[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-16 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] [NFC] [Serializer] Pack information in serializer (PR #69287)

2023-10-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 12a731b5a4cfec96ba7c72888a1d76b8e13b043e d6a724d38b67f33d97d25459564c3926d72c22dc --

[clang] [NFC] [Serializer] Pack information in serializer (PR #69287)

2023-10-16 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/69287 >From 326bc3a4a24cfd515f2673e5a01bd30b3b1bf6bc Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Mon, 16 Oct 2023 16:41:31 +0800 Subject: [PATCH] [NFC] [Serializer] Pack information in serializer Previously,

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread Fangrui Song via cfe-commits
=?utf-8?b?5YiY6Zuo5Z+5?= Message-ID: In-Reply-To: https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/69075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4b8b70a - [Clang] Fix dependence handling of nttp for variable templates (#69075)

2023-10-16 Thread via cfe-commits
Author: 刘雨培 Date: 2023-10-16T22:23:28-07:00 New Revision: 4b8b70a52fa4d133a19f620c8a9160793ded08b5 URL: https://github.com/llvm/llvm-project/commit/4b8b70a52fa4d133a19f620c8a9160793ded08b5 DIFF: https://github.com/llvm/llvm-project/commit/4b8b70a52fa4d133a19f620c8a9160793ded08b5.diff LOG:

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread Fangrui Song via cfe-commits
=?utf-8?b?5YiY6Zuo5Z+5?= Message-ID: In-Reply-To: https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/69075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [NFC] [Serializer] Pack information in serializer (PR #69287)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Chuanqi Xu (ChuanqiXu9) Changes Previously, the boolean values will occupy spaces that can contain integers. It wastes the spaces especially if the boolean values are serialized consecutively. The patch tries to pack such

[clang] [NFC] [Serializer] Pack information in serializer (PR #69287)

2023-10-16 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/69287 Previously, the boolean values will occupy spaces that can contain integers. It wastes the spaces especially if the boolean values are serialized consecutively. The patch tries to pack such consecutive

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-16 Thread Brad Smith via cfe-commits
brad0 wrote: > * renaming the current label from `GNU` to e.g. `UNIX` would be correct. That would be fine with me. https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-16 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-16 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] [Driver] Hook up Haiku PowerPC support (PR #69134)

2023-10-16 Thread Brad Smith via cfe-commits
brad0 wrote: > Does backend have any recognition of Haiku-PPC target? Can you clarify what it is you're referring to? I didn't come across anything looking around under llvm/, but I might have missed something. I was looking in clang/lib/Basic/Targets/PPC.cpp, but didn't see anything that

[clang] [clang][Interp] Check pointer inc/dec ops for null (PR #69168)

2023-10-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/69168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7bc793a - [clang][Interp] Check pointer inc/dec ops for null (#69168)

2023-10-16 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-17T06:53:33+02:00 New Revision: 7bc793a6925ccebbe21f1c98a79d6dc89a615c01 URL: https://github.com/llvm/llvm-project/commit/7bc793a6925ccebbe21f1c98a79d6dc89a615c01 DIFF: https://github.com/llvm/llvm-project/commit/7bc793a6925ccebbe21f1c98a79d6dc89a615c01.diff

[clang-tools-extra] `clangd`: support `-stdlib=` flags from `compile_commands.json`. (PR #69283)

2023-10-16 Thread Chris Carlon via cfe-commits
https://github.com/cjc25 created https://github.com/llvm/llvm-project/pull/69283 The `--stdlib` flag can affect the system headers used by `clang` during compilation. By default, `clang` will use the platform-installed C++ standard headers, but with `--stdlib=libc++`, `clang` can use headers

[clang] [Driver][DragonFly] Fixes for linker path and command-line option handling (PR #69095)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/69095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][DragonFly] Fixes for linker path and command-line option handling (PR #69095)

2023-10-16 Thread Fangrui Song via cfe-commits
@@ -56,7 +56,9 @@ void dragonfly::Linker::ConstructJob(Compilation , const JobAction , const InputInfoList , const ArgList , const char *LinkingOutput) const { -

[clang] [Driver][DragonFly] Fixes for linker path and command-line option handling (PR #69095)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-10-16 Thread via cfe-commits
goldsteinn wrote: > We should update LangRef and require that the integer arg has the size of the > pointer index type As in disallow say `ptrmask.p0.i32` on typical systems with 64-bit pointer/index? > (with current GEP semantics implying a 1-extend to pointer type width), > implement a

[clang] [Clang] Check features of tune CPU against target CPU (PR #68861)

2023-10-16 Thread Chen Zheng via cfe-commits
@@ -833,6 +833,22 @@ TargetInfo::CreateTargetInfo(DiagnosticsEngine , if (!Target->handleTargetFeatures(Opts->Features, Diags)) return nullptr; + // If TuneCPU is set, check if it contains all instruction sets needed by + // current feature map. + if

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2023-10-16 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?=

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread via cfe-commits
https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/69075 From 92e0cef2941d45bde9e08698ded277f8bf6ac04a Mon Sep 17 00:00:00 2001 From: letrec Date: Sun, 8 Oct 2023 00:44:11 +0800 Subject: [PATCH 1/3] Fix dependence handling for variable templates ---

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Qiu Chaofan via cfe-commits
@@ -2420,11 +2420,11 @@ command line. The current set of options correspond to the existing "subtarget features" for the target with or without a "-mno-" in front corresponding to the absence -of the feature, as well as ``arch="CPU"`` which will change the default "CPU" -for

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Qiu Chaofan via cfe-commits
@@ -2420,11 +2420,11 @@ command line. The current set of options correspond to the existing "subtarget features" for the target with or without a "-mno-" in front corresponding to the absence -of the feature, as well as ``arch="CPU"`` which will change the default "CPU" -for

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2023-10-16 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,65 @@ +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -std=c++20 -emit-obj -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %t/main.cpp -o %t/main.o vgvassilev wrote: I thought this is a frontend issue --

[clang] Fix crash with modules and constexpr destructor (PR #69076)

2023-10-16 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,65 @@ +// RUN: rm -rf %t +// RUN: mkdir %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -std=c++20 -emit-obj -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %t/main.cpp -o %t/main.o + +//--- V.h +#ifndef V_H +#define V_H + +class A { +public: + constexpr

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2023-10-16 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/68846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2023-10-16 Thread A. Jiang via cfe-commits
frederick-vs-ja wrote: @Endilll Thanks for notification! P2280 was already handled, while P2156 was previously missed. @cor3ntin I've add the DR status to P2156R1 and force-pushed. https://github.com/llvm/llvm-project/pull/68846 ___ cfe-commits

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2023-10-16 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja updated https://github.com/llvm/llvm-project/pull/68846 >From 00dec85aabcbd2e93fa80aed7b21f7ce02aab589 Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Tue, 17 Oct 2023 10:41:18 +0800 Subject: [PATCH] [Docs][Clang] DR status in cxx_status.html ---

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-16 Thread Craig Topper via cfe-commits
@@ -476,6 +524,31 @@ class GetFTypeInfo { !eq(Scalar, f64) : "FPR64"); } +multiclass VPatVMACC info_pairs, ValueType vec_m1> { + foreach pair = info_pairs in { +defvar VdInfo = pair.Wti; +defvar Vs2Info = pair.Vti; +let Predicates =

[clang] [X86] Support -march=pantherlake, clearwaterforest (PR #69277)

2023-10-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ce9eaf0360d9f528ab061bcdbcf81c5b2155f098 9e673f332b8f7a3cfdeb1a73f6a77aee651f7664 --

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-16 Thread Craig Topper via cfe-commits
@@ -558,6 +558,12 @@ DecodeStatus RISCVDisassembler::getInstruction(MCInst , uint64_t , "XTHeadVdot custom opcode table"); TRY_TO_DECODE_FEATURE(RISCV::FeatureVendorXSfvcp, DecoderTableXSfvcp32, "SiFive VCIX custom

[clang] ce9eaf0 - Revert "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (#68379)"

2023-10-16 Thread Antonio Abbatangelo via cfe-commits
Author: Antonio Abbatangelo Date: 2023-10-16T22:16:09-04:00 New Revision: ce9eaf0360d9f528ab061bcdbcf81c5b2155f098 URL: https://github.com/llvm/llvm-project/commit/ce9eaf0360d9f528ab061bcdbcf81c5b2155f098 DIFF:

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-16 Thread Shao-Ce SUN via cfe-commits
sunshaoce wrote: LGTM. If no one else has any objections, I think we can merge it. https://github.com/llvm/llvm-project/pull/68295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread via cfe-commits
https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/69075 From 177753fe1c81fe2ddeba949788c405f6686ebe51 Mon Sep 17 00:00:00 2001 From: letrec Date: Sun, 8 Oct 2023 00:44:11 +0800 Subject: [PATCH 1/3] Fix dependence handling for variable templates ---

[clang] [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (PR #68379)

2023-10-16 Thread via cfe-commits
antangelo wrote: I've come up with this minimal reproducer: ```cpp template struct outer { template struct inner { inner(B b); inner(const inner ) = default; }; template inner(B b) -> inner; }; outer::inner i(1); ``` The error seems to be triggered by the

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread Fangrui Song via cfe-commits
@@ -380,25 +380,25 @@ UnresolvedLookupExpr *UnresolvedLookupExpr::Create( void *Mem = Context.Allocate(Size, alignof(UnresolvedLookupExpr)); return new (Mem) UnresolvedLookupExpr(Context, NamingClass, QualifierLoc, SourceLocation(),

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread via cfe-commits
LYP951018 wrote: @erichkeane could you help me merge this PR please? I could not merge it by myself because I don't have write access to the repo https://github.com/llvm/llvm-project/pull/69075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157331: [clang] Implement C23

2023-10-16 Thread Zijun Zhao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3694697003bb: [clang] Implement C23 stdckdint.h (authored by ZijunZhao). Changed prior to commit: https://reviews.llvm.org/D157331?vs=557650=557720#toc Repository: rG LLVM Github Monorepo CHANGES

[clang] 3694697 - [clang] Implement C23

2023-10-16 Thread via cfe-commits
Author: zijunzhao Date: 2023-10-17T00:51:21Z New Revision: 3694697003bbf443fd644c6746a1c7c937657fce URL: https://github.com/llvm/llvm-project/commit/3694697003bbf443fd644c6746a1c7c937657fce DIFF: https://github.com/llvm/llvm-project/commit/3694697003bbf443fd644c6746a1c7c937657fce.diff LOG:

[clang] [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (PR #68379)

2023-10-16 Thread Paul Kirth via cfe-commits
ilovepi wrote: I think we may be seeing some issues with this patch, when building Fuchsia. We're seeing the following error. ``` FAILED: host_x64/obj/sdk/lib/ld/test/ld-unittests.filter-view-tests.cc.o ../../prebuilt/third_party/clang/custom/bin/clang++ -MD -MF

[clang] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-16 Thread via cfe-commits
HaohaiWen wrote: If no objection, I'll merge it tomorrow. https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Refactor matchFunnelShift to allow more pattern (NFC) (PR #68474)

2023-10-16 Thread via cfe-commits
HaohaiWen wrote: If no objection, I'll merge it tomorrow. https://github.com/llvm/llvm-project/pull/68474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix dependence handling of nttp for variable templates (PR #69075)

2023-10-16 Thread via cfe-commits
https://github.com/LYP951018 updated https://github.com/llvm/llvm-project/pull/69075 From 177753fe1c81fe2ddeba949788c405f6686ebe51 Mon Sep 17 00:00:00 2001 From: letrec Date: Sun, 8 Oct 2023 00:44:11 +0800 Subject: [PATCH 1/2] Fix dependence handling for variable templates ---

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-10-16 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67201 >From bdd5a67168d21fe8218f5f525921cdb9bd056c9b Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 6 Sep 2023 11:41:56 -0700 Subject: [PATCH 1/2] [libunwind][libc++][libc++abi] Add cross-compilation

[clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2023-10-16 Thread Pavel Iliin via cfe-commits
@@ -2110,6 +2110,66 @@ static bool checkFPMathBuiltinElementType(Sema , SourceLocation Loc, return false; } +/// SemaBuiltinCpuSupports - Handle __builtin_cpu_supports(char *). +/// This checks that the target supports __builtin_cpu_supports and +/// that the string

[clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2023-10-16 Thread Pavel Iliin via cfe-commits
https://github.com/ilinpv edited https://github.com/llvm/llvm-project/pull/68919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2023-10-16 Thread Pavel Iliin via cfe-commits
https://github.com/ilinpv commented: Except for the AuxTarget question, target independent part looks good to me. Thank you for the patch. https://github.com/llvm/llvm-project/pull/68919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-16 Thread Ellis Hoag via cfe-commits
@@ -0,0 +1,28 @@ +//===- MarkColdFunctions.h - *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-16 Thread Ellis Hoag via cfe-commits
@@ -1127,6 +1134,11 @@ PassBuilder::buildModuleSimplificationPipeline(OptimizationLevel Level, if (EnableSyntheticCounts && !PGOOpt) MPM.addPass(SyntheticCountsPropagation()); + if (EnableMarkColdFunctions && PGOOpt && + (PGOOpt->Action == PGOOptions::SampleUse

[clang] Enable v for RISCV64 Android (PR #69261)

2023-10-16 Thread via cfe-commits
https://github.com/enh-google approved this pull request. https://github.com/llvm/llvm-project/pull/69261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Alex Voicu (AlexVlx) Changes For certain cases (e.g. when their address is observable at run time) it is necessary to provide physical backing for non-type template parameter objects. Said backing comes in the form of a global

[clang] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

2023-10-16 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/69266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Handle template parameter objects with explicit address spaces (PR #69266)

2023-10-16 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/69266 For certain cases (e.g. when their address is observable at run time) it is necessary to provide physical backing for non-type template parameter objects. Said backing comes in the form of a global variable.

[clang] Enable v for RISCV64 Android (PR #69261)

2023-10-16 Thread via cfe-commits
https://github.com/pirama-arumuga-nainar approved this pull request. https://github.com/llvm/llvm-project/pull/69261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. I like how this centralizes everything in a single place and the def file format seems like a natural fit for the platforms. https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka updated https://github.com/llvm/llvm-project/pull/69262 >From d6a4d1cc70e7d3a13b94ff397bef8a0a75e21257 Mon Sep 17 00:00:00 2001 From: Juergen Ributzka Date: Mon, 28 Aug 2023 15:25:48 -0700 Subject: [PATCH 1/2] [llvm] Use XMACROS for MachO platforms. This change

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b225934a4b0d2944958a53269665b00e7eae4875 d6a4d1cc70e7d3a13b94ff397bef8a0a75e21257 --

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread Davide Italiano via cfe-commits
https://github.com/dcci approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enable v for RISCV64 Android (PR #69261)

2023-10-16 Thread via cfe-commits
https://github.com/hiraditya edited https://github.com/llvm/llvm-project/pull/69261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Juergen Ributzka (ributzka) Changes This change adds the PLATFORM XMACRO to simplify the addition of new MachO platforms and reduce the number of required changes. Many of the changes needed for adding a new platform are

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka created https://github.com/llvm/llvm-project/pull/69262 This change adds the PLATFORM XMACRO to simplify the addition of new MachO platforms and reduce the number of required changes. Many of the changes needed for adding a new platform are mechanical, such as adding

[clang] Enable v for RISCV64 Android (PR #69261)

2023-10-16 Thread via cfe-commits
https://github.com/hiraditya created https://github.com/llvm/llvm-project/pull/69261 None >From c3203b8f9ee863283c897f9910505e70a6181110 Mon Sep 17 00:00:00 2001 From: AdityaK <1894981+hiradi...@users.noreply.github.com> Date: Mon, 16 Oct 2023 16:01:53 -0700 Subject: [PATCH] Enable v for

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-16 Thread Owen Pan via cfe-commits
owenca wrote: > This allows git-clang-format to be used on a Windows terminal without > manually needing to find the path and invoke the python interpreter. We have > a similar script for `scan-build`. Can you open an issue and link to it from here? It seems `git clang-format` works in

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-16 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69102 >From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 15 Oct 2023 11:39:42 +0100 Subject: [PATCH 1/2] Fix #35272: Don't replace typedefs in extern c scope ---

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-16 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > For reference, can you give a couple examples of code where this is > triggering? > > If this is triggering in practice, do we want a real driver option to control > the sanitizer? The alignment attributes themselves? I am not sure we need special driver flag for that.

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-16 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69102 >From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 15 Oct 2023 11:39:42 +0100 Subject: [PATCH 1/2] Fix #35272: Don't replace typedefs in extern c scope ---

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-10-16 Thread David Li via cfe-commits
https://github.com/david-xl approved this pull request. https://github.com/llvm/llvm-project/pull/66164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix #68492: point to the correct const location (PR #69103)

2023-10-16 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69103 >From 354a8e4034afd82e6ea854848a86b9011e26269b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Fri, 13 Oct 2023 19:27:15 +0100 Subject: [PATCH 1/3] Fix #68492: point to the correct const location ---

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/69057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread Artem Dergachev via cfe-commits
@@ -492,11 +492,13 @@ void check_required_cast() { void check_cast_behavior(OSObject *obj) { OSArray *arr1 = OSDynamicCast(OSArray, obj); - clang_analyzer_eval(arr1 == obj); // expected-warning{{TRUE}} -// expected-note@-1{{TRUE}} -

[clang-tools-extra] Fix #68492: point to the correct const location (PR #69103)

2023-10-16 Thread via cfe-commits
@@ -293,6 +293,10 @@ Changes in existing checks ` check to enforce a stricter match with the swap function signature, eliminating false-positives. +- Improved :doc:`readability-const-params-in-decls EugeneZelenko wrote: Please keep alphabetical order (by

[clang] [analyzer] Trust base to derived casts for dynamic types (PR #69057)

2023-10-16 Thread Artem Dergachev via cfe-commits
@@ -392,19 +393,26 @@ void DynamicTypePropagation::checkPostCall(const CallEvent , } } -/// TODO: Handle explicit casts. -/// Handle C++ casts. -/// -/// Precondition: the cast is between ObjCObjectPointers. ExplodedNode

[clang] [clang-format] Fix a bug in mis-annotating arrows (PR #67780)

2023-10-16 Thread Owen Pan via cfe-commits
owenca wrote: See #69249. https://github.com/llvm/llvm-project/pull/67780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-10-16 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: For reference, can you give a couple examples of code where this is triggering? If this is triggering in practice, do we want a real driver option to control the sanitizer? The alignment attributes themselves? https://github.com/llvm/llvm-project/pull/69240

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/69249 >From 25e0a84bd254969fb6930001f6203d4dc56f9871 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 16 Oct 2023 13:38:09 -0700 Subject: [PATCH 1/2] [clang-format] Fix a bug in annotating TrailingReturnArrow Skip

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
@@ -3497,6 +3497,15 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine ) const { Tok->setType(TT_TrailingReturnArrow); break; } +if (Tok->isNot(TT_TrailingAnnotation)) owenca wrote: Because

[clang] [clang-format] Allow default values for template parameters in lambda (PR #69052)

2023-10-16 Thread Emilia Kond via cfe-commits
https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/69052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5f4ed78 - [clang-format] Allow default values for template parameters in lambda (#69052)

2023-10-16 Thread via cfe-commits
Author: Emilia Kond Date: 2023-10-17T00:38:33+03:00 New Revision: 5f4ed780d348c810a7d4c1dd9354abf79094364b URL: https://github.com/llvm/llvm-project/commit/5f4ed780d348c810a7d4c1dd9354abf79094364b DIFF: https://github.com/llvm/llvm-project/commit/5f4ed780d348c810a7d4c1dd9354abf79094364b.diff

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-10-16 Thread Fangrui Song via cfe-commits
MaskRay wrote: These tests just need a `--target=x86_64-linux-gnu`: which is how clang/test/Driver tests these stuff. Non-ELF platforms such as Apple, Windows, and AIX, may not support some options. Ideally we should express that the test works for every ELF platform or everything except

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Björn Schäpers via cfe-commits
@@ -3497,6 +3497,15 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine ) const { Tok->setType(TT_TrailingReturnArrow); break; } +if (Tok->isNot(TT_TrailingAnnotation)) HazardyKnusperkeks wrote: Why do you

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Björn Schäpers via cfe-commits
@@ -3497,6 +3497,15 @@ void TokenAnnotator::calculateFormattingInformation(AnnotatedLine ) const { Tok->setType(TT_TrailingReturnArrow); break; } +if (Tok->isNot(TT_TrailingAnnotation)) + continue; +const auto *Next =

[clang] [Clang] Handle real and imaginary parts of complex lvalue in `APValue::printPretty` (PR #69252)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yingwei Zheng (dtcxzyw) Changes This patch handles formatting of real and imaginary parts of complex lvalue. Fixes #69218. --- Full diff: https://github.com/llvm/llvm-project/pull/69252.diff 2 Files Affected: - (modified)

[clang] [Clang] Handle real and imaginary parts of complex lvalue in `APValue::printPretty` (PR #69252)

2023-10-16 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw created https://github.com/llvm/llvm-project/pull/69252 This patch handles formatting of real and imaginary parts of complex lvalue. Fixes #69218. >From 8f0ebe5b5cfed069c8274c0761559d6595d4dea8 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Tue, 17 Oct 2023

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-16 Thread Erich Keane via cfe-commits
erichkeane wrote: I did a force-push with the hope that it'll get the code-formatter to start recognizing what is going on, it seems to be doing some wacky things? https://github.com/llvm/llvm-project/pull/69244 ___ cfe-commits mailing list

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/69244 >From 810d49553eac0e42697283b008810cdc37971dd0 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 16 Oct 2023 13:02:14 -0700 Subject: [PATCH 1/2] [CONCEPTS]Corrected comparison of constraints with out of

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
@@ -2420,11 +2420,11 @@ command line. The current set of options correspond to the existing "subtarget features" for the target with or without a "-mno-" in front corresponding to the absence -of the feature, as well as ``arch="CPU"`` which will change the default "CPU" -for

[clang-tools-extra] [Clang] Support target attr specifying CPU (PR #68678)

2023-10-16 Thread Fangrui Song via cfe-commits
@@ -2420,11 +2420,11 @@ command line. The current set of options correspond to the existing "subtarget features" for the target with or without a "-mno-" in front corresponding to the absence -of the feature, as well as ``arch="CPU"`` which will change the default "CPU" -for

[clang-tools-extra] c5b617c - [clang-tidy][NFC] Clarify documentation for misc-definitions-in-headers

2023-10-16 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-10-16T20:50:38Z New Revision: c5b617c5e53d7af81c621d200e2cd03324538541 URL: https://github.com/llvm/llvm-project/commit/c5b617c5e53d7af81c621d200e2cd03324538541 DIFF: https://github.com/llvm/llvm-project/commit/c5b617c5e53d7af81c621d200e2cd03324538541.diff LOG:

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Skip TrailingAnnotation when looking for TrailingReturnArrow. Fixes #69234. --- Full diff: https://github.com/llvm/llvm-project/pull/69249.diff 2 Files Affected: - (modified)

[clang] [clang-format] Fix a bug in annotating TrailingReturnArrow (PR #69249)

2023-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/69249 Skip TrailingAnnotation when looking for TrailingReturnArrow. Fixes #69234. >From 25e0a84bd254969fb6930001f6203d4dc56f9871 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 16 Oct 2023 13:38:09 -0700 Subject:

[clang] [CONCEPTS]Corrected comparison of constraints with out of line CTD (PR #69244)

2023-10-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/69244 >From 021ec9d584dffc6852a777effc50843bd0facaa1 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 16 Oct 2023 13:02:14 -0700 Subject: [PATCH 1/2] [CONCEPTS]Corrected comparison of constraints with out of

[clang] b7de1d0 - [Clang][NFC] Use correct tool name for NVIDIA's 'nvlink'

2023-10-16 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-10-16T15:41:01-05:00 New Revision: b7de1d07e5298bdd97816043360ea334378f5565 URL: https://github.com/llvm/llvm-project/commit/b7de1d07e5298bdd97816043360ea334378f5565 DIFF: https://github.com/llvm/llvm-project/commit/b7de1d07e5298bdd97816043360ea334378f5565.diff

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes (PR #69242)

2023-10-16 Thread via cfe-commits
https://github.com/michaelrj-google updated https://github.com/llvm/llvm-project/pull/69242 >From 56bf257baff400189651c71a1639fbad8faa3a19 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Mon, 16 Oct 2023 19:43:21 + Subject: [PATCH 1/2] [clang-tidy] Improved

  1   2   3   4   >