[compiler-rt] [flang] [clang-tools-extra] [llvm] [libcxx] [clang] [libc] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-11-09 Thread Anton Rydahl via cfe-commits
https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/68642 >From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Mon, 9 Oct 2023 15:13:22 -0700 Subject: [PATCH 01/12] Merged __is_trivial_equality_predicate and

[llvm] [compiler-rt] [clang] [flang] [libc] [libcxx] [clang-tools-extra] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-11-09 Thread Anton Rydahl via cfe-commits
https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/68642 >From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Mon, 9 Oct 2023 15:13:22 -0700 Subject: [PATCH 01/11] Merged __is_trivial_equality_predicate and

[flang] [clang-tools-extra] [clang] [llvm] [compiler-rt] [libcxx] [BOLT] Read .rela.dyn in static non-pie binary (PR #71635)

2023-11-09 Thread Vladislav Khmelevsky via cfe-commits
https://github.com/yota9 closed https://github.com/llvm/llvm-project/pull/71635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang-tools-extra] [clang] [llvm] [compiler-rt] [libcxx] [BOLT] Read .rela.dyn in static non-pie binary (PR #71635)

2023-11-09 Thread Vladislav Khmelevsky via cfe-commits
https://github.com/yota9 edited https://github.com/llvm/llvm-project/pull/71635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a0710e1 - Revert "[clang-format] Handle variable declarations in BreakAfterAttributes (#71755)"

2023-11-09 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-11-09T23:34:06-08:00 New Revision: a0710e162dac8eb845588779deb39f2b35e5cb88 URL: https://github.com/llvm/llvm-project/commit/a0710e162dac8eb845588779deb39f2b35e5cb88 DIFF: https://github.com/llvm/llvm-project/commit/a0710e162dac8eb845588779deb39f2b35e5cb88.diff

[clang] 50a48d8 - CodeGenPGO: simplify. NFC

2023-11-09 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-11-09T23:24:51-08:00 New Revision: 50a48d8c26e8a46d2a3ce5ffdda060e851d65dc4 URL: https://github.com/llvm/llvm-project/commit/50a48d8c26e8a46d2a3ce5ffdda060e851d65dc4 DIFF: https://github.com/llvm/llvm-project/commit/50a48d8c26e8a46d2a3ce5ffdda060e851d65dc4.diff

[clang] [X86][AVX10] Permit AVX512 options/features used together with AVX10 (PR #71318)

2023-11-09 Thread Phoebe Wang via cfe-commits
phoebewang wrote: Thanks @KanRobert @e-kud https://github.com/llvm/llvm-project/pull/71318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f229ba4 - [X86][AVX10] Permit AVX512 options/features used together with AVX10 (#71318)

2023-11-09 Thread via cfe-commits
Author: Phoebe Wang Date: 2023-11-10T15:21:05+08:00 New Revision: f229ba4e8d6bb24622b2d41b3c89585cb9005d8d URL: https://github.com/llvm/llvm-project/commit/f229ba4e8d6bb24622b2d41b3c89585cb9005d8d DIFF: https://github.com/llvm/llvm-project/commit/f229ba4e8d6bb24622b2d41b3c89585cb9005d8d.diff

[clang] [X86][AVX10] Permit AVX512 options/features used together with AVX10 (PR #71318)

2023-11-09 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/71318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 557b064 - Reorder HipStdPar.h after D155856. NFC

2023-11-09 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-11-09T23:10:49-08:00 New Revision: 557b064dbfb6da837e1aa40fd481ed6e71e29f2c URL: https://github.com/llvm/llvm-project/commit/557b064dbfb6da837e1aa40fd481ed6e71e29f2c DIFF: https://github.com/llvm/llvm-project/commit/557b064dbfb6da837e1aa40fd481ed6e71e29f2c.diff

[libcxx] [libc] [clang] [clang-tools-extra] [llvm] [flang] [compiler-rt] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-11-09 Thread Anton Rydahl via cfe-commits
https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/68642 >From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Mon, 9 Oct 2023 15:13:22 -0700 Subject: [PATCH 01/10] Merged __is_trivial_equality_predicate and

[clang] [clang-tools-extra] [mlir] [lldb] [llvm] [flang] [compiler-rt] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle variable declarations in BreakAfterAttributes (PR #71755)

2023-11-09 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/71755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5c36f43 - [clang-format] Handle variable declarations in BreakAfterAttributes (#71755)

2023-11-09 Thread via cfe-commits
Author: Owen Pan Date: 2023-11-09T23:01:48-08:00 New Revision: 5c36f4332d93c6f9bd9b01a34149a635e07a00d3 URL: https://github.com/llvm/llvm-project/commit/5c36f4332d93c6f9bd9b01a34149a635e07a00d3 DIFF: https://github.com/llvm/llvm-project/commit/5c36f4332d93c6f9bd9b01a34149a635e07a00d3.diff

[clang] Llvm modules on demand bmi (PR #71773)

2023-11-09 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > > > > > > Whether we re-use wrapper code or make some new code is an > > > > > > > implementation detail. > > > > > > > It does not actually prevent you from taking the two-phase > > > > > > > approach ( currently , --precompile will be unchanged in action). > > > > > >

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/71894 >From 9202857d0100bf8a29c43472a3ce531d9afa4a2b Mon Sep 17 00:00:00 2001 From: Billy Moses Date: Thu, 9 Nov 2023 02:17:05 + Subject: [PATCH] [Clang] add user-level sizeless attribute ---

[lldb] [clang-tools-extra] [flang] [mlir] [clang] [llvm] [compiler-rt] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: The patch does not apply cleanly at HEAD. The fix-up commit `resolve conflict` contains the rebased part and a lot of unrelated changes. I think in this case, it's cleaner to squash all the commits and force push to `binary-correlate`. (Force push is fine with me:

[clang] [clang][LoongArch] Don't imply -fdirect-access-external-data for non-PIC (PR #71887)

2023-11-09 Thread Xi Ruoyao via cfe-commits
xry111 wrote: cc @MaskRay https://github.com/llvm/llvm-project/pull/71887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][LoongArch] Don't imply -fdirect-access-external-data for non-PIC (PR #71887)

2023-11-09 Thread Xi Ruoyao via cfe-commits
xry111 wrote: Suggest to add "Fixes #71645" in the message. https://github.com/llvm/llvm-project/pull/71887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Llvm modules on demand bmi (PR #71773)

2023-11-09 Thread Iain Sandoe via cfe-commits
iains wrote: > > > > > > Whether we re-use wrapper code or make some new code is an > > > > > > implementation detail. > > > > > > It does not actually prevent you from taking the two-phase approach > > > > > > ( currently , --precompile will be unchanged in action). > > > > > > > > > > > >

[lldb] [clang-tools-extra] [flang] [mlir] [clang] [llvm] [compiler-rt] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,46 @@ +// REQUIRES: linux || windows MaskRay wrote: Add `// REQUIRES: lld-available` https://github.com/llvm/llvm-project/pull/69493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[lldb] [compiler-rt] [flang] [llvm] [clang] [clang-tools-extra] [mlir] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,46 @@ +// REQUIRES: linux || windows +// Default +// RUN: %clang -o %t.normal -fprofile-instr-generate -fcoverage-mapping -fuse-ld=lld %S/Inputs/instrprof-debug-info-correlate-main.cpp %S/Inputs/instrprof-debug-info-correlate-foo.cpp +// RUN: env

[flang] [clang] [mlir] [lldb] [clang-tools-extra] [llvm] [compiler-rt] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
@@ -46,14 +73,38 @@ const char *InstrProfCorrelator::NumCountersAttributeName = "Num Counters"; llvm::Expected> InstrProfCorrelator::Context::get(std::unique_ptr Buffer, - const object::ObjectFile ) { + const

[clang-tools-extra] [clang] [lldb] [compiler-rt] [flang] [mlir] [llvm] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [llvm] [flang] [clang-tools-extra] [mlir] [lldb] [clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay commented: The comment `The data and names sections are omitted in lightweight mode.` in compiler-rt should be updated since binary correlation is different from the lightweight mode https://github.com/llvm/llvm-project/pull/69493

[compiler-rt] [lldb] [llvm] [flang] [clang] [mlir] [clang-tools-extra] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
@@ -1331,6 +1336,18 @@ static int merge_main(int argc, const char *argv[]) { "(default: 1)")); cl::ParseCommandLineOptions(argc, argv, "LLVM profile data merger\n"); + if (!DebugInfoFilename.empty() && !BinaryFilename.empty()) { +

[compiler-rt] [clang-tools-extra] [lldb] [clang] [flang] [mlir] [llvm] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,11 @@ +; RUN: opt < %s -passes=instrprof -profile-correlate=binary -S | FileCheck %s MaskRay wrote: This isn't clear how `__profd_foo` is different from `-profile-correlate=none`. This test can be added to `coverage.ll` as a new RUN line

[clang-tools-extra] [compiler-rt] [flang] [llvm] [lldb] [mlir] [clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
@@ -1331,6 +1336,18 @@ static int merge_main(int argc, const char *argv[]) { "(default: 1)")); cl::ParseCommandLineOptions(argc, argv, "LLVM profile data merger\n"); + if (!DebugInfoFilename.empty() && !BinaryFilename.empty()) { +

[clang-tools-extra] [compiler-rt] [libcxx] [libc] [flang] [llvm] [clang] [libcxx] Unifying __is_trivial_equality_predicate and __is_trivial_plus_operation into __desugars_to (PR #68642)

2023-11-09 Thread Anton Rydahl via cfe-commits
https://github.com/AntonRydahl updated https://github.com/llvm/llvm-project/pull/68642 >From f0d93cc6a5cd485c654ab38221691db038bacc7d Mon Sep 17 00:00:00 2001 From: AntonRydahl Date: Mon, 9 Oct 2023 15:13:22 -0700 Subject: [PATCH 1/9] Merged __is_trivial_equality_predicate and

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/71894 >From 5feb493573e1809ddf450948bdd3c735bb4b6ffd Mon Sep 17 00:00:00 2001 From: Billy Moses Date: Thu, 9 Nov 2023 02:17:05 + Subject: [PATCH] [Clang] add user-level sizeless attribute ---

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread William Moses via cfe-commits
@@ -2400,7 +2402,66 @@ bool Type::isWebAssemblyTableType() const { return false; } -bool Type::isSizelessType() const { return isSizelessBuiltinType(); } +bool Type::isSizelessType() const { wsmoses wrote: isIncompleteType has a recursive descent open to

[clang-tools-extra] [compiler-rt] [flang] [llvm] [lldb] [mlir] [clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
@@ -1829,6 +1833,22 @@ void CoverageMappingModuleGen::emit() { llvm::GlobalValue::InternalLinkage, NamesArrVal, llvm::getCoverageUnusedNamesVarName()); } + const StringRef

[clang-tools-extra] [llvm] [lldb] [flang] [mlir] [clang] [compiler-rt] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
@@ -1341,20 +1344,26 @@ void InstrProfiling::createDataVariable(InstrProfCntrInstBase *Inc, } auto *Data = new GlobalVariable(*M, DataTy, false, Linkage, nullptr, DataVarName); - // Reference the counter variable with a label difference (link-time - // constant).

[flang] [compiler-rt] [lldb] [clang] [llvm] [mlir] [clang-tools-extra] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
@@ -195,8 +195,14 @@ OPTIONS .. option:: --debug-info= Specify the executable or ``.dSYM`` that contains debug info for the raw profile. - When ``-debug-info-correlate`` was used for instrumentation, use this option - to correlate the raw profile. + When

[compiler-rt] [mlir] [llvm] [clang] [clang-tools-extra] [flang] [lldb] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-09 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,9 @@ +// RUN: %clang_cc1 -fprofile-instrument=clang -fcoverage-mapping -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -mllvm -profile-correlate=binary -fprofile-instrument=clang -fcoverage-mapping -emit-llvm -o - %s | FileCheck %s

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/71894 >From 4de8e238b6680540f4bc884c66430eb2974512c2 Mon Sep 17 00:00:00 2001 From: Billy Moses Date: Thu, 9 Nov 2023 02:17:05 + Subject: [PATCH 1/2] [Clang] add user-level sizeless attribute ---

[clang] Llvm modules on demand bmi (PR #71773)

2023-11-09 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > > > > Whether we re-use wrapper code or make some new code is an > > > > > implementation detail. > > > > > It does not actually prevent you from taking the two-phase approach ( > > > > > currently , --precompile will be unchanged in action). > > > > > > > > > > > > It

[clang] Llvm modules on demand bmi (PR #71773)

2023-11-09 Thread Iain Sandoe via cfe-commits
iains wrote: > > > > Whether we re-use wrapper code or make some new code is an > > > > implementation detail. > > > > It does not actually prevent you from taking the two-phase approach ( > > > > currently , --precompile will be unchanged in action). > > > > > > > > > It doesn't prevent the

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread Timm Baeder via cfe-commits
@@ -2400,7 +2402,66 @@ bool Type::isWebAssemblyTableType() const { return false; } -bool Type::isSizelessType() const { return isSizelessBuiltinType(); } +bool Type::isSizelessType() const { + // Check if this type or any of its constituents are sizeless, due to + //

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread Timm Baeder via cfe-commits
@@ -2400,7 +2402,66 @@ bool Type::isWebAssemblyTableType() const { return false; } -bool Type::isSizelessType() const { return isSizelessBuiltinType(); } +bool Type::isSizelessType() const { + // Check if this type or any of its constituents are sizeless, due to + //

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread Timm Baeder via cfe-commits
@@ -2400,7 +2402,66 @@ bool Type::isWebAssemblyTableType() const { return false; } -bool Type::isSizelessType() const { return isSizelessBuiltinType(); } +bool Type::isSizelessType() const { tbaederr wrote: The name of this function sounds like this is a

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread Timm Baeder via cfe-commits
@@ -2400,7 +2402,66 @@ bool Type::isWebAssemblyTableType() const { return false; } -bool Type::isSizelessType() const { return isSizelessBuiltinType(); } +bool Type::isSizelessType() const { + // Check if this type or any of its constituents are sizeless, due to + //

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread Timm Baeder via cfe-commits
@@ -2400,7 +2402,66 @@ bool Type::isWebAssemblyTableType() const { return false; } -bool Type::isSizelessType() const { return isSizelessBuiltinType(); } +bool Type::isSizelessType() const { + // Check if this type or any of its constituents are sizeless, due to + //

[clang] Llvm modules on demand bmi (PR #71773)

2023-11-09 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > > Whether we re-use wrapper code or make some new code is an implementation > > > detail. > > > It does not actually prevent you from taking the two-phase approach ( > > > currently , --precompile will be unchanged in action). > > > > > > It doesn't prevent the

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

2023-11-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:607 +// compiler has broken. +assert((!StartLoc || StartLoc->isValid()) && "Start location is not valid"); +assert((!EndLoc || EndLoc->isValid()) && "End location is not valid");

[clang] Llvm modules on demand bmi (PR #71773)

2023-11-09 Thread Iain Sandoe via cfe-commits
iains wrote: > > Whether we re-use wrapper code or make some new code is an implementation > > detail. > > It does not actually prevent you from taking the two-phase approach ( > > currently , --precompile will be unchanged in action). > > It doesn't prevent the two-phase compilation model

[clang] [llvm] [AIX] Enable tests relating to 64-bit XCOFF object files (PR #71814)

2023-11-09 Thread Chen Zheng via cfe-commits
https://github.com/chenzheng1030 approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/71814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AIX] Enable tests relating to 64-bit XCOFF object files (PR #71814)

2023-11-09 Thread Chen Zheng via cfe-commits
@@ -332,43 +332,6 @@ def calculate_arch_features(arch_string): config.available_features.add("llvm-driver") -def exclude_unsupported_files_for_aix(dirname): -for filename in os.listdir(dirname): -source_path = os.path.join(dirname, filename) -if

[clang] [llvm] [AIX] Enable tests relating to 64-bit XCOFF object files (PR #71814)

2023-11-09 Thread Chen Zheng via cfe-commits
https://github.com/chenzheng1030 edited https://github.com/llvm/llvm-project/pull/71814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/71894 >From 4de8e238b6680540f4bc884c66430eb2974512c2 Mon Sep 17 00:00:00 2001 From: Billy Moses Date: Thu, 9 Nov 2023 02:17:05 + Subject: [PATCH] [Clang] add user-level sizeless attribute ---

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/71894 >From 3e23febb464791a4b24ec73476ef988d2e98ca18 Mon Sep 17 00:00:00 2001 From: Billy Moses Date: Thu, 9 Nov 2023 02:17:05 + Subject: [PATCH] [Clang] add user-level sizeless attribute ---

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: William Moses (wsmoses) Changes As discussed in [this RFC](https://discourse.llvm.org/t/rfc-attribute-no-sizeof/74695) this PR implements a. new user-level sizeless attribute. This prevents types or variables marked with this attribute

[clang] [Clang] add user-level sizeless attribute (PR #71894)

2023-11-09 Thread William Moses via cfe-commits
https://github.com/wsmoses created https://github.com/llvm/llvm-project/pull/71894 As discussed in [this RFC](https://discourse.llvm.org/t/rfc-attribute-no-sizeof/74695) this PR implements a. new user-level sizeless attribute. This prevents types or variables marked with this attribute from

[clang] [clang-format] Handle variable declarations in BreakAfterAttributes (PR #71755)

2023-11-09 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/71755 >From 17921d5a1d74017128691428815ede53ac1a4d67 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 8 Nov 2023 17:55:56 -0800 Subject: [PATCH 1/2] [clang-format] Handle variable declarations in

[llvm] [clang] [AIX] Enable tests relating to 64-bit XCOFF object files (PR #71814)

2023-11-09 Thread Jake Egan via cfe-commits
@@ -332,43 +332,6 @@ def calculate_arch_features(arch_string): config.available_features.add("llvm-driver") -def exclude_unsupported_files_for_aix(dirname): -for filename in os.listdir(dirname): -source_path = os.path.join(dirname, filename) -if

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-11-09 Thread Gedare Bloom via cfe-commits
gedare wrote: > See [#66857 > (comment)](https://github.com/llvm/llvm-project/issues/66857#issuecomment-1793022188). > Can you make this a suboption, e.g. `AlignFunctionPointers`? We can add > another (e.g. `AlignConstructorsDestructors`) for ctors and dtors in the > future. Yes, I will

[clang] [clang][analyzer] Improve 'errno' handling in StdLibraryFunctionsChecker. (PR #71392)

2023-11-09 Thread via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= , =?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: https://github.com/DonatNagyE approved this pull request. LGTM, but let's wait a bit for other reviewers before merging. https://github.com/llvm/llvm-project/pull/71392

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-11-09 Thread Owen Pan via cfe-commits
https://github.com/owenca commented: See https://github.com/llvm/llvm-project/issues/66857#issuecomment-1793022188. Can you make this a suboption, e.g. `AlignFunctionPointers`? We can add another (e.g. `AlignConstructorsDestructors`) for ctors and dtors in the future.

[clang] [X86][AVX10] Permit AVX512 options/features used together with AVX10 (PR #71318)

2023-11-09 Thread Evgenii Kudriashov via cfe-commits
https://github.com/e-kud approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/71318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][LoongArch] Don't imply -fdirect-access-external-data for non-PIC (PR #71887)

2023-11-09 Thread WÁNG Xuěruì via cfe-commits
https://github.com/xen0n commented: Looks okay, although I may be missing some places. For now I don't know if recording this fact (no copy reloc support) with a helper function somewhere would help de-duplicating the logic -- it should be the case normally but I don't know where to best put

[clang] clang: Add pragma clang fp reciprocal (PR #68267)

2023-11-09 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,130 @@ +// RUN: %clang_cc1 -O3 -triple %itanium_abi_triple -emit-llvm -o - %s | FileCheck -check-prefixes=CHECK,DEFAULT %s +// RUN: %clang_cc1 -O3 -triple %itanium_abi_triple -freciprocal-math -emit-llvm -o - %s | FileCheck -check-prefixes=CHECK,FLAG %s + +float

[llvm] [clang] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-09 Thread Jun Wang via cfe-commits
@@ -1809,6 +1816,23 @@ bool SIInsertWaitcnts::shouldFlushVmCnt(MachineLoop *ML, return HasVMemLoad && UsesVgprLoadedOutside; } +bool SIInsertWaitcnts::insertWaitcntAfterMemOp(MachineFunction ) { + bool Modified = false; + + for (auto : MF) { jwanggit86

[clang] 0e7b30f - [C++20] [Modules] Enhance better diagnostic for implicit global module and module partitions

2023-11-09 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-11-10T10:58:07+08:00 New Revision: 0e7b30fa821dd4899227aa643030f4e4164f4e56 URL: https://github.com/llvm/llvm-project/commit/0e7b30fa821dd4899227aa643030f4e4164f4e56 DIFF: https://github.com/llvm/llvm-project/commit/0e7b30fa821dd4899227aa643030f4e4164f4e56.diff

[llvm] [clang] [AMDGPU] Emit a waitcnt instruction after each memory instruction (PR #68932)

2023-11-09 Thread Jun Wang via cfe-commits
https://github.com/jwanggit86 updated https://github.com/llvm/llvm-project/pull/68932 >From a87ba1892375ef67edb5d6f3bd537869203273a6 Mon Sep 17 00:00:00 2001 From: Jun Wang Date: Thu, 12 Oct 2023 16:45:59 -0500 Subject: [PATCH 1/8] [AMDGPU] Emit a waitcnt instruction after each memory

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

2023-11-09 Thread Owen Pan via Phabricator via cfe-commits
owenpan requested changes to this revision. owenpan added a comment. This revision now requires changes to proceed. In D155529#4509686 , @MyDeveloperDay wrote: > We should never make assumptions about what people do/don't use > If you have this you

[clang] [clang][LoongArch] Don't imply -fdirect-access-external-data for non-PIC (PR #71887)

2023-11-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: hev (heiher) Changes LoongArch does not and will not support copy relocation, so non-PIC code defaults to -fno-direct-access-external-data. Explicit `-fdirect-access-external-data` is acceptable, for example if the code is

[clang] [clang][LoongArch] Don't imply -fdirect-access-external-data for non-PIC (PR #71887)

2023-11-09 Thread via cfe-commits
heiher wrote: Add @xry111 @xen0n https://github.com/llvm/llvm-project/pull/71887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][LoongArch] Don't imply -fdirect-access-external-data for non-PIC (PR #71887)

2023-11-09 Thread via cfe-commits
https://github.com/heiher created https://github.com/llvm/llvm-project/pull/71887 LoongArch does not and will not support copy relocation, so non-PIC code defaults to -fno-direct-access-external-data. Explicit `-fdirect-access-external-data` is acceptable, for example if the code is

[clang] Llvm modules on demand bmi (PR #71773)

2023-11-09 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > The proposition of the patches here is (in the most common general case) to > remove the step of generating the ImplementationBMI and to pipeline the > filtering to the AST consumer that generates the Interface BMI. Agreed. This is what I want too. > Whether we re-use

[clang] [Driver][BoundsSafety] Add -fexperimental-bounds-safety flag (PR #70480)

2023-11-09 Thread Yeoul Na via cfe-commits
rapidsna wrote: > Sometimes, it is actually useful to expose some experimental features that we > don't feel comfortable surfacing as driver options as cc1 options. The cc1 > options give the users to experiment with the feature. It's the users's > responsibility to adapt when the feature

[clang] [clang][DependencyScanner] Remove all warning flags when suppressing warnings (PR #71612)

2023-11-09 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/71612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Return empty QualType when a negative array was created (PR #71552)

2023-11-09 Thread Shilei Tian via cfe-commits
https://github.com/shiltian closed https://github.com/llvm/llvm-project/pull/71552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] df2725f - [Clang][OpenMP] Return empty QualType when a negative array was created (#71552)

2023-11-09 Thread via cfe-commits
Author: Baodi Date: 2023-11-09T20:42:59-05:00 New Revision: df2725f3d55ffdc8ca2f9580183956e376a30de7 URL: https://github.com/llvm/llvm-project/commit/df2725f3d55ffdc8ca2f9580183956e376a30de7 DIFF: https://github.com/llvm/llvm-project/commit/df2725f3d55ffdc8ca2f9580183956e376a30de7.diff LOG:

[clang] [CUDA][HIP] Make template implicitly host device (PR #70369)

2023-11-09 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/70369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9774d0c - [CUDA][HIP] Make template implicitly host device (#70369)

2023-11-09 Thread via cfe-commits
Author: Yaxun (Sam) Liu Date: 2023-11-09T20:36:38-05:00 New Revision: 9774d0ce5fbd70288514da77072313b4f45b34bb URL: https://github.com/llvm/llvm-project/commit/9774d0ce5fbd70288514da77072313b4f45b34bb DIFF:

[llvm] [clang-tools-extra] [mlir] [flang] [clang] [compiler-rt] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

2023-11-09 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/69266 >From ded7435220d2c3527c4798d1b328a5f2940e279a Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 16 Oct 2023 22:43:55 +0100 Subject: [PATCH 1/3] Handle trying to bind a generic reference to a template

[llvm] [clang] [AIX] Enable tests relating to 64-bit XCOFF object files (PR #71814)

2023-11-09 Thread Chen Zheng via cfe-commits
@@ -332,43 +332,6 @@ def calculate_arch_features(arch_string): config.available_features.add("llvm-driver") -def exclude_unsupported_files_for_aix(dirname): -for filename in os.listdir(dirname): -source_path = os.path.join(dirname, filename) -if

[clang] [Driver][BoundsSafety] Add -fexperimental-bounds-safety flag (PR #70480)

2023-11-09 Thread Yeoul Na via cfe-commits
rapidsna wrote: > However, implementing the checking in clang/lib/Driver is much more common. > clang/lib/Frontend/CompilerInvocation.cpp has some checking, but the majority > is in clang/lib/Driver. @MaskRay To be clear, the check is now in Driver as you suggested. It's just that the

[clang] [Driver][BoundsSafety] Add -fexperimental-bounds-safety flag (PR #70480)

2023-11-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: It depends whether an option leads to a warning or is silently ignored for a language that is not implemented. Many options are silently ignored. For example, -faligned-new and -fexceptions are silently ignored. Sometimes, it is useful report a warning/error to prevent misuses.

[clang] [clang] Remove fixed point arithmetic error (PR #71884)

2023-11-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ea89965b3cfcb00a08941780da45c663cb4a6cab b1263d73347612acd2109a88c1188054e29e0082 --

[clang] [CodeGen] -fsanitize=alignment: add cl::opt sanitize-alignment-builtin to disable memcpy instrumentation (PR #69240)

2023-11-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: I plan to revert this workaround soon. https://github.com/llvm/llvm-project/pull/69240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove fixed point arithmetic error (PR #71884)

2023-11-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (PiJoules) Changes Prior to this, clang would always report ``` compile with '-ffixed-point' to enable fixed point types ``` whenever it sees `_Accum`, `_Fract`, or `_Sat` when fixed point arithmetic is not enabled. This can break

[clang] [clang] Remove fixed point arithmetic error (PR #71884)

2023-11-09 Thread via cfe-commits
https://github.com/PiJoules created https://github.com/llvm/llvm-project/pull/71884 Prior to this, clang would always report ``` compile with '-ffixed-point' to enable fixed point types ``` whenever it sees `_Accum`, `_Fract`, or `_Sat` when fixed point arithmetic is not enabled. This can

[mlir] [clang] [flang] [clang-tools-extra] [llvm] [compiler-rt] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

2023-11-09 Thread Alex Voicu via cfe-commits
AlexVlx wrote: Gentle ping. https://github.com/llvm/llvm-project/pull/69266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [llvm] [clang] [flang] [clang-tools-extra] [mlir] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

2023-11-09 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/69266 >From ded7435220d2c3527c4798d1b328a5f2940e279a Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 16 Oct 2023 22:43:55 +0100 Subject: [PATCH 1/2] Handle trying to bind a generic reference to a template

[compiler-rt] [llvm] [clang] [flang] [clang-tools-extra] [mlir] [clang][CodeGen] Handle template parameter objects with explicit address spaces (PR #69266)

2023-11-09 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/69266 >From ded7435220d2c3527c4798d1b328a5f2940e279a Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 16 Oct 2023 22:43:55 +0100 Subject: [PATCH] Handle trying to bind a generic reference to a template parameter

[clang] [X86][AVX10] Permit AVX512 options/features used together with AVX10 (PR #71318)

2023-11-09 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/71318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

2023-11-09 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3970-4009 if (Left.is(tok::l_paren) || Right.is(tok::r_paren)) { if (Right.is(TT_CastRParen) || (Left.MatchingParen && Left.MatchingParen->is(TT_CastRParen))) { return

[clang] [clang][deps] Skip writing `DIAG_PRAGMA_MAPPINGS` record (PR #70874)

2023-11-09 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/70874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix WebKit static analyzers to support ref and deref methods to be defined on different classes. (PR #69985)

2023-11-09 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: Yes, it would be great if you can merge the change now that I've addressed your nits. https://github.com/llvm/llvm-project/pull/69985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][deps] Skip writing `DIAG_PRAGMA_MAPPINGS` record (PR #70874)

2023-11-09 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/70874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

2023-11-09 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/71780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Skip writing `DIAG_PRAGMA_MAPPINGS` record (PR #70874)

2023-11-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/70874.diff 3 Files Affected: - (modified) clang/include/clang/Lex/HeaderSearchOptions.h (+7-1) - (modified)

[clang] [clang][deps] Skip writing `DIAG_PRAGMA_MAPPINGS` record (PR #70874)

2023-11-09 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 ready_for_review https://github.com/llvm/llvm-project/pull/70874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Skip writing `DIAG_PRAGMA_MAPPINGS` record (PR #70874)

2023-11-09 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/70874 >From 450c5adeb3ddc5bf7e01fcbe379c37b08d4de9d1 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Tue, 31 Oct 2023 16:35:38 -0700 Subject: [PATCH] [clang][deps] Skip writing `DIAG_PRAGMA_MAPPINGS` record ---

[clang] Fix WebKit static analyzers to support ref and deref methods to be defined on different classes. (PR #69985)

2023-11-09 Thread Ryosuke Niwa via cfe-commits
@@ -77,14 +77,53 @@ class RefCntblBaseVirtualDtorChecker (AccSpec == AS_none && RD->isClass())) return false; - std::optional RefCntblBaseRD = isRefCountable(Base); - if (!RefCntblBaseRD || !(*RefCntblBaseRD)) + auto

[clang] Fix WebKit static analyzers to support ref and deref methods to be defined on different classes. (PR #69985)

2023-11-09 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/69985 >From bf169f3d79f8a5b0658d9e060ddd6c3e773b979a Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 23 Oct 2023 16:38:10 -0700 Subject: [PATCH] Fix WebKit static analyzers to support ref and deref methods to be

[clang] [Clang][BPF] Add __bpf_cpu_version__ macro (PR #71856)

2023-11-09 Thread via cfe-commits
https://github.com/yonghong-song updated https://github.com/llvm/llvm-project/pull/71856 >From fd2b39e869cf3b8395113bac409486cc052ca749 Mon Sep 17 00:00:00 2001 From: Yonghong Song Date: Thu, 9 Nov 2023 15:16:03 -0800 Subject: [PATCH] [Clang][BPF] Add __bpf_cpu_version__ macro Sometimes bpf

[clang] [Clang] Correct handling of negative and out-of-bounds indices (PR #71877)

2023-11-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Bill Wendling (bwendling) Changes GCC returns 0 for a negative index on an array in a structure. It also returns 0 for an array index that goes beyond the extent of the array. In addition. a pointer to a

[clang] [Clang] Correct handling of negative and out-of-bounds indices (PR #71877)

2023-11-09 Thread Bill Wendling via cfe-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/71877 GCC returns 0 for a negative index on an array in a structure. It also returns 0 for an array index that goes beyond the extent of the array. In addition. a pointer to a struct field returns that field's size,

  1   2   3   4   >