[llvm] [clang-tools-extra] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-18 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: I believe this is ready to go now. All the tests have been converted to lit-style tests and everything has been wired up into a `check-mlgo-utils` CMake target. I talked with Mircea about the absl dependency. It's not in the tests anymore and the plan is to refactor in

[llvm] [clang] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Bhuminjay Soni via cfe-commits
11happy wrote: **Updates of Recent Commit:** - Incorporated all the naming and formatting suggestions by @5chmidti - Thanks @felix642 for such a great insight on testcases, actually those two you suggested were actually getting flagged when they shouldn't ,added changes so that they don't get

[clang] [llvm] Adding support of AMDLIBM vector library (PR #78560)

2024-01-18 Thread Phoebe Wang via cfe-commits
@@ -3190,10 +3190,10 @@ def fno_experimental_isel : Flag<["-"], "fno-experimental-isel">, Group, - Values<"Accelerate,libmvec,MASSV,SVML,SLEEF,Darwin_libsystem_m,ArmPL,none">, + Values<"Accelerate,libmvec,MASSV,SVML,SLEEF,Darwin_libsystem_m,ArmPL,AMDLIBM,none">,

[clang] [llvm] Adding support of AMDLIBM vector library (PR #78560)

2024-01-18 Thread Phoebe Wang via cfe-commits
@@ -129,7 +129,8 @@ class TargetLibraryInfoImpl { MASSV,// IBM MASS vector library. SVML, // Intel short vector math library. SLEEFGNUABI, // SLEEF - SIMD Library for Evaluating Elementary Functions. -ArmPL// Arm Performance

[llvm] [clang] Adding support of AMDLIBM vector library (PR #78560)

2024-01-18 Thread Phoebe Wang via cfe-commits
@@ -1279,6 +1281,213 @@ void TargetLibraryInfoImpl::addVectorizableFunctionsFromVecLib( } break; } + case AMDLIBM: { +#define FIXED(NL) ElementCount::getFixed(NL) +const VecDesc VecFuncs[] = { phoebewang wrote: Move them to `VecFuncs.def`?

[clang-tools-extra] [clang-apply-replacements] Deduplicate Implementation of `collectReplacementsFromDirectory` (NFC) (PR #78630)

2024-01-18 Thread Daniil Dudkin via cfe-commits
https://github.com/unterumarmung updated https://github.com/llvm/llvm-project/pull/78630 >From 1951badf6ba8302da1431747412edf960f53b0b1 Mon Sep 17 00:00:00 2001 From: Daniil Dudkin Date: Fri, 19 Jan 2024 00:41:03 +0300 Subject: [PATCH] [clang-apply-replacements] Deduplicate Implementation of

[flang] [lldb] [libcxxabi] [lld] [llvm] [libcxx] [clang] [polly] [clang-tools-extra] [libc] [mlir] [openmp] [compiler-rt] [libunwind] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

2024-01-18 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov converted_to_draft https://github.com/llvm/llvm-project/pull/77967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 407db48 - [Release Notes] [C++20] [Modules] Summarize modules related change to the release note for clang 18

2024-01-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-01-19T15:26:22+08:00 New Revision: 407db48eb4d387ae272bfbef9b12868806f1e830 URL: https://github.com/llvm/llvm-project/commit/407db48eb4d387ae272bfbef9b12868806f1e830 DIFF: https://github.com/llvm/llvm-project/commit/407db48eb4d387ae272bfbef9b12868806f1e830.diff

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

2024-01-18 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 498e1c2 - [coroutine] Create coroutine body in the correct eval context (#78589)

2024-01-18 Thread via cfe-commits
Author: Utkarsh Saxena Date: 2024-01-19T08:23:25+01:00 New Revision: 498e1c2257da552abc58aa75f6b9f776bf826f86 URL: https://github.com/llvm/llvm-project/commit/498e1c2257da552abc58aa75f6b9f776bf826f86 DIFF:

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/78675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 461679f - [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (#78675)

2024-01-18 Thread via cfe-commits
Author: Craig Topper Date: 2024-01-18T23:15:24-08:00 New Revision: 461679f2925220f350c6bafb2d661c309c5e3ae8 URL: https://github.com/llvm/llvm-project/commit/461679f2925220f350c6bafb2d661c309c5e3ae8 DIFF: https://github.com/llvm/llvm-project/commit/461679f2925220f350c6bafb2d661c309c5e3ae8.diff

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/78675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-18 Thread Lu Weining via cfe-commits
https://github.com/SixWeining approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/78664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread Alex Bradbury via cfe-commits
https://github.com/asb approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/78675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] RISCV vector calling convention (1/2) (PR #77560)

2024-01-18 Thread Kito Cheng via cfe-commits
https://github.com/kito-cheng edited https://github.com/llvm/llvm-project/pull/77560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] Adding support of AMDLIBM vector library (PR #78560)

2024-01-18 Thread Rohit Aggarwal via cfe-commits
rohitaggarwal007 wrote: @florianhumblot @alexey-bataev @RKSimon @phoebewang Please review the pull request. https://github.com/llvm/llvm-project/pull/78560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] [openmp] [clang] [mlir] [lldb] [compiler-rt] [clang-tools-extra] [lld] [llvm] [libc] [flang] [libc++][memory] P2868R1: Removing deprecated typedef `std::allocator::is_always_equal` (PR #78562

2024-01-18 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov updated https://github.com/llvm/llvm-project/pull/78562 >From fadaafbf791d5fe78f6ac9ee3494b128339781ba Mon Sep 17 00:00:00 2001 From: Zingam Date: Thu, 18 Jan 2024 09:47:40 +0200 Subject: [PATCH 1/6] [libc++][memory] P2868R1 - Removing deprecated typedef

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/78675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Craig Topper (topperc) Changes This file has sections for non-experimental and experimental extensions, but we keep forgetting to move things when we change the extension status. --- Patch is 23.54 KiB, truncated to 20.00 KiB below,

[clang] [RISCV] Re-order riscv-target-features.c to put non-experimental extensions together. (PR #78675)

2024-01-18 Thread Craig Topper via cfe-commits
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/78675 This file has sections for non-experimental and experimental extensions, but we keep forgetting to move things when we change the extension status. >From 55bd10f35b217161cfeb13b8798e584ece0b6bee Mon Sep 17

[llvm] [clang] [RISCV] Add B extension (PR #76893)

2024-01-18 Thread Wang Pengcheng via cfe-commits
wangpc-pp wrote: I will hold this PR util B extension is ratified (I think it won't take too long). Or, at least after llvm 18 branch is created. https://github.com/llvm/llvm-project/pull/76893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-18 Thread via cfe-commits
@@ -70,6 +70,8 @@ Changes to the LLVM IR * Added `llvm.exp10` intrinsic. +* Added a code model attribute for the global variable. heiher wrote: Thanks https://github.com/llvm/llvm-project/pull/78664 ___

[clang] [llvm] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-18 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/78664 >From ccb95a2f40e94ab773dd8897dd287dba7a38 Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Fri, 19 Jan 2024 11:13:39 +0800 Subject: [PATCH 1/2] [docs] Add llvm and clang release notes for the global-var code

[clang] [flang] [libc] [openmp] [lldb] [llvm] [lld] [libcxx] [clang-tools-extra] [compiler-rt] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)

2024-01-18 Thread Ethan Luis McDonough via cfe-commits
https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/76587 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/12] Add profiling functions to libomptarget

[clang] Reland "[clang] Fix CTAD for aggregates for nested template classes" (PR #78670)

2024-01-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (antangelo) Changes Reland of #78387 Use the template pattern in determining whether to synthesize the aggregate deduction guide, and update DeclareImplicitDeductionGuideFromInitList to substitute outer template arguments. The

[clang] Reland "[clang] Fix CTAD for aggregates for nested template classes" (PR #78670)

2024-01-18 Thread via cfe-commits
https://github.com/antangelo created https://github.com/llvm/llvm-project/pull/78670 Reland of #78387 Use the template pattern in determining whether to synthesize the aggregate deduction guide, and update DeclareImplicitDeductionGuideFromInitList to substitute outer template arguments. The

[lldb] [llvm] [clang] [BOLT] Fix unconditional output of boltedcollection in merge-fdata (PR #78653)

2024-01-18 Thread Davide Italiano via cfe-commits
https://github.com/dcci commented: LG https://github.com/llvm/llvm-project/pull/78653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9fec33a - Revert "[BOLT] Fix unconditional output of boltedcollection in merge-fdata (#78653)"

2024-01-18 Thread Amir Ayupov via cfe-commits
Author: Amir Ayupov Date: 2024-01-18T19:59:09-08:00 New Revision: 9fec33aadc56c8c4ad3778a92dc0aaa3201a63ae URL: https://github.com/llvm/llvm-project/commit/9fec33aadc56c8c4ad3778a92dc0aaa3201a63ae DIFF: https://github.com/llvm/llvm-project/commit/9fec33aadc56c8c4ad3778a92dc0aaa3201a63ae.diff

[clang-tools-extra] [clang] [llvm] [clang-format] Option to ignore macro definitions (PR #70338)

2024-01-18 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/70338 >From 25ca978ef9caf372997f2ebf227fb2b2ca443aa0 Mon Sep 17 00:00:00 2001 From: Tomek Paszek Date: Sat, 11 Nov 2023 19:38:00 +0100 Subject: [PATCH 01/15] Added an option to ignore macro definitions. ---

[lldb] [clang] [llvm] [BOLT] Fix unconditional output of boltedcollection in merge-fdata (PR #78653)

2024-01-18 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/78653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang] [llvm] [BOLT] Fix unconditional output of boltedcollection in merge-fdata (PR #78653)

2024-01-18 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/78653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix crash of attribute transform (PR #78088)

2024-01-18 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/78088 >From b0fcd3b278cf625845c192301e0d9c37af09c239 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 14 Jan 2024 15:07:26 +0800 Subject: [PATCH] [Clang][Sema] fix crash of attribute transform ---

[clang] [Clang][Sema] fix crash of attribute transform (PR #78088)

2024-01-18 Thread Qizhi Hu via cfe-commits
@@ -7081,10 +7085,10 @@ QualType TreeTransform::TransformAttributedType( // FIXME: dependent operand expressions? if (getDerived().AlwaysRebuild() || modifiedType != oldType->getModifiedType()) { -// TODO: this is really lame; we should really be rebuilding the

[clang] [llvm] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-18 Thread Matt Arsenault via cfe-commits
@@ -70,6 +70,8 @@ Changes to the LLVM IR * Added `llvm.exp10` intrinsic. +* Added a code model attribute for the global variable. arsenm wrote: Helpful to include link to the LangRef reference https://github.com/llvm/llvm-project/pull/78664

[clang] [llvm] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: hev (heiher) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/78664.diff 2 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+8) - (modified) llvm/docs/ReleaseNotes.rst (+4) ``diff diff --git

[clang] [llvm] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-18 Thread via cfe-commits
https://github.com/heiher created https://github.com/llvm/llvm-project/pull/78664 None >From ccb95a2f40e94ab773dd8897dd287dba7a38 Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Fri, 19 Jan 2024 11:13:39 +0800 Subject: [PATCH] [docs] Add llvm and clang release notes for the global-var code

[clang] [Clang][Sema] fix crash of attribute transform (PR #78088)

2024-01-18 Thread Qizhi Hu via cfe-commits
@@ -7081,10 +7085,10 @@ QualType TreeTransform::TransformAttributedType( // FIXME: dependent operand expressions? if (getDerived().AlwaysRebuild() || modifiedType != oldType->getModifiedType()) { -// TODO: this is really lame; we should really be rebuilding the

[clang] [Headers][X86] Add macro descriptions to ia32intrin.h (PR #78613)

2024-01-18 Thread Phoebe Wang via cfe-commits
@@ -411,13 +497,45 @@ __rdpmc(int __A) { /// \param __A ///Address of where to store the 32-bit \c IA32_TSC_AUX value. /// \returns The 64-bit value of the time stamp counter. +/// \see _rdtsc static __inline__ unsigned long long __DEFAULT_FN_ATTRS __rdtscp(unsigned int

[clang] [Headers][X86] Add macro descriptions to ia32intrin.h (PR #78613)

2024-01-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang commented: > Is _bswap (one underscore) a mistake? The [12.0 release > notes](https://releases.llvm.org/12.0.0/tools/clang/docs/ReleaseNotes.html#x86-support-in-clang) > say it has two underscores. I think single underscore is correct, it conform the difination

[clang] [Headers][X86] Add macro descriptions to ia32intrin.h (PR #78613)

2024-01-18 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/78613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Don't collect templated decls for builtin templates (PR #78466)

2024-01-18 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/78466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] e81c981 - [clangd] Don't collect templated decls for builtin templates (#78466)

2024-01-18 Thread via cfe-commits
Author: Younan Zhang Date: 2024-01-19T10:54:47+08:00 New Revision: e81c981fe35483a4b7474e110ff1b5d02bc2cb00 URL: https://github.com/llvm/llvm-project/commit/e81c981fe35483a4b7474e110ff1b5d02bc2cb00 DIFF: https://github.com/llvm/llvm-project/commit/e81c981fe35483a4b7474e110ff1b5d02bc2cb00.diff

[clang] [llvm] [lld] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-18 Thread via cfe-commits
@@ -1401,17 +1406,48 @@ void AsmPrinter::emitBBAddrMapSection(const MachineFunction ) { uint8_t BBAddrMapVersion = OutStreamer->getContext().getBBAddrMapVersion(); OutStreamer->emitInt8(BBAddrMapVersion); OutStreamer->AddComment("feature"); - auto FeaturesBits =

[lld] [libc] [llvm] [lldb] [flang] [openmp] [clang] [compiler-rt] [clang-tools-extra] [libcxx] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)

2024-01-18 Thread Ethan Luis McDonough via cfe-commits
https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/76587 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/11] Add profiling functions to libomptarget

[clang-tools-extra] [clangd] Don't collect templated decls for builtin templates (PR #78466)

2024-01-18 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/78466 >From efa5098e9ca433654ef3bc439c422867e4abee41 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Thu, 18 Jan 2024 00:15:18 +0800 Subject: [PATCH 1/2] [clangd] Don't collect templated decls for builtin templates

[clang] [llvm] [Clang] Correct __builtin_dynamic_object_size for subobject types (PR #78526)

2024-01-18 Thread Bill Wendling via cfe-commits
bwendling wrote: > Perhaps according to the GCC documentation as written. But mode 0 and 1 are > in general asking for an upper bound on the accessible bytes (that is, an N > so any.access beyond N bytes is definitely out of bounds), so it seems to me > that returning -1 is strictly worse

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-18 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > We saw some failures internally with this patch: > > * `"'absl::AnyInvocable' has different definitions in different > modules;".` > Probably related to the template arguments stability you mention. > * `"No type named 'MemberType' in 'some_object::Traits'"`. > I

[clang] [coroutine] Create coroutine body in the correct eval context (PR #78589)

2024-01-18 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/78589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang-tools-extra] [clang] [llvm] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-18 Thread Fangrui Song via cfe-commits
@@ -1,7 +1,7 @@ // RUN: %clang -x c -ffixed-point -S -emit-llvm -o - %s | FileCheck %s -// RUN: %clang -x c -ffixed-point -S -emit-llvm -o - --target=x86_64-scei-ps4-ubuntu-fast %s | FileCheck %s MaskRay wrote: @pogo59

[clang] [clang][dataflow] Treat comma operator correctly in `getResultObjectLocation()`. (PR #78427)

2024-01-18 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. This change itself looks good to me, but I start to doubt whether we actually need `getResultObjectLocation` the way it is currently implemented. One of the red flags for me seeing some `getResultObjectLocation` calls in

[llvm] [clang] [compiler-rt] [clang-tools-extra] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-18 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/78655 >From f440f44e7e270d4636ad39f4e4223c904e496d3a Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Fri, 19 Jan 2024 00:47:05 + Subject: [PATCH] Make clang report invalid target versions for all environment.

[llvm] [clang] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8947469ec1ad6d35b2feec0acc43d0d191514f0b f440f44e7e270d4636ad39f4e4223c904e496d3a --

[llvm] [clang] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-18 Thread via cfe-commits
https://github.com/ZijunZhaoCCK edited https://github.com/llvm/llvm-project/pull/78655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (ZijunZhaoCCK) Changes Followup for https://github.com/llvm/llvm-project/pull/75373 1. Make this feature not just available for android, but everyone. 2. Correct some target triples/ 3. Add opencl to the environment type list.

[llvm] [clang] Make clang report invalid target versions for all environment types. (PR #78655)

2024-01-18 Thread via cfe-commits
https://github.com/ZijunZhaoCCK edited https://github.com/llvm/llvm-project/pull/78655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Make clang report invalid target versions for all environment. (PR #78655)

2024-01-18 Thread via cfe-commits
https://github.com/ZijunZhaoCCK created https://github.com/llvm/llvm-project/pull/78655 Followup for https://github.com/llvm/llvm-project/pull/75373 1. Make this feature not just available for android, but everyone. 2. Correct some target triples/ 3. Add opencl to the environment type list.

[clang] [libcxx] [mlir] [llvm] [compiler-rt] [asan] Enable StackSafetyAnalysis by default (PR #77210)

2024-01-18 Thread via cfe-commits
NancyWang2019 wrote: @MaskRay can you help address https://github.com/llvm/llvm-project/pull/77210#issuecomment-1893860870 , test cases are failing on LoZ buildbot. Thanks https://github.com/llvm/llvm-project/pull/77210 ___ cfe-commits mailing list

[llvm] [clang] [clang-tools-extra] [compiler-rt] Re-exec TSan with no ASLR if memory layout is incompatible on Linux (PR #78351)

2024-01-18 Thread Thurston Dang via cfe-commits
https://github.com/thurstond updated https://github.com/llvm/llvm-project/pull/78351 >From 74d320657671ee64650d96cbc33fef7d414c0ec1 Mon Sep 17 00:00:00 2001 From: Thurston Dang Date: Tue, 16 Jan 2024 21:06:01 + Subject: [PATCH 1/6] Re-exec TSan with no ASLR if memory layout is

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #78127)

2024-01-18 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/78127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add readability-redundant-casting check (PR #70595)

2024-01-18 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/70595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8649328 - [RISCV] Add support for new unprivileged extensions defined in profiles spec (#77458)

2024-01-18 Thread via cfe-commits
Author: Luke Lau Date: 2024-01-19T06:57:06+07:00 New Revision: 8649328060b4e748502d1d859f9c9c1bd3c2bccc URL: https://github.com/llvm/llvm-project/commit/8649328060b4e748502d1d859f9c9c1bd3c2bccc DIFF: https://github.com/llvm/llvm-project/commit/8649328060b4e748502d1d859f9c9c1bd3c2bccc.diff

[clang] [llvm] [RISCV] Add support for new unprivileged extensions defined in profiles spec (PR #77458)

2024-01-18 Thread Luke Lau via cfe-commits
https://github.com/lukel97 closed https://github.com/llvm/llvm-project/pull/77458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake] Detect properly new linker introduced in Xcode 15 (PR #77806)

2024-01-18 Thread Eric Miotto via cfe-commits
https://github.com/edymtt updated https://github.com/llvm/llvm-project/pull/77806 >From 1530d4c137642715d11b5b8b8e2aefcb7566d7c9 Mon Sep 17 00:00:00 2001 From: Eric Miotto Date: Thu, 18 Jan 2024 15:22:35 -0800 Subject: [PATCH] [CMake] Detect properly new linker introduced in Xcode 15 As

[libunwind] [lldb] [libc] [lld] [clang-tools-extra] [compiler-rt] [llvm] [clang] [libclc] [flang] [libcxxabi] [libcxx] [RISCV] Support Global Dynamic TLSDESC in the RISC-V backend (PR #66915)

2024-01-18 Thread Paul Kirth via cfe-commits
@@ -80,6 +80,11 @@ static cl::opt EnableRISCVDeadRegisterElimination( " them with stores to x0"), cl::init(true)); +// TODO: This should be controlled by -mtls-dialect= +cl::opt EnableRISCVTLSDESC("riscv-enable-tlsdesc", ilovepi wrote:

[clang] [Driver,sanitizer] Remove RequiresPIE and msan's NeedPIE setting (PR #77689)

2024-01-18 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > > @MaskRay I see that in > > > [3bbc912](https://github.com/llvm/llvm-project/commit/3bbc912d37f03d9ad3be330b81d91c2eaf6c37f2) > > > you removed some tests that fail because of this change. Why do you > > > think that is an appropriate solution? I have some other tests in a

[clang-tools-extra] [llvm] [clang] [CGProfile] Use callee's PGO name when caller->callee is an indirect call. (PR #78610)

2024-01-18 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/78610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [CGProfile] Use callee's PGO name when caller->callee is an indirect call. (PR #78610)

2024-01-18 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks approved this pull request. https://github.com/llvm/llvm-project/pull/78610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [CGProfile] Use callee's PGO name when caller->callee is an indirect call. (PR #78610)

2024-01-18 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: I'm missing the full context behind this patch, but code seems reasonable https://github.com/llvm/llvm-project/pull/78610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [llvm] [CLANG] Add warning when INF or NAN are used in a binary operation or as function argument in fast math mode. (PR #76873)

2024-01-18 Thread Aaron Ballman via cfe-commits
@@ -2835,6 +2835,9 @@ class Preprocessor { if (Identifier.getIdentifierInfo()->isRestrictExpansion() && !SourceMgr.isInMainFile(Identifier.getLocation())) emitRestrictExpansionWarning(Identifier); + +if (Identifier.getIdentifierInfo()->getName() ==

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,132 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,132 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL commented: I still think that this should be modernize check... As it's main purpose is to change code. https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,132 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,132 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,132 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm] [clang] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
@@ -224,6 +224,13 @@ New checks Recommends the smallest possible underlying type for an ``enum`` or ``enum`` class based on the range of its enumerators. +- New :doc:`readability-use-std-min-max + ` check. + + Replaces certain conditional statements with equivalent

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,149 @@ +// RUN: %check_clang_tidy %s readability-use-std-min-max %t + +#define MY_MACRO_MIN(a, b) ((a) < (b) ? (a) : (b)) + +constexpr int myConstexprMin(int a, int b) { + return a < b ? a : b; +} + +constexpr int myConstexprMax(int a, int b) { + return a > b ? a :

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,132 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-18 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [libcxx] [mlir] [openmp] [compiler-rt] [clang-tools-extra] [flang] [libc] [lld] [llvm] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

2024-01-18 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov edited https://github.com/llvm/llvm-project/pull/76449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-apply-replacements] Deduplicate Implementation of `collectReplacementsFromDirectory` (NFC) (PR #78630)

2024-01-18 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/78630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang-tools-extra] [openmp] [llvm] [lld] [compiler-rt] [mlir] [libc] [flang] [clang] [libcxx] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

2024-01-18 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov edited https://github.com/llvm/llvm-project/pull/76449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [libcxx] [mlir] [openmp] [compiler-rt] [clang-tools-extra] [flang] [libc] [lld] [llvm] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

2024-01-18 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov edited https://github.com/llvm/llvm-project/pull/76449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC][X86] Make cpu id builtins target independent and lower for PPC (PR #68919)

2024-01-18 Thread Fangrui Song via cfe-commits
@@ -359,6 +359,13 @@ class LLVM_LIBRARY_VISIBILITY PPCTargetInfo : public TargetInfo { bool isSPRegName(StringRef RegName) const override { return RegName.equals("r1") || RegName.equals("x1"); } + + // We support __builtin_cpu_supports/__builtin_cpu_is on targets

[clang] [lldb] [libcxx] [mlir] [openmp] [compiler-rt] [clang-tools-extra] [flang] [libc] [lld] [llvm] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

2024-01-18 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov edited https://github.com/llvm/llvm-project/pull/76449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [libcxx] [mlir] [openmp] [compiler-rt] [clang-tools-extra] [flang] [libc] [lld] [llvm] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

2024-01-18 Thread Hristo Hristov via cfe-commits
@@ -144,7 +144,8 @@ _LIBCPP_HIDE_FROM_ABI decltype(auto) __visit_format_arg(_Visitor&& __vis, basic_ __libcpp_unreachable(); } -# if _LIBCPP_STD_VER >= 26 +# if _LIBCPP_STD_VER >= 26 && (!defined(_LIBCPP_COMPILER_CLANG_BASED) || _LIBCPP_CLANG_VER >= 1800)

[clang] [Headers][X86] Add macro descriptions to ia32intrin.h (PR #78613)

2024-01-18 Thread Paul T Robinson via cfe-commits
pogo59 wrote: > When a macro is merely an alternate name for an intrinsic function, does it > want to be documented as its own intrinsic function? I assume yes in this > patch, but if there's a different tactic that avoids duplicating a bunch of > descriptions, I'm open to suggestions. I

[clang] [Headers][X86] Add macro descriptions to ia32intrin.h (PR #78613)

2024-01-18 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 updated https://github.com/llvm/llvm-project/pull/78613 >From e4c9272ee9cbb918347a23d2dce14c9c12765009 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Thu, 18 Jan 2024 10:50:21 -0800 Subject: [PATCH 1/2] [Headers][X86] Add macro descriptions to ia32intrin.h These

[clang] [NFC] Add API documentation and annotations (PR #78635)

2024-01-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chris B (llvm-beanz) Changes This change adds SM 6.2 availability annotation to 16-bit APIs (16-bit types require SM 6.2), and adds Doxygen API documentation. --- Full diff: https://github.com/llvm/llvm-project/pull/78635.diff 2 Files

[clang] [NFC] Add API documentation and annotations (PR #78635)

2024-01-18 Thread Chris B via cfe-commits
https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/78635 This change adds SM 6.2 availability annotation to 16-bit APIs (16-bit types require SM 6.2), and adds Doxygen API documentation. >From 0e4a6081b17da6474b931dcf9250b001b95e23ff Mon Sep 17 00:00:00 2001 From:

[clang-tools-extra] [clang-apply-replacements] Deduplicate Implementation of `collectReplacementsFromDirectory` (NFC) (PR #78630)

2024-01-18 Thread Daniil Dudkin via cfe-commits
unterumarmung wrote: I honestly don't who should review/approve this, but hopefully the change is not complicated. https://github.com/llvm/llvm-project/pull/78630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][ExtractAPI] Ensure typedef to pointer types are preserved (PR #78584)

2024-01-18 Thread Zixu Wang via cfe-commits
https://github.com/zixu-w approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/78584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] Ensure typedef to pointer types are preserved (PR #78584)

2024-01-18 Thread Daniel Grumberg via cfe-commits
daniel-grumberg wrote: That and the typedef case before the pointer case. The pointer check would lead to extraneous desugaring in the fragments, i.e. you would get something like `struct Bar * value`, because the typedefs are also pointer types and therefore the typedef name would get

[clang] [lldb] [libcxx] [mlir] [openmp] [compiler-rt] [clang-tools-extra] [flang] [libc] [lld] [llvm] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

2024-01-18 Thread Hristo Hristov via cfe-commits
https://github.com/H-G-Hristov deleted https://github.com/llvm/llvm-project/pull/76449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang] [clang] [libcxx] [mlir] [llvm] [openmp] [libc] [lldb] [BOLT] Use continuous output addresses in delta encoding in BAT (PR #76904)

2024-01-18 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/76904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang] [clang] [libcxx] [mlir] [llvm] [openmp] [libc] [lldb] [BOLT] Use continuous output addresses in delta encoding in BAT (PR #76904)

2024-01-18 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/76904 >From 2027bc7dc00395884c3bd4da21bbb79d079293fc Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 3 Jan 2024 21:25:27 -0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=

[clang] [lldb] [libcxx] [mlir] [openmp] [clang-tools-extra] [flang] [libc] [llvm] [BOLT] Use continuous output addresses in delta encoding in BAT (PR #76904)

2024-01-18 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/76904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [libcxx] [mlir] [openmp] [compiler-rt] [clang-tools-extra] [flang] [libc] [lld] [llvm] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

2024-01-18 Thread Hristo Hristov via cfe-commits
@@ -24,14 +24,17 @@ void test(From value) { auto store = std::make_format_args(value); const std::basic_format_args format_args{store}; - std::visit_format_arg( - [v = To(value)](auto a) { -if constexpr (std::is_same_v) - assert(v == a); -

  1   2   3   4   5   6   >