[clang-tools-extra] [run-clang-tidy.py] Refactor, add progress indicator, add type hints (PR #89490)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Nicolas van Kempen (nicovank) Changes [There is work](https://discourse.llvm.org/t/rfc-upgrading-llvms-minimum-required-python-version/67571) to make Python 3.8 the minimum Python version for LLVM. I edited this script

[clang-tools-extra] [run-clang-tidy.py] Refactor, add progress indicator, add type hints (PR #89490)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Nicolas van Kempen (nicovank) Changes [There is work](https://discourse.llvm.org/t/rfc-upgrading-llvms-minimum-required-python-version/67571) to make Python 3.8 the minimum Python version for LLVM. I edited this script because I

[clang-tools-extra] [run-clang-tidy.py] Refactor, add progress indicator, add type hints (PR #89490)

2024-04-19 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank created https://github.com/llvm/llvm-project/pull/89490 [There is work](https://discourse.llvm.org/t/rfc-upgrading-llvms-minimum-required-python-version/67571) to make Python 3.8 the minimum Python version for LLVM. I edited this script because I wanted some

[clang] [clang] Allow relational comparisons between unequal pointers to `void` in constant expressions (PR #89449)

2024-04-19 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Changes to DR tests look good to me, thank you! Can you send an email to Jens Maurer asking him to mark 2526 as superseded by 2749? I'm also somewhat suspicious of the fact that we check only LHS for being `void*`, but that's what we did previously as

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

2024-04-19 Thread Troy Butler via cfe-commits
Troy-Butler wrote: I'm not sure of how it happened, but despite fetching the latest version of files, my clone/fork didn't fully update before I made this pull request, and it's causing issues that I'm not experienced enough to resolve. To be safe, I'm going to close this pull request, erase

[clang] [llvm] [mlir] Fix warning about mismatches between function parameter and call-site args names (PR #89294)

2024-04-19 Thread Troy Butler via cfe-commits
https://github.com/Troy-Butler closed https://github.com/llvm/llvm-project/pull/89294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread Troy Butler via cfe-commits
Troy-Butler wrote: I apologize - I'm not sure how this happened. I was careful to refresh my fork/clone before starting on this issue, but somehow not all of the files were updated, and now my PR requests are getting wires crossed. I think it would be safest for me to close this issue, delete

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread Troy Butler via cfe-commits
https://github.com/Troy-Butler closed https://github.com/llvm/llvm-project/pull/89480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][WIP] Add support for i64/f64 readlane, writelane and readfirstlane operations. (PR #89217)

2024-04-19 Thread Vikram Hegde via cfe-commits
vikramRH wrote: Gentle ping :) https://github.com/llvm/llvm-project/pull/89217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 22bf7c5 - [clang][Interp] Support __builtin_os_log_format_buffer_size

2024-04-19 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-04-20T06:13:32+02:00 New Revision: 22bf7c5e01e8693b2da722e1a33e69e931d6 URL: https://github.com/llvm/llvm-project/commit/22bf7c5e01e8693b2da722e1a33e69e931d6 DIFF: https://github.com/llvm/llvm-project/commit/22bf7c5e01e8693b2da722e1a33e69e931d6.diff

[clang] [clang]MveEmitter:Pass Args as const references (PR #89202)

2024-04-19 Thread via cfe-commits
aniplcc wrote: cc @RKSimon https://github.com/llvm/llvm-project/pull/89202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere requested changes to this pull request. +1 on what Cyndy said. The lldb change itself looks fine. https://github.com/llvm/llvm-project/pull/89480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [C++17] Support __GCC_[CON|DE]STRUCTIVE_SIZE (PR #89446)

2024-04-19 Thread Phoebe Wang via cfe-commits
phoebewang wrote: Sorry, I know nothing about it. But it looks to me it's to match with GCC, why don't borrow the value from GCC as a beginning? https://github.com/llvm/llvm-project/pull/89446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread Cyndy Ishida via cfe-commits
cyndyishida wrote: It appears your PR branch is based on a stale version of the target `llvm/main` branch, resulting in more commits than what this PR intended for. Please merge in the target branch and resolve any conflicts. https://github.com/llvm/llvm-project/pull/89480

[clang] [clang-format] Fix a bug in annotating CastRParen before unary && (PR #89346)

2024-04-19 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/89346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c455b46 - [clang-format] Fix a bug in annotating CastRParen before unary && (#89346)

2024-04-19 Thread via cfe-commits
Author: Owen Pan Date: 2024-04-19T20:21:43-07:00 New Revision: c455b462da70e800124ca4f453c466ea05db6033 URL: https://github.com/llvm/llvm-project/commit/c455b462da70e800124ca4f453c466ea05db6033 DIFF: https://github.com/llvm/llvm-project/commit/c455b462da70e800124ca4f453c466ea05db6033.diff

[clang] [clang][Apple][cmake] Disable plugin support at LLVM level (PR #89483)

2024-04-19 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/89483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f03cd2d - [clang][Apple][cmake] Disable plugin support at LLVM level (#89483)

2024-04-19 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-04-19T19:57:39-07:00 New Revision: f03cd2db91956456f1c5e2da86d3c50183eebd28 URL: https://github.com/llvm/llvm-project/commit/f03cd2db91956456f1c5e2da86d3c50183eebd28 DIFF: https://github.com/llvm/llvm-project/commit/f03cd2db91956456f1c5e2da86d3c50183eebd28.diff

[clang] [clang] Allow constexpr cast from `void*` in more cases (PR #89484)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (offsetof) Changes [[expr.const]/5.14](https://eel.is/c++draft/expr.const#5.14) says that constexpr cast from code*cv* void\*/code to `T*` is OK if the pointee type is similar to `T`, but Clang currently only permits the conversion

[clang] [clang] Allow constexpr cast from `void*` in more cases (PR #89484)

2024-04-19 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [clang] Allow constexpr cast from `void*` in more cases (PR #89484)

2024-04-19 Thread via cfe-commits
https://github.com/offsetof created https://github.com/llvm/llvm-project/pull/89484 [[expr.const]/5.14](https://eel.is/c++draft/expr.const#5.14) says that constexpr cast from *cv* void\* to `T*` is OK if the pointee type is similar to `T`, but Clang currently only permits the conversion if

[clang] [clang][Apple][cmake] Disable plugin support at LLVM level (PR #89483)

2024-04-19 Thread David Tellenbach via cfe-commits
https://github.com/dtellenbach approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/89483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Apple][cmake] Disable plugin support at LLVM level (PR #89483)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes Matches up with the clang setting --- Full diff: https://github.com/llvm/llvm-project/pull/89483.diff 1 Files Affected: - (modified) clang/cmake/caches/Apple-stage2.cmake (+1) ``diff diff

[clang] [clang][Apple][cmake] Disable plugin support at LLVM level (PR #89483)

2024-04-19 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida edited https://github.com/llvm/llvm-project/pull/89483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Apple][cmake] Disable plugin support at LLVM level (PR #89483)

2024-04-19 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/89483 Matches up with the clang tools >From 76ece379c8a8325b0f866a89e1de523cbeaa0c25 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Fri, 19 Apr 2024 19:34:14 -0700 Subject: [PATCH] [clang][darwin][cmake]

[clang] [ASTImporter] Fix infinite recurse on return type declared inside body (#68775) (PR #89096)

2024-04-19 Thread Ding Fei via cfe-commits
https://github.com/danix800 closed https://github.com/llvm/llvm-project/pull/89096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0ccdd4c - [ASTImporter] Fix infinite recurse on return type declared inside body (#68775)

2024-04-19 Thread via cfe-commits
Author: Ding Fei Date: 2024-04-20T10:11:02+08:00 New Revision: 0ccdd4c28fca72d1e1d518c6ed9715e92fb47edf URL: https://github.com/llvm/llvm-project/commit/0ccdd4c28fca72d1e1d518c6ed9715e92fb47edf DIFF: https://github.com/llvm/llvm-project/commit/0ccdd4c28fca72d1e1d518c6ed9715e92fb47edf.diff

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Troy Butler (Troy-Butler) Changes Addresses issue #85984 --- Full diff: https://github.com/llvm/llvm-project/pull/89480.diff 6 Files Affected: - (modified) clang/include/clang/StaticAnalyzer/Core/PathSensitive/Store.h (+2-2) -

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Troy Butler (Troy-Butler) Changes Addresses issue #85984 --- Full diff: https://github.com/llvm/llvm-project/pull/89480.diff 6 Files Affected: - (modified) clang/include/clang/StaticAnalyzer/Core/PathSensitive/Store.h (+2-2) -

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread Troy Butler via cfe-commits
https://github.com/Troy-Butler created https://github.com/llvm/llvm-project/pull/89480 Addresses issue #85984 >From fba4b0556340a00c1e059a8abdba5fdd1b0e38ea Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Mon, 25 Mar 2024 13:28:45 -0400 Subject: [PATCH 1/4] [LLVM][LIB] Refactor Redundant

[clang] Align -ffp-model=fast denormal handling with -ffast-math (PR #89477)

2024-04-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5b4ed0dc9fac9144efe74da77517dcff46e731e9 cd8df1939a456c05a1d94c471627fc5a7a332fc1 --

[clang] Align -ffp-model=fast denormal handling with -ffast-math (PR #89477)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This is an attempt to better align the denormal handling of -ffp-model=fast with the behavior of -ffast-math. The clang user's manual claims that -ffp-model=fast "behaves identically to specifying both

[clang] Align -ffp-model=fast denormal handling with -ffast-math (PR #89477)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Andy Kaylor (andykaylor) Changes This is an attempt to better align the denormal handling of -ffp-model=fast with the behavior of -ffast-math. The clang user's manual claims that -ffp-model=fast "behaves identically to specifying

[clang] Align -ffp-model=fast denormal handling with -ffast-math (PR #89477)

2024-04-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/89477 This is an attempt to better align the denormal handling of -ffp-model=fast with the behavior of -ffast-math. The clang user's manual claims that -ffp-model=fast "behaves identically to specifying both

[clang] [BoundsSafety] WIP: Make 'counted_by' work for pointer fields; late parsing for 'counted_by' on decl attr position (PR #87596)

2024-04-19 Thread Dan Liew via cfe-commits
delcypher wrote: The implementation of the experimental late attribute changed (#88596) so I've rebased this PR on it and fixed it up to work as intended. https://github.com/llvm/llvm-project/pull/87596 ___ cfe-commits mailing list

[clang] [Attributes] Support Attributes being declared as supporting an experimental late parsing mode "extension" (PR #88596)

2024-04-19 Thread Dan Liew via cfe-commits
delcypher wrote: @rapidsna I've re-implemented this patch with the new semantics that we discussed offline. I have also reworked #87596 to use this new implementation. https://github.com/llvm/llvm-project/pull/88596 ___ cfe-commits mailing list

[clang] [Attributes] Support Attributes being declared as supporting an experimental late parsing mode "extension" (PR #88596)

2024-04-19 Thread Dan Liew via cfe-commits
https://github.com/delcypher updated https://github.com/llvm/llvm-project/pull/88596 >From b859cf056df24daa85f3fd305ef56f32e0f266ed Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Fri, 12 Apr 2024 17:36:19 -0700 Subject: [PATCH] [Attributes] Support Attributes being declared as supporting an

[clang] [Attributes] Support Attributes being declared as supporting an experimental late parsing mode "extension" (PR #88596)

2024-04-19 Thread Dan Liew via cfe-commits
https://github.com/delcypher edited https://github.com/llvm/llvm-project/pull/88596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ttributes] Support Attributes being declared as supporting an "extended" late parsing mode (PR #88596)

2024-04-19 Thread Dan Liew via cfe-commits
https://github.com/delcypher edited https://github.com/llvm/llvm-project/pull/88596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ttributes] Support Attributes being declared as supporting an "extended" late parsing mode (PR #88596)

2024-04-19 Thread Dan Liew via cfe-commits
https://github.com/delcypher updated https://github.com/llvm/llvm-project/pull/88596 >From ec02422a6e2f3460c5606a52a04ba8f5b89b802f Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Fri, 12 Apr 2024 17:36:19 -0700 Subject: [PATCH] [Attributes] Support Attributes being declared as supporting an

[clang] ttributes] Support Attributes being declared as supporting an "extended" late parsing mode (PR #88596)

2024-04-19 Thread Dan Liew via cfe-commits
https://github.com/delcypher edited https://github.com/llvm/llvm-project/pull/88596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Attributes] Support Attributes being declared as only supporting late parsing when passing an experimental feature flag (PR #88596)

2024-04-19 Thread Dan Liew via cfe-commits
https://github.com/delcypher edited https://github.com/llvm/llvm-project/pull/88596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Attributes] Support Attributes being declared as only supporting late parsing when passing an experimental feature flag (PR #88596)

2024-04-19 Thread Dan Liew via cfe-commits
https://github.com/delcypher updated https://github.com/llvm/llvm-project/pull/88596 >From 24ea6b9306e0da81b956718590bff3c3cfb9124c Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Fri, 12 Apr 2024 17:36:19 -0700 Subject: [PATCH] [Attributes] Support Attributes being declared as supporting an

[clang] [BoundsSafety] WIP: Make 'counted_by' work for pointer fields; late parsing for 'counted_by' on decl attr position (PR #87596)

2024-04-19 Thread Dan Liew via cfe-commits
https://github.com/delcypher updated https://github.com/llvm/llvm-project/pull/87596 >From 24ea6b9306e0da81b956718590bff3c3cfb9124c Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Fri, 12 Apr 2024 17:36:19 -0700 Subject: [PATCH 1/2] [Attributes] Support Attributes being declared as supporting

[clang] [clang] CTAD: Fix require-clause is not transformed. (PR #89378)

2024-04-19 Thread Mehdi Amini via cfe-commits
joker-eph wrote: This seems to have broken the bot: https://github.com/llvm/llvm-project/pull/89476 (you should have had an email?) I reverted in https://github.com/llvm/llvm-project/pull/89476 https://github.com/llvm/llvm-project/pull/89378 ___

[clang] Revert "[clang] CTAD: Fix require-clause is not transformed." (PR #89476)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mehdi Amini (joker-eph) Changes Reverts llvm/llvm-project#89378 Broke the windows premerge checks https://lab.llvm.org/buildbot/#/builders/271/builds/6788 --- Full diff: https://github.com/llvm/llvm-project/pull/89476.diff 4 Files

[clang] Revert "[clang] CTAD: Fix require-clause is not transformed." (PR #89476)

2024-04-19 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/89476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b48ea2d - Revert "[clang] CTAD: Fix require-clause is not transformed." (#89476)

2024-04-19 Thread via cfe-commits
Author: Mehdi Amini Date: 2024-04-20T02:34:50+02:00 New Revision: b48ea2d394911efcc56880fde58f806282db1e8a URL: https://github.com/llvm/llvm-project/commit/b48ea2d394911efcc56880fde58f806282db1e8a DIFF: https://github.com/llvm/llvm-project/commit/b48ea2d394911efcc56880fde58f806282db1e8a.diff

[clang] Revert "[clang] CTAD: Fix require-clause is not transformed." (PR #89476)

2024-04-19 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/89476 Reverts llvm/llvm-project#89378 Broke the windows premerge checks https://lab.llvm.org/buildbot/#/builders/271/builds/6788 >From 7897826aa7931ffc854a88b20e5ab8bf976ad093 Mon Sep 17 00:00:00 2001 From: Mehdi

[clang] [clang] Fix self-capturing `__block` variables (PR #89475)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: None (ille-apple) Changes This is an updated version of https://reviews.llvm.org/D90434 from 2020. Due to time constraints I stopped working on the patch, and unfortunately never got back around to it until now. Clang

[clang] [clang] Fix self-capturing `__block` variables (PR #89475)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (ille-apple) Changes This is an updated version of https://reviews.llvm.org/D90434 from 2020. Due to time constraints I stopped working on the patch, and unfortunately never got back around to it until now. Clang special-cases

[clang] [clang] Fix self-capturing `__block` variables (PR #89475)

2024-04-19 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] [clang] Fix self-capturing `__block` variables (PR #89475)

2024-04-19 Thread via cfe-commits
https://github.com/ille-apple created https://github.com/llvm/llvm-project/pull/89475 This is an updated version of https://reviews.llvm.org/D90434 from 2020. Due to time constraints I stopped working on the patch, and unfortunately never got back around to it until now. Clang special-cases

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-04-19 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa edited https://github.com/llvm/llvm-project/pull/89425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-04-19 Thread YunQiang Su via cfe-commits
@@ -28,6 +28,19 @@ if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) if (NOT LLVM_RUNTIMES_BUILD) load_llvm_config() endif() + if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) +set(print_target_triple ${CMAKE_CXX_COMPILER}

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-04-19 Thread YunQiang Su via cfe-commits
@@ -28,6 +28,19 @@ if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) if (NOT LLVM_RUNTIMES_BUILD) load_llvm_config() endif() + if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) wzssyqa wrote: With my patch, `libclang_rt.builtin` has been

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-04-19 Thread YunQiang Su via cfe-commits
@@ -181,6 +181,20 @@ message(STATUS "LLVM default target triple: ${LLVM_DEFAULT_TARGET_TRIPLE}") set(LLVM_TARGET_TRIPLE "${LLVM_DEFAULT_TARGET_TRIPLE}") +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(print_target_triple ${CMAKE_CXX_COMPILER}

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-04-19 Thread YunQiang Su via cfe-commits
@@ -142,7 +142,7 @@ if(WIN32 OR LLVM_WINSYSROOT) set(RUNTIMES_${target}_CMAKE_MODULE_LINKER_FLAGS ${WINDOWS_LINK_FLAGS} CACHE STRING "") endif() -foreach(target

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-04-19 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa requested changes to this pull request. https://github.com/llvm/llvm-project/pull/89425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-04-19 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa edited https://github.com/llvm/llvm-project/pull/89425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [CMake] Use Clang to infer the target triple (PR #89425)

2024-04-19 Thread YunQiang Su via cfe-commits
wzssyqa wrote: Does it really needed? https://github.com/llvm/llvm-project/pull/89425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 7fcca11 - [clang-tidy] bugprone-lambda-function-name ignore macro in captures (#89076)

2024-04-19 Thread via cfe-commits
Author: Congcong Cai Date: 2024-04-20T07:45:20+08:00 New Revision: 7fcca112034f55c26e943c13fd0d57adfbe96705 URL: https://github.com/llvm/llvm-project/commit/7fcca112034f55c26e943c13fd0d57adfbe96705 DIFF: https://github.com/llvm/llvm-project/commit/7fcca112034f55c26e943c13fd0d57adfbe96705.diff

[clang-tools-extra] [clang-tidy] bugprone-lambda-function-name ignore macro in captures (PR #89076)

2024-04-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/89076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix -fno-unsafe-math-optimizations behavior (PR #89473)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Andy Kaylor (andykaylor) Changes This changes the handling of -fno-unsafe-fp-math to stop having that option imply -ftrapping-math. In gcc, -fno-unsafe-math-optimizations sets -ftrapping-math, but that dependency is based on the

[clang] Fix -fno-unsafe-math-optimizations behavior (PR #89473)

2024-04-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/89473 This changes the handling of -fno-unsafe-fp-math to stop having that option imply -ftrapping-math. In gcc, -fno-unsafe-math-optimizations sets -ftrapping-math, but that dependency is based on the fact the

[clang] [Clang] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Bill Wendling via cfe-commits
@@ -930,12 +931,12 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr *E, unsigned Type, // Get the flexible array member Decl. const RecordDecl *OuterRD = nullptr; - std::string FAMName; + const FieldDecl *FAMDecl = nullptr; if (const auto *ME =

[clang] [Clang] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/89462 >From 2a6b3356a977132459bed84fb4e4add631e181cb Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 19 Apr 2024 15:06:34 -0700 Subject: [PATCH 1/2] [Clang][NFC] Improve testing for the flexible array

[clang] [Clang] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Bill Wendling via cfe-commits
bwendling wrote: A quick look at `Decl` seems like it would require adding a `PrevInContextAndBits`, which would increase the size by `sizeof(Decl *)`. I might be able to massage a way to make it work, but it's probably not worth it. https://github.com/llvm/llvm-project/pull/89462

[clang] [Clang] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Eli Friedman via cfe-commits
@@ -930,12 +931,12 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr *E, unsigned Type, // Get the flexible array member Decl. const RecordDecl *OuterRD = nullptr; - std::string FAMName; + const FieldDecl *FAMDecl = nullptr; if (const auto *ME =

[clang] [Clang] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: If you can pull it off without increasing the size of Decl, sure; not sure it's worthwhile otherwise. https://github.com/llvm/llvm-project/pull/89462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Bill Wendling via cfe-commits
bwendling wrote: Would changing the `decl_iterator` into a bidirectional iterator be acceptable? That way I could grab the last `FieldDecl` to check if it's a FAM rather than iterating through unnecessary `Decls`... https://github.com/llvm/llvm-project/pull/89462

[clang] [Clang] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Bill Wendling via cfe-commits
https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/89462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Bill Wendling via cfe-commits
bwendling wrote: > Strictly speaking, I don't think this is NFC. Consider, for example: > > ``` > struct S { > struct X { int array[1]; } x; > struct Y { int count; int array[] __attribute__((__counted_by__(count))); } > y; > }; > void f(void* __attribute__((pass_dynamic_object_size(0;

[clang] [Clang][NFC] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Strictly speaking, I don't think this is NFC. Consider, for example: ``` struct S { struct X { int array[1]; } x; struct Y { int count; int array[] __attribute__((__counted_by__(count))); } y; }; void f(void* __attribute__((pass_dynamic_object_size(0; void g(struct

[clang] [clang][modules] Allow module maps with textual headers to be non-affecting (PR #89441)

2024-04-19 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > > Is this a pre-existing issue, or did my patch change to make "each textual > > header gets a `HFI`"? > > My best understanding that your patch gave textual headers`HFI`s when the > module map was loaded, rather than when the header was included. This > shouldn't

[clang] [clang][modules] Allow module maps with textual headers to be non-affecting (PR #89441)

2024-04-19 Thread Sam McCall via cfe-commits
sam-mccall wrote: > Is this a pre-existing issue, or did my patch change to make "each textual > header gets a `HFI`"? My best understanding that your patch gave textual headers`HFI`s when the module map was loaded, rather than when the header was included. This shouldn't have mattered, but

[clang] [Clang][NFC] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Bill Wendling via cfe-commits
bwendling wrote: > Does this still work for cases where there are multiple flexible arrays? e.g. > > ``` > struct weird_protocol { > unsigned int cmd_type; > unsigned int data_len; > union { > struct cmd_one one[]; > struct cmd_two two[]; > struct cmd_three

[clang] [clang] Allow relational comparisons between unequal pointers to `void` in constant expressions (PR #89449)

2024-04-19 Thread via cfe-commits
https://github.com/offsetof edited https://github.com/llvm/llvm-project/pull/89449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Kees Cook via cfe-commits
kees wrote: Does this still work for cases where there are multiple flexible arrays? e.g. ``` struct weird_protocol { unsigned int cmd_type; unsigned int data_len; union { struct cmd_one one[]; struct cmd_two two[]; struct cmd_three three[]; unsigned

[clang] [clang][modules] Allow module maps with textual headers to be non-affecting (PR #89441)

2024-04-19 Thread Sam McCall via cfe-commits
sam-mccall wrote: > clang's headers all have proper modules now, are you sure you still need A? We can't use `clang/lib/Headers/module.modulemap`, so we need something to describe those headers. Why can't we? In our build system, it's the **build system's** job to generate modulemaps for

[clang] [Clang][NFC] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Bill Wendling (bwendling) Changes Testing for the name of the flexible array member isn't as robust as testing the FieldDecl pointers. --- Full diff: https://github.com/llvm/llvm-project/pull/89462.diff

[clang] [Clang][NFC] Improve testing for the flexible array member (PR #89462)

2024-04-19 Thread Bill Wendling via cfe-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/89462 Testing for the name of the flexible array member isn't as robust as testing the FieldDecl pointers. >From 2a6b3356a977132459bed84fb4e4add631e181cb Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 19

[clang] [clang][modules] Allow module maps with textual headers to be non-affecting (PR #89441)

2024-04-19 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > Is this a pre-existing issue, or did my patch change to make "each textual > header gets a `HFI`"? I'm not sure yet, I think we'll need to investigate [Sam's reproducer](https://github.com/llvm/llvm-project/pull/89005#issuecomment-2067300965) and consider [Richard's

[clang] [Clang] Handle structs with inner structs and no fields (PR #89126)

2024-04-19 Thread Bill Wendling via cfe-commits
@@ -826,29 +826,32 @@ const FieldDecl *CodeGenFunction::FindFlexibleArrayMemberField( ASTContext , const RecordDecl *RD, StringRef Name, uint64_t ) { const LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel = getLangOpts().getStrictFlexArraysLevel(); -

[clang] [Clang] Fix crash on invalid size in user-defined `static_assert` message (PR #89420)

2024-04-19 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/89420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Allow module maps with textual headers to be non-affecting (PR #89441)

2024-04-19 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > I updated the description of this PR, hopefully it makes more sense now. I > still need to investigate what goes wrong in > "Modules/preprocess-decluse.cpp". It seems that it assumes `%t/b.pcm` embeds > the information from "a.modulemap". Is this a pre-existing

[clang] [Clang] Fix crash on invalid size in user-defined `static_assert` message (PR #89420)

2024-04-19 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/89420 >From a64b08503ae9f49d8b58ee92c226ba19c450ca27 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Fri, 19 Apr 2024 19:13:26 +0200 Subject: [PATCH 1/2] [Clang] Fix crash on invalid size in static_assert message ---

[clang] [Clang] Update missing varargs arg extension warnings (PR #84520)

2024-04-19 Thread via cfe-commits
Sirraide wrote: Actually, a trailing comma in the macro invocation might work too. It’s been a while since I last had to deal w/ this. https://github.com/llvm/llvm-project/pull/84520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [OpenACC] Implement 'num_gangs' sema for compute constructs (PR #89460)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes num_gangs takes an 'int-expr-list', for 'parallel', and an 'int-expr' for 'kernels'. This patch changes the parsing to always parse it as an 'int-expr-list', then correct the expression count during

[clang] [OpenACC] Implement 'num_gangs' sema for compute constructs (PR #89460)

2024-04-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Erich Keane (erichkeane) Changes num_gangs takes an 'int-expr-list', for 'parallel', and an 'int-expr' for 'kernels'. This patch changes the parsing to always parse it as an 'int-expr-list', then correct the expression count

[clang] [OpenACC] Implement 'num_gangs' sema for compute constructs (PR #89460)

2024-04-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/89460 num_gangs takes an 'int-expr-list', for 'parallel', and an 'int-expr' for 'kernels'. This patch changes the parsing to always parse it as an 'int-expr-list', then correct the expression count during Sema.

[clang] [clang][modules] Allow module maps with textual headers to be non-affecting (PR #89441)

2024-04-19 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: I updated the description of this PR, hopefully it makes more sense now. I still need to investigate what goes wrong in "Modules/preprocess-decluse.cpp". It seems that it assumes `%t/b.pcm` embeds the information from "a.modulemap".

[clang] [Clang] Update missing varargs arg extension warnings (PR #84520)

2024-04-19 Thread via cfe-commits
Sirraide wrote: > @Sirraide, I noticed the following build issue when new compiler with this > change (bootstrap compiler) is being used to build one of the files for > `clangd`: > > ``` > .../clang-tools-extra/clangd/unittests/FindTargetTests.cpp:430:29: error: > passing no argument for the

[clang] [Clang] Handle structs with inner structs and no fields (PR #89126)

2024-04-19 Thread Eli Friedman via cfe-commits
@@ -826,29 +826,32 @@ const FieldDecl *CodeGenFunction::FindFlexibleArrayMemberField( ASTContext , const RecordDecl *RD, StringRef Name, uint64_t ) { const LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel = getLangOpts().getStrictFlexArraysLevel(); -

[clang] [clang][modules] Allow module maps with textual headers to be non-affecting (PR #89441)

2024-04-19 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/89441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Loop over FieldDecls instead of all Decls (PR #89453)

2024-04-19 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/89453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5bcf31e - [Clang] Loop over FieldDecls instead of all Decls (#89453)

2024-04-19 Thread via cfe-commits
Author: Bill Wendling Date: 2024-04-19T21:38:17Z New Revision: 5bcf31ebfad8b32aed20dd47be6238cc19710e63 URL: https://github.com/llvm/llvm-project/commit/5bcf31ebfad8b32aed20dd47be6238cc19710e63 DIFF: https://github.com/llvm/llvm-project/commit/5bcf31ebfad8b32aed20dd47be6238cc19710e63.diff

[clang] [llvm] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2024-04-19 Thread Steven Wu via cfe-commits
@@ -0,0 +1,25 @@ +// Check that a clang invocation can spawn and handshake with a module build daemon + +// RUN: %kill-process "-cc1modbuildd mbd-handshake" +// RUN: rm -rf mbd-handshake %t +// RUN: split-file %s %t + +//--- main.c +int main() {return 0;} + +// RUN: %clang

[clang] [clang][modules] HeaderSearch::MarkFileModuleHeader creates extra HeaderFileInfo, breaks PCM reuse (PR #89005)

2024-04-19 Thread Sam McCall via cfe-commits
sam-mccall wrote: Thanks for the pointer to 87848 - reverting that one locally doesn't help though, even in combination with applying #89005 and #89428. So this change isn't on the critical path to fixing our builds, but still much appreciated and will take a look now. --- Unsurprisingly,

[clang] [ARM64EC] Add softintrin.lib as an implicit dependency to object files. (PR #89171)

2024-04-19 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/89171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >