steakhal wrote:
Hey, do you think a regression test would be valuable?
https://github.com/llvm/llvm-project/pull/90301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
wzssyqa wrote:
Blocked by https://github.com/llvm/llvm-project/pull/89638
https://github.com/llvm/llvm-project/pull/90313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wzssyqa converted_to_draft
https://github.com/llvm/llvm-project/pull/90313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: YunQiang Su (wzssyqa)
Changes
https://discourse.llvm.org/t/rfc-baremetal-target-triple-normalization/78524
See: PR#89638.
---
Patch is 40.61 KiB, truncated to 20.00 KiB below, full version:
llvmbot wrote:
@llvm/pr-subscribers-backend-arm
Author: YunQiang Su (wzssyqa)
Changes
https://discourse.llvm.org/t/rfc-baremetal-target-triple-normalization/78524
See: PR#89638.
---
Patch is 40.61 KiB, truncated to 20.00 KiB below, full version:
https://github.com/wzssyqa created
https://github.com/llvm/llvm-project/pull/90313
https://discourse.llvm.org/t/rfc-baremetal-target-triple-normalization/78524
See: PR#89638.
>From 28b918f8a67381cd568c85bae77af517091a32b4 Mon Sep 17 00:00:00 2001
From: YunQiang Su
Date: Sat, 27 Apr 2024
https://github.com/wzssyqa edited
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/11happy approved this pull request.
LGTM.
Thank you for CCing me.
https://github.com/llvm/llvm-project/pull/90279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
> (I still need to figure out how to do proper stacked PRs...)
AFAIK, not possible unless our release manager installs e.g. [such an
application](https://github.com/marketplace/stacked-pull-requests) to the
repository; but candidly, I have never used it before so I have no idea
https://github.com/vitalybuka demilestoned
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka milestoned
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -136,6 +136,41 @@ std::string getNamespaceScope(const Decl *D) {
return "";
}
+void printDeclAndWrappers(const TypedefNameDecl *TND,
+ llvm::raw_string_ostream , PrintingPolicy PP) {
+ TND->print(OS, PP);
+ const Decl *LastPrintedDecl = TND;
+
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/89570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 commented:
Thanks for working on this! One thought from me.
https://github.com/llvm/llvm-project/pull/89570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/2] [Sema] Avoid an undesired pack expansion while
transforming
@@ -160,3 +160,22 @@ namespace GH88929 {
using E = P...[0]; // expected-error {{unknown type name 'P'}} \
// expected-error {{expected ';' after alias
declaration}}
}
+
+namespace GH88925 {
+template struct S {};
+
+template struct sequence {};
+
phoebewang wrote:
> I am curious what a `win32-elf` triple is. Does MSVC support generating ELF
> object files?
No idea, but https://github.com/llvm/llvm-project/issues/87140 doesn't look
like from fuzzing.
Consider Windows has WSL now, I'd not surprise it's supported or will be
supported
https://github.com/wzssyqa edited
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wzssyqa edited
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wzssyqa edited
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -160,3 +160,22 @@ namespace GH88929 {
using E = P...[0]; // expected-error {{unknown type name 'P'}} \
// expected-error {{expected ';' after alias
declaration}}
}
+
+namespace GH88925 {
+template struct S {};
+
+template struct sequence {};
+
https://github.com/apolloww updated
https://github.com/llvm/llvm-project/pull/90310
>From c0ba0d5b49fec06d0ca23214acc1ccef43013c01 Mon Sep 17 00:00:00 2001
From: Wei Wang
Date: Fri, 26 Apr 2024 14:47:31 -0700
Subject: [PATCH 1/2] update pipeline
---
https://github.com/wzssyqa ready_for_review
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wzssyqa updated
https://github.com/llvm/llvm-project/pull/89638
>From aafa018b3d7657483738fa91812e3e8bbdd8205a Mon Sep 17 00:00:00 2001
From: YunQiang Su
Date: Sat, 27 Apr 2024 10:55:38 +0800
Subject: [PATCH] Triple::normalize: Use none as OS for XX-none-ABI
When we parse
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f9a0b467dd3da17e9b5d3b50bff624a60dc2950c
c0ba0d5b49fec06d0ca23214acc1ccef43013c01 --
https://github.com/apolloww edited
https://github.com/llvm/llvm-project/pull/90310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apolloww edited
https://github.com/llvm/llvm-project/pull/90310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Wei Wang (apolloww)
Changes
Skip CoroSplit and CoroCleanup in pre-lto pipeline so that CoroElide can happen
after callee coroutine is imported into caller's module in ThinLTO.
---
Full diff:
https://github.com/apolloww created
https://github.com/llvm/llvm-project/pull/90310
Skip CoroSplit and CoroCleanup in pre-lto pipeline so that CoroElide can happen
after callee coroutine is imported into caller's module in ThinLTO.
>From c0ba0d5b49fec06d0ca23214acc1ccef43013c01 Mon Sep 17
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/90161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-04-26T19:54:36-07:00
New Revision: 315dc4bbc730a3c672967c27587088cfe9752fe6
URL:
https://github.com/llvm/llvm-project/commit/315dc4bbc730a3c672967c27587088cfe9752fe6
DIFF:
https://github.com/llvm/llvm-project/commit/315dc4bbc730a3c672967c27587088cfe9752fe6.diff
https://github.com/JustinStitt updated
https://github.com/llvm/llvm-project/pull/86618
>From 50e7b1039e514dacc05bb8cd9ff9a3e3df9ed24d Mon Sep 17 00:00:00 2001
From: Justin Stitt
Date: Tue, 5 Mar 2024 03:14:49 +
Subject: [PATCH 01/18] implement wraps attribute
Signed-off-by: Justin Stitt
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nikita Kniazev (Kojoley)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90308.diff
1 Files Affected:
- (modified) clang/docs/UsersManual.rst (+1-1)
``diff
diff --git a/clang/docs/UsersManual.rst
https://github.com/Kojoley created
https://github.com/llvm/llvm-project/pull/90308
None
>From 60860728ca2eb529efa46ee8ce9236cc8f6916a9 Mon Sep 17 00:00:00 2001
From: Nikita Kniazev
Date: Sat, 27 Apr 2024 05:18:32 +0300
Subject: [PATCH] [clang][docs] fix rendering issue in UsersManual.rst
---
@@ -44,15 +44,18 @@ void test_os_log_format(const char *pc, int i, void *p,
void *buf) {
}
// Test os_log_format primitive with ObjC string literal format argument.
-void test_objc(const char *pc, int i, void *p, void *buf, NSString *nss) {
+void test_objc(const char *pc,
https://github.com/ahatanak approved this pull request.
https://github.com/llvm/llvm-project/pull/89977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -44,15 +44,18 @@ void test_os_log_format(const char *pc, int i, void *p,
void *buf) {
}
// Test os_log_format primitive with ObjC string literal format argument.
-void test_objc(const char *pc, int i, void *p, void *buf, NSString *nss) {
+void test_objc(const char *pc,
@@ -4781,6 +4782,7 @@ CodeGenModule::CreateRuntimeFunction(llvm::FunctionType
*FTy, StringRef Name,
}
}
setDSOLocal(F);
+ markRegisterParameterAttributes(F);
kees wrote:
Ah-ha, thanks! Okay, I've updated the comments with just a
https://github.com/kees updated https://github.com/llvm/llvm-project/pull/89707
>From c061c8f49f2b916bb5e60ec35d3e448ac13f2b72 Mon Sep 17 00:00:00 2001
From: Kees Cook
Date: Mon, 22 Apr 2024 17:53:32 -0700
Subject: [PATCH 1/4] [CodeGen][i386] Move -mregparm storage earlier and fix
Runtime
sumit-sahrawat wrote:
@kadircet @sam-mccall kindly review
https://github.com/llvm/llvm-project/pull/90305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sumit-sahrawat updated
https://github.com/llvm/llvm-project/pull/90305
>From ca152a90259afa79ea413b8e4a21165cebcd7d5a Mon Sep 17 00:00:00 2001
From: Sumit Sahrawat <139506625+sumit-sahra...@users.noreply.github.com>
Date: Sat, 27 Apr 2024 07:02:58 +0530
Subject: [PATCH]
https://github.com/sumit-sahrawat updated
https://github.com/llvm/llvm-project/pull/90305
>From d4c734b59e6c3184d42af2b26ef50d57db662796 Mon Sep 17 00:00:00 2001
From: Sumit Sahrawat <139506625+sumit-sahra...@users.noreply.github.com>
Date: Sat, 27 Apr 2024 06:57:29 +0530
Subject: [PATCH]
https://github.com/sumit-sahrawat updated
https://github.com/llvm/llvm-project/pull/90305
>From e62ba302157d7f3576f7d2d24d90e702700c2a4d Mon Sep 17 00:00:00 2001
From: Sumit Sahrawat <139506625+sumit-sahra...@users.noreply.github.com>
Date: Sat, 27 Apr 2024 06:52:10 +0530
Subject: [PATCH]
Author: Craig Topper
Date: 2024-04-26T17:57:51-07:00
New Revision: de375fbc713b7c5cd0e3377a49f0773300203b63
URL:
https://github.com/llvm/llvm-project/commit/de375fbc713b7c5cd0e3377a49f0773300203b63
DIFF:
https://github.com/llvm/llvm-project/commit/de375fbc713b7c5cd0e3377a49f0773300203b63.diff
MaskRay wrote:
> It's LGTM, but it's going to be annoying to merge. I bet this patch has
> several reasons to be reverted, and will be reverted multiple times. It would
> be nice to try to split into smaller parts.
I agree.
It'd be nice if Chromium folks can test this before this is merged.
https://github.com/sumit-sahrawat updated
https://github.com/llvm/llvm-project/pull/90305
>From 8cde06cc546950eb9f9c6a807129d18ef5da882e Mon Sep 17 00:00:00 2001
From: Sumit Sahrawat <139506625+sumit-sahra...@users.noreply.github.com>
Date: Sat, 27 Apr 2024 06:33:17 +0530
Subject: [PATCH]
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/89992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sumit-sahrawat updated
https://github.com/llvm/llvm-project/pull/90305
>From 32039a6494c36dbd875d038ebb66196d4013c156 Mon Sep 17 00:00:00 2001
From: Sumit Sahrawat <139506625+sumit-sahra...@users.noreply.github.com>
Date: Sat, 27 Apr 2024 06:28:07 +0530
Subject: [PATCH]
https://github.com/sumit-sahrawat edited
https://github.com/llvm/llvm-project/pull/90305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sumit-sahrawat updated
https://github.com/llvm/llvm-project/pull/90305
>From b713f37e4cb9f53e66904890d0207c7b4349f2a8 Mon Sep 17 00:00:00 2001
From: Sumit Sahrawat <139506625+sumit-sahra...@users.noreply.github.com>
Date: Sat, 27 Apr 2024 06:23:43 +0530
Subject: [PATCH]
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: Sumit Sahrawat (sumit-sahrawat)
Changes
This PR makes `clangd` add a `.gitignore` file when creating index directories
(`.cache/clangd/index`), with the content `*`. This makes git repos
automatically ignore this directory.
This is
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Sumit Sahrawat (sumit-sahrawat)
Changes
This PR makes `clangd` add a `.gitignore` file when creating index directories
(`.cache/clangd/index`), with the content `*`. This makes git repos
automatically ignore this directory.
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/sumit-sahrawat created
https://github.com/llvm/llvm-project/pull/90305
This PR makes `clangd` add a `.gitignore` file when creating index directories
(`.cache/clangd/index`), with the content `*`. This makes git repos
automatically ignore this directory.
This is similar to
@@ -44,15 +44,18 @@ void test_os_log_format(const char *pc, int i, void *p,
void *buf) {
}
// Test os_log_format primitive with ObjC string literal format argument.
-void test_objc(const char *pc, int i, void *p, void *buf, NSString *nss) {
+void test_objc(const char *pc,
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/87750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vitaly Buka
Date: 2024-04-26T17:14:43-07:00
New Revision: 2e5035aeed4a9d33ab179f6e90c68fa70588c013
URL:
https://github.com/llvm/llvm-project/commit/2e5035aeed4a9d33ab179f6e90c68fa70588c013
DIFF:
https://github.com/llvm/llvm-project/commit/2e5035aeed4a9d33ab179f6e90c68fa70588c013.diff
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vitaly Buka
Date: 2024-04-26T17:14:43-07:00
New Revision: 2e5035aeed4a9d33ab179f6e90c68fa70588c013
URL:
https://github.com/llvm/llvm-project/commit/2e5035aeed4a9d33ab179f6e90c68fa70588c013
DIFF:
https://github.com/llvm/llvm-project/commit/2e5035aeed4a9d33ab179f6e90c68fa70588c013.diff
https://github.com/dyung approved this pull request.
Thanks, hopefully this revert should fix the Windows problems we are seeing.
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Eli Friedman (efriedma-quic)
Changes
There's some code in AggExprEmitter::VisitCXXParenListOrInitListExpr to try to
do early cleanup for GEPs for fields that aren't accessed. But it's unlikely to
actually save significant
https://github.com/efriedma-quic created
https://github.com/llvm/llvm-project/pull/90303
There's some code in AggExprEmitter::VisitCXXParenListOrInitListExpr to try to
do early cleanup for GEPs for fields that aren't accessed. But it's unlikely to
actually save significant compile-time, and
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ryosuke Niwa (rniwa)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90301.diff
1 Files Affected:
- (modified)
clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedCallArgsChecker.cpp (+1-1)
``diff
diff --git
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90301
None
>From 0e9d10029e6d498d3bc5a319ac0945cf23db230d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 26 Apr 2024 17:01:35 -0700
Subject: [PATCH] Fix a crash introduced by 3d5e9ab by adding a nullptr check.
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Lets revert #90299 to recover bots before the weekend.
https://github.com/llvm/llvm-project/pull/83774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3ec858bc5d45ee22ca99febd38e1ba188f71022c
b4c0a3f4835a686a15a3ed90a4058f353f844f26 --
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JustinStitt updated
https://github.com/llvm/llvm-project/pull/86618
>From 50e7b1039e514dacc05bb8cd9ff9a3e3df9ed24d Mon Sep 17 00:00:00 2001
From: Justin Stitt
Date: Tue, 5 Mar 2024 03:14:49 +
Subject: [PATCH 01/17] implement wraps attribute
Signed-off-by: Justin Stitt
llvmbot wrote:
@llvm/pr-subscribers-backend-systemz
@llvm/pr-subscribers-libcxx
Author: Vitaly Buka (vitalybuka)
Changes
https://lab.llvm.org/buildbot/#/builders/168/builds/20063
This reverts commit cf5a8b489464d09dfdd7a48ce7c8b41d3c9bf819.
---
Patch is 59.07 KiB, truncated to 20.00
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/90299
https://lab.llvm.org/buildbot/#/builders/168/builds/20063
This reverts commit cf5a8b489464d09dfdd7a48ce7c8b41d3c9bf819.
>From b4c0a3f4835a686a15a3ed90a4058f353f844f26 Mon Sep 17 00:00:00 2001
From: Vitaly
https://github.com/brandtbucher updated
https://github.com/llvm/llvm-project/pull/88333
>From f797b695ce38f46563f3724dcffee4005c65c659 Mon Sep 17 00:00:00 2001
From: Brandt Bucher
Date: Wed, 10 Apr 2024 17:03:19 -0700
Subject: [PATCH 1/2] Prefer non-volatile registers for preserve_none
Use
JustinStitt wrote:
In an effort to appease the build bot, I am adding a `-W` flag to turn of
`warn_wraps_attr_var_decl_type_not_integer` which yells at users for trying to
add `__attribute__((wraps))` to things that don't really wrap in the
traditional sense.
cyndyishida wrote:
> Overall I really like the direction of this. I'm curious if any of the
> maintainers from Apple have thoughts since they're the primary users of
> availability annotations.
While I like the approach of aligning availability parameters closer to
`llvm::Triple`, I am
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Volodymyr Sapsai (vsapsai)
Changes
There is no reason for C and Objective-C to differ from C++ in this matter.
rdar://85531830
---
Full diff: https://github.com/llvm/llvm-project/pull/90298.diff
2 Files Affected:
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Volodymyr Sapsai (vsapsai)
Changes
There is no reason for C and Objective-C to differ from C++ in this matter.
rdar://85531830
---
Full diff: https://github.com/llvm/llvm-project/pull/90298.diff
2 Files Affected:
- (modified)
https://github.com/vsapsai created
https://github.com/llvm/llvm-project/pull/90298
There is no reason for C and Objective-C to differ from C++ in this matter.
rdar://85531830
>From 8dafc9af06eef1a4b3fba8b5cffeece62967a6fd Mon Sep 17 00:00:00 2001
From: Volodymyr Sapsai
Date: Fri, 26 Apr 2024
https://github.com/JustinStitt updated
https://github.com/llvm/llvm-project/pull/86618
>From 50e7b1039e514dacc05bb8cd9ff9a3e3df9ed24d Mon Sep 17 00:00:00 2001
From: Justin Stitt
Date: Tue, 5 Mar 2024 03:14:49 +
Subject: [PATCH 01/16] implement wraps attribute
Signed-off-by: Justin Stitt
vitalybuka wrote:
It's LGTM, but it's going to be annoying to merge.
I bet this patch has several reasons to be reverted, and will be reverted
multiple times.
It would be nice to try to split into smaller parts.
https://github.com/llvm/llvm-project/pull/81677
@@ -35,6 +35,9 @@
// RUN: %p/../../../../lib/sanitizer_common/sanitizer_coverage_interface.inc
\
// RUN: | grep -e "INTERFACE_\(WEAK_\)\?FUNCTION"
\
// RUN: | grep -v "__sanitizer_weak_hook"
\
+//
dschuff wrote:
We are also seeing the Windows failure. Given that there appear to be 2
separate problems, this patch should probably be reverted rather than trying to
fix-forward.
https://github.com/llvm/llvm-project/pull/83774
___
cfe-commits
MaskRay wrote:
> This change seems to have caused a test in emscripten to starting failing
> with `argument unused during compilation: '-O2'`:
> [emscripten-core/emscripten#21841](https://github.com/emscripten-core/emscripten/pull/21841).
>
> Is that an intended side effect of this change?
@@ -4781,6 +4782,7 @@ CodeGenModule::CreateRuntimeFunction(llvm::FunctionType
*FTy, StringRef Name,
}
}
setDSOLocal(F);
+ markRegisterParameterAttributes(F);
efriedma-quic wrote:
Suggested text on the clang change:
FIXME: We should
@@ -62,6 +62,13 @@ namespace llvm {
LibFunc TheLibFunc, AttributeList AttributeList,
FunctionType *Invalid, ArgsTy... Args) = delete;
+ // Handle -mregparm for the given function.
+ // FIXME: This should likely be implemented in
+
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/89992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -249,9 +245,27 @@ GetAffectingModuleMaps(const Preprocessor , Module
*RootModule) {
for (const auto : HS.findResolvedModulesForHeader(*File))
if (const Module *M = KH.getModule())
-CollectIncludingMapsFromAncestors(M);
+
MaskRay wrote:
I am curious what a `win32-elf` triple is. Does MSVC support generating ELF
object files?
https://github.com/llvm/llvm-project/pull/87149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaskRay wrote:
For driver tests we prefer specifying a concrete target triple than making a
test dependent on the default target triple (controlled by `REQUIES:
coff-supported-target` in this case).
A concrete target triple (e.g. x86_64-windows) loses coverage for
aarch64-windows, but we
@@ -249,9 +245,27 @@ GetAffectingModuleMaps(const Preprocessor , Module
*RootModule) {
for (const auto : HS.findResolvedModulesForHeader(*File))
if (const Module *M = KH.getModule())
-CollectIncludingMapsFromAncestors(M);
+
@@ -249,9 +245,27 @@ GetAffectingModuleMaps(const Preprocessor , Module
*RootModule) {
for (const auto : HS.findResolvedModulesForHeader(*File))
if (const Module *M = KH.getModule())
-CollectIncludingMapsFromAncestors(M);
+
dyung wrote:
This change is also causing a failure on our internal Windows builder, and a
public Windows bot:
https://lab.llvm.org/buildbot/#/builders/119/builds/17634
```
88.872 [191/66/4550] Linking CXX executable bin\clang-repl.exe
FAILED: bin/clang-repl.exe
cmd.exe /C "cd . && "C:\Program
5chmidti wrote:
CC @11happy (couldn't add you as a reviewer)
https://github.com/llvm/llvm-project/pull/90279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Julian Schmidt (5chmidti)
Changes
When a binary operator is the last operand of a macro, the end location
that is past the `BinaryOperator` will be inside the macro and therefore an
invalid location to insert a `FixIt` into,
https://github.com/5chmidti created
https://github.com/llvm/llvm-project/pull/90279
When a binary operator is the last operand of a macro, the end location
that is past the `BinaryOperator` will be inside the macro and therefore an
invalid location to insert a `FixIt` into, which is why the
5chmidti wrote:
Do we add `improvement` documentation for checks that landed in the same
release cycle?
https://github.com/llvm/llvm-project/pull/90273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/90276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Ryosuke Niwa
Date: 2024-04-26T14:28:27-07:00
New Revision: 3d5e9ab6d89bfe3454e2b6f80b4babaa69413a87
URL:
https://github.com/llvm/llvm-project/commit/3d5e9ab6d89bfe3454e2b6f80b4babaa69413a87
DIFF:
https://github.com/llvm/llvm-project/commit/3d5e9ab6d89bfe3454e2b6f80b4babaa69413a87.diff
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/90153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Delete uses __get_long_cap()
```
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void
__set_long_cap(size_type __s) _NOEXCEPT {
__r_.first().__l.__cap_ = __s / __endian_factor;
__r_.first().__l.__is_long_ = true;
}
_LIBCPP_HIDE_FROM_ABI
1 - 100 of 489 matches
Mail list logo
