AdamMagierFOSS created this revision.
AdamMagierFOSS added reviewers: rjmccall, rsmith.
AdamMagierFOSS requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The code generation for the UBSan VLA size check was qualified by a con-
dition that the
AdamMagierFOSS added a comment.
Thank you for the feedback - I've added responses inline and I'll update the
change to reflect the feedback.
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2247
// Otherwise, evaluate and record it.
- if (const Expr *size =
AdamMagierFOSS added a comment.
Thanks once again for the feedback - I'll make the changes and commit directly.
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2256
+ llvm::Value *size = EmitScalarExpr(sizeExpr);
+ clang::QualType sizeExprType =
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb2715660ed0f: [clang][CodeGen][UBSan] VLA size checking for
unsigned integer parameter (authored by AdamMagierFOSS).
Changed prior to commit:
https://reviews.llvm.org/D116048?vs=399057=399114#toc
AdamMagierFOSS updated this revision to Diff 399057.
AdamMagierFOSS added a comment.
Updating based on feedback from rjmccall.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116048/new/
https://reviews.llvm.org/D116048
Files:
clang/lib/CodeGen/CodeGenFunction.cpp
