[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad updated this revision to Diff 157846. TheAhmad marked 4 inline comments as done. TheAhmad added a comment. auto used at line 612. auto removed at line 614. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 Files: ClangTidy.cpp Index: ClangTidy.cpp

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad accepted this revision. TheAhmad marked 3 inline comments as done. TheAhmad added a comment. This revision is now accepted and ready to land. Thanks Eugene! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 ___

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad updated this revision to Diff 157667. TheAhmad marked an inline comment as done. TheAhmad added a comment. Added auto at line 612. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 Files: ClangTidy.cpp Index: ClangTidy.cpp

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad created this revision. TheAhmad added a reviewer: alexfh. TheAhmad added a project: clang-tools-extra. Hi. Clang tidy has problem with compile command databases that do not use necassarily absolute file paths. This is common in many projects that use makefiles as the build system,

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad updated this revision to Diff 157623. TheAhmad added a comment. Ran Clang Format. Redundant Braces Removed. Used auto. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 Files: ClangTidy.cpp Index: ClangTidy.cpp

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. > Also, tests. What should I provide for tests? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad updated this revision to Diff 157676. TheAhmad marked 4 inline comments as done. TheAhmad added a comment. Used make_pair instead of constructor call. Used unique_ptr. Used named cast. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49890 Files: ClangTidy.cpp

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. The most comprehensive fix is to support all possible valid compilation databases. The current fix is the fastest one. > Can you just make clang-tidy respect the directory value? This is exactly what I did. I prepended the directory value to the file value and stored

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. In https://reviews.llvm.org/D49890#1182556, @alexfh wrote: > Could you describe the specific problem you're solving and provide an > example? As mentioned by others, a test would be very welcome as well. Sorry for so much delay, @alexfh. I didn't see your comment. I

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. Hi @alexfh, I have attached the compilation database for `MPlayer-1.3.0`.F7659818: compile_commands.json As can be seen, the paths are relative. To answer your comments I need more time. I do not remember the exact details. I will