[clang-tools-extra] Clang tools docs ci test (PR #69826)

2023-10-21 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/69826 None >From f8bd3e5f45e05f68522f41bb0b6ea733095eb7a4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 21 Oct 2023 02:33:56 -0700 Subject: [PATCH 1/2] [Github] Add clang-tools-extra docs to CI

[clang-tools-extra] Clang tools docs ci test (PR #69826)

2023-10-21 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/69826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/68636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Updated in 68281947f7df4c7325b862857fbf3ed06d711f74. https://github.com/llvm/llvm-project/pull/68636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6828194 - [Sanitizer][Docs] Reformat CMake invocation in docs

2023-10-09 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2023-10-09T22:45:34Z New Revision: 68281947f7df4c7325b862857fbf3ed06d711f74 URL: https://github.com/llvm/llvm-project/commit/68281947f7df4c7325b862857fbf3ed06d711f74 DIFF: https://github.com/llvm/llvm-project/commit/68281947f7df4c7325b862857fbf3ed06d711f74.diff

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Sorry. I'll wait longer to merge next time. I'll push a fixup to address the comment. Thanks for the comment/review! https://github.com/llvm/llvm-project/pull/68636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Sanitizer][Docs] Improve docs on building Asan (PR #68636)

2023-10-09 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/68636 Currently the documentation for building Asan doesn't specify that compiler-rt needs to be built as well. In addition, there's no minimal example for the LLVM CMake configuration. This patch addresses

[clang] 8b6f09e - Revert "[clang][X86] Add __cpuidex function to cpuid.h"

2023-08-19 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2023-08-19T17:18:10-07:00 New Revision: 8b6f09e257b521947b50761737290e5bf31c80f3 URL: https://github.com/llvm/llvm-project/commit/8b6f09e257b521947b50761737290e5bf31c80f3 DIFF:

[clang] 58696d2 - [clang][X86] Add __cpuidex function to cpuid.h

2023-08-19 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2023-08-19T17:12:23-07:00 New Revision: 58696d2f5bbae32dddcaec6891293e769465e77c URL: https://github.com/llvm/llvm-project/commit/58696d2f5bbae32dddcaec6891293e769465e77c DIFF:

[clang] c0bc461 - [Clang] Give error message for invalid profile path when compiling IR

2022-09-16 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2022-09-16T19:45:57Z New Revision: c0bc461999fdac918dd26867947c24eb6235c8d0 URL: https://github.com/llvm/llvm-project/commit/c0bc461999fdac918dd26867947c24eb6235c8d0 DIFF: https://github.com/llvm/llvm-project/commit/c0bc461999fdac918dd26867947c24eb6235c8d0.diff

[clang] 2ff0aa2 - [CMake][Fuchsia] Add LLVM_ENABLE_HTTPLIB to Stage 2 build

2023-06-03 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2023-06-03T22:30:19Z New Revision: 2ff0aa207fd55604604bb9eec33dada1a80842db URL: https://github.com/llvm/llvm-project/commit/2ff0aa207fd55604604bb9eec33dada1a80842db DIFF: https://github.com/llvm/llvm-project/commit/2ff0aa207fd55604604bb9eec33dada1a80842db.diff

[clang] 2df77ac - [clang][X86] Add __cpuidex function to cpuid.h

2023-05-24 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2023-05-24T06:27:46Z New Revision: 2df77ac20a1ed996706b164b0c4ed5ad140f635f URL: https://github.com/llvm/llvm-project/commit/2df77ac20a1ed996706b164b0c4ed5ad140f635f DIFF: https://github.com/llvm/llvm-project/commit/2df77ac20a1ed996706b164b0c4ed5ad140f635f.diff

[clang] f3baf63 - Revert "[clang][X86] Add __cpuidex function to cpuid.h"

2023-08-04 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2023-08-04T13:28:53-07:00 New Revision: f3baf63d9a1ba91974f4df6abb8f2abd9a0df5b5 URL: https://github.com/llvm/llvm-project/commit/f3baf63d9a1ba91974f4df6abb8f2abd9a0df5b5 DIFF:

[clang] db63fb5 - [Clang][Docs] Fix man page build

2023-05-13 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2023-05-13T08:51:10Z New Revision: db63fb5d45e0f58a1c657b23a24e85f28e3dbf73 URL: https://github.com/llvm/llvm-project/commit/db63fb5d45e0f58a1c657b23a24e85f28e3dbf73 DIFF: https://github.com/llvm/llvm-project/commit/db63fb5d45e0f58a1c657b23a24e85f28e3dbf73.diff

[clang] 286cefc - [clang][X86] Add __cpuidex function to cpuid.h

2023-05-17 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2023-05-17T19:38:28Z New Revision: 286cefcf35d0f55c57184c4219b95e82c96f1420 URL: https://github.com/llvm/llvm-project/commit/286cefcf35d0f55c57184c4219b95e82c96f1420 DIFF: https://github.com/llvm/llvm-project/commit/286cefcf35d0f55c57184c4219b95e82c96f1420.diff

[clang] 4acee5b - Revert "[clang][X86] Add __cpuidex function to cpuid.h"

2023-05-17 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2023-05-18T05:37:48Z New Revision: 4acee5b5cfa462af66225acda7d3d9efe1036aa9 URL: https://github.com/llvm/llvm-project/commit/4acee5b5cfa462af66225acda7d3d9efe1036aa9 DIFF: https://github.com/llvm/llvm-project/commit/4acee5b5cfa462af66225acda7d3d9efe1036aa9.diff

[llvm] [libc] [lldb] [compiler-rt] [libcxxabi] [flang] [lld] [libcxx] [clang] [clang-tools-extra] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-19 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/76653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-18 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: I believe this is ready to go now. All the tests have been converted to lit-style tests and everything has been wired up into a `check-mlgo-utils` CMake target. I talked with Mircea about the absl dependency. It's not in the tests anymore and the plan is to refactor in

[clang-tools-extra] [llvm] [clang] [AsmPrinter] Remove mbb-profile-dump flag (PR #76595)

2024-01-23 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/76595 >From 55cf94d98c38cd2b5cd8fbf76e5fd83b5a47f4af Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Fri, 29 Dec 2023 16:14:15 -0800 Subject: [PATCH] [AsmPrinter] Remove mbb-profile-dump flag Now that the

[clang-tools-extra] [clang] [llvm] [AsmPrinter] Remove mbb-profile-dump flag (PR #76595)

2024-01-23 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/76595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][PGO] Add libunwind to list of stage1 runtimes (PR #78869)

2024-01-21 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: This fixes #78487. https://github.com/llvm/llvm-project/pull/78869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] code-format: Improve the code-format-helper to be able to run as a git hook (PR #73957)

2023-12-11 Thread Aiden Grossman via cfe-commits
@@ -1,21 +1,56 @@ #!/usr/bin/env python3 # -# - code-format-helper, runs code formatters from the ci --*- python -*--==# +# - code-format-helper, runs code formatters from the ci or in a hook --*- python -*--==# # # Part of the LLVM Project, under the Apache License

[llvm] [clang] [clang-tools-extra] [lld] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-10 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/76653 >From 0196a8780f2d3a378f0fd3b86a6e6b6590ca02de Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 30 Dec 2023 15:37:56 -0800 Subject: [PATCH 01/12] [llvm-exegesis] Remove unused Counter::read method

[clang-tools-extra] [lld] [clang] [llvm] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-10 Thread Aiden Grossman via cfe-commits
@@ -112,9 +116,11 @@ class Counter { PerfEvent Event; int FileDescriptor = -1; bool IsDummyEvent; + std::vector ValidationEvents; boomanaiden154 wrote: My understanding is that `Counter` was an abstraction over a specific event that we want to measure

[clang-tools-extra] [lld] [clang] [llvm] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-10 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/76653 >From 0196a8780f2d3a378f0fd3b86a6e6b6590ca02de Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 30 Dec 2023 15:37:56 -0800 Subject: [PATCH 01/14] [llvm-exegesis] Remove unused Counter::read method

[clang-tools-extra] [clang] [lld] [llvm] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-10 Thread Aiden Grossman via cfe-commits
@@ -87,6 +93,8 @@ struct BenchmarkMeasure { // This is the per-snippet value, i.e. measured quantity for one repetition of // the whole snippet. double PerSnippetValue; + // These are the validation counter values. + std::unordered_map ValidationCounters;

[clang] [llvm] [clang-tools-extra] [llvm-exegesis] Add tablegen support for validation counters (PR #76652)

2024-01-10 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/76652 >From 0196a8780f2d3a378f0fd3b86a6e6b6590ca02de Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 30 Dec 2023 15:37:56 -0800 Subject: [PATCH 1/5] [llvm-exegesis] Remove unused Counter::read method

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Add tablegen support for validation counters (PR #76652)

2024-01-10 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/76652 >From 0196a8780f2d3a378f0fd3b86a6e6b6590ca02de Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 30 Dec 2023 15:37:56 -0800 Subject: [PATCH 1/7] [llvm-exegesis] Remove unused Counter::read method

[clang-tools-extra] [llvm] [lld] [clang] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-10 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/76653 >From 0196a8780f2d3a378f0fd3b86a6e6b6590ca02de Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 30 Dec 2023 15:37:56 -0800 Subject: [PATCH 01/12] [llvm-exegesis] Remove unused Counter::read method

[clang-tools-extra] [clang] [lld] [llvm] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-10 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/76653 >From 0196a8780f2d3a378f0fd3b86a6e6b6590ca02de Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 30 Dec 2023 15:37:56 -0800 Subject: [PATCH 01/13] [llvm-exegesis] Remove unused Counter::read method

[llvm] [clang] [clang-tools-extra] [llvm-exegesis] Add tablegen support for validation counters (PR #76652)

2024-01-10 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/76652 >From 0196a8780f2d3a378f0fd3b86a6e6b6590ca02de Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 30 Dec 2023 15:37:56 -0800 Subject: [PATCH 1/6] [llvm-exegesis] Remove unused Counter::read method

[llvm] [clang] [clang-tools-extra] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-10 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/76653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Add tablegen support for validation counters (PR #76652)

2024-01-10 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/76652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-14 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/72319 >From c3f723c8a975cc5e075d56350645b0be486f3cda Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Tue, 14 Nov 2023 14:20:24 -0800 Subject: [PATCH] [MLGO] Upstream the corpus extraction tooling ---

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-14 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/72319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-14 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 ready_for_review https://github.com/llvm/llvm-project/pull/72319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-14 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/72319 >From c3f723c8a975cc5e075d56350645b0be486f3cda Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Tue, 14 Nov 2023 14:20:24 -0800 Subject: [PATCH 1/2] [MLGO] Upstream the corpus extraction tooling ---

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-14 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: After this lands, my plan is to work on getting CI up and running, both to run testing and also to publish the package. https://github.com/llvm/llvm-project/pull/72319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang] [llvm] Hashpin sensitive dependencies and configure dependabot to update them automatically (PR #75859)

2024-01-15 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/75859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-15 Thread Aiden Grossman via cfe-commits
@@ -10,112 +10,70 @@ on: - 'llvmorg-*' jobs: - release-tasks: -permissions: - contents: write # To upload assets to release. + validate-tag: +name: Validate Tag runs-on: ubuntu-latest if: github.repository == 'llvm/llvm-project' +outputs: +

[llvm] [clang] [clang-tools-extra] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-15 Thread Aiden Grossman via cfe-commits
@@ -26,21 +35,26 @@ jobs: prepare: name: Prepare to build binaries runs-on: ubuntu-22.04 -if: github.repository == 'llvm/llvm-project' outputs: - release-version: ${{ steps.validate-tag.outputs.release-version }} - flags: ${{

[clang-tools-extra] [llvm] [clang] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-15 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,74 @@ +name: Release Lit + +permissions: + contents: read + +on: + workflow_dispatch: +inputs: + release-version: +description: 'Release Version' +required: true +type: string + + workflow_call: +inputs: + release-version: +

[llvm] [clang-tools-extra] [clang] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-15 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/69523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-15 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 commented: No issues on my end. Definitely seems to be an improvement over what was there before. It would be nice to unify the documentation test action and the documentation release action (at least somewhat), but it doesn't seem like they're particularly

[clang] [clang-tools-extra] [llvm] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-15 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,74 @@ +name: Release Lit + +permissions: + contents: read + +on: + workflow_dispatch: +inputs: + release-version: +description: 'Release Version' +required: true +type: string + + workflow_call: +inputs: + release-version: +

[clang] [llvm] [clang-tools-extra] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-15 Thread Aiden Grossman via cfe-commits
@@ -10,112 +10,70 @@ on: - 'llvmorg-*' jobs: - release-tasks: -permissions: - contents: write # To upload assets to release. + validate-tag: +name: Validate Tag runs-on: ubuntu-latest if: github.repository == 'llvm/llvm-project' +outputs: +

[clang] [libcxx] [lld] [libc] [compiler-rt] [clang-tools-extra] [llvm] [flang] [lldb] [libcxxabi] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-16 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/76653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Bump minimum compatibility to Python 3.6 (PR #77228)

2024-01-17 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/77228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-17 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,12 @@ +# MLGO Python Library + +This folder contains the MLGO python library. This library consists of telling boomanaiden154 wrote: Updated it to calling this the folder for MLGO Python Utilities. Good catch on the first line. Not sure exactly what

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-17 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,6 @@ +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. boomanaiden154 wrote: Looks like all the other Python tests within the monorepo are pretty much lit tests. I'll work on converting these tests to lit tests later

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-17 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,6 @@ +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. boomanaiden154 wrote: Or what's probably better for structuring is we can do `mlgo/mlgo/corpus` and then the package would be accessed as `mlgo.corpus` while still

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-17 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > Would it be also possible to remove the dependency on > [Abseil](https://github.com/abseil/abseil-py)? None of the existing scripts > in LLVM use it and I don't think we should be introducing this dependency. It > looks like Abseil is only used for flag parsing,

[compiler-rt] [clang] [llvm] [flang] [libc] [clang-tools-extra] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-05 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/74230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-05 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/74230 >From ae4097b53b90e31802be0be5c8a81fb74c81efc9 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 2 Dec 2023 23:46:58 -0800 Subject: [PATCH 1/3] [clang-format] Add "three dot" diff option to

[clang] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-02 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/74230 This patch adds in the ability to do a "three dot" git-clang-format between two commits. This looks at the diff between the second commit and the common merge base rather than comparing at the point of

[clang] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-03 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/74230 >From ae4097b53b90e31802be0be5c8a81fb74c81efc9 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 2 Dec 2023 23:46:58 -0800 Subject: [PATCH 1/2] [clang-format] Add "three dot" diff option to

[clang] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-03 Thread Aiden Grossman via cfe-commits
@@ -153,7 +157,10 @@ def main(): else: if len(commits) > 2: die('at most two commits allowed; %d given' % len(commits)) - changed_lines = compute_diff_and_extract_lines(commits, files, opts.staged) + changed_lines = compute_diff_and_extract_lines(commits,

[clang] [clang-format] Add "three dot" diff option to git-clang-format (PR #74230)

2023-12-03 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/74230 >From ae4097b53b90e31802be0be5c8a81fb74c81efc9 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 2 Dec 2023 23:46:58 -0800 Subject: [PATCH] [clang-format] Add "three dot" diff option to

[clang-tools-extra] [libc] [llvm] [clang] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/2] [llvm-exegesis] Add middle half repetition mode This

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/6] [llvm-exegesis] Add middle half repetition mode This

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: @legrosbuffle This should be ready to again when you have a chance to take a look. Thanks! https://github.com/llvm/llvm-project/pull/77020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang-tools-extra] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/3] [llvm-exegesis] Add middle half repetition mode This

[llvm] [clang-tools-extra] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -455,6 +466,26 @@ static void runBenchmarkConfigurations( Measurement.PerSnippetValue, NewMeasurement.PerSnippetValue); } } +} else if (RepetitionMode == boomanaiden154 wrote: Moved them to `ResultAggregator.cpp` and added

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/5] [llvm-exegesis] Add middle half repetition mode This

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/4] [llvm-exegesis] Add middle half repetition mode This

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: @legrosbuffle This is ready for review when you have a chance. Thanks! https://github.com/llvm/llvm-project/pull/77153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > It's a single line of code so it probably can stay there for backwards > compatibility :) Sounds good. https://github.com/llvm/llvm-project/pull/77153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77153 >From 1a86a03fdc9d6eee08830ff2f113c39e6096d564 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Fri, 5 Jan 2024 14:40:26 -0800 Subject: [PATCH 1/4] [llvm-exegesis] Replace --num-repetitions with

[llvm] [clang] [clang-tools-extra] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/77153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77153 >From 1a86a03fdc9d6eee08830ff2f113c39e6096d564 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Fri, 5 Jan 2024 14:40:26 -0800 Subject: [PATCH 1/5] [llvm-exegesis] Replace --num-repetitions with

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77153 >From 1a86a03fdc9d6eee08830ff2f113c39e6096d564 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Fri, 5 Jan 2024 14:40:26 -0800 Subject: [PATCH 1/3] [llvm-exegesis] Replace --num-repetitions with

[llvm] [lld] [clang] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-02-01 Thread Aiden Grossman via cfe-commits
@@ -73,68 +83,89 @@ FileHeader: Sections: - Name:.text.foo Type:SHT_PROGBITS -Address: [[FOO_ADDR]] +Address: 0x4000 Flags: [SHF_ALLOC, SHF_EXECINSTR] -Content: '503b050520907d02ebf5c3' +Content: '503b050530907d08ebf50f8dee1fc3'

[clang] [clang-tools-extra] [mlir] [libc] [libcxx] [llvm] [lldb] [MLGO] Remove absl dependency from scripts (PR #78880)

2024-01-21 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/78880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [mlir] [libc] [libcxx] [llvm] [lldb] [MLGO] Remove absl dependency from scripts (PR #78880)

2024-01-21 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/78880 >From 80c9507d7f49ddbc5f2554f597950f797355c255 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sun, 21 Jan 2024 03:53:03 + Subject: [PATCH 1/7] Add make_corpus script test ---

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

2024-01-29 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > In general, CSSPGO is meant as a more practical alternative for IRPGO thanks > to i) the use of sampled profile, ii) context-sensitivity. However, IRPGO is > still expected to provide better performance in all cases where it's > applicable thanks to accurate profile

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

2024-01-29 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Do you have benchmarks on how well this performs relative to standard IRPGO (or on top of it)? https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [compiler-rt] [clang-tools-extra] [flang] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-30 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/6] [llvm-exegesis] Add middle half repetition mode This

[llvm] [compiler-rt] [clang-tools-extra] [flang] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-30 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/77020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [lld] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -172,6 +172,105 @@ class OtoolOptTable : public CommonOptTable { "Mach-O object file displaying tool") {} }; +struct BBAddrMapLabel { + std::string BlockLabel; + std::string PGOAnalysis; +}; + +// This class represents the BBAddrMap and PGOMap

[llvm] [lld] [clang] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -172,6 +172,105 @@ class OtoolOptTable : public CommonOptTable { "Mach-O object file displaying tool") {} }; +struct BBAddrMapLabel { + std::string BlockLabel; + std::string PGOAnalysis; +}; + +// This class represents the BBAddrMap and PGOMap

[llvm] [lld] [clang] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -1693,24 +1750,21 @@ disassembleObject(ObjectFile , const ObjectFile , LLVM_DEBUG(LVP.dump()); - std::unordered_map AddrToBBAddrMap; - std::unordered_map AddrToPGOAnalysisMap; + BBAddrMapInfo FullAddrMap; auto ReadBBAddrMap = [&](std::optional SectionIndex =

[lld] [clang] [llvm] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -73,68 +83,89 @@ FileHeader: Sections: - Name:.text.foo Type:SHT_PROGBITS -Address: [[FOO_ADDR]] +Address: 0x4000 Flags: [SHF_ALLOC, SHF_EXECINSTR] -Content: '503b050520907d02ebf5c3' +Content: '503b050530907d08ebf50f8dee1fc3'

[lld] [clang] [llvm] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/74128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. Just nits/minor questions from me, code otherwise LGTM. Sorry for the delay in review. I didn't realize you explicitly wanted me to review portions of the code. https://github.com/llvm/llvm-project/pull/74128

[llvm] [clang] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,13 @@ +diff --git a/clang/cmake/caches/BOLT-PGO.cmake b/clang/cmake/caches/BOLT-PGO.cmake +index 1a04ca9a74e5..d092820e4115 100644 +--- a/clang/cmake/caches/BOLT-PGO.cmake b/clang/cmake/caches/BOLT-PGO.cmake +@@ -4,6 +4,8 @@ set(CLANG_BOOTSTRAP_TARGETS +

[clang] [llvm] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/80713 This patch adjusts the build process for building the toolchain for the CI container to perform more rigorous perf-training for PGO, particularly building the entirety of LLVM as that is what showed the

[llvm] [clang] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/80713 >From bef28f6d909060aeb4993866fad52dbe8a897d20 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 3 Feb 2024 20:46:57 -0800 Subject: [PATCH 1/2] [Github] Use building LLVM as perf-training for CI

[clang] [llvm] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,13 @@ +diff --git a/clang/cmake/caches/BOLT-PGO.cmake b/clang/cmake/caches/BOLT-PGO.cmake +index 1a04ca9a74e5..d092820e4115 100644 +--- a/clang/cmake/caches/BOLT-PGO.cmake b/clang/cmake/caches/BOLT-PGO.cmake +@@ -4,6 +4,8 @@ set(CLANG_BOOTSTRAP_TARGETS +

[llvm] [clang] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Looks like there was a transient failure in the stage2 build while loading the container image. I've restarted it and everything seems to be going fine. Hopefully that's not an issue going forward. https://github.com/llvm/llvm-project/pull/80713

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-19 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/72319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [llvm] [clang-tools-extra] [compiler-rt] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-16 Thread Aiden Grossman via cfe-commits
@@ -26,21 +35,26 @@ jobs: prepare: name: Prepare to build binaries runs-on: ubuntu-22.04 -if: github.repository == 'llvm/llvm-project' outputs: - release-version: ${{ steps.validate-tag.outputs.release-version }} - flags: ${{

[flang] [clang] [llvm] [clang-tools-extra] [compiler-rt] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-16 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. https://github.com/llvm/llvm-project/pull/69523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Release] Disable PGO (PR #88465)

2024-04-12 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. LGTM. I've run into the issue where profile data is generated again where it shouldn't be. I've meant to open up an issue and look into it at some point, but haven't had time to do so. I haven't previously run into this causing

[clang] [clang-tools-extra] [flang] [llvm] [mlir] [polly] [test]: fix filecheck annotation typos (PR #91854)

2024-05-13 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Were these found manually or using some automated tooling? Based on the Rust PR, it seems like these were found by just manually going through the results from a regex? https://github.com/llvm/llvm-project/pull/91854 ___