[PATCH] D36824: Rename getSupportedNanEncoding() to getIEEE754Standard() (NFC)

2017-08-17 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji created this revision. As function getSupportedNanEncoding() relies on IEEE 754 Standard, new suggested name is getIEEE754Standard() which is more convenient to use in decision non related to NaN encoding. Repository: rL LLVM https://reviews.llvm.org/D36824 Files:

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

2017-08-17 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 111492. abeserminji added a comment. On @atanasyan 's suggestion, part of the patch is separated here https://reviews.llvm.org/D36824. Comments resolved. Repository: rL LLVM https://reviews.llvm.org/D35982 Files:

[PATCH] D35624: Removal of microMIPS64R6

2017-07-25 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji marked 2 inline comments as done. abeserminji added a comment. Comments resolved Repository: rL LLVM https://reviews.llvm.org/D35624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35624: Removal of microMIPS64R6

2017-07-25 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 108067. abeserminji added a comment. Comments resolved and patch adapted to current revision. Repository: rL LLVM https://reviews.llvm.org/D35624 Files: Basic/Targets/Mips.cpp clang/Basic/DiagnosticCommonKinds.td Index: Basic/Targets/Mips.cpp

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

2017-07-28 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji created this revision. Herald added a subscriber: arichardson. In patch https://reviews.llvm.org/D3274 using abs.[ds] instruction is forced, as they should behave in accordance with flags Has2008 and ABS2008. Unfortunately for revisions prior mips32r6 and mips64r6, abs.[ds] is not

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

2017-08-24 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 112534. abeserminji added a comment. Added test //test/Driver/mips-mabs-warning.c// as suggested in comments. Repository: rL LLVM https://reviews.llvm.org/D35982 Files: include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D36824: [mips] Rename getSupportedNanEncoding() to getIEEE754Standard() (NFC)

2017-08-22 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 112150. abeserminji added a comment. Herald added a subscriber: arichardson. Comment resolved. Repository: rL LLVM https://reviews.llvm.org/D36824 Files: lib/Basic/Targets/Mips.h lib/Driver/ToolChains/Arch/Mips.cpp

[PATCH] D35624: Removal of microMIPS64R6

2017-12-11 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 126331. abeserminji added a comment. Comment addressed. https://reviews.llvm.org/D35624 Files: include/clang/Basic/DiagnosticCommonKinds.td lib/Basic/Targets/Mips.cpp Index: lib/Basic/Targets/Mips.cpp

[PATCH] D35624: Removal of microMIPS64R6

2017-12-11 Thread Aleksandar Beserminji via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320351: [mips] Removal of microMIPS64R6 (authored by abeserminji). Changed prior to commit: https://reviews.llvm.org/D35624?vs=126331=126332#toc Repository: rL LLVM https://reviews.llvm.org/D35624

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

2018-05-07 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 145460. abeserminji marked 4 inline comments as done. abeserminji added a comment. Comments resolved. https://reviews.llvm.org/D44684 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/Mips.cpp

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

2018-05-07 Thread Aleksandar Beserminji via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL331636: [mips] Improve handling of -fno-[pic/PIC] option (authored by abeserminji, committed by ). Changed prior to commit: https://reviews.llvm.org/D44684?vs=145460=145462#toc Repository: rL LLVM

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

2018-04-27 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:340 + "ignoring '%0' option as it cannot be used with " + "explicit use of -mabicalls and the N64 ABI">, InGroup; sdardis wrote: > Use the

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

2018-04-27 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 144344. abeserminji marked 2 inline comments as done. abeserminji added a comment. Comments resolved. https://reviews.llvm.org/D44684 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/Mips.cpp

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

2018-04-26 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 144092. abeserminji added a comment. Comments resolved. Repository: rL LLVM https://reviews.llvm.org/D44684 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D44381: [mips] Change the way how Clang chooses relocation mode

2018-03-12 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji created this revision. abeserminji added reviewers: sdardis, petarj. Herald added a subscriber: arichardson. This patch makes Clang behave more like gcc. - On N64 ABI, -mno-abicalls is needed to disable PIC. Warning is reported when only -fno-pic/-fno-PIC is used. - An error is

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

2018-04-13 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 142406. abeserminji marked an inline comment as done. abeserminji edited the summary of this revision. abeserminji added a comment. Comments resolved. Repository: rC Clang https://reviews.llvm.org/D44381 Files: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

2018-04-16 Thread Aleksandar Beserminji via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC330118: [mips] Prevent PIC to be set to level 2 (authored by abeserminji, committed by ). Repository: rL LLVM https://reviews.llvm.org/D44381 Files: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

2018-04-16 Thread Aleksandar Beserminji via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL330118: [mips] Prevent PIC to be set to level 2 (authored by abeserminji, committed by ). Changed prior to commit: https://reviews.llvm.org/D44381?vs=142406=142609#toc Repository: rL LLVM

[PATCH] D44381: [mips] Change the way how Clang chooses relocation mode

2018-03-20 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 139102. abeserminji added a comment. Herald added a subscriber: llvm-commits. Resolved a comment. Repository: rL LLVM https://reviews.llvm.org/D44381 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/mips-as.c test/Driver/mips-features.c

[PATCH] D44381: [mips] Force PIC to level 1

2018-03-20 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji updated this revision to Diff 139110. abeserminji retitled this revision from "[mips] Change the way how Clang chooses relocation mode" to "[mips] Force PIC to level 1". abeserminji edited the summary of this revision. abeserminji added a comment. Updated the patch. Now this patch

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

2018-03-20 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji created this revision. abeserminji added reviewers: petarj, sdardis. Herald added subscribers: llvm-commits, arichardson. - On N64 ABI, -mno-abicalls is needed to disable PIC. Warning is reported when only -fno-pic/-fno-PIC is used. This is how GCC behaves. - An error is reported

[PATCH] D53984: [mips] Fix broken MSA test

2018-11-01 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji created this revision. abeserminji added reviewers: atanasyan, smaksimovic, petarj, mstojanovic. Herald added subscribers: jrtc27, arichardson. Test //builtins-mips-msa-error.c// wasn't reporting errors. This patch fixes the test, so further test cases can be added. Repository: rC

[PATCH] D53984: [mips] Fix broken MSA test

2018-11-05 Thread Aleksandar Beserminji via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL346124: [mips][msa] Fix broken test (authored by abeserminji, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53984?vs=172152=172554#toc

[PATCH] D54038: [mips][msa] Fix msa_[st/ld] offset check

2018-11-07 Thread Aleksandar Beserminji via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC346302: [mips][msa] Fix msa_[st/ld] offset check (authored by abeserminji, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D54038 Files:

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

2019-01-17 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji created this revision. abeserminji added reviewers: petarj, atanasyan, MatzeB, mstojanovic. Herald added subscribers: jfb, arichardson, sdardis, srhines. When executing test-suite tests with -static option, we get stdthreadbug test to fail. Sometimes it segfault, sometimes it gets

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

2019-01-18 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji added a comment. @atanasyan That looks good. I tried to make an equivalent for the Makefile --- SingleSource/UnitTests/C++11/Makefile (revision 351547) +++ SingleSource/UnitTests/C++11/Makefile (working copy) @@ -4,6 +4,11 @@ CPPFLAGS += -std=c++11 -pthread

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

2019-01-17 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji added a comment. I am not sure if -static option passed as --cflag to lnt runtest enters the LDFLAGS. I guess it doesn't. But if there is a way to check which options are passed as --cflags, we might be able to add -Wl, -whole-archive -lpthread -Wl -no-whole-archive only in case

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

2019-01-24 Thread Aleksandar Beserminji via Phabricator via cfe-commits
abeserminji abandoned this revision. abeserminji added a comment. Agreed on this solution D52878 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56836/new/ https://reviews.llvm.org/D56836