[PATCH] D62888: [NewPM] Port Sancov

2019-07-12 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked an inline comment as done. abrachet added inline comments. Comment at: llvm/trunk/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:1022-1026 +SanitizerCoverage::getSectionStart(const std::string ) const { + return getSectionStartImpl(TargetTriple, Section);

[PATCH] D65545: Handle some fs::remove failures

2019-08-02 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. > I haven't updated all ignored instances of fs::remove, I therefore can't mark > it LLVM_NODISCARD for now. I think I remember reading that casting a `[[nodiscard]]` functions return to void was broken on some compilers, ie still warns. You cast `fs::remove` to void

[PATCH] D63518: BitStream reader: propagate errors

2019-06-27 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added inline comments. Comment at: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp:205 + return MaybeBitCode.takeError(); +switch (unsigned BitCode = MaybeBitCode.get()) { default: // Default behavior: reject This and an identical switch

[PATCH] D68931: [clang] [clang-offload-bundler] Fix finding installed llvm-objcopy

2019-10-13 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:469 // Find llvm-objcopy in order to create the bundle binary. ErrorOr Objcopy = sys::findProgramByName( "llvm-objcopy",

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

2020-03-04 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added inline comments. Comment at: llvm/include/llvm/Support/Threading.h:201 + /// hardware core is used. + inline ThreadPoolStrategy heavyweight_hardware_concurrency(StringRef Num) { +Optional S = Nit: Remove `inline`

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

2020-02-28 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:40 +SrcMgr::CharacteristicKind FileType) { + if (SrcMgr::isSystem(FileType)) { +if (!SM.isInMainFile(HashLoc)) { Could you whitelist

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

2020-03-03 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:40 +SrcMgr::CharacteristicKind FileType) { + if (SrcMgr::isSystem(FileType)) { +if (!SM.isInMainFile(HashLoc)) { PaulkaToast wrote: >

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

2022-03-13 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 414965. abrachet edited the summary of this revision. abrachet added a comment. Update example to have multiple options in NoArgUnusedWith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files:

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

2022-03-13 Thread Alex Brachet via Phabricator via cfe-commits
abrachet created this revision. abrachet added reviewers: MaskRay, thakis. Herald added subscribers: ormris, dang, usaxena95, kadircet, rupprecht, arphaman, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: alexander-shaposhnikov.

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

2022-03-13 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked an inline comment as done. abrachet added a comment. In D121560#3378181 , @MaskRay wrote: >> This patch adds an example for -static-libcxx and -nostdlib. > > We have -static-libstdc++ but not -static-libc++. (D53238 >

[PATCH] D113718: Don't append the working directory to absolute paths

2022-02-25 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. We're seeing test failures in https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8821217427732511185/overview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113718/new/

[PATCH] D120074: [Driver][Fuchsia][NFC] Use GetLinkerPath to see if linker is lld

2022-02-17 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f4dff8ab40: [Driver][Fuchsia][NFC] Use GetLinkerPath to see if linker is lld (authored by abrachet). Herald added a project: clang. Herald added a

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-03-23 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D122335#3403281 , @hubert.reinterpretcast wrote: > For users on Windows, would this cause extra trouble if they wanted to see > what was included? Is `tar(1)` not available on Windows? CHANGES SINCE LAST ACTION

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-03-30 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 419170. abrachet marked 2 inline comments as done. abrachet added a comment. reabase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/CMakeLists.txt clang/docs/ReleaseNotes.rst

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-03-30 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 419165. abrachet marked 2 inline comments as done. abrachet added a comment. - Define `CLANG_CRASH_SAVE_TEMPS` in config.h and not with `add_definitions` - Add `CLANG_CRASH_SAVE_TEMPS` env var to force emitting individual preprocessed sources CHANGES

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-03-30 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1434 StringRef AdditionalInformation, CompilationDiagnosticReport *Report) { +#ifdef CLANG_CRASH_SAVE_TEMPS + constexpr bool SaveReproTemps = true;

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-03-29 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 419014. abrachet added a comment. Herald added a subscriber: mgorny. - Add new build option `CLANG_CRASH_SAVE_TEMPS` which defaults to Off, or On if `CMAKE_BUILD_TYPE` is Debug. It retains the old behavior alongside the tar file. - Mark tests which use

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

2022-03-31 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 419491. abrachet added a comment. Rebase so patch applies CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files: clang-tools-extra/clangd/CompileCommands.cpp clang/include/clang/Driver/Options.h

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-04-04 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 420299. abrachet added a comment. Fixing failing tests in Modules/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/CMakeLists.txt clang/docs/ReleaseNotes.rst

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

2022-04-04 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 420375. abrachet added a comment. Actually clang-format... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files: clang-tools-extra/clangd/CompileCommands.cpp clang/include/clang/Driver/Options.h

[PATCH] D122613: [Driver] Make -moutline-atomics default for aarch64-fuchsia targets

2022-03-28 Thread Alex Brachet via Phabricator via cfe-commits
abrachet accepted this revision. abrachet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Fuchsia.h:81 + bool IsAArch64OutlineAtomicsDefault( + const llvm::opt::ArgList ) const override { +return true;

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

2022-03-22 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 417313. abrachet marked an inline comment as done. abrachet added a comment. Herald added subscribers: pmatos, asb, StephenFan. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files:

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-03-23 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 417754. abrachet added a comment. Herald added a subscriber: arphaman. Fix test failures outside of Driver/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/docs/ReleaseNotes.rst

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-03-23 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D122335#3403474 , @aaron.ballman wrote: > Yup, I'm okay with that compiler engineer requirement; I think our existing > requirements on Windows already pull in a useful `tar` program even though it > doesn't seem like we

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-03-23 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 417756. abrachet added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver.cpp clang/test/Driver/crash-diagnostics-dir.c

[PATCH] D117611: [Sema] Warn about printf %n on Android and Fuchsia

2022-01-21 Thread Alex Brachet via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4e600f5f5c: [Sema] Warn about printf %n on Android and Fuchsia (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-04-08 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

2022-04-13 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D121560#3439570 , @MaskRay wrote: > If you need a -static-libstdc++ not subject to unused argument warning, > --start-no-unused-arguments and D53238 > (-static=c++stdlib) may be better

[PATCH] D159130: [CMake] Add option to disable driver build in Fuchsia cache file

2023-09-05 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:34 set(LLVM_USE_CRT_RELEASE "MT" CACHE STRING "") -else() + set(FUCHSIA_DISABLE_DRIVER_BUILD On) +endif() phosek wrote: > Nit: can you use `ON` for consistency? Done in

[PATCH] D159130: [CMake] Add option to disable driver build in Fuchsia cache file

2023-09-05 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked an inline comment as done. Closed by commit rGc7cc756ce343: [CMake] Add option to disable driver build in Fuchsia cache file (authored by abrachet).

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

2023-09-06 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. I'm seeing libcxx failures after this patch. See https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8770673168839783889/overview # .---command stderr # |

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

2023-09-09 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added inline comments. Comment at: clang/test/Driver/haiku.cpp:2 +// Check the C++ header path (libstdc++) +// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \ +// RUN: --sysroot=%S/Inputs/haiku_x86_64_tree \ This test is broken for people

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

2023-09-09 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added inline comments. Comment at: clang/test/Driver/haiku.cpp:2 +// Check the C++ header path (libstdc++) +// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \ +// RUN: --sysroot=%S/Inputs/haiku_x86_64_tree \ brad wrote: > abrachet wrote: >

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

2023-09-27 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. struct S { template constexpr bool a(F&& f) const { // This works previously in clang and on gcc return f(1); // no matching function for call to object of type ... } }; template struct S1 { void f() { auto test = [] (auto)

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-27 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked an inline comment as done. abrachet added inline comments. Comment at: clang/test/Driver/emit-reproducer.c:1 +// RUN: rm -rf %t; mkdir %t + hans wrote: > I'm not sure if lit handles that semicolon, or if it hands this over to the > shell, in

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-27 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG684c08010876: [Clang] Extend -gen-reproducer flag (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-31 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 433120. abrachet marked an inline comment as done. abrachet added a comment. Fix tests on macOS and compile test with `-fsyntax-only` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120201/new/ https://reviews.llvm.org/D120201 Files:

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-31 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 433122. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120201/new/ https://reviews.llvm.org/D120201 Files: clang/include/clang/Driver/Driver.h clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

2022-05-31 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D120201#3547834 , @dyung wrote: > The test you added seems to be failing on the PS4 Windows bot. A quick glance > seems to suggest that you aren't properly escaping the path separators > somewhere. Can you take a look and

[PATCH] D126548: [InstrProf] Stop exporting lprofDirMode

2022-05-31 Thread Alex Brachet via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG35a032eaf429: [InstrProf] Stop exporting lprofDirMode (authored by abrachet). Herald added subscribers: Sanitizers, cfe-commits, Enna1. Herald added projects: clang, Sanitizers. Repository: rG LLVM

[PATCH] D126678: [clang] Allow CLANG_MODULE_CACHE_PATH env var to override module caching behavior

2022-06-09 Thread Alex Brachet via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. abrachet marked an inline comment as done. Closed by commit rGfac39d14b129: [clang] Allow CLANG_MODULE_CACHE_PATH env var to override module caching… (authored by abrachet). Herald added a project: clang. Herald added a

[PATCH] D109977: LLVM Driver Multicall tool

2022-06-04 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked 5 inline comments as done. abrachet added a comment. In D109977#3378312 , @phosek wrote: > Another potential future improvement is error reporting for subcommands: > > $ ./bin/llvm clang > llvm: error: no input files > $

[PATCH] D109977: LLVM Driver Multicall tool

2022-06-04 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 434277. abrachet added a comment. Herald added a subscriber: hiraditya. - `llvm llvm-$tool` -> `llvm $tool` - Error messages will now show `$tool: error: ...` instead of `error: ...` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/

[PATCH] D109977: LLVM Driver Multicall tool

2022-06-04 Thread Alex Brachet via Phabricator via cfe-commits
abrachet commandeered this revision. abrachet added a reviewer: beanz. abrachet added a comment. I spoke to @beanz offline to make sure he is still ok with the patch being commandeered. Thanks for the patch @beanz, very excited about this :) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

2022-06-03 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. As a heads up, because I'm not sure how often folks look at Github Issues. This patch causes a stack overflow on some Objective-C++ code. I have filed https://github.com/llvm/llvm-project/issues/55851. Could you take a look @martong? Repository: rG LLVM Github

[PATCH] D109977: LLVM Driver Multicall tool

2022-06-05 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 434352. abrachet marked an inline comment as done. abrachet edited the summary of this revision. abrachet added a comment. Better handling of names with version, ie `llvm-cxxfilt-15` -> `cxxfilt` CHANGES SINCE LAST ACTION

[PATCH] D109977: LLVM Driver Multicall tool

2022-06-05 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked 2 inline comments as done. Closed by commit rGf06abbb39380: LLVM Driver Multicall tool (authored by beanz, committed by abrachet). Repository: rG

[PATCH] D109977: LLVM Driver Multicall tool

2022-06-05 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 434370. abrachet marked an inline comment as done. abrachet added a comment. - Fix bazel build, `llvm-driver` can't be built by bazel, but the existing tools which lost their `main` will still work. - Remove `--version` - Fix `dsymutil` not depending on

[PATCH] D109977: LLVM Driver Multicall tool

2022-06-05 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked 5 inline comments as done. abrachet added a comment. In D109977#3558762 , @MaskRay wrote: > Thanks for picking up the change. I confirm that I can build `llvm` without > an error and it appears to work fine. > >> llvm-driver can be

[PATCH] D109977: LLVM Driver Multicall tool

2022-06-05 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:2030 +string(REPLACE "-" "_" key ${link_name}) +string(REPLACE "+" "p" key ${key}) +string(REPLACE "llvm-" "" tool_name ${link_name})

[PATCH] D127933: [clang] Don't emit IFUNC when targeting Fuchsia

2022-06-16 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4f6adc451a2: [clang] Dont emit IFUNC when targeting Fuchsia (authored by abrachet). Herald added a project: clang. Herald added a subscriber:

[PATCH] D109977: LLVM Driver Multicall tool

2022-06-06 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked an inline comment as done. abrachet added inline comments. Comment at: llvm/test/lit.cfg.py:142 tools = [ +ToolSubst('%llvm', FindTool('llvm')), ToolSubst('%lli', FindTool('lli'), post='.', extra_args=lli_args), thakis wrote: > This

[PATCH] D109977: LLVM Driver Multicall tool

2022-07-19 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D109977#3662859 , @mgorny wrote: > The actual problem is that you're passing `${USE_SHARED}` to `llvm_config()` > (in `add_llvm_executable`) before it's defined. Moving the definition earlier > fixed this error but uncovers

[PATCH] D127800: [llvm-driver] Generate symlinks instead of executables for tools

2022-07-19 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09d4dbc3829e: [llvm-driver] Generate symlinks instead of executables for tools (authored by abrachet). Herald added a project: clang. Herald added a

[PATCH] D109977: LLVM Driver Multicall tool

2022-07-19 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. Thanks @mgorny I was able to get CMake to run. Although I didn't end up with the same error as you. I simply had warnings: CMake Warning (dev) at /usr/local/lib/cmake/llvm/TableGen.cmake:103 (add_custom_command): Policy CMP0116 is not set: Ninja generators

[PATCH] D109977: LLVM Driver Multicall tool

2022-07-18 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D109977#3652467 , @mgorny wrote: > In D109977#3652091 , @abrachet > wrote: > >> Could I have a cmake invocation or a bot link? > > The exact CMake invocation for clang is: > >

[PATCH] D130514: [CMake][Fuchsia] Enable assertions and backtraces in stage 1 build

2022-07-26 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0df7d8bc355d: [CMake][Fuchsia] Enable assertions and backtraces in stage 1 build (authored by abrachet). Herald added a project: clang. Herald added

[PATCH] D109977: LLVM Driver Multicall tool

2022-07-14 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked an inline comment as done. abrachet added a comment. In D109977#3611683 , @mgorny wrote: > This seems to have broken standalone builds for Gentoo. > > While building Clang, I get: > > CMake Error at

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

2022-07-22 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D128465#3672515 , @MaskRay wrote: > I am still seeing the > > zstdConfig.cmake > zstd-config.cmake > > warning. @ckissane @phosek will you fix it? :) I've quieted the warnings in

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

2022-04-18 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

2022-08-01 Thread Alex Brachet via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5fd03b00ee02: [Driver] Re-run lld with --reproduce when it crashes (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

2022-08-01 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D120175#3691843 , @MaskRay wrote: > LGTM > > (Note: This is a patch which I think would benefit from a second look and > 2.5h from approval to push was too short for others to react on this patch.) Ack, I'll give more time

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

2022-08-01 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D120175#3692032 , @thakis wrote: > This breaks tests on mac and win: > http://45.33.8.238/macm1/41545/step_7.txt > http://45.33.8.238/win/63579/step_7.txt > > Please take a look and revert for now if it takes a while to fix.

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

2022-08-18 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked an inline comment as done. Closed by commit rG377dddf4a083: [clang][Driver] Pass correct reproduce flag to lld-link (authored by abrachet). Herald

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

2022-08-18 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D131214#3733317 , @thakis wrote: > The removal of the explicit target broke the test on Mac: > http://45.33.8.238/macm1/42754/step_7.txt > > (Just need to be more permissive about leading underscores) > > Please take a look

[PATCH] D133117: [clang] Give better message for unsupported no_sanitize on globals

2022-09-01 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked an inline comment as done. abrachet added a comment. In D133117#3764721 , @aaron.ballman wrote: > LGTM aside from a requested change in diagnostic wording (no need for > additional review), though please also add a release note when

[PATCH] D133117: [clang] Give better message for unsupported no_sanitize on globals

2022-09-01 Thread Alex Brachet via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf6d6e33abc2e: [clang] Give better message for unsupported no_sanitize on globals (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D134640: Unwind-tables: move back to original logic outline for kind.

2022-09-28 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134640/new/ https://reviews.llvm.org/D134640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135340: [PGO] Make emitted symbols hidden

2022-10-18 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 468425. abrachet added a comment. The error @zequanwu ran into happens only on MacOS because it this Darwin-only test happens to be the only one that tests instrprof with no code. `__llvm_profile_filename` doesn't get emitted in this case so it ends up

[PATCH] D136703: [Driver][Fuchsia] Make -mfix-cortex-a53-835769 default when targeting Fuchsia

2022-10-25 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4981a186b3aa: [Driver][Fuchsia] Make -mfix-cortex-a53-835769 default when targeting Fuchsia (authored by abrachet). Herald added a project: clang.

[PATCH] D135340: [PGO] Make emitted symbols hidden

2022-10-25 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D135340#3882280 , @thakis wrote: > This is still breaking ` Profile-x86_64 :: instrprof-darwin-dead-strip.c` > on mac. I'm reverting this again for now. Sorry about that, I've tested it locally and it should be good to go

[PATCH] D135340: [PGO] Make emitted symbols hidden

2022-10-25 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 470597. abrachet added a comment. Use sed to filter nm output instead of grep. grep exits with exit code 1 because there are no matching lines. This is expected because there are no more external symbols other than `_main` and `__mh_execute_header`, note

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

2022-10-17 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D128567#3863178 , @aeubanks wrote: > I've noticed that we're skipping compiler-rt tests with `REQUIRED: > lld-available` because `LLVM_TOOL_LLD_BUILD` needs to be defined. any update > on the proposed alternative? I think

[PATCH] D127800: [llvm-driver] Generate symlinks instead of executables for tools

2022-09-13 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked an inline comment as done. abrachet added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1283 macro(add_llvm_tool name) + cmake_parse_arguments(ARG "DEPENDS;GENERATE_DRIVER" "" "" ${ARGN}) if( NOT LLVM_BUILD_TOOLS ) Amir

[PATCH] D134640: Unwind-tables: move back to original logic outline for kind.

2022-09-26 Thread Alex Brachet via Phabricator via cfe-commits
abrachet accepted this revision. abrachet added a comment. This revision is now accepted and ready to land. Thanks! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134640/new/ https://reviews.llvm.org/D134640

[PATCH] D134289: [Driver] Make --execute-only the default for aarch64-fuchsia

2022-09-20 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked an inline comment as done. abrachet added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:93 CmdArgs.push_back("--fix-cortex-a53-843419"); +CmdArgs.push_back("--execute-only"); } mcgrathr wrote: > This is a

[PATCH] D134289: [Driver] Make --execute-only the default for aarch64-fuchsia

2022-09-20 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16f735d2fbe8: [Driver] Make --execute-only the default for aarch64-fuchsia (authored by abrachet). Herald added a project: clang. Herald added a

[PATCH] D135340: [PGO] Make emitted symbols hidden

2022-10-13 Thread Alex Brachet via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGecac223b0e4b: [PGO] Make emitted symbols hidden (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D135471: [CMake] Drop libLTO and switch to PIE for Fuchsia toolchain

2022-10-07 Thread Alex Brachet via Phabricator via cfe-commits
abrachet accepted this revision. abrachet added a comment. This revision is now accepted and ready to land. Nice thats 71mb saved :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135471/new/ https://reviews.llvm.org/D135471

[PATCH] D134979: [llvm-driver][NFC] Simplify handling of tool symlinks

2022-10-01 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa1c58b9c67a: [llvm-driver][NFC] Simplify handling of tool symlinks (authored by abrachet). Herald added a project: clang. Herald added a

[PATCH] D131310: [llvm-driver] Support single distributions

2022-10-01 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0df701b0d9: [llvm-driver] Support single distributions (authored by abrachet). Herald added a project: clang. Herald added a subscriber:

[PATCH] D135916: Itanium ABI: Pack non-pod members of packed types

2022-10-14 Thread Alex Brachet via Phabricator via cfe-commits
abrachet accepted this revision. abrachet added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135916/new/ https://reviews.llvm.org/D135916

[PATCH] D132416: [Driver][Fuchsia] Add default linker flags

2022-09-30 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dfc8ebee5d6: [Driver][Fuchsia] Add default linker flags (authored by abrachet). Herald added a project: clang. Herald added a subscriber:

[PATCH] D130226: [clang-doc] Default to Standalone executor and improve documentation

2022-08-04 Thread Alex Brachet via Phabricator via cfe-commits
abrachet accepted this revision. abrachet added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:195 + $ clang-doc --executor=all-TUs compile_commands.json + )"; + Is it intentional that the rest of this help message also has two

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

2022-08-08 Thread Alex Brachet via Phabricator via cfe-commits
abrachet updated this revision to Diff 450836. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131214/new/ https://reviews.llvm.org/D131214 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/lld-repro.c Index: clang/test/Driver/lld-repro.c

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

2022-08-08 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1639 +Twine ReproduceOption = +C.getDefaultToolChain().getTriple().isOSBinFormatCOFF() +? "/reproduce:" mstorsjo wrote: >

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

2022-08-16 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added subscribers: mcgrathr, abrachet. abrachet added a comment. This is breaking us. template struct S; // #1 template struct S {}; // #2 The following compiled before but is now broken, (we use `-fclang-abi-compat=13.0`). We get a warning from

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

2022-08-16 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D128745#3727715 , @ychen wrote: > In D128745#3727697 , @abrachet > wrote: > >> This is breaking us. >> >> template struct S; // #1 >> >> template struct S {}; // #2 >> >>

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

2022-08-18 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. While digging around failures we were seeing related to this I found some behavior that diverges from gcc. See https://godbolt.org/z/qe18Wh4jf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

2022-08-02 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D120175#3693458 , @probinson wrote: > There is now cross-project-tests which would seem to be the appropriate place > for a test that wants to run both clang and lld. Thanks for pointing that out. I'll look into moving the

[PATCH] D139949: [clang-scan-deps] Migrate to OptTable

2023-01-13 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c60ec699fc1: [clang-scan-deps] Migrate to OptTable (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D139949: [clang-scan-deps] Migrate to OptTable

2023-01-13 Thread Alex Brachet via Phabricator via cfe-commits
abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:2207 ":frontend", +":ScanDepsTableGen", ":tooling", GMNGeoffrey wrote: > MaskRay wrote: > > Move

[PATCH] D142649: [CMake] Remove libLTO from Fuchsia toolchain

2023-01-26 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa27081e43f: [CMake] Remove libLTO from Fuchsia toolchain (authored by abrachet). Herald added a project: clang. Herald added a subscriber:

[PATCH] D136554: Implement CWG2631

2022-11-04 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. Hi, we're hitting an assertion failure after this patch llvm-project/clang/lib/Sema/SemaDecl.cpp:15589: Decl *clang::Sema::ActOnFinishFunctionBody(Decl *, Stmt *, bool): Assertion `MaybeODRUseExprs.empty() && "Leftover expressions for odr-use checking"' failed.

[PATCH] D136554: Implement CWG2631

2022-11-04 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D136554#3909198 , @cor3ntin wrote: > In D136554#3909196 , @abrachet > wrote: > >> Hi, we're hitting an assertion failure after this patch >> >>

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

2022-11-02 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D120175#3902789 , @thakis wrote: > I noticed that when using `-fcrash-diagnostics=all` and the linker crashes, > clang creates both preprocessor and linker repros: > > clang: note: diagnostic msg: >

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

2022-11-09 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. I believe this patch might be the cause of some assertion failures we are seeing in a two stage lto build, as it's only happening for arm64-darwin. See https://ci.chromium.org/ui/p/fuchsia/builders/prod/clang-mac-xarm64/b8798097341668696785/overview and it's

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

2022-11-02 Thread Alex Brachet via Phabricator via cfe-commits
abrachet added a comment. In D120175#3902838 , @thakis wrote: > Great, thanks :) > > For context, we're trying to use this flag In Production to try and debug a > linker crash, but making the compiler repro failed for some reason – and then > we

[PATCH] D137289: [Driver] Don't preprocess source files when reproducing linker crashes

2022-11-02 Thread Alex Brachet via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG78ed64d89fd6: [Driver] Dont preprocess source files when reproducing linker crashes (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D145725: [Driver] Make -X default for baremetal riscv

2023-03-13 Thread Alex Brachet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked 2 inline comments as done. Closed by commit rGdf405dbfd316: [Driver] Make -X default for baremetal riscv (authored by abrachet). Herald added a

  1   2   >