Author: arphaman
Date: Tue Jan 31 06:37:48 2017
New Revision: 293619
URL: http://llvm.org/viewvc/llvm-project?rev=293619=rev
Log:
Workaround new -Wshadow warning introduced by r293599
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp
Modified:
Author: arphaman
Date: Wed Feb 1 04:52:02 2017
New Revision: 293759
URL: http://llvm.org/viewvc/llvm-project?rev=293759=rev
Log:
Revert r293518 as it caused module linking error in clang-reorder-fields
This commit reverts "r293518 - [ASTMatchers] Sprinkle some constexpr on the
global matcher
Author: arphaman
Date: Wed Feb 1 11:37:28 2017
New Revision: 293787
URL: http://llvm.org/viewvc/llvm-project?rev=293787=rev
Log:
[CodeGen][ObjC] Avoid asserting on block pointer types in
isPointerZeroInitializable
rdar://30111891
Added:
cfe/trunk/test/CodeGenObjC/block-ptr-type-crash.m
Author: arphaman
Date: Fri Feb 3 08:22:33 2017
New Revision: 294008
URL: http://llvm.org/viewvc/llvm-project?rev=294008=rev
Log:
[Sema][ObjC++] Typo correction should handle ivars and properties
After r260016 and r260017 disabled typo correction for ivars and properties
clang didn't report
Author: arphaman
Date: Mon Jan 30 05:37:18 2017
New Revision: 293475
URL: http://llvm.org/viewvc/llvm-project?rev=293475=rev
Log:
Revert "r293343 - [ubsan] Sanity-check shift amounts before truncation
(fixes PR27271)"
After r293343 clang fails to compile itself with -fsanitize=undefined (
Author: arphaman
Date: Mon Feb 20 11:55:15 2017
New Revision: 295674
URL: http://llvm.org/viewvc/llvm-project?rev=295674=rev
Log:
[Sema][ObjC] perform-selector ARC check should see @selector in parens
Modified:
cfe/trunk/lib/Sema/SemaExprObjC.cpp
Author: arphaman
Date: Fri Feb 17 12:11:08 2017
New Revision: 295471
URL: http://llvm.org/viewvc/llvm-project?rev=295471=rev
Log:
[Docs] 'Limitations' should be a subsection
The 'Limitations' section in thedocumentation for
readability-misleading-indentation should be a subsection, as otherwise
Author: arphaman
Date: Thu Feb 16 17:15:36 2017
New Revision: 295381
URL: http://llvm.org/viewvc/llvm-project?rev=295381=rev
Log:
Use correct fix-it location for -Wblock-capture-autoreleasing
The '__autoreleasing' keyword should be inserted after the Objective-C pointer
type.
rdar://30123548
Author: arphaman
Date: Thu Feb 23 18:21:20 2017
New Revision: 296054
URL: http://llvm.org/viewvc/llvm-project?rev=296054=rev
Log:
NFC, Remove commented out block of code from CGBlocks.cpp
This is a preparation clean-up commit around the code that emits
block copy/dispose routines.
Modified:
Author: arphaman
Date: Thu Feb 23 18:09:30 2017
New Revision: 296048
URL: http://llvm.org/viewvc/llvm-project?rev=296048=rev
Log:
NFC, Add a test that ensures that we don't emit helper code in copy/dispose
routines for objects that are captured with the __unsafe_unretained
ownership qualifier
Author: arphaman
Date: Thu Feb 23 17:41:50 2017
New Revision: 296040
URL: http://llvm.org/viewvc/llvm-project?rev=296040=rev
Log:
NFC, Add a test that ensure that we don't emit helper code in copy/dispose
routines for variables that are const-captured
This is a preparation commit that improves
Author: arphaman
Date: Fri Feb 24 11:45:16 2017
New Revision: 296140
URL: http://llvm.org/viewvc/llvm-project?rev=296140=rev
Log:
[Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma
in macro argument pre-expansion mode when skipping a function body
This commit fixes a
Author: arphaman
Date: Wed Feb 22 17:18:49 2017
New Revision: 295903
URL: http://llvm.org/viewvc/llvm-project?rev=295903=rev
Log:
[ObjC][Modules] Don't perform property lookup in hidden class extensions
rdar://30603803
Modified:
cfe/trunk/lib/AST/DeclObjC.cpp
Author: arphaman
Date: Mon Feb 13 17:19:40 2017
New Revision: 295001
URL: http://llvm.org/viewvc/llvm-project?rev=295001=rev
Log:
[CodeCompletion] Code complete the missing C++11 keywords
This commit adds context sensitive code completion support for the C++11
keywords that currently don't have
Author: arphaman
Date: Mon Feb 13 17:35:59 2017
New Revision: 295003
URL: http://llvm.org/viewvc/llvm-project?rev=295003=rev
Log:
[CodeCompletion] Code complete the '__auto_type' keyword
rdar://29219185
Added:
cfe/trunk/test/CodeCompletion/auto_type.c
Modified:
Author: arphaman
Date: Wed Feb 15 17:24:15 2017
New Revision: 295256
URL: http://llvm.org/viewvc/llvm-project?rev=295256=rev
Log:
[Docs] Add missing space to an option doc
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.td
URL:
Author: arphaman
Date: Mon Jan 23 11:23:23 2017
New Revision: 292805
URL: http://llvm.org/viewvc/llvm-project?rev=292805=rev
Log:
[Sema] UsingShadowDecl shouldn't be hidden by the UsingDecl that owns it
rdar://23454249
Differential Revision: https://reviews.llvm.org/D28514
Added:
Author: arphaman
Date: Tue Jan 24 08:15:08 2017
New Revision: 292932
URL: http://llvm.org/viewvc/llvm-project?rev=292932=rev
Log:
[CodeCompletion] Ensure that ObjC root class completes instance
methods from protocols and categories as well
Code completion results for class methods already
Author: arphaman
Date: Fri Jan 20 09:38:58 2017
New Revision: 292615
URL: http://llvm.org/viewvc/llvm-project?rev=292615=rev
Log:
[Sema] Improve the error diagnostic for dot destructor calls on pointer objects
This commit improves the mismatched destructor type error by detecting when the
Author: arphaman
Date: Fri Jan 20 10:48:25 2017
New Revision: 292617
URL: http://llvm.org/viewvc/llvm-project?rev=292617=rev
Log:
[Frontend] The macro that describes the Objective-C bool type should
be defined for non Objective-C code as well
rdar://29794915
Differential Revision:
Author: arphaman
Date: Thu Jan 19 11:17:57 2017
New Revision: 292497
URL: http://llvm.org/viewvc/llvm-project?rev=292497=rev
Log:
[Sema] Fix PR28181 by avoiding calling BuildOverloadedBinOp in C mode
rdar://28532840
Differential Revision: https://reviews.llvm.org/D25213
Added:
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This fixes PR 30274 by making sure that we skip the 'Using' and
'ConstructorUsingShadowDecl' declarations when evaluating the
arphaman added a comment.
(Forgot to mention) This is a a fix for the regression introduced by r274049.
Repository:
rL LLVM
https://reviews.llvm.org/D24884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman created this revision.
arphaman added a reviewer: DmitryPolukhin.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes PR 30440 by initializing CXXNameMangler's FunctionTypeDepth in
the two constructors added in r274222
arphaman added a subscriber: arphaman.
Comment at: clang-rename/RenamingAction.cpp:75
@@ +74,3 @@
+ // has been matched multiple times (which shouldn't happen in reality,
+ // need to fix that) or when it's a specific header. For now, just ingore
+ // there error
arphaman abandoned this revision.
arphaman added a comment.
I just noticed that PR 30274 is actually a duplicate of PR 29087, which already
has a patch with a fix in review. This patch is now abandoned. Sorry about not
noticing the duplicate earlier.
Repository:
rL LLVM
arphaman created this revision.
arphaman added a reviewer: aaron.ballman.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a crash that happens when clang is analyzing a
transparent_union attribute on a union which has a field
Author: arphaman
Date: Wed Oct 5 04:27:48 2016
New Revision: 283304
URL: http://llvm.org/viewvc/llvm-project?rev=283304=rev
Log:
[Sema] Packed member warning: Use the typedef name for anonymous structures
This commit improves the packed member warning by showing the name of the
anonymous
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283304: [Sema] Packed member warning: Use the typedef name
for anonymous structures (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25106?vs=73338=73611#toc
Repository:
rL
Author: arphaman
Date: Thu Oct 6 04:47:29 2016
New Revision: 283432
URL: http://llvm.org/viewvc/llvm-project?rev=283432=rev
Log:
[Sema] Fix PR30520: Handle incomplete field types in transparent_union unions
This commit fixes a crash that happens when clang is analyzing a
transparent_union
arphaman created this revision.
arphaman added reviewers: rnk, aaron.ballman.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
While working on fixing PR30520 yesterday I noticed that clang also crashes on
code like this:
template
union u {
Author: arphaman
Date: Thu Oct 6 04:37:15 2016
New Revision: 283428
URL: http://llvm.org/viewvc/llvm-project?rev=283428=rev
Log:
Fix PR30440: Initialize FunctionTypeDepth in CXXNameMangler
This commit fixes PR 30440 by initializing CXXNameMangler's FunctionTypeDepth
in the two constructors
arphaman updated this revision to Diff 73781.
arphaman added a comment.
Slight update: There's no need to pass `CFGBlock` into `isBuiltinUnreachable`.
Repository:
rL LLVM
https://reviews.llvm.org/D25321
Files:
lib/Analysis/ReachableCode.cpp
test/Sema/warn-unreachable.c
Index:
arphaman created this revision.
arphaman added reviewers: dblaikie, krememek.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes the issue of clang emitting an unreachable warning when it
encounters unreachable
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283432: [Sema] Fix PR30520: Handle incomplete field types in
transparent_union unions (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25273?vs=73626=73789#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283428: Fix PR30440: Initialize FunctionTypeDepth in
CXXNameMangler (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D24932?vs=72526=73787#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283102: Fix PR 28885: Fix AST Printer output for the
inherited constructor using (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25131?vs=73145=73410#toc
Repository:
rL
arphaman updated this revision to Diff 73460.
arphaman marked an inline comment as done.
arphaman added a comment.
Thanks for the response,
I updated the patch with a approach that you suggested - now
`Sema::CreateOverloadedBinOp` isn't called in C mode (I have an assertion for
this in
Author: arphaman
Date: Tue Oct 4 11:06:37 2016
New Revision: 283228
URL: http://llvm.org/viewvc/llvm-project?rev=283228=rev
Log:
[Sema] Format a comment line so that it fits 80 columns. NFC
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
arphaman added a comment.
In https://reviews.llvm.org/D23657#560938, @arphaman wrote:
> Btw, slightly off-topic, but I noticed that the declaration
> `DiagnoseMisalignedMembers` in the header has a doc comment that violates the
> 80 chars rule. I committed a fix in r283228.
I meant to say
arphaman added a comment.
Thanks for working on this!
This patch fixes a couple of our internal warnings that shouldn't be presented.
I included a code sample that reproduces our warnings, would you mind adding
some code to the test case that's similar to the sample below?
typedef
arphaman updated this revision to Diff 73898.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch uses Adrian's suggestion.
Repository:
rL LLVM
https://reviews.llvm.org/D25321
Files:
lib/Analysis/ReachableCode.cpp
test/Sema/warn-unreachable.c
Index:
arphaman added inline comments.
Comment at: clang-refactor/driver/Driver.cpp:36
@@ +35,3 @@
+argv[1] = (llvm::Twine(argv[0]) + " " +
llvm::Twine(argv[1])).str().c_str();
+Manager.dispatch(Command, argc - 1, argv + 1);
+ } else {
Is there a particular
arphaman added inline comments.
Comment at: clang-refactor/core/SymbolIndexClient.h:31
@@ +30,3 @@
+} // end namespace refactor
+} // end namespace refactor
+
End namespace clang?
https://reviews.llvm.org/D24192
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a bug that's tracked by PR 10758 and duplicates like PR 30343.
The bug causes clang to crash with a stack
arphaman added a comment.
In https://reviews.llvm.org/D25040#556165, @vsk wrote:
> In https://reviews.llvm.org/D25040#556109, @arphaman wrote:
>
> > Thanks for working on this, I have a couple of comments/questions:
> >
> > - The current logic doesn't work correctly for a test case that's shown
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282554: [Coverage] The coverage region for switch covers the
code after the switch. (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D24981?vs=72692=72733#toc
Repository:
rL
Author: arphaman
Date: Tue Sep 27 18:30:36 2016
New Revision: 282554
URL: http://llvm.org/viewvc/llvm-project?rev=282554=rev
Log:
[Coverage] The coverage region for switch covers the code after the switch.
This patch fixes a regression introduced in r262697 that changed the way the
coverage
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the displayed diagnostics when encountering a redefinition
of a function whose previous definition was
arphaman created this revision.
arphaman added reviewers: aaron.ballman, rogfer01.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the packed member warning by showing the name of the
anonymous structure/union when it was
arphaman removed rL LLVM as the repository for this revision.
arphaman updated this revision to Diff 73076.
arphaman added a comment.
I had to reuploaded the diff as Phabricator seemed to have removed the 'lib'
and 'test' paths prefixes from the filenames in the original diff.
arphaman set the repository for this revision to rL LLVM.
arphaman updated this revision to Diff 73338.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Update to the patch that follows Aaron's comments:
- Uses the explicit type name instead of auto.
- Expands the test by
arphaman created this revision.
arphaman added reviewers: rsmith, rjmccall.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a crash that happens because of an assertion failure in C mode
only. The assertion failure happens
arphaman added a comment.
In https://reviews.llvm.org/D25131#558004, @rsmith wrote:
> Minor comment, otherwise LGTM.
This makes sense, thanks for pointing it out!
I'll update the comment when I commit.
Repository:
rL LLVM
https://reviews.llvm.org/D25131
Author: arphaman
Date: Mon Oct 3 07:12:03 2016
New Revision: 283102
URL: http://llvm.org/viewvc/llvm-project?rev=283102=rev
Log:
Fix PR 28885: Fix AST Printer output for the inherited constructor using
declarations.
This commit ensures that the correct record type is printed out for the
using
Author: arphaman
Date: Mon Oct 3 07:17:56 2016
New Revision: 283104
URL: http://llvm.org/viewvc/llvm-project?rev=283104=rev
Log:
Revert r283102 (Typo in the phabricator link)
Modified:
cfe/trunk/lib/AST/DeclPrinter.cpp
cfe/trunk/test/SemaCXX/cxx11-ast-print.cpp
Modified:
Author: arphaman
Date: Mon Oct 3 07:22:17 2016
New Revision: 283105
URL: http://llvm.org/viewvc/llvm-project?rev=283105=rev
Log:
Fix PR 28885: Fix AST Printer output for the inherited constructor using
declarations.
This commit ensures that the correct record type is printed out for the
using
arphaman created this revision.
arphaman added a reviewer: vsk.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a regression introduced in r262697 that changed the way the
coverage regions for switch are constructed. The PGO
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch ensures that the AST printer outputs the correct C++ type for an
inheriting constructor using declaration.
For
arphaman created this revision.
arphaman added reviewers: manmanren, doug.gregor.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves code completion for properties that are declared in
Objective-C protocols by making sure that
arphaman updated this revision to Diff 75877.
arphaman added a comment.
The updated patch incorporates John's suggestions into code.
Repository:
rL LLVM
https://reviews.llvm.org/D25937
Files:
lib/Sema/SemaDecl.cpp
test/SemaCXX/warn-everthing.cpp
test/SemaCXX/warn-unused-variables.cpp
arphaman created this revision.
arphaman added a reviewer: aaron.ballman.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch adds a bit of documentation for the `transparent_union` attribute.
Repository:
rL LLVM
arphaman created this revision.
arphaman added reviewers: aaron.ballman, jordan_rose.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch adds an `objc_subclassing_restricted` attribute into clang. This
attribute acts similarly to
arphaman added a comment.
Hi Paul,
Are you planning to work on this patch? If not, can I take a shot at it?
Cheers,
Alex
https://reviews.llvm.org/D16533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman created this revision.
arphaman added a reviewer: akyrtzi.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch implements a heuristic that I mentioned in
https://reviews.llvm.org/D25520. When completing blocks properties that
arphaman updated this revision to Diff 77205.
arphaman marked 2 inline comments as done.
arphaman added a comment.
The updated patch introduces a new warning group named
`-Wshadow-uncaptured-local` that was suggested by Reid.
Repository:
rL LLVM
https://reviews.llvm.org/D26278
Files:
arphaman updated this revision to Diff 77201.
arphaman added a comment.
The updated patch preserves the old behaviour in `-Wshadow-all`
Repository:
rL LLVM
https://reviews.llvm.org/D26278
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
arphaman accepted this revision.
arphaman added a reviewer: arphaman.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman created this revision.
arphaman added reviewers: rnk, rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This is a follow-up patch to r286354. This patch avoids the -Wshadow warning
for variables which shadow variables that aren't
Author: arphaman
Date: Wed Nov 9 07:43:18 2016
New Revision: 286363
URL: http://llvm.org/viewvc/llvm-project?rev=286363=rev
Log:
[CodeCompletion] Show block invocation results for block property setters
This commit changes the code completion results for block property setters:
The default
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286363: [CodeCompletion] Show block invocation results for
block property setters (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26071?vs=76178=77337#toc
Repository:
rL
Author: arphaman
Date: Wed Nov 9 08:02:18 2016
New Revision: 286365
URL: http://llvm.org/viewvc/llvm-project?rev=286365=rev
Log:
[AST] Dump dependent scope member expression with its member name
Modified:
cfe/trunk/lib/AST/ASTDumper.cpp
cfe/trunk/test/Misc/ast-dump-stmt.cpp
Modified:
arphaman added reviewers: rsmith, bruno.
arphaman set the repository for this revision to rL LLVM.
arphaman updated this revision to Diff 77351.
arphaman added a comment.
I rebased the patch, adjusted the test and added a test case for Objective-C
blocks.
Repository:
rL LLVM
Author: arphaman
Date: Wed Nov 9 04:38:57 2016
New Revision: 286354
URL: http://llvm.org/viewvc/llvm-project?rev=286354=rev
Log:
[Sema] Avoid -Wshadow warnings for shadowed variables that aren't captured
by lambdas with an explicit capture list
This commit avoids the -Wshadow warning for
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286354: [Sema] Avoid -Wshadow warnings for shadowed
variables that aren't captured (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26278?vs=77205=77328#toc
Repository:
rL
arphaman added a comment.
This has already been fixed in r276352. I closed PR25961.
https://reviews.llvm.org/D21126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman accepted this revision.
arphaman added a reviewer: arphaman.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks.
https://reviews.llvm.org/D22770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman added a comment.
I looked at the way `HasFallthroughStmt` is used, and it didn't seem so, no.
It's used in the following manner in AnalysisBasedWarnings.cpp:
bool FallThroughDiagFull =
!Diags.isIgnored(diag::warn_unannotated_fallthrough, D->getLocStart());
bool
Author: arphaman
Date: Mon Nov 7 10:56:19 2016
New Revision: 286121
URL: http://llvm.org/viewvc/llvm-project?rev=286121=rev
Log:
[www] Update the link to the 'include what you use' project
Modified:
cfe/trunk/www/related.html
Modified: cfe/trunk/www/related.html
URL:
arphaman added a comment.
In https://reviews.llvm.org/D26406#590741, @kastiglione wrote:
> Thanks @arphaman, are you able to commit this?
Yes, I can commit this for you. Let me know what commit message I should use.
https://reviews.llvm.org/D26406
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286465: [Sema] Avoid -Wshadow warnings for shadowed
variables that (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26448?vs=77335=77492#toc
Repository:
rL LLVM
Author: arphaman
Date: Thu Nov 10 10:19:11 2016
New Revision: 286465
URL: http://llvm.org/viewvc/llvm-project?rev=286465=rev
Log:
[Sema] Avoid -Wshadow warnings for shadowed variables that
aren't captured by lambdas with a default capture specifier
This commit is a follow-up to r286354. It
arphaman created this revision.
arphaman added reviewers: manmanren, bruno.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the 'expected identifier' errors that are presented when a
C++ keyword is used as an identifier in
arphaman added a comment.
It seems sufficient enough, I will commit it with the summary. Thanks!
https://reviews.llvm.org/D26406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Thu Nov 10 12:30:26 2016
New Revision: 286487
URL: http://llvm.org/viewvc/llvm-project?rev=286487=rev
Log:
Add -Wduplicate-protocol for existing diagnostic
Expose a warning flag for warn_duplicate_protocol_def. This allows control
over the severity of duplicate protocol
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286487: Add -Wduplicate-protocol for existing diagnostic
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26406?vs=77232=77514#toc
Repository:
rL LLVM
Author: arphaman
Date: Tue Oct 18 05:55:01 2016
New Revision: 284472
URL: http://llvm.org/viewvc/llvm-project?rev=284472=rev
Log:
[CodeCompletion] Add a block property setter completion result
This commit changes code completion results for Objective-C block properties:
clang now suggests an
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes an assertion failure crash that happens when a constant record
reference member is initialized using an empty
Author: arphaman
Date: Tue Oct 18 05:38:58 2016
New Revision: 284468
URL: http://llvm.org/viewvc/llvm-project?rev=284468=rev
Log:
[CodeCompletion][NFC] Extract a function that formats block placeholders.
This commit extracts a new function named `formatBlockPlaceholder` from
the function
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284472: [CodeCompletion] Add a block property setter
completion result (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25520?vs=74528=74977#toc
Repository:
rL LLVM
arphaman added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D25051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Tue Oct 18 05:35:27 2016
New Revision: 284467
URL: http://llvm.org/viewvc/llvm-project?rev=284467=rev
Log:
[CodeCompletion][NFC] Extract a function that looks for block decl type locs.
This commit extracts a new function named `findTypeLocationForBlockDecl` from
the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284467: [CodeCompletion][NFC] Extract a function that looks
for block decl type locs. (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25519?vs=74520=74972#toc
Repository:
arphaman created this revision.
arphaman added a reviewer: manmanren.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the '-Wformat' warnings by ensuring that the formatting
checker can see through Objective-C message sends
arphaman updated this revision to Diff 75279.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch adds a comment to the modified code as request by Manman.
Repository:
rL LLVM
https://reviews.llvm.org/D25777
Files:
lib/Sema/TreeTransform.h
arphaman created this revision.
arphaman added reviewers: dblaikie, majnemer.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the mismatched destructor type error by detecting when the
destructor call has used a '.' instead
arphaman added a comment.
Thanks for working on this! I have a couple of comments:
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1762
def err_init_incomplete_type : Error<"initialization of incomplete type %0">;
+def err_list_init_in_parens : Error<"list-initializer
arphaman added a comment.
In https://reviews.llvm.org/D25520#569389, @akyrtzi wrote:
> > What do you think of the following possible priority heuristic
>
> SGTM.
>
> Changes LGTM. I'd also recommend that as a follow-up patch it would be great
> to extend the setter completion to variables as
arphaman created this revision.
arphaman added reviewers: rjmccall, rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes a NULL pointer crash that happens when clang is trying to
create an implicit default constructor for a
arphaman created this revision.
arphaman added reviewers: rjmccall, thakis.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch makes the `-Wunused-variable` warning behaviour more consistent: Now
clang won't warn on variables with
1 - 100 of 625 matches
Mail list logo
