[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

aganea added a comment. Thanks for fixing this @zturner. I simply want to back-up what @probinson says above - most of the games we do at Ubisoft are currently using a different compilation toolchains for each platform (we ship at least 4-5 platforms for each top game). It can be clang or it

[PATCH] D51380: Fix incorrect usage of std::error_category

aganea created this revision. aganea added reviewers: ilya-biryukov, zturner. Herald added a subscriber: cfe-commits. As mentionned here , this change prevents a dangling pointer in `std:error_code` by using a singleton. Repository: rC Clang

[PATCH] D51380: Fix incorrect usage of std::error_category

aganea added a comment. Thank you! Repository: rC Clang https://reviews.llvm.org/D51380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51380: Fix incorrect usage of std::error_category

This revision was automatically updated to reflect the committed changes. Closed by commit rC340929: [Preamble] Fix incorrect usage of std::error_category (authored by aganea, committed by ). Repository: rC Clang https://reviews.llvm.org/D51380 Files: lib/Frontend/PrecompiledPreamble.cpp

[PATCH] D51806: [clang-cl] Enable -march

aganea created this revision. aganea added reviewers: thakis, ddunbar, hans. Herald added a subscriber: cfe-commits. Currently, `-march` does not work in the `clang-cl` driver. We are currently migrating from MSVC. The project size makes that we have to stick with `clang-cl` for a little while.

[PATCH] D51806: [clang-cl] Enable -march

aganea added a comment. @hans I want to target precisely a given CPU when using `clang-cl`. The options in the `m_x86_Features_Group` are too granular. It is easier to just add `-march=skylake` on the cmd-line. Is there any other way? Repository: rC Clang https://reviews.llvm.org/D51806

[PATCH] D51806: [clang-cl] Enable -march

aganea updated this revision to Diff 164666. aganea added a comment. Updated diff with coverage test as requested. Repository: rC Clang https://reviews.llvm.org/D51806 Files: include/clang/Driver/Options.td test/Driver/cl-options.c Index: test/Driver/cl-options.c

[PATCH] D51806: [clang-cl] Enable -march

aganea added a comment. @hans Just an after thought: maybe we should prevent usage of `-march=` and `/arch:` at the same time. What do you think? I can add another patch for that purpose. Repository: rC Clang https://reviews.llvm.org/D51806

[PATCH] D51806: [clang-cl] Enable -march

aganea added a comment. Thank you! Repository: rC Clang https://reviews.llvm.org/D51806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51806: [clang-cl] Enable -march

This revision was automatically updated to reflect the committed changes. Closed by commit rC341847: [clang-cl] Enable -march option (authored by aganea, committed by ). Repository: rC Clang https://reviews.llvm.org/D51806 Files: include/clang/Driver/Options.td test/Driver/cl-options.c

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. In https://reviews.llvm.org/D52193#1243456, @thakis wrote: > ...and to reword this a bit: Clang taking a long time to start up in some > configurations is a bug we should profile and fix :-) This is time spent in `ntdll.dll` loading various low-level libraries like

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. In https://reviews.llvm.org/D52193#1260862, @zturner wrote: > I can try to get some timings from my machine. How do we handle crash > recovery in the case where we don't spawn a child process? I thought the > whole reason for spawning the cc1 driver as a separate

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. Updated tests again. This time I've closed all applications, all unused services, and tried to have a "clean" machine. New timings without the child `clang-cl.exe` being invoked (hacked from https://reviews.llvm.org/D52411). The test consists in building Clang+LLVM+LLD

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. In https://reviews.llvm.org/D52193#1241056, @zturner wrote: > The process stuff looks cool and useful independently of `/MP`. Would it be > possible to break that into a separate patch, and add a unit test for the > behavior of the `WaitAll` flag? Of course, will do.

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea marked an inline comment as done. aganea added a comment. It seems Reid's change has done good: `cmake` is not as significant as before in the build process. See below the improved timings: The tests consist in a full cleanup (delete build folder), cmake to regenerate, then a full

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. > clang-cl isn't supposed to do (explicit) registry accesses when you hold it > right (pass in -fms-compatibility-version etc). Have you seen registry access > costs, or is that speculation? Please see this log: F7268226: clang-cl-log.zip

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. In https://reviews.llvm.org/D52193#1239171, @hans wrote: > Thanks for adding the Ninja numbers. It confirms that Ninja is significantly > faster than MSBuild + /MP. It is true for the 6-cores Xeon, but not for the dual-18-cores. I think there are two issues there,

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. > clang-cl isn't supposed to do (explicit) registry accesses when you hold it > right (pass in -fms-compatibility-version etc). Have you seen registry access > costs, or is that speculation? No speculation, I will share the FileMon logs shortly. It is indirectly

[PATCH] D11850: Delay emitting members of dllexport classes until the class is fully parsed (PR23542)

aganea added subscribers: belkiss, rnk, aganea. aganea added a comment. Herald added a subscriber: llvm-commits. Cross-referencing PR40006 . It seems to be a different manifestation of this same bug. @hans Could you possibly take a look at the bug

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea created this revision. aganea added reviewers: rnk, hans, zturner. Herald added a reviewer: JDevlieghere. Herald added a subscriber: cfe-commits. This is very preliminary change which adds support for (`clang-cl`) `/MP` (Build with multiple processes). Doc for `/MP` is here

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. In https://reviews.llvm.org/D52193#1238944, @zturner wrote: > In https://reviews.llvm.org/D52193#1238923, @aganea wrote: > > > The goal of this change is frictionless compilation into VS2017 when using > > `clang-cl` as a compiler. We've realized that compiling Clang+LLD

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. The goal of this change is frictionless compilation into VS2017 when using `clang-cl` as a compiler. We've realized that compiling Clang+LLD with Clang generates a faster executable that with MSVC (even latest one). I currently can't see a good way of generating the

[PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM. With a few minor comments: Comment at: llvm/include/llvm/DebugInfo/CodeView/TypeDeserializer.h:122 ~FieldListDeserializer() override { -CVType FieldList; -

[PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:29 +/// Carrying the size separately instead of trusting the size stored in the +/// record prefix provides some extra safety and flexibility. template class CVRecord {

[PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea marked an inline comment as done. aganea added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:29 +/// Carrying the size separately instead of trusting the size stored in the +/// record prefix provides some extra safety and flexibility.

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

aganea created this revision. aganea added reviewers: rnk, scott.linder, uabelho, aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compiling from an already preprocessed CPP, the checksums generated in the debug info would be those of the (input) preprocessed

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

aganea updated this revision to Diff 193886. aganea marked 2 inline comments as done. aganea edited the summary of this revision. aganea added a comment. I made a more elegant change, where no additional lookups or string compares are required. I noted btw that clang /E does not generate

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

aganea added a comment. I'll try profiling several solution on a large unity/jumbo file and get back with some results. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

aganea added a comment. In D60283#1456497 , @thakis wrote: > See > http://llvm-cs.pcc.me.uk/tools/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp#756 > for a "is same file" example. I'm not sure adding a bool to PresumedLoc is > worth it for this.

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

aganea added a comment. That is strange. As you can’t mix /Yc and /Yu on the command line, MSBuild should issue two different calls to clang-cl, one with /Yc and one /Yu /MP. Can you check with ProcMon that commands are issued in the right order? Repository: rC Clang CHANGES SINCE LAST

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea updated this revision to Diff 199659. aganea marked 3 inline comments as done. aganea added a comment. In D60283#1503256 , @probinson wrote: > Minor stuff. This solution is surprisingly simple, the main question being > (and I don't have an

[PATCH] D61914: [Support][Test] Time profiler: add regression test

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. Thanks Anton! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61914/new/ https://reviews.llvm.org/D61914

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

aganea added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/regular_cdb.json:4 + "directory": "DIR", + "command": "clang -c DIR/regular_cdb.cpp -IInputs -MD -MF DIR/regular_cdb.d", + "file": "DIR/regular_cdb.cpp" Is `-MD -MF` required for

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

aganea accepted this revision. aganea added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/ClangScanDeps/Inputs/regular_cdb.json:4 + "directory": "DIR", + "command": "clang -c DIR/regular_cdb.cpp -IInputs -MD -MF DIR/regular_cdb.d", +

[PATCH] D63290: Unify DependencyFileGenerator class and DependencyCollector interface

aganea added a reviewer: benlangmuir. aganea added inline comments. Comment at: clang/include/clang/Frontend/Utils.h:118 /// Builds a depdenency file when attached to a Preprocessor (for includes) and /// ASTReader (for module imports), and writes it out at the end of

[PATCH] D63290: Unify DependencyFileGenerator class and DependencyCollector interface

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63290/new/ https://reviews.llvm.org/D63290 ___ cfe-commits mailing list

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

aganea added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32 +class DependencyCollectorFactory { +public: Do you envision future uses for this factory? Comment at:

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

aganea added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32 +class DependencyCollectorFactory { +public: arphaman wrote: > aganea wrote: > > Do you envision future uses for this factory? > Most likely, yes. > > I don't want to

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM! Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63579/new/ https://reviews.llvm.org/D63579 ___ cfe-commits mailing list

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

aganea created this revision. aganea added reviewers: hans, thakis, rsmith. aganea added a project: clang. Previously, `-fdiagnostics-absolute-paths` did not have an effect in some cases, for example: when using relative include paths, or relative CPP paths, or `--show-includes`, or `-E` or

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

This revision was automatically updated to reflect the committed changes. Closed by commit rC360467: Fixed tests where grep was not matching the linefeed (authored by aganea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61496?vs=197990=199069#toc Repository: rC Clang

[PATCH] D61914: [Support][Test] Time profiler: add regression test

aganea added a comment. Could you please move the test to a more approriate location? (ie. clang/trunk/test/Driver/) Comment at: clang/tools/driver/cc1_main.cpp:245 + +llvm::errs() << "Time trace json-file dumped to " << Path.str() << "\n"; +llvm::errs()

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea added a comment. Ping! Any further comments? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/ https://reviews.llvm.org/D60283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

This revision was automatically updated to reflect the committed changes. Closed by commit rC361296: [DebugInfo] Dont emit checksums when compiling a preprocessed CPP (authored by aganea, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/

[PATCH] D61945: ftime-trace as a CoreOption

This revision was automatically updated to reflect the committed changes. Closed by commit rL360907: ftime-trace as a CoreOption (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea updated this revision to Diff 199599. aganea marked an inline comment as done. aganea added a comment. Updated again with a different solution. We can't just act on `Entry.getFile().hasLineDirectives()` because a directive such as `#line 100` simply overrides the `__LINE__`, not

[PATCH] D61945: ftime-trace as a CoreOption

aganea created this revision. aganea added reviewers: thakis, anton-afanasyev. aganea added a project: clang. As suggested here by @thakis , make so that `-ftime-trace` can be used directly in clang-cl without `-Xclang` Repository: rC Clang

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea added a comment. Ping! Is this good to go? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42642: [CUDA] Detect installation in PATH

aganea added a subscriber: rnk. aganea added a comment. So it turns out this is a symlink issue. The file `clang/trunk/test/Driver/Inputs/CUDA-symlinks/usr/bin/ptxas` has been synchronized on my Windows 10 PC as a regular text file, not a symlink. It looks like TortoiseSVN doesn't implement

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea marked an inline comment as done. aganea added a comment. In D61046#1486850 , @rnk wrote: > The only remaining change I find questionable is the R600 backend change creduce'd and reported here:

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

This revision was automatically updated to reflect the committed changes. Closed by commit rL360044: Fix compilation warnings when compiling with GCC 7.3 (authored by aganea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61046?vs=196655=198265#toc Repository: rL LLVM

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/trunk/test/Preprocessor/indent_macro.c:1-2 -// RUN: %clang_cc1 -E %s | grep '^ zzap$' +// RUN: %clang_cc1 -E %s | FileCheck %s --match-full-lines --strict-whitespace +// CHECK: zzap

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

aganea added a comment. In D61496#1489523 , @probinson wrote: > Checked-in files should not have CRLF endings, in general (there are a very > few exceptions, and these aren't among them). > If the checked-in files have LF endings but your tool checks

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

aganea updated this revision to Diff 197990. aganea added a comment. Changed to use `FileCheck` instead of `grep` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61496/new/ https://reviews.llvm.org/D61496 Files: clang/trunk/test/Preprocessor/indent_macro.c

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

aganea created this revision. aganea added reviewers: rnk, jlebar. aganea added a project: clang. Herald added a subscriber: mstorsjo. aganea edited the summary of this revision. The files below have been synced by Tortoise as CRLF, and it looks like they are like that in the depot as well (I'm

[PATCH] D63681: [clang-scan-deps] Introduce the DependencyScanning library with the thread worker code and better error handling

aganea added a subscriber: rnk. aganea added a comment. A bit more detail on what we're seeing on our end (specs in the post above). The 'Count' column represents the number of 1ms samples taken in that function. The 'Weight' column is cumulated times for all cores, for a given process, in ms.

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea marked 3 inline comments as done. aganea added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } rnk wrote: > nikic wrote: > > shafik wrote: > > > aganea wrote: > > > > Fixes > > > > ``` > > > > [2097/2979]

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea updated this revision to Diff 196505. aganea marked 7 inline comments as done. aganea added a comment. Adressed some of the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 Files: clang/trunk/unittests/AST/ASTImporterTest.cpp

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea added inline comments. Comment at: llvm/trunk/lib/Target/AMDGPU/R600ISelLowering.cpp:1717-1722 +// Fix spurious warning with gcc 7.3 -O3 for NewBldVec[i] below +// warning: array subscript is above array bounds [-Warray-bounds] +#if defined(__GNUC__) && __GNUC__

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea updated this revision to Diff 196655. aganea marked 3 inline comments as done. aganea added a comment. Please let me know if other changes are needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 Files:

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea added inline comments. Comment at: llvm/trunk/unittests/Transforms/Scalar/CMakeLists.txt:14-17 +# Workaround for the gcc 6.1 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. +if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0) +

[PATCH] D42642: [CUDA] Detect installation in PATH

aganea added a comment. Herald added a project: LLVM. Just a quick heads-up - the `cuda-detect-path.cu` test fails on WSL/Ubuntu 18.04: aganea@MTL-BJ842:/mnt/f/svn/buildWSL$ /usr/bin/python3.6 bin/llvm-lit -vv ../clang/test/Driver/cuda-detect-path.cu llvm-lit:

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea updated this revision to Diff 196321. aganea retitled this revision from "[clang-cl] Don't emit checksums when compiling a preprocessed CPP" to "[DebugInfo] Don't emit checksums when compiling a preprocessed CPP". aganea added a comment. Herald added a project: LLVM. Herald added a

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea marked 5 inline comments as done. aganea added inline comments. Comment at: clang/trunk/unittests/AST/ASTImporterTest.cpp:4054 +} } Fixes ``` [2097/2979] Building CXX object

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea created this revision. aganea added reviewers: spatel, rnk, nikic, chandlerc, MaskRay, martong, ioeric. aganea added projects: LLVM, clang, lld. Herald added subscribers: rnkovacs, arichardson, mgorny, nhaehnle, jvesely, mehdi_amini, emaste, arsenm. Herald added a reviewer: espindola.

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea updated this revision to Diff 196358. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 Files: clang/trunk/unittests/AST/ASTImporterTest.cpp clang/trunk/unittests/Tooling/LookupTest.cpp lld/trunk/ELF/LinkerScript.cpp

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea added a comment. Thanks Paul, your solution is even better. I'll apply rL11 locally - if everything's fine, do you mind if I re-land it again? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60283/new/

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

aganea added a comment. Ping! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63648/new/ https://reviews.llvm.org/D63648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63681: [clang-scan-deps] Introduce the DependencyScanning library with the thread worker code and better error handling

aganea added a comment. LGTM! Some quick stats on our end (running Windows 10 on a Intel W-2135, 6-core, 3.7 GHz, NVMe SSD): on a large .SLN compiling approx. 16,000 .CPP files through 600 unity .CPPs and 23,000 .H files, out of **86 secs** spent in `ClangScanDeps`, about **32 secs** are

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea created this revision. aganea added reviewers: rnk, aprantl. aganea added a project: clang. Previously, when clang was compiled with -DLLVM_ENABLE_ASSERTIONS=ON, the attached test was yielding: inlinable function call in a function with debug info must have a !dbg location call

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea updated this revision to Diff 216046. aganea marked 4 inline comments as done. aganea added a comment. As requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeclCXX.cpp

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

aganea abandoned this revision. aganea added a comment. Please see the other reviews I've sent. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65906/new/ https://reviews.llvm.org/D65906 ___ cfe-commits mailing list

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea updated this revision to Diff 216474. aganea added a comment. Use proper test file. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556 Files: lib/Lex/DependencyDirectivesSourceMinimizer.cpp

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea created this revision. aganea added reviewers: arphaman, dexonsmith, Bigcheese. aganea added a project: clang. Herald added a subscriber: tschuett. Previously, an `#error` directive with quoted, multi-line content, along with CR+LF line endings wasn't handled correctly. Repository: rC

[PATCH] D66550: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include

aganea created this revision. aganea added reviewers: arphaman, dexonsmith, Bigcheese. aganea added a project: clang. Herald added a subscriber: tschuett. aganea retitled this revision from "[clang-scan-deps] Correctly skip over double slashes in angle bracket #include" to "[clang-scan-deps]

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea updated this revision to Diff 216233. aganea marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeclCXX.cpp test/CodeGenCXX/debug-info-atexit-stub.cpp

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea added inline comments. Comment at: test/CodeGenCXX/debug-info-atexit-stub.cpp:14 + +// CHECK: define internal void @"??__Ff@?1??d@@YAPEAU?$c@UBXZ@YAXXZ"() +// CHECK-SAME: !dbg ![[SUBPROGRAM:[0-9]+]] { probinson wrote: > Do these Windows-mangled names

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer

aganea created this revision. aganea added reviewers: arphaman, dexonsmith, Bigcheese. aganea added a project: clang. Herald added a subscriber: tschuett. As per title. Repository: rC Clang https://reviews.llvm.org/D66511 Files: lib/Lex/DependencyDirectivesSourceMinimizer.cpp

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL369458: [DebugInfo] Add debug location to dynamic atexit destructor (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

aganea added a comment. In D63648#1593619 , @thakis wrote: > - Does fastbuild have something like distcc-pump? Fastbuild works like plain distcc and unfortunately it does not have pump mode. > - IIRC we used to use fdiagnostics-absolute-paths in

[PATCH] D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer

aganea marked an inline comment as done. aganea added inline comments. Comment at: lib/Lex/DependencyDirectivesSourceMinimizer.cpp:822 bool Minimizer::minimizeImpl(const char *First, const char *const End) { + skipUTF8ByteOrderMark(First, End); while (First != End)

[PATCH] D66550: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include

This revision was automatically updated to reflect the committed changes. Closed by commit rL369988: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle… (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea updated this revision to Diff 217292. aganea added a reviewer: rsmith. aganea added a comment. This failed the build - I've changed `unix2dos` to `svn:eol-style CRLF` instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556 Files:

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea updated this revision to Diff 217298. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeclCXX.cpp test/CodeGenCXX/debug-info-atexit-stub.cpp

[PATCH] D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer

This revision was automatically updated to reflect the committed changes. Closed by commit rL369993: [clang-scan-deps] Skip UTF-8 BOM in source minimizer (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

This revision was automatically updated to reflect the committed changes. Closed by commit rL369986: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF… (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea reopened this revision. aganea added a reviewer: hans. aganea added a comment. This revision is now accepted and ready to land. Re-opening this because the previous commit broke Chromium. - Added a new test

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea updated this revision to Diff 217179. aganea added a comment. Fixed unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556 Files: lib/Lex/DependencyDirectivesSourceMinimizer.cpp

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL370129: Re-land [clang-scan-deps] Minimizer: Correctly handle multi-line content with… (authored by aganea, committed by

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea updated this revision to Diff 217527. aganea added subscribers: jyknight, rnk. aganea added a comment. In D66556#1647669 , @arphaman wrote: > Will the git monorepo handle `svn:eol-style` correctly? Other files in the repo already use

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

aganea marked an inline comment as done. aganea added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3581 +llvm::DILocalScope *PrevScope = +!LexicalBlockStack.empty() +? dyn_cast(LexicalBlockStack.back()) aganea wrote: > rnk

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

aganea added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3581 +llvm::DILocalScope *PrevScope = +!LexicalBlockStack.empty() +? dyn_cast(LexicalBlockStack.back()) rnk wrote: > Is it OK to look up the lexical block stack at this

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

aganea updated this revision to Diff 218515. aganea marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 Files: include/clang/AST/GlobalDecl.h lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeclCXX.cpp

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea added a comment. In D66556#1648591 , @hans wrote: > In D66556#1648118 , @dexonsmith > wrote: > > > In D66556#1648109 , @rnk wrote: > > > > > I'm not sure what

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea added a comment. rL370219 and rG3c307370c8f8 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

aganea updated this revision to Diff 217968. aganea retitled this revision from "[DebugInfo] Add debug location to dynamic atexit destructor" to "[DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial". aganea added a comment. More tagging functions as

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea updated this revision to Diff 217055. aganea marked 2 inline comments as done. aganea added a comment. As requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556 Files: lib/Lex/DependencyDirectivesSourceMinimizer.cpp

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea added a comment. In D66328#1647062 , @probinson wrote: > I don't see a test for the __cxx_global_array_dtor case? It is actually the `arraydestroy.*` loop that is covered (generated by `CodeGenFunction::emitArrayDestroy`), please see

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

This revision was automatically updated to reflect the committed changes. Closed by commit rL371080: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as… (authored by aganea, committed by ). Changed prior to commit:

  1   2   3   4   5   >