bader added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1426
@@ +1425,3 @@
+struct PipeTypeInfo : TypeInfoCommon {
+/// The access writes.
+unsigned AccessWrites : 3;
pekka.jaaskelainen wrote:
> I think this needs a better comment than
bader created this revision.
bader added reviewers: pekka.jaaskelainen, gbenyei.
bader added a subscriber: cfe-commits.
Initial support for OpenCL 2.0 feature: pipe types.
http://reviews.llvm.org/D14441
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DataRecursiveASTVisitor.h
bader created this revision.
bader added a subscriber: cfe-commits.
http://reviews.llvm.org/D12378
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/cond.cl
Index: test/SemaOpenCL/cond.cl
Author: bader
Date: Sun Aug 30 13:06:39 2015
New Revision: 246393
URL: http://llvm.org/viewvc/llvm-project?rev=246393view=rev
Log:
[OpenCL] Improve diagnostics detecting implicit vector conversion.
Reviewers: pekka.jaaskelainen
Differential Revision: http://reviews.llvm.org/D12470
Modified:
bader added a comment.
In http://reviews.llvm.org/D12855#246004, @pekka.jaaskelainen wrote:
> The patch seems straightforward enough. BTW does someone know if anyone has
> worked on the 'pipe' qualifier?
I'm currently supporting Intel's implementation of 'pipe' qualifier and I'd
like to
Author: bader
Date: Tue Sep 15 06:18:52 2015
New Revision: 247676
URL: http://llvm.org/viewvc/llvm-project?rev=247676=rev
Log:
[OpenCL] Add new types for OpenCL 2.0.
Patch by Pedro Ferreira.
Reviewers: pekka.jaaskelainen
Differential Revision: http://reviews.llvm.org/D12855
Modified:
bader created this revision.
bader added a reviewer: pekka.jaaskelainen.
bader added a subscriber: cfe-commits.
Patch by Pedro Ferreira.
This patch was reviewed here:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20150629/thread.html#131992,
but wasn't submitted into the tree.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247676: [OpenCL] Add new types for OpenCL 2.0. (authored by
bader).
Changed prior to commit:
http://reviews.llvm.org/D12855?vs=34709=34796#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12855
bader added a subscriber: bader.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7472-7473
@@ -7469,4 +7471,4 @@
"sampler type cannot be used with the __local and __global address space
qualifiers">;
def err_opencl_global_invalid_addr_space : Error<
- "global
bader abandoned this revision.
bader added a comment.
New version of this patch was uploaded by pxli168 at
http://reviews.llvm.org/D15603.
http://reviews.llvm.org/D14441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bader added a comment.
Hi guys,
Sorry for long silence.
Unfortunately, I just can't find time to finish with this patch.
Xiuli provided a valid test case that exposed issue with type caching, so I
decided to not commit at as is (although I applied other minor style comments
locally).
I'm
bader added inline comments.
Comment at: include/clang/AST/Type.h:5020
@@ +5019,3 @@
+/// PipeType - OpenCL20.
+///
+class PipeType : public Type, public llvm::FoldingSetNode {
Xuili, could you apply the comments left by Pekka and Anastasia for the
previous
bader accepted this revision.
Comment at: test/Headers/opencl-c-header.cl:30-31
@@ +29,4 @@
+
+// ===
+// Compile for OpenCL 2.0 for the first time. The module should change.
+// RUN: %clang_cc1 -cc1 -emit-llvm -o - -cl-std=CL2.0
-finclude-default-header -fmodules
bader added a comment.
Sorry for the delay.
Is this code valid:
clk_event_t e1, e2, e3;
clk_event_t events[] = {e1, e2};
enqueue_kernel(get_default_queue(), 0, get_ndrange(), 2, events, , ...);
With this patch clang rejects it with an error:
'illegal call to enqueue_kernel, expected
bader added a comment.
Hi Anastasia,
Sorry for the delay.
I have just a few comments.
Thanks,
Alexey
Comment at: lib/Sema/SemaChecking.cpp:95
@@ +94,3 @@
+ IllegalParams = true;
+ break;
+}
It looks like this function will report only first
bader accepted this revision.
bader added a comment.
LGTM.
Comment at: test/CodeGenOpenCL/kernel-attributes.cl:9
@@ -8,3 +10,1 @@
-// CHECK: opencl.kernels = !{[[MDNODE0:![0-9]+]], [[MDNODE3:![0-9]+]]}
-
AFAIK, this named metadata node were also useful for
bader added a subscriber: bader.
Comment at: test/SemaOpenCL/ternary-implicit-casts.cl:10-11
@@ +9,4 @@
+kernel void implicit_cast_generic(global int* gint, local int* lint, int cond)
{
+ // will compile, ptr is generic and can accept global and local
+ int* ptr =
bader added a comment.
If there are no objections to adopt this approach I can start working on
rebasing that patch to the ToT.
Comment at: include/clang/AST/OpenCLImageTypes.def:39
@@ +38,3 @@
+
+IMAGE_READ_TYPE(image1d, OCLImage1d)
+IMAGE_READ_TYPE(image1d_array,
bader added a comment.
In http://reviews.llvm.org/D17821#393387, @Anastasia wrote:
> Regarding, extending this approach for OpenCL pipe types too. I was thinking
> we could change current implementation to have ReadPipeType and
> WritePipeType. They can both be derived from PipeType that we
bader added a comment.
In http://reviews.llvm.org/D17821#394620, @Anastasia wrote:
> Yes, I think it's better to go in a separate commit, not to complicate this
> one too much. Also since there are not many comment here, I think we should
> try to commit it ASAP otherwise rebasing would be an
bader added inline comments.
Comment at: include/clang/AST/ASTContext.h:903
@@ +902,3 @@
+#define IMAGE_TYPE(ImgType, Id, SingletonId, Access, Suffix)
\
+ CanQualType SingletonId;
+#include "clang/AST/OpenCLImageTypes.def"
mgrang wrote:
>
Author: bader
Date: Wed Apr 13 03:33:41 2016
New Revision: 266180
URL: http://llvm.org/viewvc/llvm-project?rev=266180=rev
Log:
[OpenCL] Move OpenCLImageTypes.def from clangAST to clangBasic library.
Putting OpenCLImageTypes.def to clangAST library violates layering requirement:
"It's not OK for
Author: bader
Date: Wed Apr 13 04:54:47 2016
New Revision: 266187
URL: http://llvm.org/viewvc/llvm-project?rev=266187=rev
Log:
[modules] Add OpenCLImageTypes.def to module map to fix the modules build.
Modified:
cfe/trunk/include/clang/module.modulemap
Modified:
bader added a comment.
In http://reviews.llvm.org/D17821#394708, @bader wrote:
> In http://reviews.llvm.org/D17821#394620, @Anastasia wrote:
>
> > Yes, I think it's better to go in a separate commit, not to complicate this
> > one too much. Also since there are not many comment here, I think we
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265783: [OpenCL] Complete image types support. (authored by
bader).
Changed prior to commit:
http://reviews.llvm.org/D17821?vs=51303=53021#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17821
bader added inline comments.
Comment at: lib/Headers/opencl.h:2
@@ +1,3 @@
+//
+// SPIR Tools
+//
This comment should be updated.
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
bader added a comment.
In http://reviews.llvm.org/D18369#409011, @yaxunl wrote:
> In http://reviews.llvm.org/D18369#408773, @bader wrote:
>
> > BTW, there is a comment on GitHub that opencl.h might be a bad name for
> > that header, since Khronos group provides the header with the same name,
>
bader added a comment.
LGTM.
Probably it would be forth to add a simple test.
http://reviews.llvm.org/D19524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:81
@@ +80,3 @@
+static bool checkBlockArgs(Sema , Expr *BlockArg) {
+ const BlockPointerType *BPT = cast(BlockArg->getType());
+ ArrayRef Params =
There should be some check before cast.
Here is
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/CodeGenOpenCL/as_type.cl:6
@@ +5,3 @@
+
+//CHECK: define spir_func <3 x i8> @f1(<4 x i8> %[[x:.*]])
+//CHECK: %[[astype:.*]] = shufflevector <4 x i8>
bader added inline comments.
Comment at: include/clang/Basic/OpenCLExtensions.def:64
@@ +63,3 @@
+OPENCLEXT_INTERNAL(cl_khr_initialize_memory, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_spir, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U)
Minimum
bader accepted this revision.
bader added a comment.
LGTM. Thanks!
http://reviews.llvm.org/D19484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader accepted this revision.
bader added a reviewer: bader.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: bader
Date: Fri Apr 15 08:23:26 2016
New Revision: 266428
URL: http://llvm.org/viewvc/llvm-project?rev=266428=rev
Log:
Remove include duplicate. NFC.
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Sema/SemaType.cpp
URL:
bader added a comment.
Sam, could you also add declarations of samplerless read_image and write_image
built-in functions with read_write qualified images, please?
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
bader added inline comments.
Comment at: lib/Headers/opencl.h:14473-14474
@@ +14472,4 @@
+
+float4 __const_func __attribute__((overloadable)) read_imagef(read_only
image2d_t image, sampler_t sampler, int2 coord);
+float4 __const_func __attribute__((overloadable))
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bader added inline comments.
Comment at: lib/Headers/opencl.h:15372-15373
@@ +15371,4 @@
+ */
+int __const_func __attribute__((overloadable)) get_image_width(image1d_t
image);
+int __const_func __attribute__((overloadable))
get_image_width(image1d_buffer_t image);
+int
bader added inline comments.
Comment at: lib/Headers/opencl.h:14476-14479
@@ +14475,6 @@
+
+#ifdef _HAS_READ_WRITE_IMAGE
+float4 __attribute__((overloadable)) read_imagef(read_write image2d_t image,
sampler_t sampler, int2 coord);
+float4 __attribute__((overloadable))
bader added a comment.
LGTM
http://reviews.llvm.org/D19071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added a comment.
To clarify my last comment: I don't think we should define Image Query built-in
functions only for 'read_only' access qualifier in OpenCL 1.x.
It's just bug in OpenCL 1.x specifications. I think the intention was to
provide these built-in functions for both 'read_only'
bader added a subscriber: bader.
bader added a comment.
In http://reviews.llvm.org/D20602#438667, @rsmith wrote:
> I'm not suggesting it be treated as invalid. This extension is part of at
> least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is
> Clang's implementation of the
bader added inline comments.
Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:12
@@ -11,3 +11,3 @@
unsigned flags = 0;
- // CHECK: %ndrange = alloca %opencl.ndrange_t*
+ // CHECK: %ndrange = alloca %ndrange_t
ndrange_t ndrange;
Could you also
bader created this revision.
bader added reviewers: Anastasia, yaxunl.
bader added subscribers: cfe-commits, pxli168, pekka.jaaskelainen.
http://reviews.llvm.org/D21795
Files:
lib/Headers/opencl-c.h
Index: lib/Headers/opencl-c.h
bader updated this revision to Diff 62100.
bader added a comment.
Re-format the patch.
No functional changes.
http://reviews.llvm.org/D21744
Files:
lib/CodeGen/CodeGenFunction.cpp
test/CodeGenOpenCL/pipe_types.cl
Index: test/CodeGenOpenCL/pipe_types.cl
bader accepted this revision.
bader added a comment.
LGTM.
A few style nitpicks.
Comment at: lib/CodeGen/CGBuiltin.cpp:2180-2181
@@ +2179,4 @@
+}
+// Could have events and/or vaargs.
+if (NumArgs >= 5) {
+ if (E->getArg(3)->getType()->isBlockPointerType()) {
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
A few minor style comments.
Comment at: lib/Sema/SemaExpr.cpp:10806-10807
@@ -10816,4 +10805,4 @@
// the ATOMIC_VAR_INIT macro.
if
Author: bader
Date: Fri Jul 8 10:34:59 2016
New Revision: 274858
URL: http://llvm.org/viewvc/llvm-project?rev=274858=rev
Log:
[OpenCL] Fix access qualifiers handling for typedefs
OpenCL s6.6: "Access qualifier must be used with image object arguments
of kernels and of user-defined functions
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274858: [OpenCL] Fix access qualifiers handling for typedefs
(authored by bader).
Changed prior to commit:
http://reviews.llvm.org/D20948?vs=63222=63235#toc
Repository:
rL LLVM
Author: bader
Date: Thu Aug 4 13:06:27 2016
New Revision: 277743
URL: http://llvm.org/viewvc/llvm-project?rev=277743=rev
Log:
[OpenCL] Added underscores to the names of 'to_addr' OpenCL built-ins.
Summary:
In order to re-define OpenCL built-in functions
'to_{private,local,global}' in OpenCL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277743: [OpenCL] Added underscores to the names of 'to_addr'
OpenCL built-ins. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23120?vs=66653=66832#toc
Repository:
rL LLVM
bader added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:6773-6774
@@ -6772,4 +7016,2 @@
-namespace {
-
/// Structure recording the 'active' range of an integer-valued
The con of this change - it will export all the symbols from this unnamed
bader added a comment.
LGTM!
Thanks a lot for working on this.
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added a comment.
Ping.
Xiuli, do you have any comments?
http://reviews.llvm.org/D21744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bader
Date: Wed Jun 29 07:25:58 2016
New Revision: 274120
URL: http://llvm.org/viewvc/llvm-project?rev=274120=rev
Log:
[OpenCL] Fix typo in as_type test.
Reset astype variable in f6 function to avoid matching with wrong value from f5
function.
Modified:
bader created this revision.
bader added reviewers: Anastasia, yaxunl.
bader added a subscriber: cfe-commits.
In order to re-define OpenCL built-in functions
'to_{private,local,global}' in OpenCL run-time library LLVM names must
be different from the clang built-in function names.
bader updated this revision to Diff 70366.
bader added a comment.
Applied code review comment from Anastasia.
Use getTypeSizeInChars instead of getTypeSize to get type size in bytes. Assume
that char size is always one byte.
https://reviews.llvm.org/D23992
Files:
lib/CodeGen/CGBuiltin.cpp
bader updated this revision to Diff 70368.
bader added a comment.
Added get_pipe_num_packets and get_pipe_max_packets test cases.
https://reviews.llvm.org/D24136
Files:
lib/Sema/SemaChecking.cpp
test/CodeGenOpenCL/pipe_builtin.cl
Index: test/CodeGenOpenCL/pipe_builtin.cl
Author: bader
Date: Tue Sep 6 05:10:28 2016
New Revision: 280699
URL: http://llvm.org/viewvc/llvm-project?rev=280699=rev
Log:
[OpenCL] Remove access qualifiers on images in arg info metadata.
Summary:
Remove access qualifiers on images in arg info metadata:
* kernel_arg_type
*
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280699: [OpenCL] Remove access qualifiers on images in arg
info metadata. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23915?vs=69649=70372#toc
Repository:
rL LLVM
bader created this revision.
bader added a reviewer: Anastasia.
bader added subscribers: yaxunl, cfe-commits.
By default return type of call expressions calling built-in
functions is set to bool.
Fixes https://llvm.org/bugs/show_bug.cgi?id=30219.
https://reviews.llvm.org/D24136
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280800: [OpenCL] Fix pipe built-in functions return type.
(authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D24136?vs=70368=70516#toc
Repository:
rL LLVM
Author: bader
Date: Wed Sep 7 05:32:03 2016
New Revision: 280800
URL: http://llvm.org/viewvc/llvm-project?rev=280800=rev
Log:
[OpenCL] Fix pipe built-in functions return type.
By default return type of call expressions calling built-in
functions is set to bool.
Fixes
bader added a comment.
Valery, do you have any additional comments/questions regarding this patch?
https://reviews.llvm.org/D23992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added a comment.
Could you a regression test, please?
https://reviews.llvm.org/D24054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bader
Date: Tue Aug 30 09:42:54 2016
New Revision: 280097
URL: http://llvm.org/viewvc/llvm-project?rev=280097=rev
Log:
[OpenCL] Make is_valid_event, create_user_event overloadable.
Summary: Make is_valid_event and create_user_event overloadable like other
built-ins.
Patch by Evgeniy
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280097: [OpenCL] Make is_valid_event, create_user_event
overloadable. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23914?vs=69650=69682#toc
Repository:
rL LLVM
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D24626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: bader
Date: Fri Sep 23 09:20:00 2016
New Revision: 282252
URL: http://llvm.org/viewvc/llvm-project?rev=282252=rev
Log:
[OpenCL] Augment pipe built-ins with pipe packet size and alignment.
Reviewers: Anastasia, vpykhtin
Subscribers: dmitry, cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282252: [OpenCL] Augment pipe built-ins with pipe packet
size and alignment. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23992?vs=70366=72276#toc
Repository:
rL LLVM
bader added inline comments.
Comment at: test/SemaOpenCL/half.cl:29
@@ +28,3 @@
+kernel void half_disabled_kernel(global half *p,
+ half h); // expected-error{{'half' cannot be
used as the type of a kernel parameter}} // expected-error{{declaring
bader added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7599-7602
@@ -7595,3 +7598,6 @@
// of event_t type.
-S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT;
+// Do not diagnose half type since it is diagnosed as invalid argument
+//
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bader created this revision.
bader added reviewers: Anastasia, vpykhtin.
bader added a subscriber: cfe-commits.
Keep pipe packet size and alignment in LLVM IR layer to enable
translation from LLVM IR to SPIR-V format.
https://reviews.llvm.org/D23992
Files:
lib/CodeGen/CGBuiltin.cpp
bader accepted this revision.
bader added a comment.
LGTM
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
Anastasia wrote:
> bader wrote:
>
bader added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
AlexeySotkin wrote:
> Anastasia
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
A few minor comments regarding outdated comments and style.
Comment at: include/clang/AST/ASTContext.h:1124
/// \brief Return pipe type for the specified
Author: bader
Date: Tue Nov 1 10:50:52 2016
New Revision: 285700
URL: http://llvm.org/viewvc/llvm-project?rev=285700=rev
Log:
[OpenCL] Override supported OpenCL extensions with -cl-ext option
Summary:
This patch adds a command line option '-cl-ext' to control a set of
supported OpenCL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285700: [OpenCL] Override supported OpenCL extensions with
-cl-ext option (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23712?vs=75568=76571#toc
Repository:
rL LLVM
bader added a comment.
@pekka.jaaskelainen, I have related question: what is the problem with
retaining OpenCL address space information in LLVM IR?
My understanding is that target CodeGen can ignore this information for the
machines with 'flat' address space model.
On the other hand I would
bader added a comment.
Committed at 285557 with updated tests.
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bader
Date: Mon Oct 31 05:26:31 2016
New Revision: 285557
URL: http://llvm.org/viewvc/llvm-project?rev=285557=rev
Log:
[OpenCL] Setting constant address space for array initializers
Summary: Setting constant address space for global constants used for
memcpy-initialization of arrays.
Author: bader
Date: Tue Nov 29 04:21:40 2016
New Revision: 288126
URL: http://llvm.org/viewvc/llvm-project?rev=288126=rev
Log:
[OpenCL] Prohibit using reserve_id_t in program scope.
Patch by Egor Churaev (echuraev).
Reviewers: Anastasia
Subscribers: cfe-commits, yaxunl, bader
Differential
Author: bader
Date: Wed Dec 7 02:43:49 2016
New Revision: 288891
URL: http://llvm.org/viewvc/llvm-project?rev=288891=rev
Log:
[OpenCL] Added a LIT test for ensuring address space mangling is done the same
both in OpenCL1.2 and OpenCL2.0.
Patch by Egor Churaev (echuraev).
Reviewers: Anastasia
Author: bader
Date: Wed Dec 7 02:38:24 2016
New Revision: 288890
URL: http://llvm.org/viewvc/llvm-project?rev=288890=rev
Log:
[OpenCL] Fix SPIR version generation.
Patch by Egor Churaev (echuraev).
Reviewers: Anastasia
Subscribers: bader, yaxunl, cfe-commits
Differential Revision:
Author: bader
Date: Thu Jun 29 01:44:10 2017
New Revision: 306653
URL: http://llvm.org/viewvc/llvm-project?rev=306653=rev
Log:
[OpenCL] Allow function declaration with empty argument list.
Summary:
does it make sense to enable K function declaration style for OpenCL?
clang throws following error
Author: bader
Date: Tue Jun 20 09:30:18 2017
New Revision: 305796
URL: http://llvm.org/viewvc/llvm-project?rev=305796=rev
Log:
[OpenCL] Fix OpenCL and SPIR version metadata generation.
Summary: OpenCL and SPIR version metadata must be generated once per module
instead of once per mangled global
Author: bader
Date: Fri Jun 2 13:08:58 2017
New Revision: 304575
URL: http://llvm.org/viewvc/llvm-project?rev=304575=rev
Log:
[OpenCL] Harden function pointer diagnostics.
Summary: Improve OpenCL type checking by rejecting function pointer types.
Reviewers: Anastasia, yaxunl
Reviewed By:
Author: bader
Date: Wed Oct 11 04:16:31 2017
New Revision: 315453
URL: http://llvm.org/viewvc/llvm-project?rev=315453=rev
Log:
[OpenCL] Allow function declaration with empty argument list.
Treat 'f()' as 'f(void)' rather than a function w/o a prototype.
Reviewers: Anastasia, yaxunl
Reviewed
Author: bader
Date: Wed Nov 15 03:38:17 2017
New Revision: 318290
URL: http://llvm.org/viewvc/llvm-project?rev=318290=rev
Log:
[OpenCL] Fix code generation of function-scope constant samplers.
Summary:
Constant samplers are handled as static variables and clang's code generation
library, which
Author: bader
Date: Wed Jun 20 01:31:24 2018
New Revision: 335103
URL: http://llvm.org/viewvc/llvm-project?rev=335103=rev
Log:
[Sema] Allow creating types with multiple of the same addrspace.
Summary:
The comment with the OpenCL clause about this clearly
says: "No type shall be qualified by
Author: bader
Date: Fri Jan 26 03:48:46 2018
New Revision: 323522
URL: http://llvm.org/viewvc/llvm-project?rev=323522=rev
Log:
[OpenCL] Add "cles_khr_int64" extension.
Summary:
For OpenCL 1.1 embedded profile 64 bit integers i.e. long,
ulong including the appropriate vector data types and
Author: bader
Date: Mon Feb 25 03:48:48 2019
New Revision: 354773
URL: http://llvm.org/viewvc/llvm-project?rev=354773=rev
Log:
[SYCL] Add clang front-end option to enable SYCL device compilation flow.
Patch by Mariya Podchishchaeva
Added:
cfe/trunk/test/Preprocessor/sycl-macro.cpp (with
Author: bader
Date: Tue Feb 19 07:19:06 2019
New Revision: 354337
URL: http://llvm.org/viewvc/llvm-project?rev=354337=rev
Log:
[OpenCL] Change type of block pointer for OpenCL
Summary:
For some reason OpenCL blocks in LLVM IR are represented as function pointers.
These pointers do not point to
Author: Mariya Podchishchaeva
Date: 2019-12-03T16:13:22+03:00
New Revision: c094e7dc4b3f9d1c1e590b008bb1cc46e3496abd
URL:
https://github.com/llvm/llvm-project/commit/c094e7dc4b3f9d1c1e590b008bb1cc46e3496abd
DIFF:
Author: Alexey Bader
Date: 2019-12-11T12:40:43+03:00
New Revision: cb30ad728f0b791c72a6a1399f36ebc60ad5
URL:
https://github.com/llvm/llvm-project/commit/cb30ad728f0b791c72a6a1399f36ebc60ad5
DIFF:
https://github.com/llvm/llvm-project/commit/cb30ad728f0b791c72a6a1399f36ebc60ad5.diff
Author: Alexey Bader
Date: 2019-12-12T14:36:11+03:00
New Revision: 2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d
URL:
https://github.com/llvm/llvm-project/commit/2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d
DIFF:
https://github.com/llvm/llvm-project/commit/2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d.diff
Author: Victor Lomuller
Date: 2019-12-05T12:24:06+03:00
New Revision: 11a9bae8f66986751078501988b4414f24dbe37e
URL:
https://github.com/llvm/llvm-project/commit/11a9bae8f66986751078501988b4414f24dbe37e
DIFF:
1 - 100 of 138 matches
Mail list logo
