r268729 - [OPENMP 4.5] Tests for 'private|firstprivates' clauses in 'taskloop' directive.

Author: abataev Date: Fri May 6 07:04:14 2016 New Revision: 268729 URL: http://llvm.org/viewvc/llvm-project?rev=268729=rev Log: [OPENMP 4.5] Tests for 'private|firstprivates' clauses in 'taskloop' directive. Added tests for codegen for private|firstprivate clauses in taskloop-based directives.

r269050 - [OPENMP 4.5] Initial codegen for 'priority' clause in task-based

Author: abataev Date: Tue May 10 07:21:02 2016 New Revision: 269050 URL: http://llvm.org/viewvc/llvm-project?rev=269050=rev Log: [OPENMP 4.5] Initial codegen for 'priority' clause in task-based directives. OpenMP 4.5 supports clause 'priority' in task-based directives. Patch adds initial codegen

r269039 - [OPENMP 4.0] Fixed codegen for destructors in task-based directives.

Author: abataev Date: Tue May 10 05:36:51 2016 New Revision: 269039 URL: http://llvm.org/viewvc/llvm-project?rev=269039=rev Log: [OPENMP 4.0] Fixed codegen for destructors in task-based directives. If private variables require destructors call at the deletion of the task, additional flag in task

r269035 - [OPENMP 4.5] Add codegen support in runtime for '[non]monotonic'

Author: abataev Date: Tue May 10 04:57:36 2016 New Revision: 269035 URL: http://llvm.org/viewvc/llvm-project?rev=269035=rev Log: [OPENMP 4.5] Add codegen support in runtime for '[non]monotonic' schedule modifiers. Runtime library expects some additional data in schedule argument for loop-based

r266755 - Revert "[OPENMP] Codegen for untied tasks."

Author: abataev Date: Tue Apr 19 11:36:01 2016 New Revision: 266755 URL: http://llvm.org/viewvc/llvm-project?rev=266755=rev Log: Revert "[OPENMP] Codegen for untied tasks." This reverts commit r266754. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp

r266754 - [OPENMP] Codegen for untied tasks.

Author: abataev Date: Tue Apr 19 11:27:55 2016 New Revision: 266754 URL: http://llvm.org/viewvc/llvm-project?rev=266754=rev Log: [OPENMP] Codegen for untied tasks. If the untied clause is present on a task construct, any thread in the team can resume the task region after a suspension. Patch

r266853 - [OPENMP] Codegen for untied tasks.

Author: abataev Date: Tue Apr 19 23:01:36 2016 New Revision: 266853 URL: http://llvm.org/viewvc/llvm-project?rev=266853=rev Log: [OPENMP] Codegen for untied tasks. If the untied clause is present on a task construct, any thread in the team can resume the task region after a suspension. Patch

r266724 - Revert "[OPENMP] Codegen for untied tasks."

Author: abataev Date: Tue Apr 19 04:27:38 2016 New Revision: 266724 URL: http://llvm.org/viewvc/llvm-project?rev=266724=rev Log: Revert "[OPENMP] Codegen for untied tasks." This reverts commit 266722. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp

r270690 - [OPENMP 4.5] Codegen for dacross loop synchronization constructs.

Author: abataev Date: Wed May 25 07:36:08 2016 New Revision: 270690 URL: http://llvm.org/viewvc/llvm-project?rev=270690=rev Log: [OPENMP 4.5] Codegen for dacross loop synchronization constructs. OpenMP 4.5 adds support for doacross loop synchronization. Patch implements codegen for this

Re: [PATCH] D22787: [OpenMP] Add support to map member expressions with references to pointers.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22788: [OpenMP] Code generation for the is_device_ptr clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with some nits Comment at: include/clang/AST/OpenMPClause.h:4419 @@ -4405,1 +4418,3 @@ + } + /// \brief Build clause with number of variables \a NumVars. ///

Re: [PATCH] D22785: [OpenMP] diagnose orphaned teams construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/Sema/SemaOpenMP.cpp:3360-3366 @@ -3356,5 +3359,9 @@ if (NestingProhibited) { - SemaRef.Diag(StartLoc,

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

ABataev requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/AST/OpenMPClause.h:4252 @@ -4237,1 +4251,3 @@ + + /// \brief Build clause with number of variables \a NumVars. /// No \brief

Re: [PATCH] D22690: [OpenMP] Add support for mapping array sections through pointer references.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5280 @@ -5279,5 +5279,3 @@ BP = CGF.EmitLoadOfPointerLValue(PtrAddr.getAddress(), -

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

ABataev created this revision. ABataev added reviewers: rnk, rsmith, majnemer. ABataev added subscribers: cfe-commits, andreybokhanko. MSVC actively uses unqualified lookup in dependent bases, lookup at the instantiation point (non-dependent names may be resolved on things declared later) etc.

Re: [PATCH] D22691: [OpenMP] Codegen for use_device_ptr clause.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22895: [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D21904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22417: [OpenMP] update test cases for -std=c++11 compile

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r275947 - [OPENMP] Removed loop statement as its body executes at most once, NFC.

Author: abataev Date: Tue Jul 19 00:06:39 2016 New Revision: 275947 URL: http://llvm.org/viewvc/llvm-project?rev=275947=rev Log: [OPENMP] Removed loop statement as its body executes at most once, NFC. Removed not required loop statement, addressing comments from Richard Smith. Modified:

Re: [PATCH] D22487: [OpenMP] Ignore parens in atomic capture

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22481: [OpenMP] Allow negative lower bound in array sections based on pointers

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22479: [OpenMP] Sema and parsing for 'target simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r275945 - [OPENMP] Improved processing of 'priority' clause, NFC.

Author: abataev Date: Mon Jul 18 23:21:09 2016 New Revision: 275945 URL: http://llvm.org/viewvc/llvm-project?rev=275945=rev Log: [OPENMP] Improved processing of 'priority' clause, NFC. Removed some old comments + improved handling of 'priority' clause value during codegen after comments from

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added a comment. I don't see successful test for the clause, which prints AST and checks serialization/deserialization. Also it should include a template test to check that dependent objects are handled correctly Comment at: include/clang/AST/OpenMPClause.h:4236 @@

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

Kelvin, Please look at these messages and fix the tests. Or tell me and I will fix them Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 15.07.2016 9:23, Robinson, Paul пишет: > >> -Original Message- >> From: Alexey Bataev [mailto:a.bat...@hotmail.com] >>

Re: [PATCH] D22384: [OpenMP] add check for both simdlen and safelen clauses specified

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D22384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

Hi Paul, Could you provide a little bit more info about diagnostic you see? Maybe the tests just need to be fixed Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 15.07.2016 2:09, Paul Robinson пишет: > probinson added a subscriber: probinson. > probinson added a

Re: [PATCH] D22007: [OpenMP] Sema and parsing for 'distribute simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r274745 - [OPENMP] Do not create helper expressions in dependent contexts, NFC.

Author: abataev Date: Thu Jul 7 06:04:06 2016 New Revision: 274745 URL: http://llvm.org/viewvc/llvm-project?rev=274745=rev Log: [OPENMP] Do not create helper expressions in dependent contexts, NFC. OpenMP relies on some helper expressions generated during semantic analysis. But they are

Re: [PATCH] D22176: [OpenMP] add more tests for 'distribute simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:10667-10668 @@ +10666,4 @@ + if (Type.isNull() || Type->isAnyPointerType() || + CheckArrayExpressionDoesNotReferToWholeSize(SemaRef, + SI->getAssociatedExpression(),Type)) +

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22169: [OpenMP] add more tests for 'distribute parallel for simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added a comment. No positive tests for the construct Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8333 @@ -8332,1 +8332,3 @@ "expected at least one 'to' clause or 'from' clause specified to '#pragma omp target update'">; +def

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:4221 @@ +4220,3 @@ + +/// \brief This represents clause 'use_device_ptr' in the '#pragma omp ...' +/// directives. No \brief's Comment at:

Re: [PATCH] D23189: [OpenMP] Sema and parsing for 'teams distribute' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: include/clang/Sema/Sema.h:8254 @@ -8253,1 +8253,3 @@ llvm::DenseMap ); + /// \brief Called on well-formed '\#pragma omp teams distribute'

Re: [PATCH] D22955: [MSVC] Improved late parsing of template functions.

ABataev added a comment. Ping https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8318 @@ -8317,1 +8317,3 @@ +def err_omp_usedeviceptr_not_a_pointer : Error< + "item used in 'use_device_pointer' clause is not a pointer">; } // end of OpenMP category It's

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

ABataev added a comment. In http://reviews.llvm.org/D18172#471861, @jlebar wrote: > Alexey, it seems that you're asking for "final" on all classes that are not > inherited from. Forgive my ignorance, but would you mind pointing me to the > document that talks about our position on "final" in

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:11377 @@ +11376,3 @@ +// item should be a pointer or array +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) sfantao wrote: >

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

ABataev added a comment. In http://reviews.llvm.org/D21904#472074, @carlo.bertolli wrote: > I think that Kelvin is right. This is what that sentence refers to: > int * bla = ..; > #pragma omp target data use_device_ptr(bla) > { > > .. bla .. // <-- this is the 'reference' that sentence is

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

ABataev added inline comments. Comment at: lib/Driver/Driver.cpp:464-468 @@ +463,7 @@ + RuntimeName = A->getValue(); +HasCompatibleOpenMP = llvm::StringSwitch(RuntimeName) + .Case("libomp", true) +

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

ABataev added a comment. General comment: remove '\brief' tags, they are not required anymore, just '\\\' is enough Comment at: include/clang/Driver/Action.h:94 @@ -93,1 +93,3 @@ + /// \brief Flag that is set to true if this action can be collapsed with + /// others

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

ABataev added a comment. Remove '\brief' Comment at: include/clang/Driver/Action.h:158-160 @@ -158,1 +157,5 @@ + /// non-device kinds, except if \a CreatePrefixForHost is set. + static std::string + getOffloadingFileNamePrefix(OffloadKind Kind, StringRef NormalizedTriple, +

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

ABataev added inline comments. Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:324-334 @@ -314,1 +323,13 @@ +// Handler for object files. The bundles are organized by sections with a +// designated name. +// +// In order to bundle we create an IR file with the

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

ABataev added a comment. Remove empty 'return' and ';' statements where they are not required. Comment at: test/Driver/clang-offload-bundler.c:14 @@ +13,3 @@ +// +// RUN: touch %t.empty + Hmm, will it work on Windows? Maybe it is better just to add an empty

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

ABataev added a comment. No '\brief's Comment at: lib/Driver/Driver.cpp:1393 @@ +1392,3 @@ +/// generate the required device actions. +class OffloadingActionBuilder { + /// \brief Flag used to trace errors in the builder. 1. 'final' 2. default initializers for

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

ABataev added inline comments. Comment at: include/clang/Driver/Action.h:493 @@ -491,1 +492,3 @@ +class OffloadUnbundlingJobAction : public JobAction { + void anchor() override; 'final'? Comment at: include/clang/Driver/Action.h:499 @@ +498,3

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

ABataev added inline comments. Comment at: lib/Driver/Tools.cpp:297 @@ +296,3 @@ + StringRef Name = llvm::sys::path::filename(Output.getFilename()); + StringRef Prefix = Name.rsplit('.').first; + if (C.getDriver().isSaveTempsEnabled()) { Use

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

ABataev added inline comments. Comment at: lib/Driver/Driver.cpp:1778 @@ +1777,3 @@ + /// phase. + class OpenMPActionBuilder : public DeviceActionBuilder { +/// \brief The OpenMP actions for the current input. 'final' http://reviews.llvm.org/D21845

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

ABataev added a comment. No '\brief's Comment at: include/clang/Driver/Action.h:204 @@ -159,1 +203,3 @@ +/// kind to its dependences. +class OffloadAction : public Action { virtual void anchor(); 'final' Comment at:

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

ave REQUIRES: x86-registered-target. On Fri, Jan 20, 2017 at 12:57 AM, Alexey Bataev via cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> wrote: Author: abataev Date: Fri Jan 20 02:57:28 2017 New Revision: 292590 URL: http://llvm.org/viewvc/llvm-project?rev

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

Yes. Could you do it yourself or you want me to do it? - Best regards, Alexey Bataev 27.01.2017 2:33, Hans Wennborg пишет: > Should we merge this to the release branch? > > On Fri, Jan 20, 2017 at 12:57 AM, Alexey Bataev via cfe-commits > <cfe-commits@lists.llvm.org>

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

yourself or you want me to do it? >> >> - >> Best regards, >> Alexey Bataev >> >> 27.01.2017 2:33, Hans Wennborg пишет: >>> Should we merge this to the release branch? >>> >>> On Fri, Jan 20, 2017 at 12:57 AM, Alexey Bataev via cfe-commit

Re: r295473 - [OpenMP] Remove barriers at cancel and cancellation point

Yes, approved Best regards, Alexey Bataev > 23 февр. 2017 г., в 1:00, Hans Wennborg написал(а): > > Alexey: ping? > >> On Tue, Feb 21, 2017 at 11:07 AM, Hans Wennborg wrote: >> I'm Ok with it if Alexey approves. >> >> On Fri, Feb 17, 2017 at 10:52 AM,

Re: [PATCH] D29758: [OpenMP] Parallel reduction on the NVPTX device.

Arpith, see the comment in CGOpenMPRuntime.cpp // if SimpleReduction is true, only the next code is generated: // ... // [i] = RedOp(*[i], *[i]); // ... and is used for omp simd directive only. - Best regards, Alexey Bataev 10.02.2017 18:49, Arpith Jacob via

Re: [PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

Armpit, fine, leave it as is Best regards, Alexey Bataev > 18 янв. 2017 г., в 15:50, Arpith Jacob via Phabricator > написал(а): > > arpith-jacob added inline comments. > > > > Comment at: lib/Sema/SemaOpenMP.cpp:1933-1937 > + StmtResult SR = S; >

r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

Author: abataev Date: Fri Jan 20 02:57:28 2017 New Revision: 292590 URL: http://llvm.org/viewvc/llvm-project?rev=292590=rev Log: [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows with SEH and openmp In some cituations (during codegen for Windows SEH constructs)

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. No tests for serialization/deserialization/AST printing https://reviews.llvm.org/D23528 ___ cfe-commits mailing list

Re: [PATCH] D24615: [OpenMP] clang doesnt diagnose if there is a lexical block around a for stmt for OpenMP loops. It is technically not allowed in the OpenMP standard

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5137-5138 @@ -5137,1 +5136,4 @@ + Stmt *CurStmt = AStmt; + if (auto CapS = dyn_cast_or_null(CurStmt)) +CurStmt = CapS->getCapturedStmt(); for (unsigned Cnt = 0; Cnt < NestedLoopCount; ++Cnt) {

Re: [PATCH] D24639: [Sema] Warn when returning a lambda that captures a local variable by reference

ABataev added a subscriber: ABataev. Comment at: lib/Sema/SemaChecking.cpp:6588 @@ -6587,2 +6587,3 @@ stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/nullptr); + } else if (lhsType->isReferenceType()) { Remove empty line Comment at:

[PATCH] D24615: [OpenMP] clang doesnt diagnose if there is a lexical block around a for stmt for OpenMP loops. It is technically not allowed in the OpenMP standard

ABataev added a comment. In https://reviews.llvm.org/D24615#561532, @kkwli0 wrote: > Should we issue a warning message in this case? Agree https://reviews.llvm.org/D24615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25204: Register Calling Convention, Clang changes

ABataev added inline comments. > Type.h:1381 > /// regparm and the calling convention. > -unsigned ExtInfo : 9; > +unsigned ExtInfo : 10; > Erich, do you really need this? You don't increase number of required bits anymore, so this code must be restored > Type.h:2909-2921 > +

[PATCH] D25252: [OpenMP] Check if the template specialization is mappable instead of specialized template

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D25252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25204: Register Calling Convention, Clang changes

ABataev added a comment. Eric, please, prepare a full context review! > ItaniumMangle.cpp:1417-1421 > + if (isRegCall) { > +Out << II->getLength() + sizeof("__regcall3__") - 1<< "__regcall3__"; > + } else { > +Out << II->getLength(); > + } Single-line substatements must not be

[PATCH] D25204: Register Calling Convention, Clang changes

ABataev added inline comments. > Index.h:3029 >CXCallingConv_PreserveAll = 15, > + CXCallingConv_X86RegCall = 16, > Maybe it is better to use 8, as the previous comment allows it? /* Value 8 was PnaclCall, but it was never used, so it could safely be re-used. */ In this case you

[PATCH] D25204: Register Calling Convention, Clang changes

ABataev added a comment. In https://reviews.llvm.org/D25204#560894, @erichkeane wrote: > Hi Alexey- > Can you let me know what you mean by "Full Context Review"? I'm unfamiliar > with that process. The other fixes I'll look at today. Check this page http://llvm.org/docs/Phabricator.html

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

ABataev added a comment. LG https://reviews.llvm.org/D21847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

ABataev added a comment. LG https://reviews.llvm.org/D21845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

ABataev added a comment. LG https://reviews.llvm.org/D21843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

ABataev added a comment. LG for me. https://reviews.llvm.org/D18172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

ABataev added a comment. LG for me https://reviews.llvm.org/D21840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

ABataev added a comment. LG https://reviews.llvm.org/D21856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

ABataev added a comment. LG https://reviews.llvm.org/D21857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

ABataev added a comment. LG https://reviews.llvm.org/D21853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

ABataev added a comment. LG https://reviews.llvm.org/D21848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21852: [Driver][OpenMP] Update actions builder to create bundling action when necessary.

ABataev added a comment. LG https://reviews.llvm.org/D21852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

ABataev added a subscriber: ABataev. ABataev added a comment. You need to add tests for serialization/deserialization https://reviews.llvm.org/D24807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

ABataev added inline comments. Comment at: lib/AST/ASTImporter.cpp:3414 @@ +3413,3 @@ + // FriendDecl is not a NamedDecl so we cannot use localUncachedLookup. + CXXRecordDecl *RD = cast(DC); + FriendDecl *ImportedFriend = RD->getFirstFriend(); CXXRecordDecl

Re: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

Add a check to line 299: if (!VarTy->isReferenceType() && !(FD->getType()->isVariablyModifiedType() && ArgLVal.getType()->isPointerType())) Best regards, Alexey Bataev On 10/10/2016 08:19 PM, Keane, Erich wrote: > That does turn ArgType into a PointerType int*. However, line 301 >

Re: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

Aaaahhh, Now I see. We have a parameter with the type that is a reference to VLA. I think in this case we should rework this code to something like this: if (ArgType->isVariablyModifiedType()) ArgType = getContext().getCanonicalParamType(ArgType.getNonReferenceType()); Try this

Re: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

Hmm, I thought it must return a pointer to the element type rather than [*] kind type. Did you checked it? Best regards, Alexey Bataev On 10/10/2016 07:09 PM, Erich Keane wrote: > erichkeane added a comment. > > Andrey- > It seems that getVariableArrayDecayedType and getCanonicalParamType

Re: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

Could you send the new results for these tests? Best regards, Alexey Bataev On 10/10/2016 09:22 PM, Keane, Erich wrote: > This causes a massive number of openmp test failures (obviously), and I'm not > terribly comfortable with how OpenMP works. I can update the tests (and > will), but would

Re: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

I mean, could you send new .ll files, which you get after these changes? Best regards, Alexey Bataev > 10 окт. 2016 г., в 22:26, Keane, Erich написал(а): > > Sure, attached. So far, there are a few changes that seem curious and > concerning. A few cases of loads going

r286129 - [OPENMP] Fixed codegen for __real/__imag expressions in atomic

Author: abataev Date: Mon Nov 7 12:15:02 2016 New Revision: 286129 URL: http://llvm.org/viewvc/llvm-project?rev=286129=rev Log: [OPENMP] Fixed codegen for __real/__imag expressions in atomic constructs. For __real/__imag unary expressions clang emits lvalue with the associated type from the

r286098 - [OPENMP] Fixed capturing of VLA variables.

Author: abataev Date: Mon Nov 7 02:07:25 2016 New Revision: 286098 URL: http://llvm.org/viewvc/llvm-project?rev=286098=rev Log: [OPENMP] Fixed capturing of VLA variables. After some changes in codegen capturing of VLA variables in OpenMP regions was broken, causing compiler crash. Patch fixes

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

ABataev added a comment. Ping https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r286106 - [OPENMP] Fixed test on MIPS-based buildbots.

Author: abataev Date: Mon Nov 7 07:37:34 2016 New Revision: 286106 URL: http://llvm.org/viewvc/llvm-project?rev=286106=rev Log: [OPENMP] Fixed test on MIPS-based buildbots. Modified: cfe/trunk/test/OpenMP/parallel_codegen.cpp Modified: cfe/trunk/test/OpenMP/parallel_codegen.cpp URL:

Re: r286129 - [OPENMP] Fixed codegen for __real/__imag expressions in atomic

Hi Dimitry, I think so Best regards, Alexey Bataev > 7 нояб. 2016 г., в 22:36, Dimitry Andric <dimi...@andric.com> написал(а): > > Hi Alexey, > > Does this look like a good candidate for 3.9.1? > > -Dimitry > >> On 07 Nov 2016, at 19:15, Alexey Bat

r286584 - Fix for PR28523: unexpected compilation error.

Author: abataev Date: Fri Nov 11 06:36:20 2016 New Revision: 286584 URL: http://llvm.org/viewvc/llvm-project?rev=286584=rev Log: Fix for PR28523: unexpected compilation error. Clang emits error message for the following code: ``` template void parallel_loop(F &) { f(0); } int main() { int x;

Re: r286098 - [OPENMP] Fixed capturing of VLA variables.

ilders/clang-cmake-armv7-a15/builds/304 http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/657 http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/347 Thanks, Diana On 7 November 2016 at 10:07, Alexey Bataev via cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-comm

r286103 - [OPENMP] Fixed capturing of VLA variables.

Author: abataev Date: Mon Nov 7 05:16:04 2016 New Revision: 286103 URL: http://llvm.org/viewvc/llvm-project?rev=286103=rev Log: [OPENMP] Fixed capturing of VLA variables. After some changes in codegen capturing of VLA variables in OpenMP regions was broken, causing compiler crash. Patch fixes

r284229 - Fix for PR30632: Name mangling issue.

Author: abataev Date: Fri Oct 14 07:43:59 2016 New Revision: 284229 URL: http://llvm.org/viewvc/llvm-project?rev=284229=rev Log: Fix for PR30632: Name mangling issue. There was a bug in the implementation of captured statements. If it has a lambda expression in it and the same lambda expression

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

ABataev added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1044-1070 +static bool isBaseClass(const CXXRecordDecl *Record, CXXRecordDecl *Base) { + SmallVector Queue; + + while (true) { +for (const auto : Record->bases()) { + const RecordType *Ty =

[PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

ABataev added inline comments. Comment at: include/clang/AST/Type.h:2934 ExtInfo(bool noReturn, bool hasRegParm, unsigned regParm, CallingConv cc, -bool producesResult) { +bool producesResult, bool noCallerSavedRegs) { assert((!hasRegParm ||

[PATCH] D26827: Make tests more robust with Release builds

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. I'm ok with these changes but please check that tests are still working on Windows https://reviews.llvm.org/D26827 ___ cfe-commits mailing

r288039 - [OPENMP] Fix for PR31137: Wrong DSA for members in struct.

Author: abataev Date: Mon Nov 28 09:55:15 2016 New Revision: 288039 URL: http://llvm.org/viewvc/llvm-project?rev=288039=rev Log: [OPENMP] Fix for PR31137: Wrong DSA for members in struct. If member expression is used in the task region and the base expression is a DeclRefExp and the variable

<    1   2   3   4   5   6   7   8   9   10   >