[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

alok marked an inline comment as done. alok added a comment. In D80197#2059591 , @thakis wrote: > This breaks check-llvm on Windows: http://45.33.8.238/win/16214/step_11.txt > > Please take a look and revert if it takes a while to investigate. Fixed in

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

alok marked 2 inline comments as done. alok added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1522 static uint64_t rotateSign(int64_t I) { uint64_t U = I; melver wrote: > rotateSign() is no longer used in this file. If there are

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2700326 , @alok wrote: > In D99160#2699038 , @dblaikie wrote: > >> In D99160#2698980 , @alok wrote: >> >>> In D99160#2671899

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok updated this revision to Diff 332867. alok added a comment. Updated to incorporate comments from @djtodoro - to split out separate patch for clang change. and fixed clang-format issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99160/new/ https://reviews.llvm.org/D99160

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok updated this revision to Diff 332870. alok added a comment. Re-based after setting the parent patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99238/new/ https://reviews.llvm.org/D99238 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) djtodoro wrote: > I think this should be a

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok created this revision. alok added reviewers: djtodoro, aprantl, jmorse, SouraVX, jini.susan.george, bhuvanendrakumarn. alok added a project: debug-info. Herald added subscribers: jansvoboda11, dexonsmith. alok requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok created this revision. alok added reviewers: aprantl, jmorse, djtodoro. alok added a project: debug-info. Herald added subscribers: jansvoboda11, pengfei, ormris, hiraditya. Herald added a reviewer: sscalpone. alok requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok updated this revision to Diff 334931. alok added a comment. Updated testcase to use option "-O0", earlier default option was being used instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99160/new/ https://reviews.llvm.org/D99160 Files:

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2665580 , @probinson wrote: > FastISel is normally used only at -O0, I wouldn't expect any parameters to be > optimized out at -O0. > The test is running llc with default optimization, which is -O2, and forcing >

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2666068 , @djtodoro wrote: > In D99160#2666066 , @alok wrote: > >> In D99160#2665580 , @probinson >> wrote: >> >>> FastISel is normally used

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok marked an inline comment as done. alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs,

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok marked 2 inline comments as done. alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs,

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok updated this revision to Diff 334636. alok added a comment. Re-based and minor changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99160/new/ https://reviews.llvm.org/D99160 Files: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp llvm/lib/Target/X86/X86FastISel.cpp

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch()))

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok updated this revision to Diff 334642. alok added a comment. Updated to address comments from @djtodoro CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99238/new/ https://reviews.llvm.org/D99238 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2671899 , @dblaikie wrote: > In D99160#2670460 , @djtodoro wrote: > >> In D99160#2669576 , @dblaikie wrote: >> >>> In D99160#2668977

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok added a comment. In D99160#2699038 , @dblaikie wrote: > In D99160#2698980 , @alok wrote: > >> In D99160#2671899 , @dblaikie wrote: >> >>> In D99160#2670460

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

alok created this revision. alok added reviewers: aprantl, djtodoro, jmorse, dblaikie, jini.susan, jini.susan.george. alok added a project: debug-info. Herald added subscribers: guansong, yaxunl. alok requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers:

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

alok added a comment. PING !!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115510/new/ https://reviews.llvm.org/D115510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

This revision was automatically updated to reflect the committed changes. Closed by commit rG5eb271880c8f: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of… (authored by alok). Changed prior to commit: https://reviews.llvm.org/D115510?vs=393447=395860#toc Repository:

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

alok marked an inline comment as done. alok added a comment. Thanks @djtodoro . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115510/new/ https://reviews.llvm.org/D115510 ___ cfe-commits mailing list

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok added a comment. In D114504#3151332 , @djtodoro wrote: > Thanks for doing this! Can you please update the summary, since it hard to > read with the format like this (at least, just try to reformat the debugger > output properly with the

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok added a comment. Thanks @djtodoro . I have incorporated all your comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114504/new/ https://reviews.llvm.org/D114504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:4513 Scope.addPrivate(Pair.first, [Replacement]() { return Replacement; }); +if (auto *DI = CGF.getDebugInfo()) { + DI->EmitDeclareOfAutoVariable(Pair.first,

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok updated this revision to Diff 389699. alok added a comment. Re-based and incorporated comments from @djtodoro CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114504/new/ https://reviews.llvm.org/D114504 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/debug_private.c

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36cb7477d1d4: [clang][OpenMP][DebugInfo] Debug support for private variables inside an OpenMP… (authored by alok). Repository: rG LLVM Github

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

alok created this revision. alok added reviewers: aprantl, djtodoro. alok added a project: debug-info. Herald added subscribers: pengfei, guansong, yaxunl. alok requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

alok created this revision. alok added reviewers: aprantl, djtodoro, jdoerfert, jini.susan.george. alok added a project: debug-info. Herald added subscribers: guansong, yaxunl. alok requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

alok created this revision. alok added reviewers: aprantl, djtodoro, jini.susan. alok added a project: debug-info. Herald added a project: All. alok requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently Clang is generating subprograms

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

alok created this revision. alok added reviewers: jmorse, aprantl, djtodoro, jini.susan. alok added a project: debug-info. Herald added subscribers: guansong, yaxunl. Herald added a project: All. alok requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers:

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa48300aee570: [clang][OpenMP][DebugInfo] Debug support for TLS variables present in OpenMP… (authored by alok). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

alok abandoned this revision. alok added a comment. GNU gdb is now modified to accept functions with linkage name. commit 6f9b09edaee43ea34d34b1998fe7b844834f251a Author: Alok Kumar Sharma Date: Sun May 22 21:46:06 2022 +0530 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

alok updated this revision to Diff 437064. alok added a comment. Herald added a project: All. Re-based and updated to include one negative testcase. I could not find a test for VarDecl with DynamicInitKind::NoStub. There are constructors for other DynamicInitKind but not for NoStub. Please help

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

alok added a comment. In D123787#3452970 , @aprantl wrote: >> For an example, if thread local variable is present in copyin clause >> (testcase attached with the > > patch), parameter with same name is generated as parameter to artificial > function.

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

alok updated this revision to Diff 423362. alok added a comment. Re-based. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123787/new/ https://reviews.llvm.org/D123787 Files: clang/include/clang/AST/Decl.h clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D124982: [clang][OpenMP][DebugInfo] Debug support for variables in containing scope of OMP constructs

alok updated this revision to Diff 428322. alok added a comment. Re-based. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124982/new/ https://reviews.llvm.org/D124982 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D124982: [clang][OpenMP][DebugInfo] Debug support for variables in containing scope of OMP constructs

alok created this revision. alok added reviewers: aprantl, djtodoro, jmorse, jini.susan. alok added a project: debug-info. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. alok requested review of this revision. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D124982: [clang][OpenMP][DebugInfo] Debug support for variables in containing scope of OMP constructs

alok updated this revision to Diff 427237. alok added a comment. re-based. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124982/new/ https://reviews.llvm.org/D124982 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

alok updated this revision to Diff 449239. alok added a comment. Re-based and updated to incorporate comments from @dblaikie CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111521/new/ https://reviews.llvm.org/D111521 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ec6ea3dfded: [clang][OpenMP][DebugInfo] Mark OpenMP generated functions as artificial (authored by alok). Repository: rG LLVM Github Monorepo