[PATCH] D64319: [OpenCL] Add function attributes handling for builtin functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64319/new/ https://reviews.llvm.org/D64319 ___ cfe-commits mailing lis

[PATCH] D45808: [OpenCL] Add 'denorms-are-zero' function attribute

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/denorms-are-zero.cl:9 +// CHECK-LABEL: define void @f() +// CHECK: attributes #{{[0-9]*}} = {{{[^}]*}} "denorms-are-zero"="true" Could we add a check for the false case too? Comm

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

Anastasia created this revision. Anastasia added reviewers: yaxunl, bader. String literals must be in `constant` address space. https://reviews.llvm.org/D46049 Files: lib/Sema/SemaExpr.cpp test/SemaOpenCL/predefind-expr.cl Index: test/SemaOpenCL/predefind-expr.cl =

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

Anastasia updated this revision to Diff 144154. Anastasia added a comment. - Renamed test; - Reformatted; - Added constant in StringLiteral creation. https://reviews.llvm.org/D46049 Files: lib/AST/Expr.cpp lib/Sema/SemaExpr.cpp test/SemaOpenCL/predefined-expr.cl Index: test/SemaOpenCL/p

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

Anastasia added inline comments. Comment at: lib/Sema/SemaExpr.cpp:3059 /*IndexTypeQuals*/ 0); SL = StringLiteral::Create(Context, Str, StringLiteral::Ascii, /*Pascal*/ false, ResTy, Loc); --

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

Anastasia added inline comments. Comment at: lib/AST/Expr.cpp:870 + if (C.getLangOpts().OpenCL && Ty.getAddressSpace() == LangAS::Default) +Ty = C.getAddrSpaceQualType(Ty, LangAS::opencl_constant); + bader wrote: > As `Ty` is passed by value, shouldn't we ac

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

Anastasia added inline comments. Comment at: lib/AST/Expr.cpp:870 + if (C.getLangOpts().OpenCL && Ty.getAddressSpace() == LangAS::Default) +Ty = C.getAddrSpaceQualType(Ty, LangAS::opencl_constant); + bader wrote: > Anastasia wrote: > > bader wrote: > > > As

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

Anastasia added inline comments. Comment at: lib/AST/Expr.cpp:870 + if (C.getLangOpts().OpenCL && Ty.getAddressSpace() == LangAS::Default) +Ty = C.getAddrSpaceQualType(Ty, LangAS::opencl_constant); + Anastasia wrote: > bader wrote: > > Anastasia wrote: > > >

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

Anastasia updated this revision to Diff 144885. Anastasia added a comment. The best way of adding common helper function I could come up with. The problem is that string literals are created quite differently all over: using various char types and const qualifiers. That seems to cover the most c

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

Anastasia updated this revision to Diff 144892. Anastasia added a comment. Added accidentally removed code and improved the test. https://reviews.llvm.org/D46049 Files: include/clang/AST/ASTContext.h lib/AST/ASTContext.cpp lib/AST/Expr.cpp lib/Sema/SemaExpr.cpp test/SemaOpenCL/predefi

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

Anastasia added a comment. In https://reviews.llvm.org/D46049#1081196, @yaxunl wrote: > Can you add a codegen test for 1.2, 2.0? Anything specific you would like me to check? I am not modifying anything in CodeGen here though. > Also, I am wondering whether this is valid for OpenCL C++. Do we

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

Anastasia updated this revision to Diff 145000. Anastasia added a comment. - Changed to adjust common function - Enhanced CodeGen string literal case to also check the predefined expr https://reviews.llvm.org/D46049 Files: include/clang/AST/ASTContext.h lib/AST/ASTContext.cpp lib/AST/Expr

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

Anastasia added a comment. Is this some sort of a vendor extension then? OpenCL 1.2 atomic builtins don't have ordering parameter. Repository: rC Clang https://reviews.llvm.org/D46386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D47154: Try to make builtin address space declarations not useless

Anastasia added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:3500 +if (auto *PtrTy = dyn_cast(PTy)) { + if (PtrTy->getAddressSpace() != + ArgValue->getType()->getPointerAddressSpace()) { arsenm wrote: > Anastasia wrote: > >

[PATCH] D68388: [PR41008][OpenCL] Support restrict keyword in C++ mode

Anastasia added a comment. Can you please explain why we are deviating from C++ on this? My concern is that this can potentially uncover bugs in C++ parsing due to un-handled restrict cases that would have to be fixed in some unclear way... I would appreciate more detailed analysis before we go

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini, neil.hickey. Herald added subscribers: ebevhan, yaxunl. https://reviews.llvm.org/D69072 Files: clang/docs/OpenCLSupport.rst Index: clang/docs/OpenCLSupport.rst =

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

Anastasia added a comment. In D69072#1712473 , @mantognini wrote: > Shouldn't this page be referenced from `clang/docs/index.rst`? Oops, yes! Sure. I will update. Thanks! > In the long run, how would this page differ from > https://releases.llvm.org/9.

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

Anastasia updated this revision to Diff 225391. Anastasia edited the summary of this revision. Anastasia added a comment. Herald added a subscriber: arphaman. Added OpenCLSupport page into index. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69072/new/ https://reviews.llvm.org/D69072 F

[PATCH] D68403: [OpenCL] PR43145: preserve addrspace for class accesses

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68403/new/ https://reviews.llvm.org/D68403 ___

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

Anastasia added subscribers: jeroen.dobbelaere, rjmccall. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10090 // if both are pointers check if operation is valid wrt address spaces - if (S.getLangOpts().OpenCL && isLHSPointer && isRHSPointer) { + i

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:14 // FINITE: fdiv nnan ninf float - // UNSAFE: fdiv nnan nsz float + // UNSAFE: fdiv reassoc nsz arcp afn float // MAD: fdiv float michele.scandale wrote: > This chan

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia created this revision. Anastasia added reviewers: rjmccall, arsenm. Herald added subscribers: ebevhan, yaxunl, wdng. Anastasia marked an inline comment as done. Anastasia added inline comments. Anastasia retitled this revision from "[RCF][OpenCL] Set fp contract flag on -cl-mad-enable" t

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float I don't find this beha

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia added a comment. In D80416#2050250 , @arsenm wrote: > The langref wording makes me think this isn't quite right. This depends on > your definition of floating point contraction. I've always assumed it meant > allow FMA, potentially increasing p

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float Anastasia wrote: > I d

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float Anastasia wrote: > Ana

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float Anastasia wrote: > Ana

[PATCH] D80440: [OpenCL] Prevent fused mul and add by default

Anastasia created this revision. Anastasia added reviewers: rjmccall, arsenm. Herald added subscribers: ebevhan, yaxunl, wdng. Currently, clang will generate fused operation `fmuladd` for expressions like `a*b+c`. However, I can't find anything in the spec that explains this behavior. But clang

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:481 =yes yes yes yes -:? [#]_ yes --yes -- +?: yes --yes

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7484 + // Only ext vector is allowed + if (const auto *VecCondTy = Cond->getType()->getAs()) { +QualType EleTy = VecCondTy->getElementType(); myhsu wrote: > Anastasia wrote: > > Why do

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

Anastasia accepted this revision. Anastasia added a comment. In D79781#2063440 , @PiotrFusik wrote: > Bumped the OpenCL version from 1.2 to 2.0. Great! Thanks! Feel free to go ahead and commit this! Can you please add a link to the bug describing incorr

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please address small documentation nitpick before committing... Btw does your change fix this bug: https://bugs.llvm.org/show_bug.cgi?id=33103 Comment at

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

Anastasia added a comment. Why? Default address space is normally an address space of automatic storage i.e. `private` in OpenCL. If you look at the address space map of targets most of them map default and private address spaces to the same value. Converting between private and other named ad

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

Anastasia added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signed-zeros -freciprocal-math \ +// R

[PATCH] D83665: [OpenCL] Fixed missing address space for templated copy constructor

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3811 + if(S.getLangOpts().OpenCL) +ArgType = S.deduceOpenCLPointeeAddrSpace(ArgType); ArgType = S.Context.getLValueReferenceType(ArgType); I feel we can just

[PATCH] D83665: [OpenCL] Fixed missing address space for templated copy constructor

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3811 + if(S.getLangOpts().OpenCL) +ArgType = S.deduceOpenCLPointeeAddrSpace(ArgType); ArgType = S.Context.getLValueReferenceType(ArgType); olestrohm wrote: >

[PATCH] D83665: [OpenCL] Fixed missing address space for templated copy constructor

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83665/new/ https://reviews.llvm.org/D83665 ___ cfe-commits mailing list

[PATCH] D83665: [OpenCL] Fixed missing address space for templated copy constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rG92fa91bb4029: [OpenCL] Fixed missing address space for templated copy constructor. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D836

[PATCH] D62574: Initial draft of target-configurable address spaces.

Anastasia added a comment. In D62574#2136423 , @ebevhan wrote: > It seems that D70605 attempted to > ameliorate the issues that I observed (pointer-conversion doing too much), > but it didn't manage to solve the problem

[PATCH] D62574: Initial draft of target-configurable address spaces.

Anastasia added a comment. > This was also only an initial concept. I think that even once all the issues > with the patch have been ironed out, it would require a round of wider review > since it's a fairly hefty API change. You don't always need a super polished prototype to justify adding

[PATCH] D77923: OpenCL: Fix some missing predefined macros

Anastasia added a comment. As for OpenCL C spec we should ideally add `__OPENCL_VERSION__` but I feel it should be taken from architecture or OS type... I think there were other cases where we needed something like an OpenCL runtime version in the triple too but I can't remember this now. I ca

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. In D80932#2071321 , @bader wrote: > In D80932#2068863 , @Anastasia wrote: > > > > > > > > > Why

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

Anastasia added a comment. In D79781#2070998 , @PiotrFusik wrote: > > Great! Thanks! Feel free to go ahead and commit this! > > Thanks. Can someone commit this for me, please? Also to 10.0 if possible? Ok, I can commit this. I am afraid the window for 10

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a4402f0d721: [OpenCL] Add cl_khr_extended_subgroup extensions. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

Anastasia added a comment. In D80932#2073542 , @Naghasan wrote: > In D80932#2072064 , @Anastasia wrote: > > > In D80932#2071321 , @bader wrote: > > > > > In D80932#2068863

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

Anastasia added a comment. > @Anastasia, if we make this change specific to SYCL mode, will it address > your concerns? I can't answer this question for the reasons I have explained above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80932/new/

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

Anastasia added a subscriber: rjmccall. Anastasia added a comment. In D80932#2083185 , @bader wrote: > In D80932#2080631 , @Anastasia wrote: > > > > @Anastasia, if we make this change specific to SYCL mode, will it

[PATCH] D81608: Fix incorrect call to ExprResult::get()

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Great spot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81608/new/ https://reviews.llvm.org/D81608

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:3628 + // FIXME: This may not be the best approach, as the correct type (including + // address space) is available in D, but the type in D may not be reliable Is this

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82781/new/ https://reviews.llvm.org/D82781 ___ cfe-commits mailing lis

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

Anastasia added inline comments. Comment at: clang/include/clang/Driver/Options.td:1176 +defm reciprocal_math : OptInFFlag< "reciprocal-math", "Allow division operations to be reassociated", "", "", [], "LangOpts->AllowRecip">; +def fapprox_func : Flag<["-"], "fapprox-func">, Gr

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG6050c156ab4f: [OpenCL] Defer addr space deduction for dependent type. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82781/new/ http

[PATCH] D82313: [OpenCL] Reject block arguments

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/invalid-block.cl:31 typedef int (^bl_t)(void); -bl_t f3(bl_t bl); // expected-error{{declaring function return value of type 'bl_t' (aka 'int (__generic ^const)(void)') is not allowed}} +bl_t f3a(int); // ex

[PATCH] D82313: [OpenCL] Reject block arguments

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82313/new/ https://reviews.llvm.org/D82313 ___ cfe-commits mailing lis

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

Anastasia added a comment. So if I understand this correctly when the template is instantiated we don't have `QualType` with the address space deduced initially during parsing of a template global variable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D78777: [AST] Use PrintingPolicy for format string diagnosis

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78777/new/ https://reviews.llvm.org/D78777 ___ cfe-commits mailing list cfe-comm

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a subscriber: svenvh. Anastasia added a comment. > I'm somewhat confused by the way this is supposed to work, or why a > separate option exists for OpenCL. The other language flags seem to be > implemented in the driver, not cc1 like OpenCL. I'm not sure this is > the right set

[PATCH] D77923: OpenCL: Fix some missing predefined macros

Anastasia added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. The current solution seems very specific and doesn't provide generic uniform mechanisms for the targets. Would something based on a triple component not work? CHANGES SINCE LAST ACTION https://r

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. > > >> I am looping in @svenvh to discuss this further. Sven, do you think we >> should rename this flag due to current proposed change? Should it be moved >> out of `-cc1` too? > > I would leave `-fdeclare-opencl-builtins` as it is, until it is complete and > ta

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2007563 , @Anastasia wrote: > > > > > >> I am looping in @svenvh to discuss this further. Sven, do you think we > >> should rename this flag due to current proposed change? Should it be moved > >> out of `-cc1` too?

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2007760 , @yaxunl wrote: > In D78979#2007643 , @Anastasia wrote: > > > ah I guess if we leave it under `-cc1 ` we will have the command line > > interface as follows: > > > > -

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2010527 , @svenvh wrote: > In D78979#2007643 , @Anastasia wrote: > > > > Would it not become confusing since the builtins are going to be included > > > by default? Should we re

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2011582 , @jvesely wrote: > In D78979#2006901 , @yaxunl wrote: > > > In D78979#2006847 , @arsenm wrote: > > > > > I'm also wondering if u

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

Anastasia added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signed-zeros -freciprocal-math \ +// R

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

Anastasia added a comment. Can you extend test test/Preprocessor/macro_variadic.cl to cover C++ for OpenCL mode, otherwise LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new/ https://reviews.llvm.org/D85429

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new/ https://reviews.llvm.org/D85429 ___ cfe-commits mailing list c

[PATCH] D85429: [OpenCL] Allow for variadic macros in C++ for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c8a4ee0764c: [OpenCL] Remove warning for variadic macros in C++ for OpenCL. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85429/new

[PATCH] D62574: Add support for target-configurable address spaces.

Anastasia added a comment. In D62574#2210503 , @ebevhan wrote: > I think this works now. It should probably be given a few more reviewers to > have a look. Do you have some suggestions, @Anastasia ? Great! I will look at this again within a week or so. I

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2015214 , @arsenm wrote: > In D78979#2010739 , @Anastasia wrote: > > > In D78979#2010527 , @svenvh wrote: > > > > > In D78979#2007643

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia updated this revision to Diff 262479. Anastasia added a subscriber: jeroen.dobbelaere. Anastasia added a comment. Herald added subscribers: martong, arphaman. Sorry for long latency. I have rebased the patch to the current master and addressed the comments from @mantognini too. CHANGE

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia added a comment. In D60193#1549806 , @mantognini wrote: > When compiling this I get the following warning: > > clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1213:10: warning: enumeration > value 'CXXAddrspaceCastExprClass' not handled in switch

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia marked 4 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:279 + case tok::kw_addrspace_cast: +if (!TypeDependent) { + Op.CheckAddrspaceCast(); mantognini wrote: > Still learning here, so could you/som

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/addrspace_cast.cl:19-24 +template +void test_temp(__global int *par) { + T *var1 = addrspace_cast(par); + __private T *var2 = addrspace_cast<__private T *>(par); +

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia updated this revision to Diff 263085. Anastasia added a comment. - Improved behavior by allowing casting between equivalent types. - Improved formatting. - Improved tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60193/new/ https://reviews.llvm.org/D60193 Files: clang/

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6a237f2046a: [OpenCL] Added addrspace_cast operator in C++ mode. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60193?vs=263085&id=264581#toc

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

Anastasia added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat); mibintc wrote: > mibin

[PATCH] D39936: [OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D39936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

Anastasia added inline comments. Herald added a subscriber: MaskRay. Herald added a project: All. Comment at: clang/docs/UsersManual.rst:3602 +Linking is done using ``spirv-link`` from `the SPIRV-Tools project +`_. Similar to

[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

Anastasia closed this revision. Anastasia added a comment. Committed in https://github.com/llvm/llvm-project/commit/5e1b36ced538cfc80f2400b27e346d2175b04092. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132473/new/ https://reviews.llvm.org/D132473

[PATCH] D130768: [OpenCL][SPIR-V] Add test for extern functions with a pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1a04529c8f: [OpenCL][SPIR-V] Test extern functions with a pointer arg. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to commit: https://revie

[PATCH] D132056: [HLSL] Restrict to supported targets

Anastasia accepted this revision. Anastasia added a comment. This makes sense. I believe the same applies to some other languages i.e. OpenCL, as the way clang evolved currently not all targets are compatible with all languages. In the future we might want to generalize this diagnostics to use

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:61 + +GlobalVariable *replaceCBuffer(CGHLSLRuntime::CBuffer &CB) { + const unsigned CBufferAddressSpace = 4; I don't think I understand the intent of this function along with `CGHL

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:61 + +GlobalVariable *replaceCBuffer(CGHLSLRuntime::CBuffer &CB) { + const unsigned CBufferAddressSpace = 4; python3kgae wrote: > Anastasia wrote: > > I don't think I understand the

[PATCH] D130766: [SPIR-V] Disable opaque pointers in relese 15

Anastasia created this revision. Anastasia added reviewers: svenvh, iliya-diyachkov. Herald added a subscriber: ebevhan. Herald added a project: All. Anastasia requested review of this revision. Herald added a subscriber: MaskRay. As discussed on RFC mapping into SPIR-V requires pointer being pres

[PATCH] D130766: [SPIR-V] Disable opaque pointers in relese 15

Anastasia added a subscriber: linjamaki. Anastasia added a comment. CC to @linjamaki in case there is anything else/different needed for HIP. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130766/new/ https://reviews.llvm.org/D130766 ___ cfe-c

[PATCH] D130768: [OpenCL][SPIR-V] Add test for extern functions with a pointer

Anastasia created this revision. Anastasia added reviewers: svenvh, iliya-diyachkov. Herald added subscribers: ebevhan, yaxunl. Herald added a project: All. Anastasia requested review of this revision. I would like to add this test case that enhances coverage of opaque pointers particularly for t

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.h:46 public: + struct ResBinding { +llvm::Optional Reg; Does this apply to buffers only? In which case it might be better to either nest this into Buffer definition or rename into

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:167 -#if defined(__OPENCL_CPP_VERSION__) || (__OPENCL_C_VERSION__ >= CL_VERSION_2_0) +#if defined(__OPENCL_CPP_VERSION__) || defined(__OPENCL_C_VERSION__) #define NULL ((void*)0) I

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:2 +// RUN: %clang_cc1 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang_cc1 -cl-std=CL1.0 -fdeclare-opencl-builtins -finclude-default-header -verify %s +// RUN: %clang

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105988/new/ https://reviews.llvm.org/D105988 ___ cfe-commits mailing list

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:26 #ifdef CL20 // Accept explicitly pointer to generic address space in OpenCL v2.0. while we are at it, do you mind changing this check into `__OPENCL_CPP_VERSION__ == 200`

[PATCH] D106254: [OpenCL][NFC] Refactors conditional versioning

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106254/new/ https://reviews.llvm.org/D106254

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105987/new/ https://reviews.llvm.org/D105987 ___ cfe-commits mailing list

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/LangStandards.def:187 Digraphs | HexFloat | OpenCL) +LANGSTANDARD_ALIAS_DEPR(openclcpp10, "clc++") I am not sure we should move it into the deprecated category yet... for now

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:329 #endif // defined(__opencl_c_atomic_scope_all_devices) -#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) +#if defined(cl_intel_subgroups) || defined(cl_khr_subgroups) || defined(__ope

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106111/new/ https://reviews.llvm.org/D106111

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

Anastasia added a subscriber: azabaznov. Anastasia added a comment. CC @azabaznov in case he has any feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106111/new/ https://reviews.llvm.org/D106111 _

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10092 "use of type 'double' requires %select{cl_khr_fp64|cl_khr_fp64 and __opencl_c_fp64}0 support">; +def err_opencl_3d_image_writes_requires_extensions : Error< +"use of type

[PATCH] D106434: [OpenCL] Add cl_khr_integer_dot_product

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106434/new/ https://reviews.llvm.org/D106434 _

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 ___ cfe-commits mailing lis

<    2   3   4   5   6   7   8   9   10   11   >