[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 updated this revision to Diff 320188. arnamoy10 added a comment. Added test for the driver-help, also contains all the changes that was done in the previous diff (Aliasing `-J` and `-module-dir`, changing data structures etc). CHANGES SINCE LAST ACTION

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 updated this revision to Diff 320184. arnamoy10 added a comment. Addressing reviewers' comments with the following changes: 1. Aliasing of -module-dir and -J to avoid code duplication 2. Moving the code to set the module and search directories from `FrontendActions.cpp` to

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, sscalpone, sameeranjoshi, SouraVX, tskeith, kiranktp, AMDChirag. Herald added a subscriber: dang. Herald added a reviewer: jansvoboda11. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 updated this revision to Diff 320306. arnamoy10 added a comment. Addressing reviewers' comments, adding `-module-dir` as the default option instead of `-J` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95448/new/ https://reviews.llvm.org/D95448 Files:

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 added a comment. Sounds good to me, thanks for the help. In the meantime I will work on the `fdefault-*` family of flags, which will be dependent on this patch I think. Comment at: clang/include/clang/Driver/Options.td:4124 def A_DASH : Joined<["-"], "A-">, Group;

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 added a comment. In D98657#2701673 , @crownyanguan wrote: > How about -Wl option, it will cause link error like " Only `-Werror` is > supported currently" Thanks for pointing it out. The issue was due to restricting -W` options in `f18` as

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, sscalpone, clementval, tskeith, AMDChirag, SouraVX. Herald added a subscriber: dang. Herald added a reviewer: jansvoboda11. arnamoy10 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

arnamoy10 updated this revision to Diff 320617. arnamoy10 added a comment. A few more comments addressed and a new test case added for write-module check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95448/new/ https://reviews.llvm.org/D95448 Files:

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 332997. arnamoy10 added a comment. rebasing on top of main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 332991. arnamoy10 added a comment. Rebasing on top of main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 332649. arnamoy10 added a comment. Addressing minor issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 added inline comments. Comment at: flang/test/Semantics/dosemantics03.f90:1-2 ! RUN: %S/test_errors.sh %s %t %f18 -Mstandard -Werror +! RUN: %S/test_errors.sh %s %t %flang_fc1 -Werror awarzynski wrote: > Rather than adding the 2nd line, could you

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 332692. arnamoy10 added a comment. Thanks @awarzynski for the comments. 1. Moving diagnostics options parsing to a separate function 2. Adding a check so that `-Wblah` does not trigger the treatment of warnings as werrors, only `-Werror` triggers it 3.

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 11. arnamoy10 added a comment. Updating test case to add `-fsyntax-only` to share with `f18 ` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options.td

[PATCH] D97119: [flang][driver] Add options for -std=f2018

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c7ebf79e923: [flang][driver] Add options for -std=f2018 (authored by arnamoy10). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 333843. arnamoy10 added a comment. Modifying the test cases to: 1. Make it work for `f18` (when `flang-new` is not installed) 2. Adding more options and one test case to check correct functionality with `PrescanAction` and `PrescanAndSemaAction` CHANGES

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

arnamoy10 added inline comments. Comment at: flang/test/Parser/omp-allocate-unparse.f90:1 -! RUN: %f18 -fdebug-no-semantics -funparse -fopenmp %s | FileCheck %s +! RUN: %flang_fc1 -fdebug-unparse-no-sema -fopenmp %s | FileCheck %s ! Check Unparsing of OpenMP Allocate directive

[PATCH] D98657: [flang][driver] Add options for -Werror

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7416e8a8431a: [flang][driver] Add options for -Werror (authored by arnamoy10). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 335246. arnamoy10 added a comment. 1. Separated test cases to check prescan, parse and sema differently. 2. Diagnostics is thrown when anything other that `error` is given for `-W`. This behaviour is reflected in `f18 CHANGES SINCE LAST ACTION

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 335255. arnamoy10 added a comment. Adding newline at the end of a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 Files: clang/include/clang/Driver/Options.td

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4abc5242c0: [flang][driver] Add -fintrinsic-modules-path option (authored by Arnamoy Bhattacharyya arnamoy.bhattachar...@huawei.com, committed by

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 332703. arnamoy10 added a comment. 1. Leaning out the "wrong-option" test case 2. Adding aliases in f18 (`-pedantic` and `-std=2018` for `-Mstandard`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 329970. arnamoy10 added a comment. Herald added a subscriber: ormris. 1. Updated to set the default search directory for the intrinsic module 2. Modified the test case to check the prepend behavior CHANGES SINCE LAST ACTION

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 329976. arnamoy10 added a comment. Clang-formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330023. arnamoy10 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Updating the patch to make -pedantic and -f2018 behave the same way, also updated the test case accordingly. CHANGES SINCE LAST ACTION

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330049. arnamoy10 added a comment. Modifying the algo of default search path extraction for supporting Windows platforms. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files:

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293 + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../tools/flang/include/flang/"); +} tskeith wrote: > tskeith wrote: > >

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330337. arnamoy10 edited the summary of this revision. arnamoy10 added a comment. Update the path based on the patch D98522 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293 + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../tools/flang/include/flang/"); +} tskeith wrote: > Does this work for an

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330968. arnamoy10 added a comment. Adding the test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330973. arnamoy10 added a comment. Moving -std to non-dialect option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 331009. arnamoy10 added a comment. Updating to use available option from `Options.td` instead of creating a new option for `-Werror` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 Files:

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 331528. arnamoy10 added a comment. Fixing bug in test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:292 + std::string driverPath = llvm::sys::fs::getMainExecutable(nullptr, nullptr); + driverPath = driverPath.substr(0, driverPath.size() - 9); + return

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added a comment. Thank you so much for this experiment @awarzynski . I will modify the code accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 ___ cfe-commits mailing list

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 331888. arnamoy10 added a comment. Using `llvm::sys::path::remove_filename` as per suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:292 + std::string driverPath = llvm::sys::fs::getMainExecutable(nullptr, nullptr); + driverPath = driverPath.substr(0, driverPath.size() - 9); + return

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 331871. arnamoy10 added a comment. Separating test cases for accepted input option and not accepted input option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files:

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:298 + driverPath.append("/../include/flang/"); + return driverPath.str().str(); +} awarzynski wrote: > Given this [[ >

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 added inline comments. Comment at: flang/test/Driver/std2018.f90:1 +! REQUIRES: new-flang-driver +! Ensure argument -std=f2018 works as expected. awarzynski wrote: > Would it be possible to share this test with `f18`? Would you please elaborate on how

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 331984. arnamoy10 added a comment. Addressing reviewers' comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added a comment. This has been merged, closing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added a comment. Abandon CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330711. arnamoy10 added a comment. Clang-formatting and addressing reviewers' comments: Moved the default directory append to `setFortranOpts()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files:

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330762. arnamoy10 added a comment. 1. Update the test case to only test `flang-new -fc1` 2. Updated help text 3. Clang-formatted and also removed redundant code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, SouraVX, tskeith, AMDChirag, sscalpone, bryanpkc. Herald added subscribers: jansvoboda11, dang. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330785. arnamoy10 added a comment. Adding the dummy modules CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 330823. arnamoy10 added a comment. Adding one more update that is probably required in semanticContext (inspired by f18), also updated test case to require flang-driver CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 updated this revision to Diff 327230. arnamoy10 added a comment. Minor changes as per comments, also updated commit message to include description of changes related to Setters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 Files:

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

arnamoy10 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97457/new/ https://reviews.llvm.org/D97457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 327572. arnamoy10 added a comment. Rebased on main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 327789. arnamoy10 added a comment. Herald added a subscriber: mgorny. Fixing build failures, also moved the pipeline check to an existing file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files:

[PATCH] D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`

arnamoy10 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98191/new/ https://reviews.llvm.org/D98191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 updated this revision to Diff 329100. arnamoy10 added a comment. Rebasing on main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 326234. arnamoy10 edited the summary of this revision. arnamoy10 added a comment. Addressing comments, by separating the search directories from `fintrinsic-modules-path` in a separate variables. Also added dummy modules for the test case, as using

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added a comment. OK, I will merge it on Monday unless @tskeith has any other comments. Comment at: clang/include/clang/Driver/Options.td:4232-4233 HelpText<"Use INTEGER(KIND=8) for the result type in size-related intrinsics.">; +def fdebug_module_writer :

[PATCH] D97119: [flang][driver] Add options for -std=2018

arnamoy10 updated this revision to Diff 326760. arnamoy10 added a comment. 1. Updated the test case to include a check when the option is not given and make sure works with f18 as well (with `Mstandard`) 2. Changed variable names as suggested. CHANGES SINCE LAST ACTION

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 added inline comments. Comment at: clang/include/clang/Driver/Options.td:4163 defm d_lines_as_comments : BooleanFFlag<"d-lines-as-comments">, Group; -defm default_double_8 : BooleanFFlag<"default-double-8">, Group; -defm default_integer_8 :

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added inline comments. Comment at: flang/test/Semantics/mod-file-rewriter.f90:9 +! RUN: %flang-new -fsyntax-only -fdebug-module-writer %p/Inputs/mod-file-unchanged.f90 2>&1 | FileCheck %s --check-prefix CHECK_UNCHANGED +! RUN: %flang-new -fsyntax-only

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 updated this revision to Diff 324606. arnamoy10 added a comment. Added some setters to work with. Modified the test case to include `flang-new -fc1` as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 Files:

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 324296. arnamoy10 added a comment. Addresses proper handling of sizes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, tskeith, sscalpone, clementval, AMDChirag, SouraVX. Herald added subscribers: jansvoboda11, dang. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 324334. arnamoy10 added a comment. - Added option for setting DOUBLE PRECISION when `fdefault-real-8` is given - Also added link to relevant gfortran doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:254 + if (args.hasArg(clang::driver::options::OPT_fdefault_real_8)) +res.defaultKinds().set_defaultRealKind(8); + if (args.hasArg(clang::driver::options::OPT_fdefault_integer_8)) {

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 324673. arnamoy10 added a comment. Updated test case to check module content CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Options.td

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added inline comments. Comment at: clang/include/clang/Driver/Options.td:4232-4233 HelpText<"Use INTEGER(KIND=8) for the result type in size-related intrinsics.">; +def fdebug_module_writer : Flag<["-"],"fdebug-module-writer">, Group, + HelpText<"Enables showing

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 323480. arnamoy10 edited the summary of this revision. arnamoy10 added a comment. Addressing reviewers' comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files:

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 323746. arnamoy10 added a comment. Addressed latest reviewer's comments, no longer using a pointer for `defaultKinds` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files:

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 325208. arnamoy10 added a comment. Updating the test case to include `-fc1` as well CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td

[PATCH] D97119: [flang][driver] Add options for -std=2018

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, sscalpone, clementval, tskeith. Herald added subscribers: jansvoboda11, dang. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support for the following

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 324785. arnamoy10 marked an inline comment as not done. arnamoy10 added a comment. - Rewritten the test cases - Moved `flarge-sizes` to a standalone test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 updated this revision to Diff 324949. arnamoy10 added a comment. Set the option as a frontend-only option, also modified the test case accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 Files:

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 324997. arnamoy10 added a comment. Added a missing option test for `-flarge-sizes` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Options.td

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 added inline comments. Comment at: flang/test/Flang-Driver/flarge_sizes.f90:1 +! Ensure argument -flarge-sizes works as expected. +! TODO: Add checks when actual codegen is possible for this family awarzynski wrote: > Could you add a `NOOPTION` variant

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, tskeith, sscalpone, clementval, AMDChirag, SouraVX. Herald added subscribers: jansvoboda11, dang, jfb. arnamoy10 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:261 + diags.getCustomDiagID(clang::DiagnosticsEngine::Error, + "Use of `-fdefault-double-8` requires `-fdefault-real-8`"); + diags.Report(diagID);

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 updated this revision to Diff 392189. arnamoy10 added a comment. Addressing reviewers comments Major changes are as follows: 1. Skipping unsupported clauses and skip the case when there is an ordered directive inside the simd construct 2. Traversing all the blocks in the Canonical

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 created this revision. arnamoy10 added reviewers: kiranchandramohan, peixin, bryanpkc, Meinersbur. Herald added a subscriber: hiraditya. arnamoy10 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2586-2587 void CodeGenFunction::EmitOMPSimdDirective(const OMPSimdDirective ) { + + bool UseOMPIRBuilder = CGM.getLangOpts().OpenMPIRBuilder; + if (UseOMPIRBuilder) { Meinersbur

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 updated this revision to Diff 394046. arnamoy10 added a comment. Thanks @Meinersbur for the comments. Addressing reviewers comments: 1. Update code to make the matadata addition correct, as per reviewers comments. 2. Using `LoopInfo` to identify BasicBlocks to iterate through. 3.

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 updated this revision to Diff 400631. arnamoy10 added a comment. Updating as per reviewers comments. Adding a test case in `OpenMPIRBuilderTest.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114379/new/ https://reviews.llvm.org/D114379 Files:

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 updated this revision to Diff 400830. arnamoy10 added a comment. 1. Trying to tackle a test failure 2. Adding `any_of()` as per reviewer's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114379/new/ https://reviews.llvm.org/D114379 Files:

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 updated this revision to Diff 400958. arnamoy10 added a comment. Making any_of one-liner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114379/new/ https://reviews.llvm.org/D114379 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irbuilder_simd.cpp

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fbd33ad623d: [OMPIRBuilder] Add support for simd (loop) directive. (authored by arnamoy10). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114379/new/

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

arnamoy10 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2596 // Check for unsupported clauses - if (!S.clauses().empty()) { -// Currently no clause is supported -return false; + for (OMPClause *C : S.clauses()) { +// Currently only

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac892c70a456: [OMPIRBuilder] Add support for simdlen clause (authored by psoni2628, committed by arnamoy10). Repository: rG LLVM Github Monorepo

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

arnamoy10 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3045 + if (!(Simdlen == nullptr && Safelen == nullptr)) { +ConstantInt *VectorizeWidth = Simdlen == nullptr ? Safelen : Simdlen; addLoopMetadata( psoni2628 wrote: >