[PATCH] D75643: Don't emit pointer to int cast warnings under -Wmicrosoft-cast

aeubanks created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks added reviewers: rnk, thakis, Mordante. MSVC also warns on this: $ cat /tmp/a.c int f(void* p) { return (int) p; } $ cl /c /tmp/a.c C:/src/tmp/a.c(1): warning C4311: 'type cast':

[PATCH] D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode

aeubanks created this revision. aeubanks added a reviewer: rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds warnings to groups recently added in https://reviews.llvm.org/D72231. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75708 Files:

[PATCH] D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode

aeubanks marked an inline comment as done. aeubanks added a comment. > I can push this for you and even give attribution (hooray, git!), but I think > you have enough uploaded code reviews that you could request push access as > described here: >

[PATCH] D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode

aeubanks updated this revision to Diff 248610. aeubanks added a comment. - Add tests for void * Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75708/new/ https://reviews.llvm.org/D75708 Files: clang/lib/Sema/SemaCast.cpp

[PATCH] D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode

aeubanks updated this revision to Diff 248614. aeubanks added a comment. - Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75708/new/ https://reviews.llvm.org/D75708 Files: clang/lib/Sema/SemaCast.cpp

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

aeubanks created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks edited the summary of this revision. aeubanks added reviewers: thakis, rnk. aeubanks retitled this revision from "Move warnings added in https://reviews.llvm.org/D75708 under

[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

This revision was automatically updated to reflect the committed changes. Closed by commit rG51d7f645448b: Dont emit pointer to int cast warnings under -Wmicrosoft-cast (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D75643?vs=248306=249203#toc Repository: rG LLVM

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

aeubanks added a comment. Specifically regarding ../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller integer type 'unsigned long' from 'void *', I sent out a change to fix that: https://chromium-review.googlesource.com/c/chromium/src/+/2091215, and tried compiling with

[PATCH] D77962: PR38490: Support reading values out of __uuidof(X) expressions during constant evaluation.

aeubanks added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3949 + // Special-case reading from __uuidof expressions so we don't have to + // construct an APValue for the whole uuid. + if (LVal.Designator.isOnePastTheEnd()) { For my

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

aeubanks added a comment. In D66490#1638708 , @hfinkel wrote: > In D66490#1638162 , @rupprecht wrote: > > > We already know that we don't want this enabled for tsan builds due to > >

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") {

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks updated this revision to Diff 260103. aeubanks added a comment. Handle /showIncludes:user Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836 Files:

[PATCH] D78939: Strip -showIncludes in getClangStripDependencyFileAdjuster()

aeubanks created this revision. aeubanks added a reviewer: thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow-up to https://reviews.llvm.org/D78836. Also consolidate some test cases. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78939

[PATCH] D78939: Strip -showIncludes in getClangStripDependencyFileAdjuster()

This revision was automatically updated to reflect the committed changes. Closed by commit rGdab1326a5ae3: Strip -showIncludes in getClangStripDependencyFileAdjuster() (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78939/new/

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commandsIn command lines with /showIncludes, clangd would output includes to stdout, breaking clients.

aeubanks created this revision. aeubanks added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/322. Repository: rG LLVM Github Monorepo

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks added a comment. Herald added a subscriber: ormris. I did verify that clangd on vscode now works on Windows on the LLVM codebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks added a comment. In D78836#2003696 , @kadircet wrote: > thanks, lgtm. do you have commit access? Yep :) Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG8000d506afcd: [clangd] Strip /showIncludes in clangd compile commands (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks updated this revision to Diff 260040. aeubanks added a comment. Add test in ToolingTest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836 Files:

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:82 +TEST(CommandMangler, StripShowIncludes) { + auto Mangler = CommandMangler::forTests(); sammccall wrote: >

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d5bb94d7838: Run Coverage pass before other *San passes under new pass manager (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks updated this revision to Diff 262248. aeubanks added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79445/new/ https://reviews.llvm.org/D79445 Files: clang/lib/CodeGen/BackendUtil.cpp Index:

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks added a comment. In D79445#2021311 , @leonardchan wrote: > In `addSanitizersAtO0`, could you make something similar to the `ASanPass` > lambda for the MSan passes and also apply it when adding kernel MSan? It ends up calling an extra

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks created this revision. aeubanks added reviewers: nemanjai, vitalybuka, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Properly forward TrackOrigins and Recover user options to the MSan pass under the new pass manager. This makes the number of

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

aeubanks created this revision. aeubanks added reviewers: vitalybuka, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes compiler-rt/test/msan/coverage-levels.cpp under the new pass manager (final check-msan test!). Under the old pass manager, the

[PATCH] D79895: Fix warning about using uninitialized variable as function const reference parameter

aeubanks added a comment. The summary of this change should be "add warning..." not "fix warning..." Could you add more detail into the commit description? About newly introduced diagnostic groups, etc. Also, I thought I saw tests in a previous revision but now they seem to be gone? CHANGES

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2110 +def warn_uninit_const_reference : Warning< + "variable %0 is uninitialized when passes as a const reference parameter " + "here">, InGroup, DefaultIgnore;

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

aeubanks added a comment. In D79698#2037305 , @leonardchan wrote: > Just to followup on this: We believe the root cause of the error we're > running into is that some sancov guards in one comdat are being referenced by > symbols in another comdat, so

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG48451ee6a7ee: [MSan] Pass MSan command line options under new pass manager (authored by aeubanks). Repository: rG LLVM

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks updated this revision to Diff 262426. aeubanks added a comment. Revert back to initial patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79445/new/ https://reviews.llvm.org/D79445 Files: clang/lib/CodeGen/BackendUtil.cpp Index:

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. One last nit, otherwise lgtm. But I'm not super familiar with this area, it'd be good to get another review from somebody more familiar. Comment at:

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 290159. aeubanks added a comment. remove some includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, mgorny. Herald added projects: clang, LLVM. aeubanks requested review of this revision. This changes --print-before/after to be a list of strings rather than legacy passes.

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

aeubanks added a comment. diff for hwasan + -O1: 14a15 > @__hwasan_shadow = external global [0 x i8] 72a74,109 > declare void @__hwasan_loadN(i64, i64) > > declare void @__hwasan_load1(i64) > > declare void @__hwasan_load2(i64) > > declare void @__hwasan_load4(i64) > > declare void

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rGafff74e5c26f: [HWAsan][NewPM] Handle hwasan like other sanitizers (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88936/new/

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

aeubanks added a comment. I've also been seeing some failures on phab reviews, e.g. https://reviews.llvm.org/D89188. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. aeubanks requested review of this revision. Some targets may add required passes via TargetMachine::registerPassBuilderCallbacks(). We need to run those even under

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

aeubanks created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. aeubanks requested review of this revision. Move it as an EP callback (-O[123]) or in addSanitizersAtO0. This makes it not run in ThinLTO pre-link (like the other sanitizers), so

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aeubanks added a comment. This seems to be breaking determinism on Windows builds, see https://crbug.com/1117026. Can this be reverted and fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

aeubanks added a comment. This doesn't work with -mtune=generic (https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html), can gcc compatibility be added? (https://crbug.com/1119448) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85384/new/

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

aeubanks added a comment. In D85384#2226866 , @craig.topper wrote: > In D85384#2226842 , @aeubanks wrote: > >> This doesn't work with -mtune=generic >> (https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html), can

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

aeubanks updated this revision to Diff 285752. aeubanks added a comment. -target -> -triple rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/ https://reviews.llvm.org/D85457 Files: clang/test/CodeGen/O0-no-skipped-passes.c

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ea8779c2e0: [NewPM][optnone] Mark various passes as required (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/

[PATCH] D86008: [NewPM][optnone] Fix clang tests in preparation for -enable-npm-optnone

aeubanks created this revision. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. aeubanks requested review of this revision. These are the last clang tests failing before being able to turn on -enable-npm-optnone. Repository: rG LLVM

[PATCH] D86011: [test] Fix thinlto-debug-pm.c in preparation for -enable-npm-optnone

aeubanks created this revision. aeubanks added reviewers: asbirlea, ychen. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. aeubanks requested review of this revision. This fails due to the clang invocation running at -O0,

[PATCH] D86008: [NewPM][optnone] Fix clang tests in preparation for -enable-npm-optnone

aeubanks updated this revision to Diff 285797. aeubanks added a comment. Split out other test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86008/new/ https://reviews.llvm.org/D86008 Files: clang/test/CodeGen/aggregate-assign-call.c Index:

[PATCH] D86011: [test] Fix thinlto-debug-pm.c in preparation for -enable-npm-optnone

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3973195095e: [test] Fix thinlto-debug-pm.c in preparation for -enable-npm-optnone (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86008: [test] Fix aggregate-assign-call.c in preparation for -enable-npm-optnone

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0ceff94d663: [test] Fix aggregate-assign-call.c in preparation for -enable-npm-optnone (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87923: [MS] On x86_32, pass overaligned, non-copyable arguments indirectly

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87923/new/ https://reviews.llvm.org/D87923

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

aeubanks added a comment. In D88138#2304243 , @quic_aankit wrote: > @aeubanks Thanks for the review. Can you also commit the patch on my behalf? Committed in ce5379f0f0675592fd10a522009fd5b1561ca72b

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

This revision was automatically updated to reflect the committed changes. Closed by commit rGce5379f0f067: [NPM] Add target specific hook to add passes for New Pass Manager (authored by aeubanks). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. aeubanks added reviewers: vitalybuka, leonardchan. This was attempted once before in https://reviews.llvm.org/D79698, but was reverted due to the coverage pass

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG922fa2fce38b: Run Coverage pass before other *San passes under new pass manager, round 2 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks marked 2 inline comments as done. aeubanks added inline comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:597-598 /// /// This extension point allows adding optimizations at the very end of the /// function optimization pipeline. A key difference

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks added a comment. In D80692#2061219 , @leonardchan wrote: > Would be worthwhile to write a small test that asserts Sancov runs before the > other sanitizers under the new PM? > > Aside from this, LGTM. Asserting that sancov runs before other

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG1285e8bcac2c: Run Coverage pass before other *San passes under new pass manager, round 2 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks updated this revision to Diff 267087. aeubanks added a comment. Update some CHECKs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80692/new/ https://reviews.llvm.org/D80692 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks updated this revision to Diff 267073. aeubanks added a comment. I foolishly submitted without running check-all, and it turns out this broke a test under check-clang. Looks like https://reviews.llvm.org/D62888 added tests in sancov-new-pm.c to make sure that sancov + LTO work together,

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks added a comment. In D89158#2357850 , @ychen wrote: > IIUC, this is the NPM version of EP_EarlyAsPossible in legacy PM for O0, > right? Between the choice of (1) [this patch and ] reusing all existing EP > callbacks and letting optnone filtering

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks updated this revision to Diff 301145. aeubanks added a comment. run -> invoke Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto : PipelineStartEPCallbacks) +C(MPM); ychen wrote: >

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks updated this revision to Diff 301132. aeubanks added a comment. only run passes in PipelineStartEPCallbacks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files:

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto : PipelineStartEPCallbacks) +C(MPM); ychen wrote: > asbirlea wrote: > > aeubanks wrote: > > >

[PATCH] D88609: Use uint64_t for branch weights instead of uint32_t

aeubanks added a comment. This was reverted due to crashes caused by adding branch weights overflowing uint64_t. Now in BranchProbabilityInfo.cpp, if the sum of weights overflows, scale down all weights by UINT32_MAX (See `ScaleWeights()`). Is that ok? Repository: rG LLVM Github Monorepo

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks updated this revision to Diff 300575. aeubanks added a comment. rebase add assert for O0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 300555. aeubanks added a comment. move map into PassInstrumentationCallbacks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 Files:

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1439 if (CodeGenOpts.OptimizationLevel == 0) { + PB.runRegisteredEPCallbacks(MPM, Level, CodeGenOpts.DebugPassManager); + nikic wrote: > It should be possible to simplify

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks updated this revision to Diff 279563. aeubanks added a comment. Rename OptNoneInstrumentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://reviews.llvm.org/D83519 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D83519: [NewPM] Support optnone under new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rGb13b85818218: [NewPM] Support optnone under new pass manager (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/

[Differential] D83519: [NewPM] Support optnone under new pass manager

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb13b85818218: [NewPM] Support optnone under new pass manager

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

aeubanks added a comment. I'm looking at enabling the -enable-npm-optnone flag and FullUnroll.ll fails. I understand that loop unrolling should be forced when some metadata is present, but the FullUnroll.ll test seems to check for a lot more than that. It checks for (roughly) two unconditional

[PATCH] D85252: [Driver] Accept -fno-lto in clang-cl

aeubanks created this revision. aeubanks added reviewers: hans, thakis. Herald added subscribers: cfe-commits, dang, dexonsmith, inglorion. Herald added a project: clang. aeubanks requested review of this revision. Some compiler-rt tests check for the presence of the compiler accepting -fno-lto

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. Actually sorry, it does still seem like there are false positives on structs. Reduced: $ cat /tmp/a.cpp struct A { const char* a; const char* b; const char* c; }; static constexpr A foo2 = A{"", ""

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

aeubanks updated this revision to Diff 284875. aeubanks added a comment. Specify target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/ https://reviews.llvm.org/D85457 Files: clang/test/CodeGen/O0-no-skipped-passes.c

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. In D85545#2211070 , @xbolva00 wrote: > I check if all elements of init list are strings, so this is not > exactly true "struct checker" (I have no such info in that part of > code..) but I consider it good enough. Your test case

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. In D85545#2208266 , @arthur.j.odwyer wrote: > To decrease the number of false-positives, you could emit the warning only > if *exactly one* comma was missing. > > const char *likely_a_bug[] = { "a", "b", "c" "d", "e", "f",

[PATCH] D85457: [NewPM][optnone] Mark various passes as required

aeubanks updated this revision to Diff 284093. aeubanks added a comment. Herald added subscribers: cfe-commits, jfb, eraman. Herald added a project: clang. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85457/new/

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. It still seems to trigger on structs at head: $ cat /tmp/a.cc struct A { const char *a; const char *b; const char *c; }; static A a = {"", "" "", ""}; $ ./build/bin/clang++ -Wstring-concatenation -o /dev/null -c /tmp/a.cc C:/src/tmp/a.cc:10:15: warning:

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aeubanks added a comment. After not warning on structs, this did find a real missing comma in the Chromium codebase, so thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545

[PATCH] D85252: [Driver] Accept -fno-lto in clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc43852e4a8: [Driver] Accept -fno-lto in clang-cl (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85252/new/

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

aeubanks added a comment. In D83013#2132070 , @echristo wrote: > Adding Chandler and Alina here as well. > > In general, I don't think that this is such a great idea. Being able to have > this sort of thing work more reliably is one of the reasons for

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks added a comment. In D83519#2144463 , @aeubanks wrote: > In D83519#2144403 , @ychen wrote: > > > High-level request: how about split this patch into two, the first for the > > `require` pass part; the

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added a comment. In D83519#2144403 , @ychen wrote: > High-level request: how about split this patch into two, the first for the > `require` pass part; the second for the PassInstrument callback. Then we

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks created this revision. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. This uses pass instrumentation callbacks to skip optional passes. PassInfoMixin now declares that passes

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any()); + ShouldRun &= C(Pass.name(),

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:150 for (auto : Callbacks->BeforePassCallbacks) - ShouldRun &= C(Pass.name(), llvm::Any()); + ShouldRun &= C(Pass.name(),

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks added a comment. In D79895#2107796 , @nick wrote: > > This warning can be turned off by the flag > > `-Wno-uninitialized-const-reference`. > > Suggesting to turn off the warning should be the last resort. I am pointing > to the false positives

[PATCH] D81422: Change filecheck default to dump input on failure

aeubanks added a comment. FWIW I didn't see this change initially but was pleasantly surprised with the extra output when debugging a newly added (relatively small) test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81422/new/

[PATCH] D82231: [NFC] Remove unused pass name parser classes

aeubanks updated this revision to Diff 272166. aeubanks added a comment. Unintended change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82231/new/ https://reviews.llvm.org/D82231 Files: llvm/include/llvm/IR/LegacyPassNameParser.h Index:

[PATCH] D82231: [NFC] Remove unused pass name parser classes

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. aeubanks added a reviewer: echristo. aeubanks updated this revision to Diff 272166. aeubanks added a comment. Unintended change Looks like these were for the most

[PATCH] D82231: [NFC] Remove unused pass name parser classes

This revision was automatically updated to reflect the committed changes. Closed by commit rG2565581e3704: [NFC] Remove unused pass name parser classes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82231/new/

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks added a comment. In D79895#2110345 , @nick wrote: > > We didn't see it in the code bases I work with, so is boost a special case, > > or an example of a common practice? > > I do not have resources to make such statistics, but there are

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks added a comment. This is causing some tests under check-clang to fail, taking a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/ https://reviews.llvm.org/D81323 ___ cfe-commits

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks updated this revision to Diff 268993. aeubanks added a comment. Update some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/ https://reviews.llvm.org/D81323 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks added a comment. Could you take a look again at the test changes? LTO + sanitizers doesn't work under NPM because [1] never ends up calling the passes registered via registerOptimizerLastEPCallback(). [1]

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks created this revision. aeubanks added reviewers: leonardchan, vitalybuka. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes pr33372.cpp under the new pass manager. ASan adds padding to globals. For example, it will change a {i32, i32, i32} to a {{i32,

[PATCH] D81273: [WIP] Enable new pass manager as default DO NOT SUBMIT

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. Just for bot testing Depends on D81175 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81273 Files:

[PATCH] D81323: Move *San module passes later in the NPM pipeline

This revision was automatically updated to reflect the committed changes. Closed by commit rGc07339c6754e: Move *San module passes later in the NPM pipeline (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

aeubanks created this revision. aeubanks added a reviewer: akhuang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move check inside of addHeapAllocSiteMetadata(). Change check to DebugInfo <= DebugLineTablesOnly. Repository: rG LLVM Github Monorepo

[PATCH] D81481: Change debuginfo check for addHeapAllocSiteMetadata

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc38793852c0: Change debuginfo check for addHeapAllocSiteMetadata (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81481/new/

  1   2   3   4   5   6   7   8   >