[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we're limited to 32 bit ints in diagnostics. With support for 4GB alignments coming soon, we need to report 4GB as the max alignment

[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedfff2f8b043: [clang] Allow printing 64 bit ints in diagnostics (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D110599: [test] Don't run optimization-remark.c against the legacy PM

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We may not emit some inlining remarks under -O0 (which seems reasonable), so use -O1 in these tests. This happens to make it pass when the legacy PM

[PATCH] D110599: [test] Don't run optimization-remark.c against the legacy PM

aeubanks updated this revision to Diff 375445. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110599/new/ https://reviews.llvm.org/D110599 Files: clang/test/Frontend/optimization-remark.c Index:

[PATCH] D110607: [Inliner] Attempt to inline calls to alwaysinline functions first

aeubanks added a comment. I'll update the tests if this lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110607/new/ https://reviews.llvm.org/D110607 ___ cfe-commits mailing list

[PATCH] D110607: [Inliner] Attempt to inline calls to alwaysinline functions first

aeubanks created this revision. aeubanks added a reviewer: mtrofin. Herald added subscribers: ormris, hiraditya, eraman. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For PR46945 we added an extra alwaysinline

[PATCH] D106585: Fix clang debug info irgen of i128 enums

aeubanks added a comment. In D106585#3169898 , @rnk wrote: > This usage of isSameValue seems suspicious: > https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LLVMContextImpl.h#L389 > > It seems to allow the possibility that APInts of differing

[PATCH] D106585: Fix clang debug info irgen of i128 enums

aeubanks added a comment. In D106585#3170019 , @aeubanks wrote: > In D106585#3169898 , @rnk wrote: > >> This usage of isSameValue seems suspicious: >>

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks created this revision. Herald added subscribers: ormris, steven_wu, hiraditya, arichardson, inglorion, sbc100, mgorny, emaste. Herald added a reviewer: MaskRay. Herald added a reviewer: gkm. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. aeubanks requested review

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks updated this revision to Diff 386748. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113738/new/ https://reviews.llvm.org/D113738 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/Config.h

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19867de9e793: [NewPM] Only invalidate modified functions analyses in CGSCC passes + turn on… (authored by aeubanks). Changed prior to commit:

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks updated this revision to Diff 386882. aeubanks added a comment. add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113738/new/ https://reviews.llvm.org/D113738 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/Config.h

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

aeubanks added a comment. Herald added a reviewer: ctetreau. I rebased this and there are still major memory regressions for tramp3d-v4: https://llvm-compile-time-tracker.com/compare.php?from=f63405f6e3d30f33e715ef5ad09136127535a3fb=aec1375e4afe90727f1c30dae1659d11a20d=max-rss Perhaps we

[PATCH] D112971: [NFC] Remove LinkAll*.h

aeubanks created this revision. Herald added a subscriber: hiraditya. aeubanks requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added a

[PATCH] D112971: [NFC] Remove LinkAll*.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe364e5dc78c: [NFC] Remove LinkAll*.h (authored by aeubanks). Herald added a subscriber: awarzynski. Changed prior to commit:

[PATCH] D112971: [NFC] Remove LinkAll*.h

aeubanks added a comment. Turns out the comments are misleading, they aren't to prevent specific functions from being removed, they're to force an odr usage of various functions, which in turn makes sure that globals in the corresponding translation units with the function definition are

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1845 + if (auto *Call = dyn_cast(U)) +FAM.invalidate(*Call->getParent()->getParent(), FuncPA); +} nikic wrote: > Do we need to worry about indirect references

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks added a comment. In D113304#3112937 , @nikic wrote: > I don't think I fully understand the interaction this has with eager > invalidation. I would have expected that if we eagerly invalidate, then this > fine-grained invalidation wouldn't make

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks updated this revision to Diff 385539. aeubanks added a comment. address comments [argpromo] only invalidate direct callers that call the function, not if the function is a parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks added inline comments. Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:1017 +// invalidate analyses for all functions in this SCC later. +FAM.invalidate(F, PreservedAnalyses::none()); } mtrofin wrote: > Should we do this if !Changed?

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks updated this revision to Diff 385642. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113304/new/ https://reviews.llvm.org/D113304 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll

[PATCH] D112971: [NFC] Remove LinkAll*.h

aeubanks added a comment. the comments were misleading, I updated them in D113074 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112971/new/ https://reviews.llvm.org/D112971

[PATCH] D112935: [NFC] Rename GVN -> GVNPass and SROA -> SROAPass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d8750c3dad4: [NFC] Rename GVN - GVNPass and SROA - SROAPass (authored by aeubanks). Herald added a project: clang. Herald added a subscriber:

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

aeubanks created this revision. aeubanks added a reviewer: asbirlea. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

aeubanks updated this revision to Diff 384842. aeubanks added a comment. update LTOBackend.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113210/new/ https://reviews.llvm.org/D113210 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13317286f829: [NewPM] Use the default AA pipeline by default (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

aeubanks added a comment. fixed with 7f62759697762473 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113210/new/ https://reviews.llvm.org/D113210

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

aeubanks added a comment. In D113210#3110780 , @Meinersbur wrote: > This change caused the Polly build to fail: > https://lab.llvm.org/buildbot/#/builders/10/builds/7501 > > opt: >

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks created this revision. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya, eraman. Herald added a reviewer: ctetreau. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previously, any change in

[PATCH] D113231: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks updated this revision to Diff 385122. aeubanks added a comment. Herald added subscribers: cfe-commits, wenlei, steven_wu. Herald added a project: clang. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113231/new/

[PATCH] D112732: [ASan] Process functions in Asan module pass

aeubanks added a comment. can we rename "asan-module" to "asan" after this change? and remove the extra "asan-pipeline"/"asan-function-pipeline" parsing callbacks in NewPMDriver.cpp? and previously we had `-passes=require` because a function pass couldn't invoke a module analysis, but that's

[PATCH] D114908: [clang] Don't call inheritDefaultTemplateArguments() on CXXDeductionGuideDecl's template parameters

aeubanks created this revision. aeubanks added a reviewer: rsmith. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A CXXDeductionGuideDecl references its class's template parameters (rather than cloning them). This causes us to

[PATCH] D114908: [clang] Don't call inheritDefaultTemplateArguments() on CXXDeductionGuideDecl's template parameters

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114908/new/ https://reviews.llvm.org/D114908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115790: [Coroutines] Run CoroEarly Pass in front of AlwaysInliner in O0 pass and warn for always_inline coroutine

aeubanks added a comment. pass manager changes seem fine, but I'll let somebody else lgtm Comment at: llvm/test/Other/new-pm-O0-defaults.ll:34 ; CHECK-DIS-NEXT: Running pass: AddDiscriminatorsPass +; CHECK-CORO: Running pass: CoroEarlyPass ; CHECK-DIS-NEXT: Running pass:

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

aeubanks added a comment. I agree that we really should only have one attribute builder class. A SmallVector does seem nicer than having a static array the size of all possible attributes. We should avoid creating copies of AttributeLists/Sets into AttrBuilders and just have AttrBuilder be a

[PATCH] D106184: [BPF] Use elementtype attribute for preserve.array/struct.index intrinsics

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106184/new/ https://reviews.llvm.org/D106184

[PATCH] D114908: [clang] Don't call inheritDefaultTemplateArguments() on CXXDeductionGuideDecl's template parameters

aeubanks added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3784-3790 + if (auto *TD = dyn_cast(D)) { +// CXXDeductionGuideDecls reference the class template parameters so we need +// to make sure not to call this twice on the same template

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This mitigates the extra memory caused by D115725 . Repository: rG LLVM Github Monorepo

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks updated this revision to Diff 399840. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117262/new/ https://reviews.llvm.org/D117262 Files: clang/lib/CodeGen/Address.h Index: clang/lib/CodeGen/Address.h

[PATCH] D116983: Clone constructor template parameters when creating deduction guide

aeubanks created this revision. rsmith added inline comments. aeubanks published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comment at: clang/lib/Sema/SemaTemplate.cpp:2174 + Args.addOuterTemplateArguments(SubstArgs); +

[PATCH] D116983: Clone constructor template parameters when creating deduction guide

aeubanks updated this revision to Diff 399514. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116983/new/ https://reviews.llvm.org/D116983 Files: clang/lib/Sema/SemaTemplate.cpp

[PATCH] D116983: Clone constructor template parameters when creating deduction guide

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2174 + Args.addOuterTemplateArguments(SubstArgs); + Args.addOuterRetainedLevel(); + NamedDecl *NewParam = transformTemplateParameter(Param, Args); rsmith wrote: > This

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks abandoned this revision. aeubanks added a comment. I posted an RFC a while back for basically removing size levels from optimization levels but never seriously looked into it: https://groups.google.com/g/llvm-dev/c/NrZsR8OZTts/m/P5t14TKaAQAJ Repository: rG LLVM Github Monorepo

[PATCH] D121847: [OpaquePtr][ARM] Use elementtype on ldrex/ldaex/stlex/strex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2371c5a0e06d: [OpaquePtr][ARM] Use elementtype on ldrex/ldaex/stlex/strex (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121847: [OpaquePtr][ARM] Use elementtype on ldrex/ldaex/stlex/strex

aeubanks created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Includes verifier changes checking the elementtype,

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

aeubanks added a comment. In D120527#3381835 , @nikic wrote: > @aeubanks Do you plan to take care of the corresponding arm intrinsics as > well? yes I'll do those Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121167: [NewPM] Actually recompute GlobalsAA before module optimization pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4fc7c551: [NewPM] Actually recompute GlobalsAA before module optimization pipeline (authored by aeubanks). Herald added a project: clang. Herald

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

aeubanks updated this revision to Diff 415137. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120527/new/ https://reviews.llvm.org/D120527 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/arm_acle.c

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

aeubanks added a comment. In D120527#3372092 , @dmgreen wrote: > Seems OK. Thanks for the patch. > > Do opaque pointer variants (like `i32 @llvm.aarch64.stxr.p0(i64 1, ptr > elementtype(i64) %ptr.0)`) get tested automatically from the existing tests >

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG250620f76e07: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

aeubanks updated this revision to Diff 414225. aeubanks added a comment. Herald added a project: All. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120527/new/ https://reviews.llvm.org/D120527 Files:

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

aeubanks created this revision. Herald added a subscriber: dmgreen. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have to keep track of pointer pointee types with opaque pointers. Repository:

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

aeubanks added a comment. I'm very out of my depth with tablegen, let me know if there's a more elegant way of doing this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122046/new/ https://reviews.llvm.org/D122046

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on various intrinsics

aeubanks updated this revision to Diff 411274. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120527/new/ https://reviews.llvm.org/D120527 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/arm_acle.c

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks updated this revision to Diff 411825. aeubanks added a comment. add header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120666/new/ https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index:

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index: clang/docs/ClangPlugins.rst

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks updated this revision to Diff 411829. aeubanks added a comment. reword Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120666/new/ https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index: clang/docs/ClangPlugins.rst

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1315c61a03e: [docs] Add note about interaction between clang plugins and -clear-ast-before… (authored by aeubanks). Repository: rG LLVM Github

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks updated this revision to Diff 411851. aeubanks added a comment. reword Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120666/new/ https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index: clang/docs/ClangPlugins.rst

[PATCH] D120757: [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in CreatePointerBitCastOrAddrSpaceCast

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lg if check-clang passes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120757/new/ https://reviews.llvm.org/D120757

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

aeubanks updated this revision to Diff 416989. aeubanks added a comment. fix dyn_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122046/new/ https://reviews.llvm.org/D122046 Files: clang/utils/TableGen/MveEmitter.cpp Index:

[PATCH] D122275: [PassManager][Coroutine] Run passes under -O0 conditionally and run GlobalDCE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bd66b312c3e: [PassManager][Coroutine] Run passes under -O0 conditionally and run GlobalDCE (authored by aeubanks). Herald added subscribers:

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

aeubanks added inline comments. Comment at: clang/utils/TableGen/MveEmitter.cpp:1197 +const Type *Ty = nullptr; +if (auto *DI = dyn_cast(D->getArg(0))->getOperator()) + if (auto *PTy = dyn_cast(getType(DI, Param))) simon_tatham wrote: > dblaikie

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0270f6e9583: [clang] Remove Address::deprecated from MveEmitter (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We clear the type cache when SkippedLayout is true and we're converting a function type. However, we then immediately put the computed entry in the

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks updated this revision to Diff 405129. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118744/new/ https://reviews.llvm.org/D118744 Files: clang/lib/CodeGen/CodeGenTypes.cpp

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks planned changes to this revision. aeubanks added a comment. I'm seeing a similar crash with struct z { static z dc(z); z (*di)(z); }; z bar = z::dc({}); going to try to fix that here as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118936: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -O1 doesn't seem necessary here. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118936 Files:

[PATCH] D119011: [clang] Cache OpenCL types

aeubanks created this revision. Herald added subscribers: Naghasan, ldrumm, Anastasia, yaxunl. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we call CGOpenCLRuntime::convertOpenCLSpecificType() multiple times we should get

[PATCH] D119011: [clang] Cache OpenCL types

aeubanks added a comment. In D119011#3297305 , @Anastasia wrote: > Just to understand the intent - is this a performance optimization or > functionality fix? This is a functionality fix. > Also is there any way to test this? I came across this while

[PATCH] D119011: [clang] Cache OpenCL types

aeubanks updated this revision to Diff 406024. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119011/new/ https://reviews.llvm.org/D119011 Files: clang/lib/CodeGen/CGOpenCLRuntime.cpp

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks updated this revision to Diff 406077. aeubanks added a comment. fix more issues, ready to review I've split the OpenCL change out into D119011 , will rebase once that's submitted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

aeubanks added a comment. can we also remove the -cc1 option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118313/new/ https://reviews.llvm.org/D118313 ___ cfe-commits mailing list

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. I think this is fine, it gives clang users another chance to report new PM blockers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118744: [clang] Fix some clang->llvm type cache invalidation issues

aeubanks added a comment. In D118744#3301977 , @rnk wrote: > This seems unfortunately complex, but I think we can live with it for a year > or two. > > Is it possible to use the compile time tracker to benchmark if this > clang->LLVM type cache

[PATCH] D118744: [clang] Fix some clang->llvm type cache invalidation issues

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45084eab5e63: [clang] Fix some clang-llvm type cache invalidation issues (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

aeubanks updated this revision to Diff 406705. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119215/new/ https://reviews.llvm.org/D119215 Files: clang/lib/CodeGen/CodeGenTypes.cpp

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When not going through the main Clang->LLVM type cache, we'd accidentally create multiple different opaque types for a member pointer type. This

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

aeubanks updated this revision to Diff 406908. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119215/new/ https://reviews.llvm.org/D119215 Files: clang/lib/CodeGen/CodeGenTypes.cpp

[PATCH] D119011: [clang] Cache OpenCL types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2724c153f929: [clang] Cache OpenCL types (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118744: [clang] Fix some clang->llvm type cache invalidation issues

aeubanks updated this revision to Diff 406504. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118744/new/ https://reviews.llvm.org/D118744 Files: clang/lib/CodeGen/CGBuilder.h clang/lib/CodeGen/CGCall.cpp

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf05a63f9a09b: [clang] Properly cache member pointer LLVM types (authored by aeubanks). Changed prior to commit:

[PATCH] D118936: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf16cc5df2288: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address… (authored by aeubanks). Repository: rG LLVM Github

[PATCH] D119061: [Clang] noinline call site attribute

aeubanks added inline comments. Comment at: clang/test/Sema/attr-noinline.cpp:14 +} + +[[clang::noinline]] static int i = bar(); // expected-error {{'noinline' attribute only applies to functions and statements}} xbolva00 wrote: > aaron.ballman wrote: > >

[PATCH] D119496: [Clang][OpaquePtr] Remove calls to deprecated Address constructor

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lg, thanks! I was just looking at one of these when trying to build Chrome with opaque pointers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks added a comment. # no asserts, no debuginfo, -O3 $ du -b clang-stable clang-patched 83539528clang-stable 83528456clang-patched clang's code size actually goes down with this patch llvm-compile-time-tracker:

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:30 + // Int portion stores lower 3 bits of the log of the alignment. + llvm::PointerIntPair ElementType; nikic wrote: > Are we guaranteed 3 bits even on 32-bit architectures? Apparently

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (PR53360)

aeubanks added a comment. The existing implementation only inlines top level call sites, which doesn't match gcc where all calls are recursively inlined [1]. gcc's implementation makes more sense IMO, only inlining top level call sites doesn't seem super useful. I'd vote for properly

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (PR53360)

aeubanks added a comment. sounds good for the purposes of going back to what we had before, but we should reconsider the attribute support Comment at: llvm/lib/Transforms/IPO/AlwaysInliner.cpp:95 - // Remember to try and delete this function afterward. This both avoids

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (#53360)

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/Transforms/Coroutines/coro-retcon-once-private.ll:6 -; CHECK: define internal { i8*, i32 } @f(i8* %buffer, i32* %array) -; CHECK-NEXT: entry:

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks updated this revision to Diff 403323. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117262/new/ https://reviews.llvm.org/D117262 Files: clang/lib/CodeGen/Address.h Index:

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:29 +// so we fallback to storing the alignment separately. +template = 8> class AddressImpl {}; + nikic wrote: > Why do we need the extra T parameter? without it we end up instantiating

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1613f05ae0c: [NFC] Store Addresss alignment into PointerIntPairs (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:70 +unsigned AlignLog = (Pointer.getInt() << 3) | ElementType.getInt(); +return CharUnits::fromQuantity(1UL << AlignLog); + } LegalizeAdulthood wrote: > This is causing warnings to

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks updated this revision to Diff 403070. aeubanks added a comment. only use PointerIntPair when alignof(Value*) >= 8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117262/new/ https://reviews.llvm.org/D117262 Files:

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. https://llvm-compile-time-tracker.com/compare.php?from=c39d22d1968cf07e54b5816ba76dccef8acaace1=1958f5a5fb5be3fb5b6bad5079a2f3485db0b0e9=instructions mostly neutral but a tiny bit of green

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9faab435a357: [docs] Mention that we are in the process of removing the legacy PM for the… (authored by aeubanks). Repository: rG LLVM Github

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

aeubanks created this revision. aeubanks added reviewers: nikic, MaskRay. Herald added subscribers: StephenFan, awarzynski. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang,

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

aeubanks updated this revision to Diff 422038. aeubanks added a comment. remove help text instead of modifying generated docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123547/new/ https://reviews.llvm.org/D123547 Files:

[PATCH] D123547: [docs] Mention that we are in the process of removing the legacy PM for the optimization pipeline

aeubanks added a comment. I tried regenerating ClangCommandLineReference.rst and it's a little out of date. I'll regenerate it in a separate change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123547/new/ https://reviews.llvm.org/D123547

<    1   2   3   4   5   6   7   8   >