[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rG3d0b61926139: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter (authored by

[PATCH] D118924: [clang-format] Fix formatting of macro definitions with a leading comment.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3574 + // line. + FirstNonCommentOnLine |= FirstOnLine; +} else { I really don't like bitwise operations on bool. Hit some nasty bugs at my job.

[PATCH] D118706: [clang-format] Correctly parse C99 digraphs: "<:", ":>", "<%", "%>", "%:", "%:%:".

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. What the fuck. I know of trigraphs, and that we got rid of them, but these... Comment at: clang/lib/Format/Format.cpp:3246 + // Turning on digraphs in standards before C++0x is error-prone, because

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:16608 + // "auto b= f(a,\n" + //

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16608 + // "auto b= f(a,\n" + // " ccc ? a : b,\n" + // "

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3282853 , @psigillito wrote: > Do I need to care about these pre-build checks failing? F21921747: image.png > The checks passed, the build on linux failed. But as far

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3282775 , @psigillito wrote: > @HazardyKnusperkeks I do not have commit access. This is my first commit to > the project. Do I just need to issue an 'arc land' command? I've never used arc, so I can't

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Have you commit access, or do you need some one to commit it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. +1 for assert Comment at: clang/lib/Format/FormatToken.h:126 +/// Sorted operators that can follow a C variable. +static const std::vector

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:119-121 +if (!RootToken.Next) { + return true; +} Drop Braces Comment at:

[PATCH] D118363: clang-format: [JS] sort import aliases.

HazardyKnusperkeks added a comment. There should have been an entry in the `ReleaseNotes.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118363/new/ https://reviews.llvm.org/D118363 ___ cfe-commits

[PATCH] D118337: [clang-format] Fix AllowShortFunctionsOnASingleLine: InlineOnly with wrapping after record.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. +1 for the TokenAnnotatorTests, I think we need more of those instead of testing the formatted output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118337/new/

[PATCH] D118220: [clang-format] Correctly format lambdas with variadic template parameters.

HazardyKnusperkeks added a comment. You guys have an enormous speed currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118220/new/ https://reviews.llvm.org/D118220 ___ cfe-commits mailing list

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Just this small detail. :) Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:131 + + // A single line identifier that is not in the last line + if

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:125 +/// Operators that can follow a C variable. +static const std::set C_OperatorsFollowingVar = { +tok::l_square, tok::r_square, And maybe choose a different

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:134 + OperateIndex + 1 < Lines.size()) { +// UnwrappedLineParser's recognition of free-standing macro like +// Q_OBJECT may also recognize some uppercased

[PATCH] D117894: [clang-format] Space between attribute closing parenthesis and qualified type colon.

HazardyKnusperkeks added a comment. Is there any case where we want not a space after such paren (except it is also a paren)? if (Left.is(TT_AttributeParen)) return Right.isNot(TT_attributeParen); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:135 +// UnwrappedLineParser's recognition of free-standing macro like +// Q_OBJECT may also recognize some uppercased type names that may be +// used as

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:120 const auto MayPrecedeDefinition = [&](const int Direction = -1) { + assert(Direction >= -1 && Direction <= 1); const size_t OperateIndex = OpeningLineIndex +

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3250415 , @MyDeveloperDay wrote: > I'm not a fan of this approach of adding a "C" language, mainly because of > the `.h` problem so ultimately it doesn't solve your problem. > > I think this is overkill

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:76 // Do not handle EOF newlines. if (TargetToken->is(tok::eof) && NewlineToInsert > 0) return; Is that needed? Comment

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:215 +const auto = *I[1]; +const auto *PreviousLine = I != AnnotatedLines.begin() ? I[-1] : nullptr; +if

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

HazardyKnusperkeks added a comment. In D117421#3249196 , @glotchimo wrote: > In D117421#3247632 , @curdeius > wrote: > >> Could you check if your patch fixes >> https://github.com/llvm/llvm-project/issues/33044

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG966f24e5a62a: [clang-format] Add a BlockIndent option to AlignAfterOpenBracket (authored by csmulhern, committed by HazardyKnusperkeks). Changed

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 400449. HazardyKnusperkeks marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index:

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks marked 5 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:215 +const auto = *I[1]; +const auto *PreviousLine = I != AnnotatedLines.begin() ? I[-1] : nullptr; +if

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:288 +// Try to merge a control statement block with left brace unwrapped. +if (TheLine->Last->is(tok::l_brace) && TheLine->First->isOneOf(tok::kw_if, tok::kw_while,

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 400400. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Updated, now using a pointer (potential null) for PreviousLine. CHANGES SINCE LAST ACTION

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. Could you please rebase the patch? I promise I will commit it **very** shortly afterwards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D117421: [clang-format] Fix incorrect alignment of operator= overloads.

HazardyKnusperkeks added a comment. Thanks for fixing this. It hit my quite some times, but never had the time to look into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117421/new/ https://reviews.llvm.org/D117421

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added a comment. In D117416#3246838 , @curdeius wrote: > Thanks for having a try on this. > However, I don't like this approach too much. You add many changes and a > single test. That's not sufficient. > Also, handling C++ keywords

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. In D109557#3242274 , @fdwr wrote: >> I think no one just had thought about it. :) > > @HazardyKnusperkeks Happy new year. Just in case it gets forgotten, I'm > squeaking on behalf of a few stackoverflowers 

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3475 return false; +if (Left.is(TT_JsTypeOperator) && Right.isTypeOrIdentifier() || +(Left.isTypeOrIdentifier() || Left.is(TT_TemplateCloser)) && Be

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:297 + return true; +if (Style.isCpp() && RecordTok->is(tok::kw_union)) + return true; Is union used in another

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks resigned from this revision. HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3059 + /// and ``while``) in C++ according to the LLVM coding style. + /// \warning + /// This option will be renamed and expanded to

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3059 + /// and ``while``) in C++ according to the LLVM coding style. + /// \warning + /// This option will be renamed and expanded to support other styles! This should

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. If the pre merge checks pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4810-4811 + + verifyFormat("#define STRINGIFY(t) #t\n" + "#define MAKEVERSIONSTRING(x, y, z, build) STRINGIFY(x) \".\" STRINGIFY(y) \".\" STRINGIFY(z) \".\"

[PATCH] D116806: [clang-format] Ensure we can correctly parse lambda in the template argument list

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2872-2874 + if (FormatTok->is(tok::l_square)) +if (!tryToParseLambda()) + break; Fewer ifs and lines. Repository: rG LLVM Github Monorepo

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. In D115060#3227120 , @owenpan wrote: > Maybe option 4 for now So I can get it through. > and the refactoring

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks added a comment. In D115060#3224176 , @owenpan wrote: >> But I suspect it is the Assignment of the `PreviousLine` since this is not >> existent every time. > > Yep! > >> So I see the following solutions: >> >> 1. Only name `NextLine`,

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2827 -**JavaScriptWrapImports** (``Boolean``) :versionbadge:`clang-format 3.9` - Whether to wrap JavaScript import/export statements. + * If ``ColumnWidth`` is 0 (no limit on the

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 397531. HazardyKnusperkeks added a comment. Option 3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115060/new/ https://reviews.llvm.org/D115060 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index:

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks reopened this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D115060#3219116 , @curdeius wrote: > @HazardyKnusperkeks, it *seems* as if this commit (or one of others indicated > on

[PATCH] D116563: [clang-format][NFC] Put all state change into the for statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f6af1d46889: [clang-format][NFC] Put all state change into the for statement (authored by HazardyKnusperkeks). Repository: rG LLVM Github

[PATCH] D116562: [clang-format][NFC] Right.Previous is Left

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1da96f744951: [clang-format][NFC] Right.Previous is Left (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D116561: [clang-format][NFC] Use Prev instead of Current->Previous

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ab5d29f556b: [clang-format][NFC] Use Prev instead of Current-Previous (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo

[PATCH] D116560: [clang-format][NFC] TokenAnnotator: Use range based for

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29d8535e2b86: [clang-format][NFC] TokenAnnotator: Use range based for (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo

[PATCH] D116559: [clang-format][NFC] Early return in TokenAnnotator::next

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG918c977dc1c8: [clang-format][NFC] Early return in TokenAnnotator::next (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo

[PATCH] D116558: [clang-format][NFC] Don't pass member by argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1db43539027: [clang-format][NFC] Dont pass member by argument (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2257fe23672: [clang-format] Fix SeparateDefinitionBlocks docs and ... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35493b45603f: [clang-format][NFC] Replace deque with vector (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks added a comment. In D116557#3218328 , @ksyx wrote: > Thanks for the fix :) No Problem. Comment at: clang/docs/ReleaseNotes.rst:300 - Option ``SeparateDefinitionBlocks`` has been added to insert or remove empty

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks updated this revision to Diff 397148. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116557/new/ https://reviews.llvm.org/D116557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h Index: clang/include/clang/Format/Format.h

[PATCH] D116563: [clang-format][NFC] Put all state change into the for statement

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D116562: [clang-format][NFC] Right.Previous is Left

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use that

[PATCH] D116561: [clang-format][NFC] Use Prev instead of Current->Previous

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D116560: [clang-format][NFC] TokenAnnotator: Use range based for

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D116559: [clang-format][NFC] Early return in TokenAnnotator::next

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D116558: [clang-format][NFC] Don't pass member by argument

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. And then

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks added a comment. Without the enum documentation I got $ ./clang/docs/tools/dump_format_style.py Traceback (most recent call last): File "/c/GIT/llvm-dev/./clang/docs/tools/dump_format_style.py", line 344, in opts = OptionsReader(f).read_options() File

[PATCH] D116557: [clang-format] Fix SeparateDefinitionBlocks docs and ...

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: ksyx, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. the Style's

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG1188f241acb7: Revert [clang-format][NFC] Prefer pass by reference (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D115061?vs=391858=397137#toc Repository: rG LLVM

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

This revision was automatically updated to reflect the committed changes. Closed by commit rGd48d1f8ee845: [clang-format][NFC] Merge another two calls to isOneOf (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

This revision was automatically updated to reflect the committed changes. Closed by commit rGf014ab933f35: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D115060?vs=391853=397135#toc Repository:

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks updated this revision to Diff 397131. HazardyKnusperkeks set the repository for this revision to rG LLVM Github Monorepo. HazardyKnusperkeks added a comment. Now with SmallVector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for adding the parse checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer ) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; ksyx wrote: > HazardyKnusperkeks wrote: > >

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer ) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; ksyx wrote: > HazardyKnusperkeks wrote: > >

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:25 +FormatTokenLexer ) { + if (Style.SeparateDefinitionBlocks == FormatStyle::SDS_Leave) +return {{}, 0}; Better, but I still think we should have the

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Only some small changes, then it looks good to me. And I will definitely use it, once it is landed. Comment at:

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14545 verifyFormat("auto lambda = []() { return 0; };", SomeSpace2); + + FormatStyle SpaceAfterOperatorOverloading = getLLVMStyle(); rajatbajpai wrote: >

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2303 + assert(IfRightBrace->MatchingParen == IfLeftBrace); + IfLeftBrace->MatchingParen = nullptr; + IfRightBrace->MatchingParen = nullptr; owenpan

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3104-3105 + /// + ///class C {} + ///}; + /// \endcode Comment at:

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2303 + assert(IfRightBrace->MatchingParen == IfLeftBrace); + IfLeftBrace->MatchingParen = nullptr; + IfRightBrace->MatchingParen = nullptr; Why null

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

HazardyKnusperkeks added a comment. Looks good, use the `verifyFormat` and please mark comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___

[PATCH] D72326: [clang-format] Add option to explicitly specify a config file

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Although there is no context. Maybe still update the uploaded diff for the archive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + zwliew wrote: > zwliew wrote:

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2338 + KeepAncestorBraces(); + NestedTooDeep.push_back(false); if (FormatTok->is(tok::l_brace)) { owenpan wrote: > HazardyKnusperkeks wrote: > > I think it is

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.h:38-39 +}; +} // end namespace format +} // end namespace clang + HazardyKnusperkeks wrote: > I know you copied it. It is wrong where you copied it from. :) Not

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added a comment. Do you plan to refactor something for this review, or do you think you are done? Then I will look at it again as a whole. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3054 + enum SeparateDefinitionStyle { +/// Leave definition blocks separated as they are without changing anything +SDS_Leave, Add full stop at the end of

[PATCH] D116318: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser

HazardyKnusperkeks added a comment. I'm against that patch. > Don't pay for what you don't use. We should not put the size check into every call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116318/new/ https://reviews.llvm.org/D116318

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:1903 /// lead to incorrect code formatting due to incorrect decisions made due to - /// clang-formats lack of complete semantic information. + /// clang-format's lack of complete

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks added a comment. In D116316#3211269 , @curdeius wrote: > Could you have a look at preceding reviews and see if there wasn't a similar > patch before? > I think that this option is a bit too limited. > Only removing braces doesn't seem

[PATCH] D116314: [clang-format] Add style to separate definition blocks

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2027 +// namespaces by inserting a line break between them. +class DefinitionBlockSeparator : public TokenAnalyzer { +public: curdeius wrote: > Please consider moving it to a

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2900 + /// \version 14 + unsigned PenaltyBreakOpenParenthesis; + Please resort. Comment at: clang/lib/Format/Format.cpp:1238

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

HazardyKnusperkeks added a comment. Does it affect calling code? `a.operator++(5);` Should it? But please add tests for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + zwliew wrote: >

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3393 if (!ChildFormatTextToApply.empty()) { assert(ChildFormatTextToApply.size() == 1); zwliew wrote: > Is there a reason for this to be limited to 1? I came across this

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + zwliew wrote: > Is there a

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

HazardyKnusperkeks added a comment. Nice change, some small notes from me. Comment at: clang/docs/ClangFormatStyleOptions.rst:4003 +**TemplateArgumentKeyword** (``TemplateArgumentStyle``) :versionbadge:`clang-format 14` + Keyword to use for template arguments (``class`` or

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3383 +///true: false: +///void operator++ (int a); vs.void operator++(int +///a); Please put

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3045 +// parenthesis of a cast we know we are in a cast. +if (!Left.isOneOf(TT_PointerOrReference, tok::l_paren)) + for (const FormatToken *Tok = What are

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D116188#3208378 , @yodaldevoid wrote: > Correct commit email Since you only upload a diff, there is no name or email. ;)

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

HazardyKnusperkeks added a comment. And initialize the value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list

[PATCH] D116183: [clang-format] Fix wrong indentation after trailing requires clause.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. I really need to get my requires patch done... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116183/new/

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Good that you renamed the method. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115967/new/ https://reviews.llvm.org/D115967 ___ cfe-commits mailing list

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1641 case tok::equal: - // Fat arrows (=>) have tok::TokenKind tok::equal but TokenType - // TT_FatArrow. They always start an expression or a child block if - //

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3231 +return Style; + } else if (ParserErrorCode != ParseError::Success) { +return make_string_error("Error reading " + ConfigFile + ": " + else after return But I prefer

<    2   3   4   5   6   7   8   9   10   11   >