[PATCH] D30465: [mips] Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64

brad created this revision. Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64 Repository: rL LLVM https://reviews.llvm.org/D30465 Files: lib/Basic/Targets.cpp test/Preprocessor/init.c Index: test/Preprocessor/init.c

[PATCH] D30465: [mips] Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64

brad added a comment. Good to know about the reviewer. I am not familiar with phabricator and was just trying something with the addition of the subscriber. I will keep the amount of context in mind for future diffs. Thanks. Repository: rL LLVM https://reviews.llvm.org/D30465

[PATCH] D30465: [mips] Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64

brad added a comment. ping? Repository: rL LLVM https://reviews.llvm.org/D30465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48515: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.

This revision was automatically updated to reflect the committed changes. Closed by commit rC336004: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el. (authored by brad, committed by ). Changed prior to commit: https://reviews.llvm.org/D48515?vs=152580=153550#toc

[PATCH] D48515: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.

brad updated this revision to Diff 152580. brad added a comment. Sorry wrong revision of the diff. https://reviews.llvm.org/D48515 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/openbsd.c Index: test/Driver/openbsd.c ===

[PATCH] D48515: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.

brad created this revision. brad added reviewers: sdardis, atanasyan. Herald added a subscriber: srhines. Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el. Repository: rC Clang https://reviews.llvm.org/D48515 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/openbsd.c Index:

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

brad added a comment. How is it going with regard to N32 fixes / testing? Repository: rC Clang https://reviews.llvm.org/D52418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

brad added a comment. Simon? Repository: rC Clang https://reviews.llvm.org/D52418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

brad added a comment. Simon, and what about lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp? Repository: rC Clang https://reviews.llvm.org/D52418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

brad added a comment. IMHO it would be best to try and deal with as many known / exposed issues with the N32 support and then just enable IAS across the board. Then tackle any remaining issues as they come up. Repository: rC Clang https://reviews.llvm.org/D52418

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

brad added a comment. I've been told there is no desire to make gnu the default on OpenBSD. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 ___ cfe-commits mailing list

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

brad added a comment. George, look at adding some appropriate entries to test/Driver/frame-pointer-elim.c Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60335/new/ https://reviews.llvm.org/D60335 ___ cfe-commits

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

brad added a comment. Now that 10 is out, any chance of getting some movement on this to resolve this ABI issue with 32-bit PowerPC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73290/new/ https://reviews.llvm.org/D73290

[PATCH] D79588: [llvm][Support] Use std::atomic for llvm::call_once

brad added a comment. OpenBSD 6.7 is just wrapping up and will be released in a few days. We have switched to Clang for our PowerPC system compiler and thus libc++. It should be Ok to remove OpenBSD from that bit of code. The original issue as far as I remember is that because we don't have

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > efriedma wrote: > > Do we want to make sparc and

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

brad added a comment. Looks reasonable. I'm a little surprised I don't see this in the FreeBSD driver. What about FreeBSD, NetBSD and DragonFly? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86412/new/ https://reviews.llvm.org/D86412 ___

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

brad accepted this revision. brad added a comment. This revision is now accepted and ready to land. I was wondering why we had not seen any issues like this but your followup post clarified the situation. Thank you. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86412/new/

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b37174b9a5d: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport… (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

brad added a comment. @efriedma Eli? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90329/new/ https://reviews.llvm.org/D90329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG018984ae6833: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets (authored by kernigh, committed by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

brad added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +//

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

brad added a comment. In D98574#2641697 , @glaubitz wrote: > `-m32` is not supported on OpenBSD at all: > > openbsd# echo | gcc -E -dM -m32 - > :0: error: -m32 is not supported by this configuration > openbsd# Yes. OpenBSD has no 32-bit

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

brad added a comment. I do not immediately see why the other tests are failing, but at a bare minimum the following test from clang/test/Preprocessor/predefined-arch-macros.c will have to be updated.. // RUN: %clang -mcpu=v9 -E -dM %s -o - 2>&1 \ // RUN: -target sparc-unknown-linux \

[PATCH] D109244: [clang] Allow the OpenBSD driver to link the libclang_rt.profile library.

This revision was automatically updated to reflect the committed changes. Closed by commit rG466451c66162: [clang] Allow the OpenBSD driver to link the libclang_rt.profile library. (authored by fcambus, committed by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109349: [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb588f5d665aa: [clang][scan-build] Use cc/c++ instead of gcc/g++ on OpenBSD. (authored by fcambus, committed by brad).

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

brad added a comment. I'm not a Perl guy but I'm wondering about simplifying what it is doing there to just `uname -s` eq 'OpenBSD'? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797

[PATCH] D108901: [Sparc] Create an error when `__builtin_longjmp` is used

This revision was automatically updated to reflect the committed changes. Closed by commit rGeeb4266f8137: [Sparc] Create an error when `__builtin_longjmp` is used (authored by xtkoba, committed by brad). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D113361: [clang][Sparc] Disable SjLj lowering.

brad created this revision. brad added reviewers: dcederman, LemonBoy, jyknight. brad added a project: clang. Herald added subscribers: jrtc27, fedor.sergeev. brad requested review of this revision. Disable SjLj lowering. The builtin SjLj support has been removed.

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

brad added a comment. Oh, and you would have to use chomp to eliminate the newline character. Never mind. That's kind of ugly. Maybe it is better to go back to the original diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797

[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd241ce0f97e4: [Driver][NetBSD] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119656: [Driver][DragonFly] -r: imply -nostdlib like GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbd9d136ef81: [Driver][DragonFly] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119656/new/

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

brad added a comment. In D119989#3329413 , @kadircet wrote: > thanks Yes, I will do so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119989/new/ https://reviews.llvm.org/D119989

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGf374c8ddf2dd: [clangd] Fix building SerializationTests unit test on OpenBSD (authored by brad). Changed prior to commit: https://reviews.llvm.org/D119989?vs=409445=409689#toc Repository: rG LLVM

[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

brad created this revision. brad added a reviewer: MaskRay. brad requested review of this revision. Herald added a project: clang. Similar to D116843 for Gnu.cpp Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119655 Files:

[PATCH] D119656: [Driver][DragonFly] -r: imply -nostdlib like GCC

brad created this revision. brad added a reviewer: MaskRay. brad requested review of this revision. Herald added a project: clang. Similar to D116843 for Gnu.cpp Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119656 Files:

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

brad updated this revision to Diff 409445. brad added a comment. Remove a file I did not mean to include as part of the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119989/new/ https://reviews.llvm.org/D119989 Files:

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

brad created this revision. brad added reviewers: sammccall, kadircet. brad added a project: clang. Herald added subscribers: usaxena95, arphaman, krytarowski. brad requested review of this revision. Herald added subscribers: llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM,

[PATCH] D123097: [RISCV] Remove redundant enabling of IAS for Clang, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG4875ff1dc90b: [RISCV] Remove redundant enabling of IAS for Clang, NFC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123097/new/

[PATCH] D123097: [RISCV] Remove redundant enabling of IAS for Clang

brad created this revision. brad added a reviewer: kito-cheng. brad added a project: clang. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D119071: [Driver][OpenBSD] -r: imply -nostdlib like GCC

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. brad requested review of this revision. Similar to D116843 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119071 Files:

[PATCH] D119071: [Driver][OpenBSD] -r: imply -nostdlib like GCC

brad updated this revision to Diff 406236. brad added a comment. formating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119071/new/ https://reviews.llvm.org/D119071 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Driver/openbsd.c

[PATCH] D119071: [Driver][OpenBSD] -r: imply -nostdlib like GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rG1831cbd9d417: [Driver][OpenBSD] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119071/new/

[PATCH] D123431: [CSKY] Remove redundant enabling of IAS for Clang, NFC

brad created this revision. brad added a reviewer: zixuan-wu. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Generic_GCC::IsIntegratedAssemblerDefault() already takes care of CSKY. Repository: rG LLVM

[PATCH] D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault

brad created this revision. brad added reviewers: bcain, kparzysz, simoll. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Move enabling of IAS back to Generic_GCC::IsIntegratedAssemblerDefault(). Repository:

[PATCH] D123431: [CSKY] Remove redundant enabling of IAS for Clang, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee4c235386a3: [CSKY] Remove redundant enabling of IAS for Clang, NFC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault

brad updated this revision to Diff 422125. brad added a comment. Update after CSKy addition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123438/new/ https://reviews.llvm.org/D123438 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5206c2c167ed: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault… (authored by brad). Repository: rG LLVM Github

[PATCH] D123836: [Driver] Move Lanai IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. brad requested review of this revision. Move enabling of IAS back to Generic_GCC::IsIntegratedAssemblerDefault(). Repository: rG LLVM

[PATCH] D159414: Haiku: Fixes for header / library paths

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:24-25 + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/lib")); + getFilePaths().push_back(concat(getDriver().SysRoot, "/boot/system/develop/lib")); }

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. I was going to hold this over for a bit longer. 2 weeks and if no one says anything then go ahead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555626. brad marked an inline comment as not done. brad added a comment. Use --target= for all additions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files:

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555623. brad added a comment. Bump DWARF version to 4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/lib/Driver/ToolChains/Haiku.h

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

brad updated this revision to Diff 555604. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159390/new/ https://reviews.llvm.org/D159390 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/Driver/ToolChains/Haiku.h clang/test/Driver/pic.c

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555621. brad added a comment. Add a test for the debug handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/lib/Driver/ToolChains/Haiku.h

[PATCH] D159390: Haiku: Enable thread-local storag, disable PIE / enable PIC by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99be6b6d598f: Haiku: Enable thread-local storag, disable PIE / enable PIC by default (authored by Jerome Duval jerome.du...@gmail.com, committed by

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad added a comment. Comment at: clang/lib/Driver/ToolChains/Haiku.h:39 + + unsigned GetDefaultDwarfVersion() const override { return 2; } + nielx wrote: > I propose pushing this to version 4. Haiku's GCC also defaults to version 4 > now. I was using the

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad created this revision. brad added reviewers: nielx, korli. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Pick up a few more codegen parametres from downstream. DWARF version 2, Math Errno handling, ObjC

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

brad updated this revision to Diff 555622. brad added a comment. More context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159409/new/ https://reviews.llvm.org/D159409 Files: clang/lib/Driver/ToolChains/Haiku.h

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. In D159054#4638511 , @probinson wrote: > The main thing to worry about, clearly, is what happens as the change > percolates downstream and into distros. But you probably know more about that > than I do anyhow. :) Yes, that is

[PATCH] D159409: Haiku: Pick up a few more codegen parametres from downstream

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb70f1f836da9: Haiku: Pick up a few more codegen parametres from downstream (authored by X512 danger_m...@list.ru, committed by brad). Repository:

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.h:46 + bool HasNativeLLVMSupport() const override { return true; } + bool IsIntegratedAssemblerDefault() const override { return true; } + bool IsUnwindTablesDefault(const llvm::opt::ArgList ) const {

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555783. Herald added a subscriber: ormris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp clang/test/Driver/haiku.c

[PATCH] D159397: [analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a73e1eb47dd: [analyzer][NFC] Use switch statement in MallocChecker::performKernelMalloc (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555794. brad edited the summary of this revision. brad added a comment. Separate out the GCC path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files:

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555785. brad added a comment. Add some C++ header path tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp

[PATCH] D159414: Haiku: Fixes for header / library paths

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:85-86 + "/boot/system/develop/headers/os/net")); + addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, + "/boot/system/develop/headers/os/opengl")); +

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

brad added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:336 - case llvm::Triple::Minix: -AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", -"", "", "", triple); uabelho wrote: > @brad : > I think

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

brad updated this revision to Diff 64. brad added a comment. x86_64 test for TLS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159390/new/ https://reviews.llvm.org/D159390 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

brad created this revision. brad added reviewers: joerg, kallisti5, nielx. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Derived from https://reviews.llvm.org/D49481, but added tests and simplified the diff a

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

brad added inline comments. Comment at: clang/test/Driver/haiku.cpp:2 +// Check the C++ header path (libstdc++) +// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \ +// RUN: --sysroot=%S/Inputs/haiku_x86_64_tree \ abrachet wrote: > This test is

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. brad marked 2 inline comments as not done. Closed by commit rGa3ba9d697b17: [Driver]

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3476332e453: [Driver] move DragonFly header search path management to the driver (authored by brad). Changed prior to commit:

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:331 - case llvm::Triple::DragonFly: -AddPath("/usr/include/c++/5.0", CXXSystem, false); -break; MaskRay wrote: > 5.0 becomes 8.0 after move? > 5.0 becomes 8.0 after move? Read

[PATCH] D158132: [Driver] move ELFIAMCU / RTEMS header search path management to the driver

brad updated this revision to Diff 554553. brad added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158132/new/ https://reviews.llvm.org/D158132 Files: clang/lib/Lex/InitHeaderSearch.cpp Index:

[PATCH] D158920: Delete CloudABI support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5165593a97a0: Delete CloudABI support (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158132: [Driver] move ELFIAMCU / RTEMS header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd267990e8c53: [Driver] move ELFIAMCU / RTEMS header search path management to the driver (authored by brad). Repository: rG LLVM Github Monorepo

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. Just FYI I am not in a rush to commit this. I am posting this more so as a means of prodding for discussion of the feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054

[PATCH] D159414: Haiku: Fixes for header / library paths

brad updated this revision to Diff 555689. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159414/new/ https://reviews.llvm.org/D159414 Files: clang/lib/Driver/ToolChains/Haiku.cpp Index: clang/lib/Driver/ToolChains/Haiku.cpp

[PATCH] D159414: Haiku: Fixes for header / library paths

brad created this revision. brad added reviewers: nielx, korli, kallisti5. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Some fixes for the header / library paths.. - Use concat macro for all paths - Correct

[PATCH] D159397: [StaticAnalyzer] Use switch statement in MallocChecker::performKernelMalloc. NFC

brad created this revision. brad added reviewers: vabridgers, NoQ. brad added a project: clang. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware. Herald added a project: All. brad requested review of this

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad updated this revision to Diff 554567. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:202 + addSystemInclude(DriverArgs, CC1Args, + concat(D.SysRoot, "/usr/local/include")); + addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, "/usr/include"));

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. But the rest LGTM as a start. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:147 + } + + if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs, Add in here.. ``` // Silence warnings when linking C code with a C++ '-stdlib' argument.

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. In D154396#4655494 , @ADKaster wrote: > @MaskRay @phosek Daniel and I have updated the patch set, Would you rather I > update the phab patch series, or re-upload the set as GitHub PRs? Update the phab patch series. Repository:

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.h:81 + + unsigned GetDefaultDwarfVersion() const override { return 5; } + This just overrides the default DWARF version anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. You also have to add Serenity to clang/lib/Lex/InitHeaderSearch.cpp InitHeaderSearch::ShouldAddDefaultIncludePaths(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396

[PATCH] D154396: [clang] Add support for SerenityOS

brad added a comment. Make use of the concat macro with the various header and library paths. https://github.com/llvm/llvm-project/commit/1d0cc510516d50c459f78896a0375fadb13a2b45 Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:78 + + if (Output.isFilename()) { +

[PATCH] D154396: [clang] Add support for SerenityOS

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:110 +assert(!Inputs.empty() && "Must have at least one input."); +addLTOOptions(TC, Args, CmdArgs, Output, Inputs[0], + D.getLTOMode() == LTOK_Thin);

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.h:46 + bool HasNativeLLVMSupport() const override { return true; } + bool IsIntegratedAssemblerDefault() const override { return true; } + UnwindTableLevel Remove the

[PATCH] D157896: Clang: Define macro _MIPS_SPFPSET

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f02e3bd6a5: Clang: Define macro _MIPS_SPFPSET (authored by brad). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78441: Delete NaCl support

brad added a comment. In D78441#4593287 , @dschuff wrote: > Deprecation is progressing > (https://groups.google.com/a/chromium.org/g/chromium-extensions/c/v8H1UHnPotY/m/NmzrIv_VBAAJ) > but we are still supporting it on some platforms, (and using clang's

[PATCH] D158378: [Driver] move Minix header search path management to the driver

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added a project: All. brad requested review of this revision. As has been done for other OS's. Move the header path management to the driver. Repository: rG LLVM Github Monorepo

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad updated this revision to Diff 551872. brad added a comment. Also use concat() in addLibStdCxxIncludePaths(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files:

[PATCH] D158378: [Driver] move Minix header search path management to the driver

brad added a comment. In D158378#4602289 , @MaskRay wrote: > Thank you for driving the migration! > > case llvm::Triple::Minix: > AddGnuCPlusPlusIncludePaths("/usr/gnu/include/c++/4.4.3", > "", "", "", triple); > >

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

brad created this revision. brad added a reviewer: devnexen. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. As has been done for other OS's. Move the header path management to the driver. Also I noticed with

[PATCH] D158183: Clang/Gnu: Scan GCC with triple without vendor if vendor is unknown

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ee3b2a6: Clang/Gnu: Scan GCC with triple without vendor if vendor is unknown (authored by wzssyqa, committed by brad). Herald added a project:

[PATCH] D158706: [Driver] Remove Myriad.cpp

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2958 default: return getTriple().getVendor() != llvm::Triple::Myriad; } You might as well remove this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158715: [Driver] Cleanup last vestiges of Minix / Contiki support

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Cleanup what is left after https://reviews.llvm.org/D158461 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158715

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

brad updated this revision to Diff 549757. brad added a comment. Removed: /boot/system/develop/headers/os/arch Added: /boot/system/develop/headers/gnu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157767/new/ https://reviews.llvm.org/D157767

  1   2   3   >