[PATCH] D39462: [Sema] Implement -Wmaybe-tautological-constant-compare for when the tautologicalness is data model dependent

bcain added a comment. I'd like to understand/resurrect this change, so I'll try to summarize. Please correct this as appropriate: 1. We got here because libc++ has code that triggers a warning for some targets (those whose `int` and `long` have the same size). 2. This change would "move" the

[PATCH] D31739: Add markup for libc++ dylib availability

bcain added a comment. I think some of the `XFAIL: availability` may be wrong here. I'd submit a patch, but it's not clear to me what the appropriate fix is. Comment at: libcxx/trunk/utils/libcxx/test/config.py:400 +if self.use_system_cxx_lib or

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

bcain added a comment. In https://reviews.llvm.org/D41316#957598, @jroelofs wrote: > I'd much rather provide no implementation than one that lies. Broken builds > are much safer than problems at runtime. Agreed! Especially the problems caused by a predictable random seed. Repository:

[PATCH] D39149: [libc++] Prevent tautological comparisons

bcain added a comment. In https://reviews.llvm.org/D39149#912260, @smeenai wrote: > I confirmed that these warnings go away with https://reviews.llvm.org/D39462 > applied, and they reappear if I manually specify > `-Wmaybe-tautological-constant-compare`. Thank you! Let's resurrect these

[PATCH] D41368: [libc++] Ignore bogus tautologic comparison warnings

bcain added a comment. In https://reviews.llvm.org/D41368#959579, @smeenai wrote: > @mclow.lists are you okay with this approach? I'm also fine using a cast to > silence the warning, as @zturner suggested, but we should suppress the > warning in some way, otherwise libc++ 6 is gonna have

[PATCH] D39462: [Sema] Implement -Wmaybe-tautological-constant-compare for when the tautologicalness is data model dependent

bcain added a comment. In https://reviews.llvm.org/D39462#959822, @phosek wrote: > FWIW we've already rolled Clang that contains > `-Wtautological-constant-compare` to our codebase and we had to set > `-Wno-tautological-constant-compare` globally because we were getting bogus > warnings in

[PATCH] D39149: [libc++] Prevent tautological comparisons

bcain added a comment. In https://reviews.llvm.org/D39149#910845, @lebedev.ri wrote: > That is my diagnostic, so i guess this is the time to reply :) ... > 3. In `-Wtautological-constant-compare`, ignore any comparisons that compare > with `std::numeric_limits`. Not a fan of this solution.

[PATCH] D39149: [libc++] Prevent tautological comparisons

bcain added a comment. In https://reviews.llvm.org/D39149#910931, @lebedev.ri wrote: > In https://reviews.llvm.org/D39149#910891, @bcain wrote: > > > In https://reviews.llvm.org/D39149#910845, @lebedev.ri wrote: > > > > > That is my diagnostic, so i guess this is the time to reply :) > > > > > >

[PATCH] D41727: [libcxx] Disable tautological-type-limit-compare warning

bcain updated this revision to Diff 130431. bcain added a comment. Herald added a subscriber: cfe-commits. Changed per review Repository: rCXX libc++ https://reviews.llvm.org/D41727 Files: libcxx/utils/libcxx/test/config.py Index: libcxx/utils/libcxx/test/config.py

[PATCH] D50816: [hexagon] restore -fuse-cxa-atexit by default

This revision was automatically updated to reflect the committed changes. Closed by commit rC339979: [hexagon] restore -fuse-cxa-atexit by default (authored by bcain, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D41727: [libcxx] Disable tautological-type-limit-compare warning

bcain abandoned this revision. bcain added a comment. Herald added subscribers: ldionne, christof. I think this is now obsolete due to clang changing the warning. Repository: rCXX libc++ https://reviews.llvm.org/D41727 ___ cfe-commits mailing

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. In D58091#1397586 , @jyknight wrote: > I think this warning (-Wbuiltin-requires-header) doesn't really make sense as > its own warning. > > We already have two related (on-by-default) warnings. ... In D58091#1414250

[PATCH] D58091: Customize warnings for missing built-in type

bcain added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:592 +: Warning<"declaration of built-in function '%0' requires the declaration" +" of the 'jmp_buf' type, commonly proived in the header .">, + InGroup>;

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. In D58091#1409584 , @jdoerfert wrote: > I did address the comments but I will wait until I hear back on the "warning > vs warning + note question". ... > I do not have strong feelings about this, either way is fine with me. >

[PATCH] D58091: Customize warnings for missing built-in type

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. I can confirm that this fix is effective at addressing the problem we experienced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. I reported PR40692. I just tried this patch on our local build where we saw the failure on an RTOS implementing pthreads. Unfortunately with this patch I encountered an (unrelated) assertion. So this fix was inconclusive for me (for now). I will follow up but if this

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. > Are you sure it is unrelated? Very nearly positive, I applied the patch to our downstream trunk and the assertion is encountered in a target-specific pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/

[PATCH] D61309: [clang] Add no-warn support for Wa

bcain created this revision. bcain added reviewers: pcc, kparzysz, sidneym. bcain added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61309 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/CC1Options.td

[PATCH] D61130: [llvm-mc] Add reportWarning() to MCContext

bcain updated this revision to Diff 197317. bcain changed the repository for this revision from rL LLVM to rG LLVM Github Monorepo. bcain added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add context, add clang update. Repository: rG LLVM Github Monorepo

[PATCH] D61130: [llvm-mc] Add reportWarning() to MCContext

bcain added a comment. More context for this change: - "`--no-warn`" is present already, target-independent, and it's supported by llvm-mc (and other MC tools) because it's already present in `include/llvm/MC/MCTargetOptionsCommandFlags.inc`. - Only the AsmParser has access to the

[PATCH] D61130: [llvm-mc] Add reportWarning() to MCContext

bcain added a comment. ping! any comments or concerns about this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61130/new/ https://reviews.llvm.org/D61130 ___ cfe-commits mailing list

[PATCH] D58091: Customize warnings for missing built-in type

bcain accepted this revision. bcain added a comment. Herald added a subscriber: dmgreen. @jdoerfert @jyknight @lebedev.ri@rsmith @aaron.ballman This will appear as a 9.0 regression, right? Let's please consider a way to address it for 9.0 before it's released. Repository: rG LLVM

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

bcain added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:212 bool UseG0 = false; + bool UseLLD = Args.getLastArgValue(options::OPT_fuse_ld_EQ).startswith("lld"); bool UseShared = IsShared && !IsStatic; Does this still work when

[PATCH] D68401: [Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly.

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68401/new/ https://reviews.llvm.org/D68401 ___ cfe-commits

[PATCH] D68884: Add support to -Wa,-W in clang

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68884/new/ https://reviews.llvm.org/D68884 ___

[PATCH] D75139: [hexagon] Pickup the default crt and libs when the musl target is selected

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. Herald added a subscriber: ormris. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75139/new/ https://reviews.llvm.org/D75139

[PATCH] D74260: Change default relocation model for hexagon when triple includes musl

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:923 + return ((getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) || + getTriple().isMusl() || getSanitizerArgs().requiresPIE()) && + getTriple().getArch() !=

[PATCH] D74776: [Hexagon] clang driver should consider --sysroot option when looking for includes

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. Herald added a subscriber: ormris. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74776/new/ https://reviews.llvm.org/D74776

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

bcain added a comment. In general, I recommend qualifying metric and threshold values with their associated units: bits, bytes, pages, etc. That way it's easy to see where the unit conversions are happening and easy to see whether the logic is correct without reasoning about how the value

[PATCH] D76079: [Hexagon] Enable init_arrays when target is linux-musl

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:548 + + bool UseInitArrayDefault = (getTriple().isMusl()) ? true : false; The ternary is unnecessary. ``` bool UseInitArrayDefault = getTriple().isMusl(); ``` Repository:

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

bcain added a comment. @kparzysz do you have any thoughts about those review comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75638/new/ https://reviews.llvm.org/D75638 ___ cfe-commits mailing

[PATCH] D77684: [Hexagon] Remove testcases that check for default linker.

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77684/new/ https://reviews.llvm.org/D77684 ___

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

bcain added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77440/new/ https://reviews.llvm.org/D77440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

bcain added a comment. In D77498#1967870 , @nathanchance wrote: > This does not take into account `CLANG_DEFAULT_LINKER`, resulting in a > `check-clang` failure: Weird -- the baseline didn't take CLANG_DEFAULT_LINKER into account either, though,

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

bcain added a comment. In D77498#1968123 , @sidneym wrote: > Since this isn't something that can be always known in advance I think the > testcase should just be removed. Why not just check if `CLANG_DEFAULT_LINKER` is empty? const char

[PATCH] D75638: [Hexagon] Support for Linux/Musl ABI.

bcain added a comment. In D75638#1917565 , @bcain wrote: > @kparzysz do you have any thoughts about those review comments? @sidneym is this just pulling existing contents downstream to go upstream? If so let's expedite this please Repository: rG

[PATCH] D76546: [Hexagon] MaxAtomicPromoteWidth, MaxAtomicInlineWidth are not getting set.

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76546/new/ https://reviews.llvm.org/D76546 ___

[PATCH] D76310: [Hexagon] Add linux #defines when linux triple is selected

bcain added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76310/new/ https://reviews.llvm.org/D76310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76582: [Hexagon] Don't clear libpath when target is linux-musl

bcain added a comment. Seems like we might want a new test case for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76582/new/ https://reviews.llvm.org/D76582 ___ cfe-commits mailing list

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

bcain updated this revision to Diff 355234. bcain added a comment. Removed some unavailable instructions. Added include order fix in hexagon_circ_brev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104952/new/ https://reviews.llvm.org/D104952

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

bcain added a comment. It occurs to me now that some of these are not very useful in the absence of `hexagon_types.h`. So I will add that one too and change the tests to use those definitions instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

bcain created this revision. bcain added a reviewer: kparzysz. Herald added a subscriber: mgorny. bcain requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add definitions for Hexagon, Hexagon circular/bit-reverse and HVX intrinsics.

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

bcain updated this revision to Diff 354758. bcain added a comment. Add hexagon_types.h and additional test cases. Updated existing test case to use types defined in hexagon_types.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104952/new/

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

bcain added a comment. Should I clang format the headers? I prefer keeping the historical formatting intact. But if the submission should conform then I suppose I'll just accept the wrapped text suggested by clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98436: [Hexagon] Support inlined use of cs0 and cs1

bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. LGTM. @kparzysz ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98436/new/ https://reviews.llvm.org/D98436

[PATCH] D108083: add sanitizer support to hexagon

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:297-298 +linkSanitizerRuntimeDeps(HTC, CmdArgs); +// FIXME: sanitizer_common or only some require unwind? +CmdArgs.push_back("-lunwind"); + } I will try

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp:25 return pc + 8; -#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) +#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) \ + ||

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

bcain added a comment. In D108083#2949815 , @vitalybuka wrote: >> We can help create a bot for hexagon-unknown-linux-musl. What's the process? > > Thank you. https://llvm.org/docs/HowToAddABuilder.html Oh I think I misunderstood: > Volunteers can

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 366995. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:88 +{ + register long r6 __asm__("r6") = n; + register long r0 __asm__("r0") = a; vitalybuka wrote: > should this use u64 like other

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367020. bcain added a comment. Herald added a subscriber: krytarowski. applied `clang-format-diff`, s/long/u32/ for syscall funcs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367008. bcain added a comment. added context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain updated this revision to Diff 367027. bcain added a comment. fixed iserror() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 Files: compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124 + +bool internal_iserror(uptr retval, int *rverrno) { + if (retval == (uptr)-1) { vitalybuka wrote: > sidneym wrote: > > bcain wrote: > > >

[PATCH] D108083: add sanitizer support to hexagon

bcain added a comment. In D108083#2947907 , @vitalybuka wrote: > Can you cut this into separate peaces, at least patch per sanitizer for "asan > lsan ubsan scudo scudo_standalone cfi safestack"? Sure, that's no problem. While I'm breaking it up, us

[PATCH] D108083: add sanitizer support to hexagon

bcain added a comment. In D108083#2947914 , @vitalybuka wrote: > Do we have public bot for hexagon? I think we have one intended to for checking hexagon-unknown-elf and perhaps not one for hexagon-unknown-linux-musl. I believe that only the Linux

[PATCH] D108083: [DRAFT] add sanitizer support to hexagon

bcain created this revision. bcain added a reviewer: sidneym. Herald added subscribers: s.egerton, cryptoad, simoncook, fedor.sergeev, mgorny. bcain requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch will need

[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common (1/8)

bcain updated this revision to Diff 366766. bcain retitled this revision from "add sanitizer support to hexagon" to "[sanitizer] Add hexagon support to sanitizer-common (1/8)". bcain edited the summary of this revision. bcain added a comment. Decomposed to just the sanitizer-common portion. Now

[PATCH] D108178: [PATCH 8/8] [clang] enable sanitizers for hexagon

bcain created this revision. bcain added reviewers: sidneym, kparzysz. bcain added a project: clang. Herald added subscribers: s.egerton, simoncook. bcain requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108178 Files:

[PATCH] D106737: [clang] [hexagon] Add resource include dir

bcain updated this revision to Diff 365352. bcain added a comment. Test case updates per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106737/new/ https://reviews.llvm.org/D106737 Files: clang/lib/Driver/ToolChains/Hexagon.cpp

[PATCH] D106737: [clang] [hexagon] Add resource include dir

bcain updated this revision to Diff 365459. bcain added a comment. Suggestions from Fangrui: override the resource-dir with an explicit arg, disable for windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106737/new/

[PATCH] D106737: [clang] [hexagon] Add resource include dir

bcain updated this revision to Diff 364665. bcain retitled this revision from "DRAFT - [clang] [hexagon] Add resource include dir" to "[clang] [hexagon] Add resource include dir". bcain added a comment. Herald added a subscriber: ormris. Add a test case, address failing test. Repository: rG

[PATCH] D113638: [xray] Add support for hexagon architecture

androm3da added a comment. Ping - any thoughts/concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113638/new/ https://reviews.llvm.org/D113638 ___ cfe-commits mailing list

[PATCH] D113638: [xray] Add support for hexagon architecture

androm3da created this revision. androm3da added reviewers: dberris, kparzysz. Herald added subscribers: hiraditya, mgorny. androm3da requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Adds x-ray

[PATCH] D113638: [xray] Add support for hexagon architecture

androm3da added a comment. This patch spans several areas, so I would be happy to decompose it into smaller parts if it made it easier for reviewers. Comment at: compiler-rt/lib/xray/xray_hexagon.cpp:76-84 +static void WriteInstFlushCache(void *Addr, uint32_t NewInstruction)

[PATCH] D113638: [xray] Add support for hexagon architecture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG543a9ad7c460: [xray] add support for hexagon (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

bcain added a comment. This patch is so far just for discussion, still needs tests, etc. The motivation for this patch is to be able to include the intrinsic header files installed in the resource dir. I've taken inspiration from `ToolChains/Linux.cpp` here. Repository: rG LLVM Github

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

bcain created this revision. bcain added reviewers: sidneym, MaskRay. bcain requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106737 Files: clang/lib/Driver/ToolChains/Hexagon.cpp Index:

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:604 + const bool HasSysRoot = !D.SysRoot.empty(); + if (HasSysRoot) { SmallString<128> P(D.SysRoot); MaskRay wrote: > To match Linux.cpp, this code block should be

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

bcain added a comment. Herald added a project: All. In D97625#3337018 , @dmgreen wrote: > Hello. I noticed this was applied to the base /test directory in the llvm > repo: https://github.com/llvm/llvm-project/tree/main/test > Was it intended be in

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

bcain added inline comments. Comment at: clang/CMakeLists.txt:179-183 +if(DEFAULT_SYSROOT) + message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use " +"configuration files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)" +"to specify

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

bcain added inline comments. Comment at: clang/CMakeLists.txt:179-183 +if(DEFAULT_SYSROOT) + message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use " +"configuration files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)" +"to specify

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

bcain added inline comments. Comment at: clang/CMakeLists.txt:179-183 +if(DEFAULT_SYSROOT) + message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use " +"configuration files (https://clang.llvm.org/docs/UsersManual.html#configuration-files)" +"to specify

[PATCH] D142947: [hexagon] add a -mcabac flag

bcain created this revision. bcain added a reviewer: kparzysz. bcain added a project: clang. Herald added a project: All. bcain requested review of this revision. Herald added a subscriber: cfe-commits. For v73 and later, clang users who wish to use the cabac instructions need a way to add the

[PATCH] D142947: [hexagon] add a -mcabac flag

bcain added a subscriber: ldionne. bcain added a comment. It seems extremely unlikely that this change to target-dependent flags caused this libc++ test failure w/an error referring to partial specialization. @ldionne is it possible that

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

bcain added a comment. Can you depend on `cstdio` in an LLVM toolchain test case like this? `clang` doesn't install `cstdio` -- does it? This is a c or c++ library file, so I think it should be out of scope for a clang test, right? AFAICT no other clang test uses this header file.

[PATCH] D142947: [hexagon] add a -mcabac flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd97675e0236: [hexagon] add a -mcabac flag (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

bcain created this revision. bcain added reviewers: kparzysz, sidneym, MaskRay. Herald added a project: All. bcain requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The removal of the early return in 96832a6bf7e0e7f1e8d634d38c44a1b32d512923

[PATCH] D156330: [hexagon] restore library path arguments

bcain created this revision. bcain added reviewers: sidneym, kparzysz, MaskRay. Herald added a project: All. bcain requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before applying this fix, clang would not include the specified library path

[PATCH] D156330: [hexagon] restore library path arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96832a6bf7e0: [hexagon] restore library path arguments (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

bcain added a comment. ping? any concerns about this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/ https://reviews.llvm.org/D156771 ___ cfe-commits mailing list

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5bc4b34a3aa9: [clang][hexagon] Handle library path arguments earlier (authored by androm3da). Repository: rG LLVM

[PATCH] D156771: [clang][hexagon] Handle library path arguments earlier

bcain updated this revision to Diff 546314. bcain added a comment. Changed test to use `-Werror -###` instead of `-fdriver-only -v -Werror`. Fixed indentation / `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156771/new/

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544527. bcain added a comment. Fixed target: `--target=hexagon-unknown-linux` was not correct for testing this bug, it should have been `--target=hexagon-unknown-linux-musl`. Used `-fdriver-only -Werror` as suggested but it did require separating the tests.

[PATCH] D156330: [hexagon] restore library path arguments

bcain added a comment. In D156330#4535974 , @MaskRay wrote: > Tip: use `%clang -fdriver-only -Werror -v` to test that a command produces no > warning or error and has an exit code of 0. Without it your > `Args.ClaimAllArgs(options::OPT_L);` change is

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544533. bcain added a comment. Too hasty w/the last update - forgot to remove the `-###`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156330/new/ https://reviews.llvm.org/D156330 Files:

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544532. bcain added a comment. I misunderstood the previous suggestion about `-fdriver-only -Werror -v` and thought I needed to separate the test into two invocations. Combined these back into a single RUN now. Repository: rG LLVM Github Monorepo