Re: r252834 - Provide a frontend based error for always_inline functions that require

Hi Eric, This is very nice! After the addition of this feature, LNT started crashing on x86_64h: FAIL: SingleSource/UnitTests/Vector/SSE/sse_expandfft.compile_time (3 of 2244) FAIL: SingleSource/UnitTests/Vector/SSE/sse_isamax.compile_time (4 of 2244) FAIL:

Re: r253481 - Re-committing r253473 after hopefully fixing the bot breakage. There was a copy-pasta issue that my local testing did not catch.

Hi Aaron, There's one test failing now: https://smooshbase.apple.com/ci/job/apple-clang-stage1-configure-R_master_check/7042/ FAIL: Clang-Unit :: ASTMatchers/Release+Asserts/ASTMatchersTests/Matcher.VarDecl_StorageDuration (8227 of 24324) TEST 'Clang-Unit ::

Re: [clang-tools-extra] r253401 - [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

Hi Matthias, This is failing on the green dragon bot: http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/13184/ http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/13184/consoleFull#54616856949ba4694-19c4-4d7e-bec5-911270d8a58c Thanks, On Tue, Nov 17, 2015 at 3:43

Re: r253481 - Re-committing r253473 after hopefully fixing the bot breakage. There was a copy-pasta issue that my local testing did not catch.

Ops, missed you follow up r253486 again. Thanks, On Wed, Nov 18, 2015 at 11:07 AM, Bruno Cardoso Lopes wrote: > Hi Aaron, > > There's one test failing now: > https://smooshbase.apple.com/ci/job/apple-clang-stage1-configure-R_master_check/7042/ > > FAIL: Clang-Unit :: >

r248935 - Revert "[DarwinDriver] Use -lto_library to specify the path for libLTO.dylib"

Author: bruno Date: Wed Sep 30 15:11:02 2015 New Revision: 248935 URL: http://llvm.org/viewvc/llvm-project?rev=248935=rev Log: Revert "[DarwinDriver] Use -lto_library to specify the path for libLTO.dylib" Revert r248932. Bots complaining about new warnings where they shouldn't. Modified:

r248932 - [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

Author: bruno Date: Wed Sep 30 14:55:07 2015 New Revision: 248932 URL: http://llvm.org/viewvc/llvm-project?rev=248932=rev Log: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib Usually, when using LTO with a clang installation newer than the system's one, there's a

r249143 - [DarwinDriver] Reapply: Use -lto_library to specify the path for libLTO.dylib

Author: bruno Date: Fri Oct 2 10:10:33 2015 New Revision: 249143 URL: http://llvm.org/viewvc/llvm-project?rev=249143=rev Log: [DarwinDriver] Reapply: Use -lto_library to specify the path for libLTO.dylib Reapply r248935. Usually, when using LTO with a clang installation newer than the system's

Re: [PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

bruno updated this revision to Diff 35664. bruno added a comment. Added test per Duncan's comment. Repository: rL LLVM http://reviews.llvm.org/D13117 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/Tools.cpp test/Driver/darwin-ld.c Index: test/Driver/darwin-ld.c

[PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

bruno created this revision. bruno added a reviewer: dexonsmith. bruno added subscribers: cfe-commits, kledzik, bob.wilson. bruno set the repository for this revision to rL LLVM. Usually, when using LTO with a clang installation newer than the system one, there's a libLTO.dylib version mismatch

[PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno created this revision. bruno added reviewers: doug.gregor, akyrtzi. bruno added subscribers: cfe-commits, dexonsmith. Consider the following ObjC++ snippet: @protocol PA; @protocol PB; @class NSArray; typedef int some_t; id FA(NSArray *h, some_t group); This would hit an

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Hi Argyrios, Thanks for the suggestions, will apply them. The assertion seems important to catch subtle bugs, are you sure it should be placed inside a "#ifndef NDEBUG”? http://reviews.llvm.org/D15173 ___ cfe-commits

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Ping! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Ping! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno updated this revision to Diff 44180. bruno added a comment. Hi Richard, Thanks for the comments. Updated the patch! In http://reviews.llvm.org/D15173#313235, @rsmith wrote: > I think that this will leave us with a broken token stream. In your example, > the cached token stream starts as

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno updated this revision to Diff 44306. bruno added a comment. Hi Richard, Thanks for the detailed explanation, it now makes sense to me. I updated the patch with another approach! Let me know if it's the right direction. http://reviews.llvm.org/D15173 Files:

[PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added subscribers: cfe-commits, dexonsmith. This is currently used by clang to lock access to modules; improve the error message so that clang can use better output messages from locking error issues.

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno added a subscriber: llvm-commits. bruno added a comment. Adding the right list for this +llvm-commits http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added a comment. Before this goes in again, I want to double check that this doesn't affect compile time on darwin + frameworks. Will get back to you asap. Comment at: lib/Lex/PPDirectives.cpp:218 @@ +217,3 @@ + SmallString<32> LowerInclude{Include}; + for (char& Ch :

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added inline comments. Comment at: lib/Lex/PPDirectives.cpp:179 @@ +178,3 @@ +"exception", "iterator", "random", "strstream", "vector", +"forward_list", "limits", "ratio", "system_error", + Applying your patch reveled a bunch of ^M (carriage-return)

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I think this should be reverted until we figure out how to solve it. Moreover, it looks expensive to check for each file if it's within a system path. I would really like to measure compile time for this change before it goes definitely in. On Fri, Jun 3, 2016 at 4:53 PM, Justin Bogner via

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

> The information about whether the file is in a system path is already being > computed, so it would incur no extra overhead. I'm not sure that's the right > fix. You are more than welcome to revert the (clang) commit while we think > of the right fix. I'm not sure what the right fix is either,

r271758 - [Modules] Improve diagnostics for LockFileManager errors

Author: bruno Date: Fri Jun 3 20:13:22 2016 New Revision: 271758 URL: http://llvm.org/viewvc/llvm-project?rev=271758=rev Log: [Modules] Improve diagnostics for LockFileManager errors Uses error message now provided by LockFileManager in LLVM r271755. rdar://problem/26529101 Modified:

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno closed this revision. bruno added a comment. Applied your suggestions and committed in r271755! Thanks http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno added a comment. Hi, Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + Taking a look at this again I don't think

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

bruno added a comment. You can probably find a way to test this by taking a look at unittests/Basic/VirtualFileSystemTest.cpp Repository: rL LLVM http://reviews.llvm.org/D20338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added a comment. FTR, I finally test it out for compile time and could not notice any difference besides noise. Thanks Eric! http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20675: Compilation for Intel MCU (Part 3/3)

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno added inline comments. Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + aturetsk wrote: > bruno wrote: > > Taking a look

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno added a comment. Ping! http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

bruno added a comment. Ping! http://reviews.llvm.org/D20451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271042 - [Driver] Fix driver support for color diagnostics

Author: bruno Date: Fri May 27 15:43:00 2016 New Revision: 271042 URL: http://llvm.org/viewvc/llvm-project?rev=271042=rev Log: [Driver] Fix driver support for color diagnostics Diagnostics that happen during driver time do not have color output support unless -fcolor-diagonostic is explicitly

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

bruno added inline comments. Comment at: test/PCH/include-timestamp.cpp:5 @@ +4,3 @@ +// Check timestamp is included by default. +// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %S/Inputs/include-timestamp-pch.h +// RUN: touch %S/Inputs/include-timestamp.h Can

Re: [PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

bruno closed this revision. bruno added a comment. Thanks Doug! Committed r271314 http://reviews.llvm.org/D20451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18585: [CrashReproducer] Add a module map callback for added headers

bruno closed this revision. bruno added a comment. Committed in r264971 http://reviews.llvm.org/D18585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20266: [Modules] Use vfs for (recursive) directory iteration

bruno closed this revision. bruno added a comment. Committed in r269661 http://reviews.llvm.org/D20266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271314 - [Parser] Fix look ahead after EOF while parsing objc message and lambdas

Author: bruno Date: Tue May 31 13:46:31 2016 New Revision: 271314 URL: http://llvm.org/viewvc/llvm-project?rev=271314=rev Log: [Parser] Fix look ahead after EOF while parsing objc message and lambdas If a closing ')' isn't found for a macro instantiation inside a '[', the next token is EOF, this

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno closed this revision. bruno added a comment. Committed in r271042 http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Sure! LGTM http://reviews.llvm.org/D19274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21338: cc1_main: Do not print statistics in -disable_free mode.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Assuming that it's guaranteed that the other path would always print out the statistics, LGTM Repository: rL LLVM http://reviews.llvm.org/D21338

Re: r273147 - [X86] Add -mno-iamcu option.

Hi Andrey, On Mon, Jun 20, 2016 at 3:31 AM, Andrey Turetskiy via cfe-commits wrote: > Author: aturetsk > Date: Mon Jun 20 05:31:39 2016 > New Revision: 273147 > > URL: http://llvm.org/viewvc/llvm-project?rev=273147=rev > Log: > [X86] Add -mno-iamcu option. > > Add

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

Ping :-) On Mon, Jan 11, 2016 at 8:49 AM, Bruno Cardoso Lopes wrote: > bruno added a comment. > > Ping! > > > http://reviews.llvm.org/D15173 > > > -- Bruno Cardoso Lopes http://www.brunocardoso.cc ___ cfe-commits mailing

[PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno created this revision. bruno added reviewers: rnk, rsmith. bruno added a subscriber: cfe-commits. Before r266366, clang used to support constructs like: typedef __attribute__((vector_size(8))) double float64x1_t; typedef __attribute__((vector_size(16))) double float64x2_t;

[PATCH] D17104: [VFS] Drop path traversal assertion

bruno created this revision. bruno added reviewers: bogner, benlangmuir. bruno added subscribers: cfe-commits, dexonsmith. This patch removes the path traversals check/assertion related with the presence of ".." in paths. The rationale is that if source and destination paths in the YAML file

[PATCH] D16906: [Parser] Perform CachedTokens update dependent on token consume request

bruno created this revision. bruno added reviewers: rsmith, doug.gregor, akyrtzi. bruno added subscribers: cfe-commits, dexonsmith. In the context where we break one tok::greatergreater into two tok::greater in order to correctly update the cached tokens; update the CachedTokens with two

r259910 - [Parser] Perform CachedTokens update dependent on token consumption

Author: bruno Date: Fri Feb 5 13:36:39 2016 New Revision: 259910 URL: http://llvm.org/viewvc/llvm-project?rev=259910=rev Log: [Parser] Perform CachedTokens update dependent on token consumption In the context where we break one tok::greatergreater into two tok::greater in order to correctly

Re: [PATCH] D16906: [Parser] Perform CachedTokens update dependent on token consume request

bruno closed this revision. bruno added a comment. Committed r259910 http://reviews.llvm.org/D16906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. > Your two-path solution seems like it's on the right track but I don't like > that it brings us back to having ".." in the source path. Given the two-path solution, another thing we could do in the first path, is to default to the remove_dots() version for the source,

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. > I'm not sure I understand how the 2nd path would cover the realpath case. It > is just an entry for the realpath itself; that doesn't help if the client > looks up "/install-dir/lib/clang/3.8.0" directly (not just from removing dots > from bin/..). What I was

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. > I don't think this is the right approach. If we don't canonicalize the > source path then: > > - looking up the path *without* the .. won't work, which means anything that > looks up a realpath will fail If we canonicalize, then it needs to be done in two places:

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno accepted this revision. bruno added a reviewer: bruno. bruno added a comment. Thanks, Committed r259311! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r259311 - [Parser] Update CachedTokens while parsing ObjectiveC template argument list

Author: bruno Date: Sat Jan 30 18:47:51 2016 New Revision: 259311 URL: http://llvm.org/viewvc/llvm-project?rev=259311=rev Log: [Parser] Update CachedTokens while parsing ObjectiveC template argument list Consider the following ObjC++ snippet: -- @protocol PA; @protocol PB; @class NSArray;

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

lly fixed in r261556. >>>> >>>> On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva <chisophu...@gmail.com> wrote: >>>> > This or r261551 seem to be causing a build failure: >>>> > >>>> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno closed this revision. bruno added a comment. Committed r261551 http://reviews.llvm.org/D17104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r261556 - [VFS] Fix call to getVFSFromYAML in unittests

Author: bruno Date: Mon Feb 22 13:02:27 2016 New Revision: 261556 URL: http://llvm.org/viewvc/llvm-project?rev=261556=rev Log: [VFS] Fix call to getVFSFromYAML in unittests Follow up from r261552 Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified:

Re: [PATCH] D17457: [VFS] Add 'overlay-relative' field to YAML files

bruno closed this revision. bruno added a comment. Committed r261552 / r261556 http://reviews.llvm.org/D17457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r261654 - Revert "[VFS] Add support for handling path traversals"

Author: bruno Date: Tue Feb 23 11:06:50 2016 New Revision: 261654 URL: http://llvm.org/viewvc/llvm-project?rev=261654=rev Log: Revert "[VFS] Add support for handling path traversals" This reverts commit r261551 due to failing tests in windows bots:

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

> -- Sean SIlva > > On Mon, Feb 22, 2016 at 10:41 AM, Bruno Cardoso Lopes via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: bruno >> Date: Mon Feb 22 12:41:09 2016 >> New Revision: 261552 >> >> URL: http://llvm.org/viewvc/llvm-project

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527 >> > >> > -- Sean SIlva >> > >> > On Mon, Feb 22, 2016 at 10:41 AM, Bruno Cardoso Lopes via cfe-commits >> > <cfe-commits@lists.llvm.org> wrote: >> >> &g

r261551 - [VFS] Add support for handling path traversals

Author: bruno Date: Mon Feb 22 12:41:01 2016 New Revision: 261551 URL: http://llvm.org/viewvc/llvm-project?rev=261551=rev Log: [VFS] Add support for handling path traversals Handle ".", ".." and "./" with trailing slashes while collecting files to be dumped into the vfs overlay directory.

r261552 - [VFS] Add 'overlay-relative' field to YAML files

Author: bruno Date: Mon Feb 22 12:41:09 2016 New Revision: 261552 URL: http://llvm.org/viewvc/llvm-project?rev=261552=rev Log: [VFS] Add 'overlay-relative' field to YAML files The VFS overlay mapping between virtual paths and real paths is done through the 'external-contents' entries in YAML

r261613 - Revert "[VFS] Add 'overlay-relative' field to YAML files" and "[VFS] Fix call to getVFSFromYAML in unittests"

Author: bruno Date: Tue Feb 23 01:06:12 2016 New Revision: 261613 URL: http://llvm.org/viewvc/llvm-project?rev=261613=rev Log: Revert "[VFS] Add 'overlay-relative' field to YAML files" and "[VFS] Fix call to getVFSFromYAML in unittests" This reverts commit r261552 and r261556 because of failing

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527 >>> > >>> > -- Sean SIlva >>> > >>> > On Mon, Feb 22, 2016 at 10:41 AM, Bruno Cardoso Lopes via cfe-commits >>> > <cfe-commits@lists.llvm.org>

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

Ping! On Wed, Jan 20, 2016 at 11:22 AM, Bruno Cardoso Lopes wrote: > bruno updated this revision to Diff 45421. > bruno added a comment. > > Update patch after Richard comments > > > http://reviews.llvm.org/D15173 > > Files: > include/clang/Lex/Preprocessor.h >

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

Hi Richard, >> + // The advance from '>>' to '>' in a ObjectiveC template argument list >> needs >> + // to be properly reflected in the token cache to allow correct >> interaction >> + // between annotation and backtracking. >> + if (ObjCGenericList && PrevTok.getKind() ==

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno updated this revision to Diff 45421. bruno added a comment. Update patch after Richard comments http://reviews.llvm.org/D15173 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPCaching.cpp lib/Parse/ParseTemplate.cpp test/Parser/objcxx11-protocol-in-template.mm Index:

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno updated this revision to Diff 48397. bruno added a comment. Updated the patch, with the following changes: Handle ".", ".." and "./" with trailing slashes while collecting files to be dumped into the vfs overlay directory. Include the support for symlinks into components. Given

[PATCH] D17457: [VFS] Add 'overlay-relative' field to YAML files

bruno created this revision. bruno added reviewers: benlangmuir, bogner. bruno added subscribers: cfe-commits, dexonsmith. The VFS overlay mapping between virtual paths and real paths is done through the 'external-contents' entries in YAML files, which contains hardcoded paths to the real files.

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. In http://reviews.llvm.org/D17104#349141, @benlangmuir wrote: > Please clarify what you mean here: > > > The rationale is that if source and destination paths in the YAML file > > contain ".." this is enough > > > for the file manager to retrieve the right file, meaning

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

Thanks! On Wed, Mar 16, 2016 at 5:35 AM, NAKAMURA Takumi wrote: > chapuni added a subscriber: chapuni. > chapuni added a comment. > > Excuse me, I have reverted it in r263636. > > > > Comment at: lib/Frontend/ModuleDependencyCollector.cpp:65 > @@ +64,3 @@ >

r263686 - Reapply [2]: [VFS] Add support for handling path traversals

Author: bruno Date: Wed Mar 16 21:20:43 2016 New Revision: 263686 URL: http://llvm.org/viewvc/llvm-project?rev=263686=rev Log: Reapply [2]: [VFS] Add support for handling path traversals This was applied twice r261551 and 263617 and later reverted because: (1) Windows bot failing on unittests.

r263617 - Reapply: [VFS] Add support for handling path traversals

Author: bruno Date: Tue Mar 15 23:39:38 2016 New Revision: 263617 URL: http://llvm.org/viewvc/llvm-project?rev=263617=rev Log: Reapply: [VFS] Add support for handling path traversals This is originally r261551, reverted because of windows bots failing on unittests. Change the current behavior to

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno updated this revision to Diff 51828. bruno added a comment. Thanks Reid. The original idea was to have MaxDigits despite the size of the input array (but bounded by its size). But since there are no other users up to this point, your suggestion seems better, updated the patch to reflect

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno added a comment. In http://reviews.llvm.org/D18296#384766, @rsmith wrote: > This patch builds a length-1 `ConversionSpecifier` but includes the complete > code point in the length of the overall format specifier, which is > inconsistent. Please either treat the trailing bytes as part of

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno updated this revision to Diff 51859. bruno added a comment. Update after Richard's review. - Handle scanf - Properly update `ConversionSpecifier` http://reviews.llvm.org/D18296 Files: include/clang/Analysis/Analyses/FormatString.h lib/Analysis/FormatString.cpp

r264987 - [DarwinDriver] Increase the number of valid digits for ld64 version string.

Author: bruno Date: Wed Mar 30 21:45:46 2016 New Revision: 264987 URL: http://llvm.org/viewvc/llvm-project?rev=264987=rev Log: [DarwinDriver] Increase the number of valid digits for ld64 version string. Previously only 3 digits were valid. Increase it to 5. Differential Revision:

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno added a comment. Committed r264987! Comment at: lib/Driver/Driver.cpp:2549-2550 @@ +2548,4 @@ + unsigned CurDigit = 0; + unsigned MaxDigits = Digits.size(); + while (CurDigit < MaxDigits) { +unsigned Digit = (unsigned)strtol(Str, , 10); rnk wrote:

r264970 - [VFS] Handle empty entries in directory traversal

Author: bruno Date: Wed Mar 30 18:54:00 2016 New Revision: 264970 URL: http://llvm.org/viewvc/llvm-project?rev=264970=rev Log: [VFS] Handle empty entries in directory traversal The VFS YAML files contain empty directory entries to describe that it's returning from a subdirectory before

r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Author: bruno Date: Wed Apr 6 19:00:57 2016 New Revision: 265622 URL: http://llvm.org/viewvc/llvm-project?rev=265622=rev Log: [CrashReproducer] Setup 'case-sensitive' in YAML files. The crash reproducer was not setting up case sensitivity in the VFS yaml files, which defaults to true. Make the

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Thanks Hans, taking a look! On Wed, Apr 6, 2016 at 5:49 PM, Hans Wennborg <h...@chromium.org> wrote: > On Wed, Apr 6, 2016 at 5:00 PM, Bruno Cardoso Lopes via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: bruno > > Date: Wed Apr 6 19:00:57

Re: r265630 - [CrashReproducer] Change std::toupper to ::toupper

Better yet. Committed r265632 Thanks Sean, On Wed, Apr 6, 2016 at 6:11 PM, Sean Silva <chisophu...@gmail.com> wrote: > We also have toUppercase in include/clang/Basic/CharInfo.h > > -- Sean Silva > > On Wed, Apr 6, 2016 at 6:04 PM, Bruno Cardoso Lopes via cfe-co

r265632 - [CrashReproducer] Use toUppercase from include/clang/Basic/CharInfo.h

Author: bruno Date: Wed Apr 6 20:12:18 2016 New Revision: 265632 URL: http://llvm.org/viewvc/llvm-project?rev=265632=rev Log: [CrashReproducer] Use toUppercase from include/clang/Basic/CharInfo.h Use toUppercase instead of ::toupper() Modified:

[PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno created this revision. bruno added reviewers: rsmith, benlangmuir, klimek. bruno added subscribers: aprantl, dexonsmith, cfe-commits. The reproducer script (generated by the crash reproducer) invokes clang and tries to rebuild modules using the headers in the .cache/vfs directory. Depending

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Attempt to fix in r265630. On Wed, Apr 6, 2016 at 5:51 PM, Bruno Cardoso Lopes <bruno.card...@gmail.com > wrote: > Thanks Hans, taking a look! > > On Wed, Apr 6, 2016 at 5:49 PM, Hans Wennborg <h...@chromium.org> wrote: > >> On Wed, Apr 6, 2016 at 5:00 PM, Bruno

r265630 - [CrashReproducer] Change std::toupper to ::toupper

Author: bruno Date: Wed Apr 6 20:04:09 2016 New Revision: 265630 URL: http://llvm.org/viewvc/llvm-project?rev=265630=rev Log: [CrashReproducer] Change std::toupper to ::toupper Attempt to fix windows bots Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp Modified:

r265621 - [CrashReproducer] Move ModuleDependencyCollector method around. NFC

Author: bruno Date: Wed Apr 6 19:00:42 2016 New Revision: 265621 URL: http://llvm.org/viewvc/llvm-project?rev=265621=rev Log: [CrashReproducer] Move ModuleDependencyCollector method around. NFC Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp Modified:

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Didn't notice that yield an error, thanks again Sean! On Wed, Apr 6, 2016 at 7:04 PM, Sean Silva <chisophu...@gmail.com> wrote: > > > On Wed, Apr 6, 2016 at 6:56 PM, Sean Silva <chisophu...@gmail.com> wrote: > >> >> >> On Wed, Apr 6, 2016 at 6:10 PM, Br

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno added a comment. Hi Ben, Comment at: lib/Basic/FileManager.cpp:221-223 @@ -220,2 +220,5 @@ // See if there is already an entry in the map. + // FIXME: Note that when first requested, the returned file name equals to the + // requested path. This is not true when

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno added a comment. Hi Manman, Comment at: lib/Parse/ParseObjc.cpp:1697 @@ -1696,3 +1696,3 @@ // We syntactically matched a type argument, so commit to parsing - // type arguments. + // type arguments. Finding protocol arguments after here is an error.

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno updated this revision to Diff 53470. bruno added a comment. New patch after Manman's review. http://reviews.llvm.org/D18997 Files: include/clang/Sema/Sema.h lib/Parse/ParseObjc.cpp lib/Sema/SemaDeclObjC.cpp test/SemaObjC/parameterized_classes.m Index:

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno abandoned this revision. bruno added a comment. Hi Ben, Comment at: lib/Basic/FileManager.cpp:221-223 @@ -220,2 +220,5 @@ // See if there is already an entry in the map. + // FIXME: Note that when first requested, the returned file name equals to the + // requested

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno updated this revision to Diff 53363. bruno added a comment. Hi Richard & Ben, Thanks for the review! I've attached a new patch and changed the approach: made findUsableModuleForHeader receive a FileName instead of FileEntry. Answering the questions below: FileManager::getFile returns

[PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno created this revision. bruno added a reviewer: doug.gregor. bruno added subscribers: manmanren, dexonsmith, cfe-commits. Under certain conditions clang currently fails to properly diagnostic ObjectC parameter list when type args and protocols are mixed in the same list. This happens when

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno added a comment. Ping! http://reviews.llvm.org/D18849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263748 - Reapply [VFS] Add 'overlay-relative' field to YAML files

Author: bruno Date: Thu Mar 17 16:11:23 2016 New Revision: 263748 URL: http://llvm.org/viewvc/llvm-project?rev=263748=rev Log: Reapply [VFS] Add 'overlay-relative' field to YAML files This reapplies r261552. The VFS overlay mapping between virtual paths and real paths is done through the

[PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, dexonsmith. Improve invalid format string specifier handling by printing out invalid specifiers characters with \x, \u and \U. Previously clang would print gargabe whenever the character is

r263750 - Revert "Reapply [VFS] Add 'overlay-relative' field to YAML files"

Author: bruno Date: Thu Mar 17 16:30:55 2016 New Revision: 263750 URL: http://llvm.org/viewvc/llvm-project?rev=263750=rev Log: Revert "Reapply [VFS] Add 'overlay-relative' field to YAML files" Tests failing on http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/46102 This reverts commit

Re: r263718 - Use a simpler set of mock headers for the vfs+modules crash recovery tests.

Nice! Thanks Benjamin On Thu, Mar 17, 2016 at 9:19 AM, Benjamin Kramer via cfe-commits wrote: > Author: d0k > Date: Thu Mar 17 11:19:51 2016 > New Revision: 263718 > > URL: http://llvm.org/viewvc/llvm-project?rev=263718=rev > Log: > Use a simpler set of mock headers

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno added a comment. Ping! http://reviews.llvm.org/D18304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno added a comment. Ping! http://reviews.llvm.org/D18296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno created this revision. bruno added reviewers: bob.wilson, dexonsmith. bruno added a subscriber: cfe-commits. Previously only 3 digits were valid. Increase it to 5. http://reviews.llvm.org/D18304 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp lib/Driver/Tools.cpp

  1   2   3   4   5   6   >