Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

carlo.bertolli updated this revision to Diff 42070. carlo.bertolli added a comment. Added regression test. Repository: rL LLVM http://reviews.llvm.org/D15220 Files: include/clang/AST/OpenMPClause.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/OpenMPKinds.def

[PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

carlo.bertolli created this revision. carlo.bertolli added reviewers: hfinkel, ABataev, rjmccall. carlo.bertolli added subscribers: sfantao, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. This patch includes parsing and semantic analysis for 'omp distribute'

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

carlo.bertolli updated this revision to Diff 41980. carlo.bertolli marked 7 inline comments as done. carlo.bertolli added a comment. This updated patch includes taskloop simd changes form the trunk and it addresses the second round of comments. Repository: rL LLVM

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

carlo.bertolli added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:460 @@ -449,4 +459,3 @@ DKind == OMPD_single || DKind == OMPD_parallel_for || - DKind == OMPD_parallel_for_simd || - DKind == OMPD_parallel_sections; // TODO add next directives.

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

carlo.bertolli updated this revision to Diff 41983. carlo.bertolli added a comment. Update dist_schedule patch to reflect changes in distribute directive patch. Repository: rL LLVM http://reviews.llvm.org/D15220 Files: include/clang/AST/OpenMPClause.h

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

carlo.bertolli updated this revision to Diff 41712. carlo.bertolli marked 15 inline comments as done. carlo.bertolli added a comment. Thanks very much for your kind comments and patience at some trivial errors on my side. This new version of the patch addresses all your concerns and it removes

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

carlo.bertolli added inline comments. Comment at: include/clang/AST/OpenMPClause.h:667 @@ -666,3 +666,3 @@ OpenMPScheduleClauseKind Kind; - /// \brief Start location of the schedule ind in source code. + /// \brief Start location of the schedule kind in source code.

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

carlo.bertolli closed this revision. carlo.bertolli added a comment. This was committed in r255001. Many thanks for all your help. Repository: rL LLVM http://reviews.llvm.org/D15125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r255001 - Add parse and sema for OpenMP distribute directive and all its clauses excluding dist_schedule.

Author: cbertol Date: Mon Dec 7 22:21:03 2015 New Revision: 255001 URL: http://llvm.org/viewvc/llvm-project?rev=255001=rev Log: Add parse and sema for OpenMP distribute directive and all its clauses excluding dist_schedule. Added: cfe/trunk/test/OpenMP/distribute_ast_print.cpp

r255498 - Add parse and sema of OpenMP distribute directive with all clauses except dist_schedule

Author: cbertol Date: Mon Dec 14 08:51:25 2015 New Revision: 255498 URL: http://llvm.org/viewvc/llvm-project?rev=255498=rev Log: Add parse and sema of OpenMP distribute directive with all clauses except dist_schedule Added: cfe/trunk/test/OpenMP/distribute_ast_print.cpp

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

carlo.bertolli added a comment. Resubmitted at rev255498 Repository: rL LLVM http://reviews.llvm.org/D15125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

carlo.bertolli updated this revision to Diff 44012. carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. Update to dist_schedule patch, as requested: show whole context and add ast print regression test. Repository: rL LLVM http://reviews.llvm.org/D15220 Files:

Re: [PATCH] D18470: [OPENMP] Remove unnecessary code generation of firstprivate clause for target directive in nvptx

carlo.bertolli abandoned this revision. carlo.bertolli added a comment. Codegen of region bodies should not be specialized based on target. Repository: rL LLVM http://reviews.llvm.org/D18470 ___ cfe-commits mailing list

Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

carlo.bertolli marked 2 inline comments as done. carlo.bertolli added a comment. Thanks very much for the quick review. I am about to update the patch reflecting your comments and to the latest trunk. Comment at: include/clang/AST/StmtOpenMP.h:2884-2896 @@ +2883,15 @@ + + ///

Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

carlo.bertolli added a comment. Thanks for these further comments. I have just updated the diff applying the suggestions. Repository: rL LLVM http://reviews.llvm.org/D21564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

carlo.bertolli added a comment. Thanks for the hint - I have updated the diff to use Context.getSizeType(). Please let me know if this is what you meant. Repository: rL LLVM http://reviews.llvm.org/D21564 ___ cfe-commits mailing list

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

carlo.bertolli closed this revision. carlo.bertolli added a comment. Please notify of any issues. Repository: rL LLVM http://reviews.llvm.org/D15220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r257917 - Add OpenMP dist_schedule clause to distribute directive and related regression tests.

Author: cbertol Date: Fri Jan 15 12:50:31 2016 New Revision: 257917 URL: http://llvm.org/viewvc/llvm-project?rev=257917=rev Log: Add OpenMP dist_schedule clause to distribute directive and related regression tests. Added: cfe/trunk/test/OpenMP/distribute_dist_schedule_ast_print.cpp

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

carlo.bertolli added a comment. Committed revision 257917. Repository: rL LLVM http://reviews.llvm.org/D15220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

carlo.bertolli added a comment. Resubmitted at revision 273884 after fixes. Repository: rL LLVM http://reviews.llvm.org/D21564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 273705. Repository: rL LLVM http://reviews.llvm.org/D21564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D17076: [OPENMP] firstprivate clause for target

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0. carlo.bertolli added subscribers: sfantao, arpith-jacob, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. Very simple but necessary extension to target directive with

r260581 - Add parse+sema and regression test for OpenMP firstprivate clause of target directive

Author: cbertol Date: Thu Feb 11 14:12:28 2016 New Revision: 260581 URL: http://llvm.org/viewvc/llvm-project?rev=260581=rev Log: Add parse+sema and regression test for OpenMP firstprivate clause of target directive Added: cfe/trunk/test/OpenMP/target_firstprivate_messages.cpp Modified:

Re: [PATCH] D17076: [OPENMP] firstprivate clause for target

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 260581. Repository: rL LLVM http://reviews.llvm.org/D17076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli removed rL LLVM as the repository for this revision. carlo.bertolli updated this revision to Diff 47695. carlo.bertolli added a comment. Remove handling of reductions - not supported by this patch. http://reviews.llvm.org/D17148 Files: lib/CodeGen/CGOpenMPRuntime.cpp

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli updated this revision to Diff 47921. carlo.bertolli added a comment. Reflect changes in http://reviews.llvm.org/D17148 and show full context. Repository: rL LLVM http://reviews.llvm.org/D17170 Files: include/clang/AST/StmtOpenMP.h lib/CodeGen/CGOpenMPRuntime.cpp

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli updated this revision to Diff 48691. carlo.bertolli added a comment. Address latest comments. Repository: rL LLVM http://reviews.llvm.org/D17170 Files: include/clang/AST/StmtOpenMP.h lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli marked 5 inline comments as done. carlo.bertolli added a comment. Updating patch following comments. Repository: rL LLVM http://reviews.llvm.org/D17170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r258140 - Activate OpenMP private clause for target construct and a regression test.

Author: cbertol Date: Tue Jan 19 10:53:55 2016 New Revision: 258140 URL: http://llvm.org/viewvc/llvm-project?rev=258140=rev Log: Activate OpenMP private clause for target construct and a regression test. Added: cfe/trunk/test/OpenMP/target_private_messages.cpp Modified:

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli set the repository for this revision to rL LLVM. carlo.bertolli updated this revision to Diff 47995. carlo.bertolli added a comment. Added comment for boolean parameter. Repository: rL LLVM http://reviews.llvm.org/D17148 Files: lib/CodeGen/CGOpenMPRuntime.cpp

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:759 @@ +758,3 @@ + /// + void emitForStaticInitWithKMPSchedule(CodeGenFunction , +SourceLocation Loc, I added this because

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:759 @@ +758,3 @@ + /// + void emitForStaticInitWithKMPSchedule(CodeGenFunction , +SourceLocation Loc, carlo.bertolli wrote: > I added this

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli added a comment. I have addressed some of the comments and restructured the code as requested. Let me know about further comments. Thanks for making this a better patch! Repository: rL LLVM http://reviews.llvm.org/D17170 ___

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. I have addressed some of the comments and restructured the code as requested. Let me know about further comments. Thanks for making this a better patch! Comment at:

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli updated this revision to Diff 48100. carlo.bertolli added a comment. Address comments and rebase over new version of http://reviews.llvm.org/D17148. Repository: rL LLVM http://reviews.llvm.org/D17170 Files: include/clang/AST/StmtOpenMP.h lib/CodeGen/CGOpenMPRuntime.cpp

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli marked 4 inline comments as done. Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2914 @@ -2713,4 +2913,3 @@ if (NT || TL) { -NumTeamsVal = (NT) ? CGF.EmitScalarExpr(NT->getNumTeams(), -/* IgnoreResultAssign = */ true) : +NumTeamsVal = (NT) ?

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli updated this revision to Diff 48200. carlo.bertolli added a comment. Updated diff reflecting comments. Note that having the emission of the runtime kmpc_for_static_init function in a static function (instead of a method of CGOpenMPRuntime) required moving to public some fields in

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli updated this revision to Diff 48271. carlo.bertolli added a comment. Update against dependence http://reviews.llvm.org/D17019. Repository: rL LLVM http://reviews.llvm.org/D17148 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli updated this revision to Diff 48273. carlo.bertolli added a comment. Update to new version of http://reviews.llvm.org/D17148, integrating changes from the trunk. Repository: rL LLVM http://reviews.llvm.org/D17170 Files: include/clang/AST/StmtOpenMP.h

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli marked 4 inline comments as done. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4426-4431 @@ +4425,8 @@ + SourceLocation Loc) { + llvm::Value *PushNumTeamsArgs[] = { + emitUpdateLocation(CGF, Loc), getThreadID(CGF, Loc),

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli updated this revision to Diff 48369. carlo.bertolli added a comment. Addressed latest comments. Repository: rL LLVM http://reviews.llvm.org/D17148 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:187-208 @@ -185,30 +186,24 @@ + +public: /// \brief Values for bit flags used in the ident_t to describe the fields. /// All enumeric elements are named and described in accordance with the code

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli updated this revision to Diff 48379. carlo.bertolli marked 4 inline comments as done. carlo.bertolli added a comment. Partially address comments to replace schedule type with schedule num in interface of static function generating call to kmpc_for_static_init. Still waiting for

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli updated this revision to Diff 48511. carlo.bertolli added a comment. Update against trunk. Repository: rL LLVM http://reviews.llvm.org/D17148 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli updated this revision to Diff 48526. carlo.bertolli added a comment. Update to trunk and implement suggestions from latest review: do not make public methods used in static function calling kmpc_for_static_init, but call those functions in the caller that can access them.

Re: [PATCH] D17019: [OpenMP] Code generation for teams - kernel launching

carlo.bertolli added a comment. Just wanted to add that tgt_target_teams needs the values for num_teams and thread_limit because, for some accelerators, it is necessary to know those values in advance, before teams gets actually executed. For instance, on Nvidia GPUs we launch one CUDA block

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli updated this revision to Diff 47890. carlo.bertolli added a comment. Apply changes to reflect review: have a single emit outlined function call for both parallel and teams; call push_num_teams outside of runtime class. http://reviews.llvm.org/D17148 Files:

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli marked 2 inline comments as done. carlo.bertolli added a comment. I applied your suggestions and generated a new diff file. Thanks! http://reviews.llvm.org/D17148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0. carlo.bertolli added subscribers: sfantao, arpith-jacob, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. This patch implements the teams directive. It only provides

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli added a comment. I can actually add a regression test that checks that the compiler does not break when using a global in a teams region, even without declare target, if that is what is required here. Repository: rL LLVM http://reviews.llvm.org/D17963

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

carlo.bertolli updated this revision to Diff 50829. carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. Modify diff to reflect comments. Repository: rL LLVM http://reviews.llvm.org/D18203 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D18105: [OPENMP] Support for codegen of private clause of target, host side

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, kkwli0. carlo.bertolli added subscribers: caomhin, sfantao, arpith-jacob, fraggamuffin, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. This patch adds support for codegen of private

Re: [PATCH] D18105: [OPENMP] Support for codegen of private clause of target, host side

carlo.bertolli updated this revision to Diff 50489. carlo.bertolli added a comment. [OPENMP] Add testing for 32-bit arch Repository: rL LLVM http://reviews.llvm.org/D18105 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_private_codegen.cpp Index:

Re: [PATCH] D18105: [OPENMP] Support for codegen of private clause of target, host side

carlo.bertolli updated this revision to Diff 50512. carlo.bertolli added a comment. [OPENMP] Add missing check macros in regression test and remove reference to firstprivate (will come in next patch). Repository: rL LLVM http://reviews.llvm.org/D18105 Files:

[PATCH] D17979: [OPENMP] Add regression test for codegen of distribute pragma for NVPTX

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0. carlo.bertolli added subscribers: sfantao, arpith-jacob, caomhin, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. The support for distribute pragma is the same on host

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli updated this revision to Diff 50187. carlo.bertolli added a comment. [OPENMP] This new version of the patch uses the inlining machinery of CGOpenMPRuntime.cpp instead of just dumping the teams body statement using EmitStmt. Repository: rL LLVM http://reviews.llvm.org/D17963

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. Addressed comment in new version of diff. Repository: rL LLVM http://reviews.llvm.org/D17963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli added a comment. Support for global variables in a target region requires the global to be placed in a pragma declare target region. Pragma declare target region is not currently available in Clang (no parsing, sema, or codegen). I will add a check for this in the regression

[PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, kkwli0. carlo.bertolli added subscribers: sfantao, arpith-jacob, caomhin, fraggamuffin, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. This patch implements the following aspects: - It

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. Great, thanks for the hint. I do much prefer your version of the function. I am updating the diff. Repository: rL LLVM http://reviews.llvm.org/D18474 ___

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli updated this revision to Diff 53425. carlo.bertolli added a comment. [OPENMP] Remove unnecessary templating of function. Repository: rL LLVM http://reviews.llvm.org/D18474 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/teams_codegen.cpp Index:

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli updated this revision to Diff 53283. carlo.bertolli added a comment. [OPENMP] Remove template for intervening statement and only allow CompoundStmt. Repository: rL LLVM http://reviews.llvm.org/D18474 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/teams_codegen.cpp

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. Alexey Thanks for the review. I addressed your comment in a new version of the revision. Samuel already reviewed the patch, as you can see in the message exchange. I am very happy to apply any design change you

r263837 - [OPENMP] Implementation of codegen for firstprivate clause of target directive

Author: cbertol Date: Fri Mar 18 16:43:32 2016 New Revision: 263837 URL: http://llvm.org/viewvc/llvm-project?rev=263837=rev Log: [OPENMP] Implementation of codegen for firstprivate clause of target directive This patch implements the following aspects: It extends sema to check that a variable

Re: [PATCH] D18105: [OPENMP] Support for codegen of private clause of target, host side

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 263654. Repository: rL LLVM http://reviews.llvm.org/D18105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, kkwli0, Hahnfeld. carlo.bertolli added subscribers: sfantao, caomhin, arpith-jacob, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. Herald added a subscriber: jholewinski. This patch adds

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

carlo.bertolli updated this revision to Diff 50845. carlo.bertolli added a comment. Update against trunk as dependence was committed to trunk. Repository: rL LLVM http://reviews.llvm.org/D18203 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CGOpenMPRuntime.cpp

r263654 - [OPENMP] Support for codegen of private clause of target, host side

Author: cbertol Date: Wed Mar 16 14:04:22 2016 New Revision: 263654 URL: http://llvm.org/viewvc/llvm-project?rev=263654=rev Log: [OPENMP] Support for codegen of private clause of target, host side This patch adds support for codegen of private clause of target and a regression test for host

Re: [PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

carlo.bertolli added a comment. Hi Jonas Thanks for your comment. That scheme would not work for #parallel on the gpu in case we do not want to inline the parallel region. There are patches coming in which that is going to happen so I think that we really need to distinguish between different

Re: [PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

carlo.bertolli added a comment. Hi Thinking more carefully, I believe you are right - no, it is not. I guess we would not call at all shouldEmitInlinedTeamsDirective for the case of paralle. Thanks! Repository: rL LLVM http://reviews.llvm.org/D18286

[PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, sfantao, Hahnfeld. carlo.bertolli added subscribers: arpith-jacob, caomhin, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. This patch fixes a bug in code generation of the correct OpenMP

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 263837. Repository: rL LLVM http://reviews.llvm.org/D18203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli updated this revision to Diff 51676. carlo.bertolli added a comment. Simplify the search function and generalize by using a template. Repository: rL LLVM http://reviews.llvm.org/D18474 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/teams_codegen.cpp Index:

Re: [PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

carlo.bertolli added a comment. Hi Alexey Thanks for your comment. The suggested change will not work as I intended in my patch when using the host as a device. This happens when you select the following options: -fomptargets=powerpc64le-ibm-linux-gnu -fopenmp-is-device In this case we

Re: [PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

carlo.bertolli updated this revision to Diff 51285. carlo.bertolli added a comment. To make clear my comment I an updating the patch following Alexey's comment and modifying it to make it work. You can see that now we have the following check: CGM.getTarget().getTriple().getArch() ==

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4257 @@ +4256,3 @@ +hasEnclosingTeams(const Stmt *TargetBody) { + if(auto *TeamsDir = dyn_cast(TargetBody)) return TeamsDir; + sfantao wrote: > I think that this can be simplified

[PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, fraggamuffin, kkwli0. carlo.bertolli added subscribers: sfantao, arpith-jacob, caomhin, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. Herald added a subscriber: jholewinski. This patch

Re: [PATCH] D17582: [OPENMP] firstprivate and private clauses of teams, host codegeneration

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 262663. Repository: rL LLVM http://reviews.llvm.org/D17582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262663 - [OPENMP] firstprivate and private clauses of teams, host codegeneration

Author: cbertol Date: Thu Mar 3 16:09:40 2016 New Revision: 262663 URL: http://llvm.org/viewvc/llvm-project?rev=262663=rev Log: [OPENMP] firstprivate and private clauses of teams, host codegeneration Add code generation support for firstprivate and private clauses of teams on the host. Add

r262741 - [OPENMP] Codegen for distribute directive

Author: cbertol Date: Fri Mar 4 14:24:58 2016 New Revision: 262741 URL: http://llvm.org/viewvc/llvm-project?rev=262741=rev Log: [OPENMP] Codegen for distribute directive This patch provide basic implementation of codegen for teams directive, excluding all clauses except dist_schedule. It also

Re: [PATCH] D17170: [OPENMP] Codegen for distribute directive

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 262741. Repository: rL LLVM http://reviews.llvm.org/D17170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17148: [OPENMP] Basic teams directive implementation

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 262652. Repository: rL LLVM http://reviews.llvm.org/D17148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r262652 - Add code generation for teams directive inside target region

Author: cbertol Date: Thu Mar 3 14:34:23 2016 New Revision: 262652 URL: http://llvm.org/viewvc/llvm-project?rev=262652=rev Log: Add code generation for teams directive inside target region Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h

r262833 - [OPENMP] Codegen for distribute directive: fix bug in ordering of parameters.

Author: cbertol Date: Mon Mar 7 10:19:13 2016 New Revision: 262833 URL: http://llvm.org/viewvc/llvm-project?rev=262833=rev Log: [OPENMP] Codegen for distribute directive: fix bug in ordering of parameters. Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Modified:

r262832 - Reapply r262741 [OPENMP] Codegen for distribute directive

Author: cbertol Date: Mon Mar 7 10:04:49 2016 New Revision: 262832 URL: http://llvm.org/viewvc/llvm-project?rev=262832=rev Log: Reapply r262741 [OPENMP] Codegen for distribute directive This patch provide basic implementation of codegen for teams directive, excluding all clauses except

Re: r262741 - [OPENMP] Codegen for distribute directive

NMP] Codegen for distribute directive Looks like the new tests don't pass on Windows: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10365 On Mar 4, 2016 12:29 PM, "Carlo Bertolli via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: cbertol Date: Fr

Re: [PATCH] D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions.

carlo.bertolli added a comment. Hi If I understand correctly the problem, I would like to add something on top of Samuel's comment. My understanding is that Alexey is suggesting that we pass a reference type to kernels for every pointer input parameter, regardless of the actual type and data

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli updated this revision to Diff 52416. carlo.bertolli added a comment. [OPENMP] Even though this patch was already accepted in its previous form, comments on depending patch http://reviews.llvm.org/D18286 (http://reviews.llvm.org/D18286) revealed that a new approach for this patch

Re: [PATCH] D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions.

carlo.bertolli added a comment. Hi Alexey I understand your concerns and share the danger of working on optimizations before a correct implementation is actually in place. I do not think this is the case. My comment was very precise about the cause-effect: the OpenMP specification was defined

Re: [PATCH] D17963: [OPENMP] Codegen for teams directive for NVPTX

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 265304. Repository: rL LLVM http://reviews.llvm.org/D17963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r265304 - [OPENMP] Codegen for teams directive for NVPTX

Author: cbertol Date: Mon Apr 4 10:55:02 2016 New Revision: 265304 URL: http://llvm.org/viewvc/llvm-project?rev=265304=rev Log: [OPENMP] Codegen for teams directive for NVPTX This patch implements the teams directive for the NVPTX backend. It is different from the host code generation path as

Re: [PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

carlo.bertolli updated this revision to Diff 52640. carlo.bertolli added a comment. [OPENMP] Rebase patch on new support for codegen for teams in nvptx target. private and firstprivate clauses are now dealt with in the teams patch and this one only becomes regression tests. Repository: rL

r267972 - [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

Author: cbertol Date: Thu Apr 28 20:37:30 2016 New Revision: 267972 URL: http://llvm.org/viewvc/llvm-project?rev=267972=rev Log: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets http://reviews.llvm.org/D18474

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli closed this revision. carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. Committed revision 267972. Repository: rL LLVM http://reviews.llvm.org/D18474 ___ cfe-commits mailing list

r275271 - [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

Author: cbertol Date: Wed Jul 13 10:37:16 2016 New Revision: 275271 URL: http://llvm.org/viewvc/llvm-project?rev=275271=rev Log: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data' http://reviews.llvm.org/D21904 This patch is similar to the implementation

r275282 - [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target

Author: cbertol Date: Wed Jul 13 12:16:49 2016 New Revision: 275282 URL: http://llvm.org/viewvc/llvm-project?rev=275282=rev Log: [OpenMP] Initial implementation of parse+sema for OpenMP clause 'is_device_ptr' of target http://reviews.llvm.org/D22070 Added:

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 275271. Repository: rL LLVM http://reviews.llvm.org/D21904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

carlo.bertolli updated this revision to Diff 63689. carlo.bertolli added a comment. [OpenMP] Add regression test to check correctness of ast building, remove 'brief's, and rebase. Repository: rL LLVM http://reviews.llvm.org/D21904 Files: include/clang/AST/OpenMPClause.h

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

carlo.bertolli marked 3 inline comments as done. Comment at: lib/Sema/SemaOpenMP.cpp:11648 @@ +11647,3 @@ +// item should be a pointer or reference to pointer +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

carlo.bertolli updated this revision to Diff 62817. carlo.bertolli added a comment. [OpenMP] Remove private variable creation from this patch as requested by comments and rebase. Repository: rL LLVM http://reviews.llvm.org/D21904 Files: include/clang/AST/OpenMPClause.h

  1   2   >