Re: [PATCH] D11437: Correct x86_64 fp128 calling convention

2015-08-10 Thread Chih-Hung Hsieh via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL244468: Correct x86_64 fp128 calling convention (authored by chh). Changed prior to commit: http://reviews.llvm.org/D11437?vs=31457id=31687#toc Repository: rL LLVM http://reviews.llvm.org/D11437

r244468 - Correct x86_64 fp128 calling convention

2015-08-10 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Mon Aug 10 12:33:31 2015 New Revision: 244468 URL: http://llvm.org/viewvc/llvm-project?rev=244468view=rev Log: Correct x86_64 fp128 calling convention These changes are for Android x86_64 targets to be compatible with current Android g++ and conform to AMD64 ABI.

Re: [PATCH] D11921: Add NaCl (a target where long double = double) to long double ABI test

2015-08-10 Thread Chih-Hung Hsieh via cfe-commits
chh added a comment. Please rebase the change to r244502 or newer, to run with -Asserts builds. Thanks. Repository: rL LLVM http://reviews.llvm.org/D11921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11922: Add NaCl to long double/fp128 mangling test

2015-08-10 Thread Chih-Hung Hsieh via cfe-commits
chh added a comment. If there were only two different types, we should have mangled name 'd' for double and 'e' for long double, even if their implementations are the same. The problem came when g++ has __float80 and __float128 types, and long double could be implemented as __float80 or

Re: r271427 - [driver][arm] add armv7 and thumb include and lib paths

2016-06-02 Thread Chih-hung Hsieh via cfe-commits
Ismail, I saw that android-ndk-standalone.cpp has already -stdlib=libstdc++. Could you tell me or just go ahead and make the necessary change? Thanks. On Thu, Jun 2, 2016 at 9:52 AM, Ismail Donmez <ism...@i10z.com> wrote: > Hi, > > On Wed, Jun 1, 2016 at 11:48 PM, Chih-Hun

r271427 - [driver][arm] add armv7 and thumb include and lib paths

2016-06-01 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Jun 1 15:48:46 2016 New Revision: 271427 URL: http://llvm.org/viewvc/llvm-project?rev=271427=rev Log: [driver][arm] add armv7 and thumb include and lib paths Add a new test android-ndk-standalone.cpp with new Android NDK release tree structure. Detect armv7 sub

r271438 - [driver][arm] change regular expression to work on Windows

2016-06-01 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Jun 1 17:53:59 2016 New Revision: 271438 URL: http://llvm.org/viewvc/llvm-project?rev=271438=rev Log: [driver][arm] change regular expression to work on Windows Differential Revision: http://reviews.llvm.org/D20600 Modified:

Re: [Diffusion] rL257984: [Cygwin] Use -femulated-tls by default since r257718 introduced the new pass.

2016-01-19 Thread Chih-hung Hsieh via cfe-commits
Glad to see that emutls is useful for Cygwin too. The diff in rL257984 do not look like depending on rL257718. It might work with my earlier implementation of emutls, before rL257718. Anyway, I did not test on Cygwin, and don't care if rL257984 is in 3.8 or not. Thanks. On Tue, Jan 19, 2016 at

r264164 - [analyzer] Fix typo s/initalize/initialize/

2016-03-23 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Mar 23 11:14:12 2016 New Revision: 264164 URL: http://llvm.org/viewvc/llvm-project?rev=264164=rev Log: [analyzer] Fix typo s/initalize/initialize/ Differential Revision: http://reviews.llvm.org/D18363 Modified:

Re: [PATCH] D18363: Fix typo s/initalize/initialize/

2016-03-23 Thread Chih-Hung Hsieh via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264164: [analyzer] Fix typo s/initalize/initialize/ (authored by chh). Changed prior to commit: http://reviews.llvm.org/D18363?vs=51307=51429#toc Repository: rL LLVM http://reviews.llvm.org/D18363

Re: [PATCH] D19393: Move Checkers.inc to clang/include/.../Checkers

2016-04-25 Thread Chih-Hung Hsieh via cfe-commits
chh marked 2 inline comments as done. chh added a comment. I used "svn mv" to move the file and "svn diff --show-copies-as-adds" to generate the diff. If I didn't use "--show-copies-as-adds", the new file was not included/shown by phabricator at all. Please let me know if there is better way

Re: [PATCH] D19393: Move Checkers.inc to clang/include/.../Checkers

2016-04-22 Thread Chih-Hung Hsieh via cfe-commits
chh updated this revision to Diff 54758. chh added a comment. Also move Checkers.td to clang/include/.../Checkers. http://reviews.llvm.org/D19393 Files: include/clang/CMakeLists.txt include/clang/StaticAnalyzer/Checkers/CMakeLists.txt include/clang/StaticAnalyzer/Checkers/Checkers.td

r267832 - [analyzer] Move Checkers.inc to clang/include/...

2016-04-27 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Apr 27 20:09:09 2016 New Revision: 267832 URL: http://llvm.org/viewvc/llvm-project?rev=267832=rev Log: [analyzer] Move Checkers.inc to clang/include/... Simplify sharing of Checkers.inc with other files like ClangTidy.cpp. Differential Revision:

Re: [PATCH] D19393: Move Checkers.inc to clang/include/.../Checkers

2016-04-27 Thread Chih-Hung Hsieh via cfe-commits
chh closed this revision. chh added a comment. Was submitted in r267832 | chh | 2016-04-27 18:09:09 -0700 (Wed, 27 Apr 2016) http://reviews.llvm.org/D19393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D19393: Move Checkers.inc to clang/include/.../Checkers

2016-04-21 Thread Chih-Hung Hsieh via cfe-commits
chh created this revision. chh added reviewers: srhines, alexfh. chh added a subscriber: cfe-commits. Herald added subscribers: danalbert, tberghammer. https://llvm.org/bugs/show_bug.cgi?id=27355 To compile with other binary output directory structures in build systems like Android. Allow

Re: [PATCH] D19393: Move Checkers.inc to clang/include/.../Checkers

2016-04-21 Thread Chih-Hung Hsieh via cfe-commits
chh added a comment. See dependent change of ClangTidy.cpp in http://reviews.llvm.org/D19393. http://reviews.llvm.org/D19393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Chih-Hung Hsieh via cfe-commits
chh added a comment. This change depends on http://reviews.llvm.org/D19393. http://reviews.llvm.org/D19249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Chih-Hung Hsieh via cfe-commits
chh updated this revision to Diff 54587. http://reviews.llvm.org/D19249 Files: clang-tidy/ClangTidy.cpp Index: clang-tidy/ClangTidy.cpp === --- clang-tidy/ClangTidy.cpp +++ clang-tidy/ClangTidy.cpp @@ -58,7 +58,7 @@ #define

[PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-18 Thread Chih-Hung Hsieh via cfe-commits
chh created this revision. chh added reviewers: srhines, alexfh. chh added a subscriber: cfe-commits. Herald added subscribers: danalbert, tberghammer. https://llvm.org/bugs/show_bug.cgi?id=27355 To compile with other binary output directory structures in build systems like Android.

[clang-tools-extra] r299119 - [clang-tidy] Reuse FileID in getLocation

2017-03-30 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Thu Mar 30 17:09:17 2017 New Revision: 299119 URL: http://llvm.org/viewvc/llvm-project?rev=299119=rev Log: [clang-tidy] Reuse FileID in getLocation One FileID per warning will increase and overflow NextLocalOffset when input file is large with many warnings. Reusing FileID

Re: [clang-tools-extra] r299119 - [clang-tidy] Reuse FileID in getLocation

2017-03-30 Thread Chih-hung Hsieh via cfe-commits
ix', > '--checks=-*,llvm-include-order', '--', '-isystem', > 'C:\\Buildbot\\Slave\\llvm-clang-lld-x86_64-scei-ps4- > windows10pro-fast\\llvm.src\\tools\\clang\\tools\\extra\\ > test\\clang-tidy/Inputs/Headers', '-nostdinc++']' returned non-zero exit > status 255 > > > er

[clang-tools-extra] r299146 - [clang-tidy] Revert D31406 (Reuse FileID in getLocation)

2017-03-30 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Thu Mar 30 20:11:11 2017 New Revision: 299146 URL: http://llvm.org/viewvc/llvm-project?rev=299146=rev Log: [clang-tidy] Revert D31406 (Reuse FileID in getLocation) Somehow the change failed test clang-tidy/llvm-include-order.cpp on Windows platform. Differential Revision:

r299681 - [Basic] getColumnNumber returns location of CR+LF on Windows

2017-04-06 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Thu Apr 6 13:36:50 2017 New Revision: 299681 URL: http://llvm.org/viewvc/llvm-project?rev=299681=rev Log: [Basic] getColumnNumber returns location of CR+LF on Windows When fixing a Clang-Tidy bug in D31406, reuse of FileID enabled the missing highlightRange function. Assertion

[clang-tools-extra] r299700 - [clang-tidy] Reuse FileID in getLocation

2017-04-06 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Thu Apr 6 15:19:26 2017 New Revision: 299700 URL: http://llvm.org/viewvc/llvm-project?rev=299700=rev Log: [clang-tidy] Reuse FileID in getLocation One FileID per warning will increase and overflow NextLocalOffset when input file is large with many warnings. Reusing FileID

[clang-tools-extra] r310858 - [clang-tidy] Add a close-on-exec check on dup() in Android module.

2017-08-14 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Mon Aug 14 10:04:16 2017 New Revision: 310858 URL: http://llvm.org/viewvc/llvm-project?rev=310858=rev Log: [clang-tidy] Add a close-on-exec check on dup() in Android module. Summary: dup() is better to be replaced by fcntl() to avoid file descriptor leakage. Differential

[clang-tools-extra] r310861 - [clang-tidy] Add a close-on-exec check on inotify_init() in Android module.

2017-08-14 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Mon Aug 14 10:25:41 2017 New Revision: 310861 URL: http://llvm.org/viewvc/llvm-project?rev=310861=rev Log: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module. Summary: inotify_init() is better to be replaced by inotify_init1() with IN_CLOEXEC flag to

[clang-tools-extra] r310863 - [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

2017-08-14 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Mon Aug 14 10:45:48 2017 New Revision: 310863 URL: http://llvm.org/viewvc/llvm-project?rev=310863=rev Log: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module. Summary: inotify_init1() is better to set IN_CLOEXEC flag to avoid file descriptor leakage.

r307809 - [clang] buildFixItInsertionLine should use Hints of the same FID and LineNo

2017-07-12 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Jul 12 09:25:40 2017 New Revision: 307809 URL: http://llvm.org/viewvc/llvm-project?rev=307809=rev Log: [clang] buildFixItInsertionLine should use Hints of the same FID and LineNo Fix bug https://bugs.llvm.org/show_bug.cgi?id=33734 Differential Revision:

[clang-tools-extra] r307810 - [clang-tidy] add regression test to performance-unnecessary-value-param

2017-07-12 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Jul 12 09:27:00 2017 New Revision: 307810 URL: http://llvm.org/viewvc/llvm-project?rev=307810=rev Log: [clang-tidy] add regression test to performance-unnecessary-value-param This test shows the problem in https://bugs.llvm.org/show_bug.cgi?id=33734 Differential Revision:

[clang-tools-extra] r311024 - [clang-tidy] Add a close-on-exec check on accept() in Android module.

2017-08-16 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Aug 16 10:18:16 2017 New Revision: 311024 URL: http://llvm.org/viewvc/llvm-project?rev=311024=rev Log: [clang-tidy] Add a close-on-exec check on accept() in Android module. Summary: accept() is better to be replaced by accept4() with SOCK_CLOEXEC flag to avoid file

[clang-tools-extra] r311027 - [clang-tidy] Add a close-on-exec check on accept4() in Android module.

2017-08-16 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Aug 16 10:46:18 2017 New Revision: 311027 URL: http://llvm.org/viewvc/llvm-project?rev=311027=rev Log: [clang-tidy] Add a close-on-exec check on accept4() in Android module. Summary: accept4() is better to set SOCK_CLOEXEC flag to avoid file descriptor leakage.

[clang-tools-extra] r311028 - [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

2017-08-16 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Aug 16 10:53:12 2017 New Revision: 311028 URL: http://llvm.org/viewvc/llvm-project?rev=311028=rev Log: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module. Summary: epoll_create1() is better to set EPOLL_CLOEXEC flag to avoid file descriptor

[clang-tools-extra] r311020 - [clang-tidy] Use CloexecCheck as base class.

2017-08-16 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Aug 16 09:59:26 2017 New Revision: 311020 URL: http://llvm.org/viewvc/llvm-project?rev=311020=rev Log: [clang-tidy] Use CloexecCheck as base class. Summary: Simplify registerMatchers and check functions in CloexecCreatCheck, CloexecSocketCheck, CloexecFopenCheck, and

[clang-tools-extra] r311035 - [clang-tidy] Use const char* to compile with VC cl.exe.

2017-08-16 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Aug 16 12:13:35 2017 New Revision: 311035 URL: http://llvm.org/viewvc/llvm-project?rev=311035=rev Log: [clang-tidy] Use const char* to compile with VC cl.exe. Summary: cl.exe does not accept constexpr char FuncBindingStr[] = ... Differential Revision:

[clang-tools-extra] r311029 - [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

2017-08-16 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Aug 16 11:02:49 2017 New Revision: 311029 URL: http://llvm.org/viewvc/llvm-project?rev=311029=rev Log: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module. Summary: epoll_create() is better to be replaced by epoll_create1() with EPOLL_CLOEXEC flag to

[clang-tools-extra] r311040 - [clang-tidy] Remove unused static variable.

2017-08-16 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Aug 16 14:00:06 2017 New Revision: 311040 URL: http://llvm.org/viewvc/llvm-project?rev=311040=rev Log: [clang-tidy] Remove unused static variable. Differential Revision: https://reviews.llvm.org/D36761 Modified:

Re: [clang-tools-extra] r311020 - [clang-tidy] Use CloexecCheck as base class.

2017-08-16 Thread Chih-hung Hsieh via cfe-commits
ariable 'SOCK_CLOEXEC' > [-Werror,-Wunused-const-variable] > static constexpr const char *SOCK_CLOEXEC = "SOCK_CLOEXEC"; > > Please test with LLVM_ENABLE_WERROR=ON before submitting! > > > On Wed, Aug 16, 2017 at 9:59 AM, Chih-Hung Hsieh via cfe-commits > <cfe-commits@l

r314264 - [clang-format] Adjust space around &/&& of structured bindings

2017-09-26 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Tue Sep 26 17:58:45 2017 New Revision: 314264 URL: http://llvm.org/viewvc/llvm-project?rev=314264=rev Log: [clang-format] Adjust space around &/&& of structured bindings Keep space before or after the &/&& tokens, but not both. For example, auto [x,y] = a; auto &[xr, yr] =

r340421 - [Tooling] Allow -flto flags and filter out -Wa, flags

2018-08-22 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Wed Aug 22 10:13:40 2018 New Revision: 340421 URL: http://llvm.org/viewvc/llvm-project?rev=340421=rev Log: [Tooling] Allow -flto flags and filter out -Wa, flags This change fixes the problem in https://bugs.llvm.org/show_bug.cgi?id=38332 by allowing

Re: [PATCH] D45454: Make __gcov_flush visible outside a shared library

2018-04-11 Thread Chih-hung Hsieh via cfe-commits
Should we have two versions of `__gcov_flush`? One version is visible outside a .so file, we use dlsym to find and call it to dump profile data of .so files, like Android. One version is hidden and must be called from another wrapper function in a .so file. An application that wants to flush .so

r326499 - [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

2018-03-01 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Thu Mar 1 14:26:19 2018 New Revision: 326499 URL: http://llvm.org/viewvc/llvm-project?rev=326499=rev Log: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS Since LLVM r326341, default EmulatedTLS mode is decided in backend according to target triple. Any