[PATCH] D128465: [WIP] Zstandard as a second compression method to LLVM

ckissane created this revision. ckissane added reviewers: phosek, leonardchan. ckissane added a project: LLVM. Herald added subscribers: Enna1, abrachet, wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane updated this revision to Diff 443006. ckissane added a comment. - chore: delete an excess blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 Files:

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane marked 5 inline comments as done. ckissane added a comment. mark some handled comments done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 ___

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

ckissane marked 4 inline comments as done. ckissane added a comment. mark handled comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 ___

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane updated this revision to Diff 443005. ckissane added a comment. - Merge branch 'ckissane.refactor-compression.part-0' of github.com:ckissane/llvm-project into ckissane.refactor-compression.part-0 - Merge branch 'main' into ckissane.refactor-compression.part-0 - compression refactor:

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:27 +static constexpr std::string AlgorithmName = "zlib"; static constexpr int NoCompression = 0; MaskRay wrote: > Is it still used? > > Prefer StringRef if the string is

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane marked 2 inline comments as done. ckissane added a comment. mark outdated comments done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

ckissane updated this revision to Diff 443009. ckissane edited the summary of this revision. ckissane added a comment. - remove crc32 from zlib compression namespace - Merge branch 'ckissane.refactor-compression.part-0' into ckissane.refactor-compression.part-1 - Merge branch

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 443035. ckissane added a comment. start breaking this up further, this is now the add cmake config patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files:

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440296. ckissane added a comment. simplifed codeflow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440288. ckissane added a comment. Fix missing cmake findZstd, remove unused crc32 from compression namespaces and simplify some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane created this revision. Herald added subscribers: hiraditya, arichardson, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added a project: All. ckissane requested

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane created this revision. ckissane added a reviewer: MaskRay. ckissane added a project: LLVM. Herald added subscribers: StephenFan, wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer:

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 440736. ckissane added a comment. up release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 Files: clang-tools-extra/clangd/index/Serialization.cpp

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane marked an inline comment as done. ckissane added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:242 +return error( +"Compressed string table, but compression::serialize is unavailable"); leonardchan wrote: >

[PATCH] D128953: chore: refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain. Changes are as follows: * Relocate the `ll

ckissane created this revision. Herald added subscribers: wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added

[PATCH] D128953: [NFC] refactor compression namespaces making way for a possible introduction of alternatives to zlib compression in the llvm toolchain.

ckissane updated this revision to Diff 441540. ckissane added a comment. - Merge branch 'ckissane.refactor-compression.part-0' of github.com:ckissane/llvm-project into ckissane.refactor-compression.part-0 - Merge branch 'main' into ckissane.refactor-compression.part-0 Repository: rG LLVM

[PATCH] D128754: Refactor LLVM compression namespaces (Part 1: remove crc32)

ckissane updated this revision to Diff 441541. ckissane added a comment. - Merge branch 'ckissane.refactor-compression.part-0' into ckissane.refactor-compression.part-1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 441537. ckissane added a comment. make part 1 after part 0 of refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 Files: llvm/docs/ReleaseNotes.rst

[PATCH] D128754: [llvm] Refactor LLVM compression namespaces (Part 1: remove crc32)

ckissane updated this revision to Diff 441770. ckissane added a comment. updated diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 Files: llvm/docs/ReleaseNotes.rst llvm/include/llvm/Support/Compression.h

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane added inline comments. Comment at: llvm/lib/ProfileData/InstrProf.cpp:154 +OS << ("profile uses " + compression::profile::AlgorithmName + + " compression but the profile reader was built " + "without " + + compression::profile::AlgorithmName + "

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane updated this revision to Diff 441763. ckissane edited the summary of this revision. ckissane added a comment. remove compression namespace alias work CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 Files:

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane updated this revision to Diff 441757. ckissane added a comment. discard debug string changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 Files: clang-tools-extra/clangd/index/Serialization.cpp

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane marked 2 inline comments as done. ckissane added a comment. comments addressed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128953/new/ https://reviews.llvm.org/D128953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128754: [llvm] Refactor LLVM compression namespaces (Part 1: remove crc32)

ckissane marked 3 inline comments as done. ckissane added a comment. addressed comments marked done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 ___

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:49-51 +namespace profile = llvm::compression::zlib; + +namespace serialize = llvm::compression::zlib; phosek wrote: > I think we will need to support dynamically selecting

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf07caf20b9d3: [llvm] cmake config groundwork to have ZSTD in LLVM (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea61750c35a1: [NFC] Refactor llvm::zlib namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443308. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd.0-cmake - added have_zstd to compiler-rt/test/lit.common.cfg.py, clang-tools-extra/clangd/test/lit.cfg.py and several lit.site.cfg.py.in files

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane marked 2 inline comments as done. ckissane added a comment. marked fixed comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG96063bfa9088: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib… (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443310. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd.0-cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files:

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440325. ckissane added a comment. more context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/Serialization.cpp

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440298. ckissane added a comment. fix type for FindZstd cmake usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440321. ckissane added a comment. remove extra struct member Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440343. ckissane added a comment. improve style on ELFWriter::maybeWriteCompression fix typo in comment on zstd value for elf enum CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files:

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440327. ckissane added a comment. format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/Serialization.cpp

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane added a comment. In D128667#3612956 , @MaskRay wrote: > The lld/ change should be separate. And it needs tests. We should have > several tests such as mixed zlib and zstd input, malformed zstd input, > compressed level, etc. `OutputSections`

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440330. ckissane added a comment. format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440323. ckissane added a comment. add more diff context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane added a comment. In D128667#3613222 , @MaskRay wrote: > `llvm-objcopy --decompress-debug-sections clang.zstd clang.zstd.uncompress` > doesn't work. > > % /tmp/out/custom1/bin/llvm-objcopy --decompress-debug-sections clang.zstd >

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ MaskRay wrote: > MaskRay wrote: > > This needs a change in

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443687. ckissane added a comment. clean a space and make accurate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane marked an inline comment as done. ckissane added a comment. Marked name of algorithm comments as done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 ___ cfe-commits mailing list

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 441113. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.refactor-compression-namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440747. ckissane edited the summary of this revision. ckissane added a comment. make it the second stage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane marked an inline comment as done. ckissane added inline comments. Comment at: llvm/unittests/Support/CompressionTest.cpp:68 - 0x414FA339U, - zlib::crc32(StringRef("The quick brown fox jumps over the lazy dog"))); -} leonardchan wrote: > Should

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 441101. ckissane added a comment. add AlgorithmName to compression namespaces CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 Files: clang-tools-extra/clangd/index/Serialization.cpp

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane added a comment. In D128667#3612956 , @MaskRay wrote: > The lld/ change should be separate. And it needs tests. We should have > several tests such as mixed zlib and zstd input, malformed zstd input, > compressed level, etc. `OutputSections`

[PATCH] D128754: Refactor LLVM compression namespaces

ckissane updated this revision to Diff 441107. ckissane added a comment. - feat: refactor llvm compression namespaces - chore: update rel notes to note zlib::crc32 remove - feat: add AlgorithmName to compression namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 441114. ckissane edited the summary of this revision. ckissane added a comment. - feat: add zstd compression - Merge branch 'ckissane.refactor-compression-namespace' into ckissane.add-zstd-compression - Merge branch 'ckissane.refactor-compression-namespace'

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 441102. ckissane added a comment. add AlgorithmName to compression namespaces CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe939bf67e340: [llvm] add zstd to `llvm::compression` namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3646258 , @MaskRay wrote: > In D128465#3646203 , @ckissane > wrote: > >> In D128465#3642997 , @MaskRay >> wrote: >> >>> As I

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 444078. ckissane added a comment. - add zstd tests to CompressionTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files:

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 444044. ckissane added a comment. - make sure LLVM_ENABLE_ZSTD OFF turns into 0 - add zstd compression namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3642997 , @MaskRay wrote: > As I mentioned, the proper approach is to add zstd functionality along with > the CMake change, instead of adding CMake to all llvm-project components > without a way to test them.

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 445615. ckissane added a comment. - move try_find_dependency into it's own file - add newline to end of TryFindDependencyMacro.cmake - clarify comment in TryFindDependencyMacro.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3661049 , @MaskRay wrote: > Does this address the macOS build failure? I believe so! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/

[PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3660714 , @MaskRay wrote: > Instead of marking a differential `[OLD] ` (which may confuse readers whether > this is to be abandoned), you can mark a differential `Request > Reviews`/`Request Changes`. Then it will

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 445623. ckissane added a comment. - remove extra cmake info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt

[PATCH] D130516: [Support] compression classes

ckissane created this revision. ckissane added a reviewer: dblaikie. Herald added subscribers: wenlei, usaxena95, kadircet, arphaman, hiraditya, arichardson, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson. Herald

[PATCH] D130516: [Support] compression classes

ckissane updated this revision to Diff 447469. ckissane added a comment. - format - merge fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clangd/index/Serialization.cpp

[PATCH] D130516: [Support] compression classes

ckissane added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:2003-2004 // consumers will not want its contents. + llvm::compression::CompressionAlgorithm CompressionScheme = + llvm::compression::ZlibCompressionAlgorithm(); +

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. @aemerson can you let me know if https://reviews.llvm.org/D129786 works on MacOS? I am continuing work on that revision because this one has a lot of outdated unrelated history. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3651025 , @aemerson wrote: > I just reverted this in 6e6be5f9504d > because > it seems to have broken macOS builds: > >

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3646601 , @MaskRay wrote: > In D128465#3646561 , @ckissane > wrote: > >> In D128465#3646258 , @MaskRay >> wrote: >> >>> In

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 444374. ckissane added a comment. - Trim CMAKE modifications to minimum needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane marked 6 inline comments as done. ckissane added a comment. Mark handled comments from @MaskRay as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 00. ckissane added a comment. tidy some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt llvm/cmake/config-ix.cmake

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3653051 , @jasonmolenda wrote: > In D128465#3652525 , @ckissane > wrote: > >> In D128465#3651025 , @aemerson >> wrote: >> >>> I

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added inline comments. Comment at: llvm/lib/Support/Compression.cpp:63 __msan_unpoison(CompressedBuffer.data(), CompressedSize); - CompressedBuffer.truncate(CompressedSize); + if (CompressedSize < CompressedBuffer.size()) +

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcef07169ec9f: [llvm] add zstd to `llvm::compression` namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 32. ckissane added a comment. - Merge branch main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt llvm/cmake/config-ix.cmake

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 89. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd - [Support] update zstd interface to use uint8_t * and ArrayRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130516: [Support] compression classes

ckissane added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:2003-2004 // consumers will not want its contents. + llvm::compression::CompressionAlgorithm CompressionScheme = + llvm::compression::ZlibCompressionAlgorithm(); +

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 448473. ckissane added a comment. - fix usage of CompressionAlgorithmFromId Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 448469. ckissane added a comment. - make compression singletons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130516: compression classes

ckissane added a comment. In D130516#3683384 , @dblaikie wrote: > Any chance this could be split up to be more directly comparable to > https://reviews.llvm.org/D130458 ? yes definitely! Doing so now! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D130516: compression classes

ckissane updated this revision to Diff 448176. ckissane added a comment. - fix compression inheritence and some more compression class helpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130516: compression classes

ckissane updated this revision to Diff 448181. ckissane added a comment. - use CompressionScheme->notNone() in InstrProf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130516: [llvm] compression classes

ckissane marked 2 inline comments as done. ckissane added a comment. marked outdated comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 ___

[PATCH] D130516: compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54 + CompressionScheme = + CompressionScheme->when(Compress && DoInstrProfNameCompression) + ->whenSupported(); note the helpers such as

[PATCH] D130516: compression classes

ckissane added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:32 +llvm::compression::CompressionAlgorithm *StringTableCompressionScheme = +new llvm::compression::ZlibCompressionAlgorithm(); + dblaikie wrote: > We're generally

[PATCH] D130667: feat: use compression class for: clang ast serial zstd option + prof data compression variants + zstd elf + ztsd objcopy support

ckissane created this revision. ckissane added reviewers: leonardchan, phosek, dblaikie. Herald added subscribers: Enna1, wenlei, usaxena95, abrachet, kadircet, arphaman, hiraditya, arichardson, mgorny, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht.

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/Support/Compression.cpp:30-32 +ZStdCompressionAlgorithm +*llvm::compression::ZStdCompressionAlgorithm::Instance = +new ZStdCompressionAlgorithm(); dblaikie wrote: > leonardchan wrote: > > Perhaps

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453723. ckissane added a comment. - fix static initialization skip errors in getCompressionSpec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files:

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked an inline comment as done. ckissane added inline comments. Comment at: llvm/include/llvm/Object/Decompressor.h:52-53 uint64_t DecompressedSize; + compression::CompressionSpecRef CompressionScheme = + compression::CompressionSpecRefs::Zlib; };

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453803. ckissane added a comment. - shorten compression related variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files:

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked an inline comment as done. ckissane added a comment. @dblaikie I've handled most of your comments, can you take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453774. ckissane marked an inline comment as done. ckissane added a comment. - CompressionImplementation member on Decompressor instead of Spec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked 2 inline comments as done. ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:38-39 + +CompressionSpecRef getCompressionSpec(uint8_t Kind); +CompressionSpecRef getCompressionSpec(CompressionKind Kind); +CompressionSpecRef

[PATCH] D130516: [llvm] compression classes

ckissane added a comment. @dblaikie @MaskRay I would like it if you could all take another look. In response to @dblaikie 's comments about implementation weight I have greatly simplified the implementation, including removing extra capitalized function overloads (Compress, Decompress), and

[PATCH] D130667: feat: use compression class for: clang ast serial zstd option + prof data compression variants + zstd elf + ztsd objcopy support

ckissane updated this revision to Diff 450172. ckissane added a comment. - Merge branch 'ckissane.compression-class' of github.com:ckissane/llvm-project into ckissane.compression-class - Merge remote-tracking branch 'origin/ckissane.compression-class-simple' into ckissane.compression-class -

[PATCH] D130667: feat: use compression class for: clang ast serial zstd option + prof data compression variants + zstd elf + ztsd objcopy support

ckissane updated this revision to Diff 450174. ckissane added a comment. - Merge remote-tracking branch 'origin/ckissane.compression-class-simple' into ckissane.compression-class - remove erroneous declation of operator StringRef() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450169. ckissane edited the summary of this revision. ckissane added a comment. - fix some nits in Compression.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450176. ckissane added a comment. - move if into switch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clangd/index/Serialization.cpp

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:48-51 + Error decompress(ArrayRef Input, uint8_t *UncompressedBuffer, + size_t ) { +return Decompress(Input, UncompressedBuffer, UncompressedSize); + }

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 449772. ckissane added a comment. - remove uppercase Compress, Decompress Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files:

[PATCH] D130516: [llvm] compression classes

ckissane added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:54-60 + OptionalCompressionScheme = compression::noneIfUnsupported( + (Compress && DoInstrProfNameCompression) ? OptionalCompressionScheme +

  1   2   >