[PATCH] D158496: [WIP][clang][modules] module build daemon initial commit

2023-08-30 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue added a comment. In D158496#4618653 , @dblaikie wrote: > (probably worth linking to the RFC/etc > (https://discourse.llvm.org/t/rfc-modules-build-daemon-build-system-agnostic-support-for-explicitly-built-modules/71524/47) > from the patch

[PATCH] D158496: [WIP][clang][modules] module build daemon initial commit

2023-08-30 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue updated this revision to Diff 554582. cpsughrue edited the summary of this revision. cpsughrue added a comment. Addressed feedback: - Renamed ub_outs() to unbuff_outs() - Fixed spelling errors - Added daemon response to handshake request from clang invocation - Replaced 10 sec sleep

[PATCH] D158496: [WIP][clang][modules] module build daemon initial commit

2023-08-30 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue updated this revision to Diff 554583. cpsughrue added a comment. Remove unnecessary header files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158496/new/ https://reviews.llvm.org/D158496 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D158496: [WIP][clang][modules] module build daemon initial commit

2023-08-22 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue created this revision. cpsughrue added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. cpsughrue requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Initial commit for module build daemon. The title will be

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

2023-07-31 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue updated this revision to Diff 545910. cpsughrue retitled this revision from "[clang][deps] provide support for cc1 command line scanning" to "[clang][deps] add support for dependency scanning with cc1 command line". cpsughrue edited the summary of this revision. cpsughrue added a

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

2023-08-01 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482 + bool Success = false; + if (FinalCommandLine[1] == "-cc1") { +Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr, Is

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

2023-08-03 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue updated this revision to Diff 546861. cpsughrue added a comment. Fixing failed test on Windows CI CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156234/new/ https://reviews.llvm.org/D156234 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

2023-08-01 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue updated this revision to Diff 546182. cpsughrue added a comment. Update llvm-lit test to use split-file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156234/new/ https://reviews.llvm.org/D156234 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

2023-08-01 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482 + bool Success = false; + if (FinalCommandLine[1] == "-cc1") { +Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr,

[PATCH] D156234: [clang][deps] provide support for cc1 command line scanning

2023-07-25 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue updated this revision to Diff 544127. cpsughrue edited the summary of this revision. cpsughrue added a comment. Fixed formatting issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156234/new/ https://reviews.llvm.org/D156234 Files:

[PATCH] D156234: [clang][deps] provide support for cc1 command line scanning

2023-07-25 Thread Connor Sughrue via Phabricator via cfe-commits
cpsughrue created this revision. cpsughrue added reviewers: Bigcheese, jansvoboda11. Herald added a project: All. cpsughrue requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow users to run a dependency scan with a cc1 command line in