Re: [PATCH] D12793: Three new overflow builtins with generic argument types

DavidEGrayson added a comment. Ping. http://reviews.llvm.org/D12793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

DavidEGrayson added a comment. Thanks, John! Looks like it's actually committed in rL251651 . Thanks for handling the volatile pointers correctly (I didn't know I had to do something special for them) and giving me credit in the commit message!

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

DavidEGrayson marked an inline comment as done. DavidEGrayson added a comment. Well, it has been another week. John, I don't have commit access, so can you commit this? Thanks! Let me know if the patch doesn't apply cleanly or any tests fail. http://reviews.llvm.org/D12793

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

DavidEGrayson added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:303 @@ +302,3 @@ +// the first element is the bit width of an integer type and the second element +// is true if the integer type is signed. +static struct WidthAndSignedness Sorry, I need

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

DavidEGrayson updated this revision to Diff 36117. DavidEGrayson added a comment. I changed the patch in two ways: it now returns ExprError() is the third argument is wrong (for consistency with the other argument checking code). I removed an outdated comment for EncompassingIntegerType.

Re: [PATCH] D12793: Three new security overflow builtins with generic argument types

DavidEGrayson added a comment. Hi John. I thought about your comment on line 1601 somewhat carefully and tried to imagine what it would look like. See my inline comment. Also, by the way, do you know if the results of the LLVM intrinsics like `llvm.smul.with.overflow.*` are guaranteed to be

Re: [PATCH] D12793: Three new security overflow builtins with generic argument types

DavidEGrayson removed rL LLVM as the repository for this revision. DavidEGrayson updated this revision to Diff 35592. DavidEGrayson added a comment. I have changed the patch to incorporate most of John McCall's feedback. The only thing I didn't act on was the suggestion to change the names of

Re: [PATCH] D12793: Three new security overflow builtins with generic argument types

DavidEGrayson added a comment. Thanks for looking at this patch, John! I disagreed with your comment about calculating the encompassing type, but I will incorporate everything else and make a new patch tonight or within a few days. Comment at: