ddpagan updated this revision to Diff 382701.
ddpagan added a comment.
Thanks for the review, Alexey.
Made the requested changes except for modifying "used_children". After looking
over other clause classes, for example, OMPNumThreadsClause, we're being
consistent in how we're declaring these.
ddpagan updated this revision to Diff 383428.
ddpagan added a comment.
Thanks for the review, Aaron.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112577/new/
https://reviews.llvm.org/D112577
Files:
clang/include/clang/AST/OpenMPClause.h
ddpagan added inline comments.
Comment at: clang/include/clang/AST/OpenMPClause.h:362-364
+ /// Sets the location of '('.
+ void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; }
+
aaron.ballman wrote:
> ABataev wrote:
> > Also worth to make it private
> I
ddpagan created this revision.
ddpagan added reviewers: ABataev, jdoerfert.
Herald added subscribers: arphaman, guansong, yaxunl.
Herald added a reviewer: aaron.ballman.
ddpagan requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, sstefan1.
Herald added projects:
ddpagan updated this revision to Diff 385692.
ddpagan added a comment.
Fixed build problem (found during build of flang). Added align clause to
simple clause check.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112577/new/
https://reviews.llvm.org/D112577
Files:
ddpagan updated this revision to Diff 385098.
ddpagan added a comment.
Successfully rebased, built, and tested.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112577/new/
https://reviews.llvm.org/D112577
Files:
clang/include/clang/AST/OpenMPClause.h
ddpagan added a comment.
Thanks for reviewing the code, Aaron.
Comment at: clang/lib/Serialization/ASTWriter.cpp:5018
Record.AddStmt(A->getAllocator());
+Record.AddStmt(A->getAlignment());
Record.AddSourceRange(A->getRange());
ddpagan added a comment.
> Is it a new mode from OpenMP 5.2? Or 5.1? Can you add a check for OpenMP
> version, if so?
Thanks for catching this, Alexey. It is new in OpenMP 5.1. I'll add a check for
this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ddpagan abandoned this revision.
ddpagan added a comment.
Change no longer needed per review/comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157197/new/
https://reviews.llvm.org/D157197
___
cfe-commits mailing list
ddpagan added a comment.
Did anything change after the patch was reverted?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158266/new/
https://reviews.llvm.org/D158266
___
cfe-commits mailing list
ddpagan added a comment.
Ok. Thanks for the clarification.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158266/new/
https://reviews.llvm.org/D158266
___
cfe-commits mailing list
ddpagan added a comment.
Is there a github PR associated with this? If yes, what is the PR? If not, one
should be created that includes a fix for the teams loop/loop error issue.
Please add me as a reviewer. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ddpagan added a comment.
How is bind(thread) not working? Runtime issue?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144634/new/
https://reviews.llvm.org/D144634
___
cfe-commits mailing list
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGeb61bde829bc: [OpenMP][CodeGen] Add codegen for combined
loop directives. (authored by ddpagan).
Herald added a project: clang.
Herald added a
ddpagan created this revision.
ddpagan added reviewers: jdoerfert, jhuber6, jplehr.
Herald added subscribers: sunshaoce, guansong, yaxunl.
Herald added a project: All.
ddpagan requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
Update
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7cb9698374ac: [OpenMP][Sema] Fix directive name
modifier/if-clause/target teams loop (authored by ddpagan).
Repository:
rG LLVM Github Monorepo
ddpagan created this revision.
ddpagan added reviewers: ABataev, jdoerfert, ronlieb.
ddpagan added projects: OpenMP, clang.
Herald added subscribers: sunshaoce, guansong, yaxunl.
Herald added a project: All.
ddpagan requested review of this revision.
Herald added subscribers: cfe-commits, jplehr,
ddpagan closed this revision.
ddpagan added a comment.
https://github.com/llvm/llvm-project/commit/b41bf9d8576f44e30726e42d31f760032c08333d
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156326/new/
https://reviews.llvm.org/D156326
ddpagan added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams
ddpagan added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams
ddpagan added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams
ddpagan added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams
ddpagan created this revision.
ddpagan added a reviewer: ABataev.
ddpagan added projects: clang, OpenMP.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
ddpagan requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits,
ddpagan created this revision.
ddpagan added a reviewer: ABataev.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
ddpagan requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, jplehr, sstefan1.
Herald added a project:
ddpagan added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1564
+ // Any if-clause associated with expansion for 'target teams loop' should
+ // apply to target region only. OpenMP 5.2 [3.4, if Clause, Semantics, 15-18]
+ if (S.getDirectiveKind() !=
ddpagan updated this revision to Diff 547515.
ddpagan added a comment.
Added reference to relevant portion of the OpenMP 5.2 specification.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157197/new/
https://reviews.llvm.org/D157197
Files:
clang/lib/CodeGen/CGStmtOpenMP.cpp
ddpagan created this revision.
ddpagan added a reviewer: ABataev.
ddpagan added projects: clang, OpenMP.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
ddpagan requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits,
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf6204724df56: [OpenMP][Docs] Update OpenMP supported
features table (authored by ddpagan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157135/new/
ddpagan updated this revision to Diff 547982.
ddpagan added a comment.
As requested, added reference to OpenMP 5.2 specification that discusses
handling of if clauses with combined/composite directives. Also, improved
comment relating to what was being done and why.
CHANGES SINCE LAST ACTION
ddpagan added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9823
+def err_omp_loop_reduction_clause : Error<
+ "reduction clause not handled with '#pragma omp loop bind(teams)'">;
def warn_break_binds_to_switch : Warning<
Should
30 matches
Mail list logo
