Author: David Spickett
Date: 2019-11-04T10:58:46Z
New Revision: 91167e22eca535025f093335acece573bf19c525
URL:
https://github.com/llvm/llvm-project/commit/91167e22eca535025f093335acece573bf19c525
DIFF:
https://github.com/llvm/llvm-project/commit/91167e22eca535025f093335acece573bf19c525.diff
Author: David Spickett
Date: 2020-10-06T11:34:58+01:00
New Revision: f0a78bdfdc6d56b25e0081884580b3960a3c2429
URL:
https://github.com/llvm/llvm-project/commit/f0a78bdfdc6d56b25e0081884580b3960a3c2429
DIFF:
Author: David Spickett
Date: 2020-09-22T08:53:24+01:00
New Revision: f93514545cd91b132fe987618488b8c1e5388fb0
URL:
https://github.com/llvm/llvm-project/commit/f93514545cd91b132fe987618488b8c1e5388fb0
DIFF:
Author: David Spickett
Date: 2020-09-21T09:21:51+01:00
New Revision: 349af8054218017a2ac0c4bfeddd63e6ccbf4a21
URL:
https://github.com/llvm/llvm-project/commit/349af8054218017a2ac0c4bfeddd63e6ccbf4a21
DIFF:
Author: David Spickett
Date: 2020-07-15T09:37:09+01:00
New Revision: fe5912249efa1ec5e6aa6e565f722dd4d33d1e54
URL:
https://github.com/llvm/llvm-project/commit/fe5912249efa1ec5e6aa6e565f722dd4d33d1e54
DIFF:
c/15950/step_7.txt Please take a look and revert if it
> takes a while to investigate.
>
> Nico
>
> On Mon, Jun 22, 2020 at 4:41 AM David Spickett via cfe-commits
> wrote:
>>
>>
>> Author: David Spickett
>> Date: 2020-06-22T09:41:13+01:00
>> New Revi
Author: David Spickett
Date: 2020-06-22T14:18:54+01:00
New Revision: f570d5810485fa6fb2e1009f795a899d79bd429f
URL:
https://github.com/llvm/llvm-project/commit/f570d5810485fa6fb2e1009f795a899d79bd429f
DIFF:
Author: David Spickett
Date: 2020-06-22T09:41:13+01:00
New Revision: 028571d60843cb87e2637ef69ee09090d4526c62
URL:
https://github.com/llvm/llvm-project/commit/028571d60843cb87e2637ef69ee09090d4526c62
DIFF:
Author: David Spickett
Date: 2020-06-25T09:33:43+01:00
New Revision: d6efc9811646edbfe13f06c2676fb469f1c155b1
URL:
https://github.com/llvm/llvm-project/commit/d6efc9811646edbfe13f06c2676fb469f1c155b1
DIFF:
Author: David Spickett
Date: 2020-11-30T10:00:49Z
New Revision: b5fbc60e4de45f2b56331281a706b78ff52bd286
URL:
https://github.com/llvm/llvm-project/commit/b5fbc60e4de45f2b56331281a706b78ff52bd286
DIFF:
https://github.com/llvm/llvm-project/commit/b5fbc60e4de45f2b56331281a706b78ff52bd286.diff
Author: David Spickett
Date: 2020-12-21T16:47:23Z
New Revision: 9a93f95fce91fb4616cee0f307b564b253789282
URL:
https://github.com/llvm/llvm-project/commit/9a93f95fce91fb4616cee0f307b564b253789282
DIFF:
https://github.com/llvm/llvm-project/commit/9a93f95fce91fb4616cee0f307b564b253789282.diff
Author: David Spickett
Date: 2020-11-06T14:13:46Z
New Revision: aecd52b97bb457aaecb0bcb658e6ea684e869de9
URL:
https://github.com/llvm/llvm-project/commit/aecd52b97bb457aaecb0bcb658e6ea684e869de9
DIFF:
https://github.com/llvm/llvm-project/commit/aecd52b97bb457aaecb0bcb658e6ea684e869de9.diff
Author: David Spickett
Date: 2021-02-04T16:36:15Z
New Revision: 1d51c699b9e2ebc5bcfdbe85c74cc871426333d4
URL:
https://github.com/llvm/llvm-project/commit/1d51c699b9e2ebc5bcfdbe85c74cc871426333d4
DIFF:
https://github.com/llvm/llvm-project/commit/1d51c699b9e2ebc5bcfdbe85c74cc871426333d4.diff
Author: David Spickett
Date: 2021-06-10T10:11:17Z
New Revision: 64de8763aa7cabc5aee4312ae2f9a68d8fd10bfa
URL:
https://github.com/llvm/llvm-project/commit/64de8763aa7cabc5aee4312ae2f9a68d8fd10bfa
DIFF:
https://github.com/llvm/llvm-project/commit/64de8763aa7cabc5aee4312ae2f9a68d8fd10bfa.diff
Author: David Spickett
Date: 2021-06-10T09:45:10Z
New Revision: 7fb1f62d12c67d4d3193c84687f0d1267d11ba99
URL:
https://github.com/llvm/llvm-project/commit/7fb1f62d12c67d4d3193c84687f0d1267d11ba99
DIFF:
https://github.com/llvm/llvm-project/commit/7fb1f62d12c67d4d3193c84687f0d1267d11ba99.diff
Author: David Spickett
Date: 2021-05-06T14:16:43Z
New Revision: e4b790c5e3653053819182a67c593bc65de860ac
URL:
https://github.com/llvm/llvm-project/commit/e4b790c5e3653053819182a67c593bc65de860ac
DIFF:
https://github.com/llvm/llvm-project/commit/e4b790c5e3653053819182a67c593bc65de860ac.diff
Author: David Spickett
Date: 2021-05-14T08:22:57Z
New Revision: 2db090a2ebd76f120bfae4fbe4b7241667aa585e
URL:
https://github.com/llvm/llvm-project/commit/2db090a2ebd76f120bfae4fbe4b7241667aa585e
DIFF:
https://github.com/llvm/llvm-project/commit/2db090a2ebd76f120bfae4fbe4b7241667aa585e.diff
Author: David Spickett
Date: 2021-05-25T14:53:07Z
New Revision: 8427053f81922b0665a1ad3f561c09f8c0b8dd30
URL:
https://github.com/llvm/llvm-project/commit/8427053f81922b0665a1ad3f561c09f8c0b8dd30
DIFF:
https://github.com/llvm/llvm-project/commit/8427053f81922b0665a1ad3f561c09f8c0b8dd30.diff
Author: David Spickett
Date: 2021-06-03T08:55:44Z
New Revision: f4543dce5db585f2b37f39145ad3fa34b6c75b0e
URL:
https://github.com/llvm/llvm-project/commit/f4543dce5db585f2b37f39145ad3fa34b6c75b0e
DIFF:
https://github.com/llvm/llvm-project/commit/f4543dce5db585f2b37f39145ad3fa34b6c75b0e.diff
Author: David Spickett
Date: 2021-06-28T08:32:36Z
New Revision: a49855316251aaa3cfe62b797b5650ae55b09378
URL:
https://github.com/llvm/llvm-project/commit/a49855316251aaa3cfe62b797b5650ae55b09378
DIFF:
https://github.com/llvm/llvm-project/commit/a49855316251aaa3cfe62b797b5650ae55b09378.diff
Author: David Spickett
Date: 2021-03-11T10:25:16Z
New Revision: 87358dba8182b4ee2d9eedabb8afb319b59a322b
URL:
https://github.com/llvm/llvm-project/commit/87358dba8182b4ee2d9eedabb8afb319b59a322b
DIFF:
https://github.com/llvm/llvm-project/commit/87358dba8182b4ee2d9eedabb8afb319b59a322b.diff
Author: David Spickett
Date: 2021-03-05T13:28:51Z
New Revision: 9c0069d836b326f3ae0b92a8f095b0707a944ed0
URL:
https://github.com/llvm/llvm-project/commit/9c0069d836b326f3ae0b92a8f095b0707a944ed0
DIFF:
https://github.com/llvm/llvm-project/commit/9c0069d836b326f3ae0b92a8f095b0707a944ed0.diff
Author: Ryan Santhiraraja
Date: 2021-02-22T12:09:20Z
New Revision: 2c25efcbd322c58b62e592a8265ef83803f0e7b9
URL:
https://github.com/llvm/llvm-project/commit/2c25efcbd322c58b62e592a8265ef83803f0e7b9
DIFF:
https://github.com/llvm/llvm-project/commit/2c25efcbd322c58b62e592a8265ef83803f0e7b9.diff
Author: David Spickett
Date: 2021-08-13T16:25:32+01:00
New Revision: 98eb348eb38aaba63aa149000c97d27a7e5190c3
URL:
https://github.com/llvm/llvm-project/commit/98eb348eb38aaba63aa149000c97d27a7e5190c3
DIFF:
Author: David Spickett
Date: 2021-12-15T16:40:26Z
New Revision: 09036be1266355e73775c5c949a69a25312ee18a
URL:
https://github.com/llvm/llvm-project/commit/09036be1266355e73775c5c949a69a25312ee18a
DIFF:
https://github.com/llvm/llvm-project/commit/09036be1266355e73775c5c949a69a25312ee18a.diff
Author: David Spickett
Date: 2022-03-23T09:51:02Z
New Revision: eb5ecbbcbb6ce38e29237ab5d17156fcb2e96e74
URL:
https://github.com/llvm/llvm-project/commit/eb5ecbbcbb6ce38e29237ab5d17156fcb2e96e74
DIFF:
https://github.com/llvm/llvm-project/commit/eb5ecbbcbb6ce38e29237ab5d17156fcb2e96e74.diff
Author: David Spickett
Date: 2022-03-23T10:43:20Z
New Revision: edb7ba714acba1d18a20d9f4986d2e38aee1d109
URL:
https://github.com/llvm/llvm-project/commit/edb7ba714acba1d18a20d9f4986d2e38aee1d109
DIFF:
https://github.com/llvm/llvm-project/commit/edb7ba714acba1d18a20d9f4986d2e38aee1d109.diff
Author: David Spickett
Date: 2022-03-23T11:43:43Z
New Revision: c3b98194df5572bc9b33024b48457538a7213b4c
URL:
https://github.com/llvm/llvm-project/commit/c3b98194df5572bc9b33024b48457538a7213b4c
DIFF:
https://github.com/llvm/llvm-project/commit/c3b98194df5572bc9b33024b48457538a7213b4c.diff
Author: David Spickett
Date: 2022-02-03T10:08:20Z
New Revision: d15e7dd1238df20e9c09cc91930f716e0d3d5b05
URL:
https://github.com/llvm/llvm-project/commit/d15e7dd1238df20e9c09cc91930f716e0d3d5b05
DIFF:
https://github.com/llvm/llvm-project/commit/d15e7dd1238df20e9c09cc91930f716e0d3d5b05.diff
Author: David Spickett
Date: 2022-04-11T13:42:24Z
New Revision: 55b6a3186cfa8b85a1defe05861d73f447e4c990
URL:
https://github.com/llvm/llvm-project/commit/55b6a3186cfa8b85a1defe05861d73f447e4c990
DIFF:
https://github.com/llvm/llvm-project/commit/55b6a3186cfa8b85a1defe05861d73f447e4c990.diff
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/65466:
This follows the RISC-V work done in 4b40ced4e5ba10b841516b3970e7699ba8ded572.
This uses AArch64's target parser instead. We just list the names, without the
"+" on them, which matches RISC-V's format.
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
I've generalised this a bit but mostly kept to what RISC-V did. If we think
it's time to completely generalise it then I'll figure that out.
Mostly want to know people are on board with supporting this for AArch64 first.
https://github.com/llvm/llvm-project/pull/65466
DavidSpickett wrote:
With just the bitvector change this is fine.
I don't disagree with splitting the test files but it should be in its own
commit/PR.
https://github.com/llvm/llvm-project/pull/65423
___
cfe-commits mailing list
DavidSpickett wrote:
@eddyz87 ping!
https://github.com/llvm/llvm-project/pull/65251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12,6 +12,7 @@
//===--===//
#include "llvm/TargetParser/AArch64TargetParser.h"
+#include "llvm/Support/raw_ostream.h"
DavidSpickett wrote:
clang-format is putting the "main module"
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: David Spickett
Date: 2023-09-11T07:50:52Z
New Revision: 2d670fab4c099a3c8e7c257a100f5a34df598ac4
URL:
https://github.com/llvm/llvm-project/commit/2d670fab4c099a3c8e7c257a100f5a34df598ac4
DIFF:
https://github.com/llvm/llvm-project/commit/2d670fab4c099a3c8e7c257a100f5a34df598ac4.diff
Author: David Spickett
Date: 2023-09-01T14:53:41Z
New Revision: 7c6544333eba516c1b569fb74288bbfe9ca54c1f
URL:
https://github.com/llvm/llvm-project/commit/7c6544333eba516c1b569fb74288bbfe9ca54c1f
DIFF:
https://github.com/llvm/llvm-project/commit/7c6544333eba516c1b569fb74288bbfe9ca54c1f.diff
Author: David Spickett
Date: 2023-09-01T14:55:11Z
New Revision: ef5219c18b252ac36815d5f322acab704259df08
URL:
https://github.com/llvm/llvm-project/commit/ef5219c18b252ac36815d5f322acab704259df08
DIFF:
https://github.com/llvm/llvm-project/commit/ef5219c18b252ac36815d5f322acab704259df08.diff
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/66083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/66083:
```
$ ./bin/clang -target arm-linux-gnueabihf --print-supported-extensions
<...>
All available -march extensions for ARM
crc
crypto
sha2
aes
dotprod
<...>
```
This
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/66083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/66083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Maybe I just need to learn how to use Github, but did half the document
disappear?
I see a reference to the attacks section `See the section on `Attacks on
pointer authentication`_ for more information.` but the section is gone from
the diff even in a private window.
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/65466:
>From f0157ffb412fd2d6d4aa4a294b631f74e5638878 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 6 Sep 2023 10:15:27 +
Subject: [PATCH 1/2] [clang][AArch64] Add --print-supported-extensions
DavidSpickett wrote:
I'm going to assume this is fine given that the test passes. We can always
revert it if that is not the case.
https://github.com/llvm/llvm-project/pull/65251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/65251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/65251:
2 of them were missing the ":" on the end.
Adding them broke the test so I had to add a new prefix just for the warning
runs only.
I manually checked the first RUNs and there is no warning emitted, as
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,56 @@
+; REQUIRES: arm-registered-target
+; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m85 -mfloat-abi=hard
-save-temps=obj -S -o - %s | FileCheck %s
+; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m55 -mfloat-abi=hard
-save-temps=obj -S -o - %s | FileCheck
@@ -0,0 +1,56 @@
+; REQUIRES: arm-registered-target
+; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m85 -mfloat-abi=hard
-save-temps=obj -S -o - %s | FileCheck %s
+; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m55 -mfloat-abi=hard
-save-temps=obj -S -o - %s | FileCheck
DavidSpickett wrote:
I think the commit title would make more sense at a glance if it was saying
what is being done instead of what's being fixed. How about:
```
[llvm][ARM] Emit MVE .arch_extension after .fpu directive if it does not
include MVE features
```
Then the commit message is fine as
@@ -0,0 +1,56 @@
+; REQUIRES: arm-registered-target
+; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m85 -mfloat-abi=hard
-save-temps=obj -S -o - %s | FileCheck %s
+; RUN: %clang --target=arm-none-eabi -mcpu=cortex-m55 -mfloat-abi=hard
-save-temps=obj -S -o - %s | FileCheck
@@ -1016,7 +1017,8 @@ TEST(TargetParserTest, ARMPrintSupportedExtensions) {
outs().flush();
testing::internal::CaptureStdout();
- ARM::PrintSupportedExtensions();
+ std::map EmptyMap;
DavidSpickett wrote:
Yeah that's fine. All it should check is that
@@ -600,11 +601,17 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
+void ARM::PrintSupportedExtensions(std::map llvmDescMap)
{
outs() << "All available -march
@@ -210,24 +210,33 @@ static void verifyTables() {
#endif
}
-void llvm::riscvExtensionsHelp() {
+void llvm::riscvExtensionsHelp(std::map llvmDescMap) {
+
outs() << "All available -march extensions for RISC-V\n\n";
- outs() << '\t' << left_justify("Name", 20) <<
@@ -600,11 +601,17 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
+void ARM::PrintSupportedExtensions(std::map llvmDescMap)
{
outs() << "All available -march
https://github.com/DavidSpickett requested changes to this pull request.
This looks really nice. Two overall things:
Now that ARM and AArch64 print more than just names, they should have column
headers like RISC-V does. Name / Description
The clang test case
@@ -210,24 +210,33 @@ static void verifyTables() {
#endif
}
-void llvm::riscvExtensionsHelp() {
+void llvm::riscvExtensionsHelp(std::map llvmDescMap) {
+
outs() << "All available -march extensions for RISC-V\n\n";
- outs() << '\t' << left_justify("Name", 20) <<
@@ -600,11 +601,17 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
+void ARM::PrintSupportedExtensions(std::map llvmDescMap)
{
outs() << "All available -march
@@ -1016,7 +1017,8 @@ TEST(TargetParserTest, ARMPrintSupportedExtensions) {
outs().flush();
testing::internal::CaptureStdout();
- ARM::PrintSupportedExtensions();
+ std::map EmptyMap;
DavidSpickett wrote:
All tests for this should include at least 1
@@ -198,13 +199,21 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
@@ -198,13 +199,21 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
@@ -600,11 +601,17 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
+void ARM::PrintSupportedExtensions(std::map llvmDescMap)
{
outs() << "All available -march
@@ -11,11 +11,13 @@
//
//===--===//
-#include "llvm/TargetParser/AArch64TargetParser.h"
+#include "llvm/Support/Error.h"
DavidSpickett wrote:
Why do we need to include Support/Error now?
@@ -11,11 +11,13 @@
//
//===--===//
-#include "llvm/TargetParser/AArch64TargetParser.h"
+#include "llvm/Support/Error.h"
#include "llvm/Support/raw_ostream.h"
+#include
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Looks good to me, thanks for working on this.
I'm not sure if you'll have permissions to click the merge button but if you
do, go ahead. Please remember to edit the final commit message to remove the
links to the output files.
Author: David Spickett
Date: 2023-09-21T08:42:57Z
New Revision: 604a231881a0e8f204a6d3337bfa3e797e911e34
URL:
https://github.com/llvm/llvm-project/commit/604a231881a0e8f204a6d3337bfa3e797e911e34
DIFF:
https://github.com/llvm/llvm-project/commit/604a231881a0e8f204a6d3337bfa3e797e911e34.diff
@@ -4,14 +4,17 @@
// RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \
// RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix
AARCH64 %}
// AARCH64: All available -march extensions for AArch64
+// AARCH64: Name
@@ -600,11 +601,16 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
- outs() << "All available -march extensions for ARM\n\n";
+void
@@ -22,7 +23,8 @@ struct RISCVExtensionInfo {
unsigned MinorVersion;
};
-void riscvExtensionsHelp();
+void getAllExtensions(StringMap );
DavidSpickett wrote:
This can go if you just set the description of only one extension in the tests.
@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) {
TEST(TargetParserTest, ARMPrintSupportedExtensions) {
std::string expected = "All available -march extensions for ARM\n\n"
- "\tcrc\n\tcrypto\n\tsha2";
+ "
1 - 100 of 328 matches
Mail list logo
