r251691 - Update debug-info-scope test to remove "FIXME", which is fixed in r251689

Author: dehao Date: Fri Oct 30 00:08:43 2015 New Revision: 251691 URL: http://llvm.org/viewvc/llvm-project?rev=251691=rev Log: Update debug-info-scope test to remove "FIXME", which is fixed in r251689 Modified: cfe/trunk/test/CodeGen/debug-info-scope.c Modified:

r248869 - Fix the sample profile format that breaks in test http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/505

Author: dehao Date: Tue Sep 29 20:03:10 2015 New Revision: 248869 URL: http://llvm.org/viewvc/llvm-project?rev=248869=rev Log: Fix the sample profile format that breaks in test http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/505 http://reviews.llvm.org/D13145

Re: [PATCH] D14848: Add -disable-llvm-passes for frontend debug info tests.

danielcdh marked an inline comment as done. danielcdh added a comment. http://reviews.llvm.org/D14848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r253595 - Update clang tests to accomendate discriminator changes.

Author: dehao Date: Thu Nov 19 13:53:16 2015 New Revision: 253595 URL: http://llvm.org/viewvc/llvm-project?rev=253595=rev Log: Update clang tests to accomendate discriminator changes. Summary: The discriminator change in http://reviews.llvm.org/D14738 will fail these clang tests. Update the

r271010 - Add instcombine pass if sampleprofile pass is enabled.

Author: dehao Date: Fri May 27 11:14:35 2016 New Revision: 271010 URL: http://llvm.org/viewvc/llvm-project?rev=271010=rev Log: Add instcombine pass if sampleprofile pass is enabled. Summary: Sample profile pass need to have instcombine pass. A related change is http://reviews.llvm.org/D17742.

r273298 - Invoke PruneEH pass before Sample Profile pass.

Author: dehao Date: Tue Jun 21 14:16:41 2016 New Revision: 273298 URL: http://llvm.org/viewvc/llvm-project?rev=273298=rev Log: Invoke PruneEH pass before Sample Profile pass. Summary: We need to call PruneEH pass before AutoFDO pass so that some EH-related calls can get inlined in Sample

r273606 - Invoke simplifycfg and sroa before instcombine.

Author: dehao Date: Thu Jun 23 15:13:10 2016 New Revision: 273606 URL: http://llvm.org/viewvc/llvm-project?rev=273606=rev Log: Invoke simplifycfg and sroa before instcombine. Summary: InstCombine needs to be performed after simplifycfg and sroa, otherwise it may make bad optimization decisions.

r293834 - Change debug-info-for-profiling from a TargetOption to a function attribute.

Author: dehao Date: Wed Feb 1 16:45:21 2017 New Revision: 293834 URL: http://llvm.org/viewvc/llvm-project?rev=293834=rev Log: Change debug-info-for-profiling from a TargetOption to a function attribute. Summary: cfe change for https://reviews.llvm.org/D29203 Reviewers: echristo, dblaikie

r295764 - Only enable AddDiscriminator pass when -fdebug-info-for-profiling is true

Author: dehao Date: Tue Feb 21 14:36:21 2017 New Revision: 295764 URL: http://llvm.org/viewvc/llvm-project?rev=295764=rev Log: Only enable AddDiscriminator pass when -fdebug-info-for-profiling is true Summary: AddDiscriminator pass is only useful for sample pgo. This patch restricts

r292458 - Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection

Author: dehao Date: Wed Jan 18 18:44:21 2017 New Revision: 292458 URL: http://llvm.org/viewvc/llvm-project?rev=292458=rev Log: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection Summary: SamplePGO uses profile with debug info to collect profile. Unlike the

r281509 - Convert finite to builtin

Author: dehao Date: Wed Sep 14 12:34:14 2016 New Revision: 281509 URL: http://llvm.org/viewvc/llvm-project?rev=281509=rev Log: Convert finite to builtin Summary: This patch converts finite/__finite to builtin functions so that it will be inlined by compiler. Reviewers: hfinkel, davidxl,

r281910 - Remove InstructionCombining and its related pass from sample pgo passes as we can handle "invoke" correctly.

Author: dehao Date: Mon Sep 19 11:02:52 2016 New Revision: 281910 URL: http://llvm.org/viewvc/llvm-project?rev=281910=rev Log: Remove InstructionCombining and its related pass from sample pgo passes as we can handle "invoke" correctly. Summary: We previously relies on InstructionCombining pass

r289670 - Create SampleProfileLoader pass in llvm instead of clang

Author: dehao Date: Wed Dec 14 10:49:34 2016 New Revision: 289670 URL: http://llvm.org/viewvc/llvm-project?rev=289670=rev Log: Create SampleProfileLoader pass in llvm instead of clang Summary: We used to create SampleProfileLoader pass in clang. This makes LTO/ThinLTO unable to add this pass in

r289715 - Create SampleProfileLoader pass in llvm instead of clang

Author: dehao Date: Wed Dec 14 15:41:04 2016 New Revision: 289715 URL: http://llvm.org/viewvc/llvm-project?rev=289715=rev Log: Create SampleProfileLoader pass in llvm instead of clang Summary: We used to create SampleProfileLoader pass in clang. This makes LTO/ThinLTO unable to add this pass in

r289675 - revert r289670 which breaks bot.

Author: dehao Date: Wed Dec 14 11:22:53 2016 New Revision: 289675 URL: http://llvm.org/viewvc/llvm-project?rev=289675=rev Log: revert r289670 which breaks bot. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

Re: [PATCH] D28588: Pass -fprofile-sample-use to lto backends.

On Thu, Jan 12, 2017 at 3:27 PM, Teresa Johnson via Phabricator < revi...@reviews.llvm.org> wrote: > tejohnson added a comment. > > In https://reviews.llvm.org/D28588#644489, @danielcdh wrote: > > > Thanks for the prompt response. > > > > But looks like several other tests also has "-mllvm >

r291870 - Pass -fprofile-sample-use to lto backends.

Author: dehao Date: Thu Jan 12 18:51:55 2017 New Revision: 291870 URL: http://llvm.org/viewvc/llvm-project?rev=291870=rev Log: Pass -fprofile-sample-use to lto backends. Summary: LTO backend will not invoke SampleProfileLoader pass even if -fprofile-sample-use is specified. This patch passes

r291874 - Temporarily revert the test change in 291870, which is broken in certain buildbots.

Author: dehao Date: Thu Jan 12 19:09:43 2017 New Revision: 291874 URL: http://llvm.org/viewvc/llvm-project?rev=291874=rev Log: Temporarily revert the test change in 291870, which is broken in certain buildbots. Modified: cfe/trunk/test/CodeGen/thinlto_backend.ll Modified:

r291774 - Pass -fprofile-sample-use to lto backends.

Author: dehao Date: Thu Jan 12 10:29:25 2017 New Revision: 291774 URL: http://llvm.org/viewvc/llvm-project?rev=291774=rev Log: Pass -fprofile-sample-use to lto backends. Summary: LTO backend will not invoke SampleProfileLoader pass even if -fprofile-sample-use is specified. This patch passes

r291775 - Revert r291774 which caused buildbot failure.

Author: dehao Date: Thu Jan 12 10:56:18 2017 New Revision: 291775 URL: http://llvm.org/viewvc/llvm-project?rev=291775=rev Log: Revert r291774 which caused buildbot failure. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp cfe/trunk/test/CodeGen/thinlto_backend.ll Modified:

r290919 - Add -plugin-opt=sample-profile for thinLTO build.

Author: dehao Date: Tue Jan 3 18:33:23 2017 New Revision: 290919 URL: http://llvm.org/viewvc/llvm-project?rev=290919=rev Log: Add -plugin-opt=sample-profile for thinLTO build. Summary: ThinLTO needs to pass down the sample profile file path to linker. Reviewers: tejohnson, davidxl, mehdi_amini

r298647 - Update the SamplePGO test to verify that unroll/icp is not invoked in thinlto compile phase.

Author: dehao Date: Thu Mar 23 16:20:17 2017 New Revision: 298647 URL: http://llvm.org/viewvc/llvm-project?rev=298647=rev Log: Update the SamplePGO test to verify that unroll/icp is not invoked in thinlto compile phase. Summary: This is the test added for https://reviews.llvm.org/D31217

r298429 - Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase.

Author: dehao Date: Tue Mar 21 14:55:46 2017 New Revision: 298429 URL: http://llvm.org/viewvc/llvm-project?rev=298429=rev Log: Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase. Summary: Because SamplePGO passes will be invoked twice in ThinLTO build: once at

r298446 - Add support for -fno-auto-profile and -fno-profile-sample-use

Author: dehao Date: Tue Mar 21 16:40:53 2017 New Revision: 298446 URL: http://llvm.org/viewvc/llvm-project?rev=298446=rev Log: Add support for -fno-auto-profile and -fno-profile-sample-use Summary: We need to be able to disable samplepgo for specific files by supporting -fno-auto-profile and

r307449 - Revert r307445 as it breaks on certain platforms.

Author: dehao Date: Fri Jul 7 15:40:37 2017 New Revision: 307449 URL: http://llvm.org/viewvc/llvm-project?rev=307449=rev Log: Revert r307445 as it breaks on certain platforms. Modified: cfe/trunk/test/CodeGen/Inputs/pgo-sample.prof cfe/trunk/test/CodeGen/pgo-sample.c Modified:

r307438 - Enable the new PM + SamlePGO + ThinLTO testing.

Author: dehao Date: Fri Jul 7 13:53:17 2017 New Revision: 307438 URL: http://llvm.org/viewvc/llvm-project?rev=307438=rev Log: Enable the new PM + SamlePGO + ThinLTO testing. Summary: This patch should be enabled after https://reviews.llvm.org/D34895 Reviewers: chandlerc, tejohnson, davidxl

r307445 - Add sample PGO integration test to cover profile annotation and inlining.

Author: dehao Date: Fri Jul 7 15:01:47 2017 New Revision: 307445 URL: http://llvm.org/viewvc/llvm-project?rev=307445=rev Log: Add sample PGO integration test to cover profile annotation and inlining. Summary: The patch makes the integration test cover major sample PGO components. Reviewers:

Re: [PATCH] D34896: Enable the new PM + SamlePGO + ThinLTO testing.

This test was originally added in https://reviews.llvm.org/D34721 with clang change. It's kind of dup of the previous test (-check-prefix=SAMPLEPGO) in terms of testing the clang bits. But we want to make sure the new PM has the expected behavior. I guess it would be acceptable to remove one of

r307584 - Use DenseMap instead std::map for GVSummaryMapTy

Author: dehao Date: Mon Jul 10 13:31:37 2017 New Revision: 307584 URL: http://llvm.org/viewvc/llvm-project?rev=307584=rev Log: Use DenseMap instead std::map for GVSummaryMapTy Summary: Frontend change for https://reviews.llvm.org/D35148 Reviewers: tejohnson Reviewed By: tejohnson Subscribers:

r309282 - Make new PM honor -fdebug-info-for-profiling (clang side)

Author: dehao Date: Thu Jul 27 08:29:53 2017 New Revision: 309282 URL: http://llvm.org/viewvc/llvm-project?rev=309282=rev Log: Make new PM honor -fdebug-info-for-profiling (clang side) Summary: The new PM needs to invoke add-discriminator pass when building with -fdebug-info-for-profiling.

r306764 - [PM] Add support for sample PGO in the new pass manager (clang-side)

Author: dehao Date: Thu Jun 29 16:33:13 2017 New Revision: 306764 URL: http://llvm.org/viewvc/llvm-project?rev=306764=rev Log: [PM] Add support for sample PGO in the new pass manager (clang-side) Summary: This implements the clang bits of https://reviews.llvm.org/D34720, and add corresponding

r306430 - Update test for enabling ICP for AutoFDO.

Author: dehao Date: Tue Jun 27 10:23:42 2017 New Revision: 306430 URL: http://llvm.org/viewvc/llvm-project?rev=306430=rev Log: Update test for enabling ICP for AutoFDO. Summary: This is the test update patch for https://reviews.llvm.org/D34662 Reviewers: davidxl Reviewed By: davidxl

Re: r292458 - Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection

Thanks, Dehao > > On Wed, Jan 18, 2017 at 4:44 PM, Dehao Chen via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: dehao > > Date: Wed Jan 18 18:44:21 2017 > > New Revision: 292458 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=292458=rev &g

r306434 - Update the test comment to clarify the intention of the test.

Author: dehao Date: Tue Jun 27 10:45:40 2017 New Revision: 306434 URL: http://llvm.org/viewvc/llvm-project?rev=306434=rev Log: Update the test comment to clarify the intention of the test. Modified: cfe/trunk/test/CodeGen/pgo-sample-thinlto-summary.c Modified:

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

What's the issue? Build breaking? Performance regression? It's not clear from the limit info in this thread... Dehao On Thu, May 18, 2017 at 1:02 PM, Vitaly Buka wrote: > Local build: r302937 no issue, r302938 has issue. > > On Thu, May 18, 2017 at 7:23 AM Dehao Chen

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

My understanding is that r302938 makes clang generate incorrect code (clang itself), which lead to unexpected clang behavior. Is it correct? If yes, how can I reproduce this issue so that I can try to triage/fix the problem? Thanks, Dehao On Thu, May 18, 2017 at 1:22 PM, Richard Smith

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

Could you give some context on how r302938 is related to this? Thanks, Dehao On Wed, May 17, 2017 at 11:14 PM, Vitaly Buka wrote: > +Dehao Chen > it started from r302938 > > On Wed, May 17, 2017 at 8:09 PM Jordan Rose via cfe-commits < >

r311707 - Expose -mllvm -accurate-sample-profile to clang.

Author: dehao Date: Thu Aug 24 14:37:33 2017 New Revision: 311707 URL: http://llvm.org/viewvc/llvm-project?rev=311707=rev Log: Expose -mllvm -accurate-sample-profile to clang. Summary: With accurate sample profile, we can do more aggressive size optimization. For some size-critical application,