[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Splits fuchsia-default-arguments check into two checks. fuchsia-default-arguments-calls warns if a function or

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran updated this revision to Diff 201375. DiegoAstiazaran added a comment. Reduces lines to 80 characters. The files have been also formatted by clang-format. Types are replaced by auto in declarations where the type is spelled in cast. CHANGES SINCE LAST ACTION

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran updated this revision to Diff 201799. DiegoAstiazaran added a comment. Fix patch submitted. Patch submitted with the last update was a new commit, functional changes were not included in that diff. New patch includes functional changes (first patch) and format changes (second

[PATCH] D62970: [clang-doc] De-duplicate comments

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. De-duplicate comments in reduce function. When two files include the same header file, this file's content is mapped twice and

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran updated this revision to Diff 203447. DiegoAstiazaran added a comment. Complete documentation in ReleaseNotes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62437/new/ https://reviews.llvm.org/D62437 Files: clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. In serialize::parseBases(...), when a base record is a template specialization, the

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

DiegoAstiazaran updated this revision to Diff 204146. DiegoAstiazaran retitled this revision from "[clang-doc] De-duplicate comments" to "[clang-doc] De-duplicate comments and locations". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added a

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

DiegoAstiazaran updated this revision to Diff 205169. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Specify type in declarations where //auto// keyword was used. Initialize pointer to nullptr in empty declaration. CHANGES SINCE LAST ACTION

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:244 // interface). + bool IsTypeDef = false; // Indicates if record was declared

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

DiegoAstiazaran updated this revision to Diff 206317. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added a subscriber: ormris. Path name generation was moved to serialization phase as @juliehockett suggested. Empty string declaration fixed. Removed

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran updated this revision to Diff 206502. DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Removed rendering of some CommentInfo kinds to reduce review load. Removed all , , and tags; they are not

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran marked 12 inline comments as done. DiegoAstiazaran added a comment. A couple of comments that were related to the function writeDescription() were marked as done since most of that function was deleted. Rendering of the other kinds of CommentInfos will be handled later.

[PATCH] D63666: [clang-doc] Add templates to HTML generator

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: mgorny. Templates are added to create a stuctured HTML file. Commands in doxygen comments are still not

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. tags are added for the parents of records. The link redirects to the parent's info

[PATCH] D63666: [clang-doc] Add templates to HTML generator

DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:307-308 + + + +f juliehockett wrote: > Emitting an extra div here? The first div is emitted by the

[PATCH] D63666: [clang-doc] Add templates to HTML generator

DiegoAstiazaran updated this revision to Diff 206103. DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran added a comment. Add FIXME comments for llvm::SmallString to std::string transition. Add check so ParagraphComment template is not generated if its content would be empty. Fix

[PATCH] D63666: [clang-doc] Add templates to HTML generator

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:313-314 + + + + Brief description. juliehockett wrote: > Emitting extra div/p here? Add a check in the comment generation bit to > ensure you're not

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran updated this revision to Diff 204157. DiegoAstiazaran added a comment. Improve format of documentation in ReleaseNotes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62437/new/ https://reviews.llvm.org/D62437 Files: clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.cpp:124 + for (auto : Other.Description) { +bool IsCommentUnique = std::find(Description.begin(), Description.end(), +

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgorny. Implement a simple HMTL generator based on the existing Markdown generator.

[PATCH] D63857: [clang-doc] Structured HTML generator

DiegoAstiazaran updated this revision to Diff 206920. DiegoAstiazaran marked 7 inline comments as done. DiegoAstiazaran added a comment. Fix TagType enum name and members. Add anonymous namespace. Separate the implementation from the definition for some functions. Use emplace_back instead of

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Serialization of child namespaces and records is now handled. Namespaces can have child records and child namespaces. Records can

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 209302. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Move the generation of css stylesheet to a function inside the HTMLGenerator. A virtual function createResources was declared for Generator class. This is

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. A default css stylesheet is included for docs generated in html format. Depends on

[PATCH] D64539: [clang-doc] Add stylesheet to generated html docs

DiegoAstiazaran updated this revision to Diff 209088. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Use `llvm::sys::fs::copy_file` to copy css file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64539/new/ https://reviews.llvm.org/D64539 Files:

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 209053. DiegoAstiazaran added a comment. Use relative paths for references/links within files. Don't fill namespaces of parentInfo in serialization and path is only generated when the parent is the global namespace. Add new fields (Path in Reference

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 209096. DiegoAstiazaran added a comment. In tag nodes with children that are not inline, two text nodes that are adjacent won't have a new line between them. Tag nodes are still rendered in their own line. A B C D is now

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 209534. DiegoAstiazaran edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63663/new/ https://reviews.llvm.org/D63663 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp

[PATCH] D64669: [clang-doc] Fix failing tests on Windows

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Tests on Windows were failing due to path separator differences. '/' was being used as separator in the expected output, paths in

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:75 +Children.emplace_back( +llvm::make_unique(Text.str(), !InlineChildren)); + } jakehehrlich wrote: > I think you can just write

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 208527. DiegoAstiazaran marked 5 inline comments as done. DiegoAstiazaran added a comment. Add helper function to move a vector's elements to another vector. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 207611. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a parent revision: D63857: [clang-doc] Add a structured HTML generator. DiegoAstiazaran added a comment. The links are now generated using the nodes structure

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

DiegoAstiazaran updated this revision to Diff 207605. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63911/new/ https://reviews.llvm.org/D63911 Files: clang-tools-extra/clang-doc/Mapper.cpp clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-doc/Serialize.h

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

DiegoAstiazaran updated this revision to Diff 207126. DiegoAstiazaran marked 6 inline comments as done. DiegoAstiazaran added a comment. Herald added subscribers: kadircet, arphaman. Add comments. Extract repeated logic into mapDecl function in SerializeTest.cpp Use EmptySID instead of specific

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:341 + Parent->USR = ParentUSR; + Parent->ChildNamespaces.emplace_back(I->USR, I->Name, InfoType::IT_namespace); + return {std::unique_ptr{std::move(I)}, juliehockett

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 207160. DiegoAstiazaran retitled this revision from "[clang-doc] Structured HTML generator" to "[clang-doc] Add a structured HTML generator". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:106-107 + + std::string Buffer; + llvm::raw_string_ostream Members(Buffer); + if (!I.Members.empty())

[PATCH] D63857: [clang-doc] Structured HTML generator

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Nodes are used to represent each part of the HTML file. There are TagNodes that represent every HTML tag (p, h1, div, ...) and they

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 208463. DiegoAstiazaran added a comment. Rebase after D52847 was pushed. Path added to parent Info in serialization, this is required after D63911 was pushed. CHANGES SINCE LAST

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 206561. DiegoAstiazaran marked 10 inline comments as done. DiegoAstiazaran retitled this revision from "[clang-doc] Add html links to the parents of a RecordInfo" to "[clang-doc] Add html links to references". DiegoAstiazaran edited the summary of

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:145-146 void ProtectedMethod(); -};)raw", 3, /*Public=*/false, Infos); +};)raw", + 3, /*Public=*/false, Infos); juliehockett

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

DiegoAstiazaran updated this revision to Diff 206570. DiegoAstiazaran added a comment. Add comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62970/new/ https://reviews.llvm.org/D62970 Files: clang-tools-extra/clang-doc/Representation.cpp

[PATCH] D63666: [clang-doc] Add templates to HTML generator

DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. D63857 replaces this revision. Nodes that represent each HTML tag are used instead of templates, it's easier to maintain. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63666/new/

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. In D63180#1562982 , @jakehehrlich wrote: > I'm getting confused in all the different patches. I reviewed the HTML > generator one like yesterday and was awaiting changes. Doesn't

[PATCH] D63911: [clang-doc] Serialize child namespaces and records

DiegoAstiazaran updated this revision to Diff 207153. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Change an if statement for a switch statement in `emitInfo(const RecordDecl *D, ...)`, it now handles correctly unexpected info types. Fix spelling in

[PATCH] D63857: [clang-doc] Structured HTML generator

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:91 +struct HTMLFile { + llvm::SmallString<16> DoctypeDecl{""}; + std::vector> Children; // List of child nodes jakehehrlich wrote: > Does this ever change? If not

[PATCH] D63857: [clang-doc] Structured HTML generator

DiegoAstiazaran updated this revision to Diff 207148. DiegoAstiazaran marked 6 inline comments as done. DiegoAstiazaran added a comment. Make DoctypeDecl a constexpr. Early exit in TagNode::Render. Functions of HTMLGenerator now return HTMLNodes instead of adding children to a Node passed by

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 207174. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Add a variable to use as a reference to the last item in a vector instead of doing vector.back(). CHANGES SINCE LAST ACTION

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

This revision was automatically updated to reflect the committed changes. Closed by commit rL368602: [clang-doc] Generate HTML links for children namespaces/records (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66151: [clang-doc] Fix bitcode writer

DiegoAstiazaran updated this revision to Diff 214923. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Default value of AccessSpecifier attributes is now AS_public. Multiple tests modified. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66151/new/

[PATCH] D66151: [clang-doc] Fix bitcode writer

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Bitcode writer was not emitting the corresponding record for the Access attribute of a FunctionInfo. This is added and corresponding test is

[PATCH] D65425: [clang-doc] Fix expected output in tests

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Removes conversion of html paths in output. These will always be in posix-style paths. https://reviews.llvm.org/D65425 Files:

[PATCH] D65425: [clang-doc] Fix expected output in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL367279: [clang-doc] Fix expected output in tests (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran added a subscriber: phosek. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:377-378 + "href", (FileURL + "#" + std::to_string(L.LineNumber)).str()); + Node->Children.emplace_back(std::move(LocNumberNode)); +

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran updated this revision to Diff 213171. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix format of index.js file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65690/new/ https://reviews.llvm.org/D65690 Files:

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/assets/index.js:17 + return FilePath.substring(Path.length + 1) + Path = Path.substring(0, Path.lastIndexOf("/")); + } phosek wrote: > Wrong indentation? Yes, clang-format

[PATCH] D65622: [clang-doc] Update documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL367743: [clang-doc] Update documentation (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 213169. DiegoAstiazaran marked 7 inline comments as done. DiegoAstiazaran added a comment. Change http to https as the default fix to the repository link. Add new flags to clang-doc documentation. CHANGES SINCE LAST ACTION

[PATCH] D65627: [clang-doc] Add flag to continue after mapping errors

DiegoAstiazaran updated this revision to Diff 213126. DiegoAstiazaran retitled this revision from "[clang-doc] Continue after mapping error" to "[clang-doc] Add flag to continue after mapping errors". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. A flag

[PATCH] D65622: [clang-doc] Update documentation

DiegoAstiazaran updated this revision to Diff 213162. DiegoAstiazaran added a comment. Specify that `stylesheets` flag is only required for html format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65622/new/ https://reviews.llvm.org/D65622 Files:

[PATCH] D65627: [clang-doc] Add flag to continue after mapping errors

This revision was automatically updated to reflect the committed changes. Closed by commit rL367729: [clang-doc] Add flag to continue after mapping errors (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 213128. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Fix comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64958/new/ https://reviews.llvm.org/D64958 Files:

[PATCH] D65690: [clang-doc] Add index in each info html file

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett, phosek. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgrang, mgorny. An index structure is created while generating the output file for each

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran updated this revision to Diff 215304. DiegoAstiazaran marked 11 inline comments as done. DiegoAstiazaran added a comment. Increase version number of clang-doc bitcode. Rename `documentInfo` function to `shouldSerializeInfo`. In new `parseBases` a BaseRecordInfo object is created

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:436 + if (const CXXRecordDecl *Base = + cast_or_null(Ty->getDecl()->getDefinition())) { +bool IsVirtual = false; juliehockett wrote: > Will

[PATCH] D66268: [clang-doc] Fix use of source-root flag

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, ilya-biryukov. The value, if any, of --source-root flag was not being used. This has been fixed and

[PATCH] D66298: [clang-doc] Fix records in global namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rL369123: [clang-doc] Fix records in global namespace (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

DiegoAstiazaran updated this revision to Diff 215624. DiegoAstiazaran added a comment. Run clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

This revision was automatically updated to reflect the committed changes. Closed by commit rL369139: [clang-doc] Redesign of generated HTML files (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66353: [clang-doc] Redesign of generated HTML files

DiegoAstiazaran updated this revision to Diff 215642. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Add comments. Fix clang-doc version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66353/new/ https://reviews.llvm.org/D66353 Files:

[PATCH] D66299: [clang-doc] Sort index elements case insensitive

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. Implement logic to compare the references of the index case insensitive. https://reviews.llvm.org/D66299

[PATCH] D66298: [clang-doc] Fix records in global namespace

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. When a Record is declared in the global namespace, clang-doc serializes it as a child of the global namespace, so the global namespace is now

[PATCH] D66124: [clang-doc] Add missing check in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL368912: [clang-doc] Add missing check in tests (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66151: [clang-doc] Fix bitcode writer

This revision was automatically updated to reflect the committed changes. Closed by commit rL369063: [clang-doc] Fix bitcode writer for access specifiers (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66268: [clang-doc] Fix use of source-root flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL369065: [clang-doc] Fix use of source-root flag (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66299: [clang-doc] Sort index elements case insensitive

This revision was automatically updated to reflect the committed changes. Closed by commit rL369068: [clang-doc] Sort index elements case insensitive (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran updated this revision to Diff 215506. DiegoAstiazaran added a comment. Rebase to master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66238/new/ https://reviews.llvm.org/D66238 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL369075: [clang-doc] Serialize inherited attributes and methods (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66298: [clang-doc] Fix records in global namespace

DiegoAstiazaran updated this revision to Diff 215537. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix tests that were going to fail in Windows. Fix tests broken after rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66298/new/

[PATCH] D66124: [clang-doc] Add missing check in tests

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Path is now checked when comparing two Infos in the unit tests. https://reviews.llvm.org/D66124

[PATCH] D66151: [clang-doc] Fix bitcode writer

DiegoAstiazaran updated this revision to Diff 215193. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Use getAccess() instead of getAccessUnsafe() for CXXMethodDecl. Add comments in YAML generator to specify that AS_none is used as the default here because it's

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. clang-doc now serializes the inherited attributes and methods, not only the name of the base

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL369182: [clang-doc] Fix casting not working in gcc 5.4.0 (authored by DiegoAstiazaran, committed by ). Herald added a

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

DiegoAstiazaran created this revision. DiegoAstiazaran added a project: clang-tools-extra. An implicit cast of std::string to llvm::SmallString<> was breaking GCC 5.4.0 builder. A pair using llvm::SmallString<> now uses std::string. https://reviews.llvm.org/D66378 Files:

[PATCH] D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error

DiegoAstiazaran accepted this revision. DiegoAstiazaran added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66502/new/ https://reviews.llvm.org/D66502 ___ cfe-commits mailing

[PATCH] D65483: [clang-format] Add link to source code in file definitions

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Two command line options have been added to clang-doc. --repository= - URL of

[PATCH] D65419: [clang-doc] Fix failing tests on Windows

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Tests on Windows were failing due to path separator differences. Links in HTML should use posix-style paths. https://reviews.llvm.org/D65419 Files:

[PATCH] D65419: [clang-doc] Fix failing tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL367264: [clang-doc] Fix failing tests on Windows (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

This revision was automatically updated to reflect the committed changes. Closed by commit rL368209: [clang-doc] Add second index for sections within infos content (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213991. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/Representation.h

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran updated this revision to Diff 213968. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Use pre-existing concurrency flag `--execute-concurrency` instead implementing a new one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65628/new/

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 214000. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Add comments. Move definition of ClangDocContext constructor to .cpp file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran updated this revision to Diff 213986. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Add comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65628/new/ https://reviews.llvm.org/D65628 Files:

[PATCH] D65833: [Tooling] Expose ExecutorConcurrency option.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368196: [Tooling] Expose ExecutorConcurrency option. (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:72 +static llvm::cl::opt ThreadCount( +"thread-count", juliehockett wrote: > Can we use the pre-existing concurrency flag instead >

[PATCH] D65628: [clang-doc] Parallelize reducing phase

This revision was automatically updated to reflect the committed changes. Closed by commit rL368206: [clang-doc] Parallelize reducing phase (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65915: [clang-doc] Protect Index with mutex during reducing and generation stage

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, ilya-biryukov. Idx in ClangDocContext instance was being modified by multiple threads causing a seg fault. A

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 214004. DiegoAstiazaran added a comment. Rebase to master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp

[PATCH] D65918: [clang-doc] Generate an HTML index file

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. clang-doc now generates a file that contains only an index to all the infos that can be used as the landing

[PATCH] D65622: [clang-doc] Update documentation

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: jakehehrlich, juliehockett. DiegoAstiazaran added a project: clang-tools-extra. HTML generator has been included in clang-tools-extra release notes. clang-doc documentation file has been updated.

  1   2   >