Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

[Re-sending, used the old cfe-commits address by accident] Where is the other thread? This problem still exists, for both trunk and the upcoming 3.7.0 RC3. I'll try to submit a patch tomorrow to partially restore the include guards, so we won't have a broken release. -Dimitry On 03 Aug

Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

The problems from my earlier mail still stand, even with trunk r245199. 1) Various configure scripts (e.g. lame and others) try to check for intrinsics using fragments similar to the following: #include xmmintrin.h then running that through clang -E. If preprocessing succeeds, the intrinsics

Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

No, it does not occur in the 3.7 branch, thanks for reverting those changes. :) -Dimitry On 18 Aug 2015, at 01:09, Hans Wennborg h...@chromium.org wrote: The 3.7 branch does have the include guards; they were re-added in http://llvm.org/viewvc/llvm-project?rev=243925view=rev. That happened

[libcxx] r245421 - Fix warnings about pessimizing return moves for C++11 and higher

Author: dim Date: Wed Aug 19 01:43:33 2015 New Revision: 245421 URL: http://llvm.org/viewvc/llvm-project?rev=245421view=rev Log: Fix warnings about pessimizing return moves for C++11 and higher Summary: Throughout the libc++ headers, there are a few instances where _VSTD::move() is used to

Re: [Diffusion] rL244063: Add missing atomic libcall support.

dim added a comment. Note that http://reviews.llvm.org/rL252920 does not apply to 3.7 cleanly, a few minor modifications are needed. Users: jyknight (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) compnerd (Auditor) majnemer (Auditor) rsmith

Re: [Diffusion] rL246882: Don't crash on a self-alias declaration

dim added a subscriber: dim. dim added auditors: 3.7-release, cfe-commits, tstellarAMD, hfinkel. dim added a comment. This got reported again in PR25397, and occurs during compilation of mpich. Looks like a good candidate for 3.7.1. Users: hfinkel (Author, Auditor) 3.7-release (Auditor)

[PATCH] D13822: Support linking against OpenMP runtime on FreeBSD.

dim created this revision. dim added reviewers: emaste, joerg, theraven. dim added a subscriber: cfe-commits. Similar to rL248426 (which was a followup to rL248379 and rL248424), add the required libraries for OpenMP on the linker command line, and update the test case.

Re: [Diffusion] rL244063: Add missing atomic libcall support.

dim added a subscriber: dim. dim added auditors: 3.7-release, cfe-commits, tstellarAMD, jyknight, compnerd, majnemer. dim added a comment. This is a change that was required to be able to use clang 3.7.0 for FreeBSD on arm. Please merge this to the 3.7 branch. (I already mailed this to James

Re: r250473 - Add an error when calling a builtin that requires features that don't

On 16 Oct 2015, at 01:47, Eric Christopher via cfe-commits wrote: > > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473=rev > Log: > Add an error when calling a builtin that requires

r250657 - Support linking against OpenMP runtime on FreeBSD.

Author: dim Date: Sun Oct 18 08:32:20 2015 New Revision: 250657 URL: http://llvm.org/viewvc/llvm-project?rev=250657=rev Log: Support linking against OpenMP runtime on FreeBSD. Summary: Similar to rL248426 (which was a followup to rL248379 and rL248424), add the required libraries for OpenMP on

Re: [Diffusion] rL248424: Push OpenMP linker flags after linker input on Darwin. Don't add any

dim added a subscriber: dim. dim added auditors: 3.7-release, cfe-commits, tstellarAMD, joerg. dim added a comment. Should be merged together with http://reviews.llvm.org/rL248379, http://reviews.llvm.org/rL248426, and http://reviews.llvm.org/rL250657. Together, these add support for linking

Re: [Diffusion] rL248379: Refactor library decision for -fopenmp support from Darwin into a

dim added a subscriber: dim. dim added auditors: 3.7-release, cfe-commits, tstellarAMD, joerg. dim added a comment. Should be merged together with http://reviews.llvm.org/rL248424, http://reviews.llvm.org/rL248426, and http://reviews.llvm.org/rL250657. Together, these add support for linking

Re: [Diffusion] rL248426: Support linking against OpenMP runtime on NetBSD.

dim added a subscriber: dim. dim added auditors: 3.7-release, cfe-commits, tstellarAMD, joerg. dim added a comment. Should be merged together with http://reviews.llvm.org/rL248379, http://reviews.llvm.org/rL248424, and http://reviews.llvm.org/rL250657. Together, these add support for linking

Re: [Diffusion] rL250657: Support linking against OpenMP runtime on FreeBSD.

dim added auditors: 3.7-release, cfe-commits, tstellarAMD, joerg. dim added a comment. Should be merged together with http://reviews.llvm.org/rL248379, http://reviews.llvm.org/rL248424, and http://reviews.llvm.org/rL248426. Together, these add support for linking against OpenMP on FreeBSD and

[libcxx] r248313 - Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

Author: dim Date: Tue Sep 22 13:55:37 2015 New Revision: 248313 URL: http://llvm.org/viewvc/llvm-project?rev=248313=rev Log: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available. Summary: In rL241532, atomic_support.h was added, which provides handling of atomic

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

dim added a comment. In http://reviews.llvm.org/D13051#250836, @EricWF wrote: > Does anything actually need this? This interface was never really meant to be > complete, just want was needed. I need it at least for FreeBSD/arm, since it defaults to armv4, and it does not yet have a full set

Re: r244063 - Add missing atomic libcall support.

On 05 Aug 2015, at 18:57, James Y Knight wrote: > Author: jyknight > Date: Wed Aug 5 11:57:36 2015 > New Revision: 244063 > > URL: http://llvm.org/viewvc/llvm-project?rev=244063=rev > Log: > Add missing atomic libcall support. > > Support for emitting libcalls for

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

dim added a comment. In http://reviews.llvm.org/D13051#250921, @jroelofs wrote: > In http://reviews.llvm.org/D13051#250910, @EricWF wrote: > > > @jroelofs @dim, could we fallback to the __sync_* builtins on arm? > The actual implementations of these __sync builtins should still come from

[PATCH] D15166: Fix C++ support on recent DragonFly BSD releases

dim created this revision. dim added reviewers: joerg, rsmith. dim added a subscriber: cfe-commits. [ Copied from https://llvm.org/bugs/show_bug.cgi?id=25597 ] Clang support for DragonFly BSD is lagging a bit, resulting in poor support for c++. DragonFlyBSD is unique in that it has two base

r256742 - Convert test/CXX/lex/lex.literal/lex.string/p4.cpp back to DOS line

Author: dim Date: Mon Jan 4 04:17:48 2016 New Revision: 256742 URL: http://llvm.org/viewvc/llvm-project?rev=256742=rev Log: Convert test/CXX/lex/lex.literal/lex.string/p4.cpp back to DOS line endings, since the file is supposed to have them, according to its comments. Also set its svn:eol-style

[PATCH] D15849: Fix several accidental DOS line endings in source files

dim created this revision. dim added a reviewer: joerg. dim added a subscriber: cfe-commits. There are a number of files in the tree which have been accidentally checked in with DOS line endings. Convert these to native line endings. There are also a few files which have DOS line endings on

r256704 - Fix several accidental DOS line endings in source files

Author: dim Date: Sun Jan 3 09:55:40 2016 New Revision: 256704 URL: http://llvm.org/viewvc/llvm-project?rev=256704=rev Log: Fix several accidental DOS line endings in source files Summary: There are a number of files in the tree which have been accidentally checked in with DOS line endings.

[PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

dim created this revision. dim added reviewers: davide, echristo, dexonsmith. dim added subscribers: emaste, ahatanak, cfe-commits, davide. Herald added subscribers: rengolin, aemerson. In rL256641, @davide turned off movt generation by default for FreeBSD. This was because our ld is very old,

r256920 - Add -fno-movt frontend option, to disable movt/movw on ARM

Author: dim Date: Wed Jan 6 01:42:18 2016 New Revision: 256920 URL: http://llvm.org/viewvc/llvm-project?rev=256920=rev Log: Add -fno-movt frontend option, to disable movt/movw on ARM Summary: In rL256641, @davide turned off movt generation by default for FreeBSD. This was because our ld is very

Re: [PATCH] D7164: Recognize "CC" and "clang-CC" as C++ compiler aliases on FreeBSD

dim abandoned this revision. dim added a comment. Abandoning this in favor of a wrapper shell script, which will call `/usr/bin/c++` instead. http://reviews.llvm.org/D7164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

dim updated this revision to Diff 44059. dim added a comment. Rename `-fno-movt` to `-mno-movt`. http://reviews.llvm.org/D15899 Files: include/clang/Driver/Options.td lib/Driver/Tools.cpp test/Driver/arm-no-movt.c Index: test/Driver/arm-no-movt.c

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

dim added a comment. In http://reviews.llvm.org/D15899#319902, @davide wrote: > I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3 > if backported) -- what about people running <= 10.2 ? Isn't this a problem > for them? People running ports-provided or hand-built

[PATCH] D15967: Turn off lldb debug tuning by default for FreeBSD

dim created this revision. dim added reviewers: emaste, probinson. dim added a subscriber: cfe-commits. Herald added a subscriber: emaste. This is the clang part of D15966. In rL256104, debugger tuning was added to the clang driver, and again the default for FreeBSD was set to lldb. The default

r257104 - Turn off lldb debug tuning by default for FreeBSD

Author: dim Date: Thu Jan 7 16:09:47 2016 New Revision: 257104 URL: http://llvm.org/viewvc/llvm-project?rev=257104=rev Log: Turn off lldb debug tuning by default for FreeBSD Summary: This is the clang part of D15966. In rL256104, debugger tuning was added to the clang driver, and again the

Re: [PATCH] D10137: On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

dim updated this revision to Diff 43655. dim added a comment. Add a test for passing -G0 to the assembler. http://reviews.llvm.org/D10137 Files: lib/Driver/Tools.cpp test/Driver/freebsd-mips-as.c Index: test/Driver/freebsd-mips-as.c

r256468 - On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

Author: dim Date: Sun Dec 27 04:36:44 2015 New Revision: 256468 URL: http://llvm.org/viewvc/llvm-project?rev=256468=rev Log: On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to the assembler. Summary: See also:

Re: [PATCH] D10137: On {mips, mipsel, mips64, mips64el}-freebsd, we need to pass any -G option to the assembler.

dim commandeered this revision. dim added a reviewer: brooks. dim added a comment. Picking this up, since it needs a minor change to apply. http://reviews.llvm.org/D10137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15166: Fix C++ support on recent DragonFly BSD releases

dim added a comment. Tried this with trunk r256465, but I get the following test failure: FAIL: Clang :: Driver/dragonfly.c (3997 of 30174) TEST 'Clang :: Driver/dragonfly.c' FAILED Script: --

r256467 - Fix C++ support on recent DragonFly BSD releases

Author: dim Date: Sun Dec 27 04:01:44 2015 New Revision: 256467 URL: http://llvm.org/viewvc/llvm-project?rev=256467=rev Log: Fix C++ support on recent DragonFly BSD releases Summary: [ Copied from https://llvm.org/bugs/show_bug.cgi?id=25597 ] Clang support for DragonFly BSD is lagging a bit,

Re: [PATCH] D15166: Fix C++ support on recent DragonFly BSD releases

dim updated this revision to Diff 43654. dim added a comment. Fix the test to check for --enable-new-dtags. http://reviews.llvm.org/D15166 Files: lib/Driver/ToolChains.cpp lib/Driver/Tools.cpp lib/Frontend/InitHeaderSearch.cpp test/Driver/dragonfly.c Index: test/Driver/dragonfly.c

r256461 - For FreeBSD on mips, pass -G options to the linker

Author: dim Date: Sun Dec 27 00:47:09 2015 New Revision: 256461 URL: http://llvm.org/viewvc/llvm-project?rev=256461=rev Log: For FreeBSD on mips, pass -G options to the linker Summary: On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to the linker. See also:

Re: [PATCH] D15791: Disable generating movt on FreeBSD

dim added a comment. In http://reviews.llvm.org/D15791#317175, @emaste wrote: > > @davide, any idea whether lld will be able to handle movt correctly? If so, > > we might want to make this dependent on -fuse-ld=bfd or -fuse-ld=lld ? > > > I'm sure lld will handle everything we need eventually

Re: [PATCH] D16102: Bug 25496 - clang++ -pg links with -lc++ instead of -lc++_p

dim added a subscriber: dim. dim added a comment. In http://reviews.llvm.org/D16102#324395, @davide wrote: > I'm fine with this solution but Saleem pointed out there are some changes > that need to be made before getting this in. @compnerd, what were these changes to be made?

Re: [PATCH] D16102: Bug 25496 - clang++ -pg links with -lc++ instead of -lc++_p

dim commandeered this revision. dim added a reviewer: dws. dim added a comment. Going to abandon this review in favor of http://reviews.llvm.org/D16264. http://reviews.llvm.org/D16102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r258107 - Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262

On 19 Jan 2016, at 01:50, Marshall Clow via cfe-commits wrote: > > Author: marshall > Date: Mon Jan 18 18:50:37 2016 > New Revision: 258107 > > URL: http://llvm.org/viewvc/llvm-project?rev=258107=rev > Log: > Fix PR#26175. Thanks to Josh Petrie for the report and

Re: [PATCH] D16264: For FreeBSD, use _p variants of libraries for linking C++ programs

dim added a comment. In http://reviews.llvm.org/D16264#340131, @compnerd wrote: > `-p` or `-pg` also effects the math library. Please adjust the tests and the > driver to reflect that. This is already handled in `lib/Driver/Tools.cpp`, in `freebsd::Linker::ConstructJob()`: if

Re: [PATCH] D16264: For FreeBSD, use _p variants of libraries for linking C++ programs

dim added a comment. Ping. http://reviews.llvm.org/D16264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

dim added subscribers: joerg, dim. dim added a comment. LGTM, at least. @emaste, @joerg, OK with you too? http://reviews.llvm.org/D17286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

Hi Richard, I am unsure if you are specifically the code owner of Sema, but can you please approve this change for the 3.8 branch? -Dimitry > On 19 Jan 2016, at 04:58, Faisal Vali via cfe-commits > wrote: > > Author: faisalv > Date: Mon Jan 18 21:58:55 2016 > New

Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

Hans, This change looks pretty trivial, and is required to not crash for the test cases in PR26134. Can we merge it to release_38, please? -Dimitry > On 19 Jan 2016, at 19:28, Dimitry Andric via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Hi Richard, >

Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

Fri, Jan 22, 2016 at 12:38 PM, Dimitry Andric <dimi...@andric.com> wrote: >> Hans, >> >> This change looks pretty trivial, and is required to not crash for the test >> cases in PR26134. Can we merge it to release_38, please? >> >> -Dimitry >> >

[clang-tools-extra] r258327 - Ensure the lit.site.cfg and Unit/lit.site.cfg make targets do not use

Author: dim Date: Wed Jan 20 12:53:44 2016 New Revision: 258327 URL: http://llvm.org/viewvc/llvm-project?rev=258327=rev Log: Ensure the lit.site.cfg and Unit/lit.site.cfg make targets do not use the same temporary file, otherwise there is a race condition when using parallel make jobs. Modified:

Re: r260851 - As reported in https://llvm.org/bugs/show_bug.cgi?id=25496, on FreeBSD,

On 16 Feb 2016, at 18:51, Hans Wennborg <h...@chromium.org> wrote: > > On Sun, Feb 14, 2016 at 8:14 AM, Dimitry Andric <dimi...@andric.com> wrote: >> On 14 Feb 2016, at 17:08, Dimitry Andric via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >>>

Re: r261422 - Fix handling of vaargs on PPC32 when going from regsave to overflow.

On 20 Feb 2016, at 09:31, Roman Divacky via cfe-commits wrote: > > Author: rdivacky > Date: Sat Feb 20 02:31:24 2016 > New Revision: 261422 > > URL: http://llvm.org/viewvc/llvm-project?rev=261422=rev > Log: > Fix handling of vaargs on PPC32 when going from regsave

Re: r260851 - As reported in https://llvm.org/bugs/show_bug.cgi?id=25496, on FreeBSD,

On 14 Feb 2016, at 17:08, Dimitry Andric via cfe-commits <cfe-commits@lists.llvm.org> wrote: > > Author: dim > Date: Sun Feb 14 10:08:20 2016 > New Revision: 260851 > > URL: http://llvm.org/viewvc/llvm-project?rev=260851=rev > Log: > As reported in https://llvm.

Re: [PATCH] D17286: Make FreeBSD and NetBSD use CLANG_DEFAULT_CXX_STDLIB

dim accepted this revision. dim added a reviewer: dim. dim added a comment. This revision is now accepted and ready to land. If nobody objects, I will commit this. http://reviews.llvm.org/D17286 ___ cfe-commits mailing list

Re: r249655 - Stop messing with the 'g' group of options in CompilerInvocation.

> On 08 Oct 2015, at 06:24, Douglas Katzman via cfe-commits > wrote: > > Author: dougk > Date: Wed Oct 7 23:24:12 2015 > New Revision: 249655 > > URL: http://llvm.org/viewvc/llvm-project?rev=249655=rev > Log: > Stop messing with the 'g' group of options in

[PATCH] D18501: Fix compilation on FreeBSD

dim created this revision. dim added reviewers: mclow.lists, EricWF, emaste. dim added subscribers: cfe-commits, bdrewery. Herald added a subscriber: emaste. On FreeBSD, a number of math.h functions are actually defined as macros, such as `signbit()`, `fpclassify()` and others. Since libc++'s

Re: [PATCH] D18501: Fix compilation on FreeBSD

dim added a comment. Note that these compilation errors came up specifically because @bdrewery is doing cross-compilation of FreeBSD with recent versions of gcc. Apparently clang does not give the same errors on these undefined identifiers, but I'm not entirely sure why not...

Re: [Diffusion] rL244063: Add missing atomic libcall support.

dim resigned from this audit. Users: jyknight (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) compnerd (Auditor) majnemer (Auditor) rsmith (Auditor) dim (Auditor) http://reviews.llvm.org/rL244063

Re: [Diffusion] rL244063: Add missing atomic libcall support.

dim accepted this commit. Users: jyknight (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) compnerd (Auditor) majnemer (Auditor) rsmith (Auditor) dim (Auditor) http://reviews.llvm.org/rL244063 ___

Re: [PATCH] D18501: Fix compilation on FreeBSD

dim abandoned this revision. dim added a comment. Yes, this was indeed the wrong include order. During the latter stages of FreeBSD's buildworld, the compiler is invoked with `-nostdinc++`, but `/usr/include` was put before the libc++ include directory, `/usr/include/c++/v1`. So as @rsmith

Re: [PATCH] D20037: Make __FreeBSD_cc_version predefined macro configurable at build time

This revision was automatically updated to reflect the committed changes. Closed by commit rL270240: Make __FreeBSD_cc_version predefined macro configurable at build time (authored by dim). Changed prior to commit: http://reviews.llvm.org/D20037?vs=56476=57952#toc Repository: rL LLVM

r270240 - Make __FreeBSD_cc_version predefined macro configurable at build time

Author: dim Date: Fri May 20 12:27:22 2016 New Revision: 270240 URL: http://llvm.org/viewvc/llvm-project?rev=270240=rev Log: Make __FreeBSD_cc_version predefined macro configurable at build time The `FreeBSDTargetInfo` class has always set the `__FreeBSD_cc_version` predefined macro to a rather

Re: [PATCH] D20037: Make __FreeBSD_cc_version predefined macro configurable at build time

dim added a subscriber: cfe-commits. dim added a comment. Belatedly adding cfe-commits. http://reviews.llvm.org/D20037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22010: Add more gcc compatibility names to clang's cpuid.h

dim added inline comments. Comment at: lib/Headers/cpuid.h:114 @@ -109,2 +113,3 @@ #define bit_AVX 0x1000 +#define bit_F16C0x2000 #define bit_RDRND 0x4000 bruno wrote: > Isn't this one also meant for gcc compat? Well, we didn't

Re: r277307 - Add more gcc compatibility names to clang's cpuid.h

Hi Hans, I would like to merge this one to release_39, since it fixes a few third party programs using cpuid.h, and expecting gcc-compatible CPUID bit macros. -Dimitry > On 31 Jul 2016, at 22:23, Dimitry Andric via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Autho

r277307 - Add more gcc compatibility names to clang's cpuid.h

Author: dim Date: Sun Jul 31 15:23:23 2016 New Revision: 277307 URL: http://llvm.org/viewvc/llvm-project?rev=277307=rev Log: Add more gcc compatibility names to clang's cpuid.h Summary: Some cpuid bit defines are named slightly different from how gcc's cpuid.h calls them. Define a few more

Re: [PATCH] D22010: Add more gcc compatibility names to clang's cpuid.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL277307: Add more gcc compatibility names to clang's cpuid.h (authored by dim). Changed prior to commit: https://reviews.llvm.org/D22010?vs=62781=66250#toc Repository: rL LLVM

Re: [PATCH] D22010: Add more gcc compatibility names to clang's cpuid.h

dim added a comment. Ping. http://reviews.llvm.org/D22010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM. Eric, apologies that this took some time to review. I finally dug out my old test cases for the original problem report in FreeBSD, and re-tested them against this patch. (These test cases

[PATCH] D22010: Add more gcc compatibility names to clang's cpuid.h

dim created this revision. dim added reviewers: joerg, rsmith. dim added a subscriber: cfe-commits. Some cpuid bit defines are named slightly different from how gcc's cpuid.h calls them. Define a few more compatibility names to appease software built for gcc: * `bit_PCLMUL` alias of

Re: [PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

dim added a comment. In http://reviews.llvm.org/D21329#475105, @theraven wrote: > Looks fine to me, though I wonder if we want to move to the new ABI for > FreeBSD11 and use the old one for <=10. For 11 it is certainly too late now, since it is ABI/API frozen now, and we would still need to

Re: [PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

dim added a comment. @theraven, do you have any other feedback? :) http://reviews.llvm.org/D21329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r277307 - Add more gcc compatibility names to clang's cpuid.h

> Hi Hans, >> >> I would like to merge this one to release_39, since it fixes a few third >> party programs using cpuid.h, and expecting gcc-compatible CPUID bit macros. >> >> -Dimitry >> >>> On 31 Jul 2016, at 22:23, Dimitry Andric via cfe-commit

Re: r266775 - Pass dwarf-version to cc1as.

Hi Hans, Can we please merge this one to release_39 too? I forgot all about it, sorry. Doug, can you please approve? -Dimitry > On 19 Apr 2016, at 19:43, Douglas Katzman via cfe-commits > wrote: > > Author: dougk > Date: Tue Apr 19 12:43:54 2016 > New Revision:

Re: [libcxx] r278904 - Support allocators with explicit conversion constructors. Fixes bug #29000

Marshall, this is maybe a good candidate for merging to release_39? -Dimitry > On 17 Aug 2016, at 07:58, Marshall Clow via cfe-commits > wrote: > > Author: marshall > Date: Wed Aug 17 00:58:40 2016 > New Revision: 278904 > > URL:

Re: r290539 - [inline-asm]No error for conflict between inputs\outputs and clobber list

On 26 Dec 2016, at 13:23, Marina Yatsina via cfe-commits wrote: > > Author: myatsina > Date: Mon Dec 26 06:23:42 2016 > New Revision: 290539 > > URL: http://llvm.org/viewvc/llvm-project?rev=290539=rev > Log: > [inline-asm]No error for conflict between inputs\outputs

Re: [libcxx] r292276 - Fix std::string assignment ambiguity from braced initializer lists.

> On 17 Jan 2017, at 23:10, Eric Fiselier via cfe-commits > wrote: > > Author: ericwf > Date: Tue Jan 17 16:10:32 2017 > New Revision: 292276 > > URL: http://llvm.org/viewvc/llvm-project?rev=292276=rev > Log: > Fix std::string assignment ambiguity from braced

Re: [libcxx] r293197 - Disable thread safety analysis for some functions in __thread_support

I'd like to merge this to the release_40 branch. Eric, you OK with that? -Dimitry > On 26 Jan 2017, at 19:37, Dimitry Andric via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: dim > Date: Thu Jan 26 12:37:18 2017 > New Revision: 293197 > > UR

[libcxx] r293443 - Merging r293197:

Author: dim Date: Sun Jan 29 14:30:51 2017 New Revision: 293443 URL: http://llvm.org/viewvc/llvm-project?rev=293443=rev Log: Merging r293197: r293197 | dim | 2017-01-26 19:37:18 +0100 (Thu, 26 Jan 2017) | 43 lines Disable

Re: [libcxx] r293197 - Disable thread safety analysis for some functions in __thread_support

ge this to the release_40 branch. Eric, you OK with that? > > -Dimitry > > > On 26 Jan 2017, at 19:37, Dimitry Andric via cfe-commits > > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > > > > Author: dim > > Date: Thu Jan

[libcxx] r293197 - Disable thread safety analysis for some functions in __thread_support

Author: dim Date: Thu Jan 26 12:37:18 2017 New Revision: 293197 URL: http://llvm.org/viewvc/llvm-project?rev=293197=rev Log: Disable thread safety analysis for some functions in __thread_support Many thread-related libc++ test cases fail on FreeBSD, due to the following -Werror warnings: In

Re: [PATCH] D23960: Avoid narrowing warnings in __bitset constructor

dim added a comment. @mclow.lists, I tested code generation (on i386-freebsd) with this small sample program: #include void f(const std::bitset<53>&); void g(void) { std::bitset<53> bs(0x1234567890abcdef); f(bs); } The assembly doesn't change at all after this fix:

[libcxx] r280543 - Avoid narrowing warnings in __bitset constructor

Author: dim Date: Fri Sep 2 16:02:11 2016 New Revision: 280543 URL: http://llvm.org/viewvc/llvm-project?rev=280543=rev Log: Avoid narrowing warnings in __bitset constructor When is compiled with warnings enabled, on a platform where size_t is 4 bytes, it results in errors similar to:

Re: [PATCH] D23960: Avoid narrowing warnings in __bitset constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rL280543: Avoid narrowing warnings in __bitset constructor (authored by dim). Changed prior to commit: https://reviews.llvm.org/D23960?vs=69489=70231#toc Repository: rL LLVM

Re: [PATCH] D23960: Avoid narrowing warnings in __bitset constructor

dim added a comment. Ping... https://reviews.llvm.org/D23960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23960: Avoid narrowing warnings in __bitset constructor

dim added inline comments. Comment at: include/bitset:262 @@ -261,3 +261,3 @@ #elif __SIZEOF_SIZE_T__ == 4 -: __first_{__v, __v >> __bits_per_word} +: __first_{static_cast<__storage_type>(__v), static_cast<__storage_type>(__v >> __bits_per_word)} #else

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

dim added a comment. FWIW, I have already imported this fix into FreeBSD two weeks ago: https://svnweb.freebsd.org/changeset/base/304960 It has been working fine for us. https://reviews.llvm.org/D23921 ___ cfe-commits mailing list

Re: [PATCH] D24867: Request init/fini array on FreeBSD 12 and later

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r266775 - Pass dwarf-version to cc1as.

Ah, I missed Doug's follow-up commit r266797, which moved the code again. I noticed that the RenderDebugEnablingArgs() call was missing in the spot indicated below, but it was only moved. -Dimitry > On 17 Aug 2016, at 01:17, Hans Wennborg wrote: > > Looks like it was

Re: [PATCH] D23961: Avoid embedded preprocessor directives in __tree

dim added a comment. In https://reviews.llvm.org/D23961#527284, @vitalybuka wrote: > PPC bots are broken by this patch > http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/3547 > http://lab.llvm.org:8011/builders/sanitizer-ppc64le-linux/builds/2353 I saw some mails about it,

[PATCH] D23961: Avoid embedded preprocessor directives in __tree

dim created this revision. dim added reviewers: mclow.lists, EricWF. dim added subscribers: emaste, cfe-commits. When I compile as part of clang, with -pedantic enabled, I get the following warnings: In file included from /usr/include/c++/v1/map:442: /usr/include/c++/v1/__tree:874:2:

[PATCH] D23960: Avoid narrowing warnings in __bitset constructor

dim created this revision. dim added reviewers: mclow.lists, EricWF. dim added subscribers: emaste, cfe-commits. When I compile is compiled with warnings enabled, I get the following error (which is interesting in itself, it should only be a warning): /usr/include/c++/v1/bitset:265:16:

[libcxx] r279926 - Avoid embedded preprocessor directives in __tree

Author: dim Date: Sat Aug 27 14:32:03 2016 New Revision: 279926 URL: http://llvm.org/viewvc/llvm-project?rev=279926=rev Log: Avoid embedded preprocessor directives in __tree Similar to rL242623, move C++ version checks outside of _NOEXCEPT_() macro invocation argument lists, to avoid "embedding

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

dim added a subscriber: dim. dim added a comment. This works for me. I had two test cases from the FreeBSD source tree which resulted in warnings, e.g.: cddl/contrib/opensolaris/lib/libnvpair/libnvpair.c:388:15: error: passing an object that undergoes default argument promotion to

[PATCH] D25449: Disable trivial pair copy/move tests when unsupported

dim created this revision. dim added reviewers: EricWF, emaste, rsmith, theraven. dim added a subscriber: cfe-commits. On FreeBSD, for ABI compatibility reasons, the pair trivial copy constructor is disabled, using the aptly-named `_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR` define.

[PATCH] D25389: Fix std::pair on FreeBSD

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. Yes, this looks good to me. For trunk r283783, this brought the number of unexpected failures down from 61 to 41. Tests fixed by this change: libc++ ::

Re: r286129 - [OPENMP] Fixed codegen for __real/__imag expressions in atomic

Hi Alexey, Does this look like a good candidate for 3.9.1? -Dimitry > On 07 Nov 2016, at 19:15, Alexey Bataev via cfe-commits > wrote: > > Author: abataev > Date: Mon Nov 7 12:15:02 2016 > New Revision: 286129 > > URL:

[libcxx] r284047 - Disable trivial pair copy/move tests when unsupported

Author: dim Date: Wed Oct 12 15:26:47 2016 New Revision: 284047 URL: http://llvm.org/viewvc/llvm-project?rev=284047=rev Log: Disable trivial pair copy/move tests when unsupported Summary: On FreeBSD, for ABI compatibility reasons, the pair trivial copy constructor is disabled, using the

[PATCH] D25593: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r291476 - Move _PairT declaration out of __hash_combine to avoid warning under C++98

Author: dim Date: Mon Jan 9 14:29:35 2017 New Revision: 291476 URL: http://llvm.org/viewvc/llvm-project?rev=291476=rev Log: Move _PairT declaration out of __hash_combine to avoid warning under C++98 Summary: Some parts of the FreeBSD tree are still compiled with C++98, and until rL288554 this

Re: r284890 - DR583, DR1512: Implement a rewrite to C++'s 'composite pointer type' rules.

On 22 Oct 2016, at 00:00, Richard Smith via cfe-commits wrote: > > Author: rsmith > Date: Fri Oct 21 17:00:42 2016 > New Revision: 284890 > > URL: http://llvm.org/viewvc/llvm-project?rev=284890=rev > Log: > DR583, DR1512: Implement a rewrite to C++'s 'composite

Re: r292032 - Fix PR31644 introduced by r287138 and add a regression test.

On 14 Jan 2017, at 22:12, Yaron Keren via cfe-commits wrote: > Author: yrnkrn > Date: Sat Jan 14 15:12:08 2017 > New Revision: 292032 > > URL: http://llvm.org/viewvc/llvm-project?rev=292032=rev > Log: > Fix PR31644 introduced by r287138 and add a regression test. >

Re: r290169 - Revert r290149: Add the alloc_size attribute to clang.

I can confirm that r290169 indeed fixes the three test failures I got earlier. Thanks George! -Dimitry > On 23 Dec 2016, at 02:29, George Burgess IV > wrote: > > It looks like the root of this is that we're treating calls to `allocsize` > functions as AllocLike

  1   2   >