[PATCH] D60040: [clangd] Use capacity() instead of size() in RefSlab::bytes()

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60040/new/ https://reviews.llvm.org/D60040

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

gribozavr added inline comments. Comment at: clang/include/clang/Tooling/Syntax/TokenBuffer.h:69 + /// The tokens after preprocessor replacements. + llvm::ArrayRef tokens(const TokenBuffer ) const; + /// Tokens that appear in the text of the file, i.e. a name of an

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/Testing/Support/Annotations.h:9 // // Annotations lets you mark points and ranges inside source code, for tests: //

[PATCH] D59407: [clangd] Add RelationSlab

gribozavr added a comment. Submitting code as it becomes ready is the usual practice here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407 ___ cfe-commits

[PATCH] D58774: Moved Symbol into its own header and implementation file

gribozavr updated this revision to Diff 188714. gribozavr added a comment. Herald added a subscriber: mgrang. Also moved the SymbolSlab implementation into Symbol.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58774/new/

[PATCH] D58774: Moved Symbol into its own header and implementation file

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355088: Moved Symbol into its own header and implementation file (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58774?vs=188714=188715#toc Repository:

[PATCH] D58778: Moved Ref into its own header and implementation file

gribozavr updated this revision to Diff 188723. gribozavr marked an inline comment as done. gribozavr added a comment. Added a license header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58778/new/ https://reviews.llvm.org/D58778 Files:

[PATCH] D58768: Moved SymbolLocation into its own header and implementation file

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58768 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D58769: Moved DenseMap support for SymbolID into SymbolID.h

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58769 Files: clang-tools-extra/clangd/index/Index.h

[PATCH] D58769: Moved DenseMap support for SymbolID into SymbolID.h

gribozavr closed this revision. gribozavr added a comment. Committed as https://reviews.llvm.org/rL355081. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58769/new/ https://reviews.llvm.org/D58769 ___

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

gribozavr added a comment. SymbolOrigin is used by itself, for example, in CodeComplete.h to define `struct CodeCompletion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58773/new/ https://reviews.llvm.org/D58773

[PATCH] D58782: Use ArrayRef::copy, instead of copying data manually

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58782 Files: clang-tools-extra/clangd/index/Ref.cpp Index:

[PATCH] D58774: Moved Symbol into its own header and implementation file

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. gribozavr added a parent revision: D58773: Moved SymbolOrigin into its own header and implementation file.

[PATCH] D58778: Moved Ref into its own header and implementation file

This revision was automatically updated to reflect the committed changes. gribozavr marked an inline comment as done. Closed by commit rL355090: Moved Ref into its own header and implementation file (authored by gribozavr, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov.

[PATCH] D58781: Added missing license headers

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58781 Files: clang-tools-extra/clangd/ExpectedTypes.cpp

[PATCH] D58774: Moved Symbol into its own header and implementation file

gribozavr updated this revision to Diff 188712. gribozavr added a comment. Moving SymbolSlab as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58774/new/ https://reviews.llvm.org/D58774 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D58774: Moved Symbol into its own header and implementation file

gribozavr added a comment. Moved SymbolSlab as well, PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58774/new/ https://reviews.llvm.org/D58774 ___ cfe-commits mailing list

[PATCH] D58781: Added missing license headers

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355092: Added missing license headers (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58781?vs=188726=188731#toc Repository: rCTE Clang Tools Extra

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355086: Moved SymbolOrigin into its own header and implementation file (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58773?vs=188703=188709#toc

[PATCH] D58778: Moved Ref into its own header and implementation file

gribozavr marked 2 inline comments as done. gribozavr added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.cpp:1 +#include "Ref.h" + ioeric wrote: > License? Added. Comment at:

[PATCH] D58778: Moved Ref into its own header and implementation file

gribozavr updated this revision to Diff 188724. gribozavr marked 2 inline comments as done. gribozavr added a comment. Added a missing include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58778/new/ https://reviews.llvm.org/D58778 Files:

[PATCH] D58782: Use ArrayRef::copy, instead of copying data manually

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355091: Use ArrayRef::copy, instead of copying data manually (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58782?vs=188729=188730#toc Repository: rCTE

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188527. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files: clang-tools-extra/docs/clangd/ApplyClangTidyFixInVSCode.gif

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188535. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files: clang-tools-extra/docs/_static/clang-tools-extra-styles.css

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188521. gribozavr marked 2 inline comments as done. gribozavr added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files:

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188531. gribozavr added a comment. Herald added a reviewer: serge-sans-paille. Added custom CSS for the details tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:360 + +- Pass an experimental `-background-index` command line argument. With + this feature enabled, clangd incrementally builds an index of

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188536. gribozavr added a comment. Removed mentions of clangd v9. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files:

[PATCH] D58717: Added documentation for clangd v9+ features

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now

[PATCH] D58721: Added release notes for clangd 8

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58721 Files:

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr updated this revision to Diff 188534. gribozavr added a comment. Separated user and developer documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58710/new/ https://reviews.llvm.org/D58710 Files:

[PATCH] D58710: Added more detailed documentation for clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rL354992: Added more detailed documentation for clangd (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58717: Added documentation for clangd v9+ features

This revision was automatically updated to reflect the committed changes. Closed by commit rL354994: Added documentation for clangd v9+ features (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr marked 4 inline comments as done. gribozavr added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:360 + +- Pass an experimental `-background-index` command line argument. With + this feature enabled, clangd incrementally builds an index of

[PATCH] D58710: Added more detailed documentation for clangd

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. The text was written mostly by Sam McCall, screenshots are mostly made by me. Repository:

[PATCH] D58768: Moved SymbolLocation into its own header and implementation file

This revision was automatically updated to reflect the committed changes. Closed by commit rL355082: Moved SymbolLocation into its own header and implementation file (authored by gribozavr, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov. Herald added a project: LLVM.

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58773 Files:

[PATCH] D58778: Moved Ref into its own header and implementation file

gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58778 Files: clang-tools-extra/clangd/AST.h

[PATCH] D58721: Added release notes for clangd 8

gribozavr updated this revision to Diff 188555. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58721/new/ https://reviews.llvm.org/D58721 Files: clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Please also add a test for find references on a constructor. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.org/D58814

[PATCH] D58815: [clangd] Make sure constructors do not reference class

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/XRefsTests.cpp:1361 +} + )cpp", }; Add the new test right after the "Method call" test, to keep it

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

gribozavr added a comment. > These references were added to support using the index data for symbol rename. Understood -- thank you for providing the context (the original commit that added this code didn't have the explanation why this reference was added). However, my suggestion would be to

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

gribozavr added a comment. > The test coverage i have will be in the clang-tidy check. Please add unit tests to `clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp`. You can pull matchers from D57113 into the shared matchers library (instead of keeping them

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

gribozavr added a comment. macOS supports `pthread_setschedparam()` that we call on Linux, why not reuse the same code path? https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/pthread_setschedparam.3.html Repository: rCTE Clang Tools Extra

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

gribozavr added a comment. > My understanding is that the storage space taken up for Refs is currently 8 > bytes per Ref (4 each for the start and end positions), plus filename strings > which are deduplicated across all refs. If we add a SymbolID, that adds an > additional 8 bytes to each

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. I see, there's no SCHED_IDLE in the macOS SDK. OK then, I trust that people who wrote CIndex.cpp support for macOS probably have got it correctly working for macOS, so it makes sense

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58603 Files: clang-tools-extra/docs/README.txt Index: clang-tools-extra/docs/README.txt

[PATCH] D58601: Fixed grammar in index.rst

gribozavr created this revision. Herald added a subscriber: arphaman. Herald added a project: clang. gribozavr added a reviewer: ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58601 Files: clang-tools-extra/docs/index.rst Index:

[PATCH] D58602: Removed an unhelpful comment in index.rst

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: jdoerfert, arphaman. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58602 Files: clang-tools-extra/docs/index.rst Index:

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

gribozavr updated this revision to Diff 188133. gribozavr marked 2 inline comments as done. gribozavr added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58603/new/ https://reviews.llvm.org/D58603 Files:

[PATCH] D58602: Removed an unhelpful comment in index.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rL354777: Removed an unhelpful comment in index.rst (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58611: Fixed typos in tests: s/CHEKC/CHECK/

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jsji, javed.absar, nemanjai. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58611 Files: clang/test/CodeGenObjC/dllstorage.m

[PATCH] D58611: Fixed typos in tests: s/CHEKC/CHECK/

This revision was automatically updated to reflect the committed changes. Closed by commit rC354785: Fixed typos in tests: s/CHEKC/CHECK/ (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58611?vs=188143=188150#toc Repository: rC Clang CHANGES SINCE

[PATCH] D58607: Moved clangd docs to a separate directory in preparation to restructure them into multiple files

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tools-extra/docs/clangd.rst:1 - -Clangd - +:orphan: ilya-biryukov wrote: > Having this does page not seem useful in the long-run. > Do we

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

This revision was automatically updated to reflect the committed changes. Closed by commit rL354779: Updated the documentation build instructions for the current CMake build system (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D58607: Moved clangd docs to a separate directory in preparation to restructure them into multiple files

gribozavr created this revision. gribozavr added a reviewer: ilya-biryukov. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58607 Files:

[PATCH] D58601: Fixed grammar in index.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354778: Fixed grammar in index.rst (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58601?vs=188117=188135#toc Repository: rCTE Clang Tools Extra CHANGES

[PATCH] D58603: Updated the documentation build instructions for the current CMake build system

gribozavr added inline comments. Comment at: clang-tools-extra/docs/README.txt:6 +You can generate documentation in HTML format from files in +clang-tools-extra/docs by building the docs-clang-tools-html target. ilya-biryukov wrote: > ilya-biryukov wrote: > >

[PATCH] D58607: Moved clangd docs to a separate directory in preparation to restructure them into multiple files

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354786: Moved clangd docs to a separate directory in preparation to restructure them… (authored by gribozavr, committed by ). Changed prior to commit:

[PATCH] D39050: Add index-while-building support to Clang

gribozavr added inline comments. Herald added a subscriber: jdoerfert. Comment at: include/clang/Frontend/FrontendOptions.h:377 + /// The path to write index data to + std::string IndexStorePath; Please end comments with a period. Comment

[PATCH] D58979: [clang][OpenMP] Revert "OMPFlushClause is synthetic, no such clause exists"

gribozavr accepted this revision. gribozavr added a comment. > Hmm, do we really need the matches for the AST node that is not > described/defined by the standard? If this is really so, I'm ok with this. When the rubber meets the road, it does not matter what is in the spec, users will need to

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:269 + /// or if this is an OpenMP stand-alone directive returns `None`. + llvm::Optional getStructuredBlock() const; }; Why not `Stmt *` as a return value? Repository: rC Clang

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:266 + + /// Returns the AST statement representing OpenMP structured-block of this + /// OpenMP executable directive, "the AST node" Comment at:

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

gribozavr accepted this revision. gribozavr added a comment. Do we also need to change anything for constructor calls? If not, please add a test for that. Comment at: lib/Index/IndexDecl.cpp:251 + Ctor->getParent(), Ctor->getDeclContext(), +

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeComplete.cpp:1513 +template bool explicitTemplateSpecialization(const NamedDecl ) { + if (const auto *TD = dyn_cast())

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. +

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

gribozavr added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. + Cmd.CommandLine = tooling::getClangStripDependencyFileAdjuster()(

[PATCH] D58815: [clangd] Make sure constructors do not reference class

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clangd/XRefs.cpp:160 +if (Roles & static_cast(index::SymbolRole::NameReference)) + return true; if (Loc == SearchedLocation) { Maybe add a blank line so that it is clear

[PATCH] D59128: [clangd] Redirect clangd page.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Fancy! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59128/new/ https://reviews.llvm.org/D59128

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added a comment. As far as I'm concerned, I don't have any major revision requests. I haven't reviewed the unit tests (I'm planning to), but for non-test code, I don't have any further comments. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: unittests/AST/OMPStructuredBlockTest.cpp:64 +++i; +})"; + ASSERT_TRUE( Same comment as in the other patch -- I would prefer that the source is inlined into the ASSERT_TRUE, with implicit string concatenation and

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/AST/Stmt.h:102 +/// This bit is set only for the Stmt's that are the structured-block +/// of OpeMP [non-standalone] executable

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: unittests/AST/OMPStructuredBlockTest.cpp:64 +++i; +})"; + ASSERT_TRUE( lebedev.ri wrote: > gribozavr wrote: > > Same comment as in the other patch -- I would prefer that the source is > > inlined into the

[PATCH] D59407: [clangd] Add RelationSlab

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Index.h:59 +return sizeof(*this) + Arena.getTotalMemory() + + sizeof(value_type) * Relations.size(); + }

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6390 +/// Given OpenMP directive, matches the first clause (out of all specified), +/// that matches InnerMatcher. +/// Other comments usually don't explain the interactions

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6389 +/// Given OpenMP directive, matches if it is an OpenMP standalone directive, +/// i.e. an executable directive with no structured block. "Matches standalone OpenMP

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said matcher, + // and convert it to the

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: include/clang/AST/Stmt.h:102 +/// This bit is set only for the Stmt's that are the structured-block +/// of OpeMP [non-standalone] executable directives. +/// I.e. those returned by

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said matcher, + // and convert it to the

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said matcher, + // and convert it to the

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:269 + /// or if this is an OpenMP stand-alone directive returns `None`. + llvm::Optional getStructuredBlock() const; }; lebedev.ri wrote: > gribozavr wrote: > > Why not `Stmt *` as a

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

gribozavr added a comment. Sorry for the delay. I will finish reviewing tomorrow. Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:9 +/// \file +/// \brief Utility class for listening for file system changes in a directory.

[PATCH] D58749: [index-while-building] IndexRecordHasher

gribozavr added a comment. > I basically didn't really like the idea of testing against hard-coded hash > values in unittests as I consider it to be an implementation detail. Sorry, that's not what I was suggesting. There are better ways to test hashing. For example, write a piece of source

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: test/AST/ast-dump-openmp-atomic.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -ast-dump %s | FileCheck -strict-whitespace -implicit-check-not=openmp_structured_block %s + lebedev.ri wrote: >

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clangd/CodeComplete.cpp:1613 }; + // We only complete symbol's name, which is same as the class template in the + // case of template specializations. which is the same as the

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h:32 + +/// \brief Handles PPCallbacks and replays preprocessing with modules disabled. +/// replays => re-runs Repository: rG LLVM Github Monorepo

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.h:156 + virtual void registerPPCallbacks(const SourceManager , Preprocessor *PP, + Preprocessor *ModuleExpanderPP) {} + Please document that

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

gribozavr added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:208 +template <> +void ExceptionAnalyzer::analyze(const FunctionDecl *Func, +ExceptionInfo ) { I'd suggest to make it a non-template and call it

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

gribozavr accepted this revision. gribozavr marked an inline comment as done. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:166 +Preprocessor->Lex(CurrentToken);

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tidy/openmp/ExceptionEscapeCheck.cpp:53 + Finder->addMatcher(ompExecutableDirective( + unless(isStandaloneDirective()), +

[PATCH] D59407: [clangd] Add RelationSlab

gribozavr added inline comments. Comment at: clang-tools-extra/clangd/index/Relation.h:1 +//===--- Ref.h ---*- C++-*-===// +// gribozavr wrote: > "--- Relation.h " Not done?

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

gribozavr accepted this revision. gribozavr marked an inline comment as done. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/openmp/ExceptionEscapeCheck.cpp:53 + Finder->addMatcher(ompExecutableDirective( +

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

gribozavr accepted this revision. gribozavr marked an inline comment as done. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo

[PATCH] D59650: [NFC] ExceptionEscapeCheck: small refactoring

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.cpp:226 +ExceptionAnalyzer::ExceptionInfo +ExceptionAnalyzer::analyzeBoilerplate(const T *Node) { + ExceptionInfo ExceptionList;

[PATCH] D60055: Check i < FD->getNumParams() before querying

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. This fix makes sense to me, however, Richard Smith @rsmith is the best person to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

gribozavr added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:756 /// lazily. mutable llvm::DenseMap RedeclComments; The name of this variable (and `RawCommentAndCacheFlags`) don't make sense after the change.

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

gribozavr added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:728 - class RawCommentAndCacheFlags { + class CommentAndOrigin { public: `RawCommentAndOrigin`? Comment at: clang/include/clang/AST/ASTContext.h:751 -

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

gribozavr requested changes to this revision. gribozavr added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:27 +/// be invoked even if the directory is empty. +class DirectoryWatcher { +public:

[PATCH] D59407: [clangd] Add RelationSlab

gribozavr added inline comments. Comment at: clang-tools-extra/clangd/index/Index.cpp:35 +auto *Array = Arena.Allocate(Rels.size()); +std::uninitialized_copy(Rels.begin(), Rels.end(), Array); +Result.emplace_back(Entry.first, Use `ArrayRef::copy()`,

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/google/IntegerTypesCheck.cpp:57 // Find all TypeLocs. The relevant Style Guide rule only applies to C++. - if

  1   2   3   4   5   6   7   8   9   10   >