hintonda updated this revision to Diff 85291.
hintonda added a comment.
- Rebased.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseNoexceptCheck.h
hintonda updated this revision to Diff 85593.
hintonda marked 4 inline comments as done.
hintonda added a comment.
- Addressed comments and added additional test cases.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
hintonda added a comment.
Thanks and sorry for the breakage. Unfortunately, I'm unable to reproduce
locally (OSX), but will try to get access to linux box this weekend.
Seems to be related to memory corruption wrt to improper StringRef usage, but I
can't say for sure yet.
hintonda added a comment.
Great, thanks. Could you commit for me?
https://reviews.llvm.org/D20693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Thanks for all the feedback. I've tried to address all your comments, and
reworked the documentation. Please let me know if I missed or misunderstood
anything.
https://reviews.llvm.org/D20693
___
cfe-commits mailing
hintonda updated this revision to Diff 84926.
hintonda marked 22 inline comments as done.
hintonda added a comment.
- Add support for matching MemberPointerType's.
- Add noexcept(false) option plus test; allow invalid replacement ranges;
enhance diagnostics.
- Updated docs.
hintonda updated this revision to Diff 84975.
hintonda added a comment.
- Fix diagnostic when removing throwing specs.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
hintonda added a comment.
Aaron, I've got this version in a branch, so if you like, I'd be happy to apply
Malcolm's suggestions.
https://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hintonda updated this revision to Diff 83816.
hintonda added a comment.
- Address comments.
https://reviews.llvm.org/D20428
Files:
include/clang/AST/Decl.h
include/clang/AST/TypeLoc.h
lib/AST/Decl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaType.cpp
lib/Sema/TreeTransform.h
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:6-8
+The check converts dynamic exception specifications, e.g.,
+``throw()``, ``throw([,...])``, or ``throw(...)``, to
+``noexcept``, ``noexcept(false)``, blank, or a user defined
hintonda added a comment.
Sorry, but I do not have commit access.
https://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda marked 7 inline comments as done.
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:64
+ Finder->addMatcher(
+ parmVarDecl(hasType(pointerType(pointee(parenType(innerType(
+
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:68
+ this);
+}
+
aaron.ballman wrote:
> hintonda wrote:
> > aaron.ballman wrote:
> > > Also missing: typedefs and using declarations.
> > As far as I know, it isn't legal
hintonda updated this revision to Diff 83827.
hintonda marked an inline comment as done.
hintonda added a comment.
- Addressed comments.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
hintonda added a comment.
If you want this included in the 4.0 release, it needs to get in before they
branch tomorrow.
https://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hintonda updated this revision to Diff 83000.
hintonda added a comment.
Rollback previous change and instead only call
actOnDelayedExceptionSpecification if noexcept type is not EST_None.
https://reviews.llvm.org/D28258
Files:
lib/Parse/ParseCXXInlineMethods.cpp
Index:
hintonda added a comment.
Richard, what do you think about just avoiding the problem altogether by only
calling actOnDelayedExceptionSpecification is noexcept type != EST_None?
https://reviews.llvm.org/D28258
___
cfe-commits mailing list
hintonda added a comment.
Great, thanks. Spoke to Richard about it last night and believe he's
comfortable with this change, but I'll let him weigh in...
https://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hintonda updated this revision to Diff 83375.
hintonda added a comment.
- Addressed comments.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
hintonda added a comment.
I could be wrong (please let me know if I am), but my understanding is:
// Does not throw
throw() --> noexcept == noexcept(true)
// Does throw
throw(something) --> noexcept(false)
Please see http://en.cppreference.com/w/cpp/language/noexcept_spec
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3547
NoexceptRange = SourceRange(KeywordLoc, T.getCloseLocation());
-} else {
- NoexceptType = EST_None;
}
} else {
rsmith wrote:
> Should `NoexceptRange` be set in
hintonda created this revision.
hintonda added reviewers: sepavloff, rsmith, aaron.ballman.
hintonda added a subscriber: cfe-commits.
Treat invalid noexcept specifications in the same way we
treat invalid throw specifications, by not resetting the exception
type to EST_None, and testing isUsable
hintonda added a comment.
Matthias, I think you make a good point. While noexcept(expr) is valuable,
noexcept(false) adds no value. Therefore, I think we should do as you suggest,
i.e.:
s/throw()/noexcept/
s/throw(something)//
Aaron, does this work for you?
hintonda added a comment.
The problem is that when a noexcept(bool expr) specification is invalid, e.g.,
bad bool expr, the NoexceptType in Parser::tryParseExceptionSpecification is
set to EST_None and returned. This will mean the FunctionDecl type won't have
an exception TypeLoc, but the
hintonda updated this revision to Diff 83588.
hintonda added a comment.
- Omit noexcept(false) replacement except for dtor and operator delete.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
hintonda updated this revision to Diff 83346.
hintonda added a comment.
- Fix compile errors.
- When noexcept expr is invalid, set NoexceptType to EST_BasicNoexcept
https://reviews.llvm.org/D20428
Files:
include/clang/AST/Decl.h
include/clang/AST/TypeLoc.h
lib/AST/Decl.cpp
hintonda abandoned this revision.
hintonda added a comment.
Unable to test change here, so have included fix directly in
https://reviews.llvm.org/D20428.
https://reviews.llvm.org/D28258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hintonda updated this revision to Diff 83371.
hintonda added a comment.
Herald added subscribers: JDevlieghere, mgorny.
Updated patch.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.h:19
+
+using CandidateSet = llvm::StringSet;
+
malcolm.parsons wrote:
> Unused?
Good catch -- left over from a previous version.
Comment at:
hintonda added a comment.
Richard, is it okay to commit this?
https://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Cool, I'll try to play with this later today.
BTW, since the call to DiagnosticsEngine::Report is delayed when using
PartialDiagnostic, would it make sense to add them as well? Also, this doesn't
seem to solve the initial problem of finding the Diag name in the first
hintonda updated this revision to Diff 109472.
hintonda added a comment.
- Use cat|xargs which should work on window -- used in other tests.
https://reviews.llvm.org/D36252
Files:
test/Misc/find-diagnostic-id.c
tools/diagtool/FindDiagnosticID.cpp
Index:
hintonda added a comment.
You may want to add an ARG statement to force docker to rerun the svn commands
each time you invoke `docker build`. Otherwise it will reuse the cache since
docker only looks at the RUN text, not it's result.
To get around that, you can add an `ARG REVISION`
hintonda added a comment.
> I'd avoid such extra complexity, after all this is just an example.
Understood... LGTM
> BTW, my old svn (1.8.8, Ubuntu 14.04) does't have "info --show-item revision"
Guess my new macbook pro spoiled me...
https://reviews.llvm.org/D36635
hintonda added a comment.
It's just an effort to make the code a bit more accessible, especially for new
users (or ones not used to running find/grep).
Steve had suggested adding an option that took the entire message and matched
it when it was produced. However, that won't work very well
hintonda updated this revision to Diff 106094.
hintonda added a comment.
- Only maintain enum names in debug builds. Current cost of maintaining enum
names is 176k.
https://reviews.llvm.org/D35175
Files:
include/clang/Basic/DiagnosticIDs.h
include/clang/Basic/DiagnosticOptions.def
hintonda created this revision.
This option helps locate the origin of a diagnostic message
by outputing the enum name and index associated with a specific
DiagID, allowing users to grep the code for the enum name directly
without having to find it in the td files first.
Additional ideas:
1.
hintonda updated this revision to Diff 105961.
hintonda added a comment.
- Make option cc1 only. Rename function, and add test.
https://reviews.llvm.org/D35175
Files:
include/clang/Basic/DiagnosticIDs.h
include/clang/Basic/DiagnosticOptions.def
include/clang/Driver/CC1Options.td
hintonda added a comment.
Great, thanks...
https://reviews.llvm.org/D35175
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda abandoned this revision.
hintonda added a comment.
Okay, sounds good. Look forward to seeing Alex's script...
https://reviews.llvm.org/D35175
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hintonda added a comment.
Not sure how to do this all in a script, but perhaps we could enhance diagtool
to generate this mapping for you. It currently only lists warnings, but I
don't think it would be difficult to extend it and generate a mapping you could
use in your script.
hintonda added a comment.
I'd be happy to do that if it would help. If so, should I do it here create a
new diff?
Perhaps we might even make sense add the ability to pass in a message and find
the matching name/index.
https://reviews.llvm.org/D35175
hintonda accepted this revision.
hintonda added a comment.
This revision is now accepted and ready to land.
LGTM.
Category ids' might be useful, but I'd wait until someone actually needs them.
Repository:
rL LLVM
https://reviews.llvm.org/D35306
hintonda added inline comments.
Comment at: lib/Basic/CMakeLists.txt:17
macro(find_first_existing_vc_file out_var path)
set(git_path "${path}/.git")
LLVM already has a version of find_first_existing_vc_file in
llvm/include/llvm/Support/CMakelists.txt.
hintonda added a comment.
ping...
https://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
This is a good example of how to script lldb, but it's predicated on knowing
the diag name, which is great if you know the name.
However, this isn't my use case. I don't have the diag name, just a diagnostic
message. In order to get the diag name associated with a
hintonda added a comment.
In https://reviews.llvm.org/D36083#827745, @arphaman wrote:
> Makes sense. I'll see if I can get somewhere with the regex idea.
Btw, I created a quick prototype with sed and found that the diag strings
aren't unique -- which isn't surprising since there's no
hintonda updated this revision to Diff 109949.
hintonda added a comment.
- Use temp files instead of temp dir.
https://reviews.llvm.org/D36347
Files:
CMakeLists.txt
utils/CMakeLists.txt
utils/run_lldb.sh.in
Index: utils/run_lldb.sh.in
hintonda added a comment.
Looks good, but I'll defer to the owners.
Minor nit...
Comment at: lib/Driver/ToolChains/MSVC.cpp:142
return true;
+} else if (llvm::sys::path::filename(ParentPath) == "x86ret"
+|| llvm::sys::path::filename(ParentPath)
hintonda added a comment.
In https://reviews.llvm.org/D36857#845465, @thakis wrote:
> Oh, I guess this is superseded by https://reviews.llvm.org/D36860 ?
Yes, please ignore this patch -- it was just for brainstorming... ;-)
Comment at: lib/Driver/ToolChains/MSVC.cpp:135
+
hintonda added a comment.
Here's a simple example that demonstrates the corruption I'm seeing:
#include "llvm/ADT/StringRef.h"
int main() {
std::string ss = "";
llvm::StringRef Ref = true ? "noexcept" : ss;
std::string s = Ref;
return 0;
}
https://reviews.llvm.org/D20693
hintonda updated this revision to Diff 101860.
hintonda added a comment.
- Make sure types for ternary operator are the same.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
hintonda updated this revision to Diff 102103.
hintonda added a comment.
- Addressed comments.
https://reviews.llvm.org/D17143
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/nested-name-spec.cpp
Index: test/SemaCXX/nested-name-spec.cpp
hintonda updated this revision to Diff 102292.
hintonda added a comment.
Rebase, fix test, and add FIXME note.
https://reviews.llvm.org/D16971
Files:
lib/Sema/SemaTemplate.cpp
test/SemaTemplate/partial-spec-fully-specified.cpp
Index: test/SemaTemplate/partial-spec-fully-specified.cpp
hintonda added a comment.
ping...
https://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda created this revision.
Reset ScopeSpec when parsing class, struct, etc.. Fixes PR32953.
https://reviews.llvm.org/D34383
Files:
lib/Parse/ParseDecl.cpp
test/SemaTemplate/instantiate-complete.cpp
Index: test/SemaTemplate/instantiate-complete.cpp
hintonda added a comment.
I have not, as yet, been able to reproduce the buildbot failures. They were
essentially intermittent seg-faults, and corrupt diag output.
I will work on creating a test that can reproduce the problem.
https://reviews.llvm.org/D20693
hintonda added a comment.
Since I don't have commit access, could you commit this for me?
thanks...
don
https://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hintonda updated this revision to Diff 101819.
hintonda added a comment.
- Rollback last change.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
hintonda added a comment.
Just ran asan on linux and we have a heap-use-after-free in the std::string
ctor.
Here's a partial stack dump:
4980==ERROR: AddressSanitizer: heap-use-after-free on address 0x60424328 at
pc 0x0057ad32 bp 0x7ffd240a7f50 sp 0x7ffd240a7700
hintonda added a comment.
btw, here's how I built it, in case that matters...
CC=../../4.0.0/build/Release/bin/clang
CXX=../../4.0.0/build/Release/bin/clang++ \
cmake ../../llvm/ \
-GNinja \
-DLLVM_USE_SANITIZER=Address \
-DCMAKE_BUILD_TYPE=Debug \
-DLLVM_TARGETS_TO_BUILD="X86" \
hintonda added a comment.
Unfortunately, the logs are no longer available, and I don't have copies.
However, I think I know what's going on, so I'll try to submit a fix later
today.
https://reviews.llvm.org/D20693
___
cfe-commits mailing list
hintonda updated this revision to Diff 101708.
hintonda added a comment.
- Rollback to previous version: rebased + r293218 and r293234.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
hintonda added a comment.
Great, thanks for you help.
Could you commit this for me?
https://reviews.llvm.org/D20693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda reopened this revision.
hintonda added a comment.
This revision is now accepted and ready to land.
Reopening due to test failures on Linux -- was rolled back.
https://reviews.llvm.org/D20693
___
cfe-commits mailing list
hintonda updated this revision to Diff 101659.
hintonda added a comment.
Herald added a subscriber: xazax.hun.
In order to fix diagnostic corruption in some of the buildbot tests
(unable to reproduce locally):
- make NoexceptMacro a static variable so it's lifetime doesn't end when
hintonda updated this revision to Diff 101722.
hintonda added a comment.
- Only pass %2 parameter if %2 is included in format.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
hintonda updated this revision to Diff 102049.
hintonda added a comment.
Rebase and move test to existing file.
https://reviews.llvm.org/D17143
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/nested-name-spec.cpp
Index: test/SemaCXX/nested-name-spec.cpp
hintonda added a comment.
I have, but just haven't heard back yet... Thanks again...
https://reviews.llvm.org/D34179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Great, thanks Aaron.
Could you commit it for me when you get a chance?
https://reviews.llvm.org/D34179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda closed this revision.
hintonda added a comment.
Committed in r305169.
https://reviews.llvm.org/D17143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda created this revision.
Handle -ast-dump-all when passed as the only option.
https://reviews.llvm.org/D34179
Files:
lib/Frontend/ASTConsumers.cpp
test/Coverage/ast-printing.c
test/Coverage/ast-printing.cpp
Index: test/Coverage/ast-printing.cpp
hintonda added a comment.
Great, thanks John.
Yes, that's correct -- I do not have commit access.
https://reviews.llvm.org/D17215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda updated this revision to Diff 101482.
hintonda added a comment.
Fixes PR14211.
Since getMostSpecialized only handles FunctionTemplateDecl matches,
keep track of non-FunctionTemplateDecl matches and only call
getMostSpecialized if no non-FunctionTemplateDecl matches are found.
Added
hintonda updated this revision to Diff 101503.
hintonda added a comment.
- Addressed comments.
https://reviews.llvm.org/D17215
Files:
lib/Sema/SemaTemplate.cpp
test/CXX/temp/temp.decls/temp.mem/p5.cpp
Index: test/CXX/temp/temp.decls/temp.mem/p5.cpp
hintonda added a comment.
LGTM...
https://reviews.llvm.org/D36806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
Now that 36971 has been committed, I believe you can just remove the
`find_first_existing_file` and `find_first_existing_vc_file` macro definitions
from this file.
https://reviews.llvm.org/D35533
___
cfe-commits mailing
hintonda accepted this revision.
hintonda added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D35533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hintonda added a comment.
In https://reviews.llvm.org/D35533#862798, @minseong.kim wrote:
> Hi~ @hintonda,
>
> Using using find_first_existing_file in ADDLLVM.cmake solves the cases with
> repo in conjunction with https://reviews.llvm.org/D35532. However, I am not
> sure it can handle
hintonda added a comment.
In https://reviews.llvm.org/D35533#862852, @minseong.kim wrote:
> @hintonda, Absolutely. Incorporating @modocache's module changes into the
> version in AddLLVM.cmake would solve the current version display issue for
> repo and do not affect the process of other
hintonda added a comment.
I just looked into both approaches and believe the one taken in AddLLVM.cmake
is correct and handles the submodule case correctly. It uses `git rev-parse
--git-dir` to find the location of the actual .git directory.
Please see https://reviews.llvm.org/D31985 for
hintonda added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:505
-assert(!Err &&
- "Replacements must not conflict since ranges have been merged.");
-llvm::consumeError(std::move(Err));
While obviously correct, are you concerned
hintonda added a comment.
ping...
https://reviews.llvm.org/D36347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:505
-assert(!Err &&
- "Replacements must not conflict since ranges have been merged.");
-llvm::consumeError(std::move(Err));
srhines wrote:
> hintonda wrote:
> >
hintonda added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:505
-assert(!Err &&
- "Replacements must not conflict since ranges have been merged.");
-llvm::consumeError(std::move(Err));
srhines wrote:
> hintonda wrote:
> > While
hintonda added a comment.
It's just too bad llvm::cantFail() doesn't take an optional string.
But the code is cleaner, so I won't comment further.
https://reviews.llvm.org/D36806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hintonda added a comment.
I've submitted a patch, https://reviews.llvm.org/D36971, that moves
find_first_existing_file and
find_first_existing_vc_file to ADDLLVM so they can be reused here. If that
patch is accepted and lands,
you can then remove these versions and check to see if that solves
hintonda added a comment.
ping...
https://reviews.llvm.org/D36347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda created this revision.
hintonda added reviewers: zturner, aprantl.
Herald added a subscriber: JDevlieghere.
Now that r320495, "[debuginfo-tests] Support moving
debuginfo-tests to llvm/projects," has landed, remove temporary FIXME
that supported the old mechanism.
Repository:
rC Clang
hintonda created this revision.
hintonda added a reviewer: EricWF.
This warning is already suppressed on non-apple platforms, so
this change just suppresses it on apple as well.
Repository:
rCXX libc++
https://reviews.llvm.org/D41248
Files:
src/experimental/filesystem/operations.cpp
hintonda added inline comments.
Comment at: include/clang/Config/config.h.cmake:40
+#cmakedefine CLANG_CONFIG_FILE_SYSTEM_DIR ${CLANG_CONFIG_FILE_SYSTEM_DIR}
+#cmakedefine CLANG_CONFIG_FILE_USER_DIR ${CLANG_CONFIG_FILE_USER_DIR}
+
These need to be in quotes
hintonda created this revision.
Herald added subscribers: cfe-commits, JDevlieghere, mgorny.
The new version of debuginfo-tests will have it's own
lit.cfg.py file which is incompatible with the one in clang/test.
This change supports both the old and new versions, and can be used
until the bots
hintonda added a comment.
Thanks for the quick feedback. I'll make all you suggested changes, but need
to think a little more about `diagtool`.
Comment at: utils/clangdiag.py:75-78
+diagtool = os.path.join(exe.GetDirectory(), 'diagtool')
+if not
hintonda updated this revision to Diff 120308.
hintonda added a comment.
Reimplement at a python module.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
--- /dev/null
+++
hintonda updated this revision to Diff 120340.
hintonda edited the summary of this revision.
hintonda added a comment.
Herald added a subscriber: ilya-biryukov.
- Addressed comments.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
hintonda added inline comments.
Comment at: utils/clangdiag.py:83
+# Remove all diag breakpoints.
+bkpts = lldb.SBBreakpointList(target)
+target.FindBreakpointsByName("clang::Diagnostic", bkpts)
Can't use iterator because it gets invalidated and not
hintonda updated this revision to Diff 120360.
hintonda added a comment.
- Add diagtool option used to set arbitrary diagtool path.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
---
hintonda updated this revision to Diff 120518.
hintonda added a comment.
- Maintain process id map for diagtool.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
--- /dev/null
+++
hintonda updated this revision to Diff 120538.
hintonda added a comment.
- Add ability to add breakpoints matching -W warnings.
https://reviews.llvm.org/D36347
Files:
utils/clangdiag.py
Index: utils/clangdiag.py
===
---
hintonda added a comment.
In https://reviews.llvm.org/D36347#901885, @zturner wrote:
> One possible reason for why this never got any traction is that
> `lldb-commits` wasn't added as a subscriber. While it's true that the tagged
> people should have chimed in, having the whole commits list
1 - 100 of 332 matches
Mail list logo
