[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

hintonda added a comment. In D62873#1530197 , @Szelethus wrote: > I seem to have missed out on previous commits that moved analyzer plugins > around -- would you mind adding `[analyzer]` to the revision names that > affect the Static Analyzer? Many of us

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. In D61697#1543443 , @thakis wrote: > I reverted this in r363379 to unbreak check-lld on mac. I think the > > if config.enable_shared: > features.add("enable_shared") > > > bit belongs in clang/test/lit.cfg.py

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda added a comment. In D59754#1543949 , @sokolovd wrote: > This looks like exactly what we need for my project. We're using Clang and > Designated Initializers but would like to make sure that we use those in > C++20 compatible manner. Is this bloc

[PATCH] D62839: [clangd] Index API and implementations for relations

hintonda added a comment. This seems to have broken gcc 5.4 builds -- for example see http://lab.llvm.org:8011/builders/clang-cmake-armv7-lnt/builds/29/steps/build%20stage%201/logs/stdio. I believe the following patch should fix the problem: diff --git a/clang-tools-extra/clangd/index/FileInd

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

hintonda added a comment. This test fails to compile on Windows 64 bit builds. Please see http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/77 Comment at: cfe/trunk/test/Analysis/inlining/placement-new-fp-suppression.cpp:16 + +typedef unsigned long uintptr_t; +

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1613268 , @NoQ wrote: > Ugh, there seems to be one more forgotten buildbot with plugins problems: > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6406/consoleText > > FAIL: Clang :: Analysis/checker-plu

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1613268 , @NoQ wrote: > Ugh, there seems to be one more forgotten buildbot with plugins problems: > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6406/consoleText > It got suddenly fixed in > http://

[PATCH] D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class.

hintonda updated this revision to Diff 208736. hintonda added a comment. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Make GeneralCategory a ManagedStatic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

hintonda added inline comments. Comment at: clang-tools-extra/test/clang-tidy/modernize-loop-convert-basic.cpp:273 + for (S::const_iterator It = Ss.begin(), E = Ss.end(); It != E; ++It) { +printf("s has value %d\n", (*It).X); I think you need to fix the c

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

hintonda added a comment. In D61827#1499160 , @lebedev.ri wrote: > This will now trigger on https://godbolt.org/z/9oFMcB right? > Just want to point out that this will then have "false-positives" when that > loop > is an OpenMP for loop, since range-for

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

hintonda added a comment. In D61827#1499303 , @torbjoernk wrote: > In D61827#1499184 , @lebedev.ri > wrote: > > > In D61827#1499183 , @hintonda > > wrote: > > > > > In D618

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

hintonda added a comment. In D61827#1499309 , @lebedev.ri wrote: > In D61827#1499306 , @hintonda wrote: > > > In D61827#1499303 , @torbjoernk > > wrote: > > > > > In D61827#

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

hintonda added a comment. In D61827#1499335 , @lebedev.ri wrote: > In D61827#1499333 , @hintonda wrote: > > > When I asked for a test above, I understood you to say you couldn't provide > > one, but If I misunderst

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

hintonda added a comment. I pulled down you patch, compiled and ran it. Once I fixed the two problems I mentioned, it ran clean, e.g.: $ bin/llvm-lit -vv ../../llvm-project/clang-tools-extra/test/clang-tidy/modernize-loop-convert-[be]*.cpp -- Testing: 2 tests, 2 threads -- PASS: Clang To

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

hintonda added a comment. In D61827#1499368 , @lebedev.ri wrote: > In D61827#1499347 , @hintonda wrote: > > > > >> Are you saying this patch is a regression? > > Not in general, no. This is most certainly an im

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. Awesome, thanks... LGTM, but you may want to give @alexfh or @aaron.ballman a day to comment before you commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61827/new/ https://

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

hintonda added a comment. I'll be happy to commit for you, but will give it till tomorrow just to make sure no one else has any additional comments. Thanks again! Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-loop-convert.rst:262 +not been used on code with

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

hintonda added a comment. I've also had issues with this behavior. It's a bad default, as the PR notes, but is there a way to provide a better one and still respect the config file? Also, could you add a test for this? Perhaps in `clang-tools-extra/test//clang-tidy/run-clang-tidy.cpp`. Repo

[PATCH] D61756: Add a __FILE_NAME__ macro.

hintonda added a comment. In D61756#1504109 , @kristina wrote: > Reverted in rL360842 as Windows bots were > failing. > > I suspect the `MSVCCompat` case may need to be handled differently depending > on the host OS si

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

hintonda added a comment. After thinking about it, I agree with this change -- there's no way to provide an appropriate default at this level. So, LGTM, but wait for @alexfh's okay. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61747/new/ https://

[PATCH] D62138: [Docs] Increase Doxygen cache size

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. Thanks, LGTM! I'll give it a day for further comments, and barring any, commit it for you tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added inline comments. Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() This is a breaking patch. What's the rational for unilaterally disabl

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added inline comments. Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() hintonda wrote: > This is a breaking patch. What's the rational for u

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

hintonda added a comment. Great idea. Please see D61747 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62157/new/ https://reviews.llvm.org/D62157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM. If no further comments, I'll commit it for you tomorrow. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61747/new/ https://reviews.llvm

[PATCH] D62157: Remove explicit header-filter in run_clang_tidy.py

hintonda added a comment. In D62157#1509289 , @juliehockett wrote: > @hintonda Aha so it is :) I don't think it's at all controversial, so I'll commit D61747 tomorrow unless someone raises an issue. Thanks... CHANG

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61697/new/ https://reviews.llvm.org/D61697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added a comment. In D62050#1509400 , @vitalybuka wrote: > In D62050#1509384 , @vitalybuka > wrote: > > > This also breaks "ninja check-cfi-and-supported" on clean build (run cmake > > in empty directory)

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM. Build and check-llvm were both clean on my Mac for static build. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62174/new/ https://reviews.l

[PATCH] D62343: [cmake] Remove old unused version of FindZ3.cmake from clang [NFC]

hintonda created this revision. hintonda added reviewers: mikhail.ramalho, beanz. Herald added a subscriber: mgorny. Herald added a project: clang. This file was moved to llvm in D54978 , r356929, but the old file was never removed. Repository: rG LLVM Github

[PATCH] D62445: [test] Fix plugin tests

hintonda created this revision. hintonda added reviewers: beanz, phosek, george.karpenkov, NoQ, ahatanak, rjmccall. Herald added subscribers: llvm-commits, dexonsmith, mgorny. Herald added projects: clang, LLVM. hintonda edited the summary of this revision. The following changes were required to

[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/test/CMakeLists.txt:141-147 - if (LLVM_WITH_Z3) -add_lit_testsuite(check-clang-analyzer-z3 "Running the Clang analyzer tests, using Z3 as a solver" - ${CMAKE_CURRENT_BINARY_DIR

[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/test/CMakeLists.txt:141-147 - if (LLVM_WITH_Z3) -add_lit_testsuite(check-clang-analyzer-z3 "Running the Clang analyzer tests, using Z3 as a solver" - ${CMAKE_CURRENT_BINARY_DIR

[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: cfe/trunk/test/CMakeLists.txt:140 - set_target_properties(check-clang-analyzer PROPERTIES FOLDER "Clang tests") - - if (LLVM_WITH_Z3) thakis wrote: > Did you intentionally de

[PATCH] D41055: [debuginfo-tests] Add support for moving debuginfo-tests from clang/test to llvm/projects or monorepo.

hintonda created this revision. Herald added subscribers: cfe-commits, JDevlieghere, mgorny. The new version of debuginfo-tests will have it's own lit.cfg.py file which is incompatible with the one in clang/test. This change supports both the old and new versions, and can be used until the bots ac

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda added a comment. In D59754#1651894 , @rsmith wrote: > I'm taking this over to finish it off and submit. Thanks Richard... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1630518 , @NoQ wrote: > I didn't make much progress so far, but i marked the test as `// UNSUPPORTED: > darwin` in rC368765 , so the buildbot is > now green starting with > http://gr

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

hintonda added a comment. Cool, I'll try to play with this later today. BTW, since the call to DiagnosticsEngine::Report is delayed when using PartialDiagnostic, would it make sense to add them as well? Also, this doesn't seem to solve the initial problem of finding the Diag name in the first

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

hintonda added a comment. This is a good example of how to script lldb, but it's predicated on knowing the diag name, which is great if you know the name. However, this isn't my use case. I don't have the diag name, just a diagnostic message. In order to get the diag name associated with a sp

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

hintonda added a comment. In https://reviews.llvm.org/D36083#827745, @arphaman wrote: > Makes sense. I'll see if I can get somewhere with the regex idea. Btw, I created a quick prototype with sed and found that the diag strings aren't unique -- which isn't surprising since there's no requireme

[PATCH] D36252: [diagtool] Add ability to get name from id

hintonda updated this revision to Diff 109472. hintonda added a comment. - Use cat|xargs which should work on window -- used in other tests. https://reviews.llvm.org/D36252 Files: test/Misc/find-diagnostic-id.c tools/diagtool/FindDiagnosticID.cpp Index: tools/diagtool/FindDiagnosticID.cpp

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

hintonda updated this revision to Diff 109949. hintonda added a comment. - Use temp files instead of temp dir. https://reviews.llvm.org/D36347 Files: CMakeLists.txt utils/CMakeLists.txt utils/run_lldb.sh.in Index: utils/run_lldb.sh.in =

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

hintonda added a comment. You may want to add an ARG statement to force docker to rerun the svn commands each time you invoke `docker build`. Otherwise it will reuse the cache since docker only looks at the RUN text, not it's result. To get around that, you can add an `ARG REVISION` declaratio

[PATCH] D36635: Add a Dockerfile for clang-proto-fuzzer

hintonda added a comment. > I'd avoid such extra complexity, after all this is just an example. Understood... LGTM > BTW, my old svn (1.8.8, Ubuntu 14.04) does't have "info --show-item revision" Guess my new macbook pro spoiled me... https://reviews.llvm.org/D36635 ___

[PATCH] D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure

hintonda added a comment. Looks good, but I'll defer to the owners. Minor nit... Comment at: lib/Driver/ToolChains/MSVC.cpp:142 return true; +} else if (llvm::sys::path::filename(ParentPath) == "x86ret" +|| llvm::sys::path::filename(ParentPath) =

[PATCH] D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking.

hintonda added a comment. In https://reviews.llvm.org/D36857#845465, @thakis wrote: > Oh, I guess this is superseded by https://reviews.llvm.org/D36860 ? Yes, please ignore this patch -- it was just for brainstorming... ;-) Comment at: lib/Driver/ToolChains/MSVC.cpp:135 +

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo

hintonda added a comment. I've submitted a patch, https://reviews.llvm.org/D36971, that moves find_first_existing_file and find_first_existing_vc_file to ADDLLVM so they can be reused here. If that patch is accepted and lands, you can then remove these versions and check to see if that solves

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

hintonda added a comment. ping... https://reviews.llvm.org/D36347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

hintonda added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:505 -assert(!Err && - "Replacements must not conflict since ranges have been merged."); -llvm::consumeError(std::move(Err)); While obviously correct, are you concerned

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

hintonda added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:505 -assert(!Err && - "Replacements must not conflict since ranges have been merged."); -llvm::consumeError(std::move(Err)); srhines wrote: > hintonda wrote: > > While

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

hintonda added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:505 -assert(!Err && - "Replacements must not conflict since ranges have been merged."); -llvm::consumeError(std::move(Err)); srhines wrote: > hintonda wrote: > > srhine

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

hintonda added a comment. It's just too bad llvm::cantFail() doesn't take an optional string. But the code is cleaner, so I won't comment further. https://reviews.llvm.org/D36806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda added a comment. In D42459#2383753 , @ldionne wrote: > @hintonda Is there a reason why this was done except for "standardizing the > usage across projects"? It was just for standardization. Please feel free to rollback or modify as necessary.

[PATCH] D70259: [Error] Add source location to cantFail

hintonda updated this revision to Diff 230125. hintonda added a comment. Herald added subscribers: lldb-commits, cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added projects: clang, LLDB. - Replace macro magic with matching 3-parameter template functions. - Refactor cantFail move in

[PATCH] D70259: [Error] Add source location to cantFail

hintonda updated this revision to Diff 230131. hintonda added a comment. - Add back original llvm::cantFail signatures so they'll still be Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70259/new/ https://reviews.llvm.org/D70259 Files: clang-tool

[PATCH] D42490: [cmake] Set cmake policy CMP0068 to suppress warnings on OSX

hintonda abandoned this revision. hintonda added a comment. Not needed for llvm+clang builds. Repository: rC Clang https://reviews.llvm.org/D42490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

hintonda updated this revision to Diff 120308. hintonda added a comment. Reimplement at a python module. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/null +++ utils/clangdiag.p

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added a comment. Thanks for the quick feedback. I'll make all you suggested changes, but need to think a little more about `diagtool`. Comment at: utils/clangdiag.py:75-78 +diagtool = os.path.join(exe.GetDirectory(), 'diagtool') +if not os.path.exists(diagtoo

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120340. hintonda edited the summary of this revision. hintonda added a comment. Herald added a subscriber: ilya-biryukov. - Addressed comments. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py =

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added inline comments. Comment at: utils/clangdiag.py:83 +# Remove all diag breakpoints. +bkpts = lldb.SBBreakpointList(target) +target.FindBreakpointsByName("clang::Diagnostic", bkpts) Can't use iterator because it gets invalidated and not a

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120360. hintonda added a comment. - Add diagtool option used to set arbitrary diagtool path. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added a comment. Thanks for the feedback (addressed below). btw, where should this module go? Since it's intended for clang, and clang based tool, developers, I put it in `clang/utils`, but Zackery suggested `lldb/examples/python` might be a better place. Please let me know if anyone

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120459. hintonda added a comment. - Enhance diagtool option to check, reset, print out current value. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py ===

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added a comment. In https://reviews.llvm.org/D36347#908186, @zturner wrote: > Do I understand correctly that this will insert breakpoints on *all* clang > diagnostics? That's not necessarily bad, but I was under the impression > originally that it would let you pick the diagnostics yo

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120492. hintonda added a comment. - Remove debugging print statement, and enhance help message. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added a comment. Is there a way to associate a particular diagtool variable to an exe_ctx? https://reviews.llvm.org/D36347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120518. hintonda added a comment. - Maintain process id map for diagtool. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/null +++ utils/cla

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120538. hintonda added a comment. - Add ability to add breakpoints matching -W warnings. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/nul

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120628. hintonda added a comment. - Add support for individual DiagID's, and print out number of breakpoints added. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120629. hintonda added a comment. - Remove whitespace. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/null +++ utils/clangdiag.py @@ -0,0 +

[PATCH] D20428: Tracking exception specification source locations

hintonda added a comment. The problem is that when a noexcept(bool expr) specification is invalid, e.g., bad bool expr, the NoexceptType in Parser::tryParseExceptionSpecification is set to EST_None and returned. This will mean the FunctionDecl type won't have an exception TypeLoc, but the Type

[PATCH] D28258: [Sema] Handle invalid noexcept expressions correctly.

hintonda created this revision. hintonda added reviewers: sepavloff, rsmith, aaron.ballman. hintonda added a subscriber: cfe-commits. Treat invalid noexcept specifications in the same way we treat invalid throw specifications, by not resetting the exception type to EST_None, and testing isUsable i

[PATCH] D28258: [Sema] Handle invalid noexcept expressions correctly.

hintonda added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3547 NoexceptRange = SourceRange(KeywordLoc, T.getCloseLocation()); -} else { - NoexceptType = EST_None; } } else { rsmith wrote: > Should `NoexceptRange` be set in the

[PATCH] D28258: [Sema] Handle invalid noexcept expressions correctly.

hintonda added a comment. Richard, what do you think about just avoiding the problem altogether by only calling actOnDelayedExceptionSpecification is noexcept type != EST_None? https://reviews.llvm.org/D28258 ___ cfe-commits mailing list cfe-commit

[PATCH] D28258: [Sema] Handle invalid noexcept expressions correctly.

hintonda updated this revision to Diff 83000. hintonda added a comment. Rollback previous change and instead only call actOnDelayedExceptionSpecification if noexcept type is not EST_None. https://reviews.llvm.org/D28258 Files: lib/Parse/ParseCXXInlineMethods.cpp Index: lib/Parse/ParseCXXInl

[PATCH] D20428: Tracking exception specification source locations

hintonda updated this revision to Diff 83346. hintonda added a comment. - Fix compile errors. - When noexcept expr is invalid, set NoexceptType to EST_BasicNoexcept https://reviews.llvm.org/D20428 Files: include/clang/AST/Decl.h include/clang/AST/TypeLoc.h lib/AST/Decl.cpp lib/Parse/Par

[PATCH] D28258: [Sema] Handle invalid noexcept expressions correctly.

hintonda abandoned this revision. hintonda added a comment. Unable to test change here, so have included fix directly in https://reviews.llvm.org/D20428. https://reviews.llvm.org/D28258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 83371. hintonda added a comment. Herald added subscribers: JDevlieghere, mgorny. Updated patch. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCh

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.h:19 + +using CandidateSet = llvm::StringSet; + malcolm.parsons wrote: > Unused? Good catch -- left over from a previous version. Comment at: docs/clang-tidy/chec

[PATCH] D20428: Tracking exception specification source locations

hintonda added a comment. Great, thanks. Spoke to Richard about it last night and believe he's comfortable with this change, but I'll let him weigh in... https://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 83375. hintonda added a comment. - Addressed comments. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-tidy/modernize/UseNoexcep

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. I could be wrong (please let me know if I am), but my understanding is: // Does not throw throw() --> noexcept == noexcept(true) // Does throw throw(something) --> noexcept(false) Please see http://en.cppreference.com/w/cpp/language/noexcept_spec https://reviews.llvm

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Matthias, I think you make a good point. While noexcept(expr) is valuable, noexcept(false) adds no value. Therefore, I think we should do as you suggest, i.e.: s/throw()/noexcept/ s/throw(something)// Aaron, does this work for you? https://reviews.llvm.org/D20

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 83588. hintonda added a comment. - Omit noexcept(false) replacement except for dtor and operator delete. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseN

[PATCH] D20428: Tracking exception specification source locations

hintonda added a comment. Richard, is it okay to commit this? https://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20428: Tracking exception specification source locations

hintonda added a comment. Aaron, I've got this version in a branch, so if you like, I'd be happy to apply Malcolm's suggestions. https://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D20428: Tracking exception specification source locations

hintonda updated this revision to Diff 83816. hintonda added a comment. - Address comments. https://reviews.llvm.org/D20428 Files: include/clang/AST/Decl.h include/clang/AST/TypeLoc.h lib/AST/Decl.cpp lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaType.cpp lib/Sema/TreeTransform.h lib/Se

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda marked 7 inline comments as done. hintonda added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:64 + Finder->addMatcher( + parmVarDecl(hasType(pointerType(pointee(parenType(innerType( + functionProtoType(hasDynamicExcept

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 83827. hintonda marked an inline comment as done. hintonda added a comment. - Addressed comments. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexcept

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:68 + this); +} + aaron.ballman wrote: > hintonda wrote: > > aaron.ballman wrote: > > > Also missing: typedefs and using declarations. > > As far as I know, it isn't legal t

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:6-8 +The check converts dynamic exception specifications, e.g., +``throw()``, ``throw([,...])``, or ``throw(...)``, to +``noexcept``, ``noexcept(false)``, blank, or a user defined macro.

[PATCH] D20428: Tracking exception specification source locations

hintonda added a comment. If you want this included in the 4.0 release, it needs to get in before they branch tomorrow. https://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D20428: Tracking exception specification source locations

hintonda added a comment. Sorry, but I do not have commit access. https://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 84926. hintonda marked 22 inline comments as done. hintonda added a comment. - Add support for matching MemberPointerType's. - Add noexcept(false) option plus test; allow invalid replacement ranges; enhance diagnostics. - Updated docs. https://reviews.llvm

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Thanks for all the feedback. I've tried to address all your comments, and reworked the documentation. Please let me know if I missed or misunderstood anything. https://reviews.llvm.org/D20693 ___ cfe-commits mailing lis

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 84975. hintonda added a comment. - Fix diagnostic when removing throwing specs. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 85291. hintonda added a comment. - Rebased. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-tidy/modernize/UseNoexceptCheck.h

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 85593. hintonda marked 4 inline comments as done. hintonda added a comment. - Addressed comments and added additional test cases. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Great, thanks. Could you commit for me? https://reviews.llvm.org/D20693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Thanks and sorry for the breakage. Unfortunately, I'm unable to reproduce locally (OSX), but will try to get access to linux box this weekend. Seems to be related to memory corruption wrt to improper StringRef usage, but I can't say for sure yet. https://reviews.llv

<    1   2   3   4   >