[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL332193: Added atomic_fetch_min, max, umin, umax intrinsics to clang. (authored by delena, committed by ). Changed prior to commit: https://reviews.llvm.org/D46386?vs=146462=146502#toc Repository: rL

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

delena added a comment. In https://reviews.llvm.org/D46386#1096833, @rjmccall wrote: > The actual semantic parts of the diff seem to have disappeared from the patch > posted to Phabricator, for what it's worth. It is not disappeared by itself, I removed it. I understood that you don't see

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

delena updated this revision to Diff 146462. delena added a comment. Added a line about *load-store* semantics of these two intrinsics. Removed the common description of memory modeling. Repository: rC Clang https://reviews.llvm.org/D46386 Files: LanguageExtensions.rst Index:

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

delena updated this revision to Diff 146080. delena added a comment. Given more clarification about memory model of atomic operations. Repository: rC Clang https://reviews.llvm.org/D46386 Files: docs/LanguageExtensions.rst include/clang/Basic/Builtins.def

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

delena updated this revision to Diff 145646. delena added a comment. Removed the unsigned version of atomics. Enhanced semantics check. Added more tests. Added documentation. Repository: rC Clang https://reviews.llvm.org/D46386 Files: docs/LanguageExtensions.rst

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

delena added a comment. In https://reviews.llvm.org/D46386#1087533, @Anastasia wrote: > Is this some sort of a vendor extension then? OpenCL 1.2 atomic builtins > don't have ordering parameter. OpenCL 1.2 atomic builtins have relaxed semantics. Always, it is not parameter, it is defined

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

delena added inline comments. Comment at: lib/Sema/SemaChecking.cpp:3098 + case AtomicExpr::AO__atomic_fetch_umax: +IsMinMax = true; +Form = Arithmetic; jfb wrote: > Should `__sync_fetch_and_min` and others also set `IsMinMax`? __sync_fetch_and_min is

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

delena created this revision. delena added reviewers: igorb, t.p.northover, ABataev, jfb, rjmccall. Herald added subscribers: cfe-commits, Anastasia. Added __atomic_fetch_min, max, umin, umax intrinsics to clang. These intrinsics work exactly as all other __atomic_fetch_* intrinsics and allow to

[PATCH] D37449: [X86][AVX512] _mm512_stream_load_si512 should take a void const* argument (PR33977)

delena accepted this revision. delena added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D37449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org