[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes `throw` more similar to `return`.

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

rymiel updated this revision to Diff 456480. rymiel added a comment. Add extra tests for spacing options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://reviews.llvm.org/D132762 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

rymiel updated this revision to Diff 456402. rymiel added a comment. Add a few token annotator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://reviews.llvm.org/D132762 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

rymiel updated this revision to Diff 454191. rymiel added a comment. Extra tests, including token annotator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132189/new/ https://reviews.llvm.org/D132189 Files:

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the heuristic was simply to look

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

rymiel updated this revision to Diff 454513. rymiel added a comment. Remove trailing newlines in added format tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132295/new/ https://reviews.llvm.org/D132295 Files:

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel added a comment. Note for reviewing: - The C++ standard, from what I could tell, seems to imply the the else clause of a consteval if clause could be written without braces, however it seems that both GCC and Clang don't allow for this, so both clauses of constexpr if statements should

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel created this revision. rymiel added reviewers: njames93, LegalizeAdulthood, aaron.ballman, gribozavr2. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

rymiel updated this revision to Diff 458012. rymiel added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132295/new/ https://reviews.llvm.org/D132295 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the AlwaysBreakTemplateDeclarations

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

rymiel added a comment. Note for reviewing: The criteria for reaching this misformat are extremely specific, requiring a single-character type or a type of a type consisting of all-uppercase letter, which are poor style on their own. I am also unsure how often this all-uppercase macro-like

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

rymiel updated this revision to Diff 454304. rymiel added a comment. Add a few format tests in addition to the annotator tests >From some incidental testing, I am pretty sure the formatting of lambdas that >were mis-annotated as "array subscript" tended to end up being formatted >correct-ish,

[PATCH] D134626: [clang-format] Correctly indent closing brace of compound requires

rymiel added a comment. I built 2 versions of clang-format, before and after this patch, and made 2 separate clones of all of LLVM+clang and ran them through either, removing all `.clang-format`s, then ran a recursive diff. I found 1 difference, in a test case at

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel commandeered this revision. rymiel added a reviewer: eoanermine. rymiel added a comment. Commandeering to finish the final nits as per https://github.com/llvm/llvm-project/issues/56283#issuecomment-1261653291 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel updated this revision to Diff 463772. rymiel added a comment. Resolve nits: - Re-sorted uses of the name RequiresExpressionIndentationKind - Updated version to be 16 - Add test for demonstrating indentation as subexpression - Reformatted Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel added a comment. Ping? This is fixing a segmentation fault. Please let me know if there are other people I should add as reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133413/new/ https://reviews.llvm.org/D133413

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel updated this revision to Diff 463773. rymiel added a comment. Missed a spot when re-sorting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.llvm.org/D129443 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel updated this revision to Diff 468414. rymiel added a comment. Swap the default for LLVM style, and adjust tests which depended on the previous style to still use it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:413 + EXPECT_TOKEN(Tokens[3], tok::string_literal, TT_OverloadedOperator); + EXPECT_TOKEN(Tokens[4], tok::identifier, TT_OverloadedOperator); + EXPECT_TOKEN(Tokens[5], tok::l_paren,

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94215d2b2103: [clang-format] Correctly annotate star/amp in function pointer params (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel updated this revision to Diff 468473. rymiel marked 4 inline comments as done. rymiel added a comment. Do not annotate the trailing identifier of an UDL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134853/new/

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel marked 2 inline comments as done. rymiel added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2126 return false; FormatToken *LeftOfParens = Tok.MatchingParen->getPreviousNonComment(); owenpan wrote: > Perhaps add: > ``` >

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

rymiel added a comment. Please provide a name and an email so someone could commit it on your behalf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org/D132131 ___

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c422ab7ce82: [clang-format] Add option for aligning requires

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. rymiel marked an inline comment as done. Closed by commit rGdce5bb9a6f89: [clang-format] Correctly annotate UDLs as OverloadedOperator (authored by rymiel).

[PATCH] D136658: [clang-format] Move InsertBraces unit tests out of FormatTest.cpp

rymiel added a comment. Is the intent here to somewhat reduce the 30k line behemoth of FormatTest.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136658/new/ https://reviews.llvm.org/D136658 ___

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel added a comment. How should I proceed with a stale rejecting review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.llvm.org/D129443 ___ cfe-commits mailing list

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The comment handling the bool case says: "bool

[PATCH] D134052: [clang-format] Disallow requires clauses to become function declarations

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There already exists logic to disallow

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

rymiel updated this revision to Diff 460810. rymiel added a comment. Also test the annotated value of the arrow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134049/new/ https://reviews.llvm.org/D134049 Files:

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:448 + EXPECT_EQ(Tokens[11]->FakeLParens.size(), 0u); + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause); + MyDeveloperDay wrote: > should you not check that

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the following construction: `template

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

rymiel updated this revision to Diff 460947. rymiel added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134049/new/ https://reviews.llvm.org/D134049 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

rymiel added a comment. In D134049#3798366 , @owenpan wrote: > Would you like to get commit access? See > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. I must humbly say that I do not think I qualify under "a track record of

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

rymiel added a comment. Thank you for the vote of confidence!! It went way more quickly than I expected; I now already have commit access! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134049/new/ https://reviews.llvm.org/D134049

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf63f0d1b6b: [clang-format] Disallow trailing return arrows to be operators (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134049/new/

[PATCH] D134052: [clang-format] Disallow requires clauses to become function declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dab45274000: [clang-format] Disallow requires clauses to become function declarations (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134587: [clang-format] Correctly annotate static and consteval lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7847225576d5: [clang-format] Correctly annotate static and consteval lambdas (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG39e6077d9723: [clang-format] Look ahead before consuming `bool` in requires clause. (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134626: [clang-format] Correctly indent closing brace of compound requires

rymiel added a comment. Note: I don't have the historical insight to know why the code order was as it was. I simply tried yoinking the place where the level was being set to occur earlier, and it surprisingly seemed to work, and also seemed to not break any other tests; I hope it doesn't

[PATCH] D134626: [clang-format] Correctly indent closing brace of compound requires

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a compound requirement is too long to fit

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

rymiel updated this revision to Diff 462670. rymiel added a comment. Remove redundant assert thank you for pointing that out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134325/new/ https://reviews.llvm.org/D134325 Files:

[PATCH] D134587: [clang-format] Correctly annotate static and consteval lambdas

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1169 "static

[PATCH] D134626: [clang-format] Correctly indent closing brace of compound requires

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fa115b56979: [clang-format] Correctly indent closing brace of compound requires (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d149d17f069: [clang-tidy] Fix crashes on `if consteval` in readability checks (authored by rymiel). Changed prior to commit: https://reviews.llvm.org/D133413?vs=464176=465291#toc Repository: rG

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel updated this revision to Diff 466551. rymiel added a comment. Flip the default and note that in the Release Notes Sorry, I did not realize I was mentioned. I think the default option will always be the first option? So I swapped them around. Note that I didn't change the LLVM config,

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel updated this revision to Diff 466862. rymiel marked an inline comment as done. rymiel added a comment. Handle UDLs with and without spaces Thank you @owenpan, I was not actually aware UDLs without spaces were valid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inside the arguments part of a function

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel marked 2 inline comments as done. rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20036 Style.Language = FormatStyle::LK_Cpp; + CHECK_PARSE_BOOL(AlignRequiresClauseBody); CHECK_PARSE_BOOL(AlignTrailingComments);

[PATCH] D134652: [clang-format] Add Basic Carbon Support/Infrastructure to clang-format

rymiel added a comment. I think the above is especially relevant as Carbon may yet change everything about its syntax; for example, in this patch, `me` has been made a keyword, but that may change in the future: https://github.com/carbon-language/carbon-lang/pull/1382 CHANGES SINCE LAST

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel added a comment. > The operator `""` and the identifier that follows should be two separate > tokens regardless if the identifier starts with an underscore. So, after some investigation, it turns out the clang lexer only combines an underscore-less UDL to a single `string_literal` token

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel updated this revision to Diff 464142. rymiel edited the summary of this revision. rymiel added a comment. Add release note Thank you, Aaron! Is the note I've added okay? I didn't expect to need to add a note to a bugfix, but I haven't written a release note before at all regardless. And

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel updated this revision to Diff 464176. rymiel added a comment. Extra consteval checks in SimplifyBooleanExprCheck Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133413/new/ https://reviews.llvm.org/D133413 Files:

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel marked 2 inline comments as done. rymiel added a comment. Thank you for pointing those out, I was indeed able to cause crashes from those locations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133413/new/ https://reviews.llvm.org/D133413

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel updated this revision to Diff 463768. rymiel edited the summary of this revision. rymiel added a comment. rymiel updated this revision to Diff 464145.

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

rymiel added a comment. Thanks for the kind words ❤️ (I've noticed Björn already includes me in his reviewers list); and while I am humbled, and I do look at every patch, I don't *yet* trust myself to actually perform good code review, as it's not something I've really ever done before.

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel updated this revision to Diff 467677. rymiel added a comment. Full stops in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134853/new/ https://reviews.llvm.org/D134853 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel added a comment. Changing the default LLVM style would change the output of all the requires-related test cases in `FormatTest.Concepts`. Should I change these test cases to use the new indentation or pass the `REI_Keyword` style to them? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

rymiel added a comment. Emilia Dreamer Thank you!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132189/new/ https://reviews.llvm.org/D132189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel added a comment. It wasn't an accidental regression, though, it was a conscious formatting decision (maybe ask @HazardyKnusperkeks for more). Similar to how lambdas can be formatted aligned to the introducer, i think this option does make sense. Repository: rG LLVM Github Monorepo

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel added a comment. In D131978#3727110 , @HazardyKnusperkeks wrote: > It's late (where I am). I thought we had something like > `ClosesRequiresClause` for concepts too. > But on the other hand, this should affect requires clauses, right? So a test

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel added a comment. It seems that even with this patch, there is seemingly weird formatting with the negation in requires clauses, such as: template requires !F int bar(T t); This is because the "fake parens" of the unary expression opened is never closed by the

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel created this revision. rymiel added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks, owenpan. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the formatter would refuse to

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel updated this revision to Diff 453107. rymiel added a comment. Added negation unary operator check to TokenAnnotatorTest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131978/new/ https://reviews.llvm.org/D131978 Files:

[PATCH] D137223: [clang-format] Remove special case for kw_operator when aligning decls

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change breaks no existing tests but does fix the

[PATCH] D140330: [clang-format] Set requires expression params as not an expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ebed862d821: [clang-format] Set requires expression params as not an expression (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D138441: [clang-format][docs] Fix invalid CSS syntax in versionbadge

This revision was automatically updated to reflect the committed changes. Closed by commit rGba4caec64fec: [clang-format][docs] Fix invalid CSS syntax in versionbadge (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138441/new/

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel updated this revision to Diff 484985. rymiel added a comment. Adapt description of parseConstraintExpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140339/new/ https://reviews.llvm.org/D140339 Files:

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3494 /// /// This is either the definition of a concept, or the body of a requires /// clause. It returns, when the parsing is complete, or the

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

rymiel planned changes to this revision. rymiel added a comment. Going to try to make the indentation of the cases following the controlling expression not continuations, since that results in weird results such as: #define LIMIT_MAX(T) \ _Generic(

[PATCH] D139211: [clang-format] Properly handle the C11 _Generic keyword.

rymiel updated this revision to Diff 485062. rymiel marked an inline comment as done. rymiel retitled this revision from "[WIP][clang-format] Properly handle the C11 _Generic keyword." to "[clang-format] Properly handle the C11 _Generic keyword.". rymiel added a comment. This revision is now

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23593-23594 - "template \n" - "concept DelayedCheck = static_cast(0) ||\n" - " requires(T t) { t.bar(); } && sizeof(T) <=

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1eeec6177fa: [clang-format] Remove special logic for parsing concept definitions. (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9899501576e: [clang-format] Disallow decltype in the middle of constraints (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141098: [clang-format][NFC] Set DeriveLineEnding to false in config files

rymiel added a comment. The LLVM Coding Standard apparently doesn't mention line endings..? A quick grep does show a bunch of \r\n results, primarily in tests. I'd be in favor of forcing \n, but I think this is a wider matter..? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140767: [clang-format] Require space before noexcept qualifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG54fab18cedac: [clang-format] Require space before noexcept qualifier (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140767/new/

[PATCH] D141098: [clang-format][NFC] Set DeriveLineEnding to false in config files

rymiel added a comment. > I think we should combine `DeriveLineEnding` and `UseCRLF` Do you mean a single `LineEnding` options which is an enum with `LF`, `CRLF` and `Derive`, or similar? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141098/new/

[PATCH] D139211: [clang-format] Properly handle the C11 _Generic keyword.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0904e0bac831: [clang-format] Properly handle the C11 _Generic keyword. (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141288: [clang-format] Inherit RightAlign options across scopes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51ba660a0700: [clang-format] Inherit RightAlign options across scopes (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cddd7a2a1d2: [clang-format][docs] Add ability to link to specific config options (authored by rymiel). Changed prior to commit: https://reviews.llvm.org/D138446?vs=476929=488720#toc Repository: rG

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. (This needs to run the updated dump script from D138446 ) I'm not sure what the strict //benefit// of squishing the two options together is, but I support

[PATCH] D141287: [clang-format] Inherit RightAlign option across scopes

rymiel abandoned this revision. rymiel added a comment. I apologize, I managed to really mess up with git somehow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141287/new/ https://reviews.llvm.org/D141287

[PATCH] D141288: [clang-format] Inherit RightAlign options across scopes

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. rymiel added a project: clang-format. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D119599

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

rymiel added inline comments. Comment at: clang/test/SemaCXX/cxx20-decomposition.cpp:160 +return a; +}() ; }(0); +(void)[&](auto c) { return b + [](auto) { aaron.ballman wrote: > Same edit elsewhere. Did clang-format get confused? It can't be

[PATCH] D141287: [clang-format] Inherit RightAlign option across scopes

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. rymiel added a project: clang-format. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D119599

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23946-23947 - verifyFormat("template \n" - "concept C =\n" - "class X;"); owenpan wrote: > Just want to make sure that the line break didn't matter.

[PATCH] D140767: [clang-format] Require space before noexcept qualifier

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This brings the noexcept qualifier more visually in line

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch properly recognizes the generic selection

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

rymiel added a comment. I put WIP in the title right now because firstly, I still need to write more tests, but also, since I haven't touched the breaking and indenting part of the code before, I want to make sure what I'm doing is sensible. Basically, after making the colons their own type so

[PATCH] D139416: [clang-format] Don't require deduction guides to be templates

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The C++ standard doesn't require that class template

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine

rymiel added a comment. Please re-upload with full context. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: clang/lib/Format/Format.cpp:811 Style.AllowShortEnumsOnASingleLine); +

[PATCH] D139416: [clang-format] Don't require deduction guides to be templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8384347997f8: [clang-format] Dont require deduction guides to be templates (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D140330: [clang-format] Set requires expression params as not an expression

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the parens of a requires expression's

[PATCH] D140330: [clang-format] Set requires expression params as not an expression

rymiel updated this revision to Diff 484040. rymiel added a comment. Small spacing typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140330/new/ https://reviews.llvm.org/D140330 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, clang-format relied on a special method to

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a function with a `requires` clause as a constraint

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

rymiel added a comment. What if I make this depend on D140339 ? Then this change would no longer impact concept definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140312/new/

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel updated this revision to Diff 484066. rymiel added a comment. Use verifyNoCrash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140339/new/ https://reviews.llvm.org/D140339 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23940 // assert. - verifyFormat("template \n" - "concept C = requires C2;"); - - verifyFormat("template \n" - "concept C = 5

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1683 -if (Tok->isOneOf(tok::kw_class, tok::kw_enum, tok::kw_concept, - tok::kw_struct, tok::kw_using)) { +if (Tok->isOneOf(tok::kw_class, tok::kw_enum,

  1   2   3   >