[libcxx] r276212 - Merging r276003:

Author: ericwf Date: Wed Jul 20 18:53:44 2016 New Revision: 276212 URL: http://llvm.org/viewvc/llvm-project?rev=276212=rev Log: Merging r276003: r276003 | ericwf | 2016-07-19 11:56:20 -0600 (Tue, 19 Jul 2016) | 35 lines Fix

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

EricWF added a comment. Why did you remove the `_VSTD` qualified on most of the `__str_find` function calls? I think that should be a qualified call because a UDT traits type can hijack overload resolution. (Although __str_find* is a reserved name). I'm happy with the changes to ``. Moving

[libunwind] r276214 - Update .arcconfig

Author: ericwf Date: Wed Jul 20 18:56:17 2016 New Revision: 276214 URL: http://llvm.org/viewvc/llvm-project?rev=276214=rev Log: Update .arcconfig Modified: libunwind/trunk/.arcconfig Modified: libunwind/trunk/.arcconfig URL:

[libunwind] r276215 - [libunwind] Properly align _Unwind_Exception.

Author: ericwf Date: Wed Jul 20 18:56:42 2016 New Revision: 276215 URL: http://llvm.org/viewvc/llvm-project?rev=276215=rev Log: [libunwind] Properly align _Unwind_Exception. Summary: _Unwind_Exception is required to be double word aligned. Currently the struct is under aligned. Reviewers:

Re: [PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

EricWF marked 2 inline comments as done. Comment at: include/atomic:581 @@ +580,3 @@ + || __f == memory_order_acq_rel, ""))) \ +__attribute__ ((__unavailable__("memory order argument to atomic operation is invalid"))) +#endif

[libcxx] r276233 - Mark P0358r1 as complete. It is already implemented

Author: ericwf Date: Wed Jul 20 22:28:52 2016 New Revision: 276233 URL: http://llvm.org/viewvc/llvm-project?rev=276233=rev Log: Mark P0358r1 as complete. It is already implemented Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[libcxx] r276231 - Mark P0337r0 as complete. It was already implemented in std::experimental

Author: ericwf Date: Wed Jul 20 22:24:43 2016 New Revision: 276231 URL: http://llvm.org/viewvc/llvm-project?rev=276231=rev Log: Mark P0337r0 as complete. It was already implemented in std::experimental Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html

Re: [PATCH] D21459: Implement http://wg21.link/P0254R1: "Integrating std::string_view and std::string"

EricWF added inline comments. Comment at: include/__string:710 @@ +709,3 @@ + +#if _LIBCPP_STD_VER > 11 +template > This declaration should be exposed in all dialects since parts of iomanip depend on it. https://reviews.llvm.org/D21459

[libcxx] r276230 - Implement P0084r2. Changing emplace return types.

Author: ericwf Date: Wed Jul 20 22:20:17 2016 New Revision: 276230 URL: http://llvm.org/viewvc/llvm-project?rev=276230=rev Log: Implement P0084r2. Changing emplace return types. Modified: libcxx/trunk/include/deque libcxx/trunk/include/forward_list libcxx/trunk/include/list

[PATCH] D22609: Suppress reserved user defined literal warning within namespace std.

EricWF created this revision. EricWF added reviewers: rsmith, majnemer. EricWF added a subscriber: cfe-commits. Currently Clang warns if a UDL is defined with a name reserved for future standardization. This patch suppresses the diagnostic within namespace std. https://reviews.llvm.org/D22609

[libcxx] r275734 - Check for unconstrained hash equality before constrained hash equality.

Author: ericwf Date: Sun Jul 17 17:04:57 2016 New Revision: 275734 URL: http://llvm.org/viewvc/llvm-project?rev=275734=rev Log: Check for unconstrained hash equality before constrained hash equality. This patch implements a simple optimization in __hash_table::find. When iterating the found

Re: [PATCH] D22265: [libcxx][filesystem] Remove setgid from parent before testing permissions

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Do you need me to commit this? https://reviews.llvm.org/D22265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r275754 - Add checkpoint diagnostics to help diagnose buildbot failures.

Author: ericwf Date: Sun Jul 17 22:00:09 2016 New Revision: 275754 URL: http://llvm.org/viewvc/llvm-project?rev=275754=rev Log: Add checkpoint diagnostics to help diagnose buildbot failures. Modified:

[libcxx] r275745 - Implement C++17 tuple bits. Including apply and make_from_tuple.

Author: ericwf Date: Sun Jul 17 19:35:56 2016 New Revision: 275745 URL: http://llvm.org/viewvc/llvm-project?rev=275745=rev Log: Implement C++17 tuple bits. Including apply and make_from_tuple. This patch upgrades to be C++17 compliant by implementing: * tuple_size_v: This was forgotten when

[libcxx] r275748 - Suppress warning in make_from_tuple tests.

Author: ericwf Date: Sun Jul 17 20:52:46 2016 New Revision: 275748 URL: http://llvm.org/viewvc/llvm-project?rev=275748=rev Log: Suppress warning in make_from_tuple tests. Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.apply/make_from_tuple.pass.cpp Modified:

[libcxx] r275749 - Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

Author: ericwf Date: Sun Jul 17 20:58:37 2016 New Revision: 275749 URL: http://llvm.org/viewvc/llvm-project?rev=275749=rev Log: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree. This patch does the following: * It renames `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`

Re: [PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

EricWF closed this revision. EricWF added a comment. r275749. https://reviews.llvm.org/D21329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r275752 - Fix arc config to use https

Author: ericwf Date: Sun Jul 17 21:05:52 2016 New Revision: 275752 URL: http://llvm.org/viewvc/llvm-project?rev=275752=rev Log: Fix arc config to use https Modified: libcxxabi/trunk/.arcconfig Modified: libcxxabi/trunk/.arcconfig URL:

[libcxx] r275751 - Add includes in test. Patch from s...@microsoft.com

Author: ericwf Date: Sun Jul 17 21:05:31 2016 New Revision: 275751 URL: http://llvm.org/viewvc/llvm-project?rev=275751=rev Log: Add includes in test. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/containers/container.adaptors/priority.queue/types.pass.cpp Modified:

Re: [PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

EricWF added a comment. I'm committing this today, meaning it will make it into 3.9, so don't forget to remove your upstream patches before the release :-) In https://reviews.llvm.org/D21329#476455, @dim wrote: > In https://reviews.llvm.org/D21329#475105, @theraven wrote: > > > Looks fine to

[libcxx] r275750 - Upgrade arcconfig to use https

Author: ericwf Date: Sun Jul 17 21:02:49 2016 New Revision: 275750 URL: http://llvm.org/viewvc/llvm-project?rev=275750=rev Log: Upgrade arcconfig to use https Modified: libcxx/trunk/.arcconfig Modified: libcxx/trunk/.arcconfig URL:

Re: [PATCH] D22012: [libcxx] [tests] Add missing includes, especially , to priority.queue/types.pass.cpp.

EricWF closed this revision. EricWF added a comment. r275751. https://reviews.llvm.org/D22012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r275753 - Prevent failures by marking Clock::is_steady tests as UNSUPPORTED: asan.

Author: ericwf Date: Sun Jul 17 21:29:33 2016 New Revision: 275753 URL: http://llvm.org/viewvc/llvm-project?rev=275753=rev Log: Prevent failures by marking Clock::is_steady tests as UNSUPPORTED: asan. Modified:

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF updated this revision to Diff 64525. EricWF added a comment. Add test for PR28469 and remove __tree from the UBSAN blacklist. https://reviews.llvm.org/D20786 Files: include/__config include/__tree test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp

[libcxx] r276003 - Fix undefined behavior in __tree

Author: ericwf Date: Tue Jul 19 12:56:20 2016 New Revision: 276003 URL: http://llvm.org/viewvc/llvm-project?rev=276003=rev Log: Fix undefined behavior in __tree Summary: This patch attempts to fix the undefined behavior in __tree by changing the node pointer types used throughout. The pointer

[libcxx] r276091 - Add missed test in r276090.

Author: ericwf Date: Wed Jul 20 00:22:35 2016 New Revision: 276091 URL: http://llvm.org/viewvc/llvm-project?rev=276091=rev Log: Add missed test in r276090. Added: libcxx/trunk/test/std/utilities/function.objects/func.wrap/func.wrap.func/derive_from.pass.cpp Added:

[libcxx] r276084 - Reimplement is_constructible fallback implementation. Fixes PR21574.

Author: ericwf Date: Wed Jul 20 00:01:24 2016 New Revision: 276084 URL: http://llvm.org/viewvc/llvm-project?rev=276084=rev Log: Reimplement is_constructible fallback implementation. Fixes PR21574. The previous implementation relied highly on specializations to handle special cases. This new

[libcxx] r276067 - Add SFINAE on additional overloads of std::complex functions. Fixes PR19921.

Author: ericwf Date: Tue Jul 19 19:14:10 2016 New Revision: 276067 URL: http://llvm.org/viewvc/llvm-project?rev=276067=rev Log: Add SFINAE on additional overloads of std::complex functions. Fixes PR19921. The functions arg, conj, imag, norm, proj, and real have additional overloads for arguments

[libcxx] r276078 - Add tests for reference binding assertions in std::tuple.

Author: ericwf Date: Tue Jul 19 21:57:39 2016 New Revision: 276078 URL: http://llvm.org/viewvc/llvm-project?rev=276078=rev Log: Add tests for reference binding assertions in std::tuple. Libc++ provides static assertions to detect reference binding issues inside tuple. This patch adds tests for

Re: [PATCH] D4447: [libcxx] Fixes libc++ bug #19921 - Remove additional overloads for std::complex

EricWF abandoned this revision. EricWF added a comment. Fixed in r276067. https://reviews.llvm.org/D4447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r276090 - Move std::function constructor SFINAE into template parameter list. Fixes PR20002.

Author: ericwf Date: Wed Jul 20 00:21:00 2016 New Revision: 276090 URL: http://llvm.org/viewvc/llvm-project?rev=276090=rev Log: Move std::function constructor SFINAE into template parameter list. Fixes PR20002. Although inheriting constructors have already been fixed in Clang 3.9 I still choose

[PATCH] D22557: [libcxx] Diagnose invalid memory order arguments in . Fixes PR21179.

EricWF created this revision. EricWF added reviewers: mclow.lists, rsmith. EricWF added subscribers: cfe-commits, rsmith. This patch uses the __attribute__((enable_if)) hack suggested by @rsmith to diagnose invalid arguments when possible. In order to diagnose an invalid argument `m` to `f(m)`

[PATCH] D22543: [libunwind] Properly align _Unwind_Exception.

EricWF created this revision. EricWF added reviewers: mclow.lists, compnerd. EricWF added a subscriber: cfe-commits. _Unwind_Exception is required to be double word aligned. Currently the struct is under aligned. https://reviews.llvm.org/D22543 Files: include/unwind.h

Re: [PATCH] D22528: [libcxxabi] When catching an exception of type nullptr_t with a handler of pointer-to-member type, produce a null value of the right type

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D22528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r276059 - Add heterogeneous comparator support for __debug_less. Fixes PR17147.

Author: ericwf Date: Tue Jul 19 18:27:18 2016 New Revision: 276059 URL: http://llvm.org/viewvc/llvm-project?rev=276059=rev Log: Add heterogeneous comparator support for __debug_less. Fixes PR17147. Added: libcxx/trunk/test/libcxx/algorithms/debug_less.pass.cpp Modified:

[libcxx] r276092 - Unbreak is_constructible tests for Clang <= 3.7.

Author: ericwf Date: Wed Jul 20 01:36:11 2016 New Revision: 276092 URL: http://llvm.org/viewvc/llvm-project?rev=276092=rev Log: Unbreak is_constructible tests for Clang <= 3.7. There is a bug in Clang's __is_constructible builtin that causes it to return true for function types; ex [T = void()].

[libcxx] r276093 - Fix inheriting constructor test for std::function.

Author: ericwf Date: Wed Jul 20 01:46:22 2016 New Revision: 276093 URL: http://llvm.org/viewvc/llvm-project?rev=276093=rev Log: Fix inheriting constructor test for std::function. The test I originally checked in only worked with ToT Clang. This patch updates the test so that it works as far back

[libcxx] r275094 - Allow is_swappable to SFINAE on deleted/ambiguous swap functions

Author: ericwf Date: Mon Jul 11 14:57:13 2016 New Revision: 275094 URL: http://llvm.org/viewvc/llvm-project?rev=275094=rev Log: Allow is_swappable to SFINAE on deleted/ambiguous swap functions Modified: libcxx/trunk/include/type_traits

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF added a reviewer: howard.hinnant. EricWF added a subscriber: howard.hinnant. EricWF added a comment. Adding Howard to the reviewers. @howard.hinnant Feel free to take a look if your interested. @mclow.lists Any comments? http://reviews.llvm.org/D20786

[libcxx] r275089 - Hide some internal symbols for memory resource.

Author: ericwf Date: Mon Jul 11 14:22:09 2016 New Revision: 275089 URL: http://llvm.org/viewvc/llvm-project?rev=275089=rev Log: Hide some internal symbols for memory resource. Modified: libcxx/trunk/src/experimental/memory_resource.cpp Modified:

[libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

Author: ericwf Date: Mon Jul 11 17:02:02 2016 New Revision: 275114 URL: http://llvm.org/viewvc/llvm-project?rev=275114=rev Log: Don't compute modulus of hash if it is smaller than the bucket count. This cleans up a previous optimization attempt in hash, and results in additional performance

[PATCH] D22255: [libcxx] Create __is_alloc_constructible<Alloc, Type, Args...> trait which checks the validity of allocator_traits construction.

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. Example Usage: To check the `EmplaceConstructible` Container requirement you would ask: `__is_alloc_constructible::value`

Re: [PATCH] D22255: [libcxx] Create __is_alloc_constructible<Alloc, Type, Args...> trait which checks the validity of allocator_traits construction.

EricWF updated this revision to Diff 63635. EricWF added a comment. - Don't use `is_constructible` in the `__is_alloc_constructible` implementation. `is_constructible` requires `is_destructible`, but that isn't required within allocators. Instead this trait checks the validity of the

Re: [PATCH] D22255: [libcxx] Create __is_alloc_constructible<Alloc, Type, Args...> trait which checks the validity of allocator_traits construction.

EricWF updated this revision to Diff 63636. EricWF added a comment. Add correct tests. http://reviews.llvm.org/D22255 Files: include/memory include/type_traits include/vector test/libcxx/utilities/memory/allocator.traits/__is_alloc_constructible.pass.cpp

Re: [PATCH] D22073: libc++: test lock-free atomic alignment

EricWF added a comment. - The test should be moved to `test/libcxx/atomics/atomics.align` since it's libc++ specific. - Please give the anonymous struct declarations unique names. `T1`, `T2`, ..., `TN` is fine. Currently they all mangle to `main::type` in diagnostic output. - The test fails to

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

Does this happen > because __bc is often astronomically high, or because __h is often > astronomically low (presumably due to bad hash functions, such as "always > hash to constant 0")? > It happens due to bad hash functions. Primarily because integral types use the identify hash f

Re: [libcxx] r275114 - Don't compute modulus of hash if it is smaller than the bucket count.

h, or because __h is often >> astronomically low (presumably due to bad hash functions, such as "always >> hash to constant 0")? >> > > It happens due to bad hash functions. Primarily because integral types use > the identify hash function. > > &g

[libcxx] r275757 - Improve ABI tests for std::pair.

Author: ericwf Date: Sun Jul 17 23:48:37 2016 New Revision: 275757 URL: http://llvm.org/viewvc/llvm-project?rev=275757=rev Log: Improve ABI tests for std::pair. Added: libcxx/trunk/test/libcxx/utilities/utility/pairs/pairs.pair/non_trivial_copy_move_ABI.pass.cpp

[PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

EricWF created this revision. EricWF added a subscriber: cfe-commits. https://reviews.llvm.org/D22452 Files: test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp Index:

[libcxx] r275759 - Rework libatomic handling in CMake and LIT.

Author: ericwf Date: Mon Jul 18 01:01:50 2016 New Revision: 275759 URL: http://llvm.org/viewvc/llvm-project?rev=275759=rev Log: Rework libatomic handling in CMake and LIT. This patch updates the way libc++ handles checking for libatomic, in part to prepare for https://reviews.llvm.org/D22073.

Re: [PATCH] D22073: libc++: test lock-free atomic alignment

EricWF added a comment. OK, IMO the way to handle this test is to have it manually link `-latomic`. This can be done by renaming the test to `.sh.cpp` and adding the following lines: // REQUIRES: libatomic // RUN: %build -latomic // RUN: %run After that this LGTM.

[libcxx] r275772 - Remove locale tests that depend on enviroment variables.

Author: ericwf Date: Mon Jul 18 01:15:55 2016 New Revision: 275772 URL: http://llvm.org/viewvc/llvm-project?rev=275772=rev Log: Remove locale tests that depend on enviroment variables. Constructing a std::locale object from an empty string selects the language from the current environment

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF updated this revision to Diff 63267. EricWF added a comment. Fix merge conflicts in __config. http://reviews.llvm.org/D20786 Files: include/__config include/__tree test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp

[libcxx] r278087 - Remove *super* old test suite results doc for Linux and Windows.

Author: ericwf Date: Mon Aug 8 22:05:43 2016 New Revision: 278087 URL: http://llvm.org/viewvc/llvm-project?rev=278087=rev Log: Remove *super* old test suite results doc for Linux and Windows. Neither of these results files has been update in years. Linux now has a dozen or so buildbots tracking

[libcxx] r277970 - Fix copy/move constructor annotation for the uses-allocator test types.

Author: ericwf Date: Sun Aug 7 21:22:41 2016 New Revision: 277970 URL: http://llvm.org/viewvc/llvm-project?rev=277970=rev Log: Fix copy/move constructor annotation for the uses-allocator test types. Previously the copy/move constructors of the test types did not properly set the arg_id to T

[libcxx] r277964 - Mark LWG 2726 as complete. No code change needed.

Author: ericwf Date: Sun Aug 7 16:47:06 2016 New Revision: 277964 URL: http://llvm.org/viewvc/llvm-project?rev=277964=rev Log: Mark LWG 2726 as complete. No code change needed. Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[libcxx] r277512 - Pass compilers when configuring Google Benchmark.

Author: ericwf Date: Tue Aug 2 15:21:07 2016 New Revision: 277512 URL: http://llvm.org/viewvc/llvm-project?rev=277512=rev Log: Pass compilers when configuring Google Benchmark. Modified: libcxx/trunk/benchmarks/CMakeLists.txt Modified: libcxx/trunk/benchmarks/CMakeLists.txt URL:

[PATCH] D23331: Implement LWG 2148: Make non-enum default hash specialization well-formed

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. This patch removes the static_assert for non-enum types in the primary hash template. Instead non-enum types create a hash specialization that is not constructible nor callable. See

[libcxx] r278147 - Update in-tree Google Benchmark to current ToT.

Author: ericwf Date: Tue Aug 9 13:56:48 2016 New Revision: 278147 URL: http://llvm.org/viewvc/llvm-project?rev=278147=rev Log: Update in-tree Google Benchmark to current ToT. I've put some work into the Google Benchmark library in order to make it easier to benchmark libc++. These changes have

Re: [PATCH] D21706: [libcxx] refactor for throw or assert

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Please make the changes in the above comment. http://reviews.llvm.org/D21706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21637: [libcxx] Don't use pthread initializers in constexpr constructors

EricWF added a comment. In http://reviews.llvm.org/D21637#471151, @rmaprath wrote: > Small side question: so how are `__m_` and `__cv_` initialized in this setup? > is it that `pthread_mutex_lock()` and the like would be able to handle an > un-initialized blob of memory (in a thread-safe way)?

Re: [PATCH] D21637: [libcxx] Don't use pthread initializers in constexpr constructors

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D21637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21637: [libcxx] Don't use pthread initializers in constexpr constructors

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. C++03 does not support default member initializers but libc++ provides both of these classes an extensions in C++03. C++03 also does not support defaulted special members. I think

[libcxx] r274214 - Update status of already completed Oulu issues.

Author: ericwf Date: Thu Jun 30 01:59:29 2016 New Revision: 274214 URL: http://llvm.org/viewvc/llvm-project?rev=274214=rev Log: Update status of already completed Oulu issues. * P0163r0: Implemented in r273839. * LWG 2309: pthread_mutex_lock only returns this error if certain debug flags were

[libcxx] r274274 - Fix C++03 build.

Author: ericwf Date: Thu Jun 30 15:46:58 2016 New Revision: 274274 URL: http://llvm.org/viewvc/llvm-project?rev=274274=rev Log: Fix C++03 build. Modified: libcxx/trunk/test/std/containers/unord/unord.map/unord.map.cnstr/compare_copy_constructible.fail.cpp

[libcxx] r274286 - Replace __make_tuple_indices implementation with superior implementation.

Author: ericwf Date: Thu Jun 30 17:34:43 2016 New Revision: 274286 URL: http://llvm.org/viewvc/llvm-project?rev=274286=rev Log: Replace __make_tuple_indices implementation with superior implementation. The previous __make_tuple_indices implementation caused O(N) instantiations and was pretty

r274316 - [Feature] Add a builtin for indexing into parameter packs. Patch by Louis Dionne.

Author: ericwf Date: Thu Jun 30 20:24:09 2016 New Revision: 274316 URL: http://llvm.org/viewvc/llvm-project?rev=274316=rev Log: [Feature] Add a builtin for indexing into parameter packs. Patch by Louis Dionne. This patch adds a __nth_element builtin that allows fetching the n-th type of a

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

EricWF added a subscriber: EricWF. EricWF added a comment. Ping? Is there a reason this hasn't been committed? http://reviews.llvm.org/D15421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r274331 - Flatten tuple_constructible, tuple_convertible and tuple_assignable.

Author: ericwf Date: Thu Jun 30 23:07:39 2016 New Revision: 274331 URL: http://llvm.org/viewvc/llvm-project?rev=274331=rev Log: Flatten tuple_constructible, tuple_convertible and tuple_assignable. This patch is the last in a series that replaces recursive meta-programming in std::tuple with

Re: [PATCH] D21918: Make the tuple_element and __make_tuple_types implementations flat.

EricWF abandoned this revision. EricWF added a comment. Committed in rr274330 http://reviews.llvm.org/D21918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r274204 - Fix unreferenced parameter warning. Patch from s...@microsoft.com

Author: ericwf Date: Wed Jun 29 23:22:58 2016 New Revision: 274204 URL: http://llvm.org/viewvc/llvm-project?rev=274204=rev Log: Fix unreferenced parameter warning. Patch from s...@microsoft.com Modified:

[libcxx] r274203 - Avoid applying unary minus to unsigned integers. Patch from s...@microsoft.com

Author: ericwf Date: Wed Jun 29 23:21:52 2016 New Revision: 274203 URL: http://llvm.org/viewvc/llvm-project?rev=274203=rev Log: Avoid applying unary minus to unsigned integers. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/depr/depr.c.headers/stdint_h.pass.cpp

Re: [PATCH] D21870: [libcxx] [test] Avoid applying unary minus to unsigned integers.

EricWF closed this revision. EricWF added a comment. r274203. http://reviews.llvm.org/D21870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21879: [libcxx] [test] Fix MSVC "warning C4100: 'argv': unreferenced formal parameter".

EricWF closed this revision. EricWF added a comment. r274204. http://reviews.llvm.org/D21879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r274205 - Fix unary_function inheritance assumption. Patch from s...@microsoft.com

Author: ericwf Date: Wed Jun 29 23:28:12 2016 New Revision: 274205 URL: http://llvm.org/viewvc/llvm-project?rev=274205=rev Log: Fix unary_function inheritance assumption. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/containers/sequences/vector.bool/vector_bool.pass.cpp

[libcxx] r274206 - Fix use of terse static assert. Patch from s...@microsoft.com

Author: ericwf Date: Wed Jun 29 23:29:12 2016 New Revision: 274206 URL: http://llvm.org/viewvc/llvm-project?rev=274206=rev Log: Fix use of terse static assert. Patch from s...@microsoft.com Modified:

Re: [PATCH] D21877: [libcxx] [test] is_swappable_include_order.pass.cpp was using a terse static_assert.

EricWF closed this revision. EricWF added a comment. r274206. http://reviews.llvm.org/D21877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21875: [libcxx] [test] The Standard requires meow_insert_iterator::reference to be void.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I fixed both the libc++ implementation and tests in r274209. http://reviews.llvm.org/D21875 ___ cfe-commits mailing list

[libcxx] r274209 - Fix ::reference typedef in insert iterators.

Author: ericwf Date: Wed Jun 29 23:40:50 2016 New Revision: 274209 URL: http://llvm.org/viewvc/llvm-project?rev=274209=rev Log: Fix ::reference typedef in insert iterators. Since at least the C++11 standard insert iterators are specified as having ::reference typedef void. Libc++ was not doing

[libcxx] r274207 - Make instreambuf.iterator/types.pass.cpp more portable.

Author: ericwf Date: Wed Jun 29 23:31:09 2016 New Revision: 274207 URL: http://llvm.org/viewvc/llvm-project?rev=274207=rev Log: Make instreambuf.iterator/types.pass.cpp more portable. Modified: libcxx/trunk/test/std/iterators/stream.iterators/istreambuf.iterator/types.pass.cpp Modified:

[libcxx] r274210 - Make std::array typedef tests more portable.

Author: ericwf Date: Wed Jun 29 23:54:00 2016 New Revision: 274210 URL: http://llvm.org/viewvc/llvm-project?rev=274210=rev Log: Make std::array typedef tests more portable. Modified: libcxx/trunk/test/std/containers/sequences/array/types.pass.cpp Modified:

[libcxx] r274211 - Make futures.overview enum tests more portable. Patch from s...@microsoft.com

Author: ericwf Date: Thu Jun 30 00:00:32 2016 New Revision: 274211 URL: http://llvm.org/viewvc/llvm-project?rev=274211=rev Log: Make futures.overview enum tests more portable. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/thread/futures/futures.overview/future_errc.pass.cpp

Re: [PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. I benchmarked the change against different key types and: 1. The change doesn't have a large detrimental impact when the key equality is as expensive as hash equality. I benchmarked

[libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

Author: ericwf Date: Fri Jul 1 18:22:25 2016 New Revision: 274403 URL: http://llvm.org/viewvc/llvm-project?rev=274403=rev Log: Work around ABI break caused by C++17 inline variables. Modified: libcxx/trunk/src/chrono.cpp Modified: libcxx/trunk/src/chrono.cpp URL:

[libcxx] r274404 - Turn off ASAN's odr-violation diagnostics for now. See PR28391

Author: ericwf Date: Fri Jul 1 18:25:47 2016 New Revision: 274404 URL: http://llvm.org/viewvc/llvm-project?rev=274404=rev Log: Turn off ASAN's odr-violation diagnostics for now. See PR28391 Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py

Re: [libcxx] r274403 - Work around ABI break caused by C++17 inline variables.

.uk> wrote: > On Fri, Jul 1, 2016 at 4:22 PM, Eric Fiselier via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: ericwf >> Date: Fri Jul 1 18:22:25 2016 >> New Revision: 274403 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=274403=r

[libcxx] r274407 - Remove accidental change committed in r274403.

Author: ericwf Date: Fri Jul 1 18:31:55 2016 New Revision: 274407 URL: http://llvm.org/viewvc/llvm-project?rev=274407=rev Log: Remove accidental change committed in r274403. Modified: libcxx/trunk/src/chrono.cpp Modified: libcxx/trunk/src/chrono.cpp URL:

[libcxx] r274408 - Add another workaround for C++17 inline variable ABI breakage.

Author: ericwf Date: Fri Jul 1 18:41:48 2016 New Revision: 274408 URL: http://llvm.org/viewvc/llvm-project?rev=274408=rev Log: Add another workaround for C++17 inline variable ABI breakage. Modified: libcxx/trunk/src/experimental/filesystem/path.cpp Modified:

[libcxx] r274413 - Make tuple_constructible and family lazy again.

Author: ericwf Date: Fri Jul 1 19:58:17 2016 New Revision: 274413 URL: http://llvm.org/viewvc/llvm-project?rev=274413=rev Log: Make tuple_constructible and family lazy again. Added: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/test_lazy_sfinae.pass.cpp Modified:

[libcxx] r274414 - Cleanup SFINAE in tuple, and add tests for reference assignment

Author: ericwf Date: Fri Jul 1 20:25:46 2016 New Revision: 274414 URL: http://llvm.org/viewvc/llvm-project?rev=274414=rev Log: Cleanup SFINAE in tuple, and add tests for reference assignment Modified: libcxx/trunk/include/__tuple

[libcxx] r274422 - Handle std::get(...) for std::tuple<>

Author: ericwf Date: Fri Jul 1 22:46:08 2016 New Revision: 274422 URL: http://llvm.org/viewvc/llvm-project?rev=274422=rev Log: Handle std::get(...) for std::tuple<> Modified: libcxx/trunk/include/tuple libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.elem/tuple.by.type.fail.cpp

[libcxx] r274423 - Improve performance of unordered_set::find by 45%. Add benchmarks.

Author: ericwf Date: Sat Jul 2 00:19:59 2016 New Revision: 274423 URL: http://llvm.org/viewvc/llvm-project?rev=274423=rev Log: Improve performance of unordered_set::find by 45%. Add benchmarks. This patch improves the performance of unordered_set's find by 45% when the value exists within the

[libcxx] r274424 - Add unordered_map::insert benchmark test and rename file

Author: ericwf Date: Sat Jul 2 00:30:54 2016 New Revision: 274424 URL: http://llvm.org/viewvc/llvm-project?rev=274424=rev Log: Add unordered_map::insert benchmark test and rename file Added: libcxx/trunk/benchmarks/unordered_set_operations.bench.cpp Removed:

[libcxxabi] r278773 - Default LIBCXXABI_LIBDIR_SUFFIX to LLVM_LIBDIR_SUFFIX

Author: ericwf Date: Mon Aug 15 22:44:55 2016 New Revision: 278773 URL: http://llvm.org/viewvc/llvm-project?rev=278773=rev Log: Default LIBCXXABI_LIBDIR_SUFFIX to LLVM_LIBDIR_SUFFIX Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/trunk/CMakeLists.txt URL:

Re: [PATCH] D7511: [libc++] Change how CMake links libc++ with OS X.

EricWF abandoned this revision. EricWF added a comment. Abandoning https://reviews.llvm.org/D7511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

EricWF accepted this revision. EricWF added a comment. Also LGTM. https://reviews.llvm.org/D23507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r278716 - Fix PR28506. Re-enable missing math.h C++11 decls on SunOS. Patch from Michal Gorny.

Author: ericwf Date: Mon Aug 15 13:58:57 2016 New Revision: 278716 URL: http://llvm.org/viewvc/llvm-project?rev=278716=rev Log: Fix PR28506. Re-enable missing math.h C++11 decls on SunOS. Patch from Michal Gorny. Modified: libcxx/trunk/include/cmath libcxx/trunk/include/math.h

Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

EricWF closed this revision. EricWF added a comment. r278716. https://reviews.llvm.org/D23507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r278722 - Use -O1 when testing with ASAN and MSAN to prevent Clang OOM errors.

Author: ericwf Date: Mon Aug 15 14:37:20 2016 New Revision: 278722 URL: http://llvm.org/viewvc/llvm-project?rev=278722=rev Log: Use -O1 when testing with ASAN and MSAN to prevent Clang OOM errors. Currently certain tests get killed when compiled with ASAN at -O0 because they eat all of the

[PATCH] D23524: [libc++abi] Fix backtrace_test.pass.cpp failure seemingly caused by inlining differences.

EricWF created this revision. EricWF added reviewers: danalbert, jroelofs, mclow.lists. EricWF added a subscriber: cfe-commits. The modified assertion fails when the test is compiled at various optimization levels. The value of `nothrow_traced` and `throw_traced` at various optimization levels

<    6   7   8   9   10   11   12   13   14   15   >