Author: ericwf
Date: Tue May 3 00:34:38 2016
New Revision: 268363
URL: http://llvm.org/viewvc/llvm-project?rev=268363=rev
Log:
Fix dependencies on install-libcxx CMake target
Modified:
libcxx/trunk/lib/CMakeLists.txt
Modified: libcxx/trunk/lib/CMakeLists.txt
URL:
EricWF added a comment.
In http://reviews.llvm.org/D19835#419547, @mclow.lists wrote:
> How about not using XFAIL?
> Instead, just test for those two conditions.
>
> Psuedo-code:
>
> #if defined(GLIBC)
> #if GLIBC < 226
> #error
> #elif TEST_STD_VER >= 11
> #error
> #endif.
Author: ericwf
Date: Tue May 3 16:58:07 2016
New Revision: 268451
URL: http://llvm.org/viewvc/llvm-project?rev=268451=rev
Log:
Make check-libcxx dependant on libc++experimental if present.
Modified:
libcxx/trunk/test/CMakeLists.txt
Modified: libcxx/trunk/test/CMakeLists.txt
URL:
Author: ericwf
Date: Tue May 3 16:30:18 2016
New Revision: 268443
URL: http://llvm.org/viewvc/llvm-project?rev=268443=rev
Log:
Create new library 'libc++experimental.a' for packaging TS symbols.
Summary:
Out-of-line symbols for headers are not ABI or API stable
and cannot live in the
Author: ericwf
Date: Tue May 3 17:32:08 2016
New Revision: 268456
URL: http://llvm.org/viewvc/llvm-project?rev=268456=rev
Log:
Add documentation for new experimental library
Modified:
libcxx/trunk/docs/BuildingLibcxx.rst
libcxx/trunk/docs/UsingLibcxx.rst
Modified:
Author: ericwf
Date: Fri May 6 16:35:06 2016
New Revision: 268801
URL: http://llvm.org/viewvc/llvm-project?rev=268801=rev
Log:
Tweak --param=no_default_flags=true to still add -Ilibcxx/test/support
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified:
Author: ericwf
Date: Fri May 6 21:30:21 2016
New Revision: 268838
URL: http://llvm.org/viewvc/llvm-project?rev=268838=rev
Log:
Fix typo it _LIBCPP_NO_EXCEPTIONS macro
Modified:
libcxx/trunk/include/exception
Modified: libcxx/trunk/include/exception
URL:
Author: ericwf
Date: Fri May 6 21:33:25 2016
New Revision: 268839
URL: http://llvm.org/viewvc/llvm-project?rev=268839=rev
Log:
Fix one more usage of _LIBCPP_HAS_NO_EXCEPTIONS
Modified:
libcxx/trunk/src/experimental/memory_resource.cpp
Modified:
Author: ericwf
Date: Fri May 6 22:09:55 2016
New Revision: 268841
URL: http://llvm.org/viewvc/llvm-project?rev=268841=rev
Log:
Add experimental container alias templates for PMRs
Added:
libcxx/trunk/include/experimental/deque
libcxx/trunk/include/experimental/forward_list
Author: ericwf
Date: Fri May 6 22:12:24 2016
New Revision: 268842
URL: http://llvm.org/viewvc/llvm-project?rev=268842=rev
Log:
Change allocator::allocate to throw length_error, not bad_alloc
Modified:
libcxx/trunk/include/memory
Author: ericwf
Date: Fri May 6 22:24:31 2016
New Revision: 268844
URL: http://llvm.org/viewvc/llvm-project?rev=268844=rev
Log:
Update TS implementation status page
Modified:
libcxx/trunk/www/ts1z_status.html
Modified: libcxx/trunk/www/ts1z_status.html
URL:
EricWF added a comment.
This is a small problem. We actually provide in C++03 minus
`ATOMIC_FLAG_INIT` since it requires C++11.
I'll come up with a way to fix these tests so they keep working in C++03.
http://reviews.llvm.org/D19758
___
EricWF closed this revision.
EricWF added a comment.
r268284.
In http://reviews.llvm.org/D19625#418697, @STL_MSFT wrote:
> No problem! With these changes, my test runs are currently clean wrt "warning
> C4100: unreferenced formal parameter" and "warning C4101: unreferenced local
> variable",
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I have no objections to this change. Howard seems to agree.
http://reviews.llvm.org/D19623
___
cfe-commits mailing list
EricWF closed this revision.
EricWF added a comment.
r268285.
http://reviews.llvm.org/D19623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Mon May 2 15:08:16 2016
New Revision: 268294
URL: http://llvm.org/viewvc/llvm-project?rev=268294=rev
Log:
Cleanup warnings and remove use of __builtin_va_list in depr.c.headers
Modified:
libcxx/trunk/test/std/depr/depr.c.headers/fenv_h.pass.cpp
Author: ericwf
Date: Mon May 2 14:15:48 2016
New Revision: 268284
URL: http://llvm.org/viewvc/llvm-project?rev=268284=rev
Log:
Void cast runtime-unused variables. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/depr/depr.c.headers/setjmp_h.pass.cpp
EricWF added a comment.
I actually want this form of initialization to break in C++03, From the
original review:
> After putting this question up on cfe-dev I have decided that it would be
> best to allow the use of in C++03. Although static initialization is
> a concern the syntax required
Author: ericwf
Date: Mon May 2 14:20:16 2016
New Revision: 268285
URL: http://llvm.org/viewvc/llvm-project?rev=268285=rev
Log:
Initialize local doubles to NaN. Patch from s...@microsoft.com
Modified:
Author: ericwf
Date: Thu May 5 03:12:25 2016
New Revision: 268614
URL: http://llvm.org/viewvc/llvm-project?rev=268614=rev
Log:
Fix sphinx build. This is a temporary solution.
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
Modified: libcxx/trunk/docs/TestingLibcxx.rst
URL:
Author: ericwf
Date: Thu May 5 01:30:05 2016
New Revision: 268613
URL: http://llvm.org/viewvc/llvm-project?rev=268613=rev
Log:
Try and fix sphinx build
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
Modified: libcxx/trunk/docs/TestingLibcxx.rst
URL:
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after the minor fixes. Thank you for the patch.
Comment at: include/__threading_support:38
@@ +37,3 @@
+{
+pthread_mutexattr_t attr;
+int ec =
Author: ericwf
Date: Thu May 5 23:49:30 2016
New Revision: 268709
URL: http://llvm.org/viewvc/llvm-project?rev=268709=rev
Log:
Fix errors in documentation
Modified:
libcxx/trunk/docs/UsingLibcxx.rst
Modified: libcxx/trunk/docs/UsingLibcxx.rst
URL:
Author: ericwf
Date: Tue May 3 17:50:33 2016
New Revision: 268459
URL: http://llvm.org/viewvc/llvm-project?rev=268459=rev
Log:
Update version numbers in docs
Modified:
libcxx/trunk/docs/conf.py
Modified: libcxx/trunk/docs/conf.py
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269070: [libcxx] Prefer C++14 over C++11 when building
libc++experimental. (authored by EricWF).
Changed prior to commit:
http://reviews.llvm.org/D19992?vs=56333=56732#toc
Repository:
rL LLVM
Author: ericwf
Date: Tue May 10 11:17:43 2016
New Revision: 269070
URL: http://llvm.org/viewvc/llvm-project?rev=269070=rev
Log:
[libcxx] Prefer C++14 over C++11 when building libc++experimental.
Summary:
Currently libc++experimental builds with C++11. This patch changes that to
C++14 when
Author: ericwf
Date: Wed May 4 15:29:19 2016
New Revision: 268543
URL: http://llvm.org/viewvc/llvm-project?rev=268543=rev
Log:
Removing some trailing whitespace
Modified:
libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/swap.pass.cpp
EricWF added a comment.
In http://reviews.llvm.org/D19835#419211, @jroelofs wrote:
> I think you could lean on the linker to cause the test to fail when the type
> is wrong:
>
> bool isinf(double);
>
> typedef int (*expected_signature)(double);
>
> void
EricWF created this revision.
EricWF added reviewers: rsmith, mclow.lists.
EricWF added a subscriber: cfe-commits.
GLIBC recently removed the incorrect `int isinf(double)` and `int
isnan(double)` overloads in C++11 and greater. This causes previously `XFAIL:
linux` tests to start passing.
EricWF added a comment.
In http://reviews.llvm.org/D19856#420366, @mclow.lists wrote:
> Q: Should the .a file get installed into /lib when you do a make install?
>
> That will make it easier to link against.
For now the install rule is off by default.
Author: ericwf
Date: Mon May 2 19:36:57 2016
New Revision: 268346
URL: http://llvm.org/viewvc/llvm-project?rev=268346=rev
Log:
Guard use of in test.
Modified:
libcxx/trunk/test/std/numerics/rand/rand.device/ctor.pass.cpp
Modified:
EricWF commandeered this revision.
EricWF edited reviewers, added: STL_MSFT; removed: EricWF.
EricWF added a comment.
Stealing this review from STL.
http://reviews.llvm.org/D19758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF retitled this revision from "[libcxx] [test] Replace non-Standard
"atomic_flag f(false);" with Standard "atomic_flag f = ATOMIC_FLAG_INIT;"." to
"[libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard
"atomic_flag f;" ".
EricWF updated the summary for this revision.
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting before committing.
http://reviews.llvm.org/D20007
___
cfe-commits mailing list
EricWF updated the summary for this revision.
EricWF updated this revision to Diff 53811.
http://reviews.llvm.org/D19006
Files:
include/tuple
test/std/utilities/tuple/tuple.tuple/tuple.cnstr/alloc.pass.cpp
test/std/utilities/tuple/tuple.tuple/tuple.cnstr/alloc_UTypes.pass.cpp
Index:
Author: ericwf
Date: Fri Apr 15 13:05:59 2016
New Revision: 266461
URL: http://llvm.org/viewvc/llvm-project?rev=266461=rev
Log:
Cleanup and guard tuple's constructor SFINAE. Fixes PR22806 and PR23256.
There are two main fixes in this patch.
First the constructor SFINAE was changed so that it's
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/libcxx/test/config.py:66
@@ -65,3 +65,3 @@
self.env = {}
self.use_target = False
self.use_system_cxx_lib = False
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This part LGTM. Sorry about the delay.
Comment at: CMakeLists.txt:187
@@ +186,3 @@
+if (NOT LIBCXXABI_LIBCXX_LIBRARY_PATH)
+ set(LIBCXXABI_LIBCXX_LIBRARY_PATH
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
I appreciate the patch, handling 'ccache' is a good thing to have. I'll look
at this again once the inline comment is addressed.
Comment at: CMakeLists.txt:225
@@
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
This no longer seems relevant.
http://reviews.llvm.org/D16791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
So we already do this for the standalone builds but not for in-tree builds.
Before committing please make sure to remove the code on CMakeLists.txt line 99
that does this same thing.
I'm
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
This patch is no longer relevant.
http://reviews.llvm.org/D18115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added a comment.
If we choose not to use full library paths could you please remove the
'libcxx_library' option? It just does what your trying here but worse, no need
to keep it around.
http://reviews.llvm.org/D16544
___
cfe-commits
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
I think this has been landed (or is no longer relevent) after all of the recent
changes.
http://reviews.llvm.org/D16792
___
cfe-commits mailing list
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
Resigning as reviewer because this patch is no longer relevant.
I fixed the issues today in r266461.
Repository:
rL LLVM
http://reviews.llvm.org/D9085
EricWF added a comment.
Just spitballing but have you considered simply passing the full path,
including the library name, to LIT? Instead of needing `enable_shared`
variables we would simply use the named library, be it DSO or archive.
Comment at:
EricWF updated this revision to Diff 53968.
EricWF added a comment.
I've silenced the tests when they pass as suggested. I added a
'assert_checkpoint.h' support header that stores the last checkpoint a test has
passed and prints that information when std::abort is called.
I also moved the
Author: ericwf
Date: Fri Apr 15 19:23:12 2016
New Revision: 266498
URL: http://llvm.org/viewvc/llvm-project?rev=266498=rev
Log:
Teach map/unordered_map how to optimize 'emplace(Key, T)'.
In cases where emplace is called with two arguments and the first one
matches the key_type we can Key to
Author: ericwf
Date: Fri Apr 15 18:27:27 2016
New Revision: 266491
URL: http://llvm.org/viewvc/llvm-project?rev=266491=rev
Log:
Extract key to avoid preemptive mallocs in insert/emplace in associative
containers
Summary: This patch applies Duncan's work on __hash_table to __tree.
Reviewers:
EricWF added a comment.
I would like to see this patch without the `support/pthread/*.cpp` files. There
are a couple of reasons for this.
1. The symbols in those files are private to the dylib, but they are declared
in the headers and given external visibility.
2. Those symbols frequently use
EricWF abandoned this revision.
EricWF added a comment.
Abandoning. This is super old and a different fix has been checked in.as
r266461.
http://reviews.llvm.org/D12502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added a comment.
Could you generate a diff against the normal directory layout? Your's is
against "libcxxabi/trunk/" where 'trunk' is the actual libcxxabi directory.
http://reviews.llvm.org/D17815
___
cfe-commits mailing list
EricWF added a comment.
In http://reviews.llvm.org/D16544#404283, @bcraig wrote:
> In http://reviews.llvm.org/D16544#403273, @EricWF wrote:
>
> > Just spitballing but have you considered simply passing the full path,
> > including the library name, to LIT? Instead of needing `enable_shared`
>
Author: ericwf
Date: Mon Apr 18 20:19:25 2016
New Revision: 266703
URL: http://llvm.org/viewvc/llvm-project?rev=266703=rev
Log:
Make tuples constructors conditionally EXPLICIT. See N4387
Added:
libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/alloc_const_Types.fail.cpp
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
See http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0033r1.html
http://reviews.llvm.org/D19254
Files:
include/memory
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Could you commit this with a new test
`test/std/utilities/utility/synopsis.pass.cpp` which checks for the presence of
initializer list?
http://reviews.llvm.org/D19280
EricWF added a comment.
OK. Thanks for the update. Sorry we couldn't land this.
http://reviews.llvm.org/D17734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Sun Apr 17 20:40:45 2016
New Revision: 266585
URL: http://llvm.org/viewvc/llvm-project?rev=266585=rev
Log:
Fix LWG issue 2345 - Add insert(value_type&&)
Modified:
libcxx/trunk/include/map
libcxx/trunk/include/unordered_map
Author: ericwf
Date: Sun Apr 17 21:31:05 2016
New Revision: 266586
URL: http://llvm.org/viewvc/llvm-project?rev=266586=rev
Log:
Add tests for LWG issue 2361
Modified:
libcxx/trunk/test/std/utilities/memory/allocator.traits/allocator.traits.types/const_pointer.pass.cpp
EricWF added a comment.
I've updated the diff so it merges and also fixed , ,
and . It can be found here:
https://gist.github.com/EricWF/487e5b1de2bb320e93fbb3c9c758b013
Repository:
rL LLVM
http://reviews.llvm.org/D15404
___
cfe-commits
EricWF added a comment.
It seems my changes to the IO headers removes a bunch of symbols from the
dylib. I'll look into it. I'm assuming it's because clang was already ignoring
the "_LIBCPP_INLINE_VISIBILITY" attribute when instantiating extern templates.
The symbols get removed even if we
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/libcxx/test/config.py:367
@@ -366,2 +366,3 @@
self.cxx.compile_flags.extend(sysroot_flags)
+
Author: ericwf
Date: Tue Apr 19 23:17:39 2016
New Revision: 266855
URL: http://llvm.org/viewvc/llvm-project?rev=266855=rev
Log:
Add cxx_runtime_root options for testing against a different libc++ at runtime
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
Author: ericwf
Date: Tue Apr 19 21:21:33 2016
New Revision: 266851
URL: http://llvm.org/viewvc/llvm-project?rev=266851=rev
Log:
[libcxx] Fix PR15638 - Only allocate in parent when starting a thread to
prevent calling terminate.
Summary:
Hi,
When creating a new thread libc++ performs at least 2
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting.
http://reviews.llvm.org/D13748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ericwf
Date: Tue Apr 19 19:14:32 2016
New Revision: 266836
URL: http://llvm.org/viewvc/llvm-project?rev=266836=rev
Log:
Add 'is_callable' and 'is_nothrow_callable' traits and cleanup INVOKE.
The primary purpose of this patch is to add the 'is_callable' traits.
Since 'is_nothrow_callable'
EricWF abandoned this revision.
EricWF added a comment.
Another solution has been committed.
http://reviews.llvm.org/D11329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu Apr 14 22:29:40 2016
New Revision: 266409
URL: http://llvm.org/viewvc/llvm-project?rev=266409=rev
Log:
[libcxx] Remove the "reduced-arity-initialization" extension from the
uses-allocator constructors
Summary:
A default uses-allocator constructor has been added since
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266409: [libcxx] Remove the "reduced-arity-initialization"
extension from the uses… (authored by EricWF).
Changed prior to commit:
http://reviews.llvm.org/D19006?vs=53813=53835#toc
Repository:
rL
EricWF requested changes to this revision.
This revision now requires changes to proceed.
Comment at: include/__mutex_base:43
@@ -42,3 +42,3 @@
_LIBCPP_INLINE_VISIBILITY
-#ifndef _LIBCPP_HAS_NO_CONSTEXPR
+#ifndef _LIBCPP_HAS_NO_CXX14_CONSTEXPR
constexpr mutex()
EricWF added inline comments.
Comment at: include/__config:300
@@ -299,3 +299,3 @@
-#if !(__has_feature(cxx_exceptions))
+#if !(__has_feature(cxx_exceptions)) && !defined(_LIBCPP_NO_EXCEPTIONS)
#define _LIBCPP_NO_EXCEPTIONS
weimingz wrote:
> Is this change OK?
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Normally system header would simply ignore this problem. However it's valuable
to compile libc++ as a non-system header for both users and developers.
Than you for the patch.
EricWF added a comment.
It's almost there.
Please move "fallback_malloc.ipp" into "fallback_malloc.cpp" and then delete
it all together. We can't have other files trying to include it.
Comment at: src/fallback_malloc.cpp:23
@@ +22,3 @@
+namespace __cxxabiv1 {
+
+void *
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. It's up to you if you want to address the inline comments before
committing.
Thanks for updating the Doc. I really need to kill one version of it.
Comment at:
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
This patch deprecates almost all C++03 extensions offered by .
These extensions started as fallback implementations for compilers without
variadic template support.
Since compiler support
Author: ericwf
Date: Sun Apr 17 21:54:00 2016
New Revision: 266587
URL: http://llvm.org/viewvc/llvm-project?rev=266587=rev
Log:
Add hash specializations for __int128_t. Fixes LWG issue 2119
Modified:
libcxx/trunk/include/functional
Author: ericwf
Date: Mon Apr 18 01:51:33 2016
New Revision: 266591
URL: http://llvm.org/viewvc/llvm-project?rev=266591=rev
Log:
Mark LWG issue 2469 as done. Also simplify try_emplace and insert_or_assign
implementations in unordered_map
Modified:
libcxx/trunk/include/unordered_map
Author: ericwf
Date: Mon Apr 18 01:17:30 2016
New Revision: 266590
URL: http://llvm.org/viewvc/llvm-project?rev=266590=rev
Log:
Implement LWG issue 2219 - support reference_wrapper in INVOKE
Added:
libcxx/trunk/test/std/utilities/function.objects/func.require/bullet_1_2_3.pass.cpp
Author: ericwf
Date: Mon Apr 18 01:58:50 2016
New Revision: 266592
URL: http://llvm.org/viewvc/llvm-project?rev=266592=rev
Log:
Mark P0152R1 as complete.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
EricWF closed this revision.
EricWF added a comment.
This was committed in r264191.
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Sat May 7 00:37:31 2016
New Revision: 268850
URL: http://llvm.org/viewvc/llvm-project?rev=268850=rev
Log:
Fix memory_resource build for _LIBCPP_HAS_NO_THREADS
Modified:
libcxx/trunk/src/experimental/memory_resource.cpp
Modified:
Author: ericwf
Date: Sun May 8 18:08:50 2016
New Revision: 268887
URL: http://llvm.org/viewvc/llvm-project?rev=268887=rev
Log:
Generate code coverage for experimental libraries
Modified:
libcxx/trunk/test/CMakeLists.txt
Modified: libcxx/trunk/test/CMakeLists.txt
URL:
Author: ericwf
Date: Sat May 7 12:05:46 2016
New Revision: 268860
URL: http://llvm.org/viewvc/llvm-project?rev=268860=rev
Log:
Enable Pthread threading API on Solaris. Fix PR27677
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
EricWF added a comment.
For reference here's the current test coverage:
http://efcs.ca/filesystem-coverage/
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added a comment.
In http://reviews.llvm.org/D16948#438880, @rmaprath wrote:
> Looks like I've completely missed this patch somehow. Will try to find some
> time (or someone) to have a look at it from an embedded-systems / ARM point
> of view asap.
>
> Great work!!!
Thanks! Even just
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D21343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ericwf
Date: Fri Jul 22 15:04:56 2016
New Revision: 276462
URL: http://llvm.org/viewvc/llvm-project?rev=276462=rev
Log:
Merging r276215:
r276215 | ericwf | 2016-07-20 17:56:42 -0600 (Wed, 20 Jul 2016) | 9 lines
EricWF updated this revision to Diff 65140.
EricWF added a comment.
Add comment about checking "stronger" orderings.
https://reviews.llvm.org/D22557
Files:
include/atomic
test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp
Index:
EricWF added a reviewer: jfb.
EricWF marked an inline comment as done.
EricWF added a comment.
Address inline comments from @jfb and add him as a reviewer.
Comment at: test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp:86
@@ +85,3 @@
+// does not generate any
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thank you for the thorough doc. It sure made the review easy on my end.
I took the liberty of rewriting your 3 benchmarks to use Google Benchmark:
Author: ericwf
Date: Sun Jul 24 20:45:07 2016
New Revision: 276598
URL: http://llvm.org/viewvc/llvm-project?rev=276598=rev
Log:
Revert r276548 - Make pair/tuples assignment operators SFINAE properly.
This is a breaking change. The SFINAE required is instantiated the second
the class is
Author: ericwf
Date: Sun Jul 24 19:50:32 2016
New Revision: 276595
URL: http://llvm.org/viewvc/llvm-project?rev=276595=rev
Log:
Make dtor_noexcept.pass.cpp tests more portable. Patch from s...@microsoft.com
Modified:
Author: ericwf
Date: Sun Jul 24 19:48:36 2016
New Revision: 276594
URL: http://llvm.org/viewvc/llvm-project?rev=276594=rev
Log:
Don't SFINAE pair's copy assignment operator in C++03 mode.
In C++03 mode evaluating the SFINAE can cause a hard error due to
access control violations. This is a
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I think I'm happy with libc++'s behavior of automatically deducing the dtor
exception specification. This patch LGTM.
https://reviews.llvm.org/D21717
Author: ericwf
Date: Sun Jul 24 21:36:42 2016
New Revision: 276603
URL: http://llvm.org/viewvc/llvm-project?rev=276603=rev
Log:
Recommit r276548 - Make pair/tuples assignment operators SFINAE properly.
I think I've solved issues with is_assignable and references to incomplete
types. The updated
EricWF closed this revision.
EricWF added a comment.
r276593.
https://reviews.llvm.org/D22162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
It's not great that our tests have so many non-portable assertions. Normally we
want to avoid writing non-standard assertions at all, but there doesn't seem to
be a way around it here.
Author: ericwf
Date: Sun Jul 24 23:32:07 2016
New Revision: 276605
URL: http://llvm.org/viewvc/llvm-project?rev=276605=rev
Log:
Implement the std::pair parts of "Improving pair and tuple". Completes N4387.
Added:
Author: ericwf
Date: Sun Jul 24 19:18:12 2016
New Revision: 276591
URL: http://llvm.org/viewvc/llvm-project?rev=276591=rev
Log:
Make move_assign_noexcept.pass.cpp tests more portable. Patch from
s...@microsoft.com
Modified:
EricWF closed this revision.
EricWF added a comment.
r276591.
https://reviews.llvm.org/D21718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
801 - 900 of 2481 matches
Mail list logo
