[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss created this revision. friss added reviewers: jansvoboda11, bnbarham, arphaman. Herald added a subscriber: hiraditya. Herald added a project: All. friss requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Every Clang

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a comment. Thanks for the initial feedback! > Mostly just skimmed so far, will hopefully have some time to look at this > more tomorrow. Out of interest, do you have any performance numbers using > this change? I assume this mainly impacts implicit modules (since I suspect > we'd

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 470644. friss added a comment. Address some review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files:

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:3002 +// The format of the stat cache is (pseudo-code): +// struct stat_cache { +//char Magic[4]; // "STAT" or "Stat" steven_wu wrote: > Few comments about stats

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 472355. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Driver/Options.td

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 472379. friss added a comment. Fix unit test build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 486711. friss added a comment. Fix Windows build (Thanks @ravi-ramaseshan) Address @benlangmuir comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files:

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a comment. In D136651#4030008 , @benlangmuir wrote: > Re-added a few of my minor comments that I think got lost on a specific > version of the diff. Otherwise LGTM. Sorry for missing these. I think I addressed all of them now.

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 486439. friss added a comment. Address review feedback Move StatCacheFileSystem to its own file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files:

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added inline comments. Comment at: clang/tools/clang-stat-cache/clang-stat-cache.cpp:291 + IsCaseSensitive = + ::pathconf(TargetDirectory.c_str(), _PC_CASE_SENSITIVE) == 1; +#endif benlangmuir wrote: > Is this pathconf extension Darwin-only? I don't

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 486466. friss added a comment. Rebase correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 489914. friss added a comment. The pre-commit CI showed some test failures on Windows. Try to address these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files:

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 489968. friss added a comment. More Windows fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a comment. In D136651#4066960 , @mstorsjo wrote: > In D136651#4066949 , @friss wrote: > >> Thanks for the report, unfortunately I have no way of testing this setup. > > Can you try a build with

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a comment. In D136651#4067012 , @glandium wrote: > Oh yes, we're using `-DLLVM_LINK_LLVM_DYLIB=ON` too, so that would be the > main trigger. This was indeed the main trigger. Thanks for the help narrowing this down. I reverted for now.

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a comment. In D136651#4064474 , @glandium wrote: > In D136651#4064260 , @glandium > wrote: > >> This broke our mac builds with errors like: >> >> ld64.lld: error: undefined symbol: CFRunLoopRun >>

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa033dbbe5c43: [Clang] Give Clang the ability to use a shared stat cache (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a subscriber: lebedev.ri. friss added a comment. In D136651#4060071 , @lebedev.ri wrote: > Docs still missing. Sorry @lebedev.ri I missed your earlier comment about this. What format of doc would you like to see? A more elaborate comment

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a comment. In D136651#4063632 , @lebedev.ri wrote: > In D136651#4063597 , @friss wrote: > >> In D136651#4060071 , @lebedev.ri >> wrote: >> >>> Docs still

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 472321. friss added a comment. Add version number in cache file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: