[PATCH] D30107: Make DynamicLibrary::getPermanentLibrary on Windows have a defined ordering.

2017-02-17 Thread Frederich Munch via Phabricator via cfe-commits
marsupial created this revision. This is mostly affecting usage of the JIT... When using DynamicLibrary::getPermanentLibrary(0,0) to get a list of the loaded libs, on Windows this is currently stored in a set which makes iteration unordered / undefined. Additionally there is a problem as newer

[PATCH] D29923: PPCallbacks::MacroUndefined, change signature and add test.

2017-03-20 Thread Frederich Munch via Phabricator via cfe-commits
marsupial added a comment. ping https://reviews.llvm.org/D29923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29923: Add test for PPCallbacks::MacroUndefined

2017-03-13 Thread Frederich Munch via Phabricator via cfe-commits
marsupial updated this revision to Diff 91563. marsupial retitled this revision from "Send UndefMacroDirective to MacroDefined callback" to "Add test for PPCallbacks::MacroUndefined". marsupial edited the summary of this revision. https://reviews.llvm.org/D29923 Files:

[PATCH] D29923: PPCallbacks::MacroUndefined, change signature and add test.

2017-03-13 Thread Frederich Munch via Phabricator via cfe-commits
marsupial updated this revision to Diff 91627. marsupial retitled this revision from "Add test for PPCallbacks::MacroUndefined" to "PPCallbacks::MacroUndefined, change signature and add test.". marsupial edited the summary of this revision. Herald added a subscriber: nemanjai.

[PATCH] D29923: Send UndefMacroDirective to MacroDefined callback

2017-03-07 Thread Frederich Munch via Phabricator via cfe-commits
marsupial added a comment. ping https://reviews.llvm.org/D29923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36701: Use Token::isOneOf method in Parser.

2017-08-14 Thread Frederich Munch via Phabricator via cfe-commits
marsupial created this revision. Easier to read and possibly optimize. https://reviews.llvm.org/D36701 Files: include/clang/Parse/Parser.h Index: include/clang/Parse/Parser.h === --- include/clang/Parse/Parser.h +++

[PATCH] D36702: Make Parser::Consume*Token methods public.

2017-08-14 Thread Frederich Munch via Phabricator via cfe-commits
marsupial created this revision. The fix in r303372 exposed a problem when using **Parser::ConsumeToken** from client code in DEBUG. **ConsumeToken** will assert for all **isTokenSpecial()** cases, but there is no way to call the proper method. The isToken methods are just convenient.

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2017-07-13 Thread Frederich Munch via Phabricator via cfe-commits
marsupial updated this revision to Diff 106548. marsupial added a comment. Blocked Win64 SEH for MingW entirely. Theoretically it should be possible to throw a SEH from within mingw, but but I'm thinking clang may be generating exception handlers for the gcc runtime in that case. I'll leave it

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2017-07-13 Thread Frederich Munch via Phabricator via cfe-commits
marsupial marked 3 inline comments as done. marsupial added a comment. Done, and changed to 'windows.h', but blocked mingw from even attempting SEH for now. https://reviews.llvm.org/D35103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2017-07-24 Thread Frederich Munch via Phabricator via cfe-commits
marsupial added a comment. Ping. https://reviews.llvm.org/D35103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2017-07-06 Thread Frederich Munch via Phabricator via cfe-commits
marsupial created this revision. Herald added a subscriber: mgorny. Getting this to work is not particularly obvious, and having it as an example should be helpful. Portions of this could be placed into LLVM, but as a whole it seems necessary to do this a higher level.

[PATCH] D33659: Extend DynamicLibrary class to be usable without loading permanently.

2017-07-06 Thread Frederich Munch via Phabricator via cfe-commits
marsupial added a comment. ping https://reviews.llvm.org/D33659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33659: Extend DynamicLibrary class to be usable without loading permanently.

2017-07-06 Thread Frederich Munch via Phabricator via cfe-commits
marsupial updated this revision to Diff 105466. https://reviews.llvm.org/D33659 Files: lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp Index: lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp === ---

[PATCH] D29923: PPCallbacks::MacroUndefined, change signature and add test.

2017-04-26 Thread Frederich Munch via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL301449: PPCallbacks::MacroUndefined, change signature and add test. (authored by marsupial). Changed prior to commit: https://reviews.llvm.org/D29923?vs=91627=96808#toc Repository: rL LLVM

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2017-07-28 Thread Frederich Munch via Phabricator via cfe-commits
marsupial marked 3 inline comments as done. marsupial added a comment. Done, thanks. Would it be possible to look at https://reviews.llvm.org/D30709 as this depends on that. (ELF does not like Windows exceptions). https://reviews.llvm.org/D35103

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2017-07-28 Thread Frederich Munch via Phabricator via cfe-commits
marsupial updated this revision to Diff 108676. marsupial added a comment. Use include guards, not pragma once and remove commented CMake debug lines. https://reviews.llvm.org/D35103 Files: examples/clang-interpreter/CMakeLists.txt examples/clang-interpreter/Invoke.cpp

[PATCH] D33659: Extend DynamicLibrary class to be usable without loading permanently.

2017-05-29 Thread Frederich Munch via Phabricator via cfe-commits
marsupial created this revision. https://reviews.llvm.org/D33659 Files: lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp Index: lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp === ---

[PATCH] D36702: Make Parser::Consume*Token methods public.

2018-02-15 Thread Frederich Munch via Phabricator via cfe-commits
marsupial added a comment. Ping. https://reviews.llvm.org/D36702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36701: Use Token::isOneOf method in Parser.

2018-02-15 Thread Frederich Munch via Phabricator via cfe-commits
marsupial added a comment. Ping. https://reviews.llvm.org/D36701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36701: Use Token::isOneOf method in Parser.

2018-02-16 Thread Frederich Munch via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325352: Use Token::isOneOf method in Parser. (authored by marsupial, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44508: Remove unnecessary include from Driver.cpp

2018-03-15 Thread Frederich Munch via Phabricator via cfe-commits
marsupial added a comment. Shouldn't the Translation Unit be responsible for knowing what it needs rather than hoping it's already been used somewhere up the chain. Perhaps std::unique_ptr and std::make_pair are too low level and one can assume, but https://reviews.llvm.org/D44509 seems like a

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

2018-03-14 Thread Frederich Munch via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC327528: Expand clang-interpreter with example of throwing in and from the JIT for… (authored by marsupial, committed by ). Repository: rC Clang https://reviews.llvm.org/D35103 Files:

[PATCH] D44555: clang-interpreter example cmake fix

2018-03-17 Thread Frederich Munch via Phabricator via cfe-commits
marsupial accepted this revision. marsupial added a comment. This revision is now accepted and ready to land. Sorry 'bout that... (CMake and quoting make dull boys) Repository: rC Clang https://reviews.llvm.org/D44555 ___ cfe-commits mailing

[PATCH] D44643: [Lex] Change HeaderSearchOptions arguments to std::string.

2018-03-19 Thread Frederich Munch via Phabricator via cfe-commits
marsupial created this revision. marsupial added reviewers: eugene, boris. marsupial added a project: clang. marsupial updated this revision to Diff 138982. Arguments passed to HeaderSearchOptions methods are stored as std::strings, having them converted to a StringRef at the call site can

[PATCH] D44643: [Lex] Change HeaderSearchOptions arguments to std::string.

2018-03-19 Thread Frederich Munch via Phabricator via cfe-commits
marsupial updated this revision to Diff 138982. https://reviews.llvm.org/D44643 Files: include/clang/Lex/HeaderSearchOptions.h Index: include/clang/Lex/HeaderSearchOptions.h === --- include/clang/Lex/HeaderSearchOptions.h +++