[PATCH] D46435: [x86] Introduce the encl[u|s|v] intrinsics

GBuella created this revision. GBuella added reviewers: craig.topper, zvi. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D46435 Files: lib/Headers/CMakeLists.txt lib/Headers/module.modulemap lib/Headers/sgxintrin.h lib/Headers/x86intrin.h

[PATCH] D46431: [x86] Introduce the pconfig intrinsic

GBuella updated this revision to Diff 145207. https://reviews.llvm.org/D46431 Files: include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt lib/Headers/cpuid.h lib/Headers/module.modulemap lib/Headers/pconfigintrin.h

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella requested review of this revision. GBuella added a comment. Oops, accepted this by accident. Repository: rC Clang https://reviews.llvm.org/D45616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46742: [X86] Use __builtin_convertvector to replace some of the avx512 truncate builtins.

GBuella accepted this revision. GBuella added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella accepted this revision. GBuella added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46540: [X86] ptwrite intrinsic

GBuella added a comment. In https://reviews.llvm.org/D46540#1091625, @Hahnfeld wrote: > Could you maybe add some short summaries to your patches? It's hard for > non-Intel employees to guess what all these instructions do... Well, I was thinking I could copy-paste this from

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

GBuella updated this revision to Diff 145876. https://reviews.llvm.org/D46541 Files: lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h test/CodeGen/target-features-error-2.c test/CodeGen/target-features-error.c Index:

[PATCH] D46435: [x86] Introduce the encl[u|s|v] intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC331743: [x86] Introduce the encl[u|s|v] intrinsics (authored by GBuella, committed by ). Changed prior to commit: https://reviews.llvm.org/D46435?vs=145205=145638#toc Repository: rC Clang

[PATCH] D46431: [x86] Introduce the pconfig intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL331740: [x86] Introduce the pconfig intrinsic (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D46431: [x86] Introduce the pconfig intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rC331740: [x86] Introduce the pconfig intrinsic (authored by GBuella, committed by ). Repository: rC Clang https://reviews.llvm.org/D46431 Files: include/clang/Driver/Options.td

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella added a comment. In https://reviews.llvm.org/D45616#1067492, @efriedma wrote: > > The fcmp opcode has no defined behavior with NaN operands in the > > comparisions handled in this patch. > > Could you describe the problem here in a bit more detail? As far as I know, > the LLVM IR fcmp

[PATCH] D46683: [X86] Assume alignment of movdir64b dst argument

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D46683 Files: lib/Headers/movdirintrin.h test/CodeGen/builtin-movdir.c Index: test/CodeGen/builtin-movdir.c

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella added a comment. In https://reviews.llvm.org/D45616#1093514, @efriedma wrote: > There is no difference between "signalling" and "non-signalling" unless > you're using "#pragma STDC FENV_ACCESS", which is currently not supported. > Presumably the work to implement that will include

[PATCH] D46540: [X86] ptwrite intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rC331962: [X86] ptwrite intrinsic (authored by GBuella, committed by ). Changed prior to commit: https://reviews.llvm.org/D46540?vs=145681=146081#toc Repository: rC Clang

[PATCH] D46683: [X86] Assume alignment of movdir64b dst argument

GBuella added a comment. In https://reviews.llvm.org/D46683#1094662, @craig.topper wrote: > What effect does this have? Nothing important really, I just guessed it doesn't cost. One contrived example I could come up with in 2 minutes: #include void x(char *restrict a

[PATCH] D46742: [X86] Use __builtin_convertvector to replace some of the avx512 truncate builtins.

GBuella added a comment. In https://reviews.llvm.org/D46742#1095658, @tkrupa wrote: > There are four other similar intrinsics which convert to 128/256-bit vectors: > > __m128i _mm256_cvtepi32_epi8 (__m256i a) > __m128i _mm256_cvtepi64_epi16 (__m256i a) > __m128i _mm256_cvtepi64_epi8 (__m256i

[PATCH] D46683: [X86] Assume alignment of movdir64b dst argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL332091: [X86] Assume alignment of movdir64b dst argument (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46683 Files:

[PATCH] D46540: [X86] ptwrite intrinsic

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D46540 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

GBuella created this revision. GBuella added reviewers: craig.topper, echristo, dblaikie. Herald added a subscriber: cfe-commits. When requirement imposed by __target__ attributes on functions are not satisfied, prefer printing those requirements, which are explicitly mentioned in the attributes.

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

GBuella updated this revision to Diff 145680. https://reviews.llvm.org/D46541 Files: lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h test/CodeGen/target-features-error-2.c test/CodeGen/target-features-error.c Index:

[PATCH] D46540: [X86] ptwrite intrinsic

GBuella updated this revision to Diff 145681. GBuella added a comment. Rebased. https://reviews.llvm.org/D46540 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D46431: [x86] Introduce the pconfig intrinsic

GBuella created this revision. GBuella added reviewers: craig.topper, zvi. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D46431 Files: include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

GBuella added a comment. Here is a variation on this, using inline asm: https://reviews.llvm.org/D46431 https://reviews.llvm.org/D44387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47142: [x86] invpcid intrinsic

GBuella added a comment. In https://reviews.llvm.org/D47142#1106664, @rnk wrote: > Why do we need a feature flag for this in the first place? The MSVC model for > most "instruction" intrinsics is that the exact instruction is emitted > regardless of the feature enabled. The target attribute

[PATCH] D47142: [x86] invpcid intrinsic

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added subscribers: cfe-commits, mgorny. An intrinsic for an old instruction, as described in the Intel SDM. Repository: rC Clang https://reviews.llvm.org/D47142 Files: include/clang/Basic/BuiltinsX86.def

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella added a comment. Ping @efriedma Repository: rC Clang https://reviews.llvm.org/D45616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

GBuella updated this revision to Diff 147775. GBuella added a comment. Fixed a horrible bug in the patch. Adding a ref to temporary string is not a wise thing to do, so I had to remove this line: ReqFeatures.push_back(F.substr(1)); Now the ReqFeatures vector can also refer to strings

[PATCH] D47142: [x86] invpcid intrinsic

GBuella added inline comments. Comment at: lib/Headers/intrin.h:196 + */ void __cdecl _invpcid(unsigned int, void *); +#endif rnk wrote: > craig.topper wrote: > > @rnk, what's the right thing to do here? > What problems does this redeclaration cause? Now that I

[PATCH] D47142: [x86] invpcid intrinsic

GBuella added inline comments. Comment at: lib/Headers/intrin.h:196 + */ void __cdecl _invpcid(unsigned int, void *); +#endif GBuella wrote: > rnk wrote: > > craig.topper wrote: > > > @rnk, what's the right thing to do here? > > What problems does this

[PATCH] D47142: [x86] invpcid intrinsic

GBuella added inline comments. Comment at: lib/Headers/intrin.h:196 + */ void __cdecl _invpcid(unsigned int, void *); +#endif rnk wrote: > GBuella wrote: > > GBuella wrote: > > > rnk wrote: > > > > craig.topper wrote: > > > > > @rnk, what's the right thing to

[PATCH] D46052: GNUstep Objective-C ABI version 2

GBuella added inline comments. Comment at: lib/CodeGen/CGObjCGNU.cpp:1056 +char c = Str[i]; +if (isalpha(c) || isnumber(c)) + StringName += c; GBuella wrote: > theraven wrote: > > Ka-Ka wrote: > > > The isnumber() function was added to

[PATCH] D46052: GNUstep Objective-C ABI version 2

GBuella added inline comments. Comment at: lib/CodeGen/CGObjCGNU.cpp:1056 +char c = Str[i]; +if (isalpha(c) || isnumber(c)) + StringName += c; theraven wrote: > Ka-Ka wrote: > > The isnumber() function was added to cctype.h by Apple. I

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

GBuella updated this revision to Diff 147984. https://reviews.llvm.org/D46541 Files: lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h test/CodeGen/target-features-error-2.c test/CodeGen/target-features-error.c Index:

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

GBuella added a comment. In https://reviews.llvm.org/D46541#1106743, @craig.topper wrote: > I think you can pass StringRef(F).substr(1). That won't create a temporary > string. It will just create a StringRef pointing into the middle of an > existing std::string stored in the parsed

[PATCH] D47142: [x86] invpcid intrinsic

GBuella updated this revision to Diff 148011. https://reviews.llvm.org/D47142 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt lib/Headers/cpuid.h lib/Headers/invpcidintrin.h

[PATCH] D47182: [X86] Move all Intel defined intrinsic includes into immintrin.h

GBuella added a comment. What does "imm" mean anyways? Repository: rC Clang https://reviews.llvm.org/D47182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47142: [x86] invpcid intrinsic

GBuella updated this revision to Diff 148341. GBuella added a comment. Relocated header inclusion from x86intrin.h -> immintrin.h I gave up on the MSVC intrinsic idea, it wouldn't work in a way compatible with MSVC as long as LLVM requires the feature to be enabled anyways. If once we decide to

[PATCH] D47142: [x86] invpcid intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL333256: [x86] invpcid intrinsic (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47142?vs=148341=148547#toc Repository:

[PATCH] D47125: [X86] Remove masking from pternlog llvm intrinsics and use a select instruction instead.

GBuella added a comment. So do these really need to be implemented as macros? Repository: rC Clang https://reviews.llvm.org/D47125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella updated this revision to Diff 150767. GBuella added a comment. I altered the code, to ignore the the signaling behaviour, as suggested. Also, it handles more vector cmp builtins now. https://reviews.llvm.org/D45616 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx-builtins.c

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella added a comment. Ping @efriedma https://reviews.llvm.org/D45616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella updated this revision to Diff 151710. https://reviews.llvm.org/D45616 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx-builtins.c test/CodeGen/avx-cmp-builtins.c test/CodeGen/avx2-builtins.c test/CodeGen/avx512f-builtins.c test/CodeGen/avx512vl-builtins.c Index:

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella added a comment. The question still left is, should we remove, auto upgrade the LLVM intrinsics not used anymore, or keep them around for when the signal behaviour is going to matter? https://reviews.llvm.org/D45616 ___ cfe-commits

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:10071 + // is _MM_FROUND_CUR_DIRECTION + if (cast(Ops[4])->getZExtValue() != 4) +UsesNonDefaultRounding = true; efriedma wrote: > Given we're ignoring floating-point

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella updated this revision to Diff 151203. GBuella edited the summary of this revision. GBuella added a comment. Ignoring signaling behviour - and rounding mode with it. Also lowering `__builtin_ia32_cmpsd` and `__builtin_ia32_cmpss`. https://reviews.llvm.org/D45616 Files:

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:10090-10100 +// _CMP_TRUE_UQ, _CMP_TRUE_US produce -1,-1... vector +// on any input and _CMP_FALSE_OQ, _CMP_FALSE_OS produce 0, 0... +if (CC == 0xf || CC == 0xb || CC == 0x1b || CC == 0x1f) { +

[PATCH] D47912: [CMake] Consider LLVM_APPEND_VC_REV when generating SVNVersion.inc

GBuella added a comment. In https://reviews.llvm.org/D47912#1125803, @smeenai wrote: > I believe LLVM_APPEND_VC_REV controls whether the revision is appended to > LLVM version string (e.g. the output of `llvm-config --version`), whereas the > SVNRevision.inc file (which is what's causing the

[PATCH] D47912: [CMake] Consider LLVM_APPEND_VC_REV when generating SVNVersion.inc

GBuella created this revision. GBuella added reviewers: beanz, bogner, hintonda. Herald added subscribers: cfe-commits, mgorny. This is merely a quickfix, due to being fustrated with waiting for ~70 objects to be linked each time following `git commit --amend`. When toggling LLVM_APPEND_VC_REV

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:10107-10112 +case 0x0b: // FALSE_OQ +case 0x1b: // FALSE_OS + return llvm::Constant::getNullValue(ConvertType(E->getType())); +case 0x0f: // TRUE_UQ +case 0x1f: // TRUE_US + return

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

GBuella added inline comments. Comment at: test/CodeGen/target-features-error-2.c:39 __m128d need_avx(__m128d a, __m128d b) { return _mm_cmp_sd(a, b, 0); // expected-error {{'__builtin_ia32_cmpsd' needs target feature avx}} } craig.topper wrote: > The 4

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

GBuella updated this revision to Diff 150018. https://reviews.llvm.org/D46541 Files: lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h test/CodeGen/target-features-error-2.c test/CodeGen/target-features-error.c Index:

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

GBuella marked an inline comment as done. GBuella added inline comments. Comment at: test/CodeGen/target-features-error-2.c:39 __m128d need_avx(__m128d a, __m128d b) { return _mm_cmp_sd(a, b, 0); // expected-error {{'__builtin_ia32_cmpsd' needs target feature avx}} }

[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL334174: [CodeGen] Improve diagnostics related to target attributes (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL331249: [X86] directstore and movdir64b intrinsics (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43459: [X86] Disable CLWB in Cannon Lake

GBuella created this revision. GBuella added reviewers: craig.topper, zvi, echristo. Herald added a subscriber: cfe-commits. Cannon Lake does not support CLWB, therefore it does not include all features listed under SKX. Repository: rC Clang https://reviews.llvm.org/D43459 Files:

[PATCH] D43459: [X86] Disable CLWB in Cannon Lake

GBuella added a comment. See also: https://reviews.llvm.org/D43380 Repository: rC Clang https://reviews.llvm.org/D43459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella updated this revision to Diff 151884. GBuella added a comment. Added `__builtin_ia32_cmpsd_mask` & `__builtin_ia32_cmpss_mask`. https://reviews.llvm.org/D45616 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx-builtins.c test/CodeGen/avx-cmp-builtins.c

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

This revision was automatically updated to reflect the committed changes. Closed by commit rC335339: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR (authored by GBuella, committed by ). Changed prior to commit: https://reviews.llvm.org/D45616?vs=152060=152456#toc

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

GBuella added a comment. ping @spatel https://reviews.llvm.org/D48715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

This revision was automatically updated to reflect the committed changes. Closed by commit rC336355: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates (authored by GBuella, committed by ). Repository: rC Clang https://reviews.llvm.org/D48715 Files: lib/CodeGen/CGBuiltin.cpp

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

GBuella updated this revision to Diff 154216. GBuella added a comment. As suggested, I added test cases with all predicates (in r336346). https://reviews.llvm.org/D48715 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx-builtins.c test/CodeGen/avx512f-builtins.c

[PATCH] D48921: NFC - type fix in test/CodeGenCXX/runtime-dllstorage.cpp

GBuella created this revision. GBuella added reviewers: compnerd, espindola. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D48921 Files: test/CodeGenCXX/runtime-dllstorage.cpp Index: test/CodeGenCXX/runtime-dllstorage.cpp

[PATCH] D48921: NFC - type fix in test/CodeGenCXX/runtime-dllstorage.cpp

GBuella requested review of this revision. GBuella added a comment. Well, apparently the test fails with the typo fix. There is no `declare dllimport void @_ZSt9terminatev()` line that could be matched for `CHECK-DYNAMIC-IA-DAG`. Repository: rC Clang https://reviews.llvm.org/D48921

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

GBuella created this revision. GBuella added reviewers: craig.topper, zvi. Herald added subscribers: cfe-commits, mgorny. Introduce pconfig and SGX related intrinsics. Repository: rC Clang https://reviews.llvm.org/D44387 Files: include/clang/Basic/BuiltinsX86.def

[PATCH] D43817: [x86] wbnoinvd intrinsic

GBuella updated this revision to Diff 136510. GBuella edited the summary of this revision. GBuella added a comment. Added Ice Lake Server architecture. Removed wbinvd related code. https://reviews.llvm.org/D43817 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

GBuella added inline comments. Comment at: lib/Headers/waitpkgintrin.h:41 +static __inline__ void __DEFAULT_FN_ATTRS +_umwait (__SIZE_TYPE__ __CONTROL, __UINT64_TYPE__ __COUNTER) +{ craig.topper wrote: > Why does the intrinsic take size_t but then its

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

GBuella updated this revision to Diff 141319. GBuella added a comment. Using the modified LLVM intrinsics from https://reviews.llvm.org/D45253. https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp

[PATCH] D43815: CodeGen tests - typo fixes

GBuella closed this revision. GBuella added a comment. Commited r329688 https://reviews.llvm.org/rL329689 Repository: rC Clang https://reviews.llvm.org/D43815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43815: CodeGen tests - typo fixes

GBuella added a comment. See: https://reviews.llvm.org/rL329689 Repository: rC Clang https://reviews.llvm.org/D43815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45488: [X86] Disable SGX for Skylake Server - CPP test

GBuella created this revision. GBuella added reviewers: craig.topper, davezarzycki. Herald added a subscriber: cfe-commits. Fix test case - corresponding to r329701 Repository: rC Clang https://reviews.llvm.org/D45488 Files: test/Preprocessor/predefined-arch-macros.c Index:

[PATCH] D45488: [X86] Disable SGX for Skylake Server - CPP test

GBuella updated this revision to Diff 141853. https://reviews.llvm.org/D45488 Files: test/Preprocessor/predefined-arch-macros.c Index: test/Preprocessor/predefined-arch-macros.c === --- test/Preprocessor/predefined-arch-macros.c

[PATCH] D45058: [X86] Disable SGX for Skylake Server

This revision was automatically updated to reflect the committed changes. Closed by commit rC329701: [X86] Disable SGX for Skylake Server (authored by GBuella, committed by ). Changed prior to commit: https://reviews.llvm.org/D45058?vs=140302=141839#toc Repository: rL LLVM

[PATCH] D45058: [X86] Disable SGX for Skylake Server

This revision was automatically updated to reflect the committed changes. Closed by commit rL329701: [X86] Disable SGX for Skylake Server (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45058 Files:

[PATCH] D45488: [X86] Disable SGX for Skylake Server - CPP test

This revision was automatically updated to reflect the committed changes. Closed by commit rL329710: [X86] Disable SGX for Skylake Server - CPP test (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45488: [X86] Disable SGX for Skylake Server - CPP test

GBuella added a comment. In https://reviews.llvm.org/D45488#1063067, @davezarzycki wrote: > I don't think this change is correct. To the best of my knowledge, SKL does > support SGX but SKX does not. llvm-lit test/Preprocessor/predefined-arch-macros.c passes now. I didn't know tests are not

[PATCH] D45056: [X86] Split up -march=icelake to -client & -server

This revision was automatically updated to reflect the committed changes. Closed by commit rL329741: [X86] Split up -march=icelake to -client -server (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D43817: [x86] wbnoinvd intrinsic

GBuella updated this revision to Diff 141904. GBuella added a comment. Rebased the patch. https://reviews.llvm.org/D43817 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D45311: Introduce wbinvd intrinsic

GBuella created this revision. GBuella added reviewers: craig.topper, echristo. Herald added a subscriber: cfe-commits. A previously missing intrinsic for an old instruction. Repository: rC Clang https://reviews.llvm.org/D45311 Files: include/clang/Basic/BuiltinsX86.def

[PATCH] D45311: Introduce wbinvd intrinsic

GBuella added a comment. The reason is, the _wbnoinvd intrinsic, and builtin were just recently introduced in GCC. Repository: rC Clang https://reviews.llvm.org/D45311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

GBuella created this revision. GBuella added reviewers: craig.topper, zvi. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp

[PATCH] D45257: [X86] Introduce cldemote intrinsic

GBuella created this revision. GBuella added reviewers: craig.topper, zvi. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D45257 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp

[PATCH] D45257: [X86] Introduce cldemote intrinsic

GBuella updated this revision to Diff 141021. https://reviews.llvm.org/D45257 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt lib/Headers/cldemoteintrin.h lib/Headers/cpuid.h

[PATCH] D43817: [x86] wbnoinvd intrinsic

GBuella added inline comments. Comment at: lib/Basic/Targets/X86.cpp:188 setFeatureEnabledImpl(Features, "mpx", true); if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX setFeatureEnabledImpl(Features, "sgx", true);

[PATCH] D45561: NFC - Indentation fixes in predefined-arch-macros.c

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added subscribers: cfe-commits, fedor.sergeev. Consistently separating tests with empty lines. Helps while navigating this file. Repository: rC Clang https://reviews.llvm.org/D45561 Files:

[PATCH] D45311: [X86] Introduce wbinvd intrinsic

GBuella updated this revision to Diff 142142. GBuella retitled this revision from "Introduce wbinvd intrinsic" to "[X86] Introduce wbinvd intrinsic". https://reviews.llvm.org/D45311 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/ia32intrin.h test/CodeGen/builtin-wbinvd.c Index:

[PATCH] D43817: [x86] wbnoinvd intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rC329848: [x86] wbnoinvd intrinsic (authored by GBuella, committed by ). Repository: rC Clang https://reviews.llvm.org/D43817 Files: docs/ClangCommandLineReference.rst

[PATCH] D45561: NFC - Indentation fixes in predefined-arch-macros.c

This revision was automatically updated to reflect the committed changes. Closed by commit rC329932: NFC - Indentation fixes in predefined-arch-macros.c (authored by GBuella, committed by ). Changed prior to commit: https://reviews.llvm.org/D45561?vs=142138=142223#toc Repository: rC Clang

[PATCH] D45311: [X86] Introduce wbinvd intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL329937: [X86] Introduce wbinvd intrinsic (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45311?vs=142142=142228#toc

[PATCH] D45257: [X86] Introduce cldemote intrinsic

GBuella updated this revision to Diff 142340. GBuella added a comment. Rebase. https://reviews.llvm.org/D45257 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt

[PATCH] D45257: [X86] Introduce cldemote intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL329993: [X86] Introduce cldemote intrinsic (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45257?vs=142340=142345#toc

[PATCH] D45613: [X86] Introduce archs: goldmont-plus & tremont

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D45613 Files: include/clang/Basic/X86Target.def lib/Basic/Targets/X86.cpp test/Driver/x86-march.c

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added a subscriber: cfe-commits. The fcmp opcode has no defined behavior with NaN operands in the comparisions handled in this patch. Thus, these intrinsics can only be safe lowered to fcmp opcodes when fast-math is

[PATCH] D45613: [X86] Introduce archs: goldmont-plus & tremont

GBuella added a comment. I was not sure about what predefined macros to add for goldmont-plus & tremont. I found this conversation: https://reviews.llvm.org/D38824 which seems to suggest no new arch specifix macros. But apparently atom archs have their own macros. Repository: rC Clang

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

GBuella updated this revision to Diff 142913. https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt lib/Headers/cpuid.h lib/Headers/waitpkgintrin.h

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

GBuella updated this revision to Diff 142910. GBuella added a comment. Modified the intrinsic. https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt

[PATCH] D45254: [X86] WaitPKG intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL330463: [X86] WaitPKG intrinsics (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45254?vs=143249=143355#toc

[PATCH] D45613: [X86] Introduce archs: goldmont-plus & tremont

This revision was automatically updated to reflect the committed changes. Closed by commit rL330110: [X86] Introduce archs: goldmont-plus tremont (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45613 Files:

[PATCH] D45254: [X86] WaitPKG intrinsics

GBuella updated this revision to Diff 143249. GBuella retitled this revision from "[X86][WAITPKG] WaitPKG intrinsics" to "[X86] WaitPKG intrinsics". https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

GBuella updated this revision to Diff 143639. GBuella added a comment. Rebased the patch. Added pconfig to Icelake Server. https://reviews.llvm.org/D44387 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella updated this revision to Diff 143647. https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

  1   2   >