[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

2021-12-24 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid added a comment. In D116188#3208456 , @HazardyKnusperkeks wrote: > Since you only upload a diff, there is no name or email. ;) It had looked like arcanist was retaining this information, but I now realize what it was doing. At any rate, I

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

2021-12-24 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid abandoned this revision. yodaldevoid added a comment. In D116229#3209414 , @owenpan wrote: > In D116229#3208507 , @curdeius > wrote: > >> Why this option is useful? Why would someone want to have a

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

2021-12-22 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid created this revision. yodaldevoid added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. yodaldevoid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Single-variant enums were still getting placed on a single

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

2021-12-22 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid created this revision. yodaldevoid added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. yodaldevoid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

2021-12-22 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid added a comment. I do not have commit access to the main repo. If someone who does could push it up I would appreciate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116189/new/ https://reviews.llvm.org/D116189

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

2021-12-23 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid updated this revision to Diff 396041. yodaldevoid added a comment. Addressed reviewer comments - Removed unnecessary null checks - Added tests for typedefs preceding short enums Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

2021-12-23 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid created this revision. yodaldevoid added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. yodaldevoid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I personally prefer that pointers are aligned to the right

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

2021-12-23 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid updated this revision to Diff 396060. yodaldevoid added a comment. Correct commit email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/ https://reviews.llvm.org/D116188 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

2021-12-23 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid updated this revision to Diff 396064. yodaldevoid added a comment. Correct commit email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116189/new/ https://reviews.llvm.org/D116189 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

2021-12-23 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid added a comment. In D116189#3207717 , @MyDeveloperDay wrote: > We need your name and email address to be able to commit as you Ah, right. `arcanist` should keep that information, but I wish Phabricator would give a way to provide it as

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

2021-12-23 Thread Gabriel Smith via Phabricator via cfe-commits
yodaldevoid updated this revision to Diff 396062. yodaldevoid added a comment. Correct commit email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116229/new/ https://reviews.llvm.org/D116229 Files: clang/include/clang/Format/Format.h