Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

The 3.7 branch does have the include guards; they were re-added in http://llvm.org/viewvc/llvm-project?rev=243925view=rev. That happened after rc2, but it will be in rc3. Can you double check if you're still running into problems on the 3.7 branch? - Hans On Mon, Aug 17, 2015 at 3:04 PM,

Re: r245257 - Generating assumption loads of vptr after ctor call

I reverted this in r245260 as it caused https://llvm.org/bugs/show_bug.cgi?id=24479 - Hans On Mon, Aug 17, 2015 at 4:34 PM, Piotr Padlewski via cfe-commits cfe-commits@lists.llvm.org wrote: Author: prazek Date: Mon Aug 17 18:33:49 2015 New Revision: 245257 URL:

r245260 - Revert r245257 Generating assumption loads of vptr after ctor call

Author: hans Date: Mon Aug 17 19:17:58 2015 New Revision: 245260 URL: http://llvm.org/viewvc/llvm-project?rev=245260view=rev Log: Revert r245257 Generating assumption loads of vptr after ctor call It caused PR24479 Removed: cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp Modified:

r245259 - Doxygen: add build option to use svg instead of png files for graphs

Author: hans Date: Mon Aug 17 18:38:56 2015 New Revision: 245259 URL: http://llvm.org/viewvc/llvm-project?rev=245259view=rev Log: Doxygen: add build option to use svg instead of png files for graphs Differential Revision: http://reviews.llvm.org/D11994 Modified:

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg h...@chromium.org wrote: On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits cfe-commits@lists.llvm.org wrote: Author: rnk Date: Mon Aug 10 14:39:01 2015 New Revision: 244488 URL:

Re: r244902 - Driver: Fix include directories when not using libgcc under mingw

Richard, I tried to ping you on the review thread but I'm not sure it got through. Martell requested this be merged to 3.7. What do you think? On Thu, Aug 13, 2015 at 8:41 AM, Martell Malone via cfe-commits cfe-commits@lists.llvm.org wrote: Author: martell Date: Thu Aug 13 10:41:04 2015 New

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

() { long double a; std::coutsizeof(a)std::endl; } which outputs 12 with mingw 32 bit, 16 with mingw 64 bit but always 16 with current clang. I fixed this and added test in r245459+r245462. 2015-08-19 19:41 GMT+03:00 Hans Wennborg via cfe-commits cfe-commits@lists.llvm.org: On Tue, Aug 18

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

On Thu, Aug 20, 2015 at 8:28 PM, Saleem Abdulrasool compn...@compnerd.org wrote: On Thu, Aug 20, 2015 at 2:13 PM, Hans Wennborg h...@chromium.org wrote: +Saleem and Renato; maybe you can take a look? Thanks for pointing this out! The patch is correct and pretty safe to apply for 3.7 I

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

Awesome, thanks! On Tue, Aug 18, 2015 at 4:27 PM, Reid Kleckner r...@google.com wrote: I merged both of them and tweaked the test case to make it work. On Tue, Aug 18, 2015 at 2:55 PM, Hans Wennborg h...@chromium.org wrote: On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg h...@chromium.org

Re: r245041 - [OPENMP] Fix for http://llvm.org/PR24371: Assert failure compiling blender 2.75.

Merged in r245229. There were merge conflicts in StmtOpenMP.h because we don't have r244209 on the branch. I think I got it right, but I'd appreciate if someone could double check http://llvm.org/viewvc/llvm-project?rev=245229view=rev Thanks, Hans On Sun, Aug 16, 2015 at 8:55 PM, Bataev, Alexey

Re: r245560 - Fix crash with two typos in the arguments of a function

Merged in r245615. Thanks, Hans On Thu, Aug 20, 2015 at 12:13 PM, Richard Smith rich...@metafoo.co.uk wrote: LGTM for branch. On Aug 20, 2015 9:47 AM, Hans Wennborg h...@chromium.org wrote: It was requested that this be merged to 3.7. Richard: OK for merging? Thanks, Hans On Thu, Aug

Re: [PATCH] Fix out-of-bounds array access when setting arm float registers

+Saleem and Renato; maybe you can take a look? On Tue, Aug 18, 2015 at 11:24 AM, Leandro Graciá Gil cfe-commits@lists.llvm.org wrote: Hi, Please find attached a patch fixing an out-of-bounds array access present in the current libunwind top of tree code. The problem is caused by subtracting

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

with current clang. I fixed this and added test in r245459+r245462. 2015-08-19 19:41 GMT+03:00 Hans Wennborg via cfe-commits cfe-commits@lists.llvm.org: On Tue, Aug 18, 2015 at 6:11 PM, Richard Smith rich...@metafoo.co.uk wrote: On Tue, Aug 18, 2015 at 3:01 PM, Hans Wennborg h

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits cfe-commits@lists.llvm.org wrote: Author: rnk Date: Mon Aug 10 14:39:01 2015 New Revision: 244488 URL: http://llvm.org/viewvc/llvm-project?rev=244488view=rev Log: [dllimport] A non-imported class with an imported key can't have

Re: r244961 - [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.

On Thu, Aug 13, 2015 at 2:45 PM, Brad Smith via cfe-commits cfe-commits@lists.llvm.org wrote: Author: brad Date: Thu Aug 13 16:45:57 2015 New Revision: 244961 URL: http://llvm.org/viewvc/llvm-project?rev=244961view=rev Log: [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.

Re: [libcxx] r244462 - Protect template argument from user interference.

On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits cfe-commits@lists.llvm.org wrote: On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via cfe-commits wrote: Author: joerg Date: Mon Aug 10 11:58:04 2015 New Revision: 244462 URL:

Re: [libcxx] r244462 - Protect template argument from user interference.

On Mon, Aug 10, 2015 at 5:26 PM, Marshall Clow mclow.li...@gmail.com wrote: On Mon, Aug 10, 2015 at 11:12 AM, Hans Wennborg h...@chromium.org wrote: On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits cfe-commits@lists.llvm.org wrote: On Mon, Aug 10, 2015 at 04:58:04PM

[libcxx] r244553 - Merging r244462:

Author: hans Date: Mon Aug 10 19:55:30 2015 New Revision: 244553 URL: http://llvm.org/viewvc/llvm-project?rev=244553view=rev Log: Merging r244462: r244462 | joerg | 2015-08-10 09:58:04 -0700 (Mon, 10 Aug 2015) | 2 lines

Re: [PATCH] D12037: WindowsX86: long double is x87DoubleExtended on mingw-w64

hans added a comment. I'm OK with it if Richard gives owner's approval. Cheers, Hans http://reviews.llvm.org/D12037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r243133 - Correct x86_64 Android fp128 mangled name

(+ the new cfe-commits list; sorry for the spam) On Fri, Aug 14, 2015 at 1:25 PM, Hans Wennborg h...@chromium.org wrote: Reid and Nico suggested this should be merged to 3.7 together with r244468 as it fixes an issue with libc++ when compiled with Clang on x86_64 Android. John, you're the

Re: [PATCH] D12037: WindowsX86: long double is x87DoubleExtended on mingw-w64

I'm OK with it if Richard gives owner's approval. Cheers, Hans On Fri, Aug 14, 2015 at 12:25 PM, Martell Malone martellmal...@gmail.com wrote: martell added a comment. Hans this is something we most definitely should have in 3.7 It's a pretty big bugfix for this target :)

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

I'm OK with it if Richard gives owner's approval. Cheers, Hans On Thu, Aug 13, 2015 at 8:27 PM, Martell Malone martellmal...@gmail.com wrote: Hi Hans, Is this bugfix something that can be merged into 3.7 ? Kind Regards Martell On Thu, Aug 13, 2015 at 4:42 PM, Martell Malone

Re: r244193 - [ObjC] Circular containers: add support of subclasses

Thanks! r245116. On Fri, Aug 14, 2015 at 3:30 PM, Richard Smith rich...@metafoo.co.uk wrote: Sorry for the delay, this LGTM for branch. On Wed, Aug 12, 2015 at 1:09 AM, AlexDenisov 1101.deb...@gmail.com wrote: Ping -- AlexDenisov Software Engineer, http://lowlevelbits.org On 06 Aug

Re: r243133 - Correct x86_64 Android fp128 mangled name

On Fri, Aug 14, 2015 at 1:55 PM, John McCall rjmcc...@apple.com wrote: On Aug 14, 2015, at 1:25 PM, Hans Wennborg h...@chromium.org wrote: Reid and Nico suggested this should be merged to 3.7 together with r244468 as it fixes an issue with libc++ when compiled with Clang on x86_64 Android.

Re: [PATCH] D11850: Delay emitting members of dllexport classes until the class is fully parsed (PR23542)

This revision was automatically updated to reflect the committed changes. Closed by commit rL245139: Delay emitting members of dllexport classes until the class is fully parsed… (authored by hans). Changed prior to commit: http://reviews.llvm.org/D11850?vs=32201id=32207#toc Repository: rL

r245139 - Delay emitting members of dllexport classes until the class is fully parsed (PR23542)

Author: hans Date: Fri Aug 14 20:18:16 2015 New Revision: 245139 URL: http://llvm.org/viewvc/llvm-project?rev=245139view=rev Log: Delay emitting members of dllexport classes until the class is fully parsed (PR23542) This enables Clang to correctly handle code such as: struct

Re: r243133 - Correct x86_64 Android fp128 mangled name

On Fri, Aug 14, 2015 at 2:02 PM, Hans Wennborg h...@chromium.org wrote: On Fri, Aug 14, 2015 at 1:55 PM, John McCall rjmcc...@apple.com wrote: On Aug 14, 2015, at 1:25 PM, Hans Wennborg h...@chromium.org wrote: Reid and Nico suggested this should be merged to 3.7 together with r244468 as it

Re: r245041 - [OPENMP] Fix for http://llvm.org/PR24371: Assert failure compiling blender 2.75.

On Fri, Aug 14, 2015 at 5:25 AM, Alexey Bataev via cfe-commits cfe-commits@lists.llvm.org wrote: Author: abataev Date: Fri Aug 14 07:25:37 2015 New Revision: 245041 URL: http://llvm.org/viewvc/llvm-project?rev=245041view=rev Log: [OPENMP] Fix for http://llvm.org/PR24371: Assert failure

r244761 - ReleaseNotes: Small version nbr fix

Author: hans Date: Wed Aug 12 11:40:42 2015 New Revision: 244761 URL: http://llvm.org/viewvc/llvm-project?rev=244761view=rev Log: ReleaseNotes: Small version nbr fix Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

r244797 - Docs: keep copyright years up-to-date

Author: hans Date: Wed Aug 12 14:45:01 2015 New Revision: 244797 URL: http://llvm.org/viewvc/llvm-project?rev=244797view=rev Log: Docs: keep copyright years up-to-date Modified: cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/conf.py URL:

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

hans added a comment. The release script change looks good to me. Better than good actually; it's a great improvement :-) http://reviews.llvm.org/D13802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13759: [Clang] Fix Clang-tidy modernize-use-auto warnings in headers and generated files; other minor cleanups.

hans added a comment. Some of these are great improvements, especially using auto for iterators etc. But I'm not sure we'll want to start changing "Foo *foo = new Foo;" to use auto everywhere. I expect we'd have to do that in a huge number of places? Comment at:

[PATCH] D14748: bmiintrin.h: Allow using the tzcnt intrinsics for non-BMI targets

hans created this revision. hans added reviewers: thakis, echristo. hans added a subscriber: cfe-commits. The tzcnt intrinsics are used non non-BMI targets by code (e.g. ffmpeg) that uses it as a potentially faster BSF. The TZCNT instruction is special in that it's encoded in a

r253358 - bmiintrin.h: Allow using the tzcnt intrinsics for non-BMI targets

Author: hans Date: Tue Nov 17 12:46:48 2015 New Revision: 253358 URL: http://llvm.org/viewvc/llvm-project?rev=253358=rev Log: bmiintrin.h: Allow using the tzcnt intrinsics for non-BMI targets The tzcnt intrinsics are used non non-BMI targets by code (e.g. ffmpeg) that uses it as a potentially

Re: [PATCH] D14311: [Clang] Fix some Clang-tidy modernize warnings, other minor fixes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D14311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r252056 - clang-cl: Parse the /guard:cf[-] flag (PR25400)

Author: hans Date: Wed Nov 4 10:11:56 2015 New Revision: 252056 URL: http://llvm.org/viewvc/llvm-project?rev=252056=rev Log: clang-cl: Parse the /guard:cf[-] flag (PR25400) Modified: cfe/trunk/include/clang/Driver/CLCompatOptions.td cfe/trunk/test/Driver/cl-options.c Modified:

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

hans added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:86 @@ -69,1 +85,3 @@ +IComponentModel componentModel = GetService(typeof(SComponentModel)) as IComponentModel; +editorAdaptersFactoryService =

r250301 - Intrin.h: implement __emul and __emulu

Author: hans Date: Wed Oct 14 11:24:28 2015 New Revision: 250301 URL: http://llvm.org/viewvc/llvm-project?rev=250301=rev Log: Intrin.h: implement __emul and __emulu Modified: cfe/trunk/lib/Headers/Intrin.h Modified: cfe/trunk/lib/Headers/Intrin.h URL:

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

hans added a comment. This is now part of the latest snapshot at http://llvm.org/builds/ Seems to work :-) I had to dig around a bit to figure out where these settings are actually exposed. Should we mention that in the documentation somewhere? Actually, do we even have any documentation for

r249775 - Expose -f[no]ms-{compatibility, extensions} in clang-cl (PR25114)

Author: hans Date: Thu Oct 8 18:13:28 2015 New Revision: 249775 URL: http://llvm.org/viewvc/llvm-project?rev=249775=rev Log: Expose -f[no]ms-{compatibility,extensions} in clang-cl (PR25114) These are enabled by default in clang-cl, because the whole idea is that it should work like cl.exe, but

Re: r248949 - Don't inherit availability information when implementing a protocol requirement.

On Fri, Oct 9, 2015 at 9:10 PM, Douglas Gregor wrote: > > > Sent from my iPhone > >> On Oct 9, 2015, at 2:17 PM, Hans Wennborg wrote: >> >>> On Fri, Oct 9, 2015 at 1:46 PM, Douglas Gregor wrote: >>> On Oct 7, 2015, at 11:55 AM, Hans

r250099 - Parse and ignore #pragma runtime_checks in MS extensions mode (PR25138)

Author: hans Date: Mon Oct 12 15:47:58 2015 New Revision: 250099 URL: http://llvm.org/viewvc/llvm-project?rev=250099=rev Log: Parse and ignore #pragma runtime_checks in MS extensions mode (PR25138) We already silently ignore the /RTC, which controls the same functionality. Modified:

Re: r248949 - Don't inherit availability information when implementing a protocol requirement.

Hi Doug, On Wed, Sep 30, 2015 at 2:27 PM, Douglas Gregor via cfe-commits wrote: > Author: dgregor > Date: Wed Sep 30 16:27:42 2015 > New Revision: 248949 > > URL: http://llvm.org/viewvc/llvm-project?rev=248949=rev > Log: > Don't inherit availability information when

r249484 - Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups

Author: hans Date: Tue Oct 6 18:40:43 2015 New Revision: 249484 URL: http://llvm.org/viewvc/llvm-project?rev=249484=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups Patch by Eugene Zelenko! Differential Revision: http://reviews.llvm.org/D13406

Re: [PATCH] D13406: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in source directories; other minor cleanups.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Sema/SemaDeclObjC.cpp:510 @@ -509,3 +509,3 @@ -if (PrevDecl && SuperClassDecl == 0) { +if (PrevDecl && (!SuperClassDecl)) { // The previous

Re: r248949 - Don't inherit availability information when implementing a protocol requirement.

On Fri, Oct 9, 2015 at 1:46 PM, Douglas Gregor wrote: > >> On Oct 7, 2015, at 11:55 AM, Hans Wennborg wrote: >> >> Hi Doug, >> >> On Wed, Sep 30, 2015 at 2:27 PM, Douglas Gregor via cfe-commits >> wrote: >>> Author: dgregor >>>

Re: [PATCH] D12368: Add a clang release note about raising the minimum Windows version for the next major release

hans added a comment. Committed in r246090. http://reviews.llvm.org/D12368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12368: Add a clang release note about raising the minimum Windows version for the next major release

This revision was automatically updated to reflect the committed changes. Closed by commit rL246090: Add a clang release note about raising the minimum Windows version for the… (authored by hans). Changed prior to commit: http://reviews.llvm.org/D12368?vs=33208id=33255#toc Repository: rL

[libcxx] r246250 - Creating release candidate final from release_370 branch

Author: hans Date: Thu Aug 27 20:43:57 2015 New Revision: 246250 URL: http://llvm.org/viewvc/llvm-project?rev=246250view=rev Log: Creating release candidate final from release_370 branch Added: libcxx/tags/RELEASE_370/final/ (props changed) - copied from r246249,

[libcxxabi] r246251 - Creating release candidate final from release_370 branch

Author: hans Date: Thu Aug 27 20:44:00 2015 New Revision: 246251 URL: http://llvm.org/viewvc/llvm-project?rev=246251view=rev Log: Creating release candidate final from release_370 branch Added: libcxxabi/tags/RELEASE_370/final/ (props changed) - copied from r246250,

[libunwind] r246257 - Creating release candidate final from release_370 branch

Author: hans Date: Thu Aug 27 20:44:18 2015 New Revision: 246257 URL: http://llvm.org/viewvc/llvm-project?rev=246257view=rev Log: Creating release candidate final from release_370 branch Added: libunwind/tags/RELEASE_370/final/ (props changed) - copied from r246256,

[PATCH] D12422: Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593)

hans created this revision. hans added a reviewer: majnemer. hans added a subscriber: cfe-commits. This seems to match the MS behaviour. http://reviews.llvm.org/D12422 Files: lib/CodeGen/CodeGenModule.cpp lib/Sema/SemaDecl.cpp test/CodeGenCXX/dllimport.cpp test/SemaCXX/dllexport.cpp

[libcxx] r246113 - Creating release candidate rc4 from release_370 branch

Author: hans Date: Wed Aug 26 18:34:53 2015 New Revision: 246113 URL: http://llvm.org/viewvc/llvm-project?rev=246113view=rev Log: Creating release candidate rc4 from release_370 branch Added: libcxx/tags/RELEASE_370/rc4/ (props changed) - copied from r246112,

[libcxxabi] r246114 - Creating release candidate rc4 from release_370 branch

Author: hans Date: Wed Aug 26 18:34:56 2015 New Revision: 246114 URL: http://llvm.org/viewvc/llvm-project?rev=246114view=rev Log: Creating release candidate rc4 from release_370 branch Added: libcxxabi/tags/RELEASE_370/rc4/ (props changed) - copied from r246113,

[libunwind] r246120 - Creating release candidate rc4 from release_370 branch

Author: hans Date: Wed Aug 26 18:35:14 2015 New Revision: 246120 URL: http://llvm.org/viewvc/llvm-project?rev=246120view=rev Log: Creating release candidate rc4 from release_370 branch Added: libunwind/tags/RELEASE_370/rc4/ (props changed) - copied from r246119,

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

hans added a comment. I also don't know anything about how this plugin works, I just build it :) I'm hoping Manuel can take a look. http://reviews.llvm.org/D12407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r246492 - Fix CHECK directives that weren't checking.

Author: hans Date: Mon Aug 31 16:48:52 2015 New Revision: 246492 URL: http://llvm.org/viewvc/llvm-project?rev=246492=rev Log: Fix CHECK directives that weren't checking. Modified: cfe/trunk/test/CodeGen/builtin-cpu-supports.c cfe/trunk/test/CodeGen/builtins-ppc-crypto.c

Re: r246468 - Pull the target attribute parsing out of CGCall and onto TargetInfo.

This change makes Basic depend on AST. The immediate problem I'm hitting is clang-format (which uses Basic but not AST) failing to link on Windows [1], but I suspect this could cause problems elsewhere too. Is there some way to avoid this dependency? [1].

r246864 - Don't allow dllexport/import on static local variables

Author: hans Date: Fri Sep 4 14:59:39 2015 New Revision: 246864 URL: http://llvm.org/viewvc/llvm-project?rev=246864=rev Log: Don't allow dllexport/import on static local variables They might technically have external linkage, but it still doesn't make sense for the user to try and export such

Re: r245036 - Add structed way to express command line options in the compilation database.

On Fri, Aug 14, 2015 at 2:55 AM, Manuel Klimek via cfe-commits wrote: > Author: klimek > Date: Fri Aug 14 04:55:36 2015 > New Revision: 245036 > > URL: http://llvm.org/viewvc/llvm-project?rev=245036=rev > Log: > Add structed way to express command line options in the

r247302 - Re-commit r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes"

Author: hans Date: Thu Sep 10 12:07:54 2015 New Revision: 247302 URL: http://llvm.org/viewvc/llvm-project?rev=247302=rev Log: Re-commit r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes" This never broke the build; it was the LLVM side, r247216, that caused problems.

r247218 - Fix Clang-tidy misc-use-override warnings, other minor fixes

Author: hans Date: Wed Sep 9 19:24:40 2015 New Revision: 247218 URL: http://llvm.org/viewvc/llvm-project?rev=247218=rev Log: Fix Clang-tidy misc-use-override warnings, other minor fixes Patch by Eugene Zelenko! Differential Revision: http://reviews.llvm.org/D12741 Modified:

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL247218: Fix Clang-tidy misc-use-override warnings, other minor fixes (authored by hans). Changed prior to commit: http://reviews.llvm.org/D12741?vs=34385=34393#toc Repository: rL LLVM

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D12741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r247346 - [MS ABI] Make member pointers return true for isIncompleteType

This made the Chromium build sad. For example: http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/3092/steps/compile/logs/stdio Reduction: $ clang -cc1 -triple i686-pc-windows-msvc18.0.0 -w -fms-extensions -fms-compatibility -fms-compatibility-version=18.0 -std=c++11

Re: [PATCH] D12422: Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593)

hans added a comment. In http://reviews.llvm.org/D12422#235509, @majnemer wrote: > We should probably do something about lambdas, they can't be imported or > exported but this can be done in a follow up patch. Follow-up in r247718. Repository: rL LLVM http://reviews.llvm.org/D12422

r247718 - MS ABI: Don't allow dllexport/import on lambdas

Author: hans Date: Tue Sep 15 16:05:30 2015 New Revision: 247718 URL: http://llvm.org/viewvc/llvm-project?rev=247718=rev Log: MS ABI: Don't allow dllexport/import on lambdas This is to follow up on David's comment in http://reviews.llvm.org/D12422#235509 Modified:

Re: [PATCH] D12741: [Clang] Fix Clang-tidy misc-use-override warnings, other minor fixes

hans added a comment. In http://reviews.llvm.org/D12741#242907, @hans wrote: > It seems this broke the build for some reason. I have reverted it in r247222. > > Example build breakages: > http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly-fast/builds/11687/steps/compile/logs/stdio, >

r247222 - Revert r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes"

Author: hans Date: Wed Sep 9 19:37:18 2015 New Revision: 247222 URL: http://llvm.org/viewvc/llvm-project?rev=247222=rev Log: Revert r247218: "Fix Clang-tidy misc-use-override warnings, other minor fixes" Seems it broke the Polly build. From

r248828 - Fix Clang-tidy modernize-use-nullptr warnings in headers and generated files; other minor cleanups.

Author: hans Date: Tue Sep 29 15:56:43 2015 New Revision: 248828 URL: http://llvm.org/viewvc/llvm-project?rev=248828=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in headers and generated files; other minor cleanups. By Eugene Zelenko! Differential Revision:

Re: [PATCH] D13187: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in headers and generated files; other minor cleanups.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D13187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13187: [Clang] Fix Clang-tidy modernize-use-nullptr warnings in headers and generated files; other minor cleanups.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248828: Fix Clang-tidy modernize-use-nullptr warnings in headers and generated files… (authored by hans). Changed prior to commit: http://reviews.llvm.org/D13187?vs=35789=36034#toc Repository: rL

r248221 - Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE

Author: hans Date: Mon Sep 21 17:44:57 2015 New Revision: 248221 URL: http://llvm.org/viewvc/llvm-project?rev=248221=rev Log: Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE This got lost in r248043 which refactored the symlink creation. Modified: cfe/trunk/tools/driver/CMakeLists.txt

Re: r248221 - Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE

ny reason to generate clang-cl if you’re not on > Windows? > > It may make sense to move clang-cl under the if(WIN32). > > -Chris > >> On Sep 21, 2015, at 3:44 PM, Hans Wennborg via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >> >> Author: hans

r248005 - clang-cl: Use 'pc' for the vendor field in the default triple

Author: hans Date: Fri Sep 18 12:11:50 2015 New Revision: 248005 URL: http://llvm.org/viewvc/llvm-project?rev=248005=rev Log: clang-cl: Use 'pc' for the vendor field in the default triple Leaving it unset can make the triple look confusing, especially when using -m32 or -m64. Modified:

r246348 - Follow-up to r246338: use getParentFunctionOrMethod

Author: hans Date: Fri Aug 28 17:56:21 2015 New Revision: 246348 URL: http://llvm.org/viewvc/llvm-project?rev=246348view=rev Log: Follow-up to r246338: use getParentFunctionOrMethod Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.cpp URL:

r246338 - Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593)

Author: hans Date: Fri Aug 28 16:47:01 2015 New Revision: 246338 URL: http://llvm.org/viewvc/llvm-project?rev=246338view=rev Log: Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593) This patch does two things: 1) Don't error about dllimport/export

Re: [PATCH] D12422: Allow TLS vars in dllimport/export functions; only inline dllimport functions when safe (PR24593)

This revision was automatically updated to reflect the committed changes. Closed by commit rL246338: Allow TLS vars in dllimport/export functions; only inline dllimport functions… (authored by hans). Changed prior to commit: http://reviews.llvm.org/D12422?vs=33388id=33471#toc Repository: rL

r255029 - Update clang-format-vs README

Author: hans Date: Tue Dec 8 11:54:27 2015 New Revision: 255029 URL: http://llvm.org/viewvc/llvm-project?rev=255029=rev Log: Update clang-format-vs README VS2013 is requried after r231084. Modified: cfe/trunk/tools/clang-format-vs/README.txt Modified:

Re: [PATCH] D15350: [clang-cl] Let /W4 map to -Wall -Wextra instead of just -Wall.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. > There's no way to make a flag alias to two flags Well, at least not with the alias mechanism in the option parser, but David pointed out we could expand it manually in

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

hans added a comment. Alexey & Chandler: Is there any ongoing communication here? It would be great if we could resolve this, or at least figure out what the status is, before we branch for 3.8 in a month or so. http://reviews.llvm.org/D13802 ___

Re: [PATCH] D15251: [Clang] Use range loops and autos in lib/Serialization/ASTReader.cpp

hans added inline comments. Comment at: lib/Serialization/ASTReader.cpp:3390 @@ -3393,5 +3389,3 @@ Mod->getExportedModules(Exports); -for (SmallVectorImpl::iterator - I = Exports.begin(), E = Exports.end(); I != E; ++I) { - Module *Exported = *I; +for

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Mon, Dec 7, 2015 at 2:14 PM, David Majnemer wrote: > > > On Mon, Dec 7, 2015 at 4:32 PM, Richard Smith via cfe-commits > wrote: >> >> On Mon, Dec 7, 2015 at 7:25 AM, Joerg Sonnenberger via cfe-commits >> wrote:

Re: [PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

hans added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:2005 @@ -1998,3 +2004,3 @@ /* IsAlignStack */ false, AsmDialect); llvm::CallInst *Result = Builder.CreateCall(IA, Args); Result->addAttribute(llvm::AttributeSet::FunctionIndex,

r255201 - Mark MS inline ASM 'nodplicate' it it has labels (PR23715)

Author: hans Date: Wed Dec 9 19:38:04 2015 New Revision: 255201 URL: http://llvm.org/viewvc/llvm-project?rev=255201=rev Log: Mark MS inline ASM 'nodplicate' it it has labels (PR23715) Duplicating it can lead to labels being defined twice. Differential revision: http://reviews.llvm.org/D15399

Re: [PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

This revision was automatically updated to reflect the committed changes. Closed by commit rL255201: Mark MS inline ASM 'nodplicate' it it has labels (PR23715) (authored by hans). Changed prior to commit: http://reviews.llvm.org/D15399?vs=42353=42365#toc Repository: rL LLVM

[PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

hans created this revision. hans added a reviewer: rnk. hans added a subscriber: cfe-commits. This avoids defining the same label twice if the function gets inlined. It's pretty hacky, but also very non-intrusive. (I also played with adding a flag on the MSAsmStmt and set that in

Re: r255524 - clang-cl: make /Wall turn on both -Wall and -Wextra (PR25563)

On Mon, Dec 14, 2015 at 3:47 PM, David Blaikie via cfe-commits <cfe-commits@lists.llvm.org> wrote: > On Tue, Dec 15, 2015 at 5:46 AM, Hans Wennborg via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: hans >> Date: Mon Dec 14 12:46:11 2015 >

r255524 - clang-cl: make /Wall turn on both -Wall and -Wextra (PR25563)

Author: hans Date: Mon Dec 14 12:46:11 2015 New Revision: 255524 URL: http://llvm.org/viewvc/llvm-project?rev=255524=rev Log: clang-cl: make /Wall turn on both -Wall and -Wextra (PR25563) The documentation suggests /Wall should really turn on -Wextra and any other warnings that are not enabled

r257516 - Don't store CGOpenMPRegionInfo::CodeGen as a reference (PR26078)

Author: hans Date: Tue Jan 12 14:54:36 2016 New Revision: 257516 URL: http://llvm.org/viewvc/llvm-project?rev=257516=rev Log: Don't store CGOpenMPRegionInfo::CodeGen as a reference (PR26078) The referenced llvm::function_ref object can go away before CodeGen is used,

r257537 - clang-cl: Support /Dfoo#bar (PR25984)

Author: hans Date: Tue Jan 12 17:17:03 2016 New Revision: 257537 URL: http://llvm.org/viewvc/llvm-project?rev=257537=rev Log: clang-cl: Support /Dfoo#bar (PR25984) Such flags will now be translated to -Dfoo=bar. Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp

r271688 - Obj-C: Fix assert-on-invalid (PR27822)

Author: hans Date: Fri Jun 3 11:59:13 2016 New Revision: 271688 URL: http://llvm.org/viewvc/llvm-project?rev=271688=rev Log: Obj-C: Fix assert-on-invalid (PR27822) Clang would assert when isObjCInstancetype() was called on a tok::annot_cxxscope token. Modified:

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 60054. hans marked 2 inline comments as done. hans added a comment. Addressing Saleem's comments, and renaming the flag to -fcase-insensitive-paths, since this doesn't apply just to includes, but anything that goes through vfs, including the main source

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In http://reviews.llvm.org/D21113#452431, @thakis wrote: > For performance: Can you check how build times for some large target in > Chromium on Linux targeting Windows compares with this vs having the sdk in a > fat mount? That would give us some data. I measured

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In http://reviews.llvm.org/D21113#452558, @thakis wrote: > Can you try building a few more files? Say, v8_base? Well, that was depressing: Putting the sdk on a vfat fs: real2m26.077s user68m31.476s sys 1m25.702s Using the flag: real9m5.179s

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

On Wed, Jun 8, 2016 at 10:20 AM, Nico Weber wrote: > It looks like we're starting to be more careful about header case. MSVC's > intrin.h is called intrin.h with a lower-case 'i'; ours starts with an > upper-case 'I' for no good reason. > > It looks like file-only renames

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In http://reviews.llvm.org/D21113#452673, @thakis wrote: > Not sure if we want a flag that adds 50% overhead, no matter how convenient > it might be :-/ I now have a version of the patch that caches directory contents that it lists: real2m31.461s user

[PATCH] D21113: Add support for case-insensitive header lookup

hans created this revision. hans added reviewers: rsmith, rnk, thakis. hans added subscribers: compnerd, majnemer, benlangmuir, cfe-commits. This is useful when dealing with headers that are normally used on case-insensitive filesystems, such as the Windows SDK, when cross-compiling from a

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 59982. hans added a comment. Add --show-includes test. http://reviews.llvm.org/D21113 Files: include/clang/Basic/VirtualFileSystem.h include/clang/Driver/Options.td include/clang/Lex/HeaderSearchOptions.h lib/Basic/VirtualFileSystem.cpp

Re: [PATCH] D21113: Add support for case-insensitive header lookup

On Thu, Jun 9, 2016 at 5:31 PM, Joerg Sonnenberger via cfe-commits <cfe-commits@lists.llvm.org> wrote: > On Wed, Jun 08, 2016 at 01:12:31AM +0000, Hans Wennborg via cfe-commits wrote: >> There has been a patch for this before (http://reviews.llvm.org/D2972), >> but thi

  1   2   3   4   5   6   7   8   9   10   >