[clang-tools-extra] r317552 - Add new check in google module for Objective-C code to ensure global variables follow the naming convention of Google Objective-C Style Guide

2017-11-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Nov 7 00:53:37 2017 New Revision: 317552 URL: http://llvm.org/viewvc/llvm-project?rev=317552=rev Log: Add new check in google module for Objective-C code to ensure global variables follow the naming convention of Google Objective-C Style Guide Summary: This is a new

[clang-tools-extra] r317559 - [clangd] Add ErrorCode enum class.

2017-11-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Nov 7 02:21:02 2017 New Revision: 317559 URL: http://llvm.org/viewvc/llvm-project?rev=317559=rev Log: [clangd] Add ErrorCode enum class. Summary: Avoid using magic number in the code everywhere. Reviewers: sammccall Reviewed By: sammccall Subscribers: ilya-biryukov,

r317672 - [clang-refactor] Introduce a new rename rule for qualified symbols

2017-11-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Nov 8 00:56:56 2017 New Revision: 317672 URL: http://llvm.org/viewvc/llvm-project?rev=317672=rev Log: [clang-refactor] Introduce a new rename rule for qualified symbols Summary: Prototype of a new rename rule for renaming qualified symbol. Reviewers: arphaman, ioeric,

[clang-tools-extra] r317780 - [clangd] Add rename support.

2017-11-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Nov 9 03:30:04 2017 New Revision: 317780 URL: http://llvm.org/viewvc/llvm-project?rev=317780=rev Log: [clangd] Add rename support. Summary: Make clangd handle "textDocument/rename" request. The rename functionality comes from the "local-rename" sub-tool of

r317696 - [clang-refactor] Get rid of OccurrencesFinder in RenamingAction, NFC

2017-11-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Nov 8 06:53:08 2017 New Revision: 317696 URL: http://llvm.org/viewvc/llvm-project?rev=317696=rev Log: [clang-refactor] Get rid of OccurrencesFinder in RenamingAction, NFC Summary: The OccurrencesFinder is only used in RenameOccurrences to find symbol occurrences, there

[clang-tools-extra] r320486 - [clangd] Introduce a "Symbol" class.

2017-12-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Dec 12 07:42:10 2017 New Revision: 320486 URL: http://llvm.org/viewvc/llvm-project?rev=320486=rev Log: [clangd] Introduce a "Symbol" class. Summary: * The "Symbol" class represents a C++ symbol in the codebase, containing all the information of a C++ symbol needed by

r316895 - [refactor] Fix a clang-tidy warning.

2017-10-30 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 30 04:17:09 2017 New Revision: 316895 URL: http://llvm.org/viewvc/llvm-project?rev=316895=rev Log: [refactor] Fix a clang-tidy warning. NFC Modified: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp Modified:

r316571 - [rename] support renaming class member.

2017-10-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 25 04:54:45 2017 New Revision: 316571 URL: http://llvm.org/viewvc/llvm-project?rev=316571=rev Log: [rename] support renaming class member. Reviewers: ioeric Reviewed By: ioeric Subscribers: klimek, cfe-commits, mgorny Differential Revision:

[clang-tools-extra] r316643 - [clang-tidy ObjC] [1/3] New module `objc` for Objective-C checks

2017-10-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Oct 26 01:23:20 2017 New Revision: 316643 URL: http://llvm.org/viewvc/llvm-project?rev=316643=rev Log: [clang-tidy ObjC] [1/3] New module `objc` for Objective-C checks Summary: This is part 1 of 3 of a series of changes to improve Objective-C linting in clang-tidy. This

[clang-tools-extra] r316645 - [clang-tidy ObjC] [2/3] Support non-C++ files in ClangTidyTest

2017-10-26 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Oct 26 01:37:25 2017 New Revision: 316645 URL: http://llvm.org/viewvc/llvm-project?rev=316645=rev Log: [clang-tidy ObjC] [2/3] Support non-C++ files in ClangTidyTest Summary: This is part 2 of 3 of a series of changes to improve Objective-C linting in clang-tidy.

r316561 - [clang-rename] Fix and enable the failing TemplatedClassFunction test.

2017-10-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 25 01:25:25 2017 New Revision: 316561 URL: http://llvm.org/viewvc/llvm-project?rev=316561=rev Log: [clang-rename] Fix and enable the failing TemplatedClassFunction test. Reviewers: ioeric Reviewed By: ioeric Subscribers: klimek, cfe-commits Differential Revision:

[clang-tools-extra] r321252 - [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension.

2017-12-21 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Dec 21 00:45:18 2017 New Revision: 321252 URL: http://llvm.org/viewvc/llvm-project?rev=321252=rev Log: [clangd] Use the clang-tools-extra as the official repo for `vscode-clangd` extension. Summary: Previously, we use a separate GitHub repository

[clang-tools-extra] r334270 - [clang-tidy] Improve string type matcher for abseil-string-find-starts-with check.

2018-06-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jun 8 01:19:22 2018 New Revision: 334270 URL: http://llvm.org/viewvc/llvm-project?rev=334270=rev Log: [clang-tidy] Improve string type matcher for abseil-string-find-starts-with check. Summary: This patch improves the check to match the desugared "string" type (so that

[clang-tools-extra] r334812 - [clangd] Fix buildbot error.

2018-06-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jun 15 02:32:36 2018 New Revision: 334812 URL: http://llvm.org/viewvc/llvm-project?rev=334812=rev Log: [clangd] Fix buildbot error. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp URL:

[clang-tools-extra] r333882 - [clangd] Remove the dead offset fields in Symbol.

2018-06-04 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Jun 4 03:43:59 2018 New Revision: 333882 URL: http://llvm.org/viewvc/llvm-project?rev=333882=rev Log: [clangd] Remove the dead offset fields in Symbol. Reviewers: sammccall Subscribers: klimek, ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits Differential

[clang-tools-extra] r334176 - [clangd] Fix using the incorrect Index for go-to-definition.

2018-06-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jun 7 01:49:55 2018 New Revision: 334176 URL: http://llvm.org/viewvc/llvm-project?rev=334176=rev Log: [clangd] Fix using the incorrect Index for go-to-definition. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits Differential

[clang-tools-extra] r331189 - [clangd] Using index for GoToDefinition.

2018-04-30 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Apr 30 08:24:17 2018 New Revision: 331189 URL: http://llvm.org/viewvc/llvm-project?rev=331189=rev Log: [clangd] Using index for GoToDefinition. Summary: This patch adds index support for GoToDefinition -- when we don't get the definition from local AST, we query our

[clang-tools-extra] r331168 - [clangd] Also use UTF-16 in index position.

2018-04-30 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Apr 30 04:40:02 2018 New Revision: 331168 URL: http://llvm.org/viewvc/llvm-project?rev=331168=rev Log: [clangd] Also use UTF-16 in index position. Reviewers: sammccall Subscribers: klimek, ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits Differential Revision:

[clang-tools-extra] r316744 - [clang-tidy ObjC] [3/3] New check objc-forbidden-subclassing

2017-10-27 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 27 00:41:36 2017 New Revision: 316744 URL: http://llvm.org/viewvc/llvm-project?rev=316744=rev Log: [clang-tidy ObjC] [3/3] New check objc-forbidden-subclassing Summary: This is part 3 of 3 of a series of changes to improve Objective-C linting in clang-tidy. This

[clang-tools-extra] r316221 - [clang-tidy] Add missing test files in r316090.

2017-10-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 20 10:54:53 2017 New Revision: 316221 URL: http://llvm.org/viewvc/llvm-project?rev=316221=rev Log: [clang-tidy] Add missing test files in r316090. Added: clang-tools-extra/trunk/test/clang-tidy/objc-arc-and-properties.m

[clang-tools-extra] r322191 - [clangd] Add static index for the global code completion.

2018-01-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jan 10 06:44:34 2018 New Revision: 322191 URL: http://llvm.org/viewvc/llvm-project?rev=322191=rev Log: [clangd] Add static index for the global code completion. Summary: Use the YAML-format symbols (generated by the global-symbol-builder tool) to do the global code

[clang-tools-extra] r322067 - [clangd] Catch more symbols in SymbolCollector.

2018-01-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 9 02:44:09 2018 New Revision: 322067 URL: http://llvm.org/viewvc/llvm-project?rev=322067=rev Log: [clangd] Catch more symbols in SymbolCollector. Summary: We currently only collect external-linkage symbols in the collector, which results in missing some typical

r322661 - [Sema] Add visited contexts to CodeCompleteContext

2018-01-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jan 17 06:29:25 2018 New Revision: 322661 URL: http://llvm.org/viewvc/llvm-project?rev=322661=rev Log: [Sema] Add visited contexts to CodeCompleteContext Summary: This would allow code completion clients to know which context is visited during Sema code completion.

[clang-tools-extra] r322929 - [clangd] Collect enum constants in SymbolCollector

2018-01-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jan 19 01:35:55 2018 New Revision: 322929 URL: http://llvm.org/viewvc/llvm-project?rev=322929=rev Log: [clangd] Collect enum constants in SymbolCollector Summary: * ignore nameless symbols * include enum constant declarataion Reviewers: ilya-biryukov, jkorous-apple

[clang-tools-extra] r323191 - [clang-tidy] Don't generate fixes for invalid new expr location in modernize-make-unique.

2018-01-23 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 23 03:43:18 2018 New Revision: 323191 URL: http://llvm.org/viewvc/llvm-project?rev=323191=rev Log: [clang-tidy] Don't generate fixes for invalid new expr location in modernize-make-unique. Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: klimek,

[clang-tools-extra] r323189 - [clangd] Use accessible scopes to query indexes for global code completion.

2018-01-23 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Jan 23 03:37:26 2018 New Revision: 323189 URL: http://llvm.org/viewvc/llvm-project?rev=323189=rev Log: [clangd] Use accessible scopes to query indexes for global code completion. Summary: * For qualified completion (foo::a^) * unresolved qualifier - use global

[clang-tools-extra] r322822 - [clang-tidy] Don't generate fix for argument constructed from std::initializer_list.

2018-01-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jan 18 00:58:18 2018 New Revision: 322822 URL: http://llvm.org/viewvc/llvm-project?rev=322822=rev Log: [clang-tidy] Don't generate fix for argument constructed from std::initializer_list. Summary: A follow-up fix of rL311652. The previous `vector` in our test is

r322826 - [ASTMatcher] Add isScoped matcher for enumDecl.

2018-01-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jan 18 01:47:57 2018 New Revision: 322826 URL: http://llvm.org/viewvc/llvm-project?rev=322826=rev Log: [ASTMatcher] Add isScoped matcher for enumDecl. Summary: Reviewers: bkramer, aaron.ballman Subscribers: aaron.ballman, cfe-commits, klimek Differential Revision:

[clang-tools-extra] r323410 - [clangd] Disable typo correction when doing code completion.

2018-01-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jan 25 01:44:06 2018 New Revision: 323410 URL: http://llvm.org/viewvc/llvm-project?rev=323410=rev Log: [clangd] Disable typo correction when doing code completion. Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: klimek, jkorous-apple, cfe-commits,

[clang-tools-extra] r323408 - [clangd] Limit completion results.

2018-01-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Jan 25 01:20:09 2018 New Revision: 323408 URL: http://llvm.org/viewvc/llvm-project?rev=323408=rev Log: [clangd] Limit completion results. Summary: * truncate symbols from static/dynamic index to the limited number (which would save lots of cost in constructing the merged

[clang-tools-extra] r322370 - [clangd] Don't navigate to forward class declaration when go to definition.

2018-01-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Jan 12 06:21:10 2018 New Revision: 322370 URL: http://llvm.org/viewvc/llvm-project?rev=322370=rev Log: [clangd] Don't navigate to forward class declaration when go to definition. Summary: For some cases, GoToDefinition will navigate to the forward class declaration, we

[clang-tools-extra] r323865 - [clang-move] Clever on handling header file which includes itself.

2018-01-31 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jan 31 04:12:29 2018 New Revision: 323865 URL: http://llvm.org/viewvc/llvm-project?rev=323865=rev Log: [clang-move] Clever on handling header file which includes itself. Summary: Previously, we assume only old.cc includes "old.h", which would introduce incorrect fixes

[clang-tools-extra] r323867 - [clangd] Better handling symbols defined in macros.

2018-01-31 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Jan 31 04:56:51 2018 New Revision: 323867 URL: http://llvm.org/viewvc/llvm-project?rev=323867=rev Log: [clangd] Better handling symbols defined in macros. Summary: For symbols defined inside macros: * use expansion location, if the symbol is formed via macro

[clang-tools-extra] r323960 - [clangd] remove the unused code NFC.

2018-02-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Feb 1 05:06:58 2018 New Revision: 323960 URL: http://llvm.org/viewvc/llvm-project?rev=323960=rev Log: [clangd] remove the unused code NFC. Modified: clang-tools-extra/trunk/unittests/clangd/SymbolCollectorTests.cpp Modified:

[clang-tools-extra] r324220 - [clangd] Expclictly set the init value of -assume-header-dir option, NFC.

2018-02-05 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 5 02:14:16 2018 New Revision: 324220 URL: http://llvm.org/viewvc/llvm-project?rev=324220=rev Log: [clangd] Expclictly set the init value of -assume-header-dir option, NFC. Modified:

[clang-tools-extra] r324233 - [clang-tidy] tweak "misc-definitions-in-headers" doc, NFC.

2018-02-05 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 5 05:04:41 2018 New Revision: 324233 URL: http://llvm.org/viewvc/llvm-project?rev=324233=rev Log: [clang-tidy] tweak "misc-definitions-in-headers" doc, NFC. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-definitions-in-headers.rst Modified:

[clang-tools-extra] r324235 - [clang-tidy] Fix incorrect code indention in the doc.

2018-02-05 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 5 05:23:48 2018 New Revision: 324235 URL: http://llvm.org/viewvc/llvm-project?rev=324235=rev Log: [clang-tidy] Fix incorrect code indention in the doc. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/objc-property-declaration.rst Modified:

[clang-tools-extra] r324328 - [clangd] Fix incorrect file path for symbols defined by the compile command-line option.

2018-02-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Feb 6 01:50:35 2018 New Revision: 324328 URL: http://llvm.org/viewvc/llvm-project?rev=324328=rev Log: [clangd] Fix incorrect file path for symbols defined by the compile command-line option. Summary: Reviewers: ioeric Reviewed By: ioeric Subscribers: klimek,

[clang-tools-extra] r324886 - [clang-move] Fix the incorrect expansion end location.

2018-02-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 12 04:26:12 2018 New Revision: 324886 URL: http://llvm.org/viewvc/llvm-project?rev=324886=rev Log: [clang-move] Fix the incorrect expansion end location. Summary: Before the fix, if clang-move decides to move the following macro statement, it only moves the first

[clang-tools-extra] r324742 - [clang-move] Don't dump macro symbols.

2018-02-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Feb 9 07:57:30 2018 New Revision: 324742 URL: http://llvm.org/viewvc/llvm-project?rev=324742=rev Log: [clang-move] Don't dump macro symbols. Reviewers: ioeric Subscribers: klimek, cfe-commits Differential Revision: https://reviews.llvm.org/D43075 Modified:

[clang-tools-extra] r324993 - [clangd] Remove an already-done FIXME, NFC

2018-02-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Feb 13 01:56:45 2018 New Revision: 324993 URL: http://llvm.org/viewvc/llvm-project?rev=324993=rev Log: [clangd] Remove an already-done FIXME, NFC Modified: clang-tools-extra/trunk/clangd/index/Index.h Modified: clang-tools-extra/trunk/clangd/index/Index.h URL:

[clang-tools-extra] r324992 - [clangd] SymbolLocation only covers symbol name.

2018-02-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Feb 13 01:53:50 2018 New Revision: 324992 URL: http://llvm.org/viewvc/llvm-project?rev=324992=rev Log: [clangd] SymbolLocation only covers symbol name. Summary: * Change the offset range to half-open, [start, end). * Fix a few fixmes. Reviewers: sammccall Subscribers:

[clang-tools-extra] r325779 - [clangd] Correct setting ignoreWarnings in CodeCompletion.

2018-02-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Feb 22 05:35:01 2018 New Revision: 325779 URL: http://llvm.org/viewvc/llvm-project?rev=325779=rev Log: [clangd] Correct setting ignoreWarnings in CodeCompletion. Summary: We should set the flag before creating ComplierInstance -- when CopmilerInstance gets initialized,

[clang-tools-extra] r325503 - [clangd] Correct the doc, password => Personal Access Token.

2018-02-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 19 06:26:55 2018 New Revision: 325503 URL: http://llvm.org/viewvc/llvm-project?rev=325503=rev Log: [clangd] Correct the doc, password => Personal Access Token. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/README.md Modified:

[clang-tools-extra] r325484 - [clangd] Bump vs-code clangd extension v0.0.3

2018-02-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 19 02:49:12 2018 New Revision: 325484 URL: http://llvm.org/viewvc/llvm-project?rev=325484=rev Log: [clangd] Bump vs-code clangd extension v0.0.3 Reviewers: sammccall Subscribers: klimek, ilya-biryukov, jkorous-apple, cfe-commits, ioeric Differential Revision:

[clang-tools-extra] r325499 - [clangd] Add brief instructions on how to make a release for vscode-clangd extension.

2018-02-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Feb 19 06:01:52 2018 New Revision: 325499 URL: http://llvm.org/viewvc/llvm-project?rev=325499=rev Log: [clangd] Add brief instructions on how to make a release for vscode-clangd extension. Reviewers: sammccall Subscribers: klimek, ilya-biryukov, jkorous-apple, ioeric,

[clang-tools-extra] r321358 - [clangd] Add a tool to build YAML-format global symbols.

2017-12-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Dec 22 06:38:05 2017 New Revision: 321358 URL: http://llvm.org/viewvc/llvm-project?rev=321358=rev Log: [clangd] Add a tool to build YAML-format global symbols. Summary: The tools is used to generate global symbols for clangd (global code completion), The format is YAML,

[clang-tools-extra] r338517 - [clangd] Make SymbolLocation => bool conversion explicitly.

2018-08-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 1 04:24:50 2018 New Revision: 338517 URL: http://llvm.org/viewvc/llvm-project?rev=338517=rev Log: [clangd] Make SymbolLocation => bool conversion explicitly. Summary: The implicit bool conversion could happen superisingly, e.g. when checking `if (Loc1 == Loc2)`, the

[clang-tools-extra] r338526 - [clangd] Correct the namespace of ParsedAST forward declaration, NFC.

2018-08-01 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 1 05:50:44 2018 New Revision: 338526 URL: http://llvm.org/viewvc/llvm-project?rev=338526=rev Log: [clangd] Correct the namespace of ParsedAST forward declaration, NFC. Modified: clang-tools-extra/trunk/clangd/FindSymbols.h Modified:

[clang-tools-extra] r340001 - [clangd] Always use the latest preamble

2018-08-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 17 01:15:22 2018 New Revision: 340001 URL: http://llvm.org/viewvc/llvm-project?rev=340001=rev Log: [clangd] Always use the latest preamble Summary: Fix an inconsistent behavior of using `LastBuiltPreamble`/`NewPreamble` in TUScheduler (see the test for details), AST

[clang-tools-extra] r339011 - [clangd] Index Interfaces for Xrefs

2018-08-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Aug 6 06:14:32 2018 New Revision: 339011 URL: http://llvm.org/viewvc/llvm-project?rev=339011=rev Log: [clangd] Index Interfaces for Xrefs Summary: This is the first step of implementing Xrefs in clangd: - add index interfaces, and related data structures. Reviewers:

[clang-tools-extra] r339116 - [clangd] Share getSymbolID implementation.

2018-08-07 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Aug 7 01:57:52 2018 New Revision: 339116 URL: http://llvm.org/viewvc/llvm-project?rev=339116=rev Log: [clangd] Share getSymbolID implementation. Summary: And remove all duplicated implementation. Reviewers: ioeric Subscribers: ilya-biryukov, MaskRay, jkorous,

r339558 - Revert "Allow relockable scopes with thread safety attributes."

2018-08-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Aug 13 05:50:30 2018 New Revision: 339558 URL: http://llvm.org/viewvc/llvm-project?rev=339558=rev Log: Revert "Allow relockable scopes with thread safety attributes." This reverts commit r339456. The change introduces a new crash, see class SCOPED_LOCKABLE FileLock {

[clang-tools-extra] r339416 - [clangd] Fix a "-Wdangling-else" compiler warning in the test.

2018-08-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 10 01:34:16 2018 New Revision: 339416 URL: http://llvm.org/viewvc/llvm-project?rev=339416=rev Log: [clangd] Fix a "-Wdangling-else" compiler warning in the test. Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp Modified:

[clang-tools-extra] r339415 - [clang-tidy] Omit cases where loop variable is not used in loop body in

2018-08-10 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 10 01:25:51 2018 New Revision: 339415 URL: http://llvm.org/viewvc/llvm-project?rev=339415=rev Log: [clang-tidy] Omit cases where loop variable is not used in loop body in performance-for-range-copy check. Summary: The upstream change r336737 make the check too smart

[clang-tools-extra] r340038 - [clang-tidy] Abseil: integral division of Duration check

2018-08-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 17 08:19:19 2018 New Revision: 340038 URL: http://llvm.org/viewvc/llvm-project?rev=340038=rev Log: [clang-tidy] Abseil: integral division of Duration check This check is an abseil specific test that tests to ensure users utilize abseil specific floating point

[clang-tools-extra] r340035 - [clangd] Add a testcase for empty preamble.

2018-08-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 17 07:55:57 2018 New Revision: 340035 URL: http://llvm.org/viewvc/llvm-project?rev=340035=rev Log: [clangd] Add a testcase for empty preamble. Summary: This is a patch of add a testcase for https://reviews.llvm.org/D50628. Reviewers: ilya-biryukov Subscribers:

r340029 - [Preamble] Empty preamble is not an error.

2018-08-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 17 07:25:10 2018 New Revision: 340029 URL: http://llvm.org/viewvc/llvm-project?rev=340029=rev Log: [Preamble] Empty preamble is not an error. Summary: Empty preamble is valid for source file which doesn't have any preprocessor and #includes. This patch makes clang

[clang-tools-extra] r340075 - [clang-tidy] Add missing check documentation.

2018-08-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 17 12:50:22 2018 New Revision: 340075 URL: http://llvm.org/viewvc/llvm-project?rev=340075=rev Log: [clang-tidy] Add missing check documentation. Added: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-duration-division.rst Added:

[clang-tools-extra] r340161 - [clangd] Simplify the code using UniqueStringSaver, NFC.

2018-08-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Aug 20 02:47:12 2018 New Revision: 340161 URL: http://llvm.org/viewvc/llvm-project?rev=340161=rev Log: [clangd] Simplify the code using UniqueStringSaver, NFC. Modified: clang-tools-extra/trunk/clangd/index/Index.cpp clang-tools-extra/trunk/clangd/index/Index.h

[clang-tools-extra] r340156 - [clangd] Add missing lock in the lookup.

2018-08-20 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Aug 20 02:07:59 2018 New Revision: 340156 URL: http://llvm.org/viewvc/llvm-project?rev=340156=rev Log: [clangd] Add missing lock in the lookup. Reviewers: ioeric Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential Revision:

[clang-tools-extra] r340800 - [clang-tidy] Abseil: no namepsace check

2018-08-28 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Aug 28 00:48:28 2018 New Revision: 340800 URL: http://llvm.org/viewvc/llvm-project?rev=340800=rev Log: [clang-tidy] Abseil: no namepsace check This check ensures that users of Abseil do not open namespace absl in their code, as that violates our compatibility

[clang-tools-extra] r340411 - [clang-tidy] Abseil: faster strsplit delimiter check

2018-08-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 22 06:58:25 2018 New Revision: 340411 URL: http://llvm.org/viewvc/llvm-project?rev=340411=rev Log: [clang-tidy] Abseil: faster strsplit delimiter check This check is an abseil specific check that checks for code using single character string literals as delimiters

r340403 - [Preamble] Fix an undefined behavior when checking an empty preamble can be reused.

2018-08-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 22 05:34:04 2018 New Revision: 340403 URL: http://llvm.org/viewvc/llvm-project?rev=340403=rev Log: [Preamble] Fix an undefined behavior when checking an empty preamble can be reused. Summary: Passing nullptr to memcmp is UB. Reviewers: ilya-biryukov Reviewed By:

[clang-tools-extra] r340412 - [clang-tidy] Add Abseil prefix to documentation

2018-08-22 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Aug 22 07:03:30 2018 New Revision: 340412 URL: http://llvm.org/viewvc/llvm-project?rev=340412=rev Log: [clang-tidy] Add Abseil prefix to documentation Summary: Adds the Abseil prefix to the list of prefixes in the documentation Patch by Deanna Garcia! Reviewers:

[clang-tools-extra] r341242 - [clangd] Implement findOccurrences interface in dynamic index.

2018-08-31 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 31 12:53:37 2018 New Revision: 341242 URL: http://llvm.org/viewvc/llvm-project?rev=341242=rev Log: [clangd] Implement findOccurrences interface in dynamic index. Summary: Implement the interface in - FileIndex - MemIndex - MergeIndex Depends on

[clang-tools-extra] r341208 - [clangd] Collect symbol occurrences in SymbolCollector.

2018-08-31 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Aug 31 05:54:13 2018 New Revision: 341208 URL: http://llvm.org/viewvc/llvm-project?rev=341208=rev Log: [clangd] Collect symbol occurrences in SymbolCollector. SymbolCollector will be used for two cases: - collect Symbol type only, used for indexing preamble AST. -

[clang-tools-extra] r341463 - [clangd] Sort GoToDefinition results.

2018-09-05 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Sep 5 05:00:15 2018 New Revision: 341463 URL: http://llvm.org/viewvc/llvm-project?rev=341463=rev Log: [clangd] Sort GoToDefinition results. Summary: GoToDefinition returns all declaration results (implicit/explicit) that are in the same location, and the results are

[clang-tools-extra] r327293 - [clangd] Fix diagnostic errors in the test code, NFC.

2018-03-12 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Mar 12 09:49:24 2018 New Revision: 327293 URL: http://llvm.org/viewvc/llvm-project?rev=327293=rev Log: [clangd] Fix diagnostic errors in the test code, NFC. Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: klimek, jkorous-apple, cfe-commits, ioeric

[clang-tools-extra] r327386 - [clangd] Remove extra ";", NFC.

2018-03-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 13 05:26:28 2018 New Revision: 327386 URL: http://llvm.org/viewvc/llvm-project?rev=327386=rev Log: [clangd] Remove extra ";", NFC. Modified: clang-tools-extra/trunk/unittests/clangd/ClangdUnitTests.cpp Modified:

[clang-tools-extra] r327387 - [clangd] Fix irrelevant declaratations in goto definition (on macros).

2018-03-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 13 05:30:59 2018 New Revision: 327387 URL: http://llvm.org/viewvc/llvm-project?rev=327387=rev Log: [clangd] Fix irrelevant declaratations in goto definition (on macros). Summary: DeclrationAndMacrosFinder will find some declarations (not macro!) that are referened

[clang-tools-extra] r327401 - [clangd] Use the macro name range as the definition range.

2018-03-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 13 07:31:31 2018 New Revision: 327401 URL: http://llvm.org/viewvc/llvm-project?rev=327401=rev Log: [clangd] Use the macro name range as the definition range. Summary: This also aligns with the behavior of declarations. Reviewers: sammccall Reviewed By: sammccall

[clang-tools-extra] r327111 - [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

2018-03-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Mar 9 02:47:14 2018 New Revision: 327111 URL: http://llvm.org/viewvc/llvm-project?rev=327111=rev Log: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith Patch by Niko Weh! Reviewers: hokein Subscribers: klimek, cfe-commits, ioeric,

[clang-tools-extra] r327023 - [clangd] Early return for #include goto definition.

2018-03-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Mar 8 08:28:12 2018 New Revision: 327023 URL: http://llvm.org/viewvc/llvm-project?rev=327023=rev Log: [clangd] Early return for #include goto definition. Summary: This would save cost of walking over the AST, NFC. Reviewers: ilya-biryukov Subscribers: klimek,

[clang-tools-extra] r327131 - [clangd] Fix failing lit test.

2018-03-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Mar 9 06:16:46 2018 New Revision: 327131 URL: http://llvm.org/viewvc/llvm-project?rev=327131=rev Log: [clangd] Fix failing lit test. This test is missed in r327129. Modified: clang-tools-extra/trunk/test/clangd/xrefs.test Modified:

[clang-tools-extra] r327129 - [clangd] Use identifier range as the definition range.

2018-03-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Mar 9 06:00:34 2018 New Revision: 327129 URL: http://llvm.org/viewvc/llvm-project?rev=327129=rev Log: [clangd] Use identifier range as the definition range. Summary: This also matches the range in symbol index. Reviewers: sammccall Subscribers: klimek, ilya-biryukov,

[clang-tools-extra] r326799 - [clang-tidy] Fix one corner case in make-unique check.

2018-03-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 6 06:34:35 2018 New Revision: 326799 URL: http://llvm.org/viewvc/llvm-project?rev=326799=rev Log: [clang-tidy] Fix one corner case in make-unique check. Summary: Previously, we tried to cover all "std::initializer_list" implicit conversion cases in the code, but

[clang-tools-extra] r329578 - [clangd] Allow using customized include path in URI.

2018-04-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Apr 9 08:09:44 2018 New Revision: 329578 URL: http://llvm.org/viewvc/llvm-project?rev=329578=rev Log: [clangd] Allow using customized include path in URI. Summary: Calculating the include path from absolute file path does not always work for all build system, e.g. bazel

[clang-tools-extra] r329583 - [clangd] Bump v0.0.6 for vscode-clangd.

2018-04-09 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Apr 9 08:37:09 2018 New Revision: 329583 URL: http://llvm.org/viewvc/llvm-project?rev=329583=rev Log: [clangd] Bump v0.0.6 for vscode-clangd. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json Modified:

r329786 - [Tooling] Correct the "-std" compile command option.

2018-04-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Apr 11 02:18:18 2018 New Revision: 329786 URL: http://llvm.org/viewvc/llvm-project?rev=329786=rev Log: [Tooling] Correct the "-std" compile command option. Summary: "-std c++11" is not valid in compiler, we have to use "-std=c++11". Test in vscode with this patch, code

r329784 - [Tooling] Optimize memory usage in InMemoryToolResults.

2018-04-11 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Apr 11 01:13:07 2018 New Revision: 329784 URL: http://llvm.org/viewvc/llvm-project?rev=329784=rev Log: [Tooling] Optimize memory usage in InMemoryToolResults. Avoid storing duplicated "std::string"s. clangd's global-symbol-builder takes 20+GB memory running across LLVM

[clang-tools-extra] r329997 - [clangd] Add line and column number to the index symbol.

2018-04-13 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Apr 13 01:30:39 2018 New Revision: 329997 URL: http://llvm.org/viewvc/llvm-project?rev=329997=rev Log: [clangd] Add line and column number to the index symbol. Summary: LSP is using Line & column as symbol position, clangd needs to transfer file offset to Line & column

[clang-tools-extra] r330182 - [clangd] Fix "fail to create file URI" warnings in FileIndexTest.

2018-04-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Apr 17 01:34:50 2018 New Revision: 330182 URL: http://llvm.org/viewvc/llvm-project?rev=330182=rev Log: [clangd] Fix "fail to create file URI" warnings in FileIndexTest. Summary: When running the FileIndexTest, it shows "Failed to create an URI for file XXX: not a valid

[clang-tools-extra] r330245 - [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.

2018-04-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Apr 18 01:54:28 2018 New Revision: 330245 URL: http://llvm.org/viewvc/llvm-project?rev=330245=rev Log: [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file. Summary: Fix https://bugs.llvm.org/show_bug.cgi?id=34900. Reviewers: alexfh Reviewed By:

[clang-tools-extra] r330327 - [clang-tidy] Fix unused-variable warning.

2018-04-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Apr 19 06:34:03 2018 New Revision: 330327 URL: http://llvm.org/viewvc/llvm-project?rev=330327=rev Log: [clang-tidy] Fix unused-variable warning. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp Modified:

Re: [clang-tools-extra] r330245 - [clang-tidy] Fix clang-tidy doesn't read .clangtidy configuration file.

2018-04-19 Thread Haojian Wu via cfe-commits
Thanks! I didn't see this warning when running check-clang-tools on my machine. Fixed in r330327. On Thu, Apr 19, 2018 at 7:39 AM, Mikael Holmén <mikael.hol...@ericsson.com> wrote: > Hi, > > > On 04/18/2018 10:54 AM, Haojian Wu via cfe-commits wrote: > >> Author: hokei

[clang-tools-extra] r330835 - [clangd] Add "str()" method to SymbolID.

2018-04-25 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Apr 25 08:27:09 2018 New Revision: 330835 URL: http://llvm.org/viewvc/llvm-project?rev=330835=rev Log: [clangd] Add "str()" method to SymbolID. Summary: This is a convenient function when we try to get std::string of SymbolID. Reviewers: ioeric Subscribers: klimek,

[clang-tools-extra] r329073 - [clang-tidy] Check for sizeof that call functions

2018-04-03 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Apr 3 08:10:24 2018 New Revision: 329073 URL: http://llvm.org/viewvc/llvm-project?rev=329073=rev Log: [clang-tidy] Check for sizeof that call functions Summary: A common mistake that I have found in our codebase is calling a function to get an integer or enum that

[clang-tools-extra] r327887 - [clang-move] Fix the failing test caused by changes in clang-format.

2018-03-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Mar 19 12:13:03 2018 New Revision: 327887 URL: http://llvm.org/viewvc/llvm-project?rev=327887=rev Log: [clang-move] Fix the failing test caused by changes in clang-format. Modified: clang-tools-extra/trunk/test/clang-move/move-used-helper-decls.cpp Modified:

[clang-tools-extra] r326778 - [clangd] Fix -Wpedantic warning, NFC.

2018-03-06 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Mar 6 04:56:18 2018 New Revision: 326778 URL: http://llvm.org/viewvc/llvm-project?rev=326778=rev Log: [clangd] Fix -Wpedantic warning, NFC. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp URL:

[clang-tools-extra] r343963 - [clangd] Update the out-of-date yaml-symbol-file flag in clangd.

2018-10-08 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 8 03:44:54 2018 New Revision: 343963 URL: http://llvm.org/viewvc/llvm-project?rev=343963=rev Log: [clangd] Update the out-of-date yaml-symbol-file flag in clangd. Summary: The flag is stale due to the recent changes of clangd indexer, this patch renames the flag to

[clang-tools-extra] r344508 - [clangd] dump xrefs information in dexp tool.

2018-10-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 15 05:32:49 2018 New Revision: 344508 URL: http://llvm.org/viewvc/llvm-project?rev=344508=rev Log: [clangd] dump xrefs information in dexp tool. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential

[clang-tools-extra] r344507 - [clangd] Fix some references missing in dynamic index.

2018-10-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 15 04:46:26 2018 New Revision: 344507 URL: http://llvm.org/viewvc/llvm-project?rev=344507=rev Log: [clangd] Fix some references missing in dynamic index. Summary: Previously, SymbolCollector postfilters all references at the end to find all references of interesting

[clang-tools-extra] r344510 - [clangd] Remove an unused include header, NFC.

2018-10-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 15 05:39:45 2018 New Revision: 344510 URL: http://llvm.org/viewvc/llvm-project?rev=344510=rev Log: [clangd] Remove an unused include header, NFC. Modified: clang-tools-extra/trunk/clangd/index/Merge.cpp Modified: clang-tools-extra/trunk/clangd/index/Merge.cpp

[clang-tools-extra] r344521 - [clangd] Add createIndex in dexp

2018-10-15 Thread Haojian Wu via cfe-commits
Author: hokein Date: Mon Oct 15 08:12:40 2018 New Revision: 344521 URL: http://llvm.org/viewvc/llvm-project?rev=344521=rev Log: [clangd] Add createIndex in dexp Summary: This would allow easily injecting our internal customization. Also updates the stale "symbol-collection-file" flag.

[clang-tools-extra] r344745 - [clangd] Clear the semantic of RefSlab::size.

2018-10-18 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu Oct 18 08:33:20 2018 New Revision: 344745 URL: http://llvm.org/viewvc/llvm-project?rev=344745=rev Log: [clangd] Clear the semantic of RefSlab::size. Summary: The RefSlab::size can easily cause confusions, it returns the number of different symbols, rahter than the number

[clang-tools-extra] r344777 - [clangd] Remove the overflow log.

2018-10-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Fri Oct 19 01:35:24 2018 New Revision: 344777 URL: http://llvm.org/viewvc/llvm-project?rev=344777=rev Log: [clangd] Remove the overflow log. Summary: LLVM codebase has generated files (all are build/Target/XXX/*.inc) that exceed the MaxLine & MaxColumn. Printing these log

[clang-tools-extra] r344678 - [clangd] Collect refs from headers.

2018-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 17 01:38:36 2018 New Revision: 344678 URL: http://llvm.org/viewvc/llvm-project?rev=344678=rev Log: [clangd] Collect refs from headers. Summary: Add a flag to SymbolCollector to collect refs fdrom headers. Note that we collect refs from headers in static index, and

[clang-tools-extra] r344679 - [clangd] Print numbers of symbols and refs as well when loading the

2018-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 17 01:48:04 2018 New Revision: 344679 URL: http://llvm.org/viewvc/llvm-project?rev=344679=rev Log: [clangd] Print numbers of symbols and refs as well when loading the index. Modified: clang-tools-extra/trunk/clangd/index/Serialization.cpp Modified:

[clang-tools-extra] r344680 - [clangd] Fix buildbot failure.

2018-10-17 Thread Haojian Wu via cfe-commits
Author: hokein Date: Wed Oct 17 01:54:48 2018 New Revision: 344680 URL: http://llvm.org/viewvc/llvm-project?rev=344680=rev Log: [clangd] Fix buildbot failure. Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified:

<    5   6   7   8   9   10   11   12   13   14   >