[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This patch will suppress handle leak warnings if the path of a bug reported by MagentaHandleChecker will reach a no return function or will reach the end of main function. As these two scenarios mean program crash and the

[PATCH] D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker

haowei updated this revision to Diff 109237. haowei added a comment. Add 1 line fix for the constraint on allocated handle in function allocateSingleHandle at line 647 https://reviews.llvm.org/D36022 Files: lib/StaticAnalyzer/Checkers/MagentaHandleChecker.cpp test/Analysis/mxhandle.c

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

haowei added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MagentaHandleChecker.cpp:483-498 +void MagentaHandleChecker::checkPreStmt(const ReturnStmt *RS, +CheckerContext ) const { + ProgramStateRef State = Ctx.getState(); +

[PATCH] D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei updated this revision to Diff 107201. haowei added a comment. Thanks for reviewing this patch. I have modified the checker according NoQ's suggestions and refactored some long functions. > We're trying to use this CallDescription thing for this purpose recently. I took a look at

[PATCH] D36023: [analyzer] Add array support for MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This commit adds support for syscalls that acquire/release handles in an array for MagentaHandleChecker introduced in https://reviews.llvm.org/D35968 and https://reviews.llvm.org/D36022. Most magenta handle related syscalls

[PATCH] D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This commits add actual code for analyzing magenta handle misuse issues to MagentaHandleChecker, which is introduced in https://reviews.llvm.org/D35968. It supports magenta syscalls that acquires/release/use handle through

[PATCH] D36024: [analyzer] Improved bug reporting in MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This commit improves the bug reporting of MagentaHandleChecker introduced in https://reviews.llvm.org/D35968 , https://reviews.llvm.org/D36022 and https://reviews.llvm.org/D36023. After this commit, the allocation and release

[PATCH] D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This patch adds "mx_create_sink" annotation support to MagentaHandleChecker to address the false positives found in Magenta unit tests. After this patch, when a call to a function contains this annotation, MagentaHandleChecker

[PATCH] D35968: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei created this revision. Herald added subscribers: xazax.hun, mgorny. This patch supersedes https://reviews.llvm.org/D34724. We have finished the checker but it is too big to be submitted as a single commit. So we split it into several pieces to help with the review process. This patch

[PATCH] D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei abandoned this revision. haowei added a comment. Superseded by https://reviews.llvm.org/D35968 https://reviews.llvm.org/D34724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33263: [scan-build] Patch to scan-build tool to support "--target=" flag

haowei created this revision. The scan-build script provided by clang can be used to detect defects in code in the compile time. However, we discovered that the "--target=" flag in clang is not properly handled by this script, which results in failures when analyzing projects that have used

[PATCH] D34489: [scan-build-py] Patch to fix "-analyzer-config" option

haowei created this revision. Herald added a subscriber: whisperity. I noticed that when I use "-analyze-config" option in scan-build-py, it behaves differently from original perl based scan-build. For example, command: $ scan-build -analyzer-config ipa=basic-inlining make Will work without

[PATCH] D33263: [scan-build] Patch to scan-build tool to support "--target=" flag

haowei added a comment. In https://reviews.llvm.org/D33263#756900, @zaks.anna wrote: > Looks good. Thank you! > Do you have commit access or should we commit? I don't have commit access, so could you commit this patch? Thanks. https://reviews.llvm.org/D33263

[PATCH] D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei created this revision. Herald added subscribers: xazax.hun, mgorny. This patch adds a new Static Analyzer checker for the correct use of handle in Magenta kernel. The concept of handle is very similar to file descriptor in Unix. This checker checks leaks, use after release and double

[PATCH] D93868: [analyzer] Update Fuchsia checker to catch when releasing unowned handles.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8deaec122ec6: [analyzer] Update Fuchsia checker to catch releasing unowned handles. (authored by Daniel Hwang ar...@google.com, committed by haowei). Herald added a project: clang. Herald added a

[PATCH] D91223: Support struct annotations in FuchsiaHandleChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG914f6c4ff8a4: [StaticAnalyzer] Support struct annotations in FuchsiaHandleChecker (authored by haowei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D92444: [CMake][Fuchsia] Install llvm-elfabi

haowei accepted this revision. haowei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92444/new/ https://reviews.llvm.org/D92444 ___

[PATCH] D91902: [analyzer] Ignore annotations if func is inlined.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ce78f54edcf: [analyzer] Ignore annotations if func is inlined. (authored by aabbaabb, committed by haowei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D91223: Support struct annotations in FuchsiaHandleChecker.

haowei added a comment. In D91223#2415137 , @MaskRay wrote: > @haowei https://llvm.org/docs/DeveloperPolicy.html#commit-messages Please use > git commit --amend --author for future patches where the majority of the work > is done by others. Thanks for

[PATCH] D90275: [clang][IR] Add support for leaf attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c0e3a77bc43: [clang][IR] Add support for leaf attribute (authored by gulfem, committed by haowei). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

haowei closed this revision. haowei added a comment. Landed in https://github.com/llvm/llvm-project/commit/d93287cac89fd50a105ac4a59c079884b8e53e49 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llvm.org/D90362

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

haowei added a comment. In D66324#2394687 , @lebedev.ri wrote: > In D66324#2336555 , @lebedev.ri > wrote: > >> In D66324#2336186 , @phosek wrote: >> >>> I apologize for the

[PATCH] D35968: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36024: [analyzer] Improved bug reporting in MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36023: [analyzer] Add array support for MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D99810: [ifs] Prepare llvm-ifs for elfabi/ifs merging.

haowei marked an inline comment as done. haowei added inline comments. Comment at: llvm/include/llvm/InterfaceStub/ELFObjHandler.h:25 namespace elfabi { phosek wrote: > Shouldn't this be in namespace `ifs`? This was renamed to ifs in D100139. Rename it

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

haowei updated this revision to Diff 353507. haowei marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100139/new/ https://reviews.llvm.org/D100139 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

haowei updated this revision to Diff 343780. haowei added a comment. Rebase the change to resolve presubmit errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100139/new/ https://reviews.llvm.org/D100139 Files:

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

haowei added a comment. This CL breaks our mac builders as well. Could you either fix the test or revert the change please? Error message: TEST 'Clang :: CodeGenCXX/const-dynamic-init.cpp' FAILED Script: -- : 'RUN: at line 1';

[PATCH] D103218: [Fuchsia][CMake] Add missing include path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ce58c52d50b: [Fuchsia][CMake] Add missing include path. (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103218: [Fuchsia][CMake] Add missing include path.

haowei created this revision. haowei added reviewers: phosek, mcgrathr, leonardchan, gulfem. Herald added subscribers: cryptoad, mgorny. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds include path for missing header

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. We are seeing test failures in our builders with message after your patch. Could you take a look and fix this unit test please? FAIL: Clang :: Driver/debug-pass-structure.c (6773 of 27894) TEST 'Clang :: Driver/debug-pass-structure.c' FAILED

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. In D99599#2726252 , @evgeny777 wrote: > @haowei What are LLVM configuration options? Also please send output from > > /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -flegacy-pass-manager > -fdebug-pass-structure -O0 -S -emit-llvm

[PATCH] D99599: [NewPM] Add an option to dump pass structure

haowei added a comment. Output from `clang -flegacy-pass-manager -fdebug-pass-structure -O0 -S -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null 2>&1`: Pass Arguments: -tti -targetlibinfo Target Transform Information Target Library

[PATCH] D94251: [scan-build-py] Update scan-build-py to allow outputing as SARIF.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd72859ffa237: [scan-build-py] Update scan-build-py to allow outputing as SARIF (authored by Daniel Hwang ar...@google.com, committed by haowei). Herald added a project: clang. Herald added a subscriber:

[PATCH] D96389: [analyzer] Update static analyzer to be support sarif-html

This revision was automatically updated to reflect the committed changes. Closed by commit rG2407eb08a574: [analyzer] Update static analyzer to be support sarif-html (authored by Daniel Hwang ar...@google.com, committed by haowei). Herald added a project: clang. Herald added a subscriber:

[PATCH] D99810: [ifs][elfabi] Merge llvm-elfabi tool into llvm-ifs

haowei marked 3 inline comments as done. haowei added a comment. I will try to split this change. Comment at: clang/lib/Driver/ToolChains/InterfaceStubs.cpp:26 const bool WriteBin = !Args.getLastArg(options::OPT_emit_merged_ifs); - CmdArgs.push_back(WriteBin ? "write-bin"

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

haowei created this revision. haowei added reviewers: phosek, plotfi, compnerd, mcgrathr. Herald added subscribers: hiraditya, mgorny. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change merges llvm-elfabi

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei created this revision. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fallback-style is a frequently used flag in clang_format, however, it was not supported by clang-format-diff.py script. This change adds this flag.

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. haowei marked an inline comment as done. Closed by commit rG38a5bd4115af: [clang_format] Add fallback-style flag to clang-format-diff.py (authored by haowei).

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei marked an inline comment as done. haowei added inline comments. Comment at: clang/tools/clang-format/clang-format-diff.py:62 + parser.add_argument('-fallback-style', + dest='fallback_style', + help='The name of the predefined

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei updated this revision to Diff 371749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109550/new/ https://reviews.llvm.org/D109550 Files: clang/tools/clang-format/clang-format-diff.py Index: clang/tools/clang-format/clang-format-diff.py

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

haowei added a comment. We are seeing float related unit tests failing in Fuchsia after this patch. What flags should we add to our build to match llvm's previous float point behavior? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

haowei added a comment. Can we revert this patch please? If I understood correctly, this patch changed the default behavior of clang when generating code for float point arithmetic. After this patch `-ffp-contract` was set to on if this flag was not specified. In theory this makes clang use

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

haowei added a comment. In D74436#2926385 , @tstellar wrote: > Can someone file a bug for this and put release-13.0.0 in the blocks field so > we can track it? Filed https://bugs.llvm.org/show_bug.cgi?id=51346 . Repository: rG LLVM Github Monorepo

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378052. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei added a comment. I added unit test for macros. I am still working on adding error checks on `--ffuchsia-api-level` flags but the rest is pretty much done. Comment at: clang/test/Frontend/attr-availability-fuchsia.c:4 +// +// It should also be exposed to non-fuchsia

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378784. haowei added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG1131b1eb3509: [clang][Fuchsia] Support availability attr on Fuchsia (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378780. haowei added a comment. Fix test failures on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td

[PATCH] D112271: [clang][Fuchsia] Add additional unit test for availability attr

haowei created this revision. haowei added reviewers: phosek, leonardchan, gulfem. Herald added a subscriber: abrachet. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds additional unit tests for availability

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378324. haowei added a comment. Added unit test when "-ffuchsia-api-level" is supplied with a non integer value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

haowei added a comment. We are seeing a series of weird errors in our windows clang builder after this patch landed: [1/828] Building CXX object compiler-rt\lib\sanitizer_common\CMakeFiles\RTSanitizerCommonNoTermination.x86_64.dir\sanitizer_solaris.cpp.obj FAILED:

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei marked an inline comment as done. haowei added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:893 Builder.defineMacro("_GNU_SOURCE"); +Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel)); +this->PlatformName = "fuchsia";

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377726. haowei marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei commandeered this revision. haowei added a reviewer: leonardchan. haowei added a comment. Herald added a subscriber: abrachet. I am commandeering this work as original author stopped working this project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377389. haowei edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td

[PATCH] D112271: [clang][Fuchsia] Add additional unit test for availability attr

This revision was automatically updated to reflect the committed changes. Closed by commit rG07bed3ae52b0: [clang][Fuchsia] Add additional unit test for availability attr (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6103fdfab4e2: [ifs][elfabi] Merge llvm-ifs/elfabi tools (authored by haowei). Changed prior to commit:

[PATCH] D119479: [clang][extract-api] Add global record support

haowei added a comment. In D119479#3387880 , @zixuw wrote: > @haowei I got a quick fix of completely purging the generator output in the > test case. Could you take a look to have a sanity check before I land the fix > on main? > > diff --git

[PATCH] D119479: [clang][extract-api] Add global record support

haowei added a comment. We are seeing test failures after this patch is landed: Clang :: SymbolGraph/global_record.c Script: -- : 'RUN: at line 1'; rm -rf /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/SymbolGraph/Output/global_record.c.tmp : 'RUN: at line 2'; split-file

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

haowei added a comment. Hi, we are seeing clang Windows build breakages after this change was relanded error message: Assertion failed: isa(Val) && "cast() argument of incompatible type!", file C:\b\s\w\ir\x\w\llvm-llvm-project\llvm\include\llvm/Support/Casting.h, line 262 PLEASE submit

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

haowei added a comment. Hi I am working on updating GoogleTest in LLVM to v1.14.0 and during my local testing, I noticed that this patch added 2 new tests `ImportMatrixType` and `ImportOpenCLPipe` through `TEST_P` calls, however, both tests were not instantiated by `INSTANTIATE_TEST_SUITE_P`

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

haowei added a comment. In D158948#4642475 , @danix800 wrote: > In D158948#4642422 , @haowei wrote: > >> Looking at >>

[PATCH] D145214: [TSAN] add support for riscv64

haowei added a comment. Hi, I believe you forgot to add `tsan_rtl_riscv64.S` to your patch when you land it. We are seeing build errors on our bots with following messages: -- Configuring done (12.3s) CMake Error at

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. We are seeing Clang driver test failures after this patch. On Fuchsia's mac clang builder, `Clang :: Driver/avr-ld.c` and `Clang :: Driver/avr-toolchain.c` are failing. Failed build task:

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. I already reverted the change in https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad . It is likely the breakage is caused by the fact that Fuchsia's Clang by default use `lld`, see

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

haowei added a comment. I tested this patch on top of https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25 (reverted in https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad) and Clang driver tests now pass without issue.

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. Emmm, I applied your latest patch on top of main(6e02e27536b9de25a651cfc9c2966ce471169355 ) but I still get a test failure on `Clang :: Driver/avr-toolchain.c`. `Clang :: Driver/avr-ld.c` no longer

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. In D126192#3583915 , @benshi001 wrote: > It seems the file > `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld` > is missing on your machine, which I have newly created in current patch.

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. I tested this patch on our windows builder and it passed as well. This patch LGTM. (I cannot click accept as the this review is already closed) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

haowei added subscribers: haowei, phosek, mcgrathr. haowei added a comment. Hi, We are seeing build failures on Fuchsia build bots after this change was landed. and we suspect this patch causes clang to miscompile certain code. I filed bug https://github.com/llvm/llvm-project/issues/57351 and

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

haowei added subscribers: mcgrathr, phosek, gulfem. haowei added a comment. After looking into the code, I think I should point out that `compiler-rt/include/profile/InstrProfData.inc` is a published header and its API details cannot be changed trivially without coordination with external

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

haowei added a comment. We are also saw failures on Fuchsia builders when using ToT clang: [31281/267743] CXX host_x64/obj/src/lib/llvm-profdata/llvm-profdata-for-test.llvm-profdata.cc.o FAILED: host_x64/obj/src/lib/llvm-profdata/llvm-profdata-for-test.llvm-profdata.cc.o

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:336 Reference *I, FieldId ) { switch (ID) { case REFERENCE_USR: This block ID came from L582, which read from a bitcode file when

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei accepted this revision. haowei added a comment. This revision is now accepted and ready to land. LGTM @paulkirth Do you have more comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134235/new/ https://reviews.llvm.org/D134235 ___

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei added a comment. @brettw Thanks for the clarification. I was oncall for buildgardener last week and got quite busy due to breakages. Thanks for your clarification, that is really helpful to understand the your intent. While I still don't see the way these constructors are implemented is

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei added a comment. I am a bit puzzled by the intent of cleaning up the constructors in Info object. I didn't see it as an issue to have multiple constructors, which is a common practice. After this clean up It doesn't make it easier to use these objects, in fact, in `Serialize.cpp`, you

[PATCH] D134371: [clang-doc] Add typedef/using information.

haowei added a comment. In D134371#3819605 , @nemanjai wrote: > This causes failures with `-Werror` such as: > https://lab.llvm.org/buildbot/#/builders/57/builds/22322 > Please fix or revert. Thanks for reporting this. I reverted this change.

[PATCH] D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change includes llvm-ml tool in Fuchsia toolchain.

[PATCH] D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc3edb627201: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141448/new/

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa903ecb4a26d: [vfs] Allow root paths relative to the vfsoverlay YAML file (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added a comment. In D137473#3993584 , @bnbarham wrote: > LGTM. If you could put up a PR after to fix the use of > `sys::fs::make_absolute` that would be appreciated . Thanks, I will start working on the fix. Repository: rG LLVM Github

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482658. haowei added a comment. Rebased the change to solve the merge conflicts on the bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files:

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml clang/test/VFS/relative-path.c

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 482644. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml clang/test/VFS/relative-path.c

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added a comment. I changed some comments and add more details. If there is no objection, can I get an approval on this change so I can land it? It will unblock our development on Windows cross compilation support. Comment at:

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1922 + EC = FS->makeAbsolute(FullPath, Name); + Name = canonicalize(Name); +} else { bnbarham wrote: > Why the canonicalization? If the Name here somehow

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475884. haowei marked 2 inline comments as done. haowei added a comment. Fixing Windows test failures. overlay-relative flag will always using native path separator, therefore, it needs a separate base FS and OverlayYAML file setup on Windows. This diff adds

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475591. haowei added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei marked 2 inline comments as done. haowei added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:1010 + std::error_code makeAbsolute(StringRef WorkingDir, + SmallVectorImpl ) const; bnbarham wrote:

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475574. haowei added a comment. I have to revert back to use process cwd instead of base fs cwd. There are a few tests relied the behavior of using process cwd that I need to take a closer look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141738: [WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Work in progress. Initial work on

[PATCH] D141738: [WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 489177. haowei added a comment. Correct C, CXX flag issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei updated this revision to Diff 490679. haowei retitled this revision from "[WIP] Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain" to "Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei marked 2 inline comments as done. haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:73 + +if(WIN32 OR (LINUX AND WINDOWS_SDK_DIR)) +#if(WINDOWS_SDK_DIR) phosek wrote: > I'd drop this part altogether, let's build these

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added a comment. Thanks for the review. I will land the change once Fuchsia clang builders are green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738

  1   2   >