chhzh123 updated this revision to Diff 413532.
chhzh123 added a comment.
Fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
Files:
mlir/python/mlir/dialects/_scf_ops_ext.py
chhzh123 updated this revision to Diff 413518.
chhzh123 added a comment.
Herald added subscribers: cfe-commits, llvm-commits, libc-commits,
libcxx-commits, pcwang-thead, awarzynski, arjunp, luke957, abrachet, Groverkss,
ormris, foad, mravishankar, frasercrmck, dexonsmith, ecnelises, ThomasRaoux,
chhzh123 marked 2 inline comments as done.
chhzh123 added a comment.
@ftynse Sorry for messing up this PR a bit. I've made the changes you
suggested. Please have a check. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
chhzh123 updated this revision to Diff 413528.
chhzh123 added a comment.
Fix function signature and add tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
Files:
mlir/test/python/dialects/scf.py
chhzh123 updated this revision to Diff 413520.
chhzh123 added a comment.
Revert
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
Files:
mlir/python/mlir/dialects/_scf_ops_ext.py
Index:
chhzh123 added a comment.
Oh seems I made a wrong merge from the master branch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
___
cfe-commits mailing list
chhzh123 added a comment.
@ftynse Thanks for reviewing! Could you help land the PR? Seems I do not have
access rights to push to the main repository.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
chhzh123 added a comment.
Hi @ftynse , could you please take a look at it and see if there is anything
that should be changed? Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
chhzh123 updated this revision to Diff 414852.
chhzh123 added a comment.
Try rebasing again
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
Files:
mlir/python/mlir/dialects/_scf_ops_ext.py
chhzh123 updated this revision to Diff 414845.
chhzh123 added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
Files:
mlir/test/python/dialects/scf.py
Index:
chhzh123 updated this revision to Diff 414847.
chhzh123 added a comment.
Rebase 3 commits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
Files:
mlir/python/mlir/dialects/_scf_ops_ext.py
chhzh123 added a comment.
I've rebased to the latest commit in the main branch, but the pre-merge checks
still failed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
chhzh123 updated this revision to Diff 414900.
chhzh123 added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
Files:
mlir/python/mlir/dialects/_scf_ops_ext.py
chhzh123 added a comment.
Passed pre-merge checks. Should be able to be merged. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121076/new/
https://reviews.llvm.org/D121076
___
cfe-commits mailing
14 matches
Mail list logo
