[PATCH] D104021: [clang-tidy] LIT test fix for Remark diagnostic

ivanmurashko created this revision. ivanmurashko added reviewers: aaron.ballman, alexfh, DmitryPolukhin. ivanmurashko added projects: clang, clang-tools-extra. Herald added a subscriber: xazax.hun. ivanmurashko requested review of this revision. Herald added a subscriber: cfe-commits. There is a

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

ivanmurashko created this revision. ivanmurashko added reviewers: aaron.ballman, alexfh, DmitryPolukhin, gribozavr2. ivanmurashko added projects: clang, clang-tools-extra. Herald added a subscriber: xazax.hun. ivanmurashko requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

ivanmurashko updated this revision to Diff 347326. ivanmurashko added a comment. @DmitryPolukhin suggestion was applied Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102906/new/ https://reviews.llvm.org/D102906 Files:

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

ivanmurashko marked an inline comment as done. ivanmurashko added a comment. Hi @aaron.ballman > Thanks! Do you need someone to commit on your behalf? I will appreciate your assistance in the landing the diff. > If so, what name and email address would you like used for patch attribution? It

[PATCH] D107944: [hmaptool] Port to python3

ivanmurashko added inline comments. Comment at: clang/utils/hmaptool/hmaptool:223 with open(output_path, 'wb') as f: f.write(magic.encode()) f.write(struct.pack(header_fmt, *header)) `magic` is a bytes object that does not have `encode()`

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko created this revision. ivanmurashko added reviewers: rsmith, DmitryPolukhin. ivanmurashko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a SIGSEGV at DeduceTemplateArgumentsByTypeMatch. See BUG description and

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko added a comment. @erichkeane, is it OK if the reproducer will be added as the LIT test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/ https://reviews.llvm.org/D106583 ___

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko updated this revision to Diff 361001. ivanmurashko added a comment. The LIT test was added: build] ./bin/llvm-lit -v ../clang/test/SemaCXX/pr51171-crash.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko updated this revision to Diff 361005. ivanmurashko added a comment. LIT test was updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/ https://reviews.llvm.org/D106583 Files: clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko added a comment. @erichkeane, could you look at the added LIT test. Is it suitable or require additional modifications? BTW: There are several failed tests but they seems to be a known issue (see bug 51117 ). Repository: rG LLVM

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

ivanmurashko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:416 + auto CallMoveMatcherLambda = lambdaExpr( + forEachLambdaCapture(lambdaCapture(capturesVar(varDecl( sammccall wrote: > sammccall wrote: > >

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko created this revision. ivanmurashko added reviewers: alexfh, DmitryPolukhin, sammccall, bruno. ivanmurashko added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. ivanmurashko requested review of this revision. Herald added subscribers:

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:328 ExistingIncludes.try_emplace(trimInclude(IncludeToAdd.Name)).first; Iter->second.push_back(std::move(IncludeToAdd)); auto = Iter->second.back(); The

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 405814. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 Files: clang-tools-extra/clangd/test/repeated_includes.test

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 405886. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 Files: clang-tools-extra/clangd/test/repeated_includes.test

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko added a comment. In D118755#3301776 , @sammccall wrote: > Do you have access to commit this or should I land it for you? I would appreciate your assistance in the land. You can use the following email address: `ivan.murashko at gmail.com`

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

ivanmurashko created this revision. ivanmurashko added reviewers: alexfh, sammccall, mboehme, aaron.ballman. ivanmurashko added projects: clang, clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. ivanmurashko requested review of this revision. Herald added a subscriber:

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 406411. ivanmurashko added a comment. There are some changes: - unit test for HeaderIncludes was added - lit test for clangd was removed - Solution uses std::list instead of copying by value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 406421. ivanmurashko added a comment. comment update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/ https://reviews.llvm.org/D118755 Files:

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko updated this revision to Diff 406420. ivanmurashko edited the summary of this revision. ivanmurashko added a comment. Comment about std::list was added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

ivanmurashko added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h:100 // and "x" will be treated as the same header when deleting #includes. llvm::StringMap> ExistingIncludes; sammccall wrote: > An alternative would

[PATCH] D118755: [clangd] Crash in __memcmp_avx2_movbe

This revision was automatically updated to reflect the committed changes. Closed by commit rG71d7c8d870db: [clangd] Crash in __memcmp_avx2_movbe (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118755/new/

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko created this revision. ivanmurashko added reviewers: kadircet, sammccall. ivanmurashko added projects: clang, clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:610-619 StoreDiags PreambleDiagnostics; PreambleDiagnostics.setDiagCallback( [](const clang::Diagnostic , clangd::Diag ) { llvm::for_each(ASTListeners,

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:709 Ctx->setStatCache(Result->StatCache); + // We have to setup DiagnosticConsumer that will be alife + // while preamble callback is executed sammccall wrote:

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko updated this revision to Diff 555441. ivanmurashko marked an inline comment as done. ivanmurashko added a comment. @sammccall's comment was addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159363/new/

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

This revision was automatically updated to reflect the committed changes. Closed by commit rGd03a7f15f019: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko added a comment. In D159363#4636581 , @kadircet wrote: > thanks, the fix LGTM as well. > > but i wonder how this surfaces, to make sure we're taking necessary > precautions in the future. we definitely have a dangling reference, which >

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

This revision was automatically updated to reflect the committed changes. Closed by commit rG987f9cb6b970: [clang-tidy] Add proper emplace checks to modernize-use-emplace (authored by nicovank, committed by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

ivanmurashko accepted this revision. ivanmurashko added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101471/new/ https://reviews.llvm.org/D101471 ___ cfe-commits mailing list

[PATCH] D94727: [clangd] Retire some flags for uncontroversial, stable features.

ivanmurashko added inline comments. Herald added projects: clang-tools-extra, All. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:762 Opts.ResourceDir = ResourceDir; - Opts.BuildDynamicSymbolIndex = EnableIndex; + Opts.BuildDynamicSymbolIndex = true;

[PATCH] D124719: [clang,doc] PCH usage documentation update

ivanmurashko created this revision. Herald added a project: All. ivanmurashko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation has an incorrect example of PCH files usage via `-include` option. The possibility has not

[PATCH] D124719: [clang,doc] PCH usage documentation update

ivanmurashko updated this revision to Diff 426248. ivanmurashko added a comment. Minor changes at the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124719/new/ https://reviews.llvm.org/D124719 Files: clang/docs/UsersManual.rst Index:

[PATCH] D124719: [docs] PCH usage documentation update

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6112f490cfe: [docs] PCH usage documentation update (authored by ivanmurashko). Changed prior to commit:

[PATCH] D124719: [docs] PCH usage documentation update

ivanmurashko updated this revision to Diff 426588. ivanmurashko added a comment. Some clarifications for the direct include example were added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124719/new/ https://reviews.llvm.org/D124719 Files:

[PATCH] D124840: [RFC] Add and sort decl to maintain order instead of inserting in order

This revision was automatically updated to reflect the committed changes. Closed by commit rG2deebc0048f9: [RFC] Add and sort decl to maintain order instead of inserting in order (authored by kuganv, committed by ivanmurashko). Herald added a project: clang. Herald added a subscriber:

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko added a comment. In D130847#3690977 , @aaron.ballman wrote: > > Given that this code is on the hot path, should it be the caller's > responsibility to have already validated the `FileID` that's passed in so > that the fake entry can

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:901 const SrcMgr::SLocEntry = getLoadedSLocEntry(MiddleIndex); if (E.getOffset() == 0) return FileID(); // invalid entry. FYI: the same check is used for the rest

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko updated this revision to Diff 449261. ivanmurashko added a comment. Fix for wrong LastFileIDLookup assignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files:

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

ivanmurashko added inline comments. Comment at: clang-tools-extra/test/lit.cfg.py:19 # suffixes: A list of file extensions to treat as test files. -config.suffixes = ['.c', '.cpp', '.hpp', '.m', '.mm', '.cu', '.ll', '.cl', '.s', +config.suffixes = ['.c', '.cpp', '.cu', '.hpp',

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

ivanmurashko updated this revision to Diff 451464. ivanmurashko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files: clang/lib/Basic/SourceManager.cpp Index:

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

This revision was automatically updated to reflect the committed changes. Closed by commit rGe78c80e3d622: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of… (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131675: [clang] SIGSEGV fix at clang::ASTContext::getRawCommentForDeclNoCacheImpl

ivanmurashko created this revision. ivanmurashko added reviewers: sammccall, aaron.ballman. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project:

[PATCH] D131675: [clang] SIGSEGV fix at clang::ASTContext::getRawCommentForDeclNoCacheImpl

This revision was automatically updated to reflect the committed changes. Closed by commit rG557e32e002ed: [clang] SIGSEGV fix at clang::ASTContext::getRawCommentForDeclNoCacheImpl (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko added a comment. In D130847#3693668 , @aaron.ballman wrote: > These changes look reasonable, but I verified that the precommit CI failures > are valid -- it looks like this change broke a test somehow; perhaps a caller > was relying on

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko created this revision. ivanmurashko added reviewers: dexonsmith, aaron.ballman. ivanmurashko added a project: clang. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko updated this revision to Diff 448885. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files: clang/include/clang/Basic/SourceManager.h Index:

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko updated this revision to Diff 450750. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files: clang/lib/Basic/SourceManager.cpp Index:

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

ivanmurashko added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:882-884 const SrcMgr::SLocEntry = getLoadedSLocEntry(I); +if (E.getOffset() == 0) + return FileID(); // invalid entry. aaron.ballman wrote: > This looks incorrect to

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

ivanmurashko updated this revision to Diff 451166. ivanmurashko added a comment. Use Invalid flag to detect invalid SLocEntry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files:

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko updated this revision to Diff 450989. ivanmurashko added a comment. stop search if we could not load an entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files:

[PATCH] D130847: [clang] SourceManager: fix at SourceManager::getFileIDLoaded for the case of invalid SLockEntry

ivanmurashko added a comment. In D130847#3693668 , @aaron.ballman wrote: > These changes look reasonable, but I verified that the precommit CI failures > are valid -- it looks like this change broke a test somehow; perhaps a caller > was relying on

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko added a comment. In D145228#4174543 , @kadircet wrote: > I understand concerns about maintenance cost for the change. But I dare to ask why you think it is so high? Perhaps there are different expectations from the feature. I’m not

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko added a comment. In D145228#4174829 , @sammccall wrote: > I think this is a bit abstract though. Concretely, what API do you need here? > e.g. which headers do you want to include, to what end? If we consider the bare minimum with the only

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko added a comment. > If we consider the bare minimum with the only goal to build outside LLVM > source tree then we don’t need to copy all internal headers. At the case the > D145302 can be modified and we can end up > with the only one header

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added a comment. > Can this be solved at the build-system level, without changing the source > code in ways that aren't otherwise useful? > For example, with a `CLANG_TIDY_EXTRA_CHECKS` cmake variable that adds more > deps? This seems like it could also work for the `clang-tidy`

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 507029. ivanmurashko added a comment. The change addresses comments from D145228 . The only one header is copied as a part of the installation. As result the diff contains the minimal changes required to integrated

[PATCH] D141950: [NFC] Use find_last_of when seraching for code in getRawCommentForDeclNoCacheImpl

This revision was automatically updated to reflect the committed changes. Closed by commit rGd604c57164ec: [NFC] Use find_last_of when seraching for code in… (authored by kuganv, committed by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko created this revision. ivanmurashko added reviewers: sammccall, alexfh, smeenai, aaron.ballman. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko created this revision. ivanmurashko added reviewers: sammccall, kadircet, ilya-biryukov. Herald added a subscriber: arphaman. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project:

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 517323. ivanmurashko added a comment. Windows constrains added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

ivanmurashko added a comment. In D148088#4302269 , @ilya-biryukov wrote: > > Could you elaborate a bit more on what is being cached with modules and how > this patch would affect it? I hope that I can provide some info here. We are going to use

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 517222. ivanmurashko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 517159. ivanmurashko added a comment. Commandeer the diff from @andrewjcg and made some chnages at the code (get it compatible with latest clang source code) and at the tests (move modules artefacts to temp folder to make the test execution more

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko added a comment. @arphaman, @andrewjcg, what's the status of the diff? The functionality is important for me and I want to get it landed. BTW: @andrewjcg I can commander the diff if you don't mind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko added a comment. Friendly ping @arphaman, @jansvoboda11, I have made the patch buildable on all platforms and have all tests passed. There was also a small fix (temp path for modules artefact) at the test that could fix its run on some platforms. Could you look at it? Does it

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 539119. ivanmurashko added a comment. rebase before the final push Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files:

[PATCH] D145302: [clangd] Add library for clangd main function

This revision was automatically updated to reflect the committed changes. Closed by commit rG56ac9d46a7c1: [clangd] Add library for clangd main function (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/

[PATCH] D145228: [clangd] Add clangd headers to install targets

ivanmurashko abandoned this revision. ivanmurashko added a comment. The diff is not required after https://reviews.llvm.org/D145302 deployed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145228/new/ https://reviews.llvm.org/D145228

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added a comment. In D145302#4492595 , @mstorsjo wrote: > In D145302#4491973 , @glandium > wrote: > >> This broke building with `-DLLVM_LINK_LLVM_DYLIB=ON`: > > I also ran into this; I pushed a fix

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko added a comment. > Still looking at issues and not sure whether these are blockers or not. Friendly reminder: @benlangmuir, do you need any assistance from my side with it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 525557. ivanmurashko added a comment. rebase to latest LLVM main branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 525558. ivanmurashko added a comment. rebased to the latest LLVM main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files:

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 525570. ivanmurashko added a comment. removed header install, only lib install has been left after the change CC: @kadircet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8ad413f0d18: [RFC][clangd] Move preamble index out of document open critical path (authored by kuganv, committed by ivanmurashko). Repository:

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8536fb11e3d: [clang][HeaderSearch] Fix implicit module when using header maps (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko marked an inline comment as not done. ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/tool/CMakeLists.txt:11 + ClangdToolMain.cpp $ ) kadircet wrote: > we should move this into `clangdMain` target now Unfortunately it

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/tool/CMakeLists.txt:37 + +target_link_libraries(clangdMain + PRIVATE kadircet wrote: > you can merge this with the previous rule fixed Comment at:

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko added a comment. In D145302#4441334 , @kadircet wrote: > thanks LG and seems to be working in a couple build configurations I tried. > but there might still be breakages in different configs, so please be on the > watchout after landing

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 536577. ivanmurashko added a comment. Fixed clangd unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files:

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 535138. ivanmurashko added a comment. Rebase + apply suggestions from @kadircet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files:

[PATCH] D145302: [clangd] Add library for clangd main function

ivanmurashko updated this revision to Diff 535144. ivanmurashko added a comment. small fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145302/new/ https://reviews.llvm.org/D145302 Files: clang-tools-extra/clangd/tool/CMakeLists.txt

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 520096. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 520069. ivanmurashko added a comment. small fix at the lit-test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 520062. ivanmurashko added a comment. `split-file` was used for lit-test simplification (see @ChuanqiXu comment) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 520117. ivanmurashko added a comment. windows marked as non supported Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

ivanmurashko updated this revision to Diff 521580. ivanmurashko added a comment. typo fixed + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp