[PATCH] D26345: Extend small data threshold driver options to PPC target

jackoalan updated this revision to Diff 86088. jackoalan added a comment. Herald added a subscriber: nemanjai. Remove already-aliased option matchings; add test case for patch. https://reviews.llvm.org/D26345 Files: lib/Driver/Tools.cpp test/Driver/ppc-eabi-small-data.c Index:

[PATCH] D41534: Don't add empty InstalledDir as a candidate GCC location

jackoalan abandoned this revision. jackoalan added a comment. I've found that passing `--gcc-toolchain=/usr` results in the exact behavior I'm after. Feel free to reopen if desired. Repository: rC Clang https://reviews.llvm.org/D41534 ___

[PATCH] D41534: Don't add empty InstalledDir as a candidate GCC location

jackoalan created this revision. jackoalan added a reviewer: cfe-commits. I maintain a couple build tools based on Clang's Tooling framework. The tools are built and used directly out of the CMake binary directory (i.e. not installed in a meaningful way). This non-installed setup causes issues

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d37d0ea3485: [Support] Expand `CFGDIR` as the base directory in configuration files. (authored by jackoalan). Repository: rG LLVM Github

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added inline comments. Comment at: clang/docs/UsersManual.rst:920 +To generate paths relative to the configuration file, the `<@>` token may be +used. This will expand to the absolute path of the directory containing the sepavloff wrote: > Response

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added a comment. bump, review requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added a comment. > 1. It it possible to limit the new syntax to config files only? It would > avoid concerns of gcc compatibility. Yes, ultimately this use case only calls for extending config files. > Is it possible to use more understandable designation, like `` or > something

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

jackoalan updated this revision to Diff 396576. jackoalan added a comment. Update call parameters in `ExpandResponseFilesDatabase::expand` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files:

[PATCH] D115604: [Support] Expand `` as the base directory in response files.

jackoalan updated this revision to Diff 396410. jackoalan added a comment. Rebase, use the slightly more intuitive `` token to expand base paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files:

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

jackoalan marked an inline comment as done. jackoalan added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1099 +else + llvm::sys::path::append(ResponseFile, LHS); +ResponseFile.append(BasePath); sepavloff wrote: > What happens if ``

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

jackoalan updated this revision to Diff 396667. jackoalan marked 5 inline comments as done. jackoalan added a comment. Update ReadConfigFile test with additional `` expansion contexts (non-prefixed, non-suffixed, escaped in middle). CHANGES SINCE LAST ACTION

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

jackoalan updated this revision to Diff 396670. jackoalan added a comment. Add ReadConfigFile test case for multiple `` in one arg. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files:

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

jackoalan added a comment. Actually, I just thought of a possible limitation of using path-append when suffixing with something that isn't actually a path component. However, I cannot say how critical this limitation is. -Wl,-rpath,,foo.o This will cause a trailing `/` to be inserted after

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 396055. jackoalan added a comment. Make expansion token a parameter of `ExpandResponseFiles` and limit use to `readConfigFile`. Elaborate manual entry further and add entry to release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D115604: [Support] Expand `` as the base directory in configuration files.

jackoalan updated this revision to Diff 396561. jackoalan retitled this revision from "[Support] Expand `` as the base directory in response files." to "[Support] Expand `` as the base directory in configuration files.". jackoalan added a comment. Make `` constant at point of expansion. Use

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 393781. jackoalan added a comment. Fix ResponseFiles test for Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files: clang/docs/UsersManual.rst

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 393777. jackoalan added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add entry to user manual explaining the `<@>` token. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 393785. jackoalan added a comment. Test coverage for more than one `<@>` per arg. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files:

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added a comment. In D115604#3188392 , @kadircet wrote: > IIUC, the new behavior being introduced by this patch is not the ability of > having a way to refer to other files in a config/response file relative way, > but rather extending that

[PATCH] D116713: [clangd] Support configuration of inlay hints.

jackoalan added a comment. Assuming origin/maain is a branch typo and is no longer being tracked, would you please delete the upstream one in https://github.com/llvm/llvm-project/branches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116713/new/